[Qemu-devel] [PATCH] ide: coding style fix

2016-04-12 Thread Pavel Butsykin
Signed-off-by: Pavel Butsykin --- hw/ide/internal.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/ide/internal.h b/hw/ide/internal.h index eb006c2..d2c458f 100644 --- a/hw/ide/internal.h +++ b/hw/ide/internal.h @@ -338,7 +338,7 @@ enum ide_dma_cmd { IDE_DMA_RE

[Qemu-devel] [PATCH v3 04/10] virtio: migrate vdev->broken flag

2016-04-12 Thread Stefan Hajnoczi
Send a subsection if the vdev->broken flag is set. This allows live migration of broken virtio devices. The subsection is only sent if vdev->broken has been set. In most cases the flag will be clear and no subsection will be sent. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 19 +++

[Qemu-devel] [PATCH v3 02/10] include: update virtio_config.h Linux header

2016-04-12 Thread Stefan Hajnoczi
Bring in the VIRTIO_CONFIG_S_NEEDS_RESET device status bit definition. Signed-off-by: Stefan Hajnoczi --- include/standard-headers/linux/virtio_config.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/standard-headers/linux/virtio_config.h b/include/standard-headers/linux/virtio_c

[Qemu-devel] [PATCH v3 03/10] virtio: stop virtqueue processing if device is broken

2016-04-12 Thread Stefan Hajnoczi
QEMU prints an error message and exits when the device enters an invalid state. Terminating the process is heavy-handed. The guest may still be able to function even if there is a bug in a virtio guest driver. Moreover, exiting is a bug in nested virtualization where a nested guest could DoS oth

[Qemu-devel] [PATCH v3 10/10] virtio: handle virtqueue_get_head() errors

2016-04-12 Thread Stefan Hajnoczi
Stop processing the vring if virtqueue_get_head() fetches an out-of-bounds head index. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 4fe342a..663

[Qemu-devel] [PATCH v3 01/10] virtio: fix stray tab character

2016-04-12 Thread Stefan Hajnoczi
Fix a single occurrence of a tab character in a file that otherwise uses spaces for indentation. Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng --- v3: * Fix typo and clarify commit description [Markus] --- hw/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[Qemu-devel] [PATCH v3 00/10] virtio: avoid exit() when device enters invalid states

2016-04-12 Thread Stefan Hajnoczi
v3: * Patch 1: Fix typo and clarify commit description [Markus] * Use virtio_set_status() instead of open coding assignment [Cornelia] * Add live migration v2: * Add VIRTIO_CONFIG_S_NEEDS_RESET notification for VIRTIO 1.0 [Cornelia] (Note I've sent a Linux virtio_config.h patch to get the c

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread Sergey Fedorov
On 05/04/16 18:32, Alex Bennée wrote: > diff --git a/cpus.c b/cpus.c > index 46732a5..8d27fb0 100644 > --- a/cpus.c > +++ b/cpus.c (snip) > @@ -146,6 +147,48 @@ typedef struct TimersState { > } TimersState; > > static TimersState timers_state; > +static bool mttcg_enabled; > + > +static QemuO

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread Sergey Fedorov
On 12/04/16 16:03, Pavel Dovgalyuk wrote: >> From: mttcg-requ...@listserver.greensocs.com >> [mailto:mttcg-requ...@listserver.greensocs.com] >> On 12/04/16 15:50, KONRAD Frederic wrote: Yes, but users may like to have an option to disable MTTCG for some reason. I'm also concerned about i

Re: [Qemu-devel] [PATCH 8/9] Add memfd based hostmem

2016-04-12 Thread Igor Mammedov
On Tue, 12 Apr 2016 13:55:28 +0200 marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a new memory backend, similar to hostmem-file, except that it > doesn't need a file path, or hugepages directory permissions. It also > try to enforce memory sealing if available. > > This ba

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread Pavel Dovgalyuk
> From: mttcg-requ...@listserver.greensocs.com > [mailto:mttcg-requ...@listserver.greensocs.com] > On 12/04/16 15:50, KONRAD Frederic wrote: > >> Yes, but users may like to have an option to disable MTTCG for some > >> reason. I'm also concerned about icount mode: not sure how to account > >> virt

[Qemu-devel] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit

2016-04-12 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch modifies SoftFloat library so that it can be configured in run-time in relation to the meaning of signaling NaN bit, while, at the same time, strictly preserving its behavior on all existing platforms. Background: In floating-point calculations, there is a n

Re: [Qemu-devel] [Nbd] [PATCHv8] Improve documentation for TLS

2016-04-12 Thread Wouter Verhelst
On Tue, Apr 12, 2016 at 01:57:25PM +0100, Alex Bligh wrote: > > On 12 Apr 2016, at 13:40, Wouter Verhelst wrote: > > > Right, that sounds good. > > Great. I may look at that when the other doc patches are applied. > > On which note, back to $subject, how is PATCHv8? It's not being applied bec

Re: [Qemu-devel] [PATCH COLO-Frame v16 16/35] COLO: synchronize PVM's state to SVM periodically

2016-04-12 Thread Hailiang Zhang
On 2016/4/12 11:02, Li Zhijian wrote: On 04/08/2016 02:26 PM, zhanghailiang wrote: Do checkpoint periodically, the default interval is 200ms. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert --- v12: - Add Reviewed-by tag v11: - Fix wrong sleep tim

[Qemu-devel] [PATCH v4 7/9] target-mips: Add abs2008 flavor of .

2016-04-12 Thread Aleksandar Markovic
From: Aleksandar Markovic Updated handling of instuctions .. Note that legacy (pre-abs2008) ABS and NEG instructions are arithmetic (any NaN operand signals invalid operation), while abs2008 ones are non-arithmetic, always changing the sign bit, even for NaN-like operands. Details on these instru

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread Sergey Fedorov
On 12/04/16 15:50, KONRAD Frederic wrote: > > > Le 12/04/2016 14:42, Sergey Fedorov a écrit : >> On 12/04/16 14:59, Peter Maydell wrote: >>> On 12 April 2016 at 12:48, Alex Bennée wrote: Sergey Fedorov writes: > Maybe we'd better use existing qemu accelerator framework and > introduc

[Qemu-devel] [PATCH v4 2/9] softfloat: For Mips only, correct default NaN values

2016-04-12 Thread Aleksandar Markovic
From: Aleksandar Markovic Only for Mips platform, and only for cases when snan_bit_is_one is 0, correct default NaN values (in their 16-, 32-, and 64-bit flavors). For more info, see [1], page 84, Table 6.3 "Value Supplied When a New Quiet NaN Is Created", and [2], page 52, table 3.7 "Default Na

[Qemu-devel] [PATCH v4 9/9] target-mips: Clean up order of helpers for CVT..

2016-04-12 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch makes position of helpers for CVT.. consistent with position of helpers for ... Signed-off-by: Aleksandar Markovic --- target-mips/op_helper.c | 60 +++ 1 file changed, 30 insertions(+), 30 deletions(-) diff --

[Qemu-devel] [PATCH v4 8/9] target-mips: Add nan2008 flavor of ..

2016-04-12 Thread Aleksandar Markovic
From: Aleksandar Markovic New set of helpers for handling nan2008-syle versions of instructions ... Details on these instructions are presented in [1] p. 129, 130, 149, 155, 222, 223, 393, 394, 504, 505. [1] "MIPS® Architecture For Programmers Volume II-A: The MIPS64® Instruction Set Referen

[Qemu-devel] [PATCH v4 4/9] softfloat: Clean up hex constants capitalization in softfloat-specialize.h

2016-04-12 Thread Aleksandar Markovic
From: Aleksandar Markovic With this partch, capitals A, B, C, D, E, F are always used for hex constants in softfloat-specialize.h. The large latter size is chosen just beacause it is currently prevalent in this file. Signed-off-by: Aleksandar Markovic --- fpu/softfloat-specialize.h | 34

[Qemu-devel] [PATCH v4 0/9] target-mips: Initiate IEEE 754-2008 support

2016-04-12 Thread Aleksandar Markovic
From: Aleksandar Markovic v4 - Added code cleanup items: a. Capitalization of hex constants in softfloat-specialize.h; b. White spaces in softfloat-specialize.h; c. Order of Mips helpers for CVT... v3 - Patch series reorganized into 6 patches instead of 2. - Commit messag

[Qemu-devel] [PATCH v4 6/9] target-mips: Activate IEEE 274-2008 support

2016-04-12 Thread Aleksandar Markovic
From: Aleksandar Markovic 1) Definitions of Mips processors are updated to reflect supported IEEE-754-2008-related features. (file target-mips/translate_init.c) 2) Functions mips_cpu_reset() and msa_reset() are updated so that flag snan_bit_is_one is properly set for any Mips configuration

[Qemu-devel] [PATCH v4 3/9] softfloat: For Mips only, correct order in pickNaNMulAdd()

2016-04-12 Thread Aleksandar Markovic
From: Aleksandar Markovic Only for Mips platform, and only for cases when snan_bit_is_one is 0, correct the order of argument comparisons in pickNaNMulAdd(). For more info, see [2], page 53, section "3.5.3 NaN Propagation". [1] "MIPS® Architecture For Programmers Volume II-A: The MIPS64® In

[Qemu-devel] [PATCH v4 5/9] softfloat: Clean up white spaces in softfloat-specialize.h

2016-04-12 Thread Aleksandar Markovic
From: Aleksandar Markovic As the development of SoftFloat library took places, many contributors had different code styles, and the code was left with inconsistent style, difficult to read, and hard to maintain. This patch will make spaces around shift operators and braces consistent within file

Re: [Qemu-devel] [Xen-devel] [PATCH v2 2/3] xenfb: move xen_rmb to the correct location

2016-04-12 Thread David Vrabel
On 12/04/16 11:43, Wei Liu wrote: > It should be placed before first time producer and consumer are used. This change isn't necessary and is confusing as this is not what this barrier is for. The barrier needs to be between the load of prod and the load of the ring contents (there's even a commen

Re: [Qemu-devel] [Nbd] [PATCHv8] Improve documentation for TLS

2016-04-12 Thread Alex Bligh
On 12 Apr 2016, at 13:40, Wouter Verhelst wrote: > Right, that sounds good. Great. I may look at that when the other doc patches are applied. On which note, back to $subject, how is PATCHv8? -- Alex Bligh

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread KONRAD Frederic
Le 12/04/2016 14:42, Sergey Fedorov a écrit : On 12/04/16 14:59, Peter Maydell wrote: On 12 April 2016 at 12:48, Alex Bennée wrote: Sergey Fedorov writes: Maybe we'd better use existing qemu accelerator framework and introduce "-machine accel=mttcg" option? My worry would be breaking exis

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread Sergey Fedorov
On 12/04/16 14:48, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 05/04/16 18:32, Alex Bennée wrote: >>> diff --git a/qemu-options.hx b/qemu-options.hx >>> index a770086..4eca704 100644 >>> --- a/qemu-options.hx >>> +++ b/qemu-options.hx >>> @@ -3224,6 +3224,20 @@ Attach to existing xen domai

Re: [Qemu-devel] [PATCH] qdev property: cleanup

2016-04-12 Thread Cao jin
On 04/12/2016 04:20 PM, Markus Armbruster wrote: Here's my try rewording the comment (sticking to GTK-Doc conventions even though I dislike them): /** * @qdev_property_add_static: * @dev: Device to add the property to * @prop: The qdev property definition * @err: location to store er

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread Sergey Fedorov
On 12/04/16 14:59, Peter Maydell wrote: > On 12 April 2016 at 12:48, Alex Bennée wrote: >> Sergey Fedorov writes: >>> Maybe we'd better use existing qemu accelerator framework and introduce >>> "-machine accel=mttcg" option? >> My worry would be breaking existing code which assumes kvm | tcg. We

Re: [Qemu-devel] [Nbd] [PATCHv8] Improve documentation for TLS

2016-04-12 Thread Wouter Verhelst
On Tue, Apr 12, 2016 at 10:53:57AM +0100, Alex Bligh wrote: > Wouter, > > On 12 Apr 2016, at 10:20, Wouter Verhelst wrote: > > > To summarize, there are three ways for the connection to end: > > > > - The client wishes to end the session, and sends the appropriate > > termination message (OPT_

Re: [Qemu-devel] [PATCH 3/3] ide: really restart pending and in-flight atapi dma

2016-04-12 Thread Pavel Butsykin
On 12.04.2016 01:18, Eric Blake wrote: On 04/06/2016 12:40 AM, Denis V. Lunev wrote: From: Pavel Butsykin Restart of ATAPI DMA used to be unreachable, because the request to do so wasn't indicated in bus->error_status due to the lack of spare bits, and ide_restart_bh() would return early doing

Re: [Qemu-devel] [PATCH for-2.7 v6 1/2] QMP: add query-hotpluggable-cpus

2016-04-12 Thread Igor Mammedov
On Mon, 11 Apr 2016 11:14:27 -0500 Michael Roth wrote: > Quoting Igor Mammedov (2016-04-08 06:29:55) > > it will allow mgmt to query present and hotpluggable > > CPU objects, it is required from a target platform that > > wish to support command to implement and set > > MachineClass.query_hotplu

Re: [Qemu-devel] [PATCH] Whitelist sysinfo call

2016-04-12 Thread Miroslav Rezanina
- 元のメッセージ - > 差出人: "Eduardo Otubo" > 宛先: "Serge Hallyn" > Cc: mreza...@redhat.com, qemu-devel@nongnu.org, arm...@redhat.com > 送信済み: 2016年4月12日, 火曜日 午後 1:53:47 > 件名: Re: Re: [Qemu-devel] [PATCH] Whitelist sysinfo call > > On Mon, Apr 11, 2016 at 08=19=52PM +, Serge Hallyn wrote: > >

[Qemu-devel] [PATCH 8/9] Add memfd based hostmem

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau Add a new memory backend, similar to hostmem-file, except that it doesn't need a file path, or hugepages directory permissions. It also try to enforce memory sealing if available. This backend is mainly useful for easily sharing the memory with other processes, for exampl

[Qemu-devel] [PATCH 6/9] exec: remove qemu_set_ram_fd()

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau If the previous ivshmem patch is applied, qemu_set_ram_fd() is no longer used. Signed-off-by: Marc-André Lureau --- exec.c | 10 -- include/exec/ram_addr.h | 1 - 2 files changed, 11 deletions(-) diff --git a/exec.c b/exec.c index 8675b5e..ec7

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread Peter Maydell
On 12 April 2016 at 12:48, Alex Bennée wrote: > Sergey Fedorov writes: >> Maybe we'd better use existing qemu accelerator framework and introduce >> "-machine accel=mttcg" option? > > My worry would be breaking existing code which assumes kvm | tcg. We > will want to enable mttcg by default for c

[Qemu-devel] [PATCH 4/9] Add memory_region_init_ram_from_fd()

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau Add a new function to Initialize a RAM memory region with a mmap-ed file descriptor. Signed-off-by: Marc-André Lureau --- include/exec/memory.h | 20 memory.c | 16 2 files changed, 36 insertions(+) diff --git a/includ

[Qemu-devel] [PATCH 3/9] exec: split qemu_ram_alloc_from_file()

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau Add qemu_ram_alloc_from_fd(), which can be use to allocate ramblock from fd only. Signed-off-by: Marc-André Lureau --- exec.c | 45 ++--- include/exec/ram_addr.h | 3 +++ 2 files changed, 33 insertions(+), 15 del

[Qemu-devel] [PATCH 9/9] tests: use memfd in vhost-user-test

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau This will exercise the memfd memory backend and should generally be better for testing than memory-backend-file (thanks to anonymous files and sealing). Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 12 ++-- 1 file changed, 6 insertions(+), 6 de

[Qemu-devel] [PATCH 7/9] memfd: split qemu_memfd_alloc()

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/qemu/memfd.h | 1 + util/memfd.c | 19 ++- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/include/qemu/memfd.h b/include/qemu/memfd.h index 745a8c5..41c24d8 100644 --- a/include/qemu/m

[Qemu-devel] [PATCH 2/9] exec: split file_ram_alloc()

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau Move file opening part in a seperate function file_ram_open(). This allows for reuse of file_ram_alloc() with only a fd. Signed-off-by: Marc-André Lureau --- exec.c | 58 ++ 1 file changed, 34 insertions(+), 24 del

[Qemu-devel] [PATCH 5/9] RFC: ivshmem: use ram_from_fd()

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau Instead of writing our own mmap handling code, reuse the code from exec.c. RFC because memory_region_init_ram_from_fd() adds some restrictions (check for xen, kvm sync-mmu, etc) and changes (such as size alignment). In practice, this doesn't seem to hurt though. Signed-o

[Qemu-devel] [PATCH 1/9] exec: check kvm mmu notifiers earlier

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau Move kvm mmu notifiers check before calling file_ram_alloc(). This shouldn't change the validation logic. Signed-off-by: Marc-André Lureau --- exec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index c4f9036..dcc6632

[Qemu-devel] [PATCH 0/9] RFC: add memfd memory backend

2016-04-12 Thread marcandre . lureau
From: Marc-André Lureau Add a new memory backend, similar to hostmem-file, except that it doesn't need a file path, or hugepages directory permissions. It also try to enforce memory sealing if available. This backend is mainly useful for easily sharing the memory with other processes, for exampl

Re: [Qemu-devel] [PATCH] Whitelist sysinfo call

2016-04-12 Thread Eduardo Otubo
On Mon, Apr 11, 2016 at 08=19=52PM +, Serge Hallyn wrote: > Quoting mreza...@redhat.com (mreza...@redhat.com): > > From: Miroslav Rezanina > > > > Newer version of nss-softokn libraries (> 3.16.2.3) use sysinfo call > > so qemu using rbd image hang after start when run in sandbox mode. > > >

Re: [Qemu-devel] [PATCH v2 1/2] seccomp: Whitelist cacheflush since 2.2.0 not 2.2.3

2016-04-12 Thread Eduardo Otubo
On Fri, Apr 08, 2016 at 02=16=33PM +0100, James Hogan wrote: > The cacheflush system call (found on MIPS and ARM) has been included in > the libseccomp header since 2.2.0, so include it back to that version. > Previously it was only enabled since 2.2.3 since that is when it was > enabled properly f

Re: [Qemu-devel] [PATCH v2 2/2] configure: Enable seccomp sandbox for MIPS

2016-04-12 Thread Eduardo Otubo
On Fri, Apr 08, 2016 at 02=16=34PM +0100, James Hogan wrote: > Enable seccomp on MIPS since libseccomp version 2.2.0 when MIPS support > was first added. > > Signed-off-by: James Hogan > Reviewed-by: Andrew Jones > Cc: Eduardo Otubo > Cc: Aurelien Jarno > --- > configure | 3 +++ > 1 file cha

Re: [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init()

2016-04-12 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 04/10/2016 12:38 PM, Cao jin wrote: >> >> >> On 04/10/2016 04:20 PM, Marcel Apfelbaum wrote: >> >>> >>> Hi, >>> I'll let Markus to continue the review, it brings very valuable >>> information, >>> I will only try to answer the questions below. >>> Several questi

Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG

2016-04-12 Thread Alex Bennée
Sergey Fedorov writes: > On 05/04/16 18:32, Alex Bennée wrote: >> diff --git a/qemu-options.hx b/qemu-options.hx >> index a770086..4eca704 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -3224,6 +3224,20 @@ Attach to existing xen domain. >> xend will use this when starting QEMU (

Re: [Qemu-devel] [PATCH] docs/atomics.txt: Update pointer to linux macro

2016-04-12 Thread Peter Maydell
On 12 April 2016 at 12:42, Marc-André Lureau wrote: > Hi > > On Mon, Apr 11, 2016 at 7:30 PM, Pranith Kumar wrote: >> - atomic_read and atomic_set in Linux give no guarantee at all; >>atomic_read and atomic_set in QEMU include a compiler barrier >> - (similar to the ACCESS_ONCE macro in Lin

Re: [Qemu-devel] [PATCH] docs/atomics.txt: Update pointer to linux macro

2016-04-12 Thread Marc-André Lureau
Hi On Mon, Apr 11, 2016 at 7:30 PM, Pranith Kumar wrote: > Add a missing end brace and update doc to point to the latest access > macro. ACCESS_ONE() is deprecated. ONE/ONCE > > Signed-off-by: Pranith Kumar > --- > docs/atomics.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [Qemu-devel] [Nbd] NBD_CMD_DISC

2016-04-12 Thread Alex Bligh
On 12 Apr 2016, at 11:34, Daniel P. Berrange wrote: > On Tue, Apr 12, 2016 at 10:48:20AM +0100, Daniel P. Berrange wrote: >> On Sun, Apr 10, 2016 at 10:49:00AM +0100, Alex Bligh wrote: >>> (Daniel: if you want to replicate the issue, just run qemu-img info >>> against my gonbdserver with TLS. Ev

Re: [Qemu-devel] [PATCH 0/3] bitsized task for glib conversion

2016-04-12 Thread Wei, Jiangang
ping... Any comments? Thanks in advance. On Thu, 2016-04-07 at 10:46 +0800, Wei Jiangang wrote: > The series used to change basename and dirname to > g_path_get_basename() and g_path_get_dirname() respectively. > > Refer to http://wiki.qemu.org/BiteSizedTasks#API_conversion > > *** BLURB HERE ***

[Qemu-devel] [PATCH v2 0/3] xenfb bug fixes and cleanup

2016-04-12 Thread Wei Liu
Wei Liu (3): xenfb: use the correct condition to avoid excessive looping xenfb: move xen_rmb to the correct location xenfb: remove out_cons in xenfb_handle_events hw/display/xenfb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.1.4

[Qemu-devel] [PATCH v2 2/3] xenfb: move xen_rmb to the correct location

2016-04-12 Thread Wei Liu
It should be placed before first time producer and consumer are used. Signed-off-by: Wei Liu --- Cc: Stefano Stabellini Cc: Anthony Perard Backport candidate to our own tree. --- hw/display/xenfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/xenfb.c b/hw/dis

[Qemu-devel] [PATCH v2 1/3] xenfb: use the correct condition to avoid excessive looping

2016-04-12 Thread Wei Liu
In commit ac0487e1 ("xenfb.c: avoid expensive loops when prod <= out_cons"), ">=" was used. In fact, a full ring is a legit state. Correct the test to use ">". Reported-by: "Hao, Xudong" Signed-off-by: Wei Liu Tested-by: "Hao, Xudong" Acked-by: Anthony Perard --- Cc: Stefano Stabellini Cc: An

[Qemu-devel] [PATCH v2 3/3] xenfb: remove out_cons in xenfb_handle_events

2016-04-12 Thread Wei Liu
The variable out_cons was only used to temporarily hold the consumer index. Use cons directly to simplify code a bit. No functional change introduced. Signed-off-by: Wei Liu --- Cc: Stefano Stabellini Cc: Anthony Perard --- hw/display/xenfb.c | 8 1 file changed, 4 insertions(+), 4 d

Re: [Qemu-devel] [Nbd] NBD_CMD_DISC

2016-04-12 Thread Daniel P. Berrange
On Tue, Apr 12, 2016 at 10:48:20AM +0100, Daniel P. Berrange wrote: > On Sun, Apr 10, 2016 at 10:49:00AM +0100, Alex Bligh wrote: > > (Daniel: if you want to replicate the issue, just run qemu-img info > > against my gonbdserver with TLS. Every fifth NBD_CMD_DISC doesn't > > get through before the

[Qemu-devel] [PATCH] MAINTAINERS: update Xen mailing list address

2016-04-12 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Stefano Stabellini Cc: Anthony Perard This is the canonical address. It also seems that this is the most reliable address. --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9277fbf..df2aa2a 100644

Re: [Qemu-devel] [PATCH 1/2] xenfb: use the correct condition to avoid excessive looping

2016-04-12 Thread Anthony PERARD
On Tue, Apr 12, 2016 at 10:57:16AM +0100, Wei Liu wrote: > In commit ac0487e1 ("xenfb.c: avoid expensive loops when prod <= > out_cons"), ">=" was used. In fact, a full ring is a legit state. > Correct the test to use ">". > > Reported-by: "Hao, Xudong" > Signed-off-by: Wei Liu > Tested-by: "Hao

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xenfb: remove out_cons in xenfb_handle_events

2016-04-12 Thread Wei Liu
On Tue, Apr 12, 2016 at 10:59:53AM +0100, Andrew Cooper wrote: > On 12/04/16 10:57, Wei Liu wrote: > > The variable out_cons was only used to temporarily hold the consumer > > index. Use cons directly to simplify code a bit. > > > > No functional change introduced. > > > > Signed-off-by: Wei Liu >

[Qemu-devel] KVM call for agenda for 2016-04-26

2016-04-12 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xenfb: remove out_cons in xenfb_handle_events

2016-04-12 Thread Andrew Cooper
On 12/04/16 10:57, Wei Liu wrote: > The variable out_cons was only used to temporarily hold the consumer > index. Use cons directly to simplify code a bit. > > No functional change introduced. > > Signed-off-by: Wei Liu > --- > Cc: Stefano Stabellini > Cc: Anthony Perard > --- > hw/display/xenf

Re: [Qemu-devel] KVM call for agenda for 2016-04-12

2016-04-12 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. Hi As there are no topics, call got cancelled. Happy Hacking. > > After discussions on the QE

[Qemu-devel] [PATCH 2/2] xenfb: remove out_cons in xenfb_handle_events

2016-04-12 Thread Wei Liu
The variable out_cons was only used to temporarily hold the consumer index. Use cons directly to simplify code a bit. No functional change introduced. Signed-off-by: Wei Liu --- Cc: Stefano Stabellini Cc: Anthony Perard --- hw/display/xenfb.c | 8 1 file changed, 4 insertions(+), 4 d

[Qemu-devel] [PATCH 0/2] xenfb bug fix and clean up

2016-04-12 Thread Wei Liu
Wei Liu (2): xenfb: use the correct condition to avoid excessive looping xenfb: remove out_cons in xenfb_handle_events hw/display/xenfb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.1.4

[Qemu-devel] [PATCH 1/2] xenfb: use the correct condition to avoid excessive looping

2016-04-12 Thread Wei Liu
In commit ac0487e1 ("xenfb.c: avoid expensive loops when prod <= out_cons"), ">=" was used. In fact, a full ring is a legit state. Correct the test to use ">". Reported-by: "Hao, Xudong" Signed-off-by: Wei Liu Tested-by: "Hao, Xudong" --- Cc: Stefano Stabellini Cc: Anthony Perard Backport ca

Re: [Qemu-devel] [Nbd] [PATCHv8] Improve documentation for TLS

2016-04-12 Thread Alex Bligh
Wouter, On 12 Apr 2016, at 10:20, Wouter Verhelst wrote: > To summarize, there are three ways for the connection to end: > > - The client wishes to end the session, and sends the appropriate > termination message (OPT_ABORT or CMD_DISC). This is a normal > disconnect. > - Either peer violates

Re: [Qemu-devel] [PULL 0/3] Block patches

2016-04-12 Thread Peter Maydell
On 12 April 2016 at 09:30, Stefan Hajnoczi wrote: > The following changes since commit dc1ffa66619b3661f17a309b0aa8d65d8d29583f: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20160411' into staging (2016-04-11 > 14:37:53 +0100) > > are available in the git repositor

Re: [Qemu-devel] post-copy is broken?

2016-04-12 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > Hi David, > > I used the latest qemu code (commit id: 4e71220387e88a22) and kernel (v4.5) > to test the post-copy, and find the guest get crashed after live migration, > no matter I did a local live migration or live migration between two hosts. I >

[Qemu-devel] [PATCH] input-linux: refine mouse detection

2016-04-12 Thread Gerd Hoffmann
Read absolute and relative axis information, only classify devices as mouse/tablet in case the x axis is present. Signed-off-by: Gerd Hoffmann --- ui/input-linux.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/ui/input-linux.c b/ui/input-linu

[Qemu-devel] post-copy is broken?

2016-04-12 Thread Li, Liang Z
Hi David, I used the latest qemu code (commit id: 4e71220387e88a22) and kernel (v4.5) to test the post-copy, and find the guest get crashed after live migration, no matter I did a local live migration or live migration between two hosts. I just ran the stress as the workload in guest. It seems

Re: [Qemu-devel] [Nbd] [PATCHv8] Improve documentation for TLS

2016-04-12 Thread Wouter Verhelst
On Tue, Apr 12, 2016 at 08:47:49AM +0100, Alex Bligh wrote: > > On 12 Apr 2016, at 07:01, Wouter Verhelst wrote: > > > hat doesn't mean OPT_ABORT not having a reply is necessarily a good > > idea. Since it's only used by reference nbd-client in just one use case > > at this point, I don't think

Re: [Qemu-devel] Implementing 9p for Windows host

2016-04-12 Thread Markus Armbruster
Michael Fritscher writes: > Hello Greg, > > thanks for your answer! Yes, I already jumped in - I was surprised how > fast it went. I was afraid of much bigger problems ;-) I've a already > a V2 nearly ready :-) As a teaser: Fixed read/write support and the > possibility to execute binaries from t

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-12 Thread Gonglei (Arei)
Hi Cornelia, Thank you so much for your review :) > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Tuesday, April 12, 2016 4:00 PM > Subject: Re: [RFC v2] virtio-crypto specification > > On Tue, 5 Apr 2016 09:14:09 + > "Gonglei (Arei)" wrote: > > > > Virti

Re: [Qemu-devel] [PATCH v2 12/13] intel_iommu: ioapic: IR support for emulated IOAPIC

2016-04-12 Thread Peter Xu
On Mon, Apr 11, 2016 at 10:22:18PM -0700, Jan Kiszka wrote: > On 2016-04-11 02:19, Peter Xu wrote: > > diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c > > index 378e663..d963d45 100644 > > --- a/hw/intc/ioapic.c > > +++ b/hw/intc/ioapic.c > > @@ -57,6 +57,8 @@ static void ioapic_service(IOAPICComm

Re: [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init()

2016-04-12 Thread Markus Armbruster
Cao jin writes: > Hi > > On 04/08/2016 04:44 PM, Markus Armbruster wrote: > >>> diff --git a/hw/ide/ich.c b/hw/ide/ich.c >>> index 0a13334..db4fdb5 100644 >>> --- a/hw/ide/ich.c >>> +++ b/hw/ide/ich.c >>> @@ -146,7 +146,7 @@ static void pci_ich9_ahci_realize(PCIDevice *dev, Error >>> **errp) >>>

[Qemu-devel] [PULL 3/3] MAINTAINERS: Add Fam Zheng as a co-maintainer of block I/O path

2016-04-12 Thread Stefan Hajnoczi
From: Fam Zheng As agreed with Stefan, I'm listing myself a co-maintainer of block I/O path and assist with the maintainership. Signed-off-by: Fam Zheng Message-id: 1459849105-7767-1-git-send-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 inserti

[Qemu-devel] [PULL 0/3] Block patches

2016-04-12 Thread Stefan Hajnoczi
The following changes since commit dc1ffa66619b3661f17a309b0aa8d65d8d29583f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160411' into staging (2016-04-11 14:37:53 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-requ

[Qemu-devel] [PULL 2/3] mirror: Replace bdrv_drain(bs) with bdrv_co_drain(bs)

2016-04-12 Thread Stefan Hajnoczi
From: Fam Zheng Suggested-by: Stefan Hajnoczi Signed-off-by: Fam Zheng Message-id: 1459855253-5378-3-git-send-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index f64db

[Qemu-devel] [PULL 1/3] block: Fix bdrv_drain in coroutine

2016-04-12 Thread Stefan Hajnoczi
From: Fam Zheng Using the nested aio_poll() in coroutine is a bad idea. This patch replaces the aio_poll loop in bdrv_drain with a BH, if called in coroutine. For example, the bdrv_drain() in mirror.c can hang when a guest issued request is pending on it in qemu_co_mutex_lock(). Mirror coroutin

Re: [Qemu-devel] [ RFC Patch v4 2/3] virtio-net rsc: support coalescing ipv4 tcp traffic

2016-04-12 Thread Michael S. Tsirkin
On Mon, Apr 04, 2016 at 03:25:55AM +0800, w...@redhat.com wrote: > From: Wei Xu > > All the data packets in a tcp connection will be cached to a big buffer > in every receive interval, and will be sent out via a timer, the > 'virtio_net_rsc_timeout' controls the interval, the value will influent

Re: [Qemu-devel] [PATCH] qdev property: cleanup

2016-04-12 Thread Markus Armbruster
Cao jin writes: > On 04/08/2016 07:17 PM, Markus Armbruster wrote: > >>> - * Static properties access data in a struct. The actual type of the >>> - * property and the field depends on the property type. >>> + * Static properties access data in a struct. The actual type of >>> ObjectProperty >>

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-12 Thread Cornelia Huck
On Tue, 5 Apr 2016 09:14:09 + "Gonglei (Arei)" wrote: > Virtio-crypto device Spec > > 1 Crypto Device > The virtio crypto device is a virtual crypto device (ie. hardware crypto > accelerator card). The encryption and decryption requests of are placed in > the data que

[Qemu-devel] [PATCH v2] [WIP] [RFC ]Add initial 9pfs support for Windows hosts v2

2016-04-12 Thread Michael Fritscher
It was tested on Windows & Linux hosts, on the later no obvious regressions could be found. The guest was a Knoppix 7.6.0 live cd. This is WIP and a RFC - it isn't meant to be upstreamed yet. The error_printf are only for debugging and will be deleted in the final patch. There are some comments

Re: [Qemu-devel] [Nbd] [PATCHv8] Improve documentation for TLS

2016-04-12 Thread Alex Bligh
On 12 Apr 2016, at 07:01, Wouter Verhelst wrote: > hat doesn't mean OPT_ABORT not having a reply is necessarily a good > idea. Since it's only used by reference nbd-client in just one use case > at this point, I don't think it's particularly bad to change the > definition to say that the server

<    1   2