Re: [Qemu-devel] [PATCH for-2.7 v2 04/17] block: Introduce image file locking

On 04/18/2016 04:33 AM, Fam Zheng wrote: On Sun, 04/17 01:29, Max Reitz wrote: On 15.04.2016 05:27, Fam Zheng wrote: Block drivers can implement this new operation .bdrv_lockf to actually lock the image in the protocol specific way. Signed-off-by: Fam Zheng --- block.c

Re: [Qemu-devel] [PATCH for-2.7 v2 05/17] raw-posix: Implement .bdrv_lockf

On 04/18/2016 04:12 AM, Fam Zheng wrote: On Sat, 04/16 16:29, Denis V. Lunev wrote: On 04/15/2016 06:27 AM, Fam Zheng wrote: virtlockd in libvirt locks the first byte, we lock byte 1 to avoid the intervene. Suggested-by: "Daniel P. Berrange" Signed-off-by: Fam Zheng

[Qemu-devel] [PULL 3/3] ppc: Fix migration of the XER register

From: Thomas Huth env->xer only holds the lower bits of the XER register nowadays, the SO, OV and CA bits are stored in separate variables (see the function cpu_write_xer() for details). Since the migration code currently only reads the "xer" variable, the upper bits are lost

[Qemu-devel] [PULL 2/3] ppc: Fix the bad exception NIP value and the range check in LSWX

From: Thomas Huth The range checks in the LSWX instruction are completely insufficient: They do not take the wrap-around case into account, and the check "reg < rx" should be "reg <= rx" instead. Fix it by using the new lsw_reg_in_range() helper function that is already used

[Qemu-devel] [PULL 1/3] ppc: Fix the range check in the LSWI instruction

From: Thomas Huth There are two issues: First, the number of registers that are used has to be calculated with "(nb + 3) / 4" (i.e. round always up, not down). Second, the "start <= ra && (start + nr - 32) > ra" condition for the wrap-around case is wrong: It has to be tested

[Qemu-devel] [PULL 0/3] ppc-for-2.6 queue 20160418

The following changes since commit c7b45f12828c1ba7105dbc029c63d7de68eaa91c: Merge remote-tracking branch 'remotes/armbru/tags/pull-backends-2016-04-15' into staging (2016-04-15 17:43:34 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git

Re: [Qemu-devel] [PATCH for-2.6] ppc: Fix migration of the XER register

On Fri, Apr 15, 2016 at 11:03:00AM +0200, Thomas Huth wrote: > env->xer only holds the lower bits of the XER register nowadays, the > SO, OV and CA bits are stored in separate variables (see the function > cpu_write_xer() for details). Since the migration code currently only > reads the "xer"

Re: [Qemu-devel] [1/3] powerpc: scan_features() updates incorrect bits

On Sat, 2016-04-16 at 00:27 +1000, Michael Ellerman wrote: > On Fri, 2016-15-04 at 02:06:13 UTC, Unknown sender due to SPF wrote: > > The real LE feature entry in the ibm_pa_feature struct has the > > wrong number of elements. Instead of checking for byte 5, bit 0, > > we check for byte 0, bit 0,

Re: [Qemu-devel] [1/3] powerpc: scan_features() updates incorrect bits

On Fri, 2016-15-04 at 02:06:13 UTC, Unknown sender due to SPF wrote: > The real LE feature entry in the ibm_pa_feature struct has the > wrong number of elements. Instead of checking for byte 5, bit 0, > we check for byte 0, bit 0, and we also incorrectly update cpu user > feature bit 5. > > diff

Re: [Qemu-devel] [PATCH v3 12/13] q35: ioapic: add support for split irqchip and irqfd

On Fri, Apr 15, 2016 at 05:31:58PM +0200, Radim Krčmář wrote: > 2016-04-15 11:31+0800, Peter Xu: > > This patch allows Intel IR work with splitted irqchip. Two more fields > > are added to IOAPICCommonState to support the translation process (For > > future AMD IR support, we will need to provide

Re: [Qemu-devel] [PATCH v3 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

On Sat, Apr 16, 2016 at 07:26:50PM -0700, Jan Kiszka wrote: > Hi Peter, > > series no longer applies to git master. What was the baseline? Do you > have a public git repo as well? Yep, since I missed the first patch. Please check v4 later. Sorry! -- peterx

Re: [Qemu-devel] [PATCH v3 02/13] intel_iommu: set IR bit for ECAP register

On Sat, Apr 16, 2016 at 07:30:25PM -0700, Jan Kiszka wrote: > On 2016-04-14 20:31, Peter Xu wrote: > > Enable IR in IOMMU Extended Capability register. > > > > Signed-off-by: Peter Xu > > --- > > hw/i386/intel_iommu.c | 7 +++ > > hw/i386/intel_iommu_internal.h |

Re: [Qemu-devel] [PATCH for-2.7 v2 04/17] block: Introduce image file locking

On Sat, 04/16 16:22, Denis V. Lunev wrote: > On 04/15/2016 06:27 AM, Fam Zheng wrote: > >Block drivers can implement this new operation .bdrv_lockf to actually lock > >the > >image in the protocol specific way. > > > >Signed-off-by: Fam Zheng > >--- > > block.c

Re: [Qemu-devel] [PATCH] block: Inactivate all nodes at migration source

On Fri, 04/15 17:11, Kevin Wolf wrote: > Am 15.04.2016 um 05:11 hat Fam Zheng geschrieben: > > qcow2 is not necessarily the top layer node. Since bdrv_inactivate() > > doesn't recurse, we should ensure all block nodes are inactivated. > > > > Signed-off-by: Fam Zheng > > Hm, I

Re: [Qemu-devel] [PATCH for-2.7 v2 04/17] block: Introduce image file locking

On Sun, 04/17 01:29, Max Reitz wrote: > On 15.04.2016 05:27, Fam Zheng wrote: > > Block drivers can implement this new operation .bdrv_lockf to actually lock > > the > > image in the protocol specific way. > > > > Signed-off-by: Fam Zheng > > --- > > block.c

Re: [Qemu-devel] [PATCH for-2.7 v2 05/17] raw-posix: Implement .bdrv_lockf

On Sat, 04/16 16:29, Denis V. Lunev wrote: > On 04/15/2016 06:27 AM, Fam Zheng wrote: > >virtlockd in libvirt locks the first byte, we lock byte 1 to avoid > >the intervene. > > > >Suggested-by: "Daniel P. Berrange" > >Signed-off-by: Fam Zheng > >--- > >

Re: [Qemu-devel] [PATCH for-2.7 v2 05/17] raw-posix: Implement .bdrv_lockf

On Sun, 04/17 20:27, Richard W.M. Jones wrote: > On Fri, Apr 15, 2016 at 11:27:55AM +0800, Fam Zheng wrote: > > virtlockd in libvirt locks the first byte, we lock byte 1 to avoid > > the intervene. > > +static int raw_lockf(BlockDriverState *bs, BdrvLockfCmd cmd) > > +{ > > + > > +BDRVRawState

Re: [Qemu-devel] [PATCH v1 2/2] block: remove redundant stats of block_acct_start()

On 04/17/2016 06:11 AM, Max Reitz wrote: I'd like to say that my inertia is keeping me from applying this patch, but I'd feel like a hypocrite for saying that, considering it would have taken much less time than writing this response... Pls feel free to ignore this patch, i just went through

Re: [Qemu-devel] [PATCH v1 1/2] block: fix description of @stats

On 04/17/2016 05:59 AM, Max Reitz wrote: On 15.04.2016 07:46, Changlong Xie wrote: Qemu does not support "info blockstats" now. It doesn't? Mine is more than happy to accept that command: $ x86_64-softmmu/qemu-system-x86_64 -nodefaults \ -drive if=none,id=drv0,driver=null-co \

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

On 04/16/16 01:31, Paolo Bonzini wrote: > > Right, but there's always the point about people that use heterogeneous > hosts and cannot pass rdrand/rdseed to the guest. For these, we should > add a QEMU driver that uses rdrand/rdseed, and thus decouples virtio-rng > from the host /dev/*

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

On 04/16/16 01:31, Paolo Bonzini wrote: > > Right, but there's always the point about people that use heterogeneous > hosts and cannot pass rdrand/rdseed to the guest. For these, we should > add a QEMU driver that uses rdrand/rdseed, and thus decouples virtio-rng > from the host /dev/*

[Qemu-devel] [PATCH] ui/gtk: copy to clipboard support

This adds a menu item to copy current selection to clipboard. Seems handy for copying out guest error messages. Signed-off-by: Michael S. Tsirkin --- ui/gtk.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index f372a6d..83af491 100644

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

Greg Kurz writes: > On Tue, 15 Mar 2016 00:02:48 +0800 > Jevon Qiao wrote: > >> Ceph as a promising unified distributed storage system is widely used in the >> world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and >> object

Re: [Qemu-devel] [PATCH for-2.7 v2 05/17] raw-posix: Implement .bdrv_lockf

On Fri, Apr 15, 2016 at 11:27:55AM +0800, Fam Zheng wrote: > virtlockd in libvirt locks the first byte, we lock byte 1 to avoid > the intervene. > +static int raw_lockf(BlockDriverState *bs, BdrvLockfCmd cmd) > +{ > + > +BDRVRawState *s = bs->opaque; > +int ret; > +struct flock fl =

Re: [Qemu-devel] [PATCH for-2.7 00/15] block: Lock images when opening

On Wed, Apr 13, 2016 at 05:09:49PM +0800, Fam Zheng wrote: > Underneath is the fcntl syscall that locks the local file, similar to what is > already used in libvirt virtlockd. Also because of that, we cannot directly > apply fcntl lock on the image file itself, instead we open and lock >

Re: [Qemu-devel] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit

Hi, Leon, I cannot say thank you enough for all your valuable feedback. Just wanted to give you a heads up that in the next version of this patch series (planned for tomorrow (Monday) or the day after tomorrow), I am going to integrate all your suggestions from this thread, including name

[Qemu-devel] [PATCH] ehci: make idt processing more robust

This patch causes a regression in FreeBSD guests. Kernel dmesg reports: usbus3: Run timeout ehci0: USB init failed err=18 and USB 2.0 passthrough does not work. USB 1.0 still works though. On a (possibly) related note, choosing any machine type above pc-i440fx-2.0 causes 100% CPU in host.

[Qemu-devel] [PATCH] usb-mtp: fix usb_mtp_get_device_info so that libmtp on the guest doesn't complain

If an application uses libmtp on the guest system, it will complain with the warning message: LIBMTP WARNING: VendorExtensionID: LIBMTP WARNING: VendorExtensionDesc: (null) LIBMTP WARNING: this typically means the device is PTP (i.e. a camera) but not a MTP device at all. Trying to

Re: [Qemu-devel] [PATCH v3 12/13] q35: ioapic: add support for split irqchip and irqfd

On Sat, Apr 16, 2016 at 07:44:12PM -0700, Jan Kiszka wrote: > On 2016-04-14 20:31, Peter Xu wrote: > > This patch allows Intel IR work with splitted irqchip. Two more fields > > are added to IOAPICCommonState to support the translation process (For > > future AMD IR support, we will need to

Re: [Qemu-devel] [PATCH v2] Use frame->retcode instead of frame address for alpha target restorer

Hello all: I am very sorry for delay finishing tilegx floating points insns. The reason is that during these days (I guess, until 2016-05-01), I have no any free time. - During these days, I am often not at home (sleep in a hotel near the office), and often work in the weekend. - It is

[Qemu-devel] [PATCH v2] qdev: Clean up around properties

include: 1. remove unnecessary declaration of static function 2. fix inconsistency between comment and function name, and typo OOM->QOM 2. update comments of functions, use uniform format(GTK-Doc style) Signed-off-by: Cao jin --- changelog: 1. Use uniform comment

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

On Fri, Apr 15, 2016 at 05:39:33PM +0200, Markus Armbruster wrote: > [Context restored] > > "Michael S. Tsirkin" writes: > > > On Thu, Apr 14, 2016 at 01:29:20PM +0200, Markus Armbruster wrote: > >> The next use case to consider is a user picking a new name for a new > >>