Re: [Qemu-devel] [PATCH COLO-Frame v16 32/35] net: Add notifier/callback for netdev init

2016-04-26 Thread Jason Wang
On 04/21/2016 08:30 AM, Hailiang Zhang wrote: > ping ... ? > > Hi Jason, > > Any comments on the net parts ? Looks good overall, just few nits. Thanks > > Thanks, > Hailiang > > On 2016/4/8 14:26, zhanghailiang wrote: >> We can register some callback for this notifier, >> this will be used by

Re: [Qemu-devel] [PATCH] net/tap: Allocating Large sized arrays to heap

2016-04-26 Thread Jason Wang
On 04/26/2016 09:26 AM, Zhou Jie wrote: > net_init_tap has a huge stack usage of 8192 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Zhou Jie > --- > net/tap.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/net/tap.c b/net/t

Re: [Qemu-devel] [PATCH] net: mipsnet: check packet length against buffer

2016-04-26 Thread Jason Wang
On 04/07/2016 06:26 PM, P J P wrote: > From: Prasad J Pandit > > When receiving packets over MIPSnet network device, it uses > receive buffer of size 1514 bytes. In case the controller > accepts large(MTU) packets, it could lead to memory corruption. > Add check to avoid it. > > Reported by: Ol

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Peter Xu
On Mon, Apr 25, 2016 at 09:24:12AM +0200, Jan Kiszka wrote: > On 2016-04-25 09:18, Peter Xu wrote: > > On Mon, Apr 25, 2016 at 07:16:19AM +0200, Jan Kiszka wrote: > >> On 2016-04-19 10:38, Peter Xu wrote: > > > > [...] > > > >>> By default, IR is disabled to be better compatible with current > >>

Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-26 Thread Gerd Hoffmann
On Fr, 2016-04-22 at 14:02 +0100, Richard W.M. Jones wrote: > v4 -> v5: > > * Fix the initrd loading problem by fixing the get_e801_addr >function so it really reads the values from the BIOS. > > Previously the function always returned 16MB, and so it only happened > to work for initrd sizes

Re: [Qemu-devel] [PATCH] net/tap: Allocating Large sized arrays to heap

2016-04-26 Thread Christian Borntraeger
On 04/26/2016 03:26 AM, Zhou Jie wrote: > net_init_tap has a huge stack usage of 8192 bytes approx. > Moving large arrays to heap to reduce stack usage. I am wondering. Why is 8k a problem for a user space program? Please note that malloc/new like allocations are much more expensive than stack a

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-26 Thread Igor Mammedov
On Tue, 26 Apr 2016 10:39:23 +0530 Bharata B Rao wrote: > On Mon, Apr 25, 2016 at 11:20:50AM +0200, Igor Mammedov wrote: > > On Wed, 16 Mar 2016 10:11:54 +0530 > > Bharata B Rao wrote: > > > > > On Wed, Mar 16, 2016 at 12:36:05PM +1100, David Gibson wrote: > > > > On Tue, Mar 15, 2016 at 10

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Jan Kiszka
On 2016-04-26 09:34, Peter Xu wrote: > On Mon, Apr 25, 2016 at 09:24:12AM +0200, Jan Kiszka wrote: >> On 2016-04-25 09:18, Peter Xu wrote: >>> On Mon, Apr 25, 2016 at 07:16:19AM +0200, Jan Kiszka wrote: On 2016-04-19 10:38, Peter Xu wrote: >>> >>> [...] >>> > By default, IR is disabled to

Re: [Qemu-devel] [PATCH for-2.7 v2 02/17] qapi: Add lock-image in blockdev-add options

2016-04-26 Thread Fam Zheng
On Sat, 04/16 13:48, Denis V. Lunev wrote: > On 04/15/2016 06:27 AM, Fam Zheng wrote: > > To allow overriding the default locking behavior when opening the image. > > > > Signed-off-by: Fam Zheng > > --- > > qapi/block-core.json | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) >

[Qemu-devel] [PATCH] hw/net/virtio-net: Allocating Large sized arrays to heap

2016-04-26 Thread Zhou Jie
virtio_net_flush_tx has a huge stack usage of 16392 bytes approx. Moving large arrays to heap to reduce stack usage. Signed-off-by: Zhou Jie --- hw/net/virtio-net.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c inde

[Qemu-devel] [PATCH] display: vga: add check to limit display width

2016-04-26 Thread P J P
From: Prasad J Pandit In vga_draw_graphic, display width could exceed the maximum range of VBE_DISPI_MAX_XRES(16000). This could lead to possible integer overflows. Add check to avoid it. Reported-by: Zuozhi Fzz Signed-off-by: Prasad J Pandit --- hw/display/vga.c | 3 +++ 1 file changed, 3 in

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Jan Kiszka
On 2016-04-26 09:57, Jan Kiszka wrote: > On 2016-04-26 09:34, Peter Xu wrote: >> On Mon, Apr 25, 2016 at 09:24:12AM +0200, Jan Kiszka wrote: >>> On 2016-04-25 09:18, Peter Xu wrote: On Mon, Apr 25, 2016 at 07:16:19AM +0200, Jan Kiszka wrote: > On 2016-04-19 10:38, Peter Xu wrote:

Re: [Qemu-devel] [PATCH for 2.7 1/1] qcow2: improve qcow2_co_write_zeroes()

2016-04-26 Thread Kevin Wolf
Am 25.04.2016 um 12:20 hat Denis V. Lunev geschrieben: > On 04/25/2016 12:05 PM, Kevin Wolf wrote: > >Am 23.04.2016 um 14:05 hat Denis V. Lunev geschrieben: > >>Unfortunately Linux kernel could send non-aligned requests to qemu-nbd > >>if the caller is using O_DIRECT and does not align in-memory da

Re: [Qemu-devel] [PATCH] net/tap: Allocating Large sized arrays to heap

2016-04-26 Thread Zhou Jie
On 2016/4/26 15:45, Christian Borntraeger wrote: On 04/26/2016 03:26 AM, Zhou Jie wrote: net_init_tap has a huge stack usage of 8192 bytes approx. Moving large arrays to heap to reduce stack usage. I am wondering. Why is 8k a problem for a user space program? For 64bit machine it will be 16k.

[Qemu-devel] update status -- vTPM for HVM virtual machine

2016-04-26 Thread Xu, Quan
On April 26, 2016 1:41 PM, Emil Condrea wrote: >Hi Quan, > >How are you ? I want to help you to get upstream the vtpm patches. I followed >the emails on xen-devel and I see that the last status was at v8 series >where Stefano asked to do some refactoring and splitting the patches into >refactori

Re: [Qemu-devel] [PATCH] net/tap: Allocating Large sized arrays to heap

2016-04-26 Thread Christian Borntraeger
On 04/26/2016 10:26 AM, Zhou Jie wrote: > On 2016/4/26 15:45, Christian Borntraeger wrote: >> On 04/26/2016 03:26 AM, Zhou Jie wrote: >>> net_init_tap has a huge stack usage of 8192 bytes approx. >>> Moving large arrays to heap to reduce stack usage. >> >> I am wondering. Why is 8k a problem for a

Re: [Qemu-devel] [PATCH] hw/net/virtio-net: Allocating Large sized arrays to heap

2016-04-26 Thread Christian Borntraeger
On 04/26/2016 10:05 AM, Zhou Jie wrote: > virtio_net_flush_tx has a huge stack usage of 16392 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Zhou Jie > --- > hw/net/virtio-net.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > d

Re: [Qemu-devel] [PATCH] hw/net/virtio-net: Allocating Large sized arrays to heap

2016-04-26 Thread Zhou Jie
On 2016/4/26 16:49, Christian Borntraeger wrote: On 04/26/2016 10:05 AM, Zhou Jie wrote: virtio_net_flush_tx has a huge stack usage of 16392 bytes approx. Moving large arrays to heap to reduce stack usage. Signed-off-by: Zhou Jie --- hw/net/virtio-net.c | 15 +++ 1 file changed,

Re: [Qemu-devel] [PATCH] usb-mtp: fix usb_mtp_get_device_info so that libmtp on the guest doesn't complain

2016-04-26 Thread Stefan Hajnoczi
On Sun, Apr 17, 2016 at 04:29:53AM -0700, Isaac Lozano wrote: > If an application uses libmtp on the guest system, > it will complain with the warning message: > LIBMTP WARNING: VendorExtensionID: > LIBMTP WARNING: VendorExtensionDesc: (null) > LIBMTP WARNING: this typically means the devi

Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-26 Thread Richard W.M. Jones
On Tue, Apr 26, 2016 at 09:43:09AM +0200, Gerd Hoffmann wrote: > On Fr, 2016-04-22 at 14:02 +0100, Richard W.M. Jones wrote: > > v4 -> v5: > > > > * Fix the initrd loading problem by fixing the get_e801_addr > >function so it really reads the values from the BIOS. > > > > Previously the func

Re: [Qemu-devel] how to enable nvme device in Qemu?

2016-04-26 Thread Stefan Hajnoczi
On Tue, Apr 19, 2016 at 08:37:42AM +, Qingtao Sun wrote: > I want to boot OS from NVMe device in qemu-2.5.1. But I didn't find > the bootable NVMe device in guest BIOS. How to enable this feature? I don't see an NVMe driver so I guess SeaBIOS does not support boot from NVMe: https://

Re: [Qemu-devel] iolimits for virtio-9p

2016-04-26 Thread Stefan Hajnoczi
On Tue, Apr 19, 2016 at 02:09:24PM +0200, Pradeep Kiruvale wrote: > We are planning to implement the io-limits for the virtio-9p driver i.e for > fsdev devices. > So, I am looking into the code base and how it has done for the block io > devices. > > I would like to know how difficult is this and

Re: [Qemu-devel] iolimits for virtio-9p

2016-04-26 Thread Pradeep Kiruvale
Hi Stefan, Thanks for the reply and adding Alberto. I am going through those APIs already. Thanks & Regards, Pradeep On 26 April 2016 at 11:21, Stefan Hajnoczi wrote: > On Tue, Apr 19, 2016 at 02:09:24PM +0200, Pradeep Kiruvale wrote: > > We are planning to implement the io-limits for the vir

Re: [Qemu-devel] emulation details of qemu

2016-04-26 Thread Stefan Hajnoczi
On Sat, Apr 23, 2016 at 06:36:39AM +, tutu sky wrote: > I want to know that is it possible to access registers or micro-architectural > part of a core/cpu in qemu during run time? Yes. How and to what extent depends on whether you are using TCG, KVM, or TCI. QEMU also has gdbstub support so

Re: [Qemu-devel] [PATCH for 2.7 1/1] qcow2: improve qcow2_co_write_zeroes()

2016-04-26 Thread Denis V. Lunev
On 04/26/2016 11:23 AM, Kevin Wolf wrote: Am 25.04.2016 um 12:20 hat Denis V. Lunev geschrieben: On 04/25/2016 12:05 PM, Kevin Wolf wrote: Am 23.04.2016 um 14:05 hat Denis V. Lunev geschrieben: Unfortunately Linux kernel could send non-aligned requests to qemu-nbd if the caller is using O_DIRE

Re: [Qemu-devel] [PATCH for 2.7 0/2] backup compression

2016-04-26 Thread Stefan Hajnoczi
On Sat, Apr 23, 2016 at 11:41:51AM +0300, Denis V. Lunev wrote: > The idea is simple - backup is "written-once" data. It is written block > by block and it is large enough. It would be nice to save storage > space and compress it. > > These patches add the ability to compress data during backup. T

Re: [Qemu-devel] [PATCH for-2.7 0/8] libqos: use standard virtio headers

2016-04-26 Thread Stefan Hajnoczi
On Mon, Apr 25, 2016 at 03:09:14PM -0400, John Snow wrote: > On 04/25/2016 08:46 AM, Stefan Hajnoczi wrote: > > This patch series eliminates code duplication in libqos virtio. > > include/standard-headers/ contains the Linux virtio header files so we don't > > need to define our own version of the

Re: [Qemu-devel] [PATCH v6] Add optionrom compatible with fw_cfg DMA version

2016-04-26 Thread Stefan Hajnoczi
On Mon, Apr 25, 2016 at 05:04:40PM +0100, Richard W.M. Jones wrote: > v5 -> v6: > > - Changed the xen_load_linux assertion as suggested by Stefan. > > - I renamed the variables in get_e801_addr function, since the >registers were really (16 bit 8086-style) AX, not EAX etc. Also I >chan

Re: [Qemu-devel] Updating documentation at http://wiki.qemu.org/download/qemu-doc.html

2016-04-26 Thread Stefan Hajnoczi
On Tue, Apr 26, 2016 at 07:50:31AM +0100, Mark Cave-Ayland wrote: > Does anyone know if it's possible to update the documentation at the > above URL? It appears as a link at http://wiki.qemu-project.org/Manual > and seems to be the first hit for most people looking for information on > QEMU SPARC e

[Qemu-devel] [PATCH] apb: convert init to realize

2016-04-26 Thread Wei Jiangang
Convert a device model where initialization obviously can't fail, make it implement realize() rather than init(). Signed-off-by: Wei Jiangang --- hw/pci-host/apb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c index aaef7bb..b29789

[Qemu-devel] [PATCH] block: Fix typo in comment

2016-04-26 Thread Wei Jiangang
s/imlement/implement/ Signed-off-by: Wei Jiangang --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index f1f520a..f74eb43 100644 --- a/blockdev.c +++ b/blockdev.c @@ -73,7 +73,7 @@ static int if_max_devs[IF_COUNT] = { * Do not chang

[Qemu-devel] [PATCH] iotests: fix the redirection order in 083

2016-04-26 Thread Wei Jiangang
It should redirect stdout to /dev/null first, then redirect stderr to whatever stdout currently points at. Signed-off-by: Wei Jiangang --- tests/qemu-iotests/083 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/083 b/tests/qemu-iotests/083 index aa99278.

Re: [Qemu-devel] [PATCH for 2.7 1/1] qcow2: improve qcow2_co_write_zeroes()

2016-04-26 Thread Kevin Wolf
Am 26.04.2016 um 11:35 hat Denis V. Lunev geschrieben: > On 04/26/2016 11:23 AM, Kevin Wolf wrote: > >Am 25.04.2016 um 12:20 hat Denis V. Lunev geschrieben: > >>On 04/25/2016 12:05 PM, Kevin Wolf wrote: > >>>Am 23.04.2016 um 14:05 hat Denis V. Lunev geschrieben: > Unfortunately Linux kernel cou

Re: [Qemu-devel] update status -- vTPM for HVM virtual machine

2016-04-26 Thread Wei Liu
Hi Quan For avoidance of doubt, this is purely status update, no action is needed on my part. Let me know if I misunderstood. Thanks Wei.

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Peter Xu
On Tue, Apr 26, 2016 at 10:15:46AM +0200, Jan Kiszka wrote: > On 2016-04-26 09:57, Jan Kiszka wrote: > > On 2016-04-26 09:34, Peter Xu wrote: > >> On Mon, Apr 25, 2016 at 09:24:12AM +0200, Jan Kiszka wrote: > >>> On 2016-04-25 09:18, Peter Xu wrote: > On Mon, Apr 25, 2016 at 07:16:19AM +0200,

[Qemu-devel] [PATCH v5 5/6] tcg: Rework tb_invalidated_flag

2016-04-26 Thread Sergey Fedorov
From: Sergey Fedorov 'tb_invalidated_flag' was meant to catch two events: * some TB has been invalidated by tb_phys_invalidate(); * the whole translation buffer has been flushed by tb_flush(). Then it was checked: * in cpu_exec() to ensure that the last executed TB can be safely linked to

[Qemu-devel] [PATCH v5 2/6] tcg: reorganize tb_find_physical loop

2016-04-26 Thread Sergey Fedorov
From: Alex Bennée Put some comments and improve code structure. This should help reading the code. Signed-off-by: Alex Bennée [Sergey Fedorov: provide commit message; bring back resetting of tb_invalidated_flag] Signed-off-by: Sergey Fedorov Reviewed-by: Richard Henderson --- cpu-exec.c | 4

[Qemu-devel] [PATCH v5 0/6] tcg: Misc clean-up patches

2016-04-26 Thread Sergey Fedorov
From: Sergey Fedorov This patch series consists of various general TCG clean-up patches extracted from Paolo's MTTCG tree [1] and Alex's MTTCG base enablement tree [2]. I also add here a patch from myself to rework tb_invalidated_flag based on the Paolo's "tcg: move tb_invalidated_flag to CPUStat

[Qemu-devel] [PATCH v5 1/6] tcg: code_bitmap is not used by user-mode emulation

2016-04-26 Thread Sergey Fedorov
From: Paolo Bonzini Signed-off-by: Paolo Bonzini [Sergey Fedorov: eliminate the field entirely in user-mode] Signed-off-by: Sergey Fedorov Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée --- Changes in v2: * The field is eliminated entirely in user-mode translate-all.c | 11 +

[Qemu-devel] [PATCH v8 4/5] ACPI: move acpi_build_srat_memory to common place

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao Move acpi_build_srat_memory to common place so that it could be reused by ARM. Rename it to build_srat_memory. Cc: Michael S. Tsirkin Cc: Igor Mammedov Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- hw/acpi/aml-build.c | 11 +++ hw/i386/acpi-bui

[Qemu-devel] [PATCH v5 3/6] cpu-exec: elide more icount code if CONFIG_USER_ONLY

2016-04-26 Thread Sergey Fedorov
From: Paolo Bonzini Signed-off-by: Paolo Bonzini [Alex Bennée: #ifndef replay code to match elided functions] Signed-off-by: Alex Bennée Signed-off-by: Sergey Fedorov --- cpu-exec.c | 8 1 file changed, 8 insertions(+) diff --git a/cpu-exec.c b/cpu-exec.c index 4cba4efc92b2..3694234

[Qemu-devel] [PATCH v8 2/5] ACPI: Add GICC Affinity Structure

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao Cc: Michael S. Tsirkin Cc: Igor Mammedov Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- hw/i386/acpi-build.c| 2 +- include/hw/acpi/acpi-defs.h | 15 ++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/

Re: [Qemu-devel] update status -- vTPM for HVM virtual machine

2016-04-26 Thread Xu, Quan
On April 26, 2016 6:25 PM, Wei Liu wrote: > For avoidance of doubt, this is purely status update, no action is needed on > my part. Yes. > Let me know if I misunderstood. > Quan

[Qemu-devel] [PATCH v5 6/6] cpu-exec: Move TB chaining into tb_find_fast()

2016-04-26 Thread Sergey Fedorov
From: Sergey Fedorov Move tb_add_jump() call and surrounding code from cpu_exec() into tb_find_fast(). That simplifies cpu_exec() a little by hiding the direct chaining optimization details into tb_find_fast(). It also allows to move tb_lock()/tb_unlock() pair into tb_find_fast(), putting it clos

[Qemu-devel] [PATCH v5 4/6] tcg: Clean up from 'next_tb'

2016-04-26 Thread Sergey Fedorov
From: Sergey Fedorov The value returned from tcg_qemu_tb_exec() is the value passed to the corresponding tcg_gen_exit_tb() at translation time of the last TB attempted to execute. It is a little confusing to store it in a variable named 'next_tb'. In fact, it is a combination of 4-byte aligned po

[Qemu-devel] [PATCH v8 1/5] ARM: Virt: Set numa-node-id for cpu and memory nodes

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao Generate memory nodes according to NUMA topology. Set numa-node-id property for cpu and memory nodes. Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- hw/arm/boot.c | 43 +-- hw/arm/virt.c | 8 2 files changed, 45 i

[Qemu-devel] [PATCH v8 0/5] ARM: Add NUMA support for machine virt

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao Add NUMA support for machine virt. Tested successfully running a guest Linux kernel with the following patch applied: - [PATCH v16 0/6] arm64, numa: Add numa support for arm64 platforms https://lkml.org/lkml/2016/4/8/571 - [PATCH v5 00/14] ACPI NUMA support for ARM64 https://l

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Jan Kiszka
On 2016-04-26 12:38, Peter Xu wrote: Hi, Jan, The above issue should be caused by EOI missing of level-triggered interrupts. Before that, I was always using edge-triggered interrupts for test, so didn't encounter this one. Would you please help try below patch? It can

Re: [Qemu-devel] [RFC for-2.7 01/11] qdt: IEEE1275-style device tree utility code

2016-04-26 Thread Thomas Huth
On 20.04.2016 04:33, David Gibson wrote: ... > This patch introduces a new utility library "qdt" for runtime > manipulation of device trees. The intention is that machine type code > can use these routines to construct the device tree conveniently, > using a pointer-based representation doesn't ha

[Qemu-devel] [PATCH v8 5/5] ACPI: Virt: Generate SRAT table

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao To support NUMA, it needs to generate SRAT ACPI table. Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 52 1 file changed, 52 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/

[Qemu-devel] [PATCH v8 3/5] ACPI: Fix the definition of proximity in AcpiSratMemoryAffinity

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao ACPI spec says that Proximity Domain is an "Integer that represents the proximity domain to which the processor belongs". So define it as a uint32_t. Cc: Michael S. Tsirkin Cc: Igor Mammedov Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- hw/i386/acpi-build.c

Re: [Qemu-devel] [PATCH v3 3/3] hw/arm/virt-acpi-build: Add PMU IRQ number in ACPI table

2016-04-26 Thread Shannon Zhao
On 2016/4/25 21:49, Shannon Zhao wrote: > On 2016年04月25日 20:42, Andrew Jones wrote: >> > On Mon, Apr 25, 2016 at 03:11:46PM +0800, Shannon Zhao wrote: >> > From: Shannon Zhao >> > >> > Add PMU IRQ number in ACPI table, then we can use PMU in guest through >> > ACPI. >>

Re: [Qemu-devel] [PATCH v3 3/3] hw/arm/virt-acpi-build: Add PMU IRQ number in ACPI table

2016-04-26 Thread Andrew Jones
On Tue, Apr 26, 2016 at 07:08:25PM +0800, Shannon Zhao wrote: > > > On 2016/4/25 21:49, Shannon Zhao wrote: > > On 2016年04月25日 20:42, Andrew Jones wrote: > >> > On Mon, Apr 25, 2016 at 03:11:46PM +0800, Shannon Zhao wrote: > >> > From: Shannon Zhao > >> > > >> > Add PMU IRQ numbe

Re: [Qemu-devel] [PATCH v8 0/5] ARM: Add NUMA support for machine virt

2016-04-26 Thread Andrew Jones
On Tue, Apr 26, 2016 at 06:40:24PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Add NUMA support for machine virt. Tested successfully running a guest > Linux kernel with the following patch applied: > > - [PATCH v16 0/6] arm64, numa: Add numa support for arm64 platforms > https://lkml.or

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Peter Xu
On Tue, Apr 26, 2016 at 12:51:44PM +0200, Jan Kiszka wrote: > On 2016-04-26 12:38, Peter Xu wrote: > Hi, Jan, > > The above issue should be caused by EOI missing of level-triggered > interrupts. Before that, I was always using edge-triggered > interrupts for test, so didn't

[Qemu-devel] [PATCH v4 2/3] hw/arm/virt: Add PMU node for virt machine

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao Add a virtual PMU device for virt machine while use PPI 7 for PMU overflow interrupt number. Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 33 + include/hw/arm/virt.h | 4 include/sysemu/kvm.h | 1 + stubs/kvm.c |

[Qemu-devel] [PATCH v4 3/3] hw/arm/virt-acpi-build: Add PMU IRQ number in ACPI table

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao Add PMU IRQ number in ACPI table, then we can use PMU in guest through ACPI. Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index f

[Qemu-devel] [PATCH v4 1/3] target-arm: kvm64: set guest PMUv3 feature bit if supported

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao Check if kvm supports guest PMUv3. If so, set the corresponding feature bit for vcpu. Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- target-arm/cpu-qom.h | 2 ++ target-arm/kvm64.c | 5 + 2 files changed, 7 insertions(+) diff --git a/target-arm/cpu-qom.h b

[Qemu-devel] [PATCH v4 0/3] Add guest PMU in machine virt

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao KVM-ARM64 supports guest PMU now. This series add the support in machine virt so that guest could use PMU. The ACPI part is tested with below guest kernel patches. https://lkml.org/lkml/2016/4/12/755 Changes since v3: * if kvm_arm_pmu_create returns a failure, don't create pm

Re: [Qemu-devel] [PATCH v4 2/3] hw/arm/virt: Add PMU node for virt machine

2016-04-26 Thread Andrew Jones
On Tue, Apr 26, 2016 at 07:40:45PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Add a virtual PMU device for virt machine while use PPI 7 for PMU > overflow interrupt number. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt.c | 33 + > include/

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

2016-04-26 Thread Alberto Garcia
On Tue 19 Apr 2016 02:09:24 PM CEST, Pradeep Kiruvale wrote: > We are planning to implement the io-limits for the virtio-9p driver > i.e for fsdev devices. > So, I am looking into the code base and how it has done for the block > io devices. > > I would like to know how difficult is this and is th

Re: [Qemu-devel] Updating documentation at http://wiki.qemu.org/download/qemu-doc.html

2016-04-26 Thread Jeff Cody
On Tue, Apr 26, 2016 at 11:02:45AM +0100, Stefan Hajnoczi wrote: > On Tue, Apr 26, 2016 at 07:50:31AM +0100, Mark Cave-Ayland wrote: > > Does anyone know if it's possible to update the documentation at the > > above URL? It appears as a link at http://wiki.qemu-project.org/Manual > > and seems to b

Re: [Qemu-devel] [RFC 00/13] Multiple fd migration support

2016-04-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> Hi > >> > >> This patch series is "an" initial implementation of multiple fd migration. > >> This is to get something out for others to comment, it is not finished

Re: [Qemu-devel] [PATCH] hw/net/virtio-net: Allocating Large sized arrays to heap

2016-04-26 Thread Michael S. Tsirkin
On Tue, Apr 26, 2016 at 04:05:24PM +0800, Zhou Jie wrote: > virtio_net_flush_tx has a huge stack usage of 16392 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Zhou Jie I don't think it's appropriate for trivial. Also - what's the point, exactly? > --- > h

[Qemu-devel] how should a device implement an array of link(?) properties?

2016-04-26 Thread Peter Maydell
Hi; I have what seems like a fairly straightforward requirement for a QOM device but no idea how to implement it, so I'm looking for advice on the right "modern" way to do it... Specifically, this is the GICv3 device. It would like to have a pointer to every CPU object it needs to be connected to.

Re: [Qemu-devel] [PATCH v14 15/19] qapi-commands: Wrap argument visit in visit_start_struct

2016-04-26 Thread Eric Blake
On 04/15/2016 05:42 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The qmp-input visitor was playing rather fast and loose: when > > I guess (some of) its *users* are playing fast and loose, and the > visitor itself lets them. The patch's title suggests "some of its > users" == qapi-com

Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: add tracepoints

2016-04-26 Thread Stefan Hajnoczi
On Thu, Apr 21, 2016 at 08:24:41AM -0700, Hollis Blanchard wrote: > These are obviously critical to understanding interrupt delivery: > gic_enable_irq > gic_disable_irq > gic_set_irq (inbound irq from device models) > gic_update_set_irq (outbound irq to CPU) > gic_acknowledge_irq > > The only one

Re: [Qemu-devel] [RFC PATCH resend 00/11] Make CoMutex/CoQueue/CoRwlock thread-safe

2016-04-26 Thread Stefan Hajnoczi
On Fri, Apr 15, 2016 at 01:31:55PM +0200, Paolo Bonzini wrote: > [this time including the mailing list] > > This is yet another tiny bit of the multiqueue work, this time affecting > the synchronization infrastructure for coroutines. Currently, coroutines > synchronize between the main I/O thread

[Qemu-devel] [PATCH] PPC/KVM: early validation of vcpu id

2016-04-26 Thread Greg Kurz
The KVM API restricts vcpu ids to be < KVM_CAP_MAX_VCPUS. On PowerPC targets, depending on the number of threads per core in the host and in the guest, some topologies do generate higher vcpu ids actually. When this happens, QEMU bails out with the following error: kvm_init_vcpu failed: Invalid ar

Re: [Qemu-devel] Simultaneous vhostfds= and ifname= options

2016-04-26 Thread Michał Dubiel
Hi all, Any thoughts to share on that? Thanks, Michal On 15 April 2016 at 18:50, Michał Dubiel wrote: > Hi guys, > > Qemu does not allow currently to use vhostfds= and ifname= options of > -netdev tap... at the same time. In order to use vhostfds=, you have to > also use fds= instead. May ask

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Radim Krčmář
2016-04-26 15:34+0800, Peter Xu: > Hi, Jan, > > The above issue should be caused by EOI missing of level-triggered > interrupts. Before that, I was always using edge-triggered > interrupts for test, so didn't encounter this one. Would you please > help try below patch? It can be applied directly o

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Jan Kiszka
On 2016-04-26 13:40, Peter Xu wrote: > On Tue, Apr 26, 2016 at 12:51:44PM +0200, Jan Kiszka wrote: >> On 2016-04-26 12:38, Peter Xu wrote: >> Hi, Jan, >> >> The above issue should be caused by EOI missing of level-triggered >> interrupts. Before that, I was always using edge-trigger

Re: [Qemu-devel] [PATCH] iotests: fix the redirection order in 083

2016-04-26 Thread Eric Blake
On 04/26/2016 04:13 AM, Wei Jiangang wrote: > It should redirect stdout to /dev/null first, > then redirect stderr to whatever stdout currently points at. > > Signed-off-by: Wei Jiangang > --- > tests/qemu-iotests/083 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric

Re: [Qemu-devel] [patch v6 11/12] vfio: register aer resume notification handler for aer resume

2016-04-26 Thread Alex Williamson
On Tue, 26 Apr 2016 11:39:02 +0800 Chen Fan wrote: > On 04/14/2016 09:02 AM, Chen Fan wrote: > > > > On 04/12/2016 05:38 AM, Alex Williamson wrote: > >> On Tue, 5 Apr 2016 19:42:02 +0800 > >> Cao jin wrote: > >> > >>> From: Chen Fan > >>> > >>> for supporting aer recovery, host and guest wo

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Radim Krčmář
2016-04-26 16:24+0200, Jan Kiszka: > On 2016-04-26 13:40, Peter Xu wrote: >> Currently, all the interrupts will be translated into one MSI in >> vtd_generate_msi_message(), in which only 8 bits of dest_id is used >> (msg.dest = irq->dest). We may possibly need to use the high 32 bits >> of MSI addr

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Jan Kiszka
On 2016-04-26 16:59, Radim Krčmář wrote: > 2016-04-26 16:24+0200, Jan Kiszka: >> On 2016-04-26 13:40, Peter Xu wrote: >>> Currently, all the interrupts will be translated into one MSI in >>> vtd_generate_msi_message(), in which only 8 bits of dest_id is used >>> (msg.dest = irq->dest). We may possi

Re: [Qemu-devel] [RFC v3] translate-all: protect code_gen_buffer with RCU

2016-04-26 Thread Richard Henderson
On 04/25/2016 11:35 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 04/25/2016 04:46 PM, Emilio G. Cota wrote: >>> +/* >>> + * write the prologue into buf2. This is safe because we'll later call >>> + * tcg_prologue_init on buf1, from which we'll start execution. >>> +

Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

2016-04-26 Thread Jason Dillaman
On Sun, Apr 24, 2016 at 7:42 PM, Fam Zheng wrote: > On Fri, 04/22 21:57, Jason Dillaman wrote: >> Since this cannot automatically recover from a crashed QEMU client with an >> RBD image, perhaps this RBD locking should not default to enabled. >> Additionally, this will conflict with the "exclusive

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Radim Krčmář
2016-04-26 17:28+0200, Jan Kiszka: > On 2016-04-26 16:59, Radim Krčmář wrote: >> 2016-04-26 16:24+0200, Jan Kiszka: >>> On 2016-04-26 13:40, Peter Xu wrote: Currently, all the interrupts will be translated into one MSI in vtd_generate_msi_message(), in which only 8 bits of dest_id is used

[Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Programmingkid
My three guest operating systems can't load a web page. I think this is a bug with QEMU. Is there anyone who has the latest revision of QEMU that can access the web from a guest? Or are you experiencing the same problem?

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix descriptor address masking in ARM address translation

2016-04-26 Thread Tom Hanson
On 03/21/2016 09:56 AM, Sergey Sorokin wrote: 17.03.2016, 18:24, "Peter Maydell" : On 17 March 2016 at 15:21, Sergey Sorokin wrote: 17.03.2016, 14:40, "Peter Maydell" : On 13 March 2016 at 18:28, Sergey Sorokin wrote: If you want to implement the AddressSize checks that's fine,

[Qemu-devel] Working on AF_VSOCK packet capture

2016-04-26 Thread Gerard
Hi all, My name is Gerard Garcia and I have been funded by GSOC16 to work on a device driver to allow capturing host/guest traffic through AF_VSOCK sockets: http://qemu-project.org/Features/VirtioVsock I'll mostly work on the Linux kernel codebase but the device driver is closely related to QEMU

Re: [Qemu-devel] how to enable nvme device in Qemu?

2016-04-26 Thread Laszlo Ersek
On 04/26/16 11:18, Stefan Hajnoczi wrote: > On Tue, Apr 19, 2016 at 08:37:42AM +, Qingtao Sun wrote: >> I want to boot OS from NVMe device in qemu-2.5.1. But I didn't find >> the bootable NVMe device in guest BIOS. How to enable this feature? > > I don't see an NVMe driver so I guess

Re: [Qemu-devel] [RFC for-2.7 04/11] pseries: Make spapr_create_fdt_skel() get information from machine state

2016-04-26 Thread Thomas Huth
On 20.04.2016 04:33, David Gibson wrote: > Currently spapr_create_fdt_skel() takes a bunch of individual parameters > for various things it will put in the device tree. Some of these can > already be taken directly from sPAPRMachineState. This patch alters it so > that all of them can be taken fr

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Jan Kiszka
On 2016-04-26 18:07, Radim Krčmář wrote: > 2016-04-26 17:28+0200, Jan Kiszka: >> On 2016-04-26 16:59, Radim Krčmář wrote: >>> 2016-04-26 16:24+0200, Jan Kiszka: On 2016-04-26 13:40, Peter Xu wrote: > Currently, all the interrupts will be translated into one MSI in > vtd_generate_msi_me

Re: [Qemu-devel] KVM Forum 2016: Call For Participation

2016-04-26 Thread Peter Maydell
On 10 March 2016 at 18:09, Paolo Bonzini wrote: > = > KVM Forum 2016: Call For Participation > August 24-26, 2016 - Westin Harbor Castle - Toronto, Canada > > (All submissions must be received before midnight May 1, 2016) > ==

Re: [Qemu-devel] [RFC for-2.7 05/11] pseries: Build device tree only at reset time

2016-04-26 Thread Thomas Huth
On 20.04.2016 04:33, David Gibson wrote: > Currently the pseries code builds a "skeleton" device tree at machine init > time, then adds a bunch of stuff to it at reset. Over time, more and more > logic has had to be moved from init to reset time, and there's really no > advantage to doing any of i

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Dr. David Alan Gilbert
* Programmingkid (programmingk...@gmail.com) wrote: > My three guest operating systems can't load a web page. I think this is a bug > with QEMU. Is there anyone who has the latest revision of QEMU that can > access the web from a guest? Or are you experiencing the same problem? Works here. Now

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Programmingkid
On Apr 26, 2016, at 3:00 PM, Dr. David Alan Gilbert wrote: > * Programmingkid (programmingk...@gmail.com) wrote: >> My three guest operating systems can't load a web page. I think this is a >> bug with QEMU. Is there anyone who has the latest revision of QEMU that can >> access the web from a g

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Thomas Huth
On 26.04.2016 21:25, Programmingkid wrote: > > On Apr 26, 2016, at 3:00 PM, Dr. David Alan Gilbert wrote: > >> * Programmingkid (programmingk...@gmail.com) wrote: >>> My three guest operating systems can't load a web page. I think this is a >>> bug with QEMU. Is there anyone who has the latest r

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Programmingkid
On Apr 26, 2016, at 4:12 PM, Thomas Huth wrote: > On 26.04.2016 21:25, Programmingkid wrote: >> >> On Apr 26, 2016, at 3:00 PM, Dr. David Alan Gilbert wrote: >> >>> * Programmingkid (programmingk...@gmail.com) wrote: My three guest operating systems can't load a web page. I think this is a

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-26 Thread Michael Roth
Quoting Igor Mammedov (2016-04-26 02:52:36) > On Tue, 26 Apr 2016 10:39:23 +0530 > Bharata B Rao wrote: > > > On Mon, Apr 25, 2016 at 11:20:50AM +0200, Igor Mammedov wrote: > > > On Wed, 16 Mar 2016 10:11:54 +0530 > > > Bharata B Rao wrote: > > > > > > > On Wed, Mar 16, 2016 at 12:36:05PM +11

Re: [Qemu-devel] [PATCH] usb-mtp: fix usb_mtp_get_device_info so that libmtp on the guest doesn't complain

2016-04-26 Thread Bandan Das
Stefan Hajnoczi writes: > On Sun, Apr 17, 2016 at 04:29:53AM -0700, Isaac Lozano wrote: >> If an application uses libmtp on the guest system, >> it will complain with the warning message: >> LIBMTP WARNING: VendorExtensionID: >> LIBMTP WARNING: VendorExtensionDesc: (null) >> LIBMTP WARNI

[Qemu-devel] [PATCH 03/19] block: Respect backing bs in bdrv_refresh_filename

2016-04-26 Thread Max Reitz
Basically, bdrv_refresh_filename() should respect all children of a BlockDriverState. However, generally those children are driver-specific, so this function cannot handle the general case. On the other hand, there are only few drivers which use other children than @file and @backing (that being vm

[Qemu-devel] [PATCH 00/19] block: Fix some filename generation issues

2016-04-26 Thread Max Reitz
(Fun fact: This series has been lying around on my disk since last November. I guess I forgot to send it because I still wanted to review it before sending it out, and that it what I forgot to do. Well, and now Berto noticed that we ought to fix something.) There are some issues regarding file

[Qemu-devel] [PATCH 04/19] block: Add bdrv_default_refresh_format_filename

2016-04-26 Thread Max Reitz
Split off the default code for format BDS from bdrv_refresh_filename() into an own function, first because it is nicer this way, and second because this will allow block drivers to reuse this function in their own specific implementation of bdrv_refresh_filename(). Signed-off-by: Max Reitz --- b

[Qemu-devel] [PATCH 02/19] block: Add BDS.backing_overridden

2016-04-26 Thread Max Reitz
If the backing file is overridden, this most probably does change the guest-visible data of a BDS. Therefore, we will need to consider this in bdrv_refresh_filename(). Adding a new field to the BDS is not nice, but it is very simple and exactly keeps track of whether the backing file has been over

[Qemu-devel] [PATCH 10/19] block: bdrv_get_full_backing_filename's ret. val.

2016-04-26 Thread Max Reitz
Make bdrv_get_full_backing_filename() return an allocated string instead of placing the result in a caller-provided buffer. Signed-off-by: Max Reitz --- block.c | 24 block/qapi.c | 12 ++-- include/block/block.h | 3 +-- 3 files changed,

[Qemu-devel] [PATCH 01/19] block: Use children list in bdrv_refresh_filename

2016-04-26 Thread Max Reitz
bdrv_refresh_filename() should invoke itself recursively on all children, not just on file. With that change, we can remove the manual invocations in blkverify and quorum. Signed-off-by: Max Reitz --- block.c | 9 + block/blkverify.c | 3 --- block/quorum.c| 1 - 3 files c

[Qemu-devel] [PATCH 09/19] block: bdrv_get_full_backing_filename_from_...'s ret. val.

2016-04-26 Thread Max Reitz
Make bdrv_get_full_backing_filename_from_filename() return an allocated string instead of placing the result in a caller-provided buffer. Signed-off-by: Max Reitz --- block.c | 32 +++- block/vmdk.c | 8 +++- include/block/block.h | 7 +++-

  1   2   >