Re: [Qemu-devel] [PATCH] disas/microblaze: Add missing 'const' attributes

2016-05-05 Thread Edgar E. Iglesias
On Wed, Apr 06, 2016 at 12:01:17PM +0200, Stefan Weil wrote: > Am 06.04.2016 um 11:16 schrieb Edgar E. Iglesias: > > On Tue, Mar 22, 2016 at 08:31:33AM +0100, Stefan Weil wrote: > >> Making the opcode list 'const' saves memory. > >> Some function arguments and local variables needed 'const', too. >

Re: [Qemu-devel] [PATCH] gdbstub: avoid busy loop while waiting for gdb

2016-05-05 Thread Peter Maydell
On 3 May 2016 at 23:58, Peter Wu wrote: > While waiting for a gdb response, or while sending an acknowledgement > there is not much to do, so just mark the socket as non-blocking to > avoid a busy loop while paused at gdb. This only affects the user-mode > emulation (qemu-arm -g 1234 ./a.out). > >

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

2016-05-05 Thread Ladi Prosek
On Thu, May 5, 2016 at 6:04 PM, Michael S. Tsirkin wrote: > On Thu, May 05, 2016 at 05:27:03PM +0200, Ladi Prosek wrote: >> On Thu, May 5, 2016 at 5:20 PM, Michael S. Tsirkin wrote: >> > On Thu, May 05, 2016 at 05:15:01PM +0200, Ladi Prosek wrote: >> >> On Thu, May 5, 2016 at 5:02 PM, Michael S.

Re: [Qemu-devel] [Qemu-Devel] [PATCH] Changed malloc to g_malloc, free to g_free in linux-user/qemu.h

2016-05-05 Thread Stefan Hajnoczi
On Thu, Mar 24, 2016 at 12:02:03AM +0530, Md Haris Iqbal wrote: > Signed-off-by: Md Haris Iqbal > --- > linux-user/qemu.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] TCP Segementation Offloading

2016-05-05 Thread Stefan Hajnoczi
On Sun, May 01, 2016 at 02:31:57PM +0200, Ingo Krabbe wrote: > Good Mayday Qemu Developers, > > today I tried to find a reference to a networking problem, that seems to be > of quite general nature: TCP Segmentation Offloading (TSO) in virtual > environments. > > When I setup TAP network adapte

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

2016-05-05 Thread Stefan Hajnoczi
On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > From: Vikhyat Umrao > Date: Mon, 2 May 2016 21:47:31 +0530 > Subject: [PATCH] rbd:change error_setg() to error_setg_errno() > > Ceph RBD block driver does not

Re: [Qemu-devel] virtio-net and vhost-net init, virtio-scsi and vhost-scsi init

2016-05-05 Thread Stefan Hajnoczi
On Thu, May 05, 2016 at 11:05:27AM +, Catalin Vasile wrote: > When the virtio-net and virtio-scsi drivers have done the probe() primitive > they set the DRIVER_OK flag. > > If the vhost kernel backend is used, the set_status() primitive in qemu will > be triggered with DRIVER_OK status and i

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

2016-05-05 Thread Jeff Cody
On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > > From: Vikhyat Umrao > > Date: Mon, 2 May 2016 21:47:31 +0530 > > Subject: [PATCH] rbd:cha

Re: [Qemu-devel] [PATCH RFC 0/8] basic vfio-ccw infrastructure

2016-05-05 Thread Alex Williamson
[cc +Intel,NVIDIA] On Thu, 5 May 2016 18:29:08 +0800 Dong Jia wrote: > On Wed, 4 May 2016 13:26:53 -0600 > Alex Williamson wrote: > > > On Wed, 4 May 2016 17:26:29 +0800 > > Dong Jia wrote: > > > > > On Fri, 29 Apr 2016 11:17:35 -0600 > > > Alex Williamson wrote: > > > > > > Dear Alex: >

Re: [Qemu-devel] [RFC PATCH v3 2/3] VFIO driver for vGPU device

2016-05-05 Thread Neo Jia
On Thu, May 05, 2016 at 09:24:26AM +, Tian, Kevin wrote: > > From: Alex Williamson > > Sent: Thursday, May 05, 2016 1:06 AM > > > > > + > > > > > +static int vgpu_dev_mmio_fault(struct vm_area_struct *vma, struct > > > > > vm_fault > > *vmf) > > > > > +{ > > > > > + int ret = 0; > > > > >

Re: [Qemu-devel] [PATCH RFC 0/8] basic vfio-ccw infrastructure

2016-05-05 Thread Neo Jia
On Thu, May 05, 2016 at 01:19:45PM -0600, Alex Williamson wrote: > [cc +Intel,NVIDIA] > > On Thu, 5 May 2016 18:29:08 +0800 > Dong Jia wrote: > > > On Wed, 4 May 2016 13:26:53 -0600 > > Alex Williamson wrote: > > > > > On Wed, 4 May 2016 17:26:29 +0800 > > > Dong Jia wrote: > > > > > > > O

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2016-05-05 Thread Server Angels
I would appreciate this patch being committed as I *think* it's affecting a system i'm building now. I have a backup host with 2 VMs. For business reasons they need to be network isolated from each other and the host, so each is passed through a physical NIC. Each VM does need access to a variable

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2016-05-05 Thread Server Angels
** Also affects: ubuntu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336794 Title: 9pfs does not honor open file handles on unlinked files Status in Q

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-05 Thread Emilio G. Cota
On Wed, May 04, 2016 at 07:22:16 -1000, Richard Henderson wrote: > On 05/04/2016 05:36 AM, Emilio G. Cota wrote: > >BTW in the last couple of days I did some more work beyond v4: > > > >- Added a benchmark (not a correctness test) to measure parallel > > performance of QHT (recall that test/qht-te

Re: [Qemu-devel] [PATCH qemu v16 01/19] vfio: Delay DMA address space listener release

2016-05-05 Thread Alex Williamson
On Wed, 4 May 2016 16:52:13 +1000 Alexey Kardashevskiy wrote: > This postpones VFIO container deinitialization to let region_del() > callbacks (called via vfio_listener_release) do proper clean up > while the group is still attached to the container. Any mappings within the container should cle

Re: [Qemu-devel] [PATCH qemu v16 02/19] memory: Call region_del() callbacks on memory listener unregistering

2016-05-05 Thread Alex Williamson
On Wed, 4 May 2016 16:52:14 +1000 Alexey Kardashevskiy wrote: > When a new memory listener is registered, listener_add_address_space() > is called and which in turn calls region_add() callbacks of memory regions. > However when unregistering the memory listener, it is just removed from > the lis

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

2016-05-05 Thread Fam Zheng
On Thu, 05/05 15:06, Jeff Cody wrote: > On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > > > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > > > From: Vikhyat Umrao > > > Date: Mon, 2 May

Re: [Qemu-devel] [PATCH v1 0/6] A migration performance testing framework

2016-05-05 Thread Li, Liang Z
> This series of patches provides a framework for testing migration > performance characteristics. The motivating factor for this is planning that > is > underway in OpenStack wrt making use of QEMU migration features such as > compression, auto-converge and post-copy. The primary aim for OpenStac

Re: [Qemu-devel] [patch v6 11/12] vfio: register aer resume notification handler for aer resume

2016-05-05 Thread Chen Fan
On 04/26/2016 10:48 PM, Alex Williamson wrote: On Tue, 26 Apr 2016 11:39:02 +0800 Chen Fan wrote: On 04/14/2016 09:02 AM, Chen Fan wrote: On 04/12/2016 05:38 AM, Alex Williamson wrote: On Tue, 5 Apr 2016 19:42:02 +0800 Cao jin wrote: From: Chen Fan for supporting aer recovery, host an

[Qemu-devel] [PATCH v3 0/5] ADB improvements

2016-05-05 Thread Programmingkid
This patch series makes several improvements to the ADB code. To test this code, please implement the patches in the order below. John Arbuckle (5): adb-keys.h: initial commit adb.c: add support for QKeyCode adb.c: correct several key assignments adb.c: prevent NO_KEY value from going to g

[Qemu-devel] [PATCH v3 1/5] adb-keys.h: initial commit

2016-05-05 Thread Programmingkid
Add the adb-keys.h file. It maps ADB transition key codes with values. Signed-off-by: John Arbuckle --- *v3 changes: Removed note. *v2 changes: Changed order of this patch. include/hw/input/adb-keys.h | 142 1 file changed, 142 insertions(+) create

[Qemu-devel] [PATCH v3 2/5] adb.c: add support for QKeyCode

2016-05-05 Thread Programmingkid
The old pc scancode translation is replaced with QEMU's QKeyCode. Signed-off-by: John Arbuckle --- *v3 changes Kept original pc_to_adb_keycode mapping. *v2 changes Changed order of this patch. hw/input/adb.c | 222 + 1 file changed, 176 i

[Qemu-devel] [PATCH v3 3/5] adb.c: correct several key assignments

2016-05-05 Thread Programmingkid
The original pc_to_adb_keycode mapping did have several keys that were incorrectly mapped. This patch fixes these mappings. Signed-off-by: John Arbuckle --- hw/input/adb.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/hw/input/adb.c b/hw/

[Qemu-devel] [PATCH v3 4/5] adb.c: prevent NO_KEY value from going to guest

2016-05-05 Thread Programmingkid
The NO_KEY value should not be sent to the guest. This patch drops that value. Signed-off-by: John Arbuckle --- hw/input/adb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/input/adb.c b/hw/input/adb.c index 6d4f4dc..37728b3 100644 --- a/hw/input/adb.c +++ b/hw/input/adb.c @@ -424,6

[Qemu-devel] [PATCH v3 5/5] adb.c: add power key support

2016-05-05 Thread Programmingkid
Add support for the power key. It has to be handled differently from the other keys because it is the only 16-bit value key. Signed-off-by: John Arbuckle --- v3 change Add several suggested comments. Moved the location of an else statement in the adb_keyboard_event() function. hw/input/adb.c |

[Qemu-devel] [PATCH v5 02/11] change pvscsi_init_msi() type to void

2016-05-05 Thread Cao jin
Nobody use its return value, so change the type to void. cc: Paolo Bonzini Acked-by: Dmitry Fleytman Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/vmw_pvscsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c

[Qemu-devel] [PATCH v5 07/11] mptsas: change msi property type

2016-05-05 Thread Cao jin
>From uint32 to enum OnOffAuto, and give it a shorter name. cc: Paolo Bonzini cc: Markus Armbruster Signed-off-by: Cao jin --- hw/scsi/mptsas.c | 4 ++-- hw/scsi/mptsas.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 1c18c84..

[Qemu-devel] [PATCH v5 09/11] pci bridge dev: change msi property type

2016-05-05 Thread Cao jin
>From bit to enum OnOffAuto. cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- Actually, I am not quite sure this device need this change, RFC. hw/pci-bridge/pci_bridge_dev.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) dif

[Qemu-devel] [PATCH v5 00/11] Add param Error ** for msi_init()

2016-05-05 Thread Cao jin
This patchset is for 2.7. This version has a huge change, so I hope to get some comments first. The change mostly is: 1. According suggestions, modify devices` msi/msix property type. its type mostly bit or uint, now change it to enum OnOffAuto, and default to "auto". So we will know if user

[Qemu-devel] [PATCH v5 03/11] megasas: Fix

2016-05-05 Thread Cao jin
msi_init returns non-zero value on both failure and success. cc: Hannes Reinecke cc: Paolo Bonzini Signed-off-by: Cao jin --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index a63a581..56fb645 100644 --- a/hw/scsi/

[Qemu-devel] [PATCH v5 08/11] megasas: change msi/msix property type

2016-05-05 Thread Cao jin
>From bit to enum OnOffAuto. cc: Hannes Reinecke cc: Paolo Bonzini cc: Markus Armbruster Signed-off-by: Cao jin --- hw/scsi/megasas.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 56fb645..e71a28b

[Qemu-devel] [PATCH v5 05/11] usb xhci: change msi/msix property type

2016-05-05 Thread Cao jin
>From bit to enum OnOffAuto. cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/usb/hcd-xhci.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index bcde

[Qemu-devel] [PATCH v5 01/11] fix some coding style problems

2016-05-05 Thread Cao jin
It has: 1. More newlines make the code block well separated. 2. Add more comments for msi_init. 3. Fix a indentation in vmxnet3.c. 4. ioh3420 & xio3130_downstream: put PCI Express capability init function together, make it more readable. cc: Dmitry Fleytman cc: Jason Wang cc: Michael S. Tsirk

[Qemu-devel] [PATCH v5 11/11] pci: Convert msi_init() to Error and fix callers to check it

2016-05-05 Thread Cao jin
msi_init() reports errors with error_report(), which is wrong when it's used in realize(). Fix by converting it to Error. Fix its callers to handle failure instead of ignoring it. For those callers who don`t handle the failure, it might happen: when user want msi on, but he doesn`t get what he w

[Qemu-devel] [PATCH v5 06/11] intel-hda: change msi property type

2016-05-05 Thread Cao jin
>From uint32 to enum OnOffAuto. cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/audio/intel-hda.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index d3

[Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capability

2016-05-05 Thread Cao jin
ENOSPC is programming error, assert it for debugging. cc: Michael S. Tsirkin cc: Marcel Apfelbaum cc: Markus Armbruster Signed-off-by: Cao jin --- hw/pci/pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index f0f41dc..fc8b377 100644 -

Re: [Qemu-devel] [PATCH v3 07/18] qapi: Add json output visitor

2016-05-05 Thread Eric Blake
On 05/04/2016 09:45 AM, Markus Armbruster wrote: > +void json_output_visitor_reset(JsonOutputVisitor *v); Hmm. Why is "reset" not a Visitor method? I think this would let us put the things enforced by your "qmp: Tighten output visitor rules" in the Visitor contract. >>

[Qemu-devel] [PATCH v5 04/11] mptsas: change .realize function name

2016-05-05 Thread Cao jin
All the other devices` .realize function name are xxx_realize, except this one. cc: Paolo Bonzini Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/mptsas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 499c146.

Re: [Qemu-devel] TCP Segementation Offloading

2016-05-05 Thread Ingo Krabbe
> On Sun, May 01, 2016 at 02:31:57PM +0200, Ingo Krabbe wrote: >> Good Mayday Qemu Developers, >> >> today I tried to find a reference to a networking problem, that seems to be >> of quite general nature: TCP Segmentation Offloading (TSO) in virtual >> environments. >> >> When I setup TAP netwo

Re: [Qemu-devel] [PATCH v2 2/2] xen: add pvUSB backend

2016-05-05 Thread Juergen Gross
On 05/05/16 12:13, Anthony PERARD wrote: > On Wed, May 04, 2016 at 10:25:03AM +0200, Juergen Gross wrote: >> On 03/05/16 17:06, Anthony PERARD wrote: >>> On Thu, Mar 10, 2016 at 04:19:30PM +0100, Juergen Gross wrote: +static void usbback_bh(void *opaque) +{ +struct usbback_info *

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

2016-05-05 Thread Vikhyat Umrao
On Fri, May 6, 2016 at 6:14 AM, Fam Zheng wrote: > On Thu, 05/05 15:06, Jeff Cody wrote: > > On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > > > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > > > > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00

Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version.

2016-05-05 Thread Janne Karhunen
Fam, Any objections to this one? -- Janne On Tue, May 3, 2016 at 12:43 PM, Janne Karhunen wrote: > From: Janne Karhunen > > Vmdk images have metadata to indicate the vmware virtual > hardware version image was created/tested to run with. > Allow users to specify that version via new 'hwversio

Re: [Qemu-devel] [PATCH v5 03/11] megasas: Fix

2016-05-05 Thread Cao jin
sorry, forget to cc some maintainers On 05/06/2016 12:20 PM, Cao jin wrote: msi_init returns non-zero value on both failure and success. cc: Hannes Reinecke cc: Paolo Bonzini Signed-off-by: Cao jin --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/h

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-05 Thread Zhang Chen
On 04/29/2016 10:03 AM, Jason Wang wrote: On 04/28/2016 05:04 PM, Zhang Chen wrote: On 04/28/2016 04:17 PM, Jason Wang wrote: On 04/28/2016 03:55 PM, Zhang Chen wrote: On 04/28/2016 03:16 PM, Jason Wang wrote: On 04/28/2016 02:53 PM, Jason Wang wrote: +static void compare_set_outdev(Obje

Re: [Qemu-devel] [PATCH v5 02/11] change pvscsi_init_msi() type to void

2016-05-05 Thread Cao jin
forget to cc some maintainers On 05/06/2016 12:20 PM, Cao jin wrote: Nobody use its return value, so change the type to void. cc: Paolo Bonzini Acked-by: Dmitry Fleytman Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/vmw_pvscsi.c | 4 +--- 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH v5 04/11] mptsas: change .realize function name

2016-05-05 Thread Cao jin
forget to cc some maintainers On 05/06/2016 12:20 PM, Cao jin wrote: All the other devices` .realize function name are xxx_realize, except this one. cc: Paolo Bonzini Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/mptsas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[Qemu-devel] qcow2 resize with snapshots

2016-05-05 Thread zhangzhiming
hi, i want to implement the function of qcow2 resize which has snapshots. each snapshot of qcow2 will have a separate total size, and when apply a snapshot, the image can be shrunk, and the total size of image will change after apply to a snapshot with different size. now, there is a disk_size v

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

2016-05-05 Thread Pradeep Kiruvale
On 4 May 2016 at 17:40, Greg Kurz wrote: > On Mon, 2 May 2016 17:49:26 +0200 > Pradeep Kiruvale wrote: > > > On 2 May 2016 at 14:57, Greg Kurz wrote: > > > > > On Thu, 28 Apr 2016 11:45:41 +0200 > > > Pradeep Kiruvale wrote: > > > > > > > On 27 April 2016 at 19:12, Greg Kurz > wrote: > > > >

Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-05 Thread Jason Wang
On 05/06/2016 01:42 PM, Zhang Chen wrote: > > > On 04/29/2016 10:03 AM, Jason Wang wrote: >> >> On 04/28/2016 05:04 PM, Zhang Chen wrote: >>> >>> On 04/28/2016 04:17 PM, Jason Wang wrote: On 04/28/2016 03:55 PM, Zhang Chen wrote: > On 04/28/2016 03:16 PM, Jason Wang wrote: >> On 04/2

<    1   2