[Qemu-devel] [PULL 03/12] configure: build SDL if only SDL2 available

2016-05-09 Thread Gerd Hoffmann
From: Cole Robinson Right now if SDL2 is installed but not SDL1, default configure will entirely disable SDL. Check upfront for SDL2 using pkg-config, but still prefer SDL1 if both versions are installed. Signed-off-by: Cole Robinson Message-id:

[Qemu-devel] [PULL 11/12] ui/gtk: copy to clipboard support

2016-05-09 Thread Gerd Hoffmann
From: "Michael S. Tsirkin" This adds a menu item to copy current selection to clipboard. Seems handy for copying out guest error messages. Signed-off-by: Michael S. Tsirkin Message-id: 1460924740-24513-1-git-send-email-...@redhat.com [ kraxel: fix build with

[Qemu-devel] [PULL 01/12] ui: gtk: fix crash when terminal inner-border is NULL

2016-05-09 Thread Gerd Hoffmann
From: Cole Robinson VTE terminal inner-border can be NULL. The vte-0.36 (API 2.90) code checks for the condition too so I assume it's not just a bug Fixes a crash on Fedora 24 with gtk 3.20 Signed-off-by: Cole Robinson Message-id:

[Qemu-devel] [PULL 10/12] ui: gtk: Fix some deprecation warnings

2016-05-09 Thread Gerd Hoffmann
From: Cole Robinson All device manager APIs are deprecated now. Much of our usage is just to get the current pointer, so centralize that logic and use the new seat APIs Signed-off-by: Cole Robinson Message-id:

[Qemu-devel] [PULL 07/12] configure: report SDL version

2016-05-09 Thread Gerd Hoffmann
From: Cole Robinson Signed-off-by: Cole Robinson Message-id: 98e4a3b98dc824bfaff96db43b172272c780c15f.1462557436.git.crobi...@redhat.com Signed-off-by: Gerd Hoffmann --- configure | 8 1 file changed, 4 insertions(+), 4

[Qemu-devel] [PULL 05/12] configure: add echo_version helper

2016-05-09 Thread Gerd Hoffmann
From: Cole Robinson Simplifies printing library versions, dependent on if the library was even found Signed-off-by: Cole Robinson Message-id: 3c9ab16123e06bb4109771ef6ee8acd82d449ba0.1462557436.git.crobi...@redhat.com Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PULL 09/12] ui: gtk: Fix a runtime warning on vte >= 0.37

2016-05-09 Thread Gerd Hoffmann
From: Cole Robinson inner-border was dropped in vte API 2.91, in favor of the standard padding style Signed-off-by: Cole Robinson Message-id: 60a6cdc337d611d902f53907e66a8f37ea374d65.1462557436.git.crobi...@redhat.com [ kraxel: Fix warning with old

[Qemu-devel] [PULL 08/12] configure: support vte-2.91

2016-05-09 Thread Gerd Hoffmann
From: Cole Robinson vte >= 0.37 expores API version 2.91, which is where all the active development is. qemu builds and runs fine with that version, so use it if it's available. Signed-off-by: Cole Robinson Message-id:

[Qemu-devel] [PULL 02/12] ui: sdl2: Release grab before opening console window

2016-05-09 Thread Gerd Hoffmann
From: Cole Robinson sdl 2.0.4 currently has a bug which causes our UI shortcuts to fire rapidly in succession: https://bugzilla.libsdl.org/show_bug.cgi?id=3287 It's a toss up whether ctrl+alt+f or ctrl+alt+2 will fire an odd or even number of times, thus determining

[Qemu-devel] [PULL 06/12] configure: report GTK version

2016-05-09 Thread Gerd Hoffmann
From: Cole Robinson Signed-off-by: Cole Robinson Message-id: 4c464e20d69fdcf21927ceed31a8d749b4af0c49.1462557436.git.crobi...@redhat.com Signed-off-by: Gerd Hoffmann --- configure | 3 ++- 1 file changed, 2 insertions(+), 1

[Qemu-devel] [PULL 04/12] configure: error on unknown --with-sdlabi value

2016-05-09 Thread Gerd Hoffmann
From: Cole Robinson I accidentally tried --with-sdlabi="1.0", and it failed much later in a weird way. Instead, throw an error if the value isn't in our whitelist. Signed-off-by: Cole Robinson Message-id:

[Qemu-devel] [PULL 00/12] ui patch queue

2016-05-09 Thread Gerd Hoffmann
Hi, First UI pull request for 2.7. Brings a bunch of build tweaks for gtk and sdl. Fixes the gtk 3.20 deprication warnings. Some stuff piled up during the freeze. please pull, Gerd The following changes since commit 975eb6a547f809608ccb08c221552f11af25: Update version for

[Qemu-devel] [PULL 12/12] spice/gl: add & use qemu_spice_gl_monitor_config

2016-05-09 Thread Gerd Hoffmann
Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/ui/spice-display.h | 1 + ui/spice-display.c | 30 ++ 2 files changed, 31 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-09 Thread Zhang Chen
On 05/10/2016 10:57 AM, Li Zhijian wrote: On 05/06/2016 06:56 PM, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/net/net.h | 8 ++

[Qemu-devel] [PATCH v16A 17/24] qmp: Don't reuse qmp visitor after grabbing output

2016-05-09 Thread Eric Blake
The testsuite was the only client that attempted to reuse a QmpOutputVisitor for a second visit after encountering an error and/or calling qmp_output_get_qobject() on a first visit. The next patch is about to tighten the semantics to be one-shot usage of the visitor, like all other visitors

Re: [Qemu-devel] [PATCH v3 07/18] qapi: Add json output visitor

2016-05-09 Thread Eric Blake
On 05/06/2016 08:08 AM, Eric Blake wrote: > On 05/06/2016 06:31 AM, Markus Armbruster wrote: >>> So all that's left are the two output functions. Can we get rid >>> of those, and make Visitor* the only public interface, rather than >>> making every caller have to do upcasts? >> >> The two output

Re: [Qemu-devel] [PATCH 2/2] block: Inactivate all children

2016-05-09 Thread Fam Zheng
On Fri, 05/06 09:49, Kevin Wolf wrote: > Am 05.05.2016 um 02:32 hat Fam Zheng geschrieben: > > On Wed, 05/04 12:12, Kevin Wolf wrote: > > > Am 19.04.2016 um 03:42 hat Fam Zheng geschrieben: > > > > Currently we only inactivate the top BDS. Actually bdrv_inactivate > > > > should be the opposite of

[Qemu-devel] [PATCH v4 27/27] qemu-iotests: Add test case 153 for image locking

2016-05-09 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/153 | 191 +++ tests/qemu-iotests/153.out | 241 + tests/qemu-iotests/group | 1 + 3 files changed, 433 insertions(+) create mode 100755

[Qemu-devel] [PATCH v4 25/27] tests: Use null-co:// instead of /dev/null

2016-05-09 Thread Fam Zheng
With image locking, opening /dev/null can fail when multiple tests run in parallel (make -j2, for example). Use null-co:// as the null protocol doesn't do image locking. While it's arguable we could special-case /dev/null, /dev/zero, /dev/urandom etc in raw-posix driver, it is not really

[Qemu-devel] [PATCH v4 23/27] iotests: 087: Disable image lock in cases where file is shared

2016-05-09 Thread Fam Zheng
Otherwise the error handling we are expceting will be masked by the preceding image locking check, and is going to be indistinguishable because the error messages are all the same. Signed-off-by: Fam Zheng --- tests/qemu-iotests/087 | 6 ++ 1 file changed, 6 insertions(+)

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-09 Thread Li Zhijian
On 05/06/2016 06:56 PM, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/net/net.h | 8 ++ net/filter-mirror.c | 60

[Qemu-devel] [PATCH v4 24/27] iotests: Disable image locking in 085

2016-05-09 Thread Fam Zheng
The cases is about live snapshot features. Disable image locking because otherwise a few tests are going to fail because we reuse the same images at blockdev-add. Signed-off-by: Fam Zheng --- tests/qemu-iotests/085 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v4 21/27] qemu-iotests: Wait for QEMU processes before checking image in 091

2016-05-09 Thread Fam Zheng
We should wait for the QEMU process to terminate and close the image before we check the data. Signed-off-by: Fam Zheng --- tests/qemu-iotests/091 | 3 +++ tests/qemu-iotests/091.out | 1 + 2 files changed, 4 insertions(+) diff --git a/tests/qemu-iotests/091

[Qemu-devel] [PATCH v4 22/27] qemu-iotests: 030: Disable image lock when checking test image

2016-05-09 Thread Fam Zheng
The VM is running, qemu-io would fail the lock acquisition. Signed-off-by: Fam Zheng --- tests/qemu-iotests/030 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index 3ac2443..fa996ef 100755 ---

[Qemu-devel] [PATCH v4 19/27] qemu-iotests: 140: Disable image lock for qemu-io access

2016-05-09 Thread Fam Zheng
The VM is still on, the image locking check would complain. Signed-off-by: Fam Zheng --- tests/qemu-iotests/140 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/140 b/tests/qemu-iotests/140 index 49f9df4..3be656a 100755 ---

[Qemu-devel] [PATCH v4 26/27] block: Turn on image locking by default

2016-05-09 Thread Fam Zheng
Now that test cases are covered, we can turn it on. RO (shared) lock is disabled to allow existing libguestfs use cases (invoking QEMU for reading image that is exclusively locked by another QEMU). Signed-off-by: Fam Zheng --- block.c| 7 +++ blockdev.c | 2 +- 2 files

[Qemu-devel] [PATCH v4 18/27] mirror: Disable image locking on target backing chain

2016-05-09 Thread Fam Zheng
In sync=none the backing image of s->target is s->common.bs, which could be exclusively locked, the image locking wouldn't work here. Later we can update completion code to lock it after the replaced node has dropped its lock. Signed-off-by: Fam Zheng --- blockdev.c | 6 ++

[Qemu-devel] [PATCH v4 12/27] gluster: Implement .bdrv_lockf

2016-05-09 Thread Fam Zheng
Reviewed-by: Niels de Vos Signed-off-by: Fam Zheng --- block/gluster.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/block/gluster.c b/block/gluster.c index a8aaacf..f9c5050 100644 --- a/block/gluster.c +++

[Qemu-devel] [PATCH v4 20/27] qemu-iotests: 046: Move version detection out from verify_io

2016-05-09 Thread Fam Zheng
So the image lock won't complain. Signed-off-by: Fam Zheng --- tests/qemu-iotests/046 | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046 index e528b67..365658e 100755 ---

[Qemu-devel] [PATCH v4 17/27] block: Don't lock drive-backup target image in none mode

2016-05-09 Thread Fam Zheng
As a very special case, in sync=none mode, the source, as the backing image of the target, will be RO opened again, which is not accepted by image locking because the first open could be exclusive. Signed-off-by: Fam Zheng --- blockdev.c | 5 + 1 file changed, 5

[Qemu-devel] [PATCH v4 14/27] qemu-img: Add "-L" option to sub commands

2016-05-09 Thread Fam Zheng
If specified, BDRV_O_NO_LOCK flag will be set when opening the image. Signed-off-by: Fam Zheng --- qemu-img.c | 89 ++ 1 file changed, 72 insertions(+), 17 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index

[Qemu-devel] [PATCH v4 16/27] qemu-nbd: Add "--no-lock/-L" option

2016-05-09 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qemu-nbd.c| 7 ++- qemu-nbd.texi | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index c55b40f..a675a19 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -95,6 +95,7 @@ static void usage(const char

[Qemu-devel] [PATCH v4 10/27] raw-posix: Use qemu_dup

2016-05-09 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/raw-posix.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 906d5c9..4e4d0d2 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -644,15 +644,7 @@ static int

[Qemu-devel] [PATCH v4 13/27] qemu-io: Add "-L" option for BDRV_O_NO_LOCK

2016-05-09 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qemu-io.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 0598251..a601fed 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -107,6 +107,7 @@ static void open_help(void) " -r, -- open

[Qemu-devel] [PATCH v4 15/27] qemu-img: Update documentation of "-L" option

2016-05-09 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qemu-img-cmds.hx | 44 ++-- qemu-img.c | 1 + qemu-img.texi| 3 +++ 3 files changed, 26 insertions(+), 22 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index e7cded6..fa87942 100644

[Qemu-devel] [PATCH v4 09/27] osdep: Introduce qemu_dup

2016-05-09 Thread Fam Zheng
This takes care both the CLOEXEC flag and fd-path mapping for image locking. Signed-off-by: Fam Zheng --- include/qemu/osdep.h | 1 + util/osdep.c | 15 +++ 2 files changed, 16 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index

[Qemu-devel] [PATCH v4 11/27] raw-posix: Implement .bdrv_lockf

2016-05-09 Thread Fam Zheng
virtlockd in libvirt locks the first byte, we lock byte 1 to avoid the intervene. Both file and host device protocols are covered. Suggested-by: "Daniel P. Berrange" Signed-off-by: Fam Zheng --- block/raw-posix.c | 22 ++ 1 file

[Qemu-devel] [PATCH v4 05/27] block: Add bdrv_image_locked

2016-05-09 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block.c | 5 + include/block/block.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 16c7d58..bb7ebed 100644 --- a/block.c +++ b/block.c @@ -880,6 +880,11 @@ static int

[Qemu-devel] [PATCH v4 08/27] osdep: Add qemu_lock_fd and qemu_unlock_fd

2016-05-09 Thread Fam Zheng
They are wrappers of POSIX fcntl file locking, with the additional interception of open/close (through qemu_open and qemu_close) to offer a better semantics that preserves the locks across multiple life cycles of different fds on the same file. The reason to make this semantics change over the

[Qemu-devel] [PATCH v4 04/27] block: Introduce image file locking

2016-05-09 Thread Fam Zheng
Block drivers can implement this new operation .bdrv_lockf to actually lock the image in the protocol specific way. Signed-off-by: Fam Zheng --- block.c | 47 +++ include/block/block_int.h | 12 2 files

[Qemu-devel] [PATCH v4 06/27] block: Make bdrv_reopen_{commit, abort} private functions

2016-05-09 Thread Fam Zheng
As parts of the transactional reopen, they are not necessary outside block.c. Make them static. Signed-off-by: Fam Zheng --- block.c | 6 -- include/block/block.h | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH v4 02/27] qapi: Add lock-image in blockdev-add options

2016-05-09 Thread Fam Zheng
To allow overriding the default locking behavior when opening the image. Signed-off-by: Fam Zheng --- qapi/block-core.json | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 1d09079..2913f3e 100644 ---

[Qemu-devel] [PATCH v4 03/27] blockdev: Add and parse "lock-image" option for block devices

2016-05-09 Thread Fam Zheng
Honor the locking switch specified in CLI or QMP, and set the open flags for the image accordingly. Signed-off-by: Fam Zheng --- blockdev.c | 12 1 file changed, 12 insertions(+) diff --git a/blockdev.c b/blockdev.c index f1f520a..200fa56 100644 --- a/blockdev.c

[Qemu-devel] [PATCH v4 07/27] block: Handle image locking during reopen

2016-05-09 Thread Fam Zheng
Stash the locking state into BDRVReopenState. If it was locked, unlock in prepare, and lock it again when commit or abort. Signed-off-by: Fam Zheng --- block.c | 11 +++ include/block/block.h | 1 + 2 files changed, 12 insertions(+) diff --git a/block.c

[Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-09 Thread Fam Zheng
v4: Don't lock RO image. [Rich] v3: Highlight is handling of image locks during close(3) and bdrv_reopen(). A number of new patches are added consequently. Fam Zheng (27): block: Add BDRV_O_NO_LOCK qapi: Add lock-image in blockdev-add options blockdev: Add and parse "lock-image"

[Qemu-devel] [PATCH v4 01/27] block: Add BDRV_O_NO_LOCK

2016-05-09 Thread Fam Zheng
Later the block layer will automatically lock the images to avoid unexpected concurrent accesses to the same image, which will easily corrupt the metadata or user data, unless in some very special cases, like migration. The exceptional cases like shared storage migration and testing should set

Re: [Qemu-devel] [PATCH v3 08/27] osdep: Add qemu_lock_fd and qemu_unlock_fd

2016-05-09 Thread Fam Zheng
On Wed, 05/04 14:46, Richard W.M. Jones wrote: > On Thu, Apr 28, 2016 at 08:57:27PM +0800, Fam Zheng wrote: > > They are wrappers of POSIX fcntl file locking, with the additional > > interception of open/close (through qemu_open and qemu_close) to offer a > > better semantics that preserves the

Re: [Qemu-devel] [PATCH 0/3] memory: some little optimzation

2016-05-09 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Subject: Re: [PATCH 0/3] memory: some little optimzation > > > > On 20/04/2016 05:34, Gonglei wrote: > > Please see the details in each patch. > > > > Gonglei (3): > > memory: drop find_ram_block() > > exec: adjuest rcu_read_lock

[Qemu-devel] [PATCH v2 2/3] exec: adjust rcu_read_lock requirement

2016-05-09 Thread Gonglei
qemu_ram_unset_idstr() doesn't need rcu lock anymore, meanwhile make the range of rcu lock in qemu_ram_set_idstr() as small as possible. Signed-off-by: Gonglei --- exec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/exec.c b/exec.c index

[Qemu-devel] [PATCH v2 0/3] memory: some little optimizations

2016-05-09 Thread Gonglei
Please see the details in each patch. v2 -> v1: - rework an argument's name for clearity in patch 1. [Fam] - fix some typos in patch 2. [Fam] - touche block->fd directly and remove the wrappers. [Paolo] Gonglei (3): memory: drop find_ram_block() exec: adjust rcu_read_lock requirement

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Enable EL2 for the A53s and A57s

2016-05-09 Thread Alistair Francis
On Mon, May 9, 2016 at 10:01 AM, Peter Maydell wrote: > On 9 May 2016 at 17:58, Alistair Francis wrote: >> I might have to look at disabling EL3 support for the ZynqMP machine >> form the command line, as I can't boot Linux with EL3 but not

Re: [Qemu-devel] [PATCH v6] Add optionrom compatible with fw_cfg DMA version

2016-05-09 Thread Richard W.M. Jones
FWIW the response from the LLVM developers: https://llvm.org/bugs/show_bug.cgi?id=27688 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual

Re: [Qemu-devel] [PATCH v6] Add optionrom compatible with fw_cfg DMA version

2016-05-09 Thread Laszlo Ersek
On 05/09/16 18:48, Richard W.M. Jones wrote: > > Actually there's a rather more fundamental problem. In the current > linuxboot_dma.c we use asm statements at the top and bottom of the > file (outside any function). The asm statements define the header and > what I assume is the footer of the

[Qemu-devel] [PATCH] target-i386: implement CPUID[0xB] (Extended Topology Enumeration)

2016-05-09 Thread Radim Krčmář
I looked at a dozen Intel CPU that have this CPUID and all of them always had Core offset as 1 (a wasted bit when hyperthreading is disabled) and Package offset at least 4 (wasted bits at <= 4 cores). QEMU uses more compact IDs and it doesn't make much sense to change it now. I keep the SMT and

Re: [Qemu-devel] [PATCH v6 00/26] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-09 Thread Radim Krčmář
2016-05-09 19:15+0200, Radim Krčmář: > From: =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= > Date: Mon, 9 May 2016 19:04:56 +0200 > Subject: [PATCH] intel_iommu: support all masks in interrupt entry cache > invalidation > > Linux guests do not gracefully handle cases when the

Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread Eduardo Habkost
On Mon, May 09, 2016 at 03:06:18PM +0200, David Hildenbrand wrote: > > > > > > > > > > Just FYI, on other architectures (e.g. s390x), other conditions (e.g. > > > > > cpu > > > > > generation) also define if a CPU model is runnable, so the pure > > > > > availability of > > > > > features does

Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread Eduardo Habkost
On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: > On 05/06/2016 12:11 PM, Eduardo Habkost wrote: > > Extend query-cpu-definitions schema to allow it to return two new > > optional fields: "runnable" and "unavailable-features". > > "runnable" will tell if the CPU model can be run in the

[Qemu-devel] [ANNOUNCE] QEMU 2.5.1.1 CVE update released

2016-05-09 Thread Michael Roth
Hi everyone, A security update to the QEMU 2.5 series is now available at: http://wiki.qemu.org/download/qemu-2.5.1.1.tar.bz2 v2.5.1.1 is now tagged in the official qemu.git repository, and the stable-2.5 branch has been updated accordingly:

Re: [Qemu-devel] [PATCH v5 0/6] qemu-io: UI enhancements

2016-05-09 Thread Max Reitz
On 08.05.2016 05:35, Eric Blake wrote: > On 05/07/2016 09:16 PM, Eric Blake wrote: >> While working on NBD, I found myself cursing the qemu-io UI for >> not letting me test various scenarios, particularly after fixing >> NBD to serve at byte granularity [1]. And in the process of >> writing these

Re: [Qemu-devel] [PATCH v5 5/6] qemu-io: Add 'write -f' to test FUA flag

2016-05-09 Thread Max Reitz
On 08.05.2016 05:16, Eric Blake wrote: > Make it easier to test block drivers with BDRV_REQ_FUA in > .supported_write_flags, by adding the '-f' flag to qemu-io to > conditionally pass the flag through to specific writes ('write', > 'write -z', 'writev', 'aio_write', 'aio_write -z'). You'll want >

Re: [Qemu-devel] [PATCH 0/4] pci: better support for 64-bit MMIO allocation

2016-05-09 Thread Marcel Apfelbaum
On 05/09/2016 07:50 PM, Laszlo Ersek wrote: Hi Marcel, On 05/02/16 17:37, Marcel Apfelbaum wrote: Hi, First two patches allocate (max_reserved_ram - max_addr_cpu_addressable) range for PCI hotplug (for PC Machines) instead of the previous 64-bit PCI window that included only the ranges

Re: [Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by default

2016-05-09 Thread Max Reitz
On 08.05.2016 05:16, Eric Blake wrote: > There's no reason to require the user to specify a flag just so > they can pass in unaligned numbers. Keep 'read -p' and 'write -p' > as no-ops so that I don't have to hunt down and update all users > of qemu-io, but otherwise make their behavior default

Re: [Qemu-devel] [PATCH v5 2/6] qemu-io: Make 'open' subcommand more like command line

2016-05-09 Thread Max Reitz
On 08.05.2016 05:16, Eric Blake wrote: > The command line defaults to BDRV_O_UNMAP, but can use > -d to reset it. Meanwhile, the 'open' subcommand was > defaulting to no discards, with no way to set it. > > The command line has both -n and -tMODE to set a variety > of cache modes, but the 'open'

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-09 Thread Peter Maydell
On 9 May 2016 at 18:55, Peter Maydell wrote: > On 9 May 2016 at 18:53, Stefan Weil wrote: >> I suggest to apply this patch to 2.6, if this is still possible > > It is not; sorry. Note that it's only an error if you're building with -Werror, and

[Qemu-devel] [Bug 1579565] Re: ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.

2016-05-09 Thread luigiburdo
Hi Daniel i dont know from this last i have this issue other versions was building right . im affraid i deleted the rc3 i just make a test with 2.5.1 and you can see configure work, like was working in past. ** Attachment added: "qemu-configure"

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-09 Thread Peter Maydell
On 9 May 2016 at 18:53, Stefan Weil wrote: > I suggest to apply this patch to 2.6, if this is still possible It is not; sorry. thanks -- PMM

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-09 Thread Stefan Weil
Am 09.05.2016 um 18:44 schrieb Aurelien Jarno: > Recent versions of GCC report the following error when compiling > target-mips/helper.c: > > qemu/target-mips/helper.c:542:9: warning: ‘memset’ used with length > equal to number of elements without multiplication by element size >

Re: [Qemu-devel] [PATCH 4/4] hw/apci: handle 64-bit MMIO regions correctly

2016-05-09 Thread Marcel Apfelbaum
On 05/09/2016 07:54 PM, Laszlo Ersek wrote: On 05/02/16 17:37, Marcel Apfelbaum wrote: In build_crs(), the calculation and merging of the ranges already happens in 64-bit, but the entry boundaries are silently truncated to 32-bit in the call to aml_dword_memory(). Fix it by handling the 64-bit

[Qemu-devel] [PATCH RFC 2/3] vl.c: create devices by their creation priority flag

2016-05-09 Thread Marcel Apfelbaum
Create the devices by their DeviceCreationPriority order instead of the input order, however devices with the same priority will be created in the same order as before. Signed-off-by: Marcel Apfelbaum --- vl.c | 55 ++- 1

[Qemu-devel] [PATCH RFC 0/3] qdev: order devices by priority before creating them

2016-05-09 Thread Marcel Apfelbaum
This series aims to allow more devices to be used with '-device' by sorting the devices based on a predefined creation order flag before creating them. Devices like IOMMU need to be created before others, so they can leverage the DeviceCreationPriority flag introduced by the first patch to

[Qemu-devel] [PATCH RFC 1/3] qdev: add device creation priority flag

2016-05-09 Thread Marcel Apfelbaum
Some devices need to be created before others. Add a flag to DeviceClass and the means to query it. Signed-off-by: Marcel Apfelbaum --- include/hw/qdev-core.h | 13 + include/monitor/qdev.h | 1 + qdev-monitor.c | 19 +++ 3 files changed,

[Qemu-devel] [PATCH RFC 3/3] hw/pci-bridge: add the corresponding creation priority flag

2016-05-09 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/pci_bridge_dev.c | 1 + hw/pci-bridge/pci_expander_bridge.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c index 7b582e9..eb552c4 100644 ---

[Qemu-devel] [PATCH] xen-hvm: ignore background I/O sections

2016-05-09 Thread Paul Durrant
Since Xen will correctly handle accesses to unimplemented I/O ports (by returning all 1's for reads and ignoring writes) there is no need for QEMU to register backgroud I/O sections. This patch therefore adds checks to xen_io_add/del so that sections with memory-region ops pointing at

Re: [Qemu-devel] [PATCH v5 1/6] qemu-io: Add missing option documentation

2016-05-09 Thread Max Reitz
On 08.05.2016 05:16, Eric Blake wrote: > The Usage: summary is missing several options, but rather than > having to maintain it, it's simpler to just state [OPTIONS], > since the options are spelled out below. > > Commit 499afa2 added --image-opts, but forgot to document it in > --help. Likewise

[Qemu-devel] [PATCH 06/23] hw/intc/arm_gicv3: Add state information

2016-05-09 Thread Peter Maydell
From: Pavel Fedin Add state information to GICv3 object structure and implement arm_gicv3_common_reset(). This commit includes accessor functions for the fields which are stored as bitmaps in uint32_t arrays. Signed-off-by: Pavel Fedin [PMM:

[Qemu-devel] [PATCH 11/23] hw/intc/arm_gicv3: Implement GICv3 distributor registers

2016-05-09 Thread Peter Maydell
From: Shlomo Pongratz Implement the distributor registers of a GICv3. Signed-off-by: Shlomo Pongratz [PMM: significantly overhauled/rewritten: * use the new bitmap data structures * restructure register read/write to handle different

[Qemu-devel] [PATCH 07/23] hw/intc/arm_gicv3: Move irq lines into GICv3CPUState structure

2016-05-09 Thread Peter Maydell
Move the GICv3 parent_irq and parent_fiq pointers into the GICv3CPUState structure rather than giving them their own array. This will make it easy to assert the IRQ and FIQ lines for a particular CPU interface without having to know or calculate the CPU index for the GICv3CPUState we are working

[Qemu-devel] [PATCH 09/23] hw/intc/arm_gicv3: ARM GICv3 device framework

2016-05-09 Thread Peter Maydell
From: Shlomo Pongratz This patch includes the device class itself, some ID register value functions which will be needed by both distributor and redistributor, and some skeleton functions for handling interrupts coming in and going out, which will be filled in in a

[Qemu-devel] [PATCH 10/23] hw/intc/arm_gicv3: Implement functions to identify next pending irq

2016-05-09 Thread Peter Maydell
Implement the GICv3 logic to recalculate the highest priority pending interrupt for each CPU after some part of the GIC state has changed. We avoid unnecessary full recalculation where possible. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3.c| 290

[Qemu-devel] [PATCH 04/23] target-arm: Provide hook to tell GICv3 about changes of security state

2016-05-09 Thread Peter Maydell
The GICv3 CPU interface needs to know when the CPU it is attached to makes an exception level or mode transition that changes the security state, because whether it is asserting IRQ or FIQ can change depending on these things. Provide a mechanism for letting the GICv3 device register a hook to be

[Qemu-devel] [PATCH 12/23] hw/intc/arm_gicv3: Implement GICv3 redistributor registers

2016-05-09 Thread Peter Maydell
From: Shlomo Pongratz Implement the redistributor registers of a GICv3. Signed-off-by: Shlomo Pongratz [PMM: significantly overhauled/rewritten: * use the new data structures * restructure register read/write to handle different width

[Qemu-devel] [PATCH 08/23] hw/intc/arm_gicv3: Add vmstate descriptors

2016-05-09 Thread Peter Maydell
From: Pavel Fedin Add state structure descriptors for the GICv3 state. We mark the KVM GICv3 device as having a migration blocker until the code to save and restore the state in the kernel is implemented. Signed-off-by: Pavel Fedin [PMM: Adjust to

[Qemu-devel] [PATCH 14/23] hw/intc/arm_gicv3: Implement gicv3_set_irq()

2016-05-09 Thread Peter Maydell
Implement the code which updates the GIC state when an interrupt input into the GIC is asserted. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3.c| 20 +++- hw/intc/arm_gicv3_dist.c | 21 + hw/intc/arm_gicv3_redist.c |

[Qemu-devel] [PATCH 17/23] hw/intc/arm_gicv3: Implement CPU i/f SGI generation registers

2016-05-09 Thread Peter Maydell
Implement the registers in the GICv3 CPU interface which generate new SGI interrupts. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3_cpuif.c | 125 + hw/intc/arm_gicv3_redist.c | 40 +++

[Qemu-devel] [PATCH 02/23] bitops.h: Implement half-shuffle and half-unshuffle ops

2016-05-09 Thread Peter Maydell
A half-shuffle operation takes a word with zeros in the high half: ABCD EFGH IJKL MNOP and spreads the bits out so they are in every other bit of the word: 0A0B 0C0D 0E0F 0G0H 0I0J 0K0L 0M0N 0O0P A half-unshuffle performs the reverse operation. Provide functions in bitops.h

[Qemu-devel] [PATCH 18/23] hw/intc/arm_gicv3: Add IRQ handling CPU interface registers

2016-05-09 Thread Peter Maydell
Add the CPU interface registers which deal with acknowledging and dismissing interrupts. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3_cpuif.c | 436 ++ hw/intc/gicv3_internal.h | 5 + trace-events | 7

[Qemu-devel] [PATCH 15/23] hw/intc/arm_gicv3: Implement GICv3 CPU interface registers

2016-05-09 Thread Peter Maydell
Implement the CPU interface registers for the GICv3; these are CPU system registers, not MMIO registers. This commit implements all the registers which are simple accessors for GIC state, but not those which act as interfaces for acknowledging, dismissing or generating interrupts. (Those will be

[Qemu-devel] [PATCH 01/23] migration: Define VMSTATE_UINT64_2DARRAY

2016-05-09 Thread Peter Maydell
Define a VMSTATE_UINT64_2DARRAY macro, to go with the ones we already have for other type sizes. Signed-off-by: Peter Maydell --- include/migration/vmstate.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/migration/vmstate.h

[Qemu-devel] [PATCH 13/23] hw/intc/arm_gicv3: Wire up distributor and redistributor MMIO regions

2016-05-09 Thread Peter Maydell
Wire up the MMIO functions exposed by the distributor and the redistributor into MMIO regions exposed by the GICv3 device. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 05/23] target-arm: Add mp-affinity property for ARM CPU class

2016-05-09 Thread Peter Maydell
From: Pavel Fedin This allows to override default affinity IDs on a per-machine basis, and possibility to retrieve IDs will be used by vGICv3 live migration code. Signed-off-by: Pavel Fedin Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH 23/23] RFC: hw/intc/arm_gicv3_kvm: Implement get/put functions

2016-05-09 Thread Peter Maydell
From: Pavel Fedin This actually implements pre_save and post_load methods for in-kernel vGICv3. Signed-off-by: Pavel Fedin [PMM: * use decimal, not 0bnnn * fixed typo in names of ICC_APR0R_EL1 and ICC_AP1R_EL1 * completely rearranged the get and put

[Qemu-devel] [PATCH 03/23] target-arm: Define new arm_is_el3_or_mon() function

2016-05-09 Thread Peter Maydell
The GICv3 system registers need to know if the CPU is AArch64 in EL3 or AArch32 in Monitor mode. This happens to be the first part of the check for arm_is_secure(), so factor it out into a new arm_is_el3_or_mon() function that the GIC can also use. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 19/23] target-arm/machine.c: Allow user to request GICv3 emulation

2016-05-09 Thread Peter Maydell
Now we have an emulated GICv3, remove the restriction in gicv3_class_name() so that the user can request a GICv3 with -machine gic-version=3 even when not using KVM. Signed-off-by: Peter Maydell --- target-arm/machine.c | 3 +-- 1 file changed, 1 insertion(+), 2

[Qemu-devel] [PATCH 22/23] NOT-FOR-UPSTREAM: kernel: Add definitions for GICv3 attributes

2016-05-09 Thread Peter Maydell
From: Pavel Fedin This temporary patch adds kernel API definitions. Use proper header update procedure after these features are released. FIXME: not-for-upstream Signed-off-by: Pavel Fedin --- linux-headers/asm-arm64/kvm.h | 17 + 1

[Qemu-devel] [PATCH 16/23] hw/intc/arm_gicv3: Implement gicv3_cpuif_update()

2016-05-09 Thread Peter Maydell
Implement the gicv3_cpuif_update() function which deals with correctly asserting IRQ and FIQ based on the current running priority of the CPU, the priority of the highest priority pending interrupt and the CPU's current exception level and security state. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 00/23] GICv3 emulation

2016-05-09 Thread Peter Maydell
This series implements emulation of the GICv3 interrupt controller. It is based to some extent on previous patches from Shlomo and Pavel, but the bulk of it has turned out to be new code. (The combination of changing the underlying data structures, adding support for TrustZone and implementing

[Qemu-devel] [PATCH 20/23] target-arm/monitor.c: Advertise emulated GICv3 in capabilities

2016-05-09 Thread Peter Maydell
Now we have an emulated GICv3 we should advertise it via the capabilities in the monitor protocol. Signed-off-by: Peter Maydell --- target-arm/monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-arm/monitor.c b/target-arm/monitor.c

[Qemu-devel] [PATCH 21/23] hw/intc/arm_gicv3: Work around Linux assuming interrupts are group 1

2016-05-09 Thread Peter Maydell
The Linux kernel's GICv3 driver assumes that all interrupts are in group 1. This is correct if the system supports the Security extensions, because in that case the kernel cannot configure the interrupts and it must have been done already by firmware. However if the system does not support the

[Qemu-devel] [Bug 1579565] Re: ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.

2016-05-09 Thread Daniel Berrange
Ok so the log message associated with the failure is this: cc -m32 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -Wendif-labels -Wmissing-include-dirs

Re: [Qemu-devel] [PATCH v6 00/26] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-09 Thread Radim Krčmář
2016-05-05 11:25+0800, Peter Xu: > Hi, all, > > This is v6 for Intel IOMMU IR support. This series introduced quite > a few new patches based on v5. Sorry for that (Yes, Jan is > contributing to it as well, though most of which are really good > ideas for me :). Hopefully we can get its

  1   2   3   4   >