Re: [Qemu-devel] [PATCH v4 3/9] spapr: Move spapr_cpu_init() to spapr_cpu_core.c

2016-06-09 Thread David Gibson
On Fri, Jun 10, 2016 at 06:29:02AM +0530, Bharata B Rao wrote: > Start consolidating CPU init related routines in spapr_cpu_core.c. As > part of this, move spapr_cpu_init() and its dependencies from spapr.c > to spapr_cpu_core.c > > No functionality change in this patch. > > Signed-off-by: Bharat

Re: [Qemu-devel] [PATCH v4 0/9] Core based CPU hotplug for PowerPC sPAPR

2016-06-09 Thread David Gibson
On Fri, Jun 10, 2016 at 06:28:59AM +0530, Bharata B Rao wrote: > Hi, > > This is the next version of the CPU hotplug patchset for PowerPC > sPAPR target. The hotplug semantics looks like this: > > (qemu) device_add POWER8E-spapr-cpu-core,id=core2,core-id=16[,threads=4] > (qemu) device_add host-sp

Re: [Qemu-devel] [PATCH v4 1/9] qom: API to get instance_size of a type

2016-06-09 Thread David Gibson
On Fri, Jun 10, 2016 at 06:29:00AM +0530, Bharata B Rao wrote: > Add an API object_type_get_size(const char *typename) that returns the > instance_size of the give typename. > > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson This looks sensible to me, it would be nice to have an ack or

Re: [Qemu-devel] [PATCH v4 2/9] spapr: Abstract CPU core device and type specific core devices

2016-06-09 Thread David Gibson
On Fri, Jun 10, 2016 at 06:29:01AM +0530, Bharata B Rao wrote: > Add sPAPR specific abastract CPU core device that is based on generic > CPU core device. Use this as base type to create sPAPR CPU specific core > devices. > > TODO: > - Add core types for other remaining CPU types > - Handle CPU mod

Re: [Qemu-devel] [PATCH 1/1] migration: fix ram decompression race deadlock

2016-06-09 Thread Amit Shah
On (Tue) 24 May 2016 [08:35:32], Denis V. Lunev wrote: > On 05/24/2016 05:07 AM, Li, Liang Z wrote: > > Thanks for your patch! And it can help to fix this issue. > > Actually, the is not the only issue in the current multi-thread > > (de)compression code. > > So I submitted a path set to fix all

Re: [Qemu-devel] [RFC] hw/i386: Composite Bus and PCI device

2016-06-09 Thread Jan Kiszka
On 2016-06-08 17:25, Eduardo Habkost wrote: > On Wed, Jun 08, 2016 at 01:00:32PM +0300, David Kiarie wrote: >> Sample composite SysBus and PCI device similar to AMD IOMMU setup >> >> Signed-off-by: David Kiarie >> --- >> hw/i386/compositedevice.c | 113 >>

Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files

2016-06-09 Thread Gerd Hoffmann
On Do, 2016-06-09 at 17:57 +0100, Daniel P. Berrange wrote: > - $(INSTALL_DATA) $(SRC_PATH)/trace-events > "$(DESTDIR)$(qemu_datadir)/trace-events" > + $(INSTALL_DATA) $(SRC_PATH)/trace-events-all > "$(DESTDIR)$(qemu_datadir)/trace-events" $(BUILD_DIR)/trace-events-all ? cheers, Ger

[Qemu-devel] [PATCH v4] spapr: Ensure all LMBs are represented in ibm, dynamic-memory

2016-06-09 Thread Bharata B Rao
Memory hotplug can fail for some combinations of RAM and maxmem when DDW is enabled in the presence of devices like nec-usb-xhci. DDW depends on maximum addressable memory returned by guest and this value is currently being calculated wrongly by the guest kernel routine memory_hotplug_max(). While

Re: [Qemu-devel] [PATCH v3] spapr: Ensure all LMBs are represented in ibm, dynamic-memory

2016-06-09 Thread Bharata B Rao
On Thu, Jun 09, 2016 at 12:03:30PM +1000, David Gibson wrote: > On Wed, Jun 08, 2016 at 10:05:12AM -0500, Michael Roth wrote: > > Quoting Bharata B Rao (2016-06-07 21:35:54) > > > On Tue, Jun 07, 2016 at 06:37:28PM -0500, Michael Roth wrote: > > > > Quoting Bharata B Rao (2016-06-07 00:19:03) > > >

Re: [Qemu-devel] [QEMU RFC PATCH v4 0/6] migration: ensure hotplug and migration work together

2016-06-09 Thread Amit Shah
On (Thu) 09 Jun 2016 [10:59:51], Jianjun Duan wrote: > Yesterday I got delivery failure for all the recipients with email > address at @redhat.com. Can somebody from Red Hat confirm if you have > received the patches? If not I will resend them. I only received patches 2, 4 and 5. Best to re-send.

[Qemu-devel] [PATCH 2/4] checkpatch: There is no qemu_strtod()

2016-06-09 Thread Eric Blake
Maybe there should be; but until there is, we should not flag strtod() calls as something to replaced with qemu_strtod(). We also lack qemu_strtof() and qemu_strtold(), but as no one has been using strtof() or strtold(), it's not worth complicating the regex for them. (Ironically, I had to use 'g

[Qemu-devel] [PATCH 4/4] qobject: Output valid JSON for non-finite numbers

2016-06-09 Thread Eric Blake
It's better to give downstream clients a valid JSON string, even if they are semantically expecting a number, than it is to give them a bare keyword extension that can cause a lexical error. Of course, as long as we don't recognize (certain) strings as valid numbers during a conversion to QObject,

[Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comments

2016-06-09 Thread Eric Blake
Fix the regex comments describing what we parse as JSON. No change to the lexer itself, just to the comments: - The "" and '' string construction was missing alternation between different escape sequences - The construction for numbers forgot to handle optional leading '-' - The construction for n

[Qemu-devel] [PATCH 0/4] Guarantee valid JSON in QMP, even for nonfinite numbers

2016-06-09 Thread Eric Blake
Flesh out an idea that came up during my JSON visitor series. Semantic errors are nicer than lexical errors. While we generally consider any non-finite number a bug in our code (that is, we don't plan to expose them over QMP), at least we can guarantee that even with a bug in our code we are still

[Qemu-devel] [PATCH 3/4] qobject: Parse non-finite numbers, as an extension

2016-06-09 Thread Eric Blake
There have been times in the past where we have been careless and allowed non-finite values to escape as a 'number' type in QMP output (such as before commit 27ff42e). This is in violation of the JSON specification in RFC 7159, and usually caused by floating-point division by 0 resulting in NaN, a

[Qemu-devel] [PATCH v4 9/9] spapr: implement query-hotpluggable-cpus callback

2016-06-09 Thread Bharata B Rao
From: Igor Mammedov It returns a list of present/possible to hotplug CPU objects with a list of properties to use with device_add. in spapr case returned list would looks like: -> { "execute": "query-hotpluggable-cpus" } <- {"return": [ { "props": { "core": 8 }, "type": "POWER8-spapr-cpu-co

[Qemu-devel] [PATCH v4 7/9] QMP: Add query-hotpluggable-cpus

2016-06-09 Thread Bharata B Rao
From: Igor Mammedov It will allow mgmt to query present and hotpluggable CPU objects, it is required from a target platform that wishes to support command to implement and set MachineClass.query_hotpluggable_cpus callback, which will return a list of possible CPU objects with options that would b

[Qemu-devel] [PATCH v4 8/9] hmp: Add 'info hotpluggable-cpus' HMP command

2016-06-09 Thread Bharata B Rao
This is the HMP equivalent for QMP query-hotpluggable-cpus. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- hmp-commands-info.hx | 14 ++ hmp.c| 41 + hmp.h| 1 + 3 files changed, 56 insertions(+) d

[Qemu-devel] [PATCH v4 6/9] spapr: CPU hot unplug support

2016-06-09 Thread Bharata B Rao
Remove the CPU core device by removing the underlying CPU thread devices. Hot removal of CPU for sPAPR guests is achieved by sending the hot unplug notification to the guest. Release the vCPU object after CPU hot unplug so that vCPU fd can be parked and reused. Signed-off-by: Bharata B Rao --- h

[Qemu-devel] [PATCH v4 3/9] spapr: Move spapr_cpu_init() to spapr_cpu_core.c

2016-06-09 Thread Bharata B Rao
Start consolidating CPU init related routines in spapr_cpu_core.c. As part of this, move spapr_cpu_init() and its dependencies from spapr.c to spapr_cpu_core.c No functionality change in this patch. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 47 --

[Qemu-devel] [PATCH v4 4/9] spapr: convert boot CPUs into CPU core devices

2016-06-09 Thread Bharata B Rao
Introduce sPAPRMachineClass.dr_cpu_enabled to indicate support for CPU core hotplug. Initialize boot time CPUs as core deivces and prevent topologies that result in partially filled cores. Both of these are done only if CPU core hotplug is supported. Note: An unrelated change in the call to xics_s

[Qemu-devel] [PATCH v4 0/9] Core based CPU hotplug for PowerPC sPAPR

2016-06-09 Thread Bharata B Rao
Hi, This is the next version of the CPU hotplug patchset for PowerPC sPAPR target. The hotplug semantics looks like this: (qemu) device_add POWER8E-spapr-cpu-core,id=core2,core-id=16[,threads=4] (qemu) device_add host-spapr-cpu-core,id=core2,core-id=16[,threads=4] (qemu) device_add POWER8E_v2.1-s

[Qemu-devel] [PATCH v4 1/9] qom: API to get instance_size of a type

2016-06-09 Thread Bharata B Rao
Add an API object_type_get_size(const char *typename) that returns the instance_size of the give typename. Signed-off-by: Bharata B Rao --- include/qom/object.h | 8 +++- qom/object.c | 8 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/include/qom/object.h b/

[Qemu-devel] [PATCH v4 2/9] spapr: Abstract CPU core device and type specific core devices

2016-06-09 Thread Bharata B Rao
Add sPAPR specific abastract CPU core device that is based on generic CPU core device. Use this as base type to create sPAPR CPU specific core devices. TODO: - Add core types for other remaining CPU types - Handle CPU model alias correctly Signed-off-by: Bharata B Rao --- hw/ppc/Makefile.objs

[Qemu-devel] [PATCH v4 5/9] spapr: CPU hotplug support

2016-06-09 Thread Bharata B Rao
Set up device tree entries for the hotplugged CPU core and use the exising RTAS event logging infrastructure to send CPU hotplug notification to the guest. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- hw/ppc/spapr.c | 78 +--- h

Re: [Qemu-devel] [PATCH] hw/timer: Add value matching support to aspeed_timer

2016-06-09 Thread Andrew Jeffery
On Thu, 2016-06-09 at 19:15 +0100, Peter Maydell wrote: > On 27 May 2016 at 06:08, Andrew Jeffery wrote: > > > > Value matching allows Linux to boot with CONFIG_NO_HZ_IDLE=y on the > > palmetto-bmc machine. Two match registers are provided for each timer. > > > > Signed-off-by: Andrew Jeffery >

Re: [Qemu-devel] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 02:57:08PM -0600, Eric Blake wrote: > On 06/09/2016 02:21 PM, Eduardo Habkost wrote: > > This patch simplifies code that uses a local_err variable just to > > immediately > > use it for an error_propagate() call. > > > > Done using the following Coccinelle patch: > > > >

Re: [Qemu-devel] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 02:54:51PM -0600, Eric Blake wrote: > On 06/09/2016 02:47 PM, Eduardo Habkost wrote: > > On Thu, Jun 09, 2016 at 05:21:34PM -0300, Eduardo Habkost wrote: > >> This patch simplifies code that uses a local_err variable just to > >> immediately > >> use it for an error_propaga

[Qemu-devel] exec: Safe work in quiescent state

2016-06-09 Thread Sergey Fedorov
Hi, For certain kinds of tasks we might need a quiescent state to perform an operation safely. Quiescent state means no CPU thread executing, and probably BQL held as well. The tasks could include: - Translation buffer flush (user and system-mode) - Cross-CPU TLB flush (system-mode) - Exclusive op

Re: [Qemu-devel] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eric Blake
On 06/09/2016 02:21 PM, Eduardo Habkost wrote: > This patch simplifies code that uses a local_err variable just to immediately > use it for an error_propagate() call. > > Done using the following Coccinelle patch: > > +++ b/block.c > @@ -353,7 +353,6 @@ out: > int bdrv_create_file(const char *f

Re: [Qemu-devel] [PULL 00/44] linux-user update

2016-06-09 Thread Peter Maydell
On 9 June 2016 at 21:19, Laurent Vivier wrote: > All the work around the signal management really improves the quality of > QEMU linux-user. > > For instance, I thought for years that "dbench" cannot work correctly in > linux-user mode because the thread is stuck in a wait() and all the > state ma

Re: [Qemu-devel] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eric Blake
On 06/09/2016 02:47 PM, Eduardo Habkost wrote: > On Thu, Jun 09, 2016 at 05:21:34PM -0300, Eduardo Habkost wrote: >> This patch simplifies code that uses a local_err variable just to immediately >> use it for an error_propagate() call. > > Please ignore this one. I found a better way to tell Cocci

Re: [Qemu-devel] [Bug 1590336] Re: qemu-arm does not reject vrintz on non-v8 cpu

2016-06-09 Thread Peter Maydell
On 9 June 2016 at 20:14, Christophe Lyon wrote: > You may still want to fix the disassembler such that it dumps the right > instruction, but that would be a separate fix. Unfortunately the disassembler is the pre-GPLv3 binutils one, so we can't just update it (and I'm not particularly inclined to

Re: [Qemu-devel] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 05:21:34PM -0300, Eduardo Habkost wrote: > This patch simplifies code that uses a local_err variable just to immediately > use it for an error_propagate() call. Please ignore this one. I found a better way to tell Coccinelle to do that. Updated Coccinelle patch is below, bu

Re: [Qemu-devel] [PATCH v2 2/6] target-i386: print obsolete warnings if +-features are used

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 07:10:59PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Applied to x86-next after changing it to use error_report(). > --- > target-i386/cpu.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 947c

[Qemu-devel] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eduardo Habkost
This patch simplifies code that uses a local_err variable just to immediately use it for an error_propagate() call. Done using the following Coccinelle patch: @@ expression R; expression list ARGS; type T; identifier F1, F2; identifier LOCAL_ERR; identifier ERRP; idexpression V;

Re: [Qemu-devel] [PATCH] error: Remove NULL checks on error_propagate() calls

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 02:11:23PM -0600, Eric Blake wrote: > On 06/09/2016 01:50 PM, Eduardo Habkost wrote: > > On Thu, Jun 09, 2016 at 01:37:23PM -0600, Eric Blake wrote: > > [...] > >> > >> Hmm - it seems like in most of the cases where the ONLY thing done in > >> the if (local_err) block is to

Re: [Qemu-devel] [PULL 00/44] linux-user update

2016-06-09 Thread Laurent Vivier
Le 08/06/2016 à 15:29, riku.voi...@linaro.org a écrit : > From: Riku Voipio > > The following changes since commit 76462405809d29bab65a3699686998ba124ab942: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20160606-1' into staging (2016-06-06 > 17:02:42 +0100) > >

Re: [Qemu-devel] [PATCH] error: Remove NULL checks on error_propagate() calls

2016-06-09 Thread Eric Blake
On 06/09/2016 01:50 PM, Eduardo Habkost wrote: > On Thu, Jun 09, 2016 at 01:37:23PM -0600, Eric Blake wrote: > [...] >> >> Hmm - it seems like in most of the cases where the ONLY thing done in >> the if (local_err) block is to propagate the error, we should instead be >> directly assigning to errp

Re: [Qemu-devel] [PATCH v7 00/15] tb hash improvements

2016-06-09 Thread Sergey Fedorov
On 08/06/16 21:55, Emilio G. Cota wrote: > v6 on qemu-devel: > https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg04251.html > > All changes in this iteration come from comments by Sergey > unless otherwise noted. All patches are checkpatch-clean > once false positives are taken into accoun

Re: [Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 01:39:34PM -0600, Eric Blake wrote: > On 06/09/2016 11:29 AM, Eduardo Habkost wrote: > > On Thu, Jun 09, 2016 at 07:10:58PM +0200, Igor Mammedov wrote: > > [...] > >> + > >> +if (local_err) { > >> +error_propagate(errp, local_err); > >> } > > > > error_prop

Re: [Qemu-devel] [PATCH] error: Remove NULL checks on error_propagate() calls

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 01:37:23PM -0600, Eric Blake wrote: [...] > > Hmm - it seems like in most of the cases where the ONLY thing done in > the if (local_err) block is to propagate the error, we should instead be > directly assigning to errp instead of wasting a local variable. At this > point,

Re: [Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-09 Thread Eric Blake
On 06/09/2016 11:29 AM, Eduardo Habkost wrote: > On Thu, Jun 09, 2016 at 07:10:58PM +0200, Igor Mammedov wrote: > [...] >> + >> +if (local_err) { >> +error_propagate(errp, local_err); >> } > > error_propagate() already ignores local_err==NULL so you don't > need to check it first.

Re: [Qemu-devel] [PATCH] error: Remove NULL checks on error_propagate() calls

2016-06-09 Thread Eric Blake
On 06/09/2016 11:40 AM, Eduardo Habkost wrote: > error_propagate() already ignores local_err==NULL, so there's no > need to check it before calling. > > Done using the following Coccinelle patch: > > @@ > identifier L; > expression E; > @@ > -if (L) { >error_propagate(E, L); >

Re: [Qemu-devel] [PATCH v2 3/3] linux-user: Use safe_syscall wrapper for fcntl

2016-06-09 Thread Laurent Vivier
Le 09/06/2016 à 16:09, Peter Maydell a écrit : > Use the safe_syscall wrapper for fcntl. This is straightforward now > that we always use 'struct fcntl64' on the host, as we don't need > to select whether to call the host's fcntl64 or fcntl syscall > (a detail that the libc previously hid for us)

Re: [Qemu-devel] [PATCH v2 2/3] linux-user: Use __get_user() and __put_user() to handle structs in do_fcntl()

2016-06-09 Thread Laurent Vivier
Le 09/06/2016 à 16:09, Peter Maydell a écrit : > Use the __get_user() and __put_user() to handle reading and writing the > guest structures in do_ioctl(). This has two benefits: > * avoids possible errors due to misaligned guest pointers > * correctly sign extends signed fields (like l_start in

Re: [Qemu-devel] [PATCH v2 1/3] linux-user: Avoid possible misalignment in host_to_target_siginfo()

2016-06-09 Thread Laurent Vivier
Le 09/06/2016 à 16:09, Peter Maydell a écrit : > host_to_target_siginfo() is implemented by a combination of > host_to_target_siginfo_noswap() followed by tswap_siginfo(). > The first of these two functions assumes that the target_siginfo_t > it is writing to is correctly aligned, but the pointer

[Qemu-devel] [Bug 1590336] Re: qemu-arm does not reject vrintz on non-v8 cpu

2016-06-09 Thread Christophe Lyon
I confirm your patch does fix the problem. You may still want to fix the disassembler such that it dumps the right instruction, but that would be a separate fix. Thanks for your quick support. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH v6 02/13] register: Add Register API

2016-06-09 Thread Peter Maydell
On 12 May 2016 at 23:45, Alistair Francis wrote: > This API provides some encapsulation of registers and factors our some "out" > common functionality to common code. Bits of device state (usually MMIO > registers), often have all sorts of access restrictions and semantics spurious comma > ass

Re: [Qemu-devel] [PATCH] target-arm: Don't permit ARMv8-only Neon insns on ARMv7

2016-06-09 Thread Christophe Lyon
On 9 June 2016 at 19:15, Peter Maydell wrote: > The Neon instructions VCVTA, VCVTM, VCVTN, VCVTP, VRINTA, VRINTM, > VRINTN, VRINTP, VRINTX, and VRINTZ were only introduced with ARMv8, > so they need a guard to make them UNDEF if the CPU only supports ARMv7. > (We got this right for all the other n

[Qemu-devel] [PATCH v1 37/40] trace: split out trace events for target-s390x/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the target-s390x/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + target-s390x/trace-events | 46 ++ trace-events | 21 - 3 files c

[Qemu-devel] [PATCH] error: Remove NULL checks on error_propagate() calls

2016-06-09 Thread Eduardo Habkost
error_propagate() already ignores local_err==NULL, so there's no need to check it before calling. Done using the following Coccinelle patch: @@ identifier L; expression E; @@ -if (L) { error_propagate(E, L); -} Signed-off-by: Eduardo Habkost --- block.c | 20 ++

[Qemu-devel] [PATCH v2 1/6] trace: Identify events with the 'vcpu' property

2016-06-09 Thread Lluís Vilanova
A new event attribute 'cpu_id' is added to have a separate ID space ('TRACE_VCPU_*') for all events with the 'vcpu' property. These are later used to identify which events are enabled on each vCPU. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- scripts/tracetool/format/events_c

[Qemu-devel] [PATCH v2 2/6] disas: Remove unused macro '_'

2016-06-09 Thread Lluís Vilanova
Eliminates a future compilation error when UI code includes the tracing headers (indirectly pulling "disas/bfd.h" through "qom/cpu.h") and GLib's i18n '_' macro. Signed-off-by: Lluís Vilanova --- disas/alpha.c |6 +++--- disas/arm.c |2 +- disas/i386.c|2 +- dis

[Qemu-devel] [PATCH v1 35/40] trace: split out trace events for net/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the net/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + net/trace-events | 29 + trace-events | 3 --- 3 files changed, 30 insertions(+), 3 deletions(-) create mode 100644 net/trace-

Re: [Qemu-devel] [PATCH 03/10] target-i386: cpu: move xcc->kvm_required check to realize time

2016-06-09 Thread Eduardo Habkost
On Mon, Jun 06, 2016 at 05:16:45PM +0200, Igor Mammedov wrote: > it will allow to drop custom cpu_x86_init() and use > cpu_generic_init() insteadi, reducing cpu_x86_create() > to a simple 3-liner. > > Signed-off-by: Igor Mammedov > Eduardo Habkost This triggers an assert when trying to use -cpu

Re: [Qemu-devel] [PATCH v1 00/40] Split up the trace-events file

2016-06-09 Thread Lluís Vilanova
Daniel P Berrange writes: > To quote Peter today: > pm215: "trace-events: causing merge conflicts since 2010" [...] Silly note. You can skip the documentation header on all trace-events file and just reference a single global one (is /trace-events gonna survive for some events?). Otherwise it's

[Qemu-devel] [PATCH v2 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-09 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- monitor.c |4 +- qapi/trace.json | 20 ++-- qmp-commands.hx | 18 ++- trace/qmp.c | 143 --- 4 files changed, 147 insertions(+), 38 deletions(-) diff --g

Re: [Qemu-devel] [PATCH 4/5] hw/arm/virt: introduce DEFINE_VIRT_MACHINE_AS_LATEST

2016-06-09 Thread Peter Maydell
On 8 June 2016 at 19:24, Andrew Jones wrote: > Create two variants of DEFINE_VIRT_MACHINE. One, just called > DEFINE_VIRT_MACHINE, that does not set properties that only > the latest machine type should have, and another that does. > This will hopefully reduce potential for errors when adding > ne

[Qemu-devel] [PATCH v1 23/40] trace: split out trace events for hw/isa/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/isa/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/isa/trace-events | 34 ++ trace-events| 8 3 files changed, 35 insertions(+), 8 deletions(-) create

[Qemu-devel] [PATCH] target-arm: Don't permit ARMv8-only Neon insns on ARMv7

2016-06-09 Thread Peter Maydell
The Neon instructions VCVTA, VCVTM, VCVTN, VCVTP, VRINTA, VRINTM, VRINTN, VRINTP, VRINTX, and VRINTZ were only introduced with ARMv8, so they need a guard to make them UNDEF if the CPU only supports ARMv7. (We got this right for all the other new-in-v8 insns, but forgot it for these Neon 2-reg-misc

Re: [Qemu-devel] [PATCH v6 03/13] register: Add Memory API glue

2016-06-09 Thread Peter Maydell
On 12 May 2016 at 23:45, Alistair Francis wrote: > Add memory io handlers that glue the register API to the memory API. > Just translation functions at this stage. Although it does allow for > devices to be created without all-in-one mmio r/w handlers. > > This patch also adds the RegisterInfoArra

[Qemu-devel] [PATCH v2 4/6] cpu: use CPUClass->parse_features() as convertor to global properties

2016-06-09 Thread Igor Mammedov
Currently CPUClass->parse_features() is used to parse -cpu features string and set properties on created CPU instances. But considering that features specified by -cpu apply to every created CPU instance, it doesn't make sence to parse the same features string for every CPU created. It also makes

[Qemu-devel] [PATCH v5 2/2] trace: [all] Add "guest_mem_before" event

2016-06-09 Thread Lluís Vilanova
The event is described in "trace-events". Note that the "MO_AMASK" flag is not traced, since it does not seem to affect the visible semantics of instructions. Signed-off-by: Lluís Vilanova --- include/exec/cpu_ldst_template.h | 25 include/exec/cpu_ldst_useronly_templ

[Qemu-devel] [PATCHv20/6] trace: Per-vCPU tracing states

2016-06-09 Thread Lluís Vilanova
NOTE: This series applies on top of "trace: Show vCPU info in guest code events" Provides per-vCPU dynamic controls of the tracing state of events with the "vcpu" property. A later series proposes an optimization where tracing code can be elided for dynamically disabled events (it uses multiple v

[Qemu-devel] [PATCH v1 36/40] trace: split out trace events for target-sparc/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the target-sparc/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + target-sparc/trace-events | 53 +++ trace-events | 27 3 fil

[Qemu-devel] [PATCH v1 21/40] trace: split out trace events for hw/sparc/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/sparc/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/sparc/trace-events | 36 trace-events | 10 -- 3 files changed, 37 insertions(+), 10 deletion

[Qemu-devel] [PATCH v1 40/40] trace: split out trace events for linux-user/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the linux-user/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + linux-user/trace-events | 37 + trace-events| 11 --- 3 files changed, 38 insertions(+), 1

[Qemu-devel] [PATCH v1 24/40] trace: split out trace events for hw/i386/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/i386/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/i386/trace-events | 37 + trace-events | 11 --- 3 files changed, 38 insertions(+), 11 deletions(

Re: [Qemu-devel] [QEMU RFC PATCH v4 0/6] migration: ensure hotplug and migration work together

2016-06-09 Thread Jianjun Duan
Yesterday I got delivery failure for all the recipients with email address at @redhat.com. Can somebody from Red Hat confirm if you have received the patches? If not I will resend them. Thanks, Jianjun On 06/08/2016 04:06 PM, Jianjun Duan wrote: > v4: - Introduce a way to set customized instance_

[Qemu-devel] [PATCH v5 0/2] trace: Add event for vCPU memory accesses

2016-06-09 Thread Lluís Vilanova
This series adds an event to track information related to memory accesses performed by the guest CPUs ("guest_mem_before"). A future series might extend this to contain the physical address and memory value (e.g., "guest_mem_after"). Signed-off-by: Lluís Vilanova --- Changes in v5 -

[Qemu-devel] [PATCH v1 34/40] trace: split out trace events for audio/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the audio/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + audio/trace-events | 42 ++ trace-events | 16 3 files changed, 43 insertions(+), 16 deletion

Re: [Qemu-devel] [PATCH 3/5] hw/arm/virt: introduce DEFINE_VIRT_MACHINE

2016-06-09 Thread Peter Maydell
On 8 June 2016 at 19:24, Andrew Jones wrote: > Use DEFINE_VIRT_MACHINE to generate versioned machine type info. > > Signed-off-by: Andrew Jones > --- > hw/arm/virt.c | 40 +++- > 1 file changed, 23 insertions(+), 17 deletions(-) Checkpatch complains about a l

[Qemu-devel] [PATCH v2 3/6] target-sparc: cpu: use sparc_cpu_parse_features() directly

2016-06-09 Thread Igor Mammedov
make SPARC target use sparc_cpu_parse_features() directly so it won't get in the way of switching other propertified targets to handling features as global properties. Signed-off-by: Igor Mammedov --- SPARC target could be switched to features properties later but that would need quite a bit of r

[Qemu-devel] [PATCH v1 15/40] trace: split out trace events for hw/scsi/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/scsi/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/scsi/trace-events | 229 +++ trace-events | 203

[Qemu-devel] [PATCH v1 14/40] trace: split out trace events for hw/usb/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/usb/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/usb/trace-events | 293 trace-events| 267 ---

[Qemu-devel] [PATCH v2 0/6] cpus: make "-cpu cpux, features" global properties

2016-06-09 Thread Igor Mammedov
Changelog: since v1: - rebase on top of x86-next tree, which shaves off already applied several patches and fixed deps on wrong tree (v1 was against my device_add_cpu tree) - add TODO comments - set cpu_globals_initialized = true early - move error_propagate() to the end of

Re: [Qemu-devel] [PATCH v6 01/13] bitops: Add MAKE_64BIT_MASK macro

2016-06-09 Thread Peter Maydell
On 12 May 2016 at 23:45, Alistair Francis wrote: > Add a macro that creates a 64bit value which has length number of ones > shifted acrros by the value of shift. "across" > > Signed-off-by: Alistair Francis > Reviewed-by: Alex Bennée > --- > V5: > - Re-write to a 64-bit mask instead of ONES()

[Qemu-devel] [PATCH v1 10/40] trace: split out trace events for hw/net/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/net/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/net/trace-events | 297 trace-events| 271 ---

[Qemu-devel] [Bug 1590336] Re: qemu-arm does not reject vrintz on non-v8 cpu

2016-06-09 Thread Peter Maydell
Should be fixed by http://patchwork.ozlabs.org/patch/633105/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1590336 Title: qemu-arm does not reject vrintz on non-v8 cpu Status in QEMU: New Bug d

Re: [Qemu-devel] [PATCH 1/5] hw/arm/virt: separate versioned type-init code

2016-06-09 Thread Peter Maydell
On 8 June 2016 at 19:24, Andrew Jones wrote: > Rename machvirt_info (which is specifically for 2.6 TypeInfo) > to machvirt_2_6_info, and separate the type registration of the > abstract machine type from the versioned type. > > Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell thanks -- P

[Qemu-devel] [PATCH v1 25/40] trace: split out trace events for hw/9pfs/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/9pfs/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/9pfs/trace-events | 72 trace-events | 46 - 3 files cha

Re: [Qemu-devel] [PATCH 2/5] hw/arm/virt: set is_default

2016-06-09 Thread Peter Maydell
On 8 June 2016 at 19:24, Andrew Jones wrote: > Make the latest machine type (currently only one) the > default. > > Signed-off-by: Andrew Jones > --- > hw/arm/virt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index a0d35d0826590..09afbafde025d 100644

[Qemu-devel] [PATCH] Makefile: Fix tag file generation targets

2016-06-09 Thread Sergey Fedorov
From: Sergey Fedorov "ctags" produces a file named "tags", not "ctags". It doesn't look reasonable to use phony target name as a file name to remove. Just use exact file names to remove in "ctags" and "TAGS" target receipts. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov --- Make

Re: [Qemu-devel] [PATCH 00/17] some ARM platform QOM'ify work

2016-06-09 Thread Peter Maydell
On 7 June 2016 at 11:34, xiaoqiang zhao wrote: > This patch series QOM'ify ARM platform related devices. > Where we drop the sysbus init function if possible and use > instance_init and DeviceClass::realize function. > > xiaoqiang zhao (17): > hw/i2c: QOM'ify bitbang_i2c.c > hw/i2c: QOM'ify ex

[Qemu-devel] [PATCH v1 27/40] trace: split out trace events for hw/pci/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/pci/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/pci/trace-events | 34 ++ trace-events| 8 3 files changed, 35 insertions(+), 8 deletions(-) create

Re: [Qemu-devel] [PATCH V9 0/9] Xilinx DisplayPort.

2016-06-09 Thread Peter Maydell
On 7 June 2016 at 22:39, Alistair Francis wrote: > On Tue, Jun 7, 2016 at 1:30 PM, wrote: >> From: KONRAD Frederic > > Hey Peter, > > These are all reviewed by Xilinx, this is ready to merge from our point of > view. This series breaks 'make check'. Specifically, the patch "i2c: implement bro

Re: [Qemu-devel] coroutines: block: Co-routine re-entered recursively when migrating disk with iothreads

2016-06-09 Thread Jason J. Herne
On 06/09/2016 12:31 PM, Stefan Hajnoczi wrote: On Mon, May 23, 2016 at 7:54 PM, Jason J. Herne wrote: Libvirt migration command: virsh migrate --live --persistent --copy-storage-all --migrate-disks vdb kvm1 qemu+ssh://dev1/system I guess that this is the same scenario as a manual drive_mirror

[Qemu-devel] [PATCH v2 5/6] trace: Conditionally trace events based on their per-vCPU state

2016-06-09 Thread Lluís Vilanova
Events with the 'vcpu' property are conditionally emitted according to their per-vCPU state. Other events are emitted normally based on their global tracing state. Note that the per-vCPU condition check applies to all tracing backends. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v1 26/40] trace: split out trace events for hw/ppc/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/ppc/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/ppc/trace-events | 64 + trace-events| 38 --- 3 files changed,

Re: [Qemu-devel] [PATCH v7 2/3] generic-loader: Add a generic loader

2016-06-09 Thread Peter Maydell
On 25 May 2016 at 19:49, Alistair Francis wrote: > Add a generic loader to QEMU which can be used to load images or set > memory values. > > Signed-off-by: Alistair Francis > --- > V7: > - Rebase > V6: > - Add error checking > V5: > - Rebase > V4: > - Allow the loader to work with every archi

Re: [Qemu-devel] [PATCH] hw/timer: Add value matching support to aspeed_timer

2016-06-09 Thread Peter Maydell
On 27 May 2016 at 06:08, Andrew Jeffery wrote: > Value matching allows Linux to boot with CONFIG_NO_HZ_IDLE=y on the > palmetto-bmc machine. Two match registers are provided for each timer. > > Signed-off-by: Andrew Jeffery > --- > > The change pulls out ptimer in favour of the regular timer infr

Re: [Qemu-devel] [PATCH v4 2/2] trace: [all] Add "guest_mem_before" event

2016-06-09 Thread Lluís Vilanova
Richard Henderson writes: > On 05/27/2016 09:01 AM, Lluís Vilanova wrote: >> -void tcg_gen_qemu_ld_i32(TCGv_i32 val, TCGv addr, TCGArg idx, TCGMemOp >> memop) >> +static inline void do_tcg_gen_qemu_ld_i32(TCGv_i32 val, TCGv addr, TCGArg >> idx, >> + TCGMe

[Qemu-devel] [PATCH v2 2/6] target-i386: print obsolete warnings if +-features are used

2016-06-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 947cf18..3f886a5 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1979,9 +1979,15 @@ static void x86_cpu_parse_featurestr(CPUState *cs

[Qemu-devel] [PATCH v2 6/6] pc: parse cpu features only once

2016-06-09 Thread Igor Mammedov
considering that features are converted to global properties and global properties are automatically applied to every new instance of created CPU (at object_new() time), there is no point in parsing cpu_model string every time a CPU created. So move parsing outside CPU creation loop and do it only

Re: [Qemu-devel] [PATCH v7 3/3] docs: Add a generic loader explanation document

2016-06-09 Thread Peter Maydell
On 25 May 2016 at 19:49, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > V6: > - Fixup documentation > V4: > - Re-write to be more comprehensive > > docs/generic-loader.txt | 54 > + > 1 file changed, 54 insertions(+) > create

Re: [Qemu-devel] [PATCH v7 1/3] loader: Allow ELF loader to auto-detect the ELF arch

2016-06-09 Thread Peter Maydell
On 25 May 2016 at 19:49, Alistair Francis wrote: > If the caller didn't specify an architecture for the ELF machine > the load_elf() function will auto detect it based on the ELF file. > > Signed-off-by: Alistair Francis > --- > V7: > - Fix typo > > hw/core/loader.c | 10 ++ > 1 file ch

[Qemu-devel] [PATCH v1 19/40] trace: split out trace events for hw/timer/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/timer/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/timer/trace-events | 76 +++ trace-events | 50 - 3 files

[Qemu-devel] [PATCH v2 5/6] arm: virt: parse cpu_model only once

2016-06-09 Thread Igor Mammedov
considering that features are converted to global properties and global properties are automatically applied to every new instance of created CPU (at object_new() time), there is no point in parsing cpu_model string every time a CPU created. So move parsing outside CPU creation loop and do it only

[Qemu-devel] [PATCH v1 39/40] trace: split out trace events for qom/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the qom/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + qom/trace-events | 30 ++ trace-events | 4 3 files changed, 31 insertions(+), 4 deletions(-) create mode 100644 qom/trac

  1   2   3   >