Re: [Qemu-devel] [PATCH 3/9] mirror: optimize dirty bitmap filling in mirror_run a bit

2016-06-15 Thread Eric Blake
On 06/15/2016 02:41 AM, Denis V. Lunev wrote: > On 06/15/2016 05:36 AM, Eric Blake wrote: >> On 06/14/2016 09:25 AM, Denis V. Lunev wrote: >>> There is no need to scan allocation tables if we have mark_all_dirty >>> flag >>> set. Just mark it all dirty. >>> >>> int ret, n; >>> end =

[Qemu-devel] [V12 3/4] hw/i386: Introduce AMD IOMMU

2016-06-15 Thread David Kiarie
Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU The IOMMU does basic translation, error checking and has a minimal IOTLB implementation. This IOMMU bypassed the need for target aborts by responding with IOMMU_NONE access rights and exempts the region 0xfee0-0xfeef from translation

[Qemu-devel] [V12 1/4] hw/pci: Prepare for AMD IOMMU

2016-06-15 Thread David Kiarie
Introduce PCI macros from linux headers for use by AMD IOMMU Signed-off-by: David Kiarie --- include/hw/pci/pci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 4420f47..ac376c5 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h

[Qemu-devel] [V12 0/4] AMD IOMMU

2016-06-15 Thread David Kiarie
Hi all, This patchset adds basic AMD IOMMU emulation support to Qemu. Changes since V11 -AMD IOMMU is not started with -device amd-iommu (with a dependency on Marcel's patches). -IOMMU commands are represented using bitfields which is less error prone and more readable[Peter] -Changed

[Qemu-devel] [V12 2/4] trace-events: Add AMD IOMMU trace events

2016-06-15 Thread David Kiarie
Signed-off-by: David Kiarie --- trace-events | 29 + 1 file changed, 29 insertions(+) diff --git a/trace-events b/trace-events index 2f14205..340d019 100644 --- a/trace-events +++ b/trace-events @@ -2164,3 +2164,32 @@ e1000e_cfg_support_virtio(bool support) "Virtio he

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-15 Thread Anton Blanchard
Hi, > From: Richard Henderson > > A 32-bit rotate insn is more common on hosts than a deposit insn, > and if the host has neither the result is truely horrific. > > At the same time, tidy up the temporaries within these functions, > drop the over-use of "likely", drop some checks for identity t

Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands

2016-06-15 Thread Wouter Verhelst
On Wed, Jun 15, 2016 at 11:27:21AM +0100, Alex Bligh wrote: > Perhaps this should read "If an error occurs, the server MUST either initiate > a hard disconnect before the entire payload has been sent or > set the appropriate code in the error field and send the response header > without any payload

Re: [Qemu-devel] [PATCH] scsi: esp: check length before dma read

2016-06-15 Thread Laszlo Ersek
On 06/15/16 11:29, P J P wrote: > From: Prasad J Pandit > > While doing DMA read into ESP command buffer 's->cmdbuf', the > length parameter could exceed the buffer size. Add check to avoid > OOB access. > > Reported-by: Li Qiang > Signed-off-by: Prasad J Pandit > --- > hw/scsi/esp.c | 3 +++

[Qemu-devel] [PATCH v2] scsi: esp: check length before dma read

2016-06-15 Thread P J P
From: Prasad J Pandit While doing DMA read into ESP command buffer 's->cmdbuf', the length parameter could exceed the buffer size. Add check to avoid OOB access. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/scsi/esp.c | 3 +++ 1 file changed, 3 insertions(+) Update: - correc

Re: [Qemu-devel] [Qemu-block] Supplying QCOW2 as 'file' driver to `blockdev-add` results in a QEMU crash

2016-06-15 Thread Kashyap Chamarthy
On Wed, Jun 15, 2016 at 11:58:31AM +0200, Kashyap Chamarthy wrote: > Seems like supplying "qcow2" file BlockdevDriver option to QMP > `blockdev-add` results in a SIGSEGV: > > [...] > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > 0x55a0121f in visit

Re: [Qemu-devel] git master build failure

2016-06-15 Thread Mark Cave-Ayland
On 15/06/16 12:26, Mark Cave-Ayland wrote: > On 15/06/16 11:23, Andrew Jones wrote: > >>> Is that from a clean clone of the repository? I wonder if a change to a >>> generated file isn't being picked up somewhere by "make distclean". My >>> standard build script is this: >> >> Not a clean clone,

Re: [Qemu-devel] git master build failure

2016-06-15 Thread Mark Cave-Ayland
On 15/06/16 11:23, Andrew Jones wrote: >> Is that from a clean clone of the repository? I wonder if a change to a >> generated file isn't being picked up somewhere by "make distclean". My >> standard build script is this: > > Not a clean clone, but a clean build dir. I build in a separate build d

[Qemu-devel] [PATCH] linux-aio: Cancel BH if not needed

2016-06-15 Thread Kevin Wolf
linux-aio uses a BH in order to make sure that the remaining completions are processed even in nested event loops of completion callbacks in order to avoid deadlocks. There is no need, however, to have the BH overhead for the first call into qemu_laio_completion_bh() or after all pending completio

Re: [Qemu-devel] [PATCH 0/9] major rework of drive-mirror

2016-06-15 Thread Dr. David Alan Gilbert
* Denis V. Lunev (d...@openvz.org) wrote: > Block commit of the active image to the backing store on a slow disk > could never end. For example with the guest with the following loop > inside > while true; do > dd bs=1k count=1 if=/dev/zero of=x > done > running above slow storage c

[Qemu-devel] [PATCH v2 1/2] build-sys: link tests/data

2016-06-15 Thread marcandre . lureau
From: Marc-André Lureau Link a common tests data directory to the build directory. Signed-off-by: Marc-André Lureau --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 8c2f90b..c79234c 100755 --- a/configure +++ b/configure @@ -6008,6 +6008,11 @@

[Qemu-devel] [PATCH v2 2/2] tests: use static qga config file

2016-06-15 Thread marcandre . lureau
From: Marc-André Lureau Do not create a leaking temporary file, but use a static file instead. Signed-off-by: Marc-André Lureau Reported-by: Peter Maydell --- tests/data/test-qga-config | 8 tests/test-qga.c | 27 --- 2 files changed, 12 insertions(

[Qemu-devel] [PATCH v2 0/2] Remove test-qga temporary file

2016-06-15 Thread marcandre . lureau
From: Marc-André Lureau Hi, Here are 2 small patches to remove the need for temporary file creation in test-qga. v1->v2: - use a symlink to tests/data instead of hardcoding SRC_PATH Marc-André Lureau (2): build-sys: link tests/data tests: use static qga config file configure

Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-06-15 Thread Sergey Sorokin
15.06.2016, 06:03, "David Gibson" : > On Tue, Jun 14, 2016 at 03:26:17PM +0300, Sergey Sorokin wrote: >>  There are functions tlb_fill(), cpu_unaligned_access() and >>  do_unaligned_access() that are called with access type and mmu index >>  arguments. But these arguments are named 'is_write' and '

Re: [Qemu-devel] [PATCH 1/2] build-sys: define QEMU_SRC_PATH

2016-06-15 Thread Marc-André Lureau
Hi On Tue, Jun 14, 2016 at 11:59 PM, Michael Roth wrote: > Quoting marcandre.lur...@redhat.com (2016-06-14 08:16:53) >> From: Marc-André Lureau >> >> Define QEMU_SRC_PATH in config-host.h, to ease accessing of tests data >> files. >> >> Signed-off-by: Marc-André Lureau > > I know this avoids th

Re: [Qemu-devel] [PATCH 0/9] major rework of drive-mirror

2016-06-15 Thread Denis V. Lunev
On 06/15/2016 01:25 PM, Kevin Wolf wrote: Am 15.06.2016 um 11:34 hat Denis V. Lunev geschrieben: On 06/15/2016 12:06 PM, Kevin Wolf wrote: The second big thing is that I don't want to see new users of the notifiers in I/O functions. Let's try if we can't add a filter BlockDriver instead. Then w

Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk

2016-06-15 Thread Denis V. Lunev
On 06/15/2016 12:19 PM, Stefan Hajnoczi wrote: On Tue, Jun 14, 2016 at 09:20:47PM -0600, Eric Blake wrote: On 06/14/2016 09:25 AM, Denis V. Lunev wrote: We should not take into account zero blocks for delay calculations. They are not read and thus IO throttling is not required. In the other cas

Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands

2016-06-15 Thread Paolo Bonzini
On 15/06/2016 12:27, Alex Bligh wrote: > > On 15 Jun 2016, at 10:18, Paolo Bonzini wrote: > >>> So what should those servers do (like 2 of mine) which don't buffer >>> the entire read, if they get an error having already sent some data? >> >> They have sent an error code of zero, and it turned

Re: [Qemu-devel] [PATCH v2 0/6] block: Enable byte granularity I/O

2016-06-15 Thread Kevin Wolf
Am 15.06.2016 um 11:02 hat Stefan Hajnoczi geschrieben: > On Tue, Jun 14, 2016 at 03:32:29PM +0200, Kevin Wolf wrote: > > Previous series have already converted some block drivers to byte-based > > rather > > than sector-based interfaces. However, the common I/O path as well as > > raw-posix > >

Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands

2016-06-15 Thread Alex Bligh
On 15 Jun 2016, at 10:18, Paolo Bonzini wrote: >> So what should those servers do (like 2 of mine) which don't buffer >> the entire read, if they get an error having already sent some data? > > They have sent an error code of zero, and it turned out to be wrong. So > the only thing they can do

Re: [Qemu-devel] [PATCH 0/9] major rework of drive-mirror

2016-06-15 Thread Kevin Wolf
Am 15.06.2016 um 11:34 hat Denis V. Lunev geschrieben: > On 06/15/2016 12:06 PM, Kevin Wolf wrote: > >The second big thing is that I don't want to see new users of the > >notifiers in I/O functions. Let's try if we can't add a filter > >BlockDriver instead. Then we'd add an option to set the filter

Re: [Qemu-devel] git master build failure

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 11:08:26AM +0100, Mark Cave-Ayland wrote: > On 15/06/16 10:48, Andrew Jones wrote: > > > On Wed, Jun 15, 2016 at 08:14:18AM +0100, Mark Cave-Ayland wrote: > >> Hi Peter, > >> > >> Just to let you know that after pulling git master > >> (49237b856ae58ee7955be0b959c504c51b014

Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-06-15 Thread Stefan Hajnoczi
On Mon, Jun 13, 2016 at 02:16:08PM -0600, Eric Blake wrote: > On 06/13/2016 07:11 AM, Stefan Hajnoczi wrote: > > On Tue, May 31, 2016 at 12:15:26PM +0300, Denis V. Lunev wrote: > >> diff --git a/include/sysemu/block-backend.h > >> b/include/sysemu/block-backend.h > >> index 57df069..3d7b446 100644

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-15 Thread Peter Maydell
On 15 June 2016 at 11:06, Peter Maydell wrote: > On 15 June 2016 at 10:20, Andrew Jones wrote: >> There may be a bug in the freebsd kernel. Maybe they need the equivalent >> of Linux's 7c9b973061 "irqchip/gic-v3: Configure all interrupts as >> non-secure Group-1". You could add the hack back that

Re: [Qemu-devel] git master build failure

2016-06-15 Thread Mark Cave-Ayland
On 15/06/16 10:48, Andrew Jones wrote: > On Wed, Jun 15, 2016 at 08:14:18AM +0100, Mark Cave-Ayland wrote: >> Hi Peter, >> >> Just to let you know that after pulling git master >> (49237b856ae58ee7955be0b959c504c51b014f20) I see the following build >> failure here: > > Just pulled and successfull

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-15 Thread Peter Maydell
On 15 June 2016 at 10:20, Andrew Jones wrote: > There may be a bug in the freebsd kernel. Maybe they need the equivalent > of Linux's 7c9b973061 "irqchip/gic-v3: Configure all interrupts as > non-secure Group-1". You could add the hack back that was in the initial > posting of this series to see i

[Qemu-devel] Supplying QCOW2 as 'file' driver to `blockdev-add` results in a QEMU crash

2016-06-15 Thread Kashyap Chamarthy
Seems like supplying "qcow2" file BlockdevDriver option to QMP `blockdev-add` results in a SIGSEGV: [...] Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. 0x55a0121f in visit_type_BlockdevRef () [...] Reproducer -- Tested with: qemu-

Re: [Qemu-devel] [PATCH 8/9] mirror: use synch scheme for drive mirror

2016-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 06:25:15PM +0300, Denis V. Lunev wrote: > Block commit of the active image to the backing store on a slow disk > could never end. For example with the guest with the following loop > inside > while true; do > dd bs=1k count=1 if=/dev/zero of=x > done > runnin

[Qemu-devel] [PATCH v2 2/5] usb: make USBDevice->attached bool

2016-06-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbruster --- hw/usb/bus.c | 8 include/hw/usb.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index 16c3461..afd70ea 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -55,9 +55,9 @@

Re: [Qemu-devel] [PATCH 0/9] major rework of drive-mirror

2016-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 06:25:07PM +0300, Denis V. Lunev wrote: > Block commit of the active image to the backing store on a slow disk > could never end. For example with the guest with the following loop > inside > while true; do > dd bs=1k count=1 if=/dev/zero of=x > done > runnin

Re: [Qemu-devel] git master build failure

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 08:14:18AM +0100, Mark Cave-Ayland wrote: > Hi Peter, > > Just to let you know that after pulling git master > (49237b856ae58ee7955be0b959c504c51b014f20) I see the following build > failure here: Just pulled and successfully compiled, configure --target-list=aarch64-soft

[Qemu-devel] [PATCH v2 3/5] usb: Add QOM property "attached ".

2016-06-15 Thread Gerd Hoffmann
USB devices in attached state are visible to the guest. This patch adds a QOM property for this. Write access is opt-in per device. Some devices manage attached state automatically (usb-host, usb-serial, usb-redir), so we can't enable write access universally but have to do it on a case by case

[Qemu-devel] [PATCH v2 1/5] usb-storage: qcow2 encryption support is finally gone, zap dead code

2016-06-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 248a580..f67c090 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -556,21 +556,6 @@ static

[Qemu-devel] [PATCH v2 0/5] usb: hotplug support for usb-bot and usb-uas

2016-06-15 Thread Gerd Hoffmann
Hi, Composite device hotplug is a long-standing issue in qemu. PCI multifunction hotplug has been solved recently in a pci-specific way, by simply not showing hot-plugged functions to the guest until function #0 is plugged. So I figured we maybe should check whenever we can apply a simliar tri

[Qemu-devel] [PATCH v2 4/5] usb-bot: hotplug support

2016-06-15 Thread Gerd Hoffmann
This patch marks usb-bot as hot-pluggable device, makes attached property settable and turns off auto-attach in case the device was hotplugged. Hot-plugging a usb-bot device with one or more scsi devices can be done this way now: (1) device-add usb-bot,id=foo (2) device-add scsi-{hd,cd},bus=f

[Qemu-devel] [PATCH v2 5/5] usb-uas: hotplug support

2016-06-15 Thread Gerd Hoffmann
Make attached property settable and turns off auto-attach in case the device was hotplugged. Hotplugging works simliar to usb-bot now. Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbruster --- hw/usb/dev-uas.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/usb/dev-uas.c b/hw

Re: [Qemu-devel] [PATCH 0/9] major rework of drive-mirror

2016-06-15 Thread Denis V. Lunev
On 06/15/2016 12:06 PM, Kevin Wolf wrote: Am 14.06.2016 um 17:25 hat Denis V. Lunev geschrieben: Block commit of the active image to the backing store on a slow disk could never end. For example with the guest with the following loop inside while true; do dd bs=1k count=1 if=/dev/z

[Qemu-devel] [PATCH] scsi: esp: check length before dma read

2016-06-15 Thread P J P
From: Prasad J Pandit While doing DMA read into ESP command buffer 's->cmdbuf', the length parameter could exceed the buffer size. Add check to avoid OOB access. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/scsi/esp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/sc

Re: [Qemu-devel] [PATCH 6/9] block: pass qiov into before_write notifier

2016-06-15 Thread Denis V. Lunev
On 06/15/2016 12:21 PM, Stefan Hajnoczi wrote: On Tue, Jun 14, 2016 at 06:25:13PM +0300, Denis V. Lunev wrote: Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy CC: Stefan Hajnoczi CC: Fam Zheng CC: Kevin Wolf CC: Max Reitz CC: Jeff Cody CC: Eric Blake --- block/i

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 04:53:35PM +0800, Shannon Zhao wrote: > > > On 2016/6/14 22:38, Peter Maydell wrote: > > This series implements emulation of the GICv3 interrupt controller. > > It is based to some extent on previous patches from Shlomo and > > Pavel, but the bulk of it has turned out to b

Re: [Qemu-devel] [PATCH 6/9] block: pass qiov into before_write notifier

2016-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 06:25:13PM +0300, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > Reviewed-by: Vladimir Sementsov-Ogievskiy > CC: Stefan Hajnoczi > CC: Fam Zheng > CC: Kevin Wolf > CC: Max Reitz > CC: Jeff Cody > CC: Eric Blake > --- > block/io.c| 12 +++

Re: [Qemu-devel] [PATCH 6/9] block: pass qiov into before_write notifier

2016-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 06:25:13PM +0300, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > Reviewed-by: Vladimir Sementsov-Ogievskiy > CC: Stefan Hajnoczi > CC: Fam Zheng > CC: Kevin Wolf > CC: Max Reitz > CC: Jeff Cody > CC: Eric Blake > --- > block/io.c| 12 +++

Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk

2016-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 09:20:47PM -0600, Eric Blake wrote: > On 06/14/2016 09:25 AM, Denis V. Lunev wrote: > > We should not take into account zero blocks for delay calculations. > > They are not read and thus IO throttling is not required. In the > > other case VM migration with 16 Tb QCOW2 disk

Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands

2016-06-15 Thread Paolo Bonzini
- Original Message - > From: "Alex Bligh" > To: "Wouter Verhelst" > Cc: "Alex Bligh" , nbd-gene...@lists.sourceforge.net, > "Paolo Bonzini" , > qemu-devel@nongnu.org, "qemu block" > Sent: Wednesday, June 15, 2016 10:52:21 AM > Subject: Re: [Nbd] [PATCH v4 04/11] nbd: Improve server ha

Re: [Qemu-devel] [PATCH 0/9] major rework of drive-mirror

2016-06-15 Thread Kevin Wolf
Am 14.06.2016 um 17:25 hat Denis V. Lunev geschrieben: > Block commit of the active image to the backing store on a slow disk > could never end. For example with the guest with the following loop > inside > while true; do > dd bs=1k count=1 if=/dev/zero of=x > done > running above s

Re: [Qemu-devel] [PATCH v2 0/6] block: Enable byte granularity I/O

2016-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 03:32:29PM +0200, Kevin Wolf wrote: > Previous series have already converted some block drivers to byte-based rather > than sector-based interfaces. However, the common I/O path as well as > raw-posix > still enforced a minimum alignment of 512 bytes because some sector-bas

Re: [Qemu-devel] [PATCH v4 3/5] blockjob: add AioContext attached callback

2016-06-15 Thread Fam Zheng
On Tue, 06/14 19:17, Stefan Hajnoczi wrote: > > +static void block_job_attached_aio_context(AioContext *new_context, > + void *opaque) > +{ > +BlockJob *job = opaque; > + > +if (job->driver->attached_aio_context) { > +job->driver->attached

Re: [Qemu-devel] [PATCH v4 0/5] blockjob: AioContext change support for mirror and backup

2016-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 03:06:11PM -0400, Jason J. Herne wrote: > On 06/14/2016 02:17 PM, Stefan Hajnoczi wrote: > > v4: > > * Add .pause()/.resume() callbacks to really quiesce during > > block_job_pause_point() [Paolo] > > * Add AioContext change support for backup block job > > * Teste

Re: [Qemu-devel] [PATCH v4 2/5] blockjob: add pause points

2016-06-15 Thread Paolo Bonzini
On 15/06/2016 10:57, Fam Zheng wrote: > > +if (!block_job_is_paused(job)) { > > I find this check ... > > > +return; > > +} > > +if (block_job_is_cancelled(job)) { > > +return; > > +} > > + > > +if (job->driver->pause) { > > +job->driver->pause(job);

Re: [Qemu-devel] [PATCH v4 0/5] blockjob: AioContext change support for mirror and backup

2016-06-15 Thread Paolo Bonzini
On 14/06/2016 20:17, Stefan Hajnoczi wrote: > v4: > * Add .pause()/.resume() callbacks to really quiesce during >block_job_pause_point() [Paolo] > * Add AioContext change support for backup block job > * Tested drive_mirror + migration and drive_backup + reboot Also a nice improvement ove

Re: [Qemu-devel] [PATCH v4 4/5] mirror: follow AioContext change gracefully

2016-06-15 Thread Paolo Bonzini
On 14/06/2016 20:17, Stefan Hajnoczi wrote: > +/* There is no matching mirror_resume() because mirror_run() will begin > + * iterating again when the job is resumed. > + */ > +static void mirror_pause(BlockJob *job) > +{ > +MirrorBlockJob *s = container_of(job, MirrorBlockJob, common); > + >

Re: [Qemu-devel] [PATCH 8/9] mirror: use synch scheme for drive mirror

2016-06-15 Thread Denis V. Lunev
On 06/15/2016 07:18 AM, Eric Blake wrote: On 06/14/2016 09:25 AM, Denis V. Lunev wrote: Block commit of the active image to the backing store on a slow disk could never end. For example with the guest with the following loop inside while true; do dd bs=1k count=1 if=/dev/zero of=x

Re: [Qemu-devel] [PATCH v4 2/5] blockjob: add pause points

2016-06-15 Thread Fam Zheng
On Tue, 06/14 19:17, Stefan Hajnoczi wrote: > --- a/blockjob.c > +++ b/blockjob.c > @@ -247,6 +247,30 @@ void block_job_complete(BlockJob *job, Error **errp) > job->driver->complete(job, errp); > } > > +void block_job_pause_point(BlockJob *job) > +{ > +if (!block_job_is_paused(job)) {

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-15 Thread Shannon Zhao
On 2016/6/14 22:38, Peter Maydell wrote: > This series implements emulation of the GICv3 interrupt controller. > It is based to some extent on previous patches from Shlomo and > Pavel, but the bulk of it has turned out to be new code. (The > combination of changing the underlying data structures,

Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands

2016-06-15 Thread Alex Bligh
> On 15 Jun 2016, at 09:03, Wouter Verhelst wrote: > > On Wed, Jun 15, 2016 at 09:05:22AM +0200, Wouter Verhelst wrote: >> There are more clients than the Linux and qemu ones, but I think it's >> fair to say that those two are the most important ones. If they agree >> that a read reply which err

Re: [Qemu-devel] [PATCH v4 2/5] blockjob: add pause points

2016-06-15 Thread Paolo Bonzini
On 14/06/2016 20:17, Stefan Hajnoczi wrote: > Block jobs are coroutines that usually perform I/O but sometimes also > sleep or yield. Currently only sleeping or yielded block jobs can be > paused. This means jobs that do not sleep or yield (using > block_job_yield()) are unaffected by block_job

Re: [Qemu-devel] [PATCH] ACPI: ARM: Present GIC version in MADT table

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 11:22:35AM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > In ACPI 5.1 Errata, it adds GIC version in GIC distributor structure. > This is useful for guest kernel to identify which version GIC hardware > is. Update GIC distributor structure and present GIC version in M

Re: [Qemu-devel] [PATCH v2] net: mipsnet: check transmit buffer size before sending

2016-06-15 Thread Jason Wang
On 2016年06月13日 15:17, P J P wrote: Hello Jason, +-- On Mon, 13 Jun 2016, Jason Wang wrote --+ | > case MIPSNET_TX_DATA_BUFFER: | > s->tx_buffer[s->tx_written++] = val; | | I believe we may still have a buffer overflow here, no? No, this is the overflow that the patch is

Re: [Qemu-devel] [PATCH v4 1/5] blockjob: move iostatus reset out of block_job_enter()

2016-06-15 Thread Fam Zheng
On Tue, 06/14 19:17, Stefan Hajnoczi wrote: > The QMP block-job-resume command and cancellation may want to reset the > job's iostatus. The next patches add a user who does not want to reset > iostatus so move it up to block_job_enter() callers. > > Signed-off-by: Stefan Hajnoczi > --- > blockd

Re: [Qemu-devel] [PATCH 4/9] mirror: efficiently zero out target

2016-06-15 Thread Denis V. Lunev
On 06/15/2016 06:00 AM, Eric Blake wrote: On 06/14/2016 09:25 AM, Denis V. Lunev wrote: With a bdrv_co_write_zeroes method on a target BDS zeroes will not be placed into the wire. Thus the target could be very efficiently zeroed out. This is should be done with the largest chunk possible. This

Re: [Qemu-devel] [PATCH 3/9] mirror: optimize dirty bitmap filling in mirror_run a bit

2016-06-15 Thread Denis V. Lunev
On 06/15/2016 05:36 AM, Eric Blake wrote: On 06/14/2016 09:25 AM, Denis V. Lunev wrote: There is no need to scan allocation tables if we have mark_all_dirty flag set. Just mark it all dirty. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy CC: Stefan Hajnoczi CC: Fam Zh

Re: [Qemu-devel] Regarding the status of Gluster's multi volfile server patches

2016-06-15 Thread Prasanna Kalever
On Wed, Jun 15, 2016 at 12:34 PM, Prasanna Kalever wrote: > On Wed, Jun 15, 2016 at 3:30 AM, Eric Blake wrote: >> On 06/14/2016 06:36 AM, Jeff Cody wrote: >>> On Tue, Jun 14, 2016 at 03:27:55PM +0530, Prasanna Kalever wrote: Hello, Can someone please help me in tracking the QAPI ch

Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files

2016-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 03:53:48PM -0600, Eric Blake wrote: > On 06/14/2016 06:26 AM, Stefan Hajnoczi wrote: > > On Thu, Jun 09, 2016 at 05:57:55PM +0100, Daniel P. Berrange wrote: > >> +$(BUILD_DIR)/trace-events-all: $(trace-events-y:%=$(SRC_PATH)/%) > >> + $(call quiet-command,cat $^ > $@) > >

[Qemu-devel] [PATCH v17 4/4] block/gluster: add support for multiple gluster servers

2016-06-15 Thread Prasanna Kumar Kalever
This patch adds a way to specify multiple volfile servers to the gluster block backend of QEMU with tcp|rdma transport types and their port numbers. Problem: Currently VM Image on gluster volume is specified like this: file=gluster[+tcp]://host[:port]/testvol/a.img Assuming we have three hosts

[Qemu-devel] [PATCH v17 3/4] block/gluster: using new qapi schema

2016-06-15 Thread Prasanna Kumar Kalever
this patch adds 'GlusterServer' related schema in qapi/block-core.json Signed-off-by: Prasanna Kumar Kalever --- block/gluster.c | 101 ++- qapi/block-core.json | 64 +--- 2 files changed, 110 insertions(+), 55 del

[Qemu-devel] [PATCH v17 0/4][WIP] block/gluster: add support for multiple gluster servers

2016-06-15 Thread Prasanna Kumar Kalever
This version of patches are rebased on master branch. Prasanna Kumar Kalever (4): block/gluster: rename [server, volname, image] -> [host, volume, path] block/gluster: code cleanup block/gluster: using new qapi schema block/gluster: add support for multiple gluster servers v1: multiple ho

[Qemu-devel] [PATCH v17 2/4] block/gluster: code cleanup

2016-06-15 Thread Prasanna Kumar Kalever
unified coding styles of multiline function arguments and other error functions moved random declarations of structures and other list variables Signed-off-by: Prasanna Kumar Kalever Reviewed-by: Eric Blake --- block/gluster.c | 113 ++-- 1 fi

[Qemu-devel] [PATCH v17 1/4] block/gluster: rename [server, volname, image] -> [host, volume, path]

2016-06-15 Thread Prasanna Kumar Kalever
A future patch will add support for multiple gluster servers. Existing terminology is a bit unusual in relation to what names are used by other networked devices, and doesn't map very well to the terminology we expect to use for multiple servers. Therefore, rename the following options: 'server'

Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands

2016-06-15 Thread Wouter Verhelst
On Wed, Jun 15, 2016 at 09:05:22AM +0200, Wouter Verhelst wrote: > There are more clients than the Linux and qemu ones, but I think it's > fair to say that those two are the most important ones. If they agree > that a read reply which errors should come without payload, then I think > we should upd

Re: [Qemu-devel] [Qemu-block] [PATCH v2] block: drop support for using qcow[2] encryption with system emulators

2016-06-15 Thread Kevin Wolf
Am 13.06.2016 um 17:36 hat Kevin Wolf geschrieben: > Am 13.06.2016 um 13:30 hat Daniel P. Berrange geschrieben: > > So rather than fix the crash, and backport it to stable > > releases, just go ahead with what we have warned users about > > and disable any use of qcow2 encryption in the system > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-15 Thread Thomas Huth
On 14.06.2016 23:32, Programmingkid wrote: > > On Jun 14, 2016, at 5:13 PM, BALATON Zoltan wrote: > >> On Tue, 14 Jun 2016, Programmingkid wrote: >>> On Jun 14, 2016, at 7:39 AM, qemu-ppc-requ...@nongnu.org wrote: smp_cores is only used by pseries and x86 machines. I expect machines th

Re: [Qemu-devel] [PATCH] m25p80: fix test on blk_pread() return value

2016-06-15 Thread Kevin Wolf
Am 14.06.2016 um 18:02 hat Cédric Le Goater geschrieben: > On 06/14/2016 10:38 AM, Kevin Wolf wrote: > > Am 14.06.2016 um 10:02 hat Cédric Le Goater geschrieben: > #4 0x7fa81c6694ac in bdrv_aligned_pwritev (bs=0x7fa81d4dd050, > req=, offset=30878208, > bytes=512, qiov=0x7f

Re: [Qemu-devel] [PATCH] block-backend: allow flush on devices with open tray

2016-06-15 Thread Kevin Wolf
Am 14.06.2016 um 18:13 hat Max Reitz geschrieben: > On 14.06.2016 17:54, John Snow wrote: > > > > > > On 06/14/2016 09:19 AM, Max Reitz wrote: > >> On 10.06.2016 23:59, John Snow wrote: > >>> If a device still has an attached BDS because the medium has not yet > >>> been removed, we will be unabl

Re: [Qemu-devel] [PATCH] seccomp: Add support for ppc/ppc64

2016-06-15 Thread Eduardo Otubo
On Wed, Jun 01, 2016 at 06=30=18PM -0500, Michael Strosaker wrote: > Support for ppc/ppc64 is official in libseccomp 2.3.0, so modify the > configuration script to allow qemuu to enable seccomp for those platforms. > > Signed-off-by: Michael Strosaker > --- > configure | 3 +++ > 1 file changed,

Re: [Qemu-devel] [PATCH RFC 10/16] hw/ppc/spapr: don't use smp_cores, smp_threads

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 10:59:01AM +1000, David Gibson wrote: > On Tue, Jun 14, 2016 at 08:23:08AM +0200, Andrew Jones wrote: > > On Tue, Jun 14, 2016 at 01:03:41PM +1000, David Gibson wrote: > > > On Fri, Jun 10, 2016 at 07:40:21PM +0200, Andrew Jones wrote: > > > > Use CPUState nr_cores,nr_thread

[Qemu-devel] [PATCHv3 2/2] MAINTAINERS: remove Blue Swirl as SPARC maintainer

2016-06-15 Thread Mark Cave-Ayland
Blue is no longer active in the QEMU project, so remove him from the list of SPARC maintainers. Signed-off-by: Mark Cave-Ayland CC: Blue Swirl --- MAINTAINERS |3 --- 1 file changed, 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4ebc29f..2fe8836 100644 --- a/MAINTAINERS +++ b

[Qemu-devel] [PATCHv3 1/2] MAINTAINERS: add Artyom Tarasenko as SPARC maintainer

2016-06-15 Thread Mark Cave-Ayland
Artyom has been working on QEMU's SPARC emulation for several years, providing initial support for Solaris under qemu-system-sparc and more recently bugfixes for qemu-system-sparc64 and TCG patch reviews. As work progresses on improving emulation for sun4u machines and beyond, Artyom has agreed to

[Qemu-devel] [PATCHv3 0/2] MAINTAINERS: update entries for SPARC

2016-06-15 Thread Mark Cave-Ayland
Update MAINTAINERS for SPARC (and associated machines): add Artyom Tarasenko and remove Blue Swirl. Signed-off-by: Mark Cave-Ayland Mark Cave-Ayland (2): MAINTAINERS: add Artyom Tarasenko as SPARC maintainer MAINTAINERS: remove Blue Swirl as SPARC maintainer MAINTAINERS |6 +++--- 1 fi

Re: [Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 10:51:08AM +1000, David Gibson wrote: > On Tue, Jun 14, 2016 at 04:03:29PM +0200, Andrew Jones wrote: > > On Tue, Jun 14, 2016 at 01:53:05PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 14/06/2016 13:39, Andrew Jones wrote: > > > > On Tue, Jun 14, 2016 at 10:17:49AM +0

[Qemu-devel] git master build failure

2016-06-15 Thread Mark Cave-Ayland
Hi Peter, Just to let you know that after pulling git master (49237b856ae58ee7955be0b959c504c51b014f20) I see the following build failure here: cc -I/home/build/src/qemu/git/qemu/tcg -I/home/build/src/qemu/git/qemu/tcg/i386 -I/home/build/src/qemu/git/qemu/linux-headers -I/home/build/src/qemu/git/

Re: [Qemu-devel] [PATCH RFC 05/16] hw/core/machine: add smp properites

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 10:37:59AM +1000, David Gibson wrote: > On Tue, Jun 14, 2016 at 08:08:07AM +0200, Andrew Jones wrote: > > On Tue, Jun 14, 2016 at 12:00:26PM +1000, David Gibson wrote: > > > On Fri, Jun 10, 2016 at 07:40:16PM +0200, Andrew Jones wrote: > > > > Signed-off-by: Andrew Jones >

Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands

2016-06-15 Thread Wouter Verhelst
On Tue, Jun 14, 2016 at 04:02:15PM +0100, Alex Bligh wrote: > > On 14 Jun 2016, at 14:32, Paolo Bonzini wrote: > > > > > On 13/06/2016 23:41, Alex Bligh wrote: > >> That's one of the reasons that there is a proposal to add > >> STRUCTURED_READ to the spec (although I still haven't had time to >

Re: [Qemu-devel] Regarding the status of Gluster's multi volfile server patches

2016-06-15 Thread Prasanna Kalever
On Wed, Jun 15, 2016 at 3:30 AM, Eric Blake wrote: > On 06/14/2016 06:36 AM, Jeff Cody wrote: >> On Tue, Jun 14, 2016 at 03:27:55PM +0530, Prasanna Kalever wrote: >>> Hello, >>> >>> Can someone please help me in tracking the QAPI changes for union >>> discriminator addition, >>> the below [1] glus

[Qemu-devel] [PATCH v2] hw/timer: Add value matching support to aspeed_timer

2016-06-15 Thread Andrew Jeffery
Value matching allows Linux to boot with CONFIG_NO_HZ_IDLE=y on the palmetto-bmc machine. Two match registers are provided for each timer. Signed-off-by: Andrew Jeffery --- Since v1: Address comments from Peter * Switch calculations to use muldiv64() * Switch to loops when calculating the next e

Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands

2016-06-15 Thread Wouter Verhelst
On Mon, Jun 13, 2016 at 10:41:05PM +0100, Alex Bligh wrote: > For amusement value, the non-threaded handler (which is not used > any more) does not send any payload on an error: > https://github.com/yoe/nbd/blob/master/nbd-server.c#L1734 nbd-server used to just drop the connection on read error.

<    1   2   3