[Qemu-devel] [PULL 19/23] spapr: Restore support for 970MP and POWER8NVL CPU cores

2016-06-30 Thread David Gibson
From: Bharata B Rao Introduction of core based CPU hotplug for PowerPC sPAPR didn't add support for 970MP and POWER8NVL based core types. Add support for the same. While we are here, add support for explicit specification of POWER5+_v2.1 core type. Signed-off-by: Bharata B Rao Signed-off-by: D

[Qemu-devel] [PULL 12/23] target-ppc: Eliminate redundant and incorrect function booke206_page_size_to_tlb

2016-06-30 Thread David Gibson
From: Aaron Larson Eliminate redundant and incorrect booke206_page_size_to_tlb function from ppce500_spin.c in preference to previously existing but newly exported definition from e500.c Defect analysis: The booke206_page_size_to_tlb function in e500.c was updated in commit 2bd9543 "ppc: booke2

[Qemu-devel] [PULL 20/23] spapr: drop reference on child object during core realization

2016-06-30 Thread David Gibson
From: Greg Kurz When a core is being realized, we create a child object for each thread of the core. The child is first initialized with object_initialize() which sets its ref count to 1, and then added to the core with object_property_add_child() which bumps the ref count to 2. When the core g

[Qemu-devel] [PULL 03/23] ppc: Use a helper to filter writes to LPCR

2016-06-30 Thread David Gibson
From: Benjamin Herrenschmidt This handles filtering bits based on what is implemented by a given architecture version. We also use it to copy to LPCR some of the relevant 970 HID4 bits. Signed-off-by: Benjamin Herrenschmidt [clg: fixed checkpatch.pl errors ] Signed-off-by: Cédric Le Goater Sig

[Qemu-devel] [PULL 08/23] ppc: Print HSRR0/HSRR1 in "info registers"

2016-06-30 Thread David Gibson
From: Benjamin Herrenschmidt They are generally useful when debugging HV mode stuff Signed-off-by: Benjamin Herrenschmidt [clg: fixed checkpatch.pl errors ] Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- target-ppc/translate.c | 7 +++ 1 file changed, 7 insertions(+) di

[Qemu-devel] [PULL 04/23] ppc: Fix conditions for delivering external interrupts to a guest

2016-06-30 Thread David Gibson
From: Benjamin Herrenschmidt External interrupts can bypass the MSR_EE test if they occur in guest mode and LPES0 is clear. In that case they are directed to the hypervisor Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- target-ppc/excp_h

[Qemu-devel] [PULL 23/23] qmp: fix spapr example of query-hotpluggable-cpus

2016-06-30 Thread David Gibson
From: Igor Mammedov 27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore added -id suffix to property names but forgot to fix example in qmp-commands.hx Fix example to have 'core-id' instead of 'core' to match current code Signed-off-by: Igor Mammedov Reviewed-by: P

[Qemu-devel] [PULL 00/23] ppc-for-2.7 queue 20160701

2016-06-30 Thread David Gibson
The following changes since commit 8a0b4de048e20215415b24c7b42514c27b9d6ef3: pcspk: fix KVM (2016-06-30 19:00:02 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.7-20160701 for you to fetch changes up to 13f5e8003e7b67039cb7a19e41b4f7f7ac669cb3

[Qemu-devel] [PULL 22/23] spapr: drop duplicate variable in spapr_core_release()

2016-06-30 Thread David Gibson
From: Greg Kurz Signed-off-by: Greg Kurz Reviewed-by: Bharata B Rao Signed-off-by: David Gibson --- hw/ppc/spapr_cpu_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c index 2e264fa..a384db5 100644 --- a/hw/ppc/spapr_

[Qemu-devel] [PULL 05/23] ppc: Enforce setting MSR:EE, IR and DR when MSR:PR is set

2016-06-30 Thread David Gibson
From: Benjamin Herrenschmidt The architecture specifies that any instruction that sets MSR:PR will also set MSR:EE, IR and DR. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- target-ppc/helper_regs.h | 4 1 file changed, 4 insertions

[Qemu-devel] [PULL 09/23] hw/ppc/spapr: Add some missing hcall function set strings

2016-06-30 Thread David Gibson
From: Thomas Huth Add "hcall-sprg0" (for H_SET_SPRG0), "hcall-copy" (for H_PAGE_INIT) and "hcall-debug" (for H_LOGICAL_CI_LOAD/STORE) to the property "ibm,hypertas-functions" to indicate that we support these hypercalls. Signed-off-by: Thomas Huth Signed-off-by: David Gibson --- hw/ppc/spapr.

[Qemu-devel] [PULL 21/23] spapr: do proper error propagation in spapr_cpu_core_realize_child()

2016-06-30 Thread David Gibson
From: Greg Kurz This patch changes spapr_cpu_core_realize_child() to have a local error pointer and use error_propagate() as it is supposed to be done. Signed-off-by: Greg Kurz Reviewed-by: Bharata B Rao Signed-off-by: David Gibson --- hw/ppc/spapr_cpu_core.c | 12 +++- 1 file change

[Qemu-devel] [PULL 02/23] ppc: Update LPCR definitions

2016-06-30 Thread David Gibson
From: Benjamin Herrenschmidt Includes all the bits up to ISA 2.07 Signed-off-by: Benjamin Herrenschmidt [clg: fixed checkpatch.pl errors ] Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- target-ppc/cpu.h | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-)

[Qemu-devel] [PULL 11/23] spapr: Restore support for older PowerPC CPU cores

2016-06-30 Thread David Gibson
From: Bharata B Rao Introduction of core based CPU hotplug for PowerPC sPAPR didn't add support for 970 and POWER5+ based core types. Add support for the same. Signed-off-by: Bharata B Rao Signed-off-by: David Gibson --- hw/ppc/spapr_cpu_core.c | 9 - 1 file changed, 8 insertions(+),

[Qemu-devel] [PULL 07/23] ppc: LPCR is a HV resource

2016-06-30 Thread David Gibson
From: Benjamin Herrenschmidt Don't allow access in guest mode Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- target-ppc/translate_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target-ppc/translate_in

[Qemu-devel] [PULL 10/23] spapr: fix write-past-end-of-array error in cpu core device init code

2016-06-30 Thread David Gibson
From: Greg Kurz This fixes a potential QEMU crash introduced by commit 3b542549661. Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr_cpu_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c index 3a

Re: [Qemu-devel] [PATCH 1/2] hw/misc: fix Aspeed SCU hw-strap2 property

2016-06-30 Thread Cédric Le Goater
On 06/30/2016 08:24 PM, Peter Maydell wrote: > On 30 June 2016 at 16:50, Cédric Le Goater wrote: >> These strap registers are complex enough, let's not mix them. >> >> Signed-off-by: Cédric Le Goater > > Was there a cover letter for this patchset? I can't find > it in my email... Ah :/ No, I di

Re: [Qemu-devel] [PATCH 2/2] ppc: Fix 64K pages support in full emulation

2016-06-30 Thread Cédric Le Goater
On 07/01/2016 12:13 AM, Benjamin Herrenschmidt wrote: > On Thu, 2016-06-30 at 18:01 +0200, Cédric Le Goater wrote: >> +static uint32_t ppc_hash64_pte_size_decode(PowerPCCPU *cpu, uint64_t >> pte0, >> + uint64_t pte1, uint32_t >> slb_pshift) >> { >> -sw

[Qemu-devel] [Bug 1591724] Re: Windows 7 installation DVD can't boot in qemu 2.6.0/OVMF

2016-06-30 Thread Aleksei Kovura
@Gannet I've built latest qemu from git just to get through installation, after that everything runs fine on 2.6.0. It's easy enough http://wiki.qemu.org/Hosts/Linux#Simple_build_and_test -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU

[Qemu-devel] [PATCH v0] spapr: Ensure thread0 of CPU core is always realized first

2016-06-30 Thread Bharata B Rao
During CPU core realization, we create all the thread objects and parent them to the core object in a loop. However, the realization of thread objects is done separately by walking the threads of a core using object_child_foreach(). With this, there is no guarantee on the order in which the child t

[Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-06-30 Thread Tom Hanson
Dave, Yeah, well, never mind. :-) If I'd looked at the code first I'd have seen the function name and thought about which data I'd want to dump and where, I'd have figured out where the debug data came from. -Tom -- You received this bug notification because you are a member of qemu- devel-ml

[Qemu-devel] Expensive emulation of CPU condition flags

2016-06-30 Thread Shuang Zhai
Hi everyone. In running an ARMv7 guest on an x86 host, we observed that a guest instruction affecting condition flags is often translated into 10+ host instructions. The reason seems to be the way that the frontend emulates the condition flags. For instance: Target ARM instruction: cmp r9,

Re: [Qemu-devel] [PATCH] pci_register_bar: cleanup

2016-06-30 Thread Cao jin
ping? This one has been posted almost 3 months On 06/20/2016 11:31 AM, Cao jin wrote: Hi Michael, Would you please take a look at this one? It has been forgotten for a long time. On 05/18/2016 08:31 PM, Michael S. Tsirkin wrote: On Wed, May 18, 2016 at 02:17:20PM +0200, Paolo Bonzini wrote:

Re: [Qemu-devel] Bug in virtio_net_load

2016-06-30 Thread Jason Wang
On 2016年07月01日 01:23, Michael S. Tsirkin wrote: On Thu, Jun 30, 2016 at 10:34:51AM +0200, Robin Geuze wrote: Hey, I work for TransIP and we host a VPS platform based on QEMU/KVM. We are currently running qemu 2.4.0. A few days ago we noticed that live migrations for some of our VM's would fai

Re: [Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch

2016-06-30 Thread Marcelo Tosatti
On Thu, Jun 30, 2016 at 03:12:17PM -0300, Eduardo Habkost wrote: > Improve the TSC frequency mismatch warning to show the host and > VM TSC frequencies. > > Signed-off-by: Eduardo Habkost > --- > target-i386/kvm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/targe

Re: [Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread Changlong Xie
On 07/01/2016 02:18 AM, John Snow wrote: On 06/30/2016 10:00 AM, Jeff Cody wrote: On Thu, Jun 30, 2016 at 04:45:52PM +0800, Changlong Xie wrote: On 06/30/2016 04:25 PM, Fam Zheng wrote: On Thu, 06/30 16:01, Changlong Xie wrote: Otherwise, we could never trigger assert(!bitmap->successor) S

[Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-06-30 Thread Tom Hanson
Dave, How did you get the debug info in #4 above? I can now replicate the error, but can't get to the monitor. I'm new to qemu so it's probably one of those things I haven't learned yet. Thanks, Tom -- You received this bug notification because you are a member of qemu- devel-ml, which is sub

Re: [Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus

2016-06-30 Thread David Gibson
On Thu, Jun 30, 2016 at 10:30:53AM +0200, Peter Krempa wrote: > On Thu, Jun 30, 2016 at 10:17:54 +0200, Igor Mammedov wrote: > > 27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct > > CPUCore > > added -id suffix to property names but forgot to fix example in > > qmp-command

Re: [Qemu-devel] [PATCH 2/2] ppc: Fix 64K pages support in full emulation

2016-06-30 Thread David Gibson
On Fri, Jul 01, 2016 at 08:13:47AM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-06-30 at 18:01 +0200, Cédric Le Goater wrote: > > +static uint32_t ppc_hash64_pte_size_decode(PowerPCCPU *cpu, uint64_t > > pte0, > > +   uint64_t pte1, uint32_t > > slb_ps

Re: [Qemu-devel] [PATCH 2/2] ppc: Fix 64K pages support in full emulation

2016-06-30 Thread Benjamin Herrenschmidt
On Thu, 2016-06-30 at 18:01 +0200, Cédric Le Goater wrote: > +static uint32_t ppc_hash64_pte_size_decode(PowerPCCPU *cpu, uint64_t > pte0, > +   uint64_t pte1, uint32_t > slb_pshift) >  { > -    switch (slb_pshift) { > -    case 12: > -    return 12; > - 

[Qemu-devel] [Bug 1581936] Re: Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

2016-06-30 Thread Gannet
I'm experiencing the same issue. Terrible video performance with Cirrus as it is the only video workable with windows 7. Please, fix it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1581936 Title:

[Qemu-devel] [PATCH] i.MX: split the GPT timer implementation in a per SOC definition.

2016-06-30 Thread Jean-Christophe Dubois
in various Freescale SOC, the GPT timers can be configured to select its input clock. Depending on the SOC the set of available input clocks may vary. The actual single GPT definition was no good enough and because of it booting the sabrelite board with a i.MX6DL device tree would fail because of

[Qemu-devel] [Bug 1591724] Re: Windows 7 installation DVD can't boot in qemu 2.6.0/OVMF

2016-06-30 Thread Gannet
The same thing. Qemu 2.5 and no possibility to install Windows 7 on OVMF, no possibility to install Windows 7 with QXL video. This is something terrible. Several hours I'm trying to install it but only on BIOS and with Cirrus video. What Qemu version will be fixed? -- You received this bug notifi

[Qemu-devel] [PATCH 2/3] hid.c: convert to QKeyCode

2016-06-30 Thread John Arbuckle
Switches hid.c from PS/2 to QKeyCode support. Signed-off-by: John Arbuckle --- hw/input/hid.c | 270 ++--- 1 file changed, 179 insertions(+), 91 deletions(-) diff --git a/hw/input/hid.c b/hw/input/hid.c index d92c746..3e1b46e 100644 --- a/hw/i

[Qemu-devel] [PATCH 0/3] Switch USB HID to QKeyCode

2016-06-30 Thread John Arbuckle
This patchset switches from the PS/2 keycode to QKeyCode support in the hid.c file. John Arbuckle (3): usb-keys.h: initial commit hid.c: convert to QKeyCode hid.c: Add debug support hw/input/hid.c | 279 ++-- include/hw/input/usb-keys.h

[Qemu-devel] [PATCH 1/3] usb-keys.h: initial commit

2016-06-30 Thread John Arbuckle
Create an emum of all the USB HID keyboard values. Signed-off-by: John Arbuckle --- include/hw/input/usb-keys.h | 154 1 file changed, 154 insertions(+) create mode 100644 include/hw/input/usb-keys.h diff --git a/include/hw/input/usb-keys.h b/includ

[Qemu-devel] [PATCH 3/3] hid.c: Add debug support

2016-06-30 Thread John Arbuckle
Add debug macros to the code for easier debugging. Signed-off-by: John Arbuckle --- hw/input/hid.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/input/hid.c b/hw/input/hid.c index 3e1b46e..efe703e 100644 --- a/hw/input/hid.c +++ b/hw/input/hid.c @@ -37,6 +37,13 @@ #define

Re: [Qemu-devel] [PATCH] Remove left shifts of negative signed integers

2016-06-30 Thread Paolo Bonzini
> > GCC correctly puts this warning under -Wextra, and promises not to ever > > make use of this facet of undefined behavior. The only correct patch > > is the one that disables the warning for clang, and possibly adds > > -fwrapv. In GCC, -fwrapv correctly silences ubsan's left-shift > > and si

Re: [Qemu-devel] [PATCH] Remove left shifts of negative signed integers

2016-06-30 Thread John Snow
On 06/30/2016 04:15 PM, Paolo Bonzini wrote: > > > - Original Message - >> From: "John Snow" >> To: qemu-devel@nongnu.org >> Cc: qemu-triv...@nongnu.org, pbonz...@redhat.com, kra...@redhat.com, "peter >> maydell" , >> "John Snow" >> Sent: Thursday, June 30, 2016 9:36:36 PM >> Subject

Re: [Qemu-devel] [PATCH] Remove left shifts of negative signed integers

2016-06-30 Thread Paolo Bonzini
> > We have been down this path before: > > http://patchwork.ozlabs.org/patch/545238/ > > > > Paolo will doubtless be along with the rant shortly. Here I am! Paolo > I figured, so I CC'd him. Nobody can say I didn't try. > > --js >

Re: [Qemu-devel] [PATCH] Remove left shifts of negative signed integers

2016-06-30 Thread Paolo Bonzini
- Original Message - > From: "John Snow" > To: qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org, pbonz...@redhat.com, kra...@redhat.com, "peter > maydell" , > "John Snow" > Sent: Thursday, June 30, 2016 9:36:36 PM > Subject: [PATCH] Remove left shifts of negative signed integers >

Re: [Qemu-devel] [PATCH] Remove left shifts of negative signed integers

2016-06-30 Thread John Snow
On 06/30/2016 04:11 PM, Peter Maydell wrote: > On 30 June 2016 at 20:36, John Snow wrote: >> Another exercise in placating Clang's increasingly strict -Werror mode. >> Technically, this is undefined behavior. In practice, -N<> as -(N<> >> Signed-off-by: John Snow >> --- >> hw/audio/fmopl.c

Re: [Qemu-devel] Function keys F16 to F19 support

2016-06-30 Thread Peter Maydell
On 30 June 2016 at 20:40, Programmingkid wrote: > Apple has a keyboard that has function keys F16 to F19 on it. > Would you accept a patch that adds support for these keys to > the cocoa interface? Depends on the patch, but in principle yes. thanks -- PMM

Re: [Qemu-devel] [PATCH] Remove left shifts of negative signed integers

2016-06-30 Thread Peter Maydell
On 30 June 2016 at 20:36, John Snow wrote: > Another exercise in placating Clang's increasingly strict -Werror mode. > Technically, this is undefined behavior. In practice, -N< as -(N< > Signed-off-by: John Snow > --- > hw/audio/fmopl.c | 2 +- > target-i386/monitor.c | 2 +- > 2 files chan

[Qemu-devel] [PULL 0/5] VFIO updates 2016-06-30

2016-06-30 Thread Alex Williamson
The following changes since commit 8a0b4de048e20215415b24c7b42514c27b9d6ef3: pcspk: fix KVM (2016-06-30 19:00:02 +0100) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20160630.0 for you to fetch changes up to 3cb3b1549f5401dc3a5e1d073e34063d

[Qemu-devel] [PULL 3/5] vfio/pci: Hide SR-IOV capability

2016-06-30 Thread Alex Williamson
The kernel currently exposes the SR-IOV capability as read-only through vfio-pci. This is sufficient to protect the host kernel, but has the potential to confuse guests without further virtualization. In particular, OVMF tries to size the VF BARs and comes up with absurd results, ending with an as

[Qemu-devel] [PULL 1/5] vfio/pci: Fix VGA quirks

2016-06-30 Thread Alex Williamson
Commit 2d82f8a3cdb2 ("vfio/pci: Convert all MemoryRegion to dynamic alloc and consistent functions") converted VFIOPCIDevice.vga to be dynamically allocted, negating the need for VFIOPCIDevice.has_vga. Unfortunately not all of the has_vga users were converted, nor was the field removed from the str

[Qemu-devel] [PULL 4/5] memory: Add MemoryRegionIOMMUOps.notify_started/stopped callbacks

2016-06-30 Thread Alex Williamson
From: Alexey Kardashevskiy The IOMMU driver may change behavior depending on whether a notifier client is present. In the case of POWER, this represents a change in the visibility of the IOTLB, for other drivers such as intel-iommu and future AMD-Vi emulation, notifier support is not yet enabled

[Qemu-devel] [PULL 5/5] intel_iommu: Throw hw_error on notify_started

2016-06-30 Thread Alex Williamson
We don't currently support the MemoryRegionIOMMUOps notifier, so throw an error should a device require it. Reviewed-by: Marcel Apfelbaum Reviewed-by: David Gibson Reviewed-by: Peter Xu Tested-by: Peter Xu Acked-by: Paolo Bonzini Signed-off-by: Alex Williamson --- hw/i386/intel_iommu.c |

[Qemu-devel] [PULL 2/5] vfio: add pcie extended capability support

2016-06-30 Thread Alex Williamson
From: Chen Fan For vfio pcie device, we could expose the extended capability on PCIE bus. due to add a new pcie capability at the tail of the chain, in order to avoid config space overwritten, we introduce a copy config for parsing extended caps. and rebuild the pcie extended config space. Signe

[Qemu-devel] Function keys F16 to F19 support

2016-06-30 Thread Programmingkid
Apple has a keyboard that has function keys F16 to F19 on it. Would you accept a patch that adds support for these keys to the cocoa interface?

[Qemu-devel] [PATCH] Remove left shifts of negative signed integers

2016-06-30 Thread John Snow
Another exercise in placating Clang's increasingly strict -Werror mode. Technically, this is undefined behavior. In practice, -N< --- hw/audio/fmopl.c | 2 +- target-i386/monitor.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index

Re: [Qemu-devel] scsi-bus: Add support for SCSI scanners

2016-06-30 Thread Jarkko Lavinen
On Thu, Jun 30, 2016 at 05:53:37PM +0200, Paolo Bonzini wrote: > > The extra sense bit seems to be a kind of internal busy/film holder > > moving status. After having this sense bit available scanning programs > > have been very stable and every feature seems to be working. > > Thanks! Out of cu

[Qemu-devel] [PATCH V4 6/6] tests/acpi: Add pxb/pxb-pcie tests blobs

2016-06-30 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- tests/acpi-test-data/pc/DSDT.pxb | Bin 0 -> 6280 bytes tests/acpi-test-data/q35/DSDT.pxb_pcie | Bin 0 -> 9098 bytes 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/acpi-test-data/pc/DSDT.pxb create mode 100644 tests/acpi-test

[Qemu-devel] [PATCH V4 5/6] hw/apci: handle 64-bit MMIO regions correctly

2016-06-30 Thread Marcel Apfelbaum
In build_crs(), the calculation and merging of the ranges already happens in 64-bit, but the entry boundaries are silently truncated to 32-bit in the call to aml_dword_memory(). Fix it by handling the 64-bit MMIO ranges separately. This fixes 64-bit BARs behind PXBs. Reviewed-by: Igor Mammedov S

[Qemu-devel] [PATCH V4 4/6] acpi: refactor pxb crs computation

2016-06-30 Thread Marcel Apfelbaum
Instead of always passing both IO and MEM ranges when computing CRS ranges, define a new CrsRangeSet structure that include them both. This is done before introducing a third type of range, 64-bit MEM, so it will be easier to pass them all around. Reviewed-by: Igor Mammedov Signed-off-by: Marcel

[Qemu-devel] [PATCH V4 3/6] hw/acpi: fix a DSDT table issue when a pxb is present.

2016-06-30 Thread Marcel Apfelbaum
PXBs do not support hotplug so they don't have a PCNT function. Since the PXB's PCI root-bus is a child bus of bus 0, the build_dsdt code will add a call to the corresponding PCNT function. Fix this by skipping the PCNT call for the above case. While at it skip also PCIe child buses. Reported-by:

[Qemu-devel] [PATCH V4 2/6] hw/pxb: declare pxb devices as not hot-pluggable

2016-06-30 Thread Marcel Apfelbaum
Prevent future issues when hotplug will work for devices attached to pxbs. Suggested-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/pci_expander_bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_

[Qemu-devel] [PATCH V4 0/6] pxb: fix 64-bit MMIO allocation

2016-06-30 Thread Marcel Apfelbaum
64-bit BARs allocations fix for devices behind PXBs/PXB-PCIEs. In build_crs() the calculation and merging of the ranges already happens in 64-bit, but the entry boundaries are silently truncated to 32-bit in the call to aml_dword_memory(). Fix it by handling the 64-bit MMIO ranges separately. v3

[Qemu-devel] [PATCH V4 1/6] tests/acpi: add pxb/pxb-pcie tests

2016-06-30 Thread Marcel Apfelbaum
Add an ivshmem device with 4G shared memory to pxb in order to check the ACPI code of 64bit MMIO allocation. Suggested-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- tests/bios-tables-test.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/

Re: [Qemu-devel] [PATCH] configure: mark qemu-ga VSS includes as system headers

2016-06-30 Thread Michael Roth
Quoting Michael Roth (2016-06-28 18:43:46) > As of e4650c81, we do w32 builds with -Werror enabled. Unfortunately > for cases where we enable VSS support in qemu-ga, we still have > warnings generated by VSS includes that ship as part of the Microsoft > VSS SDK. > > We can selectively address a nu

Re: [Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch

2016-06-30 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > Improve the TSC frequency mismatch warning to show the host and > VM TSC frequencies. > > Signed-off-by: Eduardo Habkost > --- > target-i386/kvm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target-i386/kvm.c b/tar

Re: [Qemu-devel] [PATCH] configure: Rename CONFIG_QGA_NTDDDISK into CONFIG_QGA_NTDDSCSI

2016-06-30 Thread Michael Roth
Quoting Thomas Huth (2016-06-10 10:25:54) > There is no CONFIG_QGA_NTDDDISK define used anywhere in the QEMU > sources. Looking at the changelog and qga/commands-win32.c, it > seems like this should be called CONFIG_QGA_NTDDSCSI instead. > > Signed-off-by: Thomas Huth Thanks, applied to qga tree

Re: [Qemu-devel] [PATCH v2 0/2] Remove test-qga temporary file

2016-06-30 Thread Michael Roth
Quoting marcandre.lur...@redhat.com (2016-06-15 06:05:59) > From: Marc-André Lureau > > Hi, > > Here are 2 small patches to remove the need for temporary file > creation in test-qga. > > v1->v2: > - use a symlink to tests/data instead of hardcoding SRC_PATH > > Marc-André Lureau (2): > build

Re: [Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-06-30 Thread Dmitry Osipenko
On 30.06.2016 18:02, Peter Maydell wrote: > On 27 June 2016 at 19:26, Dmitry Osipenko wrote: >> On 27.06.2016 16:27, Peter Maydell wrote: >>> I guess this fixes a regression, but it looks really weird. >>> Why should the timer behaviour change if there happens to be >>> a bottom half present? That

Re: [Qemu-devel] [PATCH] configure: mark qemu-ga VSS includes as system headers

2016-06-30 Thread Michael Roth
Quoting Thomas Huth (2016-06-29 03:27:26) > On 29.06.2016 01:43, Michael Roth wrote: > > As of e4650c81, we do w32 builds with -Werror enabled. Unfortunately > > for cases where we enable VSS support in qemu-ga, we still have > > warnings generated by VSS includes that ship as part of the Microsoft

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Kirti Wankhede
On 6/30/2016 12:42 PM, Jike Song wrote: > On 06/29/2016 09:51 PM, Xiao Guangrong wrote: >> On 06/21/2016 12:31 AM, Kirti Wankhede wrote: >>> + mutex_unlock(&parent_devices.list_lock); >>> + return parent; >>> +} >>> + >>> +static int mdev_device_create_ops(struct mdev_device *mdev, char >>>

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Kirti Wankhede
On 6/29/2016 7:21 PM, Xiao Guangrong wrote: > > > On 06/21/2016 12:31 AM, Kirti Wankhede wrote: >> Design for Mediated Device Driver: ... >> +static int mdev_add_attribute_group(struct device *dev, >> +const struct attribute_group **groups) >> +{ >> +return sysfs_create_

Re: [Qemu-devel] [RFC PATCH] exec: Support non-direct memory writes in cpu_memory_rw_debug

2016-06-30 Thread Andrey Smirnov
On Thu, Jun 30, 2016 at 7:06 AM, Peter Maydell wrote: > On 28 June 2016 at 22:44, Andrey Smirnov wrote: >> Add code to support writing to memory mapped peripherals via >> cpu_memory_rw_debug(). The code of that function already supports >> reading from such memory regions, so this commit makes th

Re: [Qemu-devel] [PATCH v2] pcspk: fix KVM

2016-06-30 Thread Peter Maydell
On 30 June 2016 at 15:57, Paolo Bonzini wrote: > The link property that was added to the pcspk device has the wrong type: > it is only correct for TCG and for KVM's userspace or split irqchip > options. The default KVM option (fully in-kernel irqchip) breaks > because it uses a PIT whose type is

Re: [Qemu-devel] [PATCH 1/2] hw/misc: fix Aspeed SCU hw-strap2 property

2016-06-30 Thread Peter Maydell
On 30 June 2016 at 16:50, Cédric Le Goater wrote: > These strap registers are complex enough, let's not mix them. > > Signed-off-by: Cédric Le Goater Was there a cover letter for this patchset? I can't find it in my email... thanks -- PMM

Re: [Qemu-devel] [RFC PATCH] exec: Support non-direct memory writes in cpu_memory_rw_debug

2016-06-30 Thread Andrey Smirnov
On Wed, Jun 29, 2016 at 8:55 AM, Paolo Bonzini wrote: > On 28/06/2016 23:44, Andrey Smirnov wrote: >> Add code to support writing to memory mapped peripherals via >> cpu_memory_rw_debug(). The code of that function already supports >> reading from such memory regions, so this commit makes that >>

Re: [Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread John Snow
On 06/30/2016 10:00 AM, Jeff Cody wrote: > On Thu, Jun 30, 2016 at 04:45:52PM +0800, Changlong Xie wrote: >> On 06/30/2016 04:25 PM, Fam Zheng wrote: >>> On Thu, 06/30 16:01, Changlong Xie wrote: Otherwise, we could never trigger assert(!bitmap->successor) Signed-off-by: Changlong

[Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch

2016-06-30 Thread Eduardo Habkost
Improve the TSC frequency mismatch warning to show the host and VM TSC frequencies. Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index f3698f1..9679415 100644 --- a/target-i386/kv

Re: [Qemu-devel] [PATCH v2] build: Use $(CCAS) for compiling .S files

2016-06-30 Thread Peter Maydell
On 23 June 2016 at 18:39, Richard Henderson wrote: > We fail to pass to $(AS) all of the different flags that may be required > for a given set of CFLAGS. Rather than figuring out the host-specific > mapping, it's better to allow the compiler driver to do that. > > However, simply using $(CC) run

Re: [Qemu-devel] [PATCH] linux-user: Fix compilation when F_SETPIPE_SZ isn't defined

2016-06-30 Thread Laurent Vivier
Le 30/06/2016 à 18:33, Peter Maydell a écrit : > Older kernels don't have F_SETPIPE_SZ and F_GETPIPE_SZ (in > particular RHEL6's system headers don't define these). Add > ifdefs so that we can gracefully fall back to not supporting > those guest ioctls rather than failing to build. > > Signed-of

Re: [Qemu-devel] [PATCH 3/4] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled

2016-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2016 at 04:11:44PM +0300, Marcel Apfelbaum wrote: > On 06/30/2016 04:01 PM, Igor Mammedov wrote: > > On Thu, 30 Jun 2016 15:48:54 +0300 > > Marcel Apfelbaum wrote: > > > > > On 06/30/2016 03:23 PM, Igor Mammedov wrote: > > > > fixes long standing issue where Linux kernel would ass

Re: [Qemu-devel] [PATCH 3/4] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled

2016-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2016 at 02:23:06PM +0200, Igor Mammedov wrote: > fixes long standing issue where Linux kernel would assing assign? > hotplugged CPU to 1st numa node as it discards proximity > for hotplugged CPUs after SRAT is parsed. > > Signed-off-by: Igor Mammedov > --- > hw/acpi/cpu.c | 9 +

Re: [Qemu-devel] [PATCH v7 7/7] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-30 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Signed-off-by: Lluís Vilanova >> Reviewed-by: Stefan Hajnoczi >> --- >> hmp-commands-info.hx |6 +- >> hmp-commands.hx |7 +- >> monitor.c| 17 +- >> qapi/trace.json | 32 +-- >> qmp-commands.hx

Re: [Qemu-devel] Bug in virtio_net_load

2016-06-30 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Jun 30, 2016 at 10:34:51AM +0200, Robin Geuze wrote: > > Hey, > > > > I work for TransIP and we host a VPS platform based on QEMU/KVM. We are > > currently running qemu 2.4.0. A few days ago we noticed that live migrations > > for some of our

Re: [Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

2016-06-30 Thread Denis V. Lunev
On 06/30/2016 07:40 PM, John Snow wrote: On 06/30/2016 05:12 AM, Denis V. Lunev wrote: On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: After loading bitmap from image and setting IN_USE flag in it's header, corresponding data (bitmap table and data clusters) becomes inconsistent an

Re: [Qemu-devel] Bug in virtio_net_load

2016-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2016 at 10:34:51AM +0200, Robin Geuze wrote: > Hey, > > I work for TransIP and we host a VPS platform based on QEMU/KVM. We are > currently running qemu 2.4.0. A few days ago we noticed that live migrations > for some of our VM's would fail. Further investigation turned out it was

Re: [Qemu-devel] [PATCH] spec/parallels: fix a mistake

2016-06-30 Thread John Snow
On 06/30/2016 01:12 PM, Denis V. Lunev wrote: > On 06/30/2016 07:43 PM, John Snow wrote: >> >> On 06/30/2016 04:15 AM, Vladimir Sementsov-Ogievskiy wrote: >>> We have only one flag for now - Empty Image flag. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> docs/specs/parallels.

Re: [Qemu-devel] [PATCH] spec/parallels: fix a mistake

2016-06-30 Thread Denis V. Lunev
On 06/30/2016 07:43 PM, John Snow wrote: On 06/30/2016 04:15 AM, Vladimir Sementsov-Ogievskiy wrote: We have only one flag for now - Empty Image flag. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/specs/parallels.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] Default for phys-addr-bits? (was Re: [PATCH 4/5] x86: Allow physical address bits to be set)

2016-06-30 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > > So that's mapped at an address beyond host phys-bits. > > And it hasn't failed/crashed etc - but I guess maybe nothing is using that > > 2G space? > > root@fedora ~# dmesg | grep Surface > [4.830095] [drm] qxl: 2048M of Surface memory size > > q

Re: [Qemu-devel] [PATCH] balloon: Fix failure of updating guest memory status

2016-06-30 Thread Li, Liang Z
> > +if (s->stats_vq_elem == NULL) { > > +virtqueue_push(s->svq, &elem, 0); > > +virtio_notify(vdev, s->svq); > > +return; > > +} > > virtqueue_push(s->svq, s->stats_vq_elem, s->stats_vq_offset); > > virtio_notify(vdev, s->svq); > > g_free(s->stats_vq_

Re: [Qemu-devel] [PATCH 2/3] VFIO driver for mediated PCI device

2016-06-30 Thread Kirti Wankhede
On 6/29/2016 8:24 AM, Alex Williamson wrote: > On Wed, 29 Jun 2016 00:15:23 +0530 > Kirti Wankhede wrote: > >> On 6/25/2016 1:15 AM, Alex Williamson wrote: >>> On Sat, 25 Jun 2016 00:04:27 +0530 >>> Kirti Wankhede wrote: >>> >> >> + >> +static int mdev_get_irq_count(struct vfio_mdev

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Kirti Wankhede
On 6/25/2016 1:10 AM, Alex Williamson wrote: > On Fri, 24 Jun 2016 23:24:58 +0530 > Kirti Wankhede wrote: > >> Alex, >> >> Thanks for taking closer look. I'll incorporate all the nits you suggested. >> >> On 6/22/2016 3:00 AM, Alex Williamson wrote: >>> On Mon, 20 Jun 2016 22:01:46 +0530 >>> Ki

Re: [Qemu-devel] [PATCH] balloon: Fix failure of updating guest memory status

2016-06-30 Thread Li, Liang Z
> >> What if we are not in the just-after-live-migration situation though? > >> If the guest simply didn't add a buffer to the queue for some reason, > >> wouldn't this newly added push/notify break the balloon protocol? > >> > > Could you elaborate how it happens? > > The added code only works for

Re: [Qemu-devel] [PATCH] spec/parallels: fix a mistake

2016-06-30 Thread John Snow
On 06/30/2016 04:15 AM, Vladimir Sementsov-Ogievskiy wrote: > We have only one flag for now - Empty Image flag. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > docs/specs/parallels.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/specs/parallels.txt b/

Re: [Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through qom

2016-06-30 Thread Denis V. Lunev
On 06/24/2016 01:49 PM, Denis V. Lunev wrote: From: Evgeny Yakovlev This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will check that required feature words are set in cpuid leaf 4003 through qom request. Currently qem

Re: [Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

2016-06-30 Thread John Snow
On 06/30/2016 05:12 AM, Denis V. Lunev wrote: > On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: >> After loading bitmap from image and setting IN_USE flag in it's header, >> corresponding data (bitmap table and data clusters) becomes inconsistent >> and is no longer needed. It is bett

Re: [Qemu-devel] [PULL 0/6] ipxe: update submodule from 4e03af8ec to 041863191

2016-06-30 Thread Peter Maydell
On 30 June 2016 at 17:21, Gerd Hoffmann wrote: > Hi, > >> Hi. I'm afraid this fails 'make check': >> TEST: tests/vmxnet3-test... (pid=19181) >> qemu-system-i386: -device vmxnet3: failed to find romfile "efi-vmxnet3.rom" >> Broken pipe > >> Looks like you forgot to add the new rom images to >> th

Re: [Qemu-devel] [PATCH v2] linux-user: Check sigsetsize argument to syscalls

2016-06-30 Thread Laurent Vivier
Le 30/06/2016 à 15:23, Peter Maydell a écrit : > Many syscalls which take a sigset_t argument also take an argument > giving the size of the sigset_t. The kernel insists that this > matches its idea of the type size and fails EINVAL if it is not. > Implement this logic in QEMU. (This mostly jus

[Qemu-devel] [PATCH] linux-user: Fix compilation when F_SETPIPE_SZ isn't defined

2016-06-30 Thread Peter Maydell
Older kernels don't have F_SETPIPE_SZ and F_GETPIPE_SZ (in particular RHEL6's system headers don't define these). Add ifdefs so that we can gracefully fall back to not supporting those guest ioctls rather than failing to build. Signed-off-by: Peter Maydell --- Reported by an anonymous IRC user...

Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers

2016-06-30 Thread John Snow
On 06/30/2016 02:30 AM, Markus Armbruster wrote: > John Snow writes: > >> On 06/28/2016 04:40 AM, Markus Armbruster wrote: >>> Sascha Silbe writes: >>> Dear Paolo, Paolo Bonzini writes: >> After applying your series on top of f12103af and running "./configure" >> i

Re: [Qemu-devel] [PULL 0/6] ipxe: update submodule from 4e03af8ec to 041863191

2016-06-30 Thread Gerd Hoffmann
Hi, > Hi. I'm afraid this fails 'make check': > TEST: tests/vmxnet3-test... (pid=19181) > qemu-system-i386: -device vmxnet3: failed to find romfile "efi-vmxnet3.rom" > Broken pipe > Looks like you forgot to add the new rom images to > the BLOBS list in Makefile. Forgot that indeed. But I thi

Re: [Qemu-devel] [PATCH 1/1] mirror: fix request throttling in drive-mirror

2016-06-30 Thread Jeff Cody
On Wed, Jun 22, 2016 at 03:35:27PM +0300, Denis V. Lunev wrote: > There are 2 deficiencies here: > - mirror_iteration could start several requests inside. Thus we could > simply have more in_flight requests than MAX_IN_FLIGHT. > - keeping this in mind throttling in mirror_run which is checking >

Re: [Qemu-devel] [PATCH 1/1] mirror: fix request throttling in drive-mirror

2016-06-30 Thread Jeff Cody
On Wed, Jun 22, 2016 at 03:35:27PM +0300, Denis V. Lunev wrote: > There are 2 deficiencies here: > - mirror_iteration could start several requests inside. Thus we could > simply have more in_flight requests than MAX_IN_FLIGHT. > - keeping this in mind throttling in mirror_run which is checking >

Re: [Qemu-devel] Default for phys-addr-bits? (was Re: [PATCH 4/5] x86: Allow physical address bits to be set)

2016-06-30 Thread Gerd Hoffmann
> So that's mapped at an address beyond host phys-bits. > And it hasn't failed/crashed etc - but I guess maybe nothing is using that 2G > space? root@fedora ~# dmesg | grep Surface [4.830095] [drm] qxl: 2048M of Surface memory size qxl bar 4 (64bit) and qxl bar 1 (32bit) are the same thing.

  1   2   3   >