Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-19 Thread Markus Armbruster
Peter Maydell writes: > On 19 July 2016 at 22:17, Pranith Kumar wrote: >> On Tue, Jul 19, 2016 at 4:53 PM, Peter Maydell >> wrote: >>> Does raise the question of whether we should be renaming >>> the file in the first place. README is the traditional >>> name and fits with all our other basica

Re: [Qemu-devel] [PATCH v2 1/1] KVM: PPC: Introduce KVM_CAP_PPC_HTM

2016-07-19 Thread Paolo Bonzini
On 20/07/2016 07:46, Michael Ellerman wrote: > Thanks. > > Acked-by: Michael Ellerman > > Or do you want me to merge this before Paul gets back? No, this should be merged through the KVM tree. Please Cc the KVM maintainers before offering to apply a patch that formally belongs to another tre

Re: [Qemu-devel] [PATCH v2 1/1] KVM: PPC: Introduce KVM_CAP_PPC_HTM

2016-07-19 Thread Michael Ellerman
Sam Bobroff writes: > Introduce a new KVM capability, KVM_CAP_PPC_HTM, that can be queried to > determine if a PowerPC KVM guest should use HTM (Hardware Transactional Minor nit, "should" should be "can" IMHO. > Memory). > > This will be used by QEMU to populate the pa-features bits in the > gu

Re: [Qemu-devel] [PATCH v4] qemu-img: add the 'dd' subcommand

2016-07-19 Thread Fam Zheng
On Tue, 07/19 19:44, Reda Sallahi wrote: > This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. > > For the start, this implements the bs, if, of and count options and requires > both if and of to be specified (no stdin/stdout if not specified) and doesn't > support tty, pipes, et

[Qemu-devel] [PATCH v3 07/10] Convert cpu_memory_rw_debug to use MemoryAccessType

2016-07-19 Thread Andrey Smirnov
Convert cpu_memory_rw_debug() to use MemoryAccessType as a way of specifying memory reads/writes. This makes caller code be more obvious in what it does (previously one had to interpret 0 or 1 and remember the semantics of the last boolean argument of the function). Signed-off-by: Andrey Smirnov

[Qemu-devel] [PATCH v3 06/10] Change signature of cpu_memory_rw_debug() to avoid casting

2016-07-19 Thread Andrey Smirnov
Change signature of cpu_memory_rw_debug() to expectet void * as a buffer instead of uint8_t * to avoid forcing the caller of the function to do a type cast. Reviewed-by: David Gibson Signed-off-by: Andrey Smirnov --- exec.c | 6 -- hw/i386/kvmvapic.c | 10

[Qemu-devel] [PATCH v3 10/10] exec: Use address_space_rw to handle reads and wirtes

2016-07-19 Thread Andrey Smirnov
Use address_space_rw to handle reads and wirtes in cpu_memory_rw_debug() this way it becomes possible to modify memory mapped registers through GDB connection. Signed-off-by: Andrey Smirnov --- exec.c| 55 --- gdbstub.c | 2

[Qemu-devel] [PATCH v3 05/10] Rename MMUAccessType to MemoryAccessType

2016-07-19 Thread Andrey Smirnov
Rename MMUAccessType to MemoryAccessType and MMU_* constants to corresponding MEM_* constants, so it would be possible to re-use these defenitions in other, non MMU-related, contexts. Signed-off-by: Andrey Smirnov --- include/exec/exec-all.h | 2 +- include/qom/cpu.h | 14

[Qemu-devel] [PATCH v3 08/10] Convert address_space_rw to use MemoryAccessType

2016-07-19 Thread Andrey Smirnov
Convert address_space_rw() to use MemoryAccessType following the conversion of cpu_memory_rw_debug(). Signed-off-by: Andrey Smirnov --- exec.c | 14 +- include/exec/memory.h| 7 +-- kvm-all.c| 8 +--- scripts/coverity-model.c | 9 +

[Qemu-devel] [PATCH v3 09/10] gdbstub: Convert target_memory_rw_debug to use MemoryAccessType

2016-07-19 Thread Andrey Smirnov
Convert target_memory_rw_debug to use MemoryAccessType as to follow similar conversion of cpu_memory_rw_debug. Signed-off-by: Andrey Smirnov --- gdbstub.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9c4cbe4..c215672 100644 --- a/g

[Qemu-devel] [PATCH v3 01/10] Avoid needless calls to address_space_rw()

2016-07-19 Thread Andrey Smirnov
Avoid calling address_space_rw() when direction of the transfer is constant and known at compile time and replace them with explicit calls to address_space_read()/address_space_write(). Reviewed-by: David Gibson Signed-off-by: Andrey Smirnov --- dma-helpers.c| 4 ++-- exec.c | 10

[Qemu-devel] [PATCH v3 03/10] Change signature of address_space_write() to avoid casting

2016-07-19 Thread Andrey Smirnov
Change signature of address_space_write() to expectet void * as a buffer instead of uint8_t * to avoid forcing the caller of the function to do a type cast. Reviewed-by: David Gibson Signed-off-by: Andrey Smirnov --- exec.c| 10 +- hw/net/dp8393x.c | 10 +-

[Qemu-devel] [PATCH v3 04/10] address_space_write_continue: Distill common code

2016-07-19 Thread Andrey Smirnov
Move call to memory_region_dispatch_write() outside of swtich statement since the only thing that is different about all of those call is "length" argument and that matches value in "l". Reviewed-by: David Gibson Signed-off-by: Andrey Smirnov --- exec.c | 23 +++ 1 file chan

[Qemu-devel] [PATCH v3 00/10] Support non-direct memory writes in cpu_memory_rw_debug

2016-07-19 Thread Andrey Smirnov
Hi everyone, This is the third version of the patch that implements an ability to write to MMIO registers from GDB stub. Changes since v2: - MMUAccessType is renamed to MemoryAccessType - Minor formating fixes Changes since v1 (https://www.mail-archive.com/qemu-devel@nongnu.org

[Qemu-devel] [PATCH v3 02/10] Change signature of address_space_read() to avoid casting

2016-07-19 Thread Andrey Smirnov
Change signature of address_space_read() to expectet void * as a buffer instead of uint8_t * to avoid forcing the caller of the function to do a type cast. Reviewed-by: David Gibson Signed-off-by: Andrey Smirnov --- exec.c| 2 +- hw/net/dp8393x.c | 16 hw/

Re: [Qemu-devel] [PATCH v5 05/14] nbd: Share common reply-sending code in server

2016-07-19 Thread Fam Zheng
On Tue, 07/19 08:52, Eric Blake wrote: > On 07/18/2016 11:10 PM, Fam Zheng wrote: > > On Mon, 07/18 22:07, Eric Blake wrote: > >> Rather than open-coding NBD_REP_SERVER, reuse the code we > >> already have by adding a length parameter. Additionally, > >> the refactoring will make adding NBD_OPT_GO

Re: [Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-07-19 Thread Fam Zheng
On Tue, 07/19 21:47, Eric Blake wrote: > > In block/raw-posix.c:handle_aiocb_write_zeroes(): > >> #ifdef CONFIG_FALLOCATE_PUNCH_HOLE > >> if (s->has_discard && s->has_fallocate) { > >> int ret = do_fallocate(s->fd, > >>FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEE

Re: [Qemu-devel] [PATCH v2 1/1] KVM: PPC: Introduce KVM_CAP_PPC_HTM

2016-07-19 Thread Balbir Singh
On 20/07/16 13:41, Sam Bobroff wrote: > Introduce a new KVM capability, KVM_CAP_PPC_HTM, that can be queried to > determine if a PowerPC KVM guest should use HTM (Hardware Transactional > Memory). > > This will be used by QEMU to populate the pa-features bits in the > guest's device tree. > > S

Re: [Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-07-19 Thread Eric Blake
On 07/19/2016 09:34 PM, Fam Zheng wrote: > On Tue, 07/19 17:45, Paolo Bonzini wrote: >> >> >> On 19/07/2016 17:28, Eric Blake wrote: If I'm reading the NBD proto.md correctly, this is not enough if NBD_CMD_FLAG_NO_HOLE is specified. We probably need to use a zeroed buffer with

[Qemu-devel] [PATCH v2 1/1] KVM: PPC: Introduce KVM_CAP_PPC_HTM

2016-07-19 Thread Sam Bobroff
Introduce a new KVM capability, KVM_CAP_PPC_HTM, that can be queried to determine if a PowerPC KVM guest should use HTM (Hardware Transactional Memory). This will be used by QEMU to populate the pa-features bits in the guest's device tree. Signed-off-by: Sam Bobroff --- v2: * Use CPU_FTR_TM_CO

Re: [Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-07-19 Thread Fam Zheng
On Tue, 07/19 17:45, Paolo Bonzini wrote: > > > On 19/07/2016 17:28, Eric Blake wrote: > >> If I'm reading the NBD proto.md correctly, this is not enough if > >> NBD_CMD_FLAG_NO_HOLE is specified. We probably need to use a zeroed buffer > >> with > >> blk_pwrite, or pass a new flag (BDRV_RED_NO_

Re: [Qemu-devel] [RFC PATCH V7 6/7] colo-compare: introduce packet comparison thread

2016-07-19 Thread Zhang Chen
On 07/19/2016 05:03 PM, Daniel P. Berrange wrote: On Tue, Jul 19, 2016 at 11:32:41AM +0800, Zhang Chen wrote: On 07/18/2016 04:37 PM, Daniel P. Berrange wrote: On Mon, Jul 18, 2016 at 03:40:49PM +0800, Zhang Chen wrote: If primary packet is same with secondary packet, we will send primary p

[Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-07-19 Thread Kwangwoo Lee
Add hotplug memory feature on aarch64 virt platfom. This patch is required to emulate a DIMM type memory like NVDIMM. Signed-off-by: Kwangwoo Lee --- default-configs/aarch64-softmmu.mak | 1 + hw/arm/virt.c | 110 include/hw/arm/virt.h

[Qemu-devel] [RFC PATCH 2/3] nvdimm: use configurable ACPI IO base and size

2016-07-19 Thread Kwangwoo Lee
This patch uses configurable IO base and size to create NPIO AML for ACPI NFIT. Since a different architecture like AArch64 does not use port-mapped IO, a configurable IO base is required to create correct mapping of ACPI IO address and size. Signed-off-by: Kwangwoo Lee --- hw/acpi/nvdimm.c

[Qemu-devel] [RFC PATCH 0/3] add nvdimm support on AArch64 virt platform

2016-07-19 Thread Kwangwoo Lee
This patch series add an evaluation environment of NVDIMM on AArch64 virt platform. Three parts need to be implemented to make this feature working properly. 1. memory hotplug on arm virt platform 2. configurable ACPI IO base and size both for i386 and arm platform 3. enable NVDIMM on arm virt pla

[Qemu-devel] [RFC PATCH 3/3] hw/arm/virt: add nvdimm emulation support

2016-07-19 Thread Kwangwoo Lee
This patch enables evaluating NVDIMM on aarch64 virt platform. The option - nvdimm - passed after machine type is disabled by default. The command below has been used to test the feature: ./aarch64-softmmu/qemu-system-aarch64 \ -machine type=virt,nvdimm=on

Re: [Qemu-devel] [RFC 1/2] spapr: Reverse order of hotpluggable cpus list

2016-07-19 Thread David Gibson
On Tue, Jul 19, 2016 at 01:52:40PM +0200, Peter Krempa wrote: > On Mon, Jul 18, 2016 at 19:19:19 +1000, David Gibson wrote: > > The spapr implementation of query-hotpluggable-cpus builds the list of > > hotpluggable cores from the end (most removed from the list head) > > because that's the easiest

Re: [Qemu-devel] [PULL v2 02/55] tests/prom-env-test: increase the test timeout

2016-07-19 Thread David Gibson
On Tue, Jul 19, 2016 at 08:50:23PM +0300, Michael S. Tsirkin wrote: > From: Marcel Apfelbaum > > On a slower machine the test can take more than 30 seconds. > Increase the timeout to 100 seconds. > > Signed-off-by: Marcel Apfelbaum > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S.

[Qemu-devel] [PULL 14/14] block/gluster: add support for multiple gluster servers

2016-07-19 Thread Jeff Cody
From: Prasanna Kumar Kalever This patch adds a way to specify multiple volfile servers to the gluster block backend of QEMU with tcp|rdma transport types and their port numbers. Problem: Currently VM Image on gluster volume is specified like this: file=gluster[+tcp]://host[:port]/testvol/a.img

[Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema

2016-07-19 Thread Jeff Cody
From: Prasanna Kumar Kalever this patch adds 'GlusterServer' related schema in qapi/block-core.json [Jeff: minor fix-ups of comments and formatting, per patch reviews] Signed-off-by: Prasanna Kumar Kalever Reviewed-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1468947453-5433-5-g

[Qemu-devel] [PULL 12/14] block/gluster: deprecate rdma support

2016-07-19 Thread Jeff Cody
From: Prasanna Kumar Kalever gluster volfile server fetch happens through unix and/or tcp, it doesn't support volfile fetch over rdma. The rdma code may actually mislead, so to make sure things do not break, for now we fallback to tcp when requested for rdma, with a warning. If you are wondering

[Qemu-devel] [PULL 09/14] mirror: fix request throttling in drive-mirror

2016-07-19 Thread Jeff Cody
From: "Denis V. Lunev" There are 2 deficiencies here: - mirror_iteration could start several requests inside. Thus we could simply have more in_flight requests than MAX_IN_FLIGHT. - keeping this in mind throttling in mirror_run which is checking s->in_flight == MAX_IN_FLIGHT is wrong. The pa

[Qemu-devel] [PULL 10/14] block/gluster: rename [server, volname, image] -> [host, volume, path]

2016-07-19 Thread Jeff Cody
From: Prasanna Kumar Kalever A future patch will add support for multiple gluster servers. Existing terminology is a bit unusual in relation to what names are used by other networked devices, and doesn't map very well to the terminology we expect to use for multiple servers. Therefore, rename th

[Qemu-devel] [PULL 11/14] block/gluster: code cleanup

2016-07-19 Thread Jeff Cody
From: Prasanna Kumar Kalever unified coding styles of multiline function arguments and other error functions moved random declarations of structures and other list variables Signed-off-by: Prasanna Kumar Kalever Reviewed-by: Eric Blake Reviewed-by: Jeff Cody Message-id: 1468947453-5433-3-git-

[Qemu-devel] [PULL 04/14] mirror: create mirror_dirty_init helper for mirror_run

2016-07-19 Thread Jeff Cody
From: "Denis V. Lunev" The code inside the helper will be extended in the next patch. mirror_run itself is overbloated at the moment. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Fam Zheng Message-id: 1468503209-19498-5-git-send-

[Qemu-devel] [PULL 08/14] mirror: improve performance of mirroring of empty disk

2016-07-19 Thread Jeff Cody
From: "Denis V. Lunev" We should not take into account zero blocks for delay calculations. They are not read and thus IO throttling is not required. In the other case VM migration with 16 Tb QCOW2 disk with 4 Gb of data takes days. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-O

[Qemu-devel] [PULL 07/14] mirror: efficiently zero out target

2016-07-19 Thread Jeff Cody
From: "Denis V. Lunev" With a bdrv_co_write_zeroes method on a target BDS and when this method is working as indicated by the bdrv_can_write_zeroes_with_unmap(), zeroes will not be placed into the wire. Thus the target could be very efficiently zeroed out. This should be done with the largest chu

[Qemu-devel] [PULL 01/14] dirty-bitmap: operate with int64_t amount

2016-07-19 Thread Jeff Cody
From: "Denis V. Lunev" Underlying HBitmap operates even with uint64_t. Thus this change is safe. This would be useful f.e. to mark entire bitmap dirty in one call. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-

[Qemu-devel] [PULL 06/14] mirror: optimize dirty bitmap filling in mirror_run a bit

2016-07-19 Thread Jeff Cody
From: "Denis V. Lunev" There is no need to scan allocation tables if we have mark_all_dirty flag set. Just mark it all dirty. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Fam Zheng Message-id: 1468503209-1

[Qemu-devel] [PULL 03/14] mirror: create mirror_throttle helper

2016-07-19 Thread Jeff Cody
From: "Denis V. Lunev" The patch also places last_pause_ns from stack in mirror_run into MirrorBlockJob structure. This helper will be useful in next patches. Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake Message-id: 1468503209-19498-4-git-send-email-...@openvz.org CC: Vladimir Sements

[Qemu-devel] [PULL 00/14] Block patches

2016-07-19 Thread Jeff Cody
The following changes since commit 5d3217340adcb6c4f0e4af5d2b865331eb2ff63d: disas: Fix ATTRIBUTE_UNUSED define clash with ALSA headers (2016-07-19 16:40:39 +0100) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-pull-request for you to fetch ch

[Qemu-devel] [PULL 05/14] block: remove extra condition in bdrv_can_write_zeroes_with_unmap

2016-07-19 Thread Jeff Cody
From: "Denis V. Lunev" All .bdrv_co_write_zeroes callbacks nowadays work perfectly even with backing store attached. If future new callbacks would be unable to do that - they have a chance to block this in bdrv_get_info(). Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake Reviewed-by: John

[Qemu-devel] [PULL 02/14] mirror: make sectors_in_flight int64_t

2016-07-19 Thread Jeff Cody
From: "Denis V. Lunev" We keep here the sum of int fields. Thus this could easily overflow, especially when we will start sending big requests in next patches. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by:

Re: [Qemu-devel] [PATCH 21/37] tests: fix qom-test leaks

2016-07-19 Thread Eric Blake
On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > tests/qom-test.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake > > diff --git a/tests/qom-test.c b/tests/qom-test.c > inde

Re: [Qemu-devel] [PATCH 16/37] pc: don't leak a20_line

2016-07-19 Thread Eric Blake
On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The irqs array is no longer being used > > Signed-off-by: Marc-André Lureau > --- > hw/i386/pc.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Eric Blake > diff --git a/hw/i386/pc.c b/hw/i386/

Re: [Qemu-devel] [PATCH 15/37] pc: simplify passing qemu_irq

2016-07-19 Thread Eric Blake
On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > qemu_irq is already a pointer, no need to have an extra pointer level. > > Signed-off-by: Marc-André Lureau > --- > hw/i386/pc.c | 8 > hw/input/pckbd.c | 4 ++-- > include/hw/i386/pc.

Re: [Qemu-devel] [PATCH 14/37] numa: do not leak NumaOptions

2016-07-19 Thread Eric Blake
On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > In all cases, call qapi_free_NumaOptions(), by using a common ending > block. > > Signed-off-by: Marc-André Lureau > --- > numa.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) >

Re: [Qemu-devel] [PATCH 12/37] tests: fix leak in test-string-input-visitor

2016-07-19 Thread Eric Blake
On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Free the list returned by visit_type_intList(). > > Signed-off-by: Marc-André Lureau > --- > tests/test-string-input-visitor.c | 1 + > 1 file changed, 1 insertion(+) Hmm, I thought I'd fixed that under v

Re: [Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on modern (PCIe) machines

2016-07-19 Thread Michael S. Tsirkin
On Tue, Jul 19, 2016 at 09:42:58PM +0300, Marcel Apfelbaum wrote: > Modern machines are expected to be used by newer setups with > modern guests aiming the use of the latest features. > > Enable modern and disable legacy for virtio devices > plugged into PCIe ports (Root ports or Downstream ports)

[Qemu-devel] [PULL 3/4] crypto: add support for querying parameters for block encryption

2016-07-19 Thread Max Reitz
From: "Daniel P. Berrange" When creating new block encryption volumes, we accept a list of parameters to control the formatting process. It is useful to be able to query what those parameters were for existing block devices. Add a qcrypto_block_get_info() method which returns a QCryptoBlockInfo i

[Qemu-devel] [PULL 2/4] AioContext: correct comments

2016-07-19 Thread Max Reitz
From: Cao jin Correct comments of field notify_me Cc: Kevin Wolf Cc: Max Reitz Signed-off-by: Cao jin Message-id: 1468575858-22975-1-git-send-email-caoj.f...@cn.fujitsu.com Signed-off-by: Max Reitz --- include/block/aio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/i

[Qemu-devel] [PULL 1/4] qcow2: do not allocate extra memory

2016-07-19 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy There are no needs to allocate more than one cluster, as we set avail_out for deflate to one cluster. Zlib docs (http://www.zlib.net/manual.html) says: "deflate compresses as much data as possible, and stops when the input buffer becomes empty or the output buf

[Qemu-devel] [PULL 0/4] Block patches

2016-07-19 Thread Max Reitz
The following changes since commit 5d3217340adcb6c4f0e4af5d2b865331eb2ff63d: disas: Fix ATTRIBUTE_UNUSED define clash with ALSA headers (2016-07-19 16:40:39 +0100) are available in the git repository at: git://github.com/XanClic/qemu.git tags/pull-block-2016-07-20 for you to fetch changes

[Qemu-devel] [PULL 4/4] block: export LUKS specific data to qemu-img info

2016-07-19 Thread Max Reitz
From: "Daniel P. Berrange" The qemu-img info command has the ability to expose format specific metadata about volumes. Wire up this facility for the LUKS driver to report on cipher configuration and key slot usage. $ qemu-img info ~/VirtualMachines/demo.luks image: /home/berrange/Virtual

Re: [Qemu-devel] [PATCH v20 5/5] block/gluster: add support for multiple gluster servers

2016-07-19 Thread Eric Blake
On 07/19/2016 10:57 AM, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. If rdma is deprecated, we don't need to mention it here. > > Problem: > > Currently VM I

Re: [Qemu-devel] [PULL 00/55] pc, pci, virtio: new features, cleanups, fixes

2016-07-19 Thread Michael S. Tsirkin
On Tue, Jul 19, 2016 at 12:52:23PM +0100, Peter Maydell wrote: > On 19 July 2016 at 05:52, Peter Xu wrote: > > On Tue, Jul 19, 2016 at 01:42:28AM +0300, Michael S. Tsirkin wrote: > >> Should be last pull with features for 2.7. > >> I mulled including Igor's cpu hot-unplug series, but it > >> appea

[Qemu-devel] [PULL v2 00/55] pc, pci, virtio: new features, cleanups, fixes

2016-07-19 Thread Michael S. Tsirkin
The following changes since commit 3913d3707e3debfbf0d2d014a1a793394993b088: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160718' into staging (2016-07-18 11:24:15 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_

[Qemu-devel] [PULL v2 00/55] pc, pci, virtio: new features, cleanups, fixes

2016-07-19 Thread Michael S. Tsirkin
The following changes since commit 3913d3707e3debfbf0d2d014a1a793394993b088: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160718' into staging (2016-07-18 11:24:15 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_

Re: [Qemu-devel] [PATCH 05/10] tcg: Prepare TB invalidation for lockless TB lookup

2016-07-19 Thread Paolo Bonzini
- Original Message - > From: "Sergey Fedorov" > To: "Paolo Bonzini" , qemu-devel@nongnu.org > Cc: "sergey fedorov" , "alex bennee" > > Sent: Tuesday, July 19, 2016 9:56:49 PM > Subject: Re: [PATCH 05/10] tcg: Prepare TB invalidation for lockless TB lookup > > On 19/07/16 11:32, Paolo

[Qemu-devel] [PATCH] pcie: fix link active status bit migration

2016-07-19 Thread Michael S. Tsirkin
We changed link status register in pci express endpoint capability over time. Specifically, commit b2101eae63ea57b571cee4a9075a4287d24ba4a4 ("pcie: Set the "link active" in the link status register") set data link layer link active bit in this register without adding compatibility to old machine t

Re: [Qemu-devel] [PATCH v5 00/15] backup compression

2016-07-19 Thread Jeff Cody
On Mon, Jul 04, 2016 at 03:28:11PM +0300, Denis V. Lunev wrote: > The idea is simple - backup is "written-once" data. It is written block > by block and it is large enough. It would be nice to save storage > space and compress it. > > These patches add the ability to compress data during backup. T

Re: [Qemu-devel] [PATCH v3 0/8] drive-mirror improvements

2016-07-19 Thread Jeff Cody
On Thu, Jul 14, 2016 at 04:33:21PM +0300, Denis V. Lunev wrote: > This patchset contains patches dealing with known-to-be-zero areas in drive > mirror from [PATCH 0/9] major rework of drive-mirror patchset. > > Changes from v2: > - added mirror_throttle helper (patch 3) to address Eric' comment ab

Re: [Qemu-devel] [PATCH v20 0/5] block/gluster: add support for multiple gluster servers

2016-07-19 Thread Jeff Cody
On Tue, Jul 19, 2016 at 10:27:28PM +0530, Prasanna Kumar Kalever wrote: > This version of patches are rebased repo at > git://repo.or.cz/qemu/armbru.git qapi-not-next > > Prasanna Kumar Kalever (5): > block/gluster: rename [server, volname, image] -> [host, volume, path] > block/gluster: code

Re: [Qemu-devel] [PATCH v20 4/5] block/gluster: using new qapi schema

2016-07-19 Thread Jeff Cody
On Tue, Jul 19, 2016 at 04:39:39PM -0400, Jeff Cody wrote: > On Tue, Jul 19, 2016 at 10:27:32PM +0530, Prasanna Kumar Kalever wrote: > > this patch adds 'GlusterServer' related schema in qapi/block-core.json > > > > Signed-off-by: Prasanna Kumar Kalever > > --- > > block/gluster.c | 115 >

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-19 Thread Peter Maydell
On 19 July 2016 at 22:17, Pranith Kumar wrote: > On Tue, Jul 19, 2016 at 4:53 PM, Peter Maydell > wrote: >> Does raise the question of whether we should be renaming >> the file in the first place. README is the traditional >> name and fits with all our other basically-plain-text >> document name

Re: [Qemu-devel] [PATCH 11/37] tests: fix small leak in test-io-channel-command

2016-07-19 Thread Eric Blake
On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > srcfifo && dstfifo must still be freed in this case. > > Signed-off-by: Marc-André Lureau > --- > tests/test-io-channel-command.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a

Re: [Qemu-devel] [PULL 09/12] Move README to markdown

2016-07-19 Thread Peter Maydell
On 19 July 2016 at 19:15, Pranith Kumar wrote: > On Tue, Jul 19, 2016 at 11:49 AM, Daniel P. Berrange > wrote: >> On Tue, Jul 19, 2016 at 10:34:16AM +0200, Paolo Bonzini wrote: >>> From: Pranith Kumar >>> >>> Move the README file to markdown so that it makes the github page look >>> prettier. I

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-19 Thread Peter Maydell
On 19 July 2016 at 18:47, Stefan Weil wrote: > Commit e5dfc5e8e715c572aea44ac4d96c43941d4741c7 renamed README but did not > update scripts/checkpatch.pl. Fix this. > > An update was also needed for qemu.nsi (Windows). > > Reported-by: Daniel P. Berrange > Signed-off-by: Stefan Weil > --- > qemu

Re: [Qemu-devel] VFIO PCIe Extended Capabilities

2016-07-19 Thread Spenser Gilliland
Hey Alex, > How so? The patch should make extended config space disappear when the > device is not on a PCIe bus. This is the correct behavior per the > PCIe spec. Are you trying to exploit this QEMU bug to see some PCIe > capabilities but not others? That's wrong, you'll need to move the > de

Re: [Qemu-devel] [PATCH v20 4/5] block/gluster: using new qapi schema

2016-07-19 Thread Jeff Cody
On Tue, Jul 19, 2016 at 10:27:32PM +0530, Prasanna Kumar Kalever wrote: > this patch adds 'GlusterServer' related schema in qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 115 > +-- > qapi/block-core.

Re: [Qemu-devel] VFIO PCIe Extended Capabilities

2016-07-19 Thread Spenser Gilliland
Hi Marcel, >> Indeed, if a device is attached to a PCI bus it makes no sense to advertise >> the extended configuration space. >> Can you please share the QEMU command line? Maybe is possible to make the >> device's bus PCIe in QEMU? Changing the following should make the tweak I proposed irrel

Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README

2016-07-19 Thread Pranith Kumar
On Tue, Jul 19, 2016 at 4:53 PM, Peter Maydell wrote: > Does raise the question of whether we should be renaming > the file in the first place. README is the traditional > name and fits with all our other basically-plain-text > document names like COPYING, MAINTAINERS, HACKING. > I was hoping tha

[Qemu-devel] [Bug 1591724] Re: Windows 7 installation DVD can't boot in qemu 2.6.0/OVMF

2016-07-19 Thread Mary Sherman
Fails on my machine, even with the HEAD of master as of today (5d3217340adcb6c4f0e4af5d2b865331eb2ff63d). Simplest configuration: cp $MY_BIOS $MY_BIOS_TMP; ./qemu-system-x86_64 \ -drive if=pflash,format=raw,readonly,file=$MY_BIOS \ -drive if=pflash,format=raw,file=$MY_BIOS_TMP \

Re: [Qemu-devel] [PATCH 11/37] tests: fix small leak in test-io-channel-command

2016-07-19 Thread Marc-André Lureau
Hi - Original Message - > On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > srcfifo && dstfifo must still be freed in this case. > > > > Signed-off-by: Marc-André Lureau > > --- > > tests/test-io-channel-command.c | 3 ++- > > 1 file change

Re: [Qemu-devel] [PATCH 09/37] tests: fix check-qom-interface leaks

2016-07-19 Thread Eric Blake
On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Found thanks to ASAN. > > Signed-off-by: Marc-André Lureau > --- > tests/check-qom-interface.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake > > diff --git a/tests/check-qom-interface

[Qemu-devel] [PULL for-2.7 24/25] nbd: Convert to byte-based interface

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake The NBD protocol doesn't have any notion of sectors, so it is a fairly easy conversion to use byte-based read and write. Signed-off-by: Eric Blake Acked-by: Paolo Bonzini Message-id: 1468624988-423-19-git-send-email-ebl...@redhat.com Signed-off-by: Stefan Hajnoczi --- block/

Re: [Qemu-devel] [PATCH 10/37] tests: fix check-qom-proplist leaks

2016-07-19 Thread Eric Blake
On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Found thanks to ASAN. > > Signed-off-by: Marc-André Lureau > --- > tests/check-qom-proplist.c | 16 > 1 file changed, 16 insertions(+) > Reviewed-by: Eric Blake -- Eric Blake eblake

Re: [Qemu-devel] [PATCH 08/37] qdist: fix entries memory leak

2016-07-19 Thread Eric Blake
On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > qdist_init() allocates of entries, make sure we don't leak it. s/of // > > Spotted thanks to ASAN. > > Signed-off-by: Marc-André Lureau > --- > util/qdist.c | 3 ++- > 1 file changed, 2 insertions(+), 1

[Qemu-devel] [PULL for-2.7 22/25] sheepdog: Switch .bdrv_co_discard() to byte-based

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake Another step towards killing off sector-based block APIs. Signed-off-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 1468624988-423-17-git-send-email-ebl...@redhat.com Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 17 ++--- 1 file changed, 10 inse

Re: [Qemu-devel] VFIO PCIe Extended Capabilities

2016-07-19 Thread Alex Williamson
On Tue, 19 Jul 2016 20:39:26 + Spenser Gilliland wrote: > >> Anyway, the current behavior is clearly a bug, so QEMU hard freeze > >> should be irrelevant. If anyone wants to take over the patch, feel > >> free. Thanks, > > > I suppose I can handle it, but sadly not for 2.7. > > If Spencer

[Qemu-devel] [PULL for-2.7 21/25] raw_bsd: Switch .bdrv_co_discard() to byte-based

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake Another step towards killing off sector-based block APIs. Signed-off-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 1468624988-423-16-git-send-email-ebl...@redhat.com Signed-off-by: Stefan Hajnoczi --- block/raw_bsd.c | 9 - 1 file changed, 4 insertions(+),

Re: [Qemu-devel] [PATCH 07/37] tests: fix test-iov leaks

2016-07-19 Thread Eric Blake
On 07/19/2016 02:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Spotted thanks to ASAN. > > Signed-off-by: Marc-André Lureau > --- > tests/test-iov.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/test-iov.c b/tests/test-iov.c > index 46ae25e..a

Re: [Qemu-devel] [PATCH 0/1] vmstatification of 0323 [for 2.8?]

2016-07-19 Thread Peter Maydell
On 19 July 2016 at 18:51, Dr. David Alan Gilbert wrote: > Hmm the n810 isn't happy for me in many ways: > a) It boots up to a desktop like thing with a couple of colourful >characters and a few icons but I can't interact with it at all. > b) Migration with current upstream fails wi

[Qemu-devel] [PULL for-2.7 20/25] qcow2: Switch .bdrv_co_discard() to byte-based

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake Another step towards killing off sector-based block APIs. Signed-off-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 1468624988-423-15-git-send-email-ebl...@redhat.com Signed-off-by: Stefan Hajnoczi --- block/qcow2.c | 10 +- 1 file changed, 5 insertions(+),

Re: [Qemu-devel] [PATCH v20 5/5] block/gluster: add support for multiple gluster servers

2016-07-19 Thread Jeff Cody
On Tue, Jul 19, 2016 at 10:27:33PM +0530, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currently VM Image on gluster volume is specified like

Re: [Qemu-devel] [PATCH 05/10] tcg: Prepare TB invalidation for lockless TB lookup

2016-07-19 Thread Sergey Fedorov
On 19/07/16 11:32, Paolo Bonzini wrote: > It looks much better now :) > When invalidating a translation block, set an invalid flag into the > TranslationBlock structure first. It is also necessary to check whether > the target TB is still valid after acquiring 'tb_lock' but before calling > tb_a

[Qemu-devel] [PULL for-2.7 19/25] nbd: Switch .bdrv_co_discard() to byte-based

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake Another step towards killing off sector-based block APIs. While at it, call directly into nbd-client.c instead of having a pointless trivial wrapper in nbd.c. Signed-off-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 1468624988-423-14-git-send-email-ebl...@redhat.com

Re: [Qemu-devel] [PATCH 36/37] ahci: fix sglist leak on retry

2016-07-19 Thread John Snow
On 07/19/2016 04:54 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > ahci-test /x86_64/ahci/io/dma/lba28/retry triggers the following leak: > > Direct leak of 16 byte(s) in 1 object(s) allocated from: > #0 0x7fc4b2a25e20 in malloc (/lib64/libasan.so.3+0xc6e20) > #1

[Qemu-devel] [PULL for-2.7 13/25] rbd: Switch rbd_start_aio() to byte-based

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake The internal function converts to byte-based before calling into RBD code; hoist the conversion to the callers so that callers can then be switched to byte-based themselves. Signed-off-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 1468624988-423-8-git-send-email-ebl.

[Qemu-devel] VFIO PCIe Extended Capabilities

2016-07-19 Thread Spenser Gilliland
Hi, I noticed your patches "vfio: add pcie extended capability support" and "vfio/pci: Hide SR-IOV capability" have gone into qemu mainline. These look really good, and thanks so much for doing these. I was wondering if there were any side effects to removing the pci_bus_is_express check on l

[Qemu-devel] [PULL for-2.7 10/25] block: Convert bdrv_aio_discard() to byte-based

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake Another step towards byte-based interfaces everywhere. Replace the sector-based bdrv_aio_discard() with a new byte-based bdrv_aio_pdiscard(), which silently ignores any unaligned head or tail. Driver callbacks will be converted in followup patches. Signed-off-by: Eric Blake M

Re: [Qemu-devel] [RFC PATCH] tcg: Optimize fence instructions

2016-07-19 Thread Pranith Kumar
Paolo Bonzini writes: > On 14/07/2016 22:29, Pranith Kumar wrote: >> +} else if (curr_mb_type == TCG_BAR_STRL && >> + prev_mb_type == TCG_BAR_LDAQ) { >> +/* Consecutive load-acquire and store-release barriers >> + * can be merged i

[Qemu-devel] [PULL for-2.7 04/25] nbd: Rely on block layer to break up large requests

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake Now that the block layer will honor max_transfer, we can simplify our code to rely on that guarantee. The readv code can call directly into nbd-client, just as the writev code has done since commit 52a4650. Interestingly enough, while qemu-io 'w 0 40m' splits into a 32M and 8M

[Qemu-devel] [Bug 485239] Re: Windows 2008 datacenter- 64 bit , installation fails with qemu-system-x86_64 0.11.50

2016-07-19 Thread pranith
Please try the latest version. The version you reported is too old. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/485239 Title: Windows 2008 datac

[Qemu-devel] [PULL for-2.7 03/25] block: Fragment writes to max transfer length

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake Drivers should be able to rely on the block layer honoring the max transfer length, rather than needing to return -EINVAL (iscsi) or manually fragment things (nbd). We already fragment write zeroes at the block layer; this patch adds the fragmentation for normal writes, after re

[Qemu-devel] [PULL for-2.7 08/25] block: Convert bdrv_discard() to byte-based

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake Another step towards byte-based interfaces everywhere. Replace the sector-based bdrv_discard() with a new byte-based bdrv_pdiscard(), which silently ignores any unaligned head or tail. Signed-off-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 1468624988-423-3-git-sen

[Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on modern (PCIe) machines

2016-07-19 Thread Marcel Apfelbaum
Modern machines are expected to be used by newer setups with modern guests aiming the use of the latest features. Enable modern and disable legacy for virtio devices plugged into PCIe ports (Root ports or Downstream ports). Using the Virtio 1 mode will remove the limitation of the number of device

[Qemu-devel] [PULL for-2.7 05/25] nbd: Drop unused offset parameter

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake Now that NBD relies on the block layer to fragment things, we no longer need to track an offset argument for which fragment of a request we are actually servicing. While at it, use true and false instead of 0 and 1 for a bool parameter. Signed-off-by: Eric Blake Reviewed-by: F

[Qemu-devel] [PULL for-2.7 01/25] block: Fragment reads to max transfer length

2016-07-19 Thread Stefan Hajnoczi
From: Eric Blake Drivers should be able to rely on the block layer honoring the max transfer length, rather than needing to return -EINVAL (iscsi) or manually fragment things (nbd). This patch adds the fragmentation in the block layer, after requests have been aligned (fragmenting before alignme

[Qemu-devel] [PULL v2 for-2.7 14/15] qapi: Change Netdev into a flat union

2016-07-19 Thread Markus Armbruster
From: Eric Blake This is a mostly-mechanical conversion that creates a new flat union 'Netdev' QAPI type that covers all the branches of the former 'NetClientOptions' simple union, where the branches are now listed in a new 'NetClientDriver' enum rather than generated from the simple union. The

  1   2   3   4   5   6   >