Re: [Qemu-devel] [RFC PATCH V9 5/7] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-07-21 Thread Zhang Chen
On 07/22/2016 02:45 PM, Li Zhijian wrote: On 07/22/2016 01:38 PM, Zhang Chen wrote: Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Cc: Daniel P . Berrange Cc: Pa

Re: [Qemu-devel] [RFC v1 05/13] target-ppc: add modulo word operations

2016-07-21 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Fri, Jul 22, 2016 at 10:59:18AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > [ Unknown signature status ] >> > On Mon, Jul 18, 2016 at 10:35:09PM +0530, Nikunj A Dadhania wrote: >> >> Adding following instructions: >> >

Re: [Qemu-devel] [RFC PATCH V9 5/7] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-07-21 Thread Li Zhijian
On 07/22/2016 01:38 PM, Zhang Chen wrote: Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Cc: Daniel P . Berrange Cc: Paolo Bonzini Signed-off-by: Zhang Chen Sign

Re: [Qemu-devel] [RFC v1 05/13] target-ppc: add modulo word operations

2016-07-21 Thread David Gibson
On Fri, Jul 22, 2016 at 10:59:18AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > [ Unknown signature status ] > > On Mon, Jul 18, 2016 at 10:35:09PM +0530, Nikunj A Dadhania wrote: > >> Adding following instructions: > >> > >> moduw: Modulo Unsigned Word > >> modsw: Modulo Signed

Re: [Qemu-devel] [RFC v1 13/13] target-ppc: introduce opc4 for Expanded Opcode

2016-07-21 Thread David Gibson
On Fri, Jul 22, 2016 at 11:05:54AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > [ Unknown signature status ] > > On Mon, Jul 18, 2016 at 10:35:17PM +0530, Nikunj A Dadhania wrote: > >> ISA 3.0 has introduced EO - Expanded Opcode. Introduce third level > >> indirect opcode table an

Re: [Qemu-devel] [RFC PATCH 0/2] Migration: support working on file:url

2016-07-21 Thread Hailiang Zhang
On 2016/7/21 20:19, Daniel P. Berrange wrote: On Thu, Jul 21, 2016 at 01:05:58PM +0800, zhanghailiang wrote: It is more simple to use file:url to migrate VM into file. Besides, it will be used in memory snapshot. NB, you can already migrate into a file "exec:/bin/cat > /path/to/file" and

Re: [Qemu-devel] [PATCH 6/8] spapr: init CPUState->cpu_index with index relative to core-id

2016-07-21 Thread Bharata B Rao
On Fri, Jul 22, 2016 at 01:23:01PM +1000, David Gibson wrote: > On Thu, Jul 21, 2016 at 05:54:37PM +0200, Igor Mammedov wrote: > > It will enshure that cpu_index for a given cpu stays the same > > regardless of the order cpus has been created/deleted and so > > it would be possible to migrate QEMU

[Qemu-devel] [RFC PATCH V9 2/7] colo-base: add colo-base to define and handle packet

2016-07-21 Thread Zhang Chen
COLO-base used by colo-compare and filter-rewriter. this can share common data structure like:net packet, and share other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/Makefile.objs | 1 + net/colo-base.c| 74

[Qemu-devel] [RFC PATCH V9 5/7] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-07-21 Thread Zhang Chen
Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Cc: Daniel P . Berrange Cc: Paolo Bonzini Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Cong

[Qemu-devel] [RFC PATCH V9 6/7] colo-compare: introduce packet comparison thread

2016-07-21 Thread Zhang Chen
If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes and secondary packet not, after REGULAR_PACKET_CHECK_MS milliseconds we set the primary packet as old_packet,then do a checkp

[Qemu-devel] [RFC PATCH V9 7/7] colo-compare: add TCP, UDP, ICMP packet comparison

2016-07-21 Thread Zhang Chen
We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. less checkpoint more efficiency. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 174 +++

[Qemu-devel] [RFC PATCH V9 4/7] colo-compare: track connection and enqueue packet

2016-07-21 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+ +-

[Qemu-devel] [RFC PATCH V9 1/7] colo-compare: introduce colo compare initialization

2016-07-21 Thread Zhang Chen
This a COLO net ascii figure: Primary qemu Secondary qemu +--+ ++ | +--

[Qemu-devel] [RFC PATCH V9 3/7] Jhash: add linux kernel jhashtable in qemu

2016-07-21 Thread Zhang Chen
Jhash used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/qemu/jhash.h | 61 1 file changed, 61 insertions(+) create mod

[Qemu-devel] [RFC PATCH V9 0/7] Introduce COLO-compare

2016-07-21 Thread Zhang Chen
COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. The full version in this github: https://github.com/zhangckid/qemu/tree/colo-v2.7-proxy-mode-compare-with-colo-base-jul22 v9: p5: - use chr_update_read_handler_full(

Re: [Qemu-devel] [RFC v1 13/13] target-ppc: introduce opc4 for Expanded Opcode

2016-07-21 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Mon, Jul 18, 2016 at 10:35:17PM +0530, Nikunj A Dadhania wrote: >> ISA 3.0 has introduced EO - Expanded Opcode. Introduce third level >> indirect opcode table and corresponding parsing routines. >> >> EO (11:12) Expanded opcode field >> Fo

Re: [Qemu-devel] [RFC v4] virtio-crypto specification

2016-07-21 Thread Zeng, Xin
On Friday, July 22, 2016 10:53 AM Gonglei (Arei) wrote: > > Hi Xin, > > Thank you so much for your great comments. > I agree with you almostly except some trivial detals. > Please see my below replies. > > And I'll submit V5 next week, and you can finish the asym algos parts if you > like. > Let

Re: [Qemu-devel] [RFC v1 10/13] target-ppc: add setb instruction

2016-07-21 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Mon, Jul 18, 2016 at 10:35:14PM +0530, Nikunj A Dadhania wrote: >> From: Vivek Andrew Sha >> >> Returns: >> -1 if bit 0 of CR field is set >> 0 if bit 1 of CR field is set >> 1 otherwise. > > Um.. that description is pretty inadeq

Re: [Qemu-devel] [RFC v1 05/13] target-ppc: add modulo word operations

2016-07-21 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Mon, Jul 18, 2016 at 10:35:09PM +0530, Nikunj A Dadhania wrote: >> Adding following instructions: >> >> moduw: Modulo Unsigned Word >> modsw: Modulo Signed Word >> >> Signed-off-by: Nikunj A Dadhania > > As rth has already mentioned this

Re: [Qemu-devel] [RFC v1 05/13] target-ppc: add modulo word operations

2016-07-21 Thread David Gibson
On Mon, Jul 18, 2016 at 10:35:09PM +0530, Nikunj A Dadhania wrote: > Adding following instructions: > > moduw: Modulo Unsigned Word > modsw: Modulo Signed Word > > Signed-off-by: Nikunj A Dadhania As rth has already mentioned this many branches probably means this wants a helper. > --- > targ

Re: [Qemu-devel] [RFC v1 10/13] target-ppc: add setb instruction

2016-07-21 Thread David Gibson
On Mon, Jul 18, 2016 at 10:35:14PM +0530, Nikunj A Dadhania wrote: > From: Vivek Andrew Sha > > Returns: > -1 if bit 0 of CR field is set > 0 if bit 1 of CR field is set > 1 otherwise. Um.. that description is pretty inadequate. Retuns where? Which CR field? > Signed-off-by: Vivek Andr

Re: [Qemu-devel] [RFC v1 13/13] target-ppc: introduce opc4 for Expanded Opcode

2016-07-21 Thread David Gibson
On Mon, Jul 18, 2016 at 10:35:17PM +0530, Nikunj A Dadhania wrote: > ISA 3.0 has introduced EO - Expanded Opcode. Introduce third level > indirect opcode table and corresponding parsing routines. > > EO (11:12) Expanded opcode field > Formats: XX1 > > EO (11:15) Expanded opcode field > Formats: V

Re: [Qemu-devel] [RFC v1 09/13] target-ppc: add cmpeqb instruction

2016-07-21 Thread David Gibson
On Mon, Jul 18, 2016 at 10:35:13PM +0530, Nikunj A Dadhania wrote: > From: Swapnil Bokade > > Search a byte in the stream of 8bytes provided in the register > > Signed-off-by: Sandipan Das > [ Modified the logic to use lesser temporaries ] > Signed-off-by: Nikunj A Dadhania rth's reference ma

[Qemu-devel] [PATCH] linux-user: correctly pack target_epoll_event for i386 target

2016-07-21 Thread Icenowy Zheng
According to comments in /usr/include/linux/eventpoll.h, x86_64 have the same memory layout of struct target_epoll_event as i386. So on a aligned host, if x86_64 should be packed, i386 will also need. This has been tested with a i386 guest on an arm host: without the patch, wineserver crashes (cor

Re: [Qemu-devel] [RFC v4] virtio-crypto specification

2016-07-21 Thread Zeng, Xin
On Sunday, June 26, 2016 5:35 PM, Gonglei (Arei) Wrote: > Hi all, > > This is the specification (version 4) about a new virtio crypto device. > In general, our comments around this proposal are listed below: 1. Suggest to introduce crypto services into virtio crypto device. The services current

Re: [Qemu-devel] [PATCH 0/8] Fix migration issues with arbitrary cpu-hot(un)plug

2016-07-21 Thread David Gibson
On Fri, Jul 22, 2016 at 12:56:26AM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 21, 2016 at 05:54:31PM +0200, Igor Mammedov wrote: > > Series fixes migration issues caused by unstable cpu_index which depended > > on order cpus were created/destroyed. It follows David's idea to make > > cpu_index

Re: [Qemu-devel] [RFC 0/2] cpu-add compatibility for query-hotpluggable-cpus implementations

2016-07-21 Thread David Gibson
On Tue, Jul 19, 2016 at 09:58:59AM +0530, Bharata B Rao wrote: > On Mon, Jul 18, 2016 at 06:20:35PM +0200, Igor Mammedov wrote: > > On Mon, 18 Jul 2016 17:06:18 +0200 > > Peter Krempa wrote: > > > > > On Mon, Jul 18, 2016 at 19:19:18 +1000, David Gibson wrote: > > > > I'm not entirely sure if thi

[Qemu-devel] [liqiang...@360.cn: 答复: Host memory leakage in QEMU xhci device emulation]

2016-07-21 Thread Michael S. Tsirkin
- Forwarded message from 李强 - Date: Fri, 22 Jul 2016 03:48:38 + From: 李强 To: "Michael S. Tsirkin" Subject: 答复: Host memory leakage in QEMU xhci device emulation Message-ID: <143c0afc63fc204cb0c55bb88f3a8abb0181d...@ex02.corp.qihoo.net> In-Reply-To: <20160722063935-mutt-send-email-

[Qemu-devel] [Bug 1605443] Re: QEMU epoll for i386-linux-user on arm host is broken in 2.6

2016-07-21 Thread Icenowy Zheng
Oh I have sent a patch to qemu-devel mailing list... (maybe the mail is rejected, as I'm using Yandex mail service...) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1605443 Title: QEMU epoll for i

Re: [Qemu-devel] [PATCH] checkpatch: fix break by renaming README

2016-07-21 Thread Peter Xu
On Thu, Jul 21, 2016 at 08:37:01AM -0600, Eric Blake wrote: > On 07/21/2016 04:15 AM, Peter Xu wrote: > > Without this, we cannot run checkpatch.pl under QEMU root directory. > > > > Signed-off-by: Peter Xu > > --- > > scripts/checkpatch.pl | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(

Re: [Qemu-devel] [PATCH 6/8] spapr: init CPUState->cpu_index with index relative to core-id

2016-07-21 Thread David Gibson
On Thu, Jul 21, 2016 at 05:54:37PM +0200, Igor Mammedov wrote: > It will enshure that cpu_index for a given cpu stays the same > regardless of the order cpus has been created/deleted and so > it would be possible to migrate QEMU instance with out of order > created CPU. > > Signed-off-by: Igor Mam

Re: [Qemu-devel] [PATCH v3 1/2] qdev: ignore GlobalProperty.errp for hotplugged devices

2016-07-21 Thread David Gibson
On Fri, Jul 22, 2016 at 01:01:26AM +0200, Greg Kurz wrote: > This patch ensures QEMU won't terminate while hotplugging a device if the > global property cannot be set and errp points to error_fatal or error_abort. > > While here, it also fixes indentation of the typename argument. > > Suggested-b

Re: [Qemu-devel] [PATCH 5/8] pc: init CPUState->cpu_index with index in possible_cpus[]

2016-07-21 Thread David Gibson
On Thu, Jul 21, 2016 at 05:54:36PM +0200, Igor Mammedov wrote: > It will enshure that cpu_index for a given cpu stays the same > regardless of the order cpus has been created/deleted. > > No compat code is needed as for initial cpus index in > possible_cpus[] matches cpu_index that's been auto-all

Re: [Qemu-devel] [PATCH 4/8] qdev: fix object reference leak in case device.realize() fails

2016-07-21 Thread David Gibson
On Thu, Jul 21, 2016 at 05:54:35PM +0200, Igor Mammedov wrote: > If device doesn't have parent assined before its realize > is called, device_set_realized() will implicitly set parent > to '/machine/unattached'. > > However device_set_realized() may fail after that point at > several other points

Re: [Qemu-devel] [PATCH 1/8] exec: reduce CONFIG_USER_ONLY ifdeffenery

2016-07-21 Thread David Gibson
On Thu, Jul 21, 2016 at 05:54:32PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: David Gibson I think this is long overdue. > --- > bsd-user/qemu.h | 2 -- > include/exec/exec-all.h | 12 > linux-user/qemu.h | 2 -- > exec.c

Re: [Qemu-devel] [PATCH 2/8] exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu

2016-07-21 Thread David Gibson
On Thu, Jul 21, 2016 at 05:54:33PM +0200, Igor Mammedov wrote: > Instead use QTAIL's tqe_prev field to detect if cpu's been > placed in list by cpu_exec_init() which is always set if > QTAIL element is in list. > > Fixes SIGSEGV on failure path in case cpu_index is assigned > by board and cpu.rela

Re: [Qemu-devel] [PATCH 3/8] exec: set cpu_index only if it's been explictly set

2016-07-21 Thread David Gibson
On Thu, Jul 21, 2016 at 05:54:34PM +0200, Igor Mammedov wrote: > it keeps the legacy behavior for all users that doesn't care > about stable cpu_index value, but would allow boards that > would support device_add/device_del to set stable cpu_index > that won't depend on order in which cpus are crea

Re: [Qemu-devel] [PATCH v12 13/27] intel_iommu: Add support for PCI MSI remap

2016-07-21 Thread Peter Xu
On Thu, Jul 21, 2016 at 08:45:30PM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 14, 2016 at 01:56:22PM +0800, Peter Xu wrote: > > This patch enables interrupt remapping for PCI devices. > > > > To play the trick, one memory region "iommu_ir" is added as child region > > of the original iommu mem

[Qemu-devel] [Bug 1605443] Re: QEMU epoll for i386-linux-user on arm host is broken in 2.6

2016-07-21 Thread pranith
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1605443 Title: QEMU epoll for i386-linux-user on arm host is broken in 2.6 Status in QEMU: Confi

Re: [Qemu-devel] [RFC v4] virtio-crypto specification

2016-07-21 Thread Gonglei (Arei)
Hi Xin, Thank you so much for your great comments. I agree with you almostly except some trivial detals. Please see my below replies. And I'll submit V5 next week, and you can finish the asym algos parts if you like. Let's co-work to finish the virtio-crypto spec, shall we? Regards, -Gonglei

[Qemu-devel] [Bug 1605443] [NEW] QEMU epoll for i386-linux-user on arm host is broken in 2.6

2016-07-21 Thread Icenowy Zheng
Public bug reported: I'm trying to get wine running on qemu-i386 on arm. I found that 2.5.1 is OK, but 2.6 is not. By bisecting, I found commit 928bed6a057cedd6110e634865e021a24029785a is the problem. I reverted this commit, and then epoll is OK now. It seems that the commit broke epoll of qem

Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features, cleanups, fixes

2016-07-21 Thread Fam Zheng
On Thu, 07/21 11:45, Peter Maydell wrote: > On 21 July 2016 at 11:36, Peter Xu wrote: > > On Thu, Jul 21, 2016 at 10:20:38AM +0100, Peter Maydell wrote: > >> Fails to build: > >> > >> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c: In > >> function ‘vtd_remap_irq_get’: > >> /home/petm

Re: [Qemu-devel] [PATCH v6 11/16] block: simplify drive-backup

2016-07-21 Thread Eric Blake
On 07/21/2016 01:40 PM, Denis V. Lunev wrote: > From: Pavel Butsykin > > Now that we can support boxed commands, use it to greatly reduce the > number of parameters (and likelihood of getting out of sync) when > adjusting drive-backup parameters.. s/.././ > > Signed-off-by: Pavel Butsykin > R

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Rename CONFIG_QGA_NTDDDISK into CONFIG_QGA_NTDDSCSI

2016-07-21 Thread Michael Roth
Quoting Michael Roth (2016-06-30 14:04:15) > Quoting Thomas Huth (2016-06-10 10:25:54) > > There is no CONFIG_QGA_NTDDDISK define used anywhere in the QEMU > > sources. Looking at the changelog and qga/commands-win32.c, it > > seems like this should be called CONFIG_QGA_NTDDSCSI instead. > > > > S

Re: [Qemu-devel] [PATCH v6 02/16] block: Convert bdrv_pwrite_compressed() to BdrvChild

2016-07-21 Thread Eric Blake
On 07/21/2016 01:40 PM, Denis V. Lunev wrote: > From: Pavel Butsykin > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Markus Armbruster > CC: Eric Blake > CC: John Snow > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > block/block-backend.c | 2 +- > b

Re: [Qemu-devel] [PATCH v6 01/16] block: switch blk_write_compressed() to byte-based interface

2016-07-21 Thread Eric Blake
On 07/21/2016 01:40 PM, Denis V. Lunev wrote: > From: Pavel Butsykin > > This is a preparatory patch, which continues the general trend of the > transition to the byte-based interfaces. bdrv_check_request() and > blk_check_requestis no longer used, so we can remove. s/requestis/request() are/ s/

[Qemu-devel] [PATCH v3 1/2] qdev: ignore GlobalProperty.errp for hotplugged devices

2016-07-21 Thread Greg Kurz
This patch ensures QEMU won't terminate while hotplugging a device if the global property cannot be set and errp points to error_fatal or error_abort. While here, it also fixes indentation of the typename argument. Suggested-by: Eduardo Habkost Signed-off-by: Greg Kurz --- hw/core/qdev-propert

[Qemu-devel] [PATCH v3 2/2] vl: exit if a bad property value is passed to -global

2016-07-21 Thread Greg Kurz
When passing '-global driver=host-powerpc64-cpu,property=compat,value=foo' on the command line, without this patch, we get the following warning per device (which means many lines if the guests has many cpus): qemu-system-ppc64: Warning: can't apply global host-powerpc64-cpu.compat=foo: Invali

[Qemu-devel] [PATCH v3 0/2] improve error handling of global properties

2016-07-21 Thread Greg Kurz
As suggested by Eduardo, this series split the error handling of global properties in two separate patches. --- Greg Kurz (2): qdev: ignore GlobalProperty.errp for hotplugged devices vl: exit if a bad property value is passed to -global hw/core/qdev-properties.c |4 ++-- includ

Re: [Qemu-devel] [PATCH v2 09/12] qapi: remove the "middle" mode

2016-07-21 Thread Eric Blake
On 07/21/2016 08:00 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Now that the register function is always generated, we can > remove the so-called "middle" mode from the generator script. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi-commands.py | 29 +--

Re: [Qemu-devel] [PATCH v2 08/12] build-sys: remove qmp-commands-old.h

2016-07-21 Thread Eric Blake
On 07/21/2016 08:00 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > Makefile.target | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Li

Re: [Qemu-devel] [PATCH v2 07/12] monitor: implement 'qmp_query_commands' without qmp_cmds

2016-07-21 Thread Eric Blake
On 07/21/2016 08:00 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > So we can get rid of the static qmp_cmds table. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 32 ++-- > 1 file changed, 14 insertions(+), 18 deletions(-) > Reviewe

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Michael S. Tsirkin
On Thu, Jul 21, 2016 at 11:58:52PM +0200, Gerd Hoffmann wrote: > Hi, > > > Actually this can still break existing scripts: > > stick a device on express bus but add disable-modern=on > > Gave you a legacy device previously but it no longer does. > > Unlikely to happen in practice because there

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Gerd Hoffmann
Hi, > Actually this can still break existing scripts: > stick a device on express bus but add disable-modern=on > Gave you a legacy device previously but it no longer does. Unlikely to happen in practice because there is little reason to use disable-modern=on in 2.6 & older because that is the

Re: [Qemu-devel] [PATCH 0/8] Fix migration issues with arbitrary cpu-hot(un)plug

2016-07-21 Thread Michael S. Tsirkin
On Thu, Jul 21, 2016 at 05:54:31PM +0200, Igor Mammedov wrote: > Series fixes migration issues caused by unstable cpu_index which depended > on order cpus were created/destroyed. It follows David's idea to make > cpu_index assignable by selected boards if board supports cpu-hotplug > with device_ad

Re: [Qemu-devel] [PATCH v4] virtio-pci: error out when both legacy and modern modes are disabled

2016-07-21 Thread Greg Kurz
On Thu, 21 Jul 2016 23:21:16 +0200 Greg Kurz wrote: > From: Greg Kurz > > Without presuming if we got there because of a user mistake or some > more subtle bug in the tooling, it really does not make sense to > implement a non-functional device. > > Signed-off-by: Greg Kurz > Reviewed-by: Mar

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Michael S. Tsirkin
On Wed, Jul 20, 2016 at 06:28:21PM +0300, Marcel Apfelbaum wrote: > Enable transitional virtio devices by default. > Enable virtio-1.0 for devices plugged into > PCIe ports (Root ports or Downstream ports). > > Using the virtio-1 mode will remove the limitation > of the number of devices that can

[Qemu-devel] [PATCH v4] virtio-pci: error out when both legacy and modern modes are disabled

2016-07-21 Thread Greg Kurz
From: Greg Kurz Without presuming if we got there because of a user mistake or some more subtle bug in the tooling, it really does not make sense to implement a non-functional device. Signed-off-by: Greg Kurz Reviewed-by: Marcel Apfelbaum Signed-off-by: Greg Kurz --- v4: - rephrased error mes

Re: [Qemu-devel] [PATCH v2 03/12] monitor: register gen:false commands manually

2016-07-21 Thread Eric Blake
On 07/21/2016 08:00 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Since a few commands are using 'gen': false, they are not registered > automatically by the generator. Register manually instead. > > This is in preparation for removal of qapi 'middle' mode generation. > >

Re: [Qemu-devel] [PATCH v2 06/12] monitor: remove mhandler.cmd_new

2016-07-21 Thread Eric Blake
On 07/21/2016 08:00 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is no longer necessary, now that middle mode has been removed. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 13 +-- > docs/writing-qmp-commands.txt | 8 +- > hmp-com

Re: [Qemu-devel] [PATCH] test: port postcopy test to ppc64

2016-07-21 Thread Thomas Huth
On 21.07.2016 15:46, Laurent Vivier wrote: > > > On 21/07/2016 15:16, Thomas Huth wrote: >> On 21.07.2016 12:12, Laurent Vivier wrote: >>> As userfaultfd syscall is available on powerpc, migration >>> postcopy can be used. >> >> Good idea to add this test for PPC, too! > > The idea comes from Da

Re: [Qemu-devel] [PATCH v2] test: port postcopy test to ppc64

2016-07-21 Thread Thomas Huth
On 21.07.2016 18:47, Laurent Vivier wrote: > As userfaultfd syscall is available on powerpc, migration > postcopy can be used. > > This patch adds the support needed to test this on powerpc, > instead of using a bootsector to run code to modify memory, > we use a FORTH script in "boot-command" pro

Re: [Qemu-devel] [PATCH v2 05/12] monitor: register the qapi generated commands

2016-07-21 Thread Eric Blake
On 07/21/2016 08:00 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Stop using the so-called 'middle' mode. Instead, use qmp_find_command() > from generated qapi commands registry. > > Note: this commit requires a 'make clean' prior to make, since the > generated files do no

Re: [Qemu-devel] [PATCH v2 02/12] qapi-schema: add 'device_add'

2016-07-21 Thread Eric Blake
On 07/21/2016 08:00 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Even though device_add is not fully qapi'fied, we may add it to the json > schema with 'gen': false, so registration and documentation can be > generated. > > Signed-off-by: Marc-André Lureau > --- > qapi-

Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour

2016-07-21 Thread Michael S. Tsirkin
On Wed, Jul 20, 2016 at 06:28:21PM +0300, Marcel Apfelbaum wrote: > Enable transitional virtio devices by default. > Enable virtio-1.0 for devices plugged into disable legacy is better, I agree. > PCIe ports (Root ports or Downstream ports). > > Using the virtio-1 mode will remove the limitation

Re: [Qemu-devel] [PULL v5 00/57] pc, pci, virtio: new features, cleanups, fixes

2016-07-21 Thread Peter Maydell
On 21 July 2016 at 18:50, Michael S. Tsirkin wrote: > The following changes since commit 5d3217340adcb6c4f0e4af5d2b865331eb2ff63d: > > disas: Fix ATTRIBUTE_UNUSED define clash with ALSA headers (2016-07-19 > 16:40:39 +0100) > > are available in the git repository at: > > git://git.kernel.org/

[Qemu-devel] [PATCH v6 07/16] qcow: add qcow_co_pwritev_compressed

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin Added implementation of the qcow_co_pwritev_compressed function that will allow us to safely use compressed writes for the qcow from running VMs. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster

Re: [Qemu-devel] [PATCH v3] virtio-pci: error out when both legacy and modern modes are disabled

2016-07-21 Thread Eric Blake
On 07/21/2016 11:43 AM, Greg Kurz wrote: > From: Greg Kurz > > Without presuming if we got there because of a user mistake or some > more subtle bug in the tooling, it really does not make sense to > implement a non-functional device. > > Signed-off-by: Greg Kurz > Signed-off-by: Greg Kurz > -

[Qemu-devel] [PATCH v6 13/16] drive-backup: added support for data compression

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. The patch adds a flag to the qmp/hmp drive-backup command which enables block compression. Compression should be i

[Qemu-devel] [PATCH v6 00/16] backup compression

2016-07-21 Thread Denis V. Lunev
The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. These patches add the ability to compress data during backup. This functionality is implemented by means of adding options to the qmp/hmp

Re: [Qemu-devel] [PATCH v2] virtio-pci: error out when both legacy and modern modes are disabled

2016-07-21 Thread Eric Blake
On 07/21/2016 09:52 AM, Greg Kurz wrote: > From: Greg Kurz > > Without presuming if we got there because of a user mistake or some > more subtle bug in the tooling, it really does not make sense to > implement a non-functional device. > > Signed-off-by: Greg Kurz > Signed-off-by: Greg Kurz > -

[Qemu-devel] [PATCH v6 11/16] block: simplify drive-backup

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin Now that we can support boxed commands, use it to greatly reduce the number of parameters (and likelihood of getting out of sync) when adjusting drive-backup parameters.. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V. Lunev CC: Jeff Cod

[Qemu-devel] [PATCH v6 15/16] qemu-iotests: test backup compression in 055

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin Added cases to check the backup compression out of qcow2, raw in qcow2 on drive-backup and blockdev-backup. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow CC: St

[Qemu-devel] [PATCH v6 14/16] blockdev-backup: added support for data compression

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Mar

[Qemu-devel] [PATCH v6 16/16] qemu-iotests: add vmdk for test backup compression in 055

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin The vmdk format has support for compression, it would be fine to add it for the test backup compression Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow CC: Stefan

[Qemu-devel] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard

2016-07-21 Thread Eric Blake
Dell Equallogic iSCSI SANs have a very unusual advertised geometry: $ iscsi-inq -e 1 -c $((0xb0)) iscsi://XXX/0 wsnz:0 maximum compare and write length:1 optimal transfer length granularity:0 maximum transfer length:0 optimal transfer length:0 maximum prefetch xdread xdwrite transfer length:0 maxi

Re: [Qemu-devel] [PATCH 24/37] pc: keep gsi reference

2016-07-21 Thread Eduardo Habkost
On Thu, Jul 21, 2016 at 02:28:33PM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Thu, Jul 21, 2016 at 01:27:35PM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > On Tue, Jul 19, 2016 at 12:54:19PM +0400, marcandre.lur...@redh

[Qemu-devel] [PATCH v6 02/16] block: Convert bdrv_pwrite_compressed() to BdrvChild

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow CC: Stefan Hajnoczi CC: Kevin Wolf --- block/block-backend.c | 2 +- block/io.c| 3 ++- include/block/block.h | 2 +- 3 files chan

[Qemu-devel] [PATCH v6 12/16] block: simplify blockdev-backup

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin Now that we can support boxed commands, use it to greatly reduce the number of parameters (and likelihood of getting out of sync) when adjusting blockdev-backup parameters. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V. Lunev CC: Jeff C

[Qemu-devel] [PATCH v6 06/16] vmdk: add vmdk_co_pwritev_compressed

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin Added implementation of the vmdk_co_pwritev_compressed function that will allow us to safely use compressed writes for the vmdk from running VMs. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster

[Qemu-devel] [PATCH v6 01/16] block: switch blk_write_compressed() to byte-based interface

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin This is a preparatory patch, which continues the general trend of the transition to the byte-based interfaces. bdrv_check_request() and blk_check_requestis no longer used, so we can remove. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V.

[Qemu-devel] [PATCH v6 09/16] block: remove BlockDriver.bdrv_write_compressed

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin There are no block drivers left that implement the old .bdrv_write_compressed interface, so it can be removed. Also now we have no need to use the bdrv_pwrite_compressed function and we can remove it entirely. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Sign

[Qemu-devel] [PATCH v6 08/16] qcow: cleanup qcow_co_pwritev_compressed to avoid the recursion

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin Now that the function uses a vector instead of a buffer, there is no need to use recursive code. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow CC: Stefan Hajnoc

[Qemu-devel] [PATCH v6 05/16] qcow2: cleanup qcow2_co_pwritev_compressed to avoid the recursion

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin Now that the function uses a vector instead of a buffer, there is no need to use recursive code. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow CC: Stefan Hajnoc

[Qemu-devel] [PATCH v6 03/16] block/io: reuse bdrv_co_pwritev() for write compressed

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin For bdrv_pwrite_compressed() it looks like most of the code creating coroutine is duplicated in bdrv_prwv_co(). So we can just add a flag (BDRV_REQ_WRITE_COMPRESSED) and use bdrv_prwv_co() as a generic one. In the end we get coroutine oriented function for write compressed by

[Qemu-devel] [PATCH 2/4] nbd: Limit nbdflags to 16 bits

2016-07-21 Thread Eric Blake
Rather than asserting that nbdflags is within range, just give it the correct type to begin with :) nbdflags corresponds to the per-export portion of NBD Protocol "transmission flags", which is 16 bits in response to NBD_OPT_EXPORT_NAME and NBD_OPT_GO. Furthermore, upstream NBD has never passed t

[Qemu-devel] [PATCH v6 04/16] qcow2: add qcow2_co_pwritev_compressed

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin Added implementation of the qcow2_co_pwritev_compressed function that will allow us to safely use compressed writes for the qcow2 from running VMs. Signed-off-by: Pavel Butsykin Reviewed-by: Stefan Hajnoczi Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruste

[Qemu-devel] [PATCH v6 10/16] block/io: turn on dirty_bitmaps for the compressed writes

2016-07-21 Thread Denis V. Lunev
From: Pavel Butsykin Previously was added the assert: commit 1755da16e32c15b22a521e8a38539e4b5cf367f3 Author: Paolo Bonzini Date: Thu Oct 18 16:49:18 2012 +0200 block: introduce new dirty bitmap functionality Now the compressed write is always in coroutine and setting the bits is don

[Qemu-devel] [PATCH for-2.7 0/4] NBD and block alignment fixes

2016-07-21 Thread Eric Blake
This series extracts a couple of bug fixes that should be included in 2.7, out of my earlier v5 NBD series [1] that was deemed too large and too late. Then it tackles the promised regression fix reported by Peter for Dell Equallogic iSCSI SANs with their unusual non-power-of-2 unmap granularity.

[Qemu-devel] [PATCH 3/4] osdep: Document differences in rounding macros

2016-07-21 Thread Eric Blake
Make it obvious which macros are safe in which situations. Useful since QEMU_ALIGN_UP and ROUND_UP both purport to do the same thing, but differ on whether the alignment must be a power of 2. Signed-off-by: Eric Blake --- include/qemu/osdep.h | 6 +- 1 file changed, 5 insertions(+), 1 delet

[Qemu-devel] [PATCH 1/4] nbd: Fix bad flag detection on server

2016-07-21 Thread Eric Blake
Commit ab7c548e added a check for invalid flags, but used an early return on error instead of properly going through the cleanup label. Signed-off-by: Eric Blake --- v1: extract from larger series previously 1/14 of v5 NBD write zeroes series v4: new patch --- nbd/server.c | 3 ++- 1 file chang

Re: [Qemu-devel] [PULL 0/4] Block patches

2016-07-21 Thread Peter Maydell
On 20 July 2016 at 22:16, Eric Blake wrote: > On 07/20/2016 10:05 AM, Peter Maydell wrote: >> On 19 July 2016 at 23:47, Max Reitz wrote: >>> The following changes since commit 5d3217340adcb6c4f0e4af5d2b865331eb2ff63d: >>> >>> disas: Fix ATTRIBUTE_UNUSED define clash with ALSA headers (2016-07-1

Re: [Qemu-devel] [PATCH v3] virtio-pci: error out when both legacy and modern modes are disabled

2016-07-21 Thread Marcel Apfelbaum
On 07/21/2016 08:43 PM, Greg Kurz wrote: From: Greg Kurz Without presuming if we got there because of a user mistake or some more subtle bug in the tooling, it really does not make sense to implement a non-functional device. Signed-off-by: Greg Kurz Signed-off-by: Greg Kurz --- v3: - rebased

[Qemu-devel] [PULL v5 49/57] virtio-balloon: Wrap in vmstate

2016-07-21 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 19 +--

[Qemu-devel] [PULL v5 47/57] virtio-blk: Wrap in vmstate

2016-07-21 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/block/virtio-blk.c | 16 ++-- 1 file

[Qemu-devel] [PULL v5 46/57] virtio-scsi: Wrap in vmstate

2016-07-21 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/scsi/virtio-scsi.c | 21 ++--- 1

[Qemu-devel] [PULL v5 38/57] virtio: Introduce virtio_add_queue_aio

2016-07-21 Thread Michael S. Tsirkin
From: Fam Zheng Using this function instead of virtio_add_queue marks the vq as aio based. This differentiation will be useful in later patches. Distinguish between virtqueue processing in the iohandler context and main loop AioContext. iohandler context is isolated from AioContexts and therefo

[Qemu-devel] [PULL v5 35/57] kvm-all: add trace events for kvm irqchip ops

2016-07-21 Thread Michael S. Tsirkin
From: Peter Xu These will help us monitoring irqchip route activities more easily. Signed-off-by: Peter Xu Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- kvm-all.c| 5 + trace-events | 3 +++ 2 files changed, 8 insertions(+) diff --

Re: [Qemu-devel] [PATCH v2] test: port postcopy test to ppc64

2016-07-21 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > As userfaultfd syscall is available on powerpc, migration > postcopy can be used. > > This patch adds the support needed to test this on powerpc, > instead of using a bootsector to run code to modify memory, > we use a FORTH script in "boot-command" p

Re: [Qemu-devel] [PATCH 24/37] pc: keep gsi reference

2016-07-21 Thread Eduardo Habkost
On Thu, Jul 21, 2016 at 01:27:35PM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Tue, Jul 19, 2016 at 12:54:19PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Further cleanup would need to call qemu_free_irq() at the appropriat

  1   2   3   4   5   >