Re: [Qemu-devel] [RFC PATCH 2/3] nvdimm: use configurable ACPI IO base and size

2016-07-25 Thread kwangwoo....@sk.com
Hi Peter, Thanks for reviewing the patches! I added some comments below. > -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Tuesday, July 26, 2016 1:13 AM > To: 이광우(LEE KWANGWOO) MS SW > Cc: Xiao Guangrong; Michael S. Tsirkin; Igor Mammedov; Paolo Bonzini

Re: [Qemu-devel] [RFC PATCH 0/3] add nvdimm support on AArch64 virt platform

2016-07-25 Thread kwangwoo....@sk.com
Hi Peter, Thanks for your kind comment! I described about NVDIMM briefly below. > -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Tuesday, July 26, 2016 1:07 AM > To: 이광우(LEE KWANGWOO) MS SW > Cc: Xiao Guangrong; Michael S. Tsirkin; Igor Mammedov; Paolo

Re: [Qemu-devel] [PATCH v1 1/8] hw: arm: SMMUv3 emulation model

2016-07-25 Thread Edgar E. Iglesias
On Thu, Jun 23, 2016 at 11:52:14AM +0530, Prem Mallappa wrote: > Big patch adds SMMUv3 model to Qemu > - As per SMMUv3 spec 16.0 > - Works with SMMUv3 driver in Linux 4.7rc1 > - Only LPAE mode translation supported > - BE mode is not supported yet > - Stage1, Stage2 and S1+S2 > - Suspen

Re: [Qemu-devel] [PATCH 2/3] hw/ppc: use error_report instead of fprintf

2016-07-25 Thread Cédric Le Goater
On 07/26/2016 07:58 AM, David Gibson wrote: > On Mon, Jul 25, 2016 at 04:24:42PM +0200, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater > > So, when I did some previous conversions to error_report(), I left out > the DT code, in the hopes I'd obsolete it with a more thorough > cleanup.

Re: [Qemu-devel] [PATCH 3/3] ppc/pnv: Add skeletton PowerNV platform

2016-07-25 Thread David Gibson
On Mon, Jul 25, 2016 at 04:24:43PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > No devices yet, not even an interrupt controller, just to get > started. > > (Folded in Stewart Smith patch to add command lien support) typo

Re: [Qemu-devel] [PATCH 2/3] hw/ppc: use error_report instead of fprintf

2016-07-25 Thread David Gibson
On Mon, Jul 25, 2016 at 04:24:42PM +0200, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater So, when I did some previous conversions to error_report(), I left out the DT code, in the hopes I'd obsolete it with a more thorough cleanup. Since that won't happen for a while yet, I'm happy en

Re: [Qemu-devel] [PATCH 1/3] hw/ppc: include fdt helper routine in a common file

2016-07-25 Thread David Gibson
On Mon, Jul 25, 2016 at 04:24:41PM +0200, Cédric Le Goater wrote: > spapr_pci would also be a good candidate but the macro _FDT is > slightly different. It returns and does not exit. > > Signed-off-by: Cédric Le Goater Ugh, I so want to get rid of that ugly macro. It may be a while before I hav

Re: [Qemu-devel] [PATCH v1 1/8] hw: arm: SMMUv3 emulation model

2016-07-25 Thread Edgar E. Iglesias
On Thu, Jun 23, 2016 at 11:52:14AM +0530, Prem Mallappa wrote: > Big patch adds SMMUv3 model to Qemu > - As per SMMUv3 spec 16.0 > - Works with SMMUv3 driver in Linux 4.7rc1 > - Only LPAE mode translation supported > - BE mode is not supported yet > - Stage1, Stage2 and S1+S2 > - Suspen

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-25 Thread Amit Shah
On (Wed) 20 Jul 2016 [12:08:32], Eduardo Habkost wrote: > From: Igor Mammedov > > instance_id is generated by last_used_id + 1 for a given device type > so for QEMU with 3 CPUs instance_id for APICs is a seti of [0, 1, 2] > When CPU in the middle is hot-removed and migration started > APICs with

Re: [Qemu-devel] [PATCH v4 6/8] STM32F205: Connect the ADC devices

2016-07-25 Thread Alistair Francis
On Mon, Jul 25, 2016 at 10:17 AM, Peter Maydell wrote: > On 23 July 2016 at 17:42, Alistair Francis wrote: >> Connect the ADC devices to the STM32F205 SoC. >> >> Signed-off-by: Alistair Francis >> --- >> V4: >> - Connect all the interrupt lines correctly >> V2: >> - Fix up the device/devices c

Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag

2016-07-25 Thread Amit Shah
On (Tue) 05 Jul 2016 [18:47:40], Michael S. Tsirkin wrote: > From: Cao jin > > internal flag msi_in_use in unnecessary, msi_uninit() could be called > directly, and msi_enabled() is enough to check device msi state. > > cc: Markus Armbruster > cc: Marcel Apfelbaum > cc: Paolo Bonzini > cc: Mi

Re: [Qemu-devel] [PATCH 6/8] spapr: init CPUState->cpu_index with index relative to core-id

2016-07-25 Thread David Gibson
On Thu, Jul 21, 2016 at 05:54:37PM +0200, Igor Mammedov wrote: > It will enshure that cpu_index for a given cpu stays the same > regardless of the order cpus has been created/deleted and so > it would be possible to migrate QEMU instance with out of order > created CPU. > > Signed-off-by: Igor Mam

Re: [Qemu-devel] [PATCH v2 0/6] Fix migration issues with arbitrary cpu-hot(un)plug

2016-07-25 Thread David Gibson
On Mon, Jul 25, 2016 at 11:59:18AM +0200, Igor Mammedov wrote: > Changes from v1: > - be conservative, drop QTAIL_*() macros hunks and do list element > check/cleanup localy in cpu_exec_exit() > - fix conflict caused by above > - update Reviewed-bys fom v1 > - drop spapr patches as they

[Qemu-devel] [PATCH v13 7/9] target-avr: adding instruction translation

2016-07-25 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/Makefile.objs|2 +- target-avr/translate-inst.c | 2622 +++ target-avr/translate.c |1 - target-avr/translate.h |1 + 4 files changed, 2624 insertions(+), 2 deletions(-) create mode 100

[Qemu-devel] [PATCH v13 8/9] target-avr: instruction decoder generator

2016-07-25 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpugen/CMakeLists.txt | 38 +++ target-avr/cpugen/README.md| 17 ++ target-avr/cpugen/cpu/avr.yaml | 214 ++ target-avr/cpugen/src/CMakeLists.txt | 63 target-avr/cpugen/src/cpugen.cpp

[Qemu-devel] [PATCH v13 6/9] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions

2016-07-25 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu.h | 13 ++- target-avr/helper.c| 288 ++--- target-avr/helper.h| 8 +- target-avr/translate.c | 9 ++ 4 files changed, 300 insertions(+), 18 deletions(-) diff --git a/target-avr/cpu.h

[Qemu-devel] [PATCH v13 3/9] target-avr: adding a sample AVR board

2016-07-25 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- MAINTAINERS | 6 +++ hw/avr/Makefile.objs | 21 + hw/avr/sample.c | 117 +++ 3 files changed, 144 insertions(+) create mode 100644 hw/avr/Makefile.objs create mode 100644 hw/avr/sample.c

[Qemu-devel] [PATCH v13 4/9] target-avr: adding instructions encodings

2016-07-25 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.h | 805 1 file changed, 805 insertions(+) create mode 100644 target-avr/translate-inst.h diff --git a/target-avr/translate-inst.h b/target-avr/translate-inst.h new file mode 100644 index 00

[Qemu-devel] [PATCH v13 5/9] target-avr: adding AVR interrupt handling

2016-07-25 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 59 - 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/target-avr/helper.c b/target-avr/helper.c index 3984fc8..1e5d97d 100644 --- a/target-avr/helper.c +++ b/target-avr/helper

[Qemu-devel] [PATCH v13 0/9] 8bit AVR cores

2016-07-25 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support yet

[Qemu-devel] [PATCH v13 1/9] target-avr: AVR cores support is added.

2016-07-25 Thread Michael Rolnik
1. basic CPU structure 2. registers 3. no instructions 4. saving sreg, rampD, rampX, rampY, rampD, eind in HW representation Signed-off-by: Michael Rolnik --- arch_init.c | 2 + configure | 5 + default-configs/avr-softmmu.mak | 21 +

[Qemu-devel] [PATCH v13 2/9] target-avr: adding AVR CPU features/flavors

2016-07-25 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu.c | 319 +-- target-avr/cpu.h | 52 - target-avr/machine.c | 28 ++--- 3 files changed, 373 insertions(+), 26 deletions(-) diff --git a/target-avr/cpu.c b/target-avr/cpu.c index c5e

Re: [Qemu-devel] [PATCH v4 4/8] STM32F2xx: Add the SPI device

2016-07-25 Thread Alistair Francis
On Mon, Jul 25, 2016 at 9:42 AM, Peter Maydell wrote: > On 23 July 2016 at 17:42, Alistair Francis wrote: >> Add the STM32F2xx SPI device. >> >> Signed-off-by: Alistair Francis >> --- > >> +static uint64_t stm32f2xx_spi_read(void *opaque, hwaddr addr, >> + uns

[Qemu-devel] [PATCH v2] x86: ioapic: conditionally upgrade IOAPIC version

2016-07-25 Thread Peter Xu
IOMMU IR and IOAPIC legacy devices (e.g., e1000) cannot work well together with some old Linux kernels (upstream before v4.0, or any released RHEL kernels). This patch fixes it. The problem is that: some old linux kernels (with IR enabled) only support IOAPIC chips with version 0x20. New kernels a

[Qemu-devel] [PULL 3/5] spapr: fix spapr-nvram migration

2016-07-25 Thread David Gibson
From: "lviv...@redhat.com" When spapr-nvram is backed by a file using pflash interface, migration fails on the destination guest with assert: bdrv_co_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed. This avoids the problem by delaying the pflash update until after the device loads co

[Qemu-devel] [PULL 5/5] spapr: disintricate core-id from DT semantics

2016-07-25 Thread David Gibson
From: Greg Kurz The goal of this patch is to have a stable core-id which does not depend on any DT related semantics, which involve non-obvious computations on modern PowerPC server cpus. With this patch, the DT core id is computed on-demand as: (core-id / smp_threads) * smt where smt i

[Qemu-devel] [PULL 0/5] ppc-for-2.7 queue 20160726

2016-07-25 Thread David Gibson
The following changes since commit 2d2e632ad00d11867c6c5625605b1fbc022dd62f: Update version for v2.7.0-rc0 release (2016-07-22 15:32:42 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.7-20160726 for you to fetch changes up to 12bf2d33fe520f9cf

[Qemu-devel] [PULL 2/5] hw/ppc/spapr: Make sure to close the htab_fd when migration is canceled

2016-07-25 Thread David Gibson
From: Thomas Huth When canceling a migration process, we currently do not close the HTAB migration file descriptor since htab_save_complete() is never called in that case. So we leave the migration process with a dangling htab_fd value around, and this causes any further migration attempts to fai

[Qemu-devel] [PULL 1/5] ppc: Huge page detection mechanism fixes - Episode III

2016-07-25 Thread David Gibson
From: Thomas Huth After already fixing two issues with the huge page detection mechanism (see commit 159d2e39a860 and 86b50f2e1bef), Greg Kurz noticed another case that caused the guest to crash where QEMU announces huge pages though they should not be available for the guest: qemu-system-ppc64

[Qemu-devel] [PULL 4/5] target-ppc: add PPC_MFTB flag to e500mc and e5500

2016-07-25 Thread David Gibson
From: Michael Walle According to the e500mc and e5500 core reference manual they have support for the mftb instruction. Signed-off-by: Michael Walle Signed-off-by: David Gibson --- target-ppc/translate_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-ppc/t

Re: [Qemu-devel] [PATCH] x86: ioapic: upgrade emulated IOAPIC to ver 0x20

2016-07-25 Thread Peter Xu
On Tue, Jul 26, 2016 at 05:15:58AM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 25, 2016 at 07:36:24PM +0800, Peter Xu wrote: > > IOMMU IR and IOAPIC legacy devices (e.g., e1000) cannot work well > > together with some old Linux kernels (upstream before v4.0, or any > > released RHEL kernels). Th

Re: [Qemu-devel] [PATCH v22 00/10] Block replication for continuous checkpoints

2016-07-25 Thread Changlong Xie
On 07/25/2016 10:34 PM, Stefan Hajnoczi wrote: On Mon, Jul 25, 2016 at 11:44:34AM +0800, Changlong Xie wrote: COLO block is the necessary prerequisite of COLO framework and COLO network, what are blocked by these patchsets now. Since v19, Stefan said he had reviewed most part of this patchsets.

Re: [Qemu-devel] [PATCH v2] mirror: double performance of the bulk stage if the disc is full

2016-07-25 Thread Jeff Cody
On Thu, Jul 14, 2016 at 08:19:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Mirror can do up to 16 in-flight requests, but actually on full copy > (the whole source disk is non-zero) in-flight is always 1. This happens > as the request is not limited in size: the data occupies maximum available

Re: [Qemu-devel] [PATCH v2] mirror: double performance of the bulk stage if the disc is full

2016-07-25 Thread Jeff Cody
On Thu, Jul 14, 2016 at 08:19:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Mirror can do up to 16 in-flight requests, but actually on full copy > (the whole source disk is non-zero) in-flight is always 1. This happens > as the request is not limited in size: the data occupies maximum available

Re: [Qemu-devel] [PATCH v22 10/10] support replication driver in blockdev-add

2016-07-25 Thread Changlong Xie
On 07/26/2016 07:00 AM, Max Reitz wrote: On 22.07.2016 12:16, Wang WeiWei wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake Signed-off-by: Wang WeiWei --- qapi/block-core.json |

Re: [Qemu-devel] [PATCH v2] hw/net/e1000e: Fix compiler warning

2016-07-25 Thread Jason Wang
On 2016年07月25日 13:47, Changlong Xie wrote: slave:~/.xie/qemu-colo # gcc --version gcc (SUSE Linux) 4.3.4 [gcc-4_3-branch revision 152973] slave:~/.xie/qemu-colo # make -j8 CChw/net/e1000e_core.o hw/net/e1000e_core.c:56: warning: ‘e1000e_set_interrupt_cause’ declared inline after being cal

Re: [Qemu-devel] [PATCH v2 0/2] vfio: add aer process

2016-07-25 Thread Zhou Jie
ping On 2016/7/19 16:13, Zhou Jie wrote: From: Chen Fan v1-v2: 1. Add aer process to vfio driver. Chen Fan (2): vfio : add aer process vfio : resume notifier drivers/vfio/pci/vfio_pci.c | 58 - drivers/vfio/pci/vfio_pci_intrs.c | 18 +

Re: [Qemu-devel] [PATCH] net: flush NetQueue before to send new packets

2016-07-25 Thread Jason Wang
On 2016年07月19日 22:33, Stefano Garzarella wrote: qemu_net_queue_send() and qemu_net_queue_send_iov() can flush enqueued packets before delivering a new packet, in this way the original packet ordering is preserved. Signed-off-by: Stefano Garzarella --- net/queue.c | 8 1 file chang

Re: [Qemu-devel] [PATCH] x86: ioapic: upgrade emulated IOAPIC to ver 0x20

2016-07-25 Thread Michael S. Tsirkin
On Mon, Jul 25, 2016 at 07:36:24PM +0800, Peter Xu wrote: > IOMMU IR and IOAPIC legacy devices (e.g., e1000) cannot work well > together with some old Linux kernels (upstream before v4.0, or any > released RHEL kernels). This patch fixes it. > > The problem is that: some old linux kernels (with IR

Re: [Qemu-devel] [PATCH v22 07/10] Introduce new APIs to do replication operation

2016-07-25 Thread Changlong Xie
On 07/26/2016 06:23 AM, Max Reitz wrote: +# @primary: Primary mode, the vm's state will be sent to secondary QEMU. >+# >+# @secondary: Secondary mode, receive the vm's state from primary QEMU. >+# >+# Since: 2.7 Probably 2.8 now. I'll update 2.7 to 2.8 for all these series Max

Re: [Qemu-devel] [PATCH v22 03/10] Backup: export interfaces for extra serialization

2016-07-25 Thread Changlong Xie
On 07/26/2016 05:50 AM, Max Reitz wrote: On 22.07.2016 12:16, Wang WeiWei wrote: From: Changlong Xie Normal backup(sync='none') workflow: step 1. NBD peformance I/O write from client to server qcow2_co_writev bdrv_co_writev ... bdrv_aligned_pwritev notifier_with

Re: [Qemu-devel] [PATCH v3 07/15] target-ppc: implement branch-less divw[o][.]

2016-07-25 Thread Nikunj A Dadhania
Richard Henderson writes: > On 07/25/2016 10:50 PM, Nikunj A Dadhania wrote: >> if (compute_ov) { >> -tcg_gen_movi_tl(cpu_ov, 1); >> -tcg_gen_movi_tl(cpu_so, 1); >> +tcg_gen_extu_i32_tl(cpu_ov, t2); >> +tcg_gen_extu_i32_tl(cpu_so, t2); >> } > > This shoul

[Qemu-devel] [RFC PATCH V10 5/7] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-07-25 Thread Zhang Chen
Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Cc: Daniel P . Berrange Cc: Paolo Bonzini Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Cong

[Qemu-devel] [RFC PATCH V10 4/7] colo-compare: track connection and enqueue packet

2016-07-25 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+ +-

[Qemu-devel] [RFC PATCH V10 6/7] colo-compare: introduce packet comparison thread

2016-07-25 Thread Zhang Chen
If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes and secondary packet not, after REGULAR_PACKET_CHECK_MS milliseconds we set the primary packet as old_packet,then do a checkp

[Qemu-devel] [RFC PATCH V10 1/7] colo-compare: introduce colo compare initialization

2016-07-25 Thread Zhang Chen
This a COLO net ascii figure: Primary qemu Secondary qemu +--+ ++ | +--

[Qemu-devel] [RFC PATCH V10 7/7] colo-compare: add TCP, UDP, ICMP packet comparison

2016-07-25 Thread Zhang Chen
We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. less checkpoint more efficiency. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 174 +++

[Qemu-devel] [RFC PATCH V10 3/7] Jhash: add linux kernel jhashtable in qemu

2016-07-25 Thread Zhang Chen
Jhash used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/qemu/jhash.h | 61 1 file changed, 61 insertions(+) create mod

[Qemu-devel] [RFC PATCH V10 2/7] colo-base: add colo-base to define and handle packet

2016-07-25 Thread Zhang Chen
COLO-base used by colo-compare and filter-rewriter. this can share common data structure like:net packet, and share other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/Makefile.objs | 1 + net/colo-base.c| 74

[Qemu-devel] [RFC PATCH V10 0/7] Introduce COLO-compare

2016-07-25 Thread Zhang Chen
COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. The full version in this github: https://github.com/zhangckid/qemu/tree/colo-v2.7-proxy-mode-compare-with-colo-base-jul22 v10: - fix typo - Should we make patch 5 in

Re: [Qemu-devel] Fw:qemu driver_mirror error "Operation not permitted"

2016-07-25 Thread lisiheng
ps -aux | grep qemuroot 6184 20.7 1.7 742476 106584 ? Sl 09:36 0:04 /usr/local/qemu-2.5.0-20160720/bin/qemu-system-x86_64 -name i-745F35DC -S -machine pc-i440fx-2.5,accel=kvm,usb=off -cpu Westmere,+invpcid,+erms,+bmi2,+smep,+avx2,+bmi1,+fsgsbase,+abm,+rdtscp,+pdpe1gb,+rdrand,+f16

Re: [Qemu-devel] [RFC 1/2] spapr: Reverse order of hotpluggable cpus list

2016-07-25 Thread David Gibson
On Mon, Jul 25, 2016 at 10:14:18AM +0200, Igor Mammedov wrote: > On Mon, 25 Jul 2016 16:09:04 +1000 > David Gibson wrote: > > > On Wed, Jul 20, 2016 at 09:01:11AM +0200, Peter Krempa wrote: > > > On Wed, Jul 20, 2016 at 11:00:05 +1000, David Gibson wrote: > > > > On Tue, Jul 19, 2016 at 01:52:4

Re: [Qemu-devel] [PATCH] tcg: Merge GETPC and GETRA

2016-07-25 Thread Benjamin Herrenschmidt
On Tue, 2016-07-26 at 06:12 +0530, Richard Henderson wrote: > The return address argument to the softmmu template helpers was > confused.  In the legacy case, we wanted to indicate that there > is no return address, and so passed in NULL.  However, we then > immediately subtracted GETPC_ADJ from NU

Re: [Qemu-devel] [PATCH v2 0/2] Drop some useless functions

2016-07-25 Thread Cao jin
Sorry to forgot the v2 changelog: 1, squash two patches into one, and update commit message as Paolo & Eric suggest. 2. Drop another function that is not used On 07/25/2016 09:02 PM, Cao jin wrote: These functions are not used anymore, drop them first. Next step is to rip out NonBlockingConne

Re: [Qemu-devel] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint

2016-07-25 Thread Changlong Xie
On 07/26/2016 05:18 AM, Max Reitz wrote: On 22.07.2016 12:15, Wang WeiWei wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- block/backup.c | 18 +

[Qemu-devel] [PATCH] tcg: Merge GETPC and GETRA

2016-07-25 Thread Richard Henderson
The return address argument to the softmmu template helpers was confused. In the legacy case, we wanted to indicate that there is no return address, and so passed in NULL. However, we then immediately subtracted GETPC_ADJ from NULL, resulting in a non-zero value, indicating the presence of an (in

[Qemu-devel] [PATCH v2 1/6] cadence_gem: QOMify Cadence GEM

2016-07-25 Thread Alistair Francis
The sysbus_init_irq() call will eventually depend on a property so it needs to be in the realize function. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- V2: - Update commit message hw/net/cadence_gem.c | 28 +--- 1 file changed, 17 insertions(+), 11 de

Re: [Qemu-devel] [PATCH v3 07/15] target-ppc: implement branch-less divw[o][.]

2016-07-25 Thread Richard Henderson
On 07/25/2016 10:50 PM, Nikunj A Dadhania wrote: if (compute_ov) { -tcg_gen_movi_tl(cpu_ov, 1); -tcg_gen_movi_tl(cpu_so, 1); +tcg_gen_extu_i32_tl(cpu_ov, t2); +tcg_gen_extu_i32_tl(cpu_so, t2); } This should be tcg_gen_extu_i32_tl(cpu_ov, t2); tcg_g

Re: [Qemu-devel] [PULL 4/7] scripts: refactor the VM class in iotests for reuse

2016-07-25 Thread Max Reitz
On 22.07.2016 10:00, Amit Shah wrote: > From: "Daniel P. Berrange" > > The iotests module has a python class for controlling QEMU > processes. Pull the generic functionality out of this file > and create a scripts/qemu.py module containing a QEMUMachine > class. Put the QTest integration support

[Qemu-devel] [PATCH v2 6/6] xlnx-zynqmp: Set the number of priority queues

2016-07-25 Thread Alistair Francis
Set the ZynqMP number of priority queues to 2. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- hw/arm/xlnx-zynqmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 23c7199..0d86ba3 100644 --- a/hw/arm/xlnx-zynqmp.c +++ b/hw

Re: [Qemu-devel] [PATCH v3 06/15] target-ppc: add modulo dword operations

2016-07-25 Thread Richard Henderson
On 07/25/2016 10:50 PM, Nikunj A Dadhania wrote: Adding following instructions for ISA3.0 support modud: Modulo Unsigned Dword modsd: Modulo Signed Dword Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 48 1 file changed, 48 inser

[Qemu-devel] [PATCH v2 5/6] cadence_gem: Correct indentation

2016-07-25 Thread Alistair Francis
Fix up the indentation inside the for loop that was introduced in the previous patch. This commit is almost empty if viewed using 'git show -w', except for a few changes that were required to avoid the 80 charecter line limit. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- V2: -

[Qemu-devel] [PATCH v2 4/6] cadence_gem: Add queue support

2016-07-25 Thread Alistair Francis
Signed-off-by: Alistair Francis --- There is a indentation error in this patch in the gem_transmit function. I have written it like that to make it easier to see the changes. It is fixed in the next patch. V2: - Use the new screening function - Update interrupt generation - Increase vmstate t

[Qemu-devel] [PATCH v2 0/6] Add support for Cadence GEM priority queues

2016-07-25 Thread Alistair Francis
This patch series adds initial priority queue support to the Cadence GEM device. This is based on original work by Peter C, that has been ported to the latest version of QEMU. There is more GEM work that I'd like to upstream after this, but I figured this a good place to start. I have done limite

[Qemu-devel] [PATCH v2 3/6] cadence_gem: Add support for screening

2016-07-25 Thread Alistair Francis
The Cadence GEM hardware allows incoming data to be 'screened' based on some register values. Add support for these screens. Signed-off-by: Alistair Francis --- V2: - Initial commit hw/net/cadence_gem.c | 151 +++ include/hw/net/cadence_gem.h |

[Qemu-devel] [PATCH v2 2/6] cadence_gem: Add the num-priority-queues property

2016-07-25 Thread Alistair Francis
The Cadence GEM hardware supports N number priority queues, this patch is a step towards that by adding the property to set the queues. At the moment behaviour doesn't change as we only use queue 0. Signed-off-by: Alistair Francis --- V2: - Fixup commit message - Add the property in this patch

Re: [Qemu-devel] [PATCH v3 05/15] target-ppc: add modulo word operations

2016-07-25 Thread Richard Henderson
On 07/25/2016 10:50 PM, Nikunj A Dadhania wrote: Adding following instructions: moduw: Modulo Unsigned Word modsw: Modulo Signed Word Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 48 1 file changed, 48 insertions(+) Reviewed-

Re: [Qemu-devel] [PULL 4/7] scripts: refactor the VM class in iotests for reuse

2016-07-25 Thread Max Reitz
On 22.07.2016 10:00, Amit Shah wrote: > From: "Daniel P. Berrange" > > The iotests module has a python class for controlling QEMU > processes. Pull the generic functionality out of this file > and create a scripts/qemu.py module containing a QEMUMachine > class. Put the QTest integration support

Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?

2016-07-25 Thread Benjamin Herrenschmidt
On Tue, 2016-07-26 at 08:42 +1000, Benjamin Herrenschmidt wrote: > We do something a bit different on ppc where we store the access type > before every access, however the DSISR case is special in that on > older > CPUs, it's expected to contains a whole subset of the opcode which is > quite a bit

Re: [Qemu-devel] [PATCH v22 00/10] Block replication for continuous checkpoints

2016-07-25 Thread Max Reitz
On 25.07.2016 16:34, Stefan Hajnoczi wrote: > On Mon, Jul 25, 2016 at 11:44:34AM +0800, Changlong Xie wrote: >> COLO block is the necessary prerequisite of COLO framework and COLO network, >> what are blocked by these patchsets now. >> >> Since v19, Stefan said he had reviewed most part of this pat

Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?

2016-07-25 Thread Benjamin Herrenschmidt
On Mon, 2016-07-25 at 23:19 +0100, Peter Maydell wrote: > > For example we have one in powerpc_excp() to read the faulting > > instruction, though that *should* never fail it's till not great. > > Mmm. Strictly speaking you can't guarantee that that load will > work, because the code you're execut

Re: [Qemu-devel] [PATCH v1 3/5] cadence_gem: Add queue support

2016-07-25 Thread Alistair Francis
On Mon, Jul 25, 2016 at 8:46 AM, Peter Maydell wrote: > On 12 July 2016 at 00:20, Alistair Francis > wrote: >> Signed-off-by: Alistair Francis >> --- >> >> There is a indentation error in this patch in the gem_transmit function. >> I have written it like that to make it easier to see the change

Re: [Qemu-devel] [PATCH v22 10/10] support replication driver in blockdev-add

2016-07-25 Thread Max Reitz
On 22.07.2016 12:16, Wang WeiWei wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie > Reviewed-by: Eric Blake > Signed-off-by: Wang WeiWei > --- > qapi/block-core.json | 19 +-- >

Re: [Qemu-devel] ppc: TCG and FP exceptions, is it right ?

2016-07-25 Thread Benjamin Herrenschmidt
On Mon, 2016-07-25 at 17:12 +0200, Tristan Gingold wrote: > > > > The code as writte will take the exception before the FPR is > > updated, > > I *think*, or am I missing something here  ? > > This looks like an oversight. In our tests, we don't read the fpr. BTW. Do you happen to have some test

Re: [Qemu-devel] [PATCH v22 07/10] Introduce new APIs to do replication operation

2016-07-25 Thread Max Reitz
On 22.07.2016 12:16, Wang WeiWei wrote: > From: Changlong Xie > > This commit introduces six replication interfaces(for block, network etc). > Firstly we can use replication_(new/remove) to create/destroy replication > instances, then in migration we can use replication_(start/stop/do_checkpoint

Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?

2016-07-25 Thread Peter Maydell
On 25 July 2016 at 22:42, Benjamin Herrenschmidt wrote: > On Mon, 2016-07-25 at 19:30 +0530, Richard Henderson wrote: >> > Or can they also be called outside of that context ? >> >> No, not without a valid return address. >> >> E.g. it's not valid to have one helper call another, and for the secon

Re: [Qemu-devel] [PATCH v22 03/10] Backup: export interfaces for extra serialization

2016-07-25 Thread Max Reitz
On 22.07.2016 12:16, Wang WeiWei wrote: > From: Changlong Xie > > Normal backup(sync='none') workflow: > step 1. NBD peformance I/O write from client to server >qcow2_co_writev > bdrv_co_writev > ... >bdrv_aligned_pwritev > notifier_with_return_list_notify -> backup_d

Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?

2016-07-25 Thread Benjamin Herrenschmidt
On Mon, 2016-07-25 at 19:42 +0530, Richard Henderson wrote: > For some targets, we also restore part of the flags computation with this  > mechanism.  With more trickery, ARM is (intending to?) compute exception  > syndrome information with this.  As I understand it, this is very much akin > to  >

Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?

2016-07-25 Thread Benjamin Herrenschmidt
On Mon, 2016-07-25 at 19:30 +0530, Richard Henderson wrote: > > Or can they also be called outside of that context ? > > No, not without a valid return address. > > E.g. it's not valid to have one helper call another, and for the second > helper  > use GETPC.  For this, typically, one must facto

Re: [Qemu-devel] ppc: TCG and FP exceptions, is it right ?

2016-07-25 Thread Benjamin Herrenschmidt
On Mon, 2016-07-25 at 19:05 +0530, Richard Henderson wrote: > > An additional note is that if FE0/FE1 are 0, we still in some case > > leave an exception behind in cs->exception_index. Now, I *think* > > that's ok, it will just be silently dropped at some point, but I am not > > 100% certain as tha

Re: [Qemu-devel] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint

2016-07-25 Thread Max Reitz
On 22.07.2016 12:15, Wang WeiWei wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > --- > block/backup.c | 18 ++ > include/block/bloc

Re: [Qemu-devel] [PATCH v12 3/9] target-avr: adding a sample AVR board

2016-07-25 Thread Peter Maydell
On 25 July 2016 at 21:56, Michael Rolnik wrote: > do you mean that I should remove the board and/or device? I use them for > testing. You should remove the device, because it's not doing anything. If that makes the CPU emulation stop working that's a problem with the CPU emulation that needs to b

Re: [Qemu-devel] [PATCH v12 3/9] target-avr: adding a sample AVR board

2016-07-25 Thread Michael Rolnik
do you mean that I should remove the board and/or device? I use them for testing. *char const** and *const char** are the same. On Mon, Jul 25, 2016 at 9:50 PM, Peter Maydell wrote: > On 24 July 2016 at 01:02, Michael Rolnik wrote: > > Signed-off-by: Michael Rolnik > > --- > > MAINTAINERS

Re: [Qemu-devel] [PATCH v5 0/3] Dynamic module loading for block drivers

2016-07-25 Thread Max Reitz
On 25.07.2016 15:56, Colin Lord wrote: > On 07/23/2016 02:21 PM, Max Reitz wrote: >> On 20.07.2016 16:30, Colin Lord wrote: >>> Here's v5 of the modularization series. Since it seems the concensus is >>> that modularizing the format drivers is unnecessary, this series no >>> longer modularizes thos

Re: [Qemu-devel] [PATCH v3 9/9] tcg: Lower indirect registers in a separate pass

2016-07-25 Thread Aurelien Jarno
On 2016-06-23 20:48, Richard Henderson wrote: > Rather than rely on recursion during the middle of register allocation, > lower indirect registers to loads and stores off the indirect base into > plain temps. > > For an x86_64 host, with sufficient registers, this results in identical > code, modu

[Qemu-devel] [PATCH v2] Unbreak FreeBSD build after optionrom update.

2016-07-25 Thread Sean Bruno
Update the build flags appropriately for FreeBSD and add the correct LD_EMULATION type for the FreeBSD build case. Signed-off-by: Sean Bruno --- pc-bios/optionrom/Makefile | 8 1 file changed, 8 insertions(+) diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile index d8

[Qemu-devel] [PULL for-2.7 3/3] configure: mark qemu-ga VSS includes as system headers

2016-07-25 Thread Michael Roth
As of e4650c81, we do w32 builds with -Werror enabled. Unfortunately for cases where we enable VSS support in qemu-ga, we still have warnings generated by VSS includes that ship as part of the Microsoft VSS SDK. We can selectively address a number of these warnings using #pragma GCC diagnostic

[Qemu-devel] [PULL for-2.7 0/3] qemu-ga patch queue for 2.7

2016-07-25 Thread Michael Roth
The following changes since commit 2d2e632ad00d11867c6c5625605b1fbc022dd62f: Update version for v2.7.0-rc0 release (2016-07-22 15:32:42 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2016-07-25-tag for you to fetch changes up to 690604f696db6b3

[Qemu-devel] [PULL for-2.7 2/3] tests: use static qga config file

2016-07-25 Thread Michael Roth
From: Marc-André Lureau Do not create a leaking temporary file, but use a static file instead. Signed-off-by: Marc-André Lureau Reported-by: Peter Maydell Signed-off-by: Michael Roth --- tests/data/test-qga-config | 8 tests/test-qga.c | 27 --- 2

[Qemu-devel] [PULL for-2.7 1/3] build-sys: link tests/data

2016-07-25 Thread Michael Roth
From: Marc-André Lureau Link a common tests data directory to the build directory. Signed-off-by: Marc-André Lureau Signed-off-by: Michael Roth --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 6ffa4a8..61279b0 100755 --- a/configure +++ b/conf

Re: [Qemu-devel] [PATCH] Unbreak build after optionrom update.

2016-07-25 Thread Sean Bruno
On 07/25/16 12:53, Peter Maydell wrote: > On 25 July 2016 at 18:57, Sean Bruno wrote: >> Update the build flags appropriately for FreeBSD and add the correct >> LD_EMULATION type for the FreeBSD build case. >> >> Signed-off-by: Sean Bruno >> --- >> pc-bios/optionrom/Makefile | 8 +++- >> 1

Re: [Qemu-devel] [PATCH for-2.7] fix qemu exit on memory hotplug when allocation fails at prealloc time

2016-07-25 Thread Eduardo Habkost
On Thu, Jul 21, 2016 at 11:00:46AM -0400, Paolo Bonzini wrote: > > > > On 21/07/2016 10:36, Markus Armbruster wrote: > > > > ... have the obvious error_propagate() + return here. Matter of taste, > > > > between you and the maintainer. Except there is none. Inexcusable for > > > > a file create

Re: [Qemu-devel] [PATCH] Unbreak build after optionrom update.

2016-07-25 Thread Peter Maydell
On 25 July 2016 at 18:57, Sean Bruno wrote: > Update the build flags appropriately for FreeBSD and add the correct > LD_EMULATION type for the FreeBSD build case. > > Signed-off-by: Sean Bruno > --- > pc-bios/optionrom/Makefile | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > d

Re: [Qemu-devel] [PATCH v12 3/9] target-avr: adding a sample AVR board

2016-07-25 Thread Peter Maydell
On 24 July 2016 at 01:02, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > --- > MAINTAINERS | 6 ++ > hw/avr/Makefile.objs | 21 ++ > hw/avr/sample-io.c | 176 > +++ > hw/avr/sample.c | 137 ++

Re: [Qemu-devel] [PATCH v12 2/9] target-avr: adding AVR CPU features/flavors

2016-07-25 Thread Peter Maydell
On 24 July 2016 at 01:02, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > --- > target-avr/cpu.c | 313 > ++- > target-avr/cpu.h | 48 > target-avr/machine.c | 1 + > 3 files changed, 361 insertions(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH v12 1/9] target-avr: AVR cores support is added.

2016-07-25 Thread Peter Maydell
On 24 July 2016 at 01:02, Michael Rolnik wrote: > 1. basic CPU structure > 2. registers > 3. no instructions > 4. saving sreg, rampD, rampX, rampY, rampD, eind in HW representation > > Signed-off-by: Michael Rolnik > --- > arch_init.c | 2 + > configure

[Qemu-devel] [PATCH] Unbreak build after optionrom update.

2016-07-25 Thread Sean Bruno
Update the build flags appropriately for FreeBSD and add the correct LD_EMULATION type for the FreeBSD build case. Signed-off-by: Sean Bruno --- pc-bios/optionrom/Makefile | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Ma

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

2016-07-25 Thread luigiburdo
Hi T, found! this was last bad a select git bisect bad Bisecting: 101 revisions left to test after this (roughly 7 steps) [f68419eee9a966f5a915314c43cda6778f976a77] Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging this is the good git bisect good Bisecting: 58 revis

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

2016-07-25 Thread luigiburdo
but what i see in this working there isnt your sdl2 patch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1603636 Title: Guest has not initialized the display yet on ubuntu 16.10 PPC Status in QEMU

[Qemu-devel] [PATCH v3 15/15] target-ppc: introduce opc4 for Expanded Opcode

2016-07-25 Thread Nikunj A Dadhania
ISA 3.0 has introduced EO - Expanded Opcode. Introduce third level indirect opcode table and corresponding parsing routines. EO (11:12) Expanded opcode field Formats: XX1 EO (11:15) Expanded opcode field Formats: VX, X, XX2 Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 82

  1   2   3   >