[Qemu-devel] [PATCH v1 7/8] target-ppc: add vsrv instruction

From: Vivek Andrew Sha Adds Vector Shift Right Variable instruction. Signed-off-by: Vivek Andrew Sha [ reverse the order of computation to avoid temporary array ] Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 17

[Qemu-devel] [PATCH v1 6/8] target-ppc: add vslv instruction

From: Vivek Andrew Sha vslv: Vector Shift Left Variable Signed-off-by: Vivek Andrew Sha Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 14 ++ target-ppc/translate/vmx-impl.c | 1 + target-p

[Qemu-devel] [PATCH v1 2/8] target-ppc: implement branch-less divd[o][.]

Similar to divw, implement branch-less divd. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 2a5ce3f..82349ed 1

[Qemu-devel] [PATCH v1 3/8] target-ppc: add dtstsfi[q] instructions

From: Sandipan Das DFP Test Significance Immediate [Quad] Signed-off-by: Sandipan Das Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson --- target-ppc/dfp_helper.c | 35 +++ target-ppc/helper.h | 2 ++ target-ppc/translate/dfp-imp

[Qemu-devel] [PATCH v1 5/8] target-ppc: add vcmpnez[b, h, w][.] instructions

From: Swapnil Bokade Adds following instructions: vcmpnezb[.]: Vector Compare Not Equal or Zero Byte vcmpnezh[.]: Vector Compare Not Equal or Zero Halfword vcmpnezw[.]: Vector Compare Not Equal or Zero Word Signed-off-by: Swapnil Bokade [ collapse switch case ] Signed-off-by: Nikunj A Dadhania

[Qemu-devel] [PATCH v1 0/8] POWER9 TCG enablements - part2

This series contains 11 new instructions for POWER9 described in ISA3.0. Patches: 01-02: Changes following instructions: divd[u][o][.]: Divide Doubleword Signed/Unsigned divw[u][o][.]: Divide Word Signed/Unsigned 03: dtstsfi[q]: DFP Test Significance Immediate [Quad] 04: vabs

[Qemu-devel] [PATCH v1 4/8] target-ppc: add vabsdu[b, h, w] instructions

From: Sandipan Das Adds following instructions: vabsdub: Vector Absolute Difference Unsigned Byte vabsduh: Vector Absolute Difference Unsigned Halfword vabsduw: Vector Absolute Difference Unsigned Word Signed-off-by: Sandipan Das [ use ISA300 define and abs(). Drop etype ] Signed-off-by: Nikun

Re: [Qemu-devel] [PATCH for-2.7 v5 0/2] vhost-user: Extend protocol to receive replies on any command.

Pl ignore the above series, sending a new revision. On Thu, Jul 28, 2016 at 11:52 AM, Prerna Saxena wrote: > From: Prerna Saxena > > > vhost-user: Extend protocol to receive replies on any command. > > The current vhost-user protocol requires the client to send reply to only a > few commands. F

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process

> > > This ends up doing a 1MB kmalloc() right? That seems a _bit_ big. > > > How big was the pfn buffer before? > > > > Yes, it is if the max pfn is more than 32GB. > > The size of the pfn buffer use before is 256*4 = 1024 Bytes, it's too > > small, and it's the main reason for bad performance. >

Re: [Qemu-devel] [PATCH] ppc: Add MacOS VGA driver ROM

On Wed, Jul 27, 2016 at 06:27:33PM +1000, Benjamin Herrenschmidt wrote: > The project is at https://github.com/ozbenh/QemuMacDrivers > > This adds a native MacOS driver in ROM (which can be picked up > by MacOS once OpenBIOS has been updated if Mark accepts > the patches I sent him) which allows M

Re: [Qemu-devel] [PATCH v2 7/6] exec: ensure the only one cpu_index allocation method is used

On Wed, Jul 27, 2016 at 11:24:54AM +0200, Igor Mammedov wrote: > Make sure that cpu_index auto allocation isn't used in > combination with manual cpu_index assignment. And > dissallow out of order cpu removal if auto allocation > is in use. > > Target that wishes to support out of order unplug sho

Re: [Qemu-devel] [PATCH v4 1/2] vhost-user: Introduce a new protocol feature REPLY_ACK.

On 27/07/16 6:58 pm, "Michael S. Tsirkin" wrote: >On Wed, Jul 27, 2016 at 12:56:18PM +, Prerna Saxena wrote: >> Hi Marc, >> Thanks, please find my reply inline. >> >> >> >> >> >> On 27/07/16 4:35 pm, "Marc-André Lureau" wrote: >> >> >Hi >> > >> >On Wed, Jul 27, 2016 at 1:52 PM, Pr

[Qemu-devel] [PATCH for-2.7 v5 1/2] vhost-user: Introduce a new protocol feature REPLY_ACK.

From: Prerna Saxena This introduces the VHOST_USER_PROTOCOL_F_REPLY_ACK. If negotiated, client applications should send a u64 payload in response to any message that contains the "need_reply" bit set on the message flags. Setting the payload to "zero" indicates the command finished successfully.

[Qemu-devel] [PATCH for-2.7 v5 0/2] vhost-user: Extend protocol to receive replies on any command.

From: Prerna Saxena vhost-user: Extend protocol to receive replies on any command. The current vhost-user protocol requires the client to send reply to only a few commands. For the remaining commands, it is impossible for QEMU to know the status of the requested operation -- ie, did it succeed?

[Qemu-devel] [PATCH for-2.7 v5 2/2] vhost-user: Attempt to fix a race with set_mem_table.

From: Prerna Saxena The set_mem_table command currently does not seek a reply. Hence, there is no easy way for a remote application to notify to QEMU when it finished setting up memory, or if there were errors doing so. As an example: (1) Qemu sends a SET_MEM_TABLE to the backend (eg, a vhost-us

Re: [Qemu-devel] [PATCH RFC v0 0/6] POWER9 TCG enablements - part2

David Gibson writes: > [ Unknown signature status ] > On Wed, Jul 27, 2016 at 12:56:52AM +0530, Nikunj A Dadhania wrote: >> This series contains 11 new instructions for POWER9 described in ISA3.0. >> >> Patches: >> 01: dtstsfi[q]: DFP Test Significance Immediate [Quad] >> 02: vabsdub

Re: [Qemu-devel] [PATCH RFC v0 0/6] POWER9 TCG enablements - part2

On Wed, Jul 27, 2016 at 12:56:52AM +0530, Nikunj A Dadhania wrote: > This series contains 11 new instructions for POWER9 described in ISA3.0. > > Patches: > 01: dtstsfi[q]: DFP Test Significance Immediate [Quad] > 02: vabsdub : Vector Absolute Difference Unsigned Byte > vabsduh

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

On Thu, Jul 28, 2016 at 03:02:54AM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 28, 2016 at 12:08:30AM +0900, Namhyung Kim wrote: > > Add virtio pstore device to allow kernel log files saved on the host. > > It will save the log files on the directory given by pstore device > > option. > > > >

[Qemu-devel] Read DMA command (0xC8)

Hello everyone, A little background if I may. I have been doing OS development for some time and even started with QEMU way back when. Shortly after I started, though, I found Bochs and found it to be more to my liking. I went on to submit many improvements to Bochs including the initial USB

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 repost 6/7] mm: add the related functions to get free page info

> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7da61ad..3ad8b10 > > 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -4523,6 +4523,52 @@ unsigned long get_max_pfn(void) } > > EXPORT_SYMBOL(get_max_pfn); > > > > +static void mark_free_pages_bitmap(struct zone *zone, unsig

Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification

On Thursday, July 28, 2016 10:51 AM Gonglei (Arei) Wrote: > > > Changes from v4: > > > - introduce crypto services into virtio crypto device. The services > > >currently defined are CIPHER, MAC, HASH, AEAD, KDF, ASYM, > > PRIMITIVE. > > > - define a unified crypto request format that is cons

Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize

On Wed, 07/27 19:23, Colin Lord wrote: > On 07/27/2016 02:26 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > Makefile.objs | 1 + > > configure | 4 +-- > > include/qemu/module.h | 2 ++ > > include/ui/console.h | 5 ++-- > > ui/Makefile.objs | 2 ++ >

Re: [Qemu-devel] [PATCH 6/6] arm: add support for an ast2500 evaluation board

On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- >  hw/arm/palmetto-bmc.c| 32 +++- >  include/hw/arm/ast2400.h |  5 + >  2 files changed, 36 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/palmetto-bmc.c b/

Re: [Qemu-devel] [PATCH 2/6] palmetto-bmc: replace palmetto_bmc with aspeed

On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: > This is mostly a name replacement to prepare ground for other socs > specificities. It also adds a specific TypeInfo struct for the > palmetto_bmc board with a custom initialization for the same reason. I think we should rename the file,

Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info

> On 07/27/2016 03:05 PM, Michael S. Tsirkin wrote: > > On Wed, Jul 27, 2016 at 09:40:56AM -0700, Dave Hansen wrote: > >> On 07/26/2016 06:23 PM, Liang Li wrote: > >>> + for_each_migratetype_order(order, t) { > >>> + list_for_each(curr, &zone->free_area[order].free_list[t]) { > >>> +

Re: [Qemu-devel] [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process

> > +/* > > + * VIRTIO_BALLOON_PFNS_LIMIT is used to limit the size of page bitmap > > + * to prevent a very large page bitmap, there are two reasons for this: > > + * 1) to save memory. > > + * 2) allocate a large bitmap may fail. > > + * > > + * The actual limit of pfn is determined by: > > + * p

Re: [Qemu-devel] [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process

> Subject: Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate > process > > On Wed, Jul 27, 2016 at 09:03:21AM -0700, Dave Hansen wrote: > > On 07/26/2016 06:23 PM, Liang Li wrote: > > > + vb->pfn_limit = VIRTIO_BALLOON_PFNS_LIMIT; > > > + vb->pfn_limit = min(vb->pfn_limit, get_max

Re: [Qemu-devel] [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process

> > + * VIRTIO_BALLOON_PFNS_LIMIT is used to limit the size of page bitmap > > + * to prevent a very large page bitmap, there are two reasons for this: > > + * 1) to save memory. > > + * 2) allocate a large bitmap may fail. > > + * > > + * The actual limit of pfn is determined by: > > + * pfn_limit

Re: [Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin

hello bruce, AFAIK, the message in error object will be printed to stderr or current monitor according whether we have a monitor. I just checked XEN_PT_LOG, message is only printed to stderr. If Xen pt device can be hotplugged via monitor command device_add, I guess using error object is right

Re: [Qemu-devel] [PATCH 5/6] aspeed: add ast2500 support to scu and sdmc controllers

On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: > Based on previous work done by Andrew Jeffery . > > Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery > --- >  hw/misc/aspeed_scu.c | 45 > +++- >  hw/misc/aspeed_sdmc.c  

Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification

Hi Michael, Thanks for your rapid feedback ! > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, July 28, 2016 6:37 AM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org; Ola Liljedahl; > Keating Brian; Zeng Xin; Hanwei

Re: [Qemu-devel] [RFC/PATCHSET 0/7] virtio: Implement virtio pstore device (v2)

Hello, On Thu, Jul 28, 2016 at 01:18:42AM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 28, 2016 at 12:08:24AM +0900, Namhyung Kim wrote: > > Hello, > > > > This is v2 of the virtio-pstore work. In this patchset I addressed > > most of feedbacks from previous version. Limiting disk size is not

Re: [Qemu-devel] [PATCH 4/6] palmetto-bmc: add board specific configuration

On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: > aspeed_init() now uses a board identifier to customize some values > specific to the board, ram base, board revision number, etc. > > Signed-off-by: Cédric Le Goater Looks okay to me, some minor comments below: > --- >  hw/arm/palmett

Re: [Qemu-devel] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard

On 07/27/2016 01:25 AM, Fam Zheng wrote: > On Thu, 07/21 13:34, Eric Blake wrote: >> +max_write_zeroes = max_write_zeroes / alignment * alignment; > > Not using QEMU_ALIGN_DOWN despite patch 3? Looks like I missed that on the rebase. Can fix if there is a reason for a respin. -- Eric Blake

Re: [Qemu-devel] [PATCH 3/6] ast2400: use machine cpu_model to initialize the soc cpu

On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: > It will be easier to specify a different cpu for other soc derived > from the ast2400 soc. > > Signed-off-by: Cédric Le Goater > --- >  hw/arm/ast2400.c  | 8 +++- >  hw/arm/palmetto-bmc.c | 1 + >  2 files changed, 8 insertions(+

Re: [Qemu-devel] [PATCH qemu] kvm-irqchip: Only do explicit IRQ routing commit when IRQCHIP is in use

On 27/07/16 23:32, Peter Xu wrote: > On Wed, Jul 27, 2016 at 09:29:07PM +0800, Peter Xu wrote: > > [...] > >>> This works too. >>> >>> You may also want to copy if(!kvm_gsi_routing_enabled()) from >>> kvm_irqchip_add_msi_route() to align API (not needed in my case though). Or >>> just check the r

Re: [Qemu-devel] [PATCH 1/6] palmetto-bmc: add a "silicon-rev" property at the soc level

On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: > The SCU controler holds the board revision number in its 0x7C > register. Let's use an alias to link a "silicon-rev" property of the > soc to the "silicon-rev" property of the SCU controler. > > The SDMC controler "silicon-rev" property

Re: [Qemu-devel] [RFC PATCH V3 3/3] filter-rewriter: rewrite tcp packet to keep secondary connection

On 2016年07月27日 17:05, Zhang Chen wrote: +if (((tcp_pkt->th_flags & (TH_ACK | TH_SYN)) == TH_ACK)) { +if (conn->syn_flag) { +/* offset = secondary_seq - primary seq */ +conn->offset -= (ntohl(tcp_pkt->th_ack) - 1); The code here is conflict with your comment

Re: [Qemu-devel] [PATCHv2 11/31] ppc: FP exceptions are always precise

On Wed, Jul 27, 2016 at 07:44:26PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2016-07-27 at 17:21 +1000, David Gibson wrote: > > On Wed, Jul 27, 2016 at 04:56:29PM +1000, Benjamin Herrenschmidt > > wrote: > > > > > > We don't implement imprecise FP exceptions and using store_current > > > whic

Re: [Qemu-devel] [RFC PATCH V3 0/3] filter-rewriter: introduce filter-rewriter

On 2016年07月27日 15:52, Zhang Chen wrote: On 07/27/2016 03:05 PM, Jason Wang wrote: On 2016年07月27日 13:49, Zhang Chen wrote: On 07/27/2016 10:50 AM, Jason Wang wrote: On 2016年07月27日 10:32, Zhang Chen wrote: Hi~ all~~ Anyone have some comments for this series? Will have a look at thi

Re: [Qemu-devel] [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process

On Thu, Jul 28, 2016 at 01:13:35AM +, Li, Liang Z wrote: > > Subject: Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate > > process > > > > On 07/26/2016 06:23 PM, Liang Li wrote: > > > + vb->pfn_limit = VIRTIO_BALLOON_PFNS_LIMIT; > > > + vb->pfn_limit = min(vb->pfn_limit, get

Re: [Qemu-devel] ext4 error when testing virtio-scsi & vhost-scsi

Hi, Jan On Wed, Jul 27, 2016 at 11:56 PM, Jan Kara wrote: > Hi! > > On Wed 27-07-16 15:58:55, Zhangfei Gao wrote: >> Hi, Michael >> >> I have met ext4 error when using vhost_scsi on arm64 platform, and >> suspect it is vhost_scsi issue. >> >> Ext4 error when testing virtio_scsi & vhost_scsi >> >>

Re: [Qemu-devel] [PATCH v2 2/2] util: Drop inet_listen()

On 07/27/2016 07:36 PM, Daniel P. Berrange wrote: On Mon, Jul 25, 2016 at 09:02:51PM +0800, Cao jin wrote: Since commit e65c67e4, inet_listen() is not used anymore, and all inet listen operation goes through QIOChannel. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Cc: Eric Bl

Re: [Qemu-devel] [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process

> Subject: Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate > process > > On 07/26/2016 06:23 PM, Liang Li wrote: > > + vb->pfn_limit = VIRTIO_BALLOON_PFNS_LIMIT; > > + vb->pfn_limit = min(vb->pfn_limit, get_max_pfn()); > > + vb->bmap_len = ALIGN(vb->pfn_limit, BITS_PER_LON

Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info

On Thu, Jul 28, 2016 at 12:10:16AM +, Li, Liang Z wrote: > > Subject: Re: [PATCH v2 repost 6/7] mm: add the related functions to get free > > page info > > > > On 07/26/2016 06:23 PM, Liang Li wrote: > > > + for_each_migratetype_order(order, t) { > > > + list_for_each(curr, &zone->free

Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info

> Subject: Re: [PATCH v2 repost 6/7] mm: add the related functions to get free > page info > > On 07/26/2016 06:23 PM, Liang Li wrote: > > + for_each_migratetype_order(order, t) { > > + list_for_each(curr, &zone->free_area[order].free_list[t]) { > > + pfn = page_to_pf

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

On Thu, Jul 28, 2016 at 12:08:30AM +0900, Namhyung Kim wrote: > Add virtio pstore device to allow kernel log files saved on the host. > It will save the log files on the directory given by pstore device > option. > > $ qemu-system-x86_64 -device virtio-pstore,directory=dir-xx ... > > (guest)

Re: [Qemu-devel] [PATCH RFC] spapr: disintricate core-id from DT semantics

On Wed, Jul 27, 2016 at 12:06:17PM +0200, Greg Kurz wrote: > Le Mon, 25 Jul 2016 16:01:31 +1000, > David Gibson a écrit : > > > On Fri, Jul 22, 2016 at 01:10:36PM +0200, Greg Kurz wrote: > > > The goal of this patch is to have a stable core-id which does not depend > > > on any DT related semanti

Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize

On 07/27/2016 02:26 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > Makefile.objs | 1 + > configure | 4 +-- > include/qemu/module.h | 2 ++ > include/ui/console.h | 5 ++-- > ui/Makefile.objs | 2 ++ > ui/sdl-init.c | 75 >

Re: [Qemu-devel] [Xen-devel] [PATCH 04/19] xen: Move evtchn functions to xen_pvdev.c

On 07/25/2016 07:53 AM, Anthony PERARD wrote: > On Sun, Jul 10, 2016 at 02:47:35PM +0300, Emil Condrea wrote: >> The name of the functions moved: >> * xen_be_evtchn_event >> * xen_be_unbind_evtchn >> * xen_be_send_notify >> >> Signed-off-by: Emil Condrea >> --- >> hw/xen/xen_backend.c

Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info

On Wed, Jul 27, 2016 at 03:16:57PM -0700, Dave Hansen wrote: > On 07/27/2016 03:05 PM, Michael S. Tsirkin wrote: > > On Wed, Jul 27, 2016 at 09:40:56AM -0700, Dave Hansen wrote: > >> On 07/26/2016 06:23 PM, Liang Li wrote: > >>> + for_each_migratetype_order(order, t) { > >>> + list_for_each

Re: [Qemu-devel] [PATCH v2 repost 3/7] mm: add a function to get the max pfn

On 07/27/2016 03:08 PM, Michael S. Tsirkin wrote: >> > +unsigned long get_max_pfn(void) >> > +{ >> > + return max_pfn; >> > +} >> > +EXPORT_SYMBOL(get_max_pfn); >> > + > > This needs a coment that this can change at any time. > So it's only good as a hint e.g. for sizing data structures. Or, if

Re: [Qemu-devel] [PATCH for-2.7 1/2] throttle: Don't allow burst limits to be lower than the normal limits

On 07/27/2016 04:45 PM, Alberto Garcia wrote: > On Thu 28 Jul 2016 12:33:51 AM CEST, Eric Blake wrote: >>> +if (cfg->buckets[i].max && cfg->buckets[i].max < >>> cfg->buckets[i].avg) { >>> +error_setg(errp, "if bps_max/iops_max is set it cannot be >>> lower" >>> +

Re: [Qemu-devel] [PATCH for-2.7 1/2] throttle: Don't allow burst limits to be lower than the normal limits

On Thu 28 Jul 2016 12:33:51 AM CEST, Eric Blake wrote: >> +if (cfg->buckets[i].max && cfg->buckets[i].max < >> cfg->buckets[i].avg) { >> +error_setg(errp, "if bps_max/iops_max is set it cannot be lower" >> + " than the bps/iops values"); > > Feels a bit l

Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification

On Wed, Jul 27, 2016 at 06:08:23PM +0800, Gonglei wrote: > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). The virtio crypto device can provide > five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. > > In this patch, CIPHER, MAC, HASH,

Re: [Qemu-devel] [PATCH for-2.7 1/2] throttle: Don't allow burst limits to be lower than the normal limits

On 07/27/2016 04:16 PM, Alberto Garcia wrote: > Setting FOO_max to a value that is lower than FOO does not make > sense, and it produces odd results depending on the value of > FOO_max_length. Although the user should not set that configuration > in the first place it's better to reject it explicit

Re: [Qemu-devel] [RFC/PATCHSET 0/7] virtio: Implement virtio pstore device (v2)

On Thu, Jul 28, 2016 at 12:08:24AM +0900, Namhyung Kim wrote: > Hello, > > This is v2 of the virtio-pstore work. In this patchset I addressed > most of feedbacks from previous version. Limiting disk size is not > implemented yet. For some reason, only parts of the patchset were received. Pls po

[Qemu-devel] [PATCH for-2.7 1/2] throttle: Don't allow burst limits to be lower than the normal limits

Setting FOO_max to a value that is lower than FOO does not make sense, and it produces odd results depending on the value of FOO_max_length. Although the user should not set that configuration in the first place it's better to reject it explicitly. https://bugzilla.redhat.com/show_bug.cgi?id=13556

[Qemu-devel] [PATCH for-2.7 0/2] Don't allow burst limits to be lower than the normal limits

Hello, Gu Nini found this problem and reported it in https://bugzilla.redhat.com/show_bug.cgi?id=1355665 When setting the throttling configuration, the burst limits can be lower than the normal limits. This does not making any sense and behaves oddly, so let's forbid it. Berto Alberto Garcia (

[Qemu-devel] [PATCH for-2.7 2/2] throttle: Test burst limits lower than the normal limits

This checks that making FOO_max lower than FOO is not allowed. We could also forbid having FOO_max == FOO, but that doesn't have any odd side effects and it would require us to update several other tests, so let's keep it simple. Signed-off-by: Alberto Garcia --- tests/test-throttle.c | 8 +

Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info

On 07/27/2016 03:05 PM, Michael S. Tsirkin wrote: > On Wed, Jul 27, 2016 at 09:40:56AM -0700, Dave Hansen wrote: >> On 07/26/2016 06:23 PM, Liang Li wrote: >>> + for_each_migratetype_order(order, t) { >>> + list_for_each(curr, &zone->free_area[order].free_list[t]) { >>> +

[Qemu-devel] [Bug 1606899] Re: virtio-vga does not let guest poweroff properly

Does the issue persist if you remove the intel-hda device (id=sound0) and the dependent hda-duplex device (id=sound0-codec0)? Asking because of . If it persists, then please capture a stack dump with gdb, when QEMU is hung. (

Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info

On Wed, Jul 27, 2016 at 09:23:35AM +0800, Liang Li wrote: > Save the free page info into a page bitmap, will be used in virtio > balloon device driver. > > Signed-off-by: Liang Li > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Mel Gorman > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > Cc: Co

Re: [Qemu-devel] [PATCH v2 repost 3/7] mm: add a function to get the max pfn

On Wed, Jul 27, 2016 at 09:23:32AM +0800, Liang Li wrote: > Expose the function to get the max pfn, so it can be used in the > virtio-balloon device driver. > > Signed-off-by: Liang Li > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Mel Gorman > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > C

Re: [Qemu-devel] [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process

On Wed, Jul 27, 2016 at 09:23:33AM +0800, Liang Li wrote: > The implementation of the current virtio-balloon is not very > efficient, the time spends on different stages of inflating > the balloon to 7GB of a 8GB idle guest: > > a. allocating pages (6.5%) > b. sending PFNs to host (68.3%) > c. add

Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info

On Wed, Jul 27, 2016 at 09:40:56AM -0700, Dave Hansen wrote: > On 07/26/2016 06:23 PM, Liang Li wrote: > > + for_each_migratetype_order(order, t) { > > + list_for_each(curr, &zone->free_area[order].free_list[t]) { > > + pfn = page_to_pfn(list_entry(curr, struct page, l

Re: [Qemu-devel] [PATCH 1/2] blockdev: Remove unnecessary lines from Makefile

On 07/27/2016 02:38 PM, Colin Lord wrote: > Removes some superfluous lines from the Makefile which should have been > removed as part of the patch series to add dynamic loading for block > driver modules. If that series has not been merged to master yet, it may be better to just squash this into t

Re: [Qemu-devel] [PATCH v2 repost 7/7] virtio-balloon: tell host vm's free page info

On Wed, Jul 27, 2016 at 09:23:36AM +0800, Liang Li wrote: > Support the request for vm's free page information, response with > a page bitmap. QEMU can make use of this free page bitmap to speed > up live migration process by skipping process the free pages. > > Signed-off-by: Liang Li > Cc: Mich

Re: [Qemu-devel] [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process

On Wed, Jul 27, 2016 at 09:03:21AM -0700, Dave Hansen wrote: > On 07/26/2016 06:23 PM, Liang Li wrote: > > + vb->pfn_limit = VIRTIO_BALLOON_PFNS_LIMIT; > > + vb->pfn_limit = min(vb->pfn_limit, get_max_pfn()); > > + vb->bmap_len = ALIGN(vb->pfn_limit, BITS_PER_LONG) / > > +BITS_PER

Re: [Qemu-devel] [PULL v2 for-2.7 02/15] qapi: change QmpInputVisitor to QSLIST

On 07/19/16 20:41, Markus Armbruster wrote: > From: Paolo Bonzini > > This saves a lot of memory compared to a statically-sized array, > or at least 24kb could be considered a lot on an Atari ST. > It also makes the code more similar to QmpOutputVisitor. > > This removes the limit on the depth of

Re: [Qemu-devel] [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process

On Wed, Jul 27, 2016 at 09:23:33AM +0800, Liang Li wrote: > The implementation of the current virtio-balloon is not very > efficient, the time spends on different stages of inflating > the balloon to 7GB of a 8GB idle guest: > > a. allocating pages (6.5%) > b. sending PFNs to host (68.3%) > c. add

Re: [Qemu-devel] [PATCH] error: error_setg_errno(): errno gets preserved

On 07/27/2016 03:24 AM, Sascha Silbe wrote: > C11 allows errno to be clobbered by pretty much any library function > call, so in general callers need to take care to save errno before > calling other functions. > > However, for error reporting functions this is rather awkward and can > make the co

[Qemu-devel] [PATCH 2/2] blockdev: Modularize nfs block driver

Modularizes the nfs block driver so that it gets dynamically loaded. Signed-off-by: Colin Lord --- block/Makefile.objs | 1 + configure | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/Makefile.objs b/block/Makefile.objs index 595f366..fa4d8b8 100644 --- a

Re: [Qemu-devel] [PATCH v2 2/2] usb-mtp: added object properties

Isaac Lozano <109loza...@gmail.com> writes: > Windows uses object properties to determine the size of a file, so to > add object properties, we must also add a minimum set of new commands > and object properties. Most object properties are data that we already > have, except for the unique persist

[Qemu-devel] [PATCH 0/2] Modularize NFS Block Driver and Makefile Cleanup

Some very short patches as a followup to my last patches to add dynamic loading of block driver modules. The first patch removes some leftover lines from the Makefile which should have been deleted, and the other patch modularizes the NFS block driver. The NFS block driver is the only remaining pro

[Qemu-devel] [PATCH 1/2] blockdev: Remove unnecessary lines from Makefile

Removes some superfluous lines from the Makefile which should have been removed as part of the patch series to add dynamic loading for block driver modules. Signed-off-by: Colin Lord --- Makefile | 3 --- 1 file changed, 3 deletions(-) diff --git a/Makefile b/Makefile index 4b9384e..c7aa8cd 100

Re: [Qemu-devel] [PATCH v2 1/2] usb-mtp: fix sending files larger than 4gb

Hi Isaac, Some minor comments below. Isaac Lozano <109loza...@gmail.com> writes: > MTP requires that if a file is larger than 4gb or if sending data larger > than 4gb, that the length field be set to 0x. > > Also widened a couple variables to prevent overflow errors. > > Signed-off-by: I

Re: [Qemu-devel] [Qemu-discuss] [problem]-starting a VM causes RT (latency) problem for application running on another VM

+ qemu-devel Hello All, Kindly read this short description of the problem (from the last week) and try to assist. Currently the problem is constantly seen and easily reproduced. Thank you, Yan From: Yan Fridland Sent: Wednesday, July 27, 2016 5:05 PM To: 'Yadi'; 'qemu-disc...@nongnu.org' Subj

Re: [Qemu-devel] ext4 error when testing virtio-scsi & vhost-scsi

Hi! On Wed 27-07-16 15:58:55, Zhangfei Gao wrote: > Hi, Michael > > I have met ext4 error when using vhost_scsi on arm64 platform, and > suspect it is vhost_scsi issue. > > Ext4 error when testing virtio_scsi & vhost_scsi > > > No issue: > 1. virtio_scsi, ext4 > 2. vhost_scsi & virtio_scsi, ex

[Qemu-devel] invalid runstate transition: 'prelaunch' -> 'prelaunch'

Hi, I just upgraded GNU ARM Eclipse QEMU to 2.6.0 and ran into a problem. The console reads: ``` GNU ARM Eclipse 64-bits QEMU v2.6.0 (qemu-system-gnuarmeclipse). Board: 'STM32F4-Discovery' (ST Discovery kit for STM32F407/417 lines). Device: 'STM32F407VG' (Cortex-M4 r0p0, MPU), Flash: 1024 kB, RA

Re: [Qemu-devel] [PATCH 1/1] block/parallels: check new image size

On 07/27/2016 07:01 PM, Denis V. Lunev wrote: From: Klim Kireev Before this patch incorrect image could be created via qemu-img (Example: qemu-img create -f parallels -o size=4096T hack.img), incorrect images cannot be used due to overflow in main image structure. This patch add check of size

Re: [Qemu-devel] [PATCH] virtio: check vring descriptor buffer length

On Wed, Jul 27, 2016 at 10:13:04AM -0600, Eric Blake wrote: > On 07/27/2016 09:37 AM, P J P wrote: > > From: Prasad J Pandit > > > > virtio back end uses set of buffers to facilitate I/O operations. > > An infinite loop unfolds in virtqueue_pop() if a buffer was > > of zero size. Add check to avo

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

On Tue, Jun 28, 2016 at 10:24:29AM +0200, Igor Mammedov wrote: > replace mainly useless exit(1) on fatal error path with > abort(), so that it would be possible to generate core > dump, that could be used to analyse cause of problem. > > Signed-off-by: Igor Mammedov I thought about this, and I'd

Re: [Qemu-devel] [PULL 0/1] Cve 2016 5403 virtio unbounded allocation patches

On 27 July 2016 at 17:43, Stefan Hajnoczi wrote: > The following changes since commit f49ee630d73729ecaeecf4b38a8df11bc613914d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160726' > into staging (2016-07-26 11:53:47 +0100) > > are available in the git repository at: > >

[Qemu-devel] [PATCH v2 1/1] block/parallels: check new image size

From: Klim Kireev Before this patch incorrect image could be created via qemu-img (Example: qemu-img create -f parallels -o size=4096T hack.img), incorrect images cannot be used due to overflow in main image structure. This patch add check of size in image creation. After reading size it compar

[Qemu-devel] [PATCH 1/1] block/parallels: check new image size

From: Klim Kireev Before this patch incorrect image could be created via qemu-img (Example: qemu-img create -f parallels -o size=4096T hack.img), incorrect images cannot be used due to overflow in main image structure. This patch add check of size in image creation. After reading size it compar

[Qemu-devel] [PATCH 6/6] arm: add support for an ast2500 evaluation board

Signed-off-by: Cédric Le Goater --- hw/arm/palmetto-bmc.c| 32 +++- include/hw/arm/ast2400.h | 5 + 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/hw/arm/palmetto-bmc.c b/hw/arm/palmetto-bmc.c index cd8aa59756b9..8d8bfeb571e2 100644 --- a/hw/ar

[Qemu-devel] [PATCH 5/6] aspeed: add ast2500 support to scu and sdmc controllers

Based on previous work done by Andrew Jeffery . Signed-off-by: Cédric Le Goater --- hw/misc/aspeed_scu.c | 45 +++- hw/misc/aspeed_sdmc.c| 1 + include/hw/misc/aspeed_scu.h | 1 + 3 files changed, 46 insertions(+), 1 deletion(-) diff --g

[Qemu-devel] [PATCH 3/6] ast2400: use machine cpu_model to initialize the soc cpu

It will be easier to specify a different cpu for other soc derived from the ast2400 soc. Signed-off-by: Cédric Le Goater --- hw/arm/ast2400.c | 8 +++- hw/arm/palmetto-bmc.c | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/arm/ast2400.c b/hw/arm/ast2400.c index fa

[Qemu-devel] [PATCH 1/1] ehci: faster frame index calculation for skipped frames

From: Evgeny Yakovlev ehci_update_frindex takes time linearly proportional to a number of uframes to calculate new frame index and raise FLR interrupts, which is a problem for large amounts of uframes. If we experience large delays between echi timer callbacks (i.e. because other periodic handle

[Qemu-devel] [PATCH 1/6] palmetto-bmc: add a "silicon-rev" property at the soc level

The SCU controler holds the board revision number in its 0x7C register. Let's use an alias to link a "silicon-rev" property of the soc to the "silicon-rev" property of the SCU controler. The SDMC controler "silicon-rev" property is derived from the SCU one at realize time. I did not find a better

[Qemu-devel] [PATCH 0/6] arm: add ast2500 support

The ast2500 soc being very close to the ast2400 soc, the goal of the changes below is to modify the existing platform 'palmetto-bmc' and existing soc 'ast2400' to take into account the small differences and avoid code duplication. This is mostly inspired by the realview platform. First patches rew

[Qemu-devel] [PATCH 4/6] palmetto-bmc: add board specific configuration

aspeed_init() now uses a board identifier to customize some values specific to the board, ram base, board revision number, etc. Signed-off-by: Cédric Le Goater --- hw/arm/palmetto-bmc.c | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/hw/arm

[Qemu-devel] [PATCH 2/6] palmetto-bmc: replace palmetto_bmc with aspeed

This is mostly a name replacement to prepare ground for other socs specificities. It also adds a specific TypeInfo struct for the palmetto_bmc board with a custom initialization for the same reason. Signed-off-by: Cédric Le Goater --- Should we change the name of the file to aspeed.c ? I am not

[Qemu-devel] [PULL 0/1] Cve 2016 5403 virtio unbounded allocation patches

The following changes since commit f49ee630d73729ecaeecf4b38a8df11bc613914d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160726' into staging (2016-07-26 11:53:47 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/CVE-2016-5403-virti

[Qemu-devel] [PULL 1/1] virtio: error out if guest exceeds virtqueue size

A broken or malicious guest can submit more requests than the virtqueue size permits, causing unbounded memory allocation in QEMU. The guest can submit requests without bothering to wait for completion and is therefore not bound by virtqueue size. This requires reusing vring descriptors in more t

Re: [Qemu-devel] [PATCH v2 repost 6/7] mm: add the related functions to get free page info

On 07/26/2016 06:23 PM, Liang Li wrote: > + for_each_migratetype_order(order, t) { > + list_for_each(curr, &zone->free_area[order].free_list[t]) { > + pfn = page_to_pfn(list_entry(curr, struct page, lru)); > + if (pfn >= start_pfn && pfn <= en

Re: [Qemu-devel] [PULL 0/2] Block patches for 2.7

On 26 July 2016 at 21:52, Jeff Cody wrote: > The following changes since commit f49ee630d73729ecaeecf4b38a8df11bc613914d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160726' > into staging (2016-07-26 11:53:47 +0100) > > are available in the git repository at: > > > g

[Qemu-devel] [PATCH] help: Update help to reflect that GTK is the default

Updates the messages displayed in the help option to reflect that GTK is the default display, not SDL. --- qemu-options.hx | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8e0d9a5..5bec1d3 100644 --- a/qemu-options.hx +++

Re: [Qemu-devel] [PATCH] virtio: check vring descriptor buffer length

On 07/27/2016 09:37 AM, P J P wrote: > From: Prasad J Pandit > > virtio back end uses set of buffers to facilitate I/O operations. > An infinite loop unfolds in virtqueue_pop() if a buffer was > of zero size. Add check to avoid it. > > Reported-by: Li Qiang > Signed-off-by: Prasad J Pandit > -

  1   2   3   >