On 08/02/2016 03:14 PM, Jason Wang wrote:
On 2016年07月26日 09:49, Zhang Chen wrote:
In this patch we use kernel jhash table to track
connection, and then enqueue net packet like this:
+ CompareState ++
| |
+---+ +---+ +---+
|conn lis
Emilio G. Cota writes:
> On Wed, Aug 03, 2016 at 22:02:04 +0100, Alex Bennée wrote:
>> Emilio G. Cota writes:
>>
>> > On Tue, Aug 02, 2016 at 18:27:42 +0100, Alex Bennée wrote:
> (snip)
>> >> +void wait_safe_cpu_work(void)
>> >> +{
>> >> +while (can_wait_for_safe() && atomic_mb_read(&safe_w
On 2016年08月02日 19:37, P J P wrote:
From: Prasad J Pandit
VMware VMXNET* NIC emulator supports packet fragmentation.
While fragmenting a packet, it checks for more fragments based
on packet length and current fragment length. It is susceptible
to an infinite loop, if the current fragment lengt
** Changed in: qemu (Ubuntu)
Importance: Undecided => Medium
** Changed in: qemu (Ubuntu Xenial)
Importance: Undecided => Medium
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1490611
Title:
On Sat, Jul 30, 2016 at 06:38:23AM +, Prerna Saxena wrote:
>
>
>
>
>
> On 30/07/16 2:19 am, "Eric Blake" wrote:
>
> >On 07/28/2016 01:07 AM, Prerna Saxena wrote:
> >> From: Prerna Saxena
> >>
> >> This introduces the VHOST_USER_PROTOCOL_F_REPLY_ACK.
> >>
> >
> >> +
> >> +With this pro
On 08/01/2016 07:44 PM, Paolo Bonzini wrote:
On 29/07/2016 13:05, Cao jin wrote:
Cc: Paolo Bonzini
Cc: Peter Maydell
Cc Peter Crosthwaite
Cc: Richard Henderson
Cao jin (3):
timer: update comments
cpus: rename local variable to meaningful one
cpus: update comments
cpus.c
On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent Vivier wrote:
> If we don't provide the page size in target-ppc:cpu_get_dump_info(),
> the default one (TARGET_PAGE_SIZE, 4KB) is used to create
> the compressed dump. It works fine with Macintosh, but not with
> pseries as the kernel default page s
On Wed, Aug 03, 2016 at 09:44:08PM +1000, Benjamin Herrenschmidt wrote:
> Other archs don't do it, some programs catch signals just fine
> and those dumps just clutter the output. Keep the dumps for cases
> that aren't supposed to happen such as unknown codes.
>
> Signed-off-by: Benjamin Herrensch
On Wed, Aug 03, 2016 at 05:55:23PM +1000, Benjamin Herrenschmidt wrote:
> The usermode "translate" code generates an error code value that
> has the "is_write" bit set, which causes our switch/case to miss
> and display "Invalid segfault errno" and a spurrious second state
> dump. Fix it.
>
> Sign
This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to
drain IO requests), remove it.
Suggested-by: Laszlo Ersek
Signed-off-by: Fam Zheng
Reviewed-by: Laszlo Ersek
---
hw/block/virtio-blk.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/vir
At system_reset, there is no point in retrying the queued request,
because the driver that issued the request won't be around any more.
Analyzed-by: Laszlo Ersek
Reported-by: Laszlo Ersek
Signed-off-by: Fam Zheng
Reviewed-by: Laszlo Ersek
---
hw/block/virtio-blk.c | 9 +
1 file change
v3: Patch 1: add comment as Laszlo suggested, and add his r-b too. :)
Fam Zheng (2):
virtio-blk: Release s->rq queue at system_reset
virtio-blk: Remove stale comment about draining
hw/block/virtio-blk.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
--
2.7.4
On 08/02/2016 01:17 AM, Bruce Rogers wrote:
Hi Cao,
Upon re-reading your comment, I believe you are still thinking that
it was right to use the error object in this context. The fact that this
device has no pin interrupt is _not_ an error condition, and hence the
use of error_setg() is not
On Wed, 08/03 13:42, Fam Zheng wrote:
> By not using "--format" with docker images command.
>
> The option is not available on RHEL 7 docker command. Use an awk
> matching command instead.
>
> Reported-by: Paolo Bonzini
> Signed-off-by: Fam Zheng
> ---
> tests/docker/Makefile.include | 5 ++---
On 2016年08月04日 07:16, Michael S. Tsirkin wrote:
This allows increasing the rx queue size up to 1024: unlike with tx,
guests don't put in huge S/G lists into RX so the risk of running into
the max 1024 limitation due to some off-by-one seems small.
It's helpful for users like OVS-DPDK which don
Hi~~ Paolo and Daniel.
No news for a week~
Can you give me some feedback for this patch?
We need comments...
Thanks
Zhang Chen
On 07/28/2016 05:12 PM, Zhang Chen wrote:
Add qemu_chr_add_handlers_full() API, we can use
this API pass in a GMainContext,make handler run
in the context rather
On Wed, 08/03 13:00, John Snow wrote:
>
>
> On 08/03/2016 12:44 PM, Max Reitz wrote:
> > On 02.08.2016 02:12, John Snow wrote:
> > > Key:
> > > [] : patches are identical
> > > [] : number of functional differences between upstream/downstream
> > > patch
> > > [down] : patch is downstrea
On Tue, Aug 2, 2016 at 4:56 AM, KONRAD Frederic
wrote:
>
>
> Le 02/07/2016 à 01:07, Alistair Francis a écrit :
>>
>> On Mon, Jun 13, 2016 at 9:27 AM, wrote:
>>>
>>> From: KONRAD Frederic
>>>
>>> This is a fixed clock device.
>>> It justs behave as an empty device with a parametrable output rate
On Tue, Aug 2, 2016 at 2:29 AM, KONRAD Frederic
wrote:
>
>
> Le 29/06/2016 à 02:38, Alistair Francis a écrit :
>>
>> On Mon, Jun 13, 2016 at 9:27 AM, wrote:
>>>
>>> From: KONRAD Frederic
>>>
>>> This adds the qemu-clock documentation.
>>>
>>> Signed-off-by: KONRAD Frederic
>>> ---
>>> docs/c
On Tue, Aug 2, 2016 at 12:47 AM, KONRAD Frederic
wrote:
>
>
> Le 29/06/2016 à 02:15, Alistair Francis a écrit :
>>
>> On Mon, Jun 13, 2016 at 9:27 AM, wrote:
>>>
>>> From: KONRAD Frederic
>>>
>>> This allows to attach a clock to a DeviceState.
>>> Contrary to gpios, the clock pins are not conta
Hi Kirti,
[auto build test WARNING on vfio/next]
[also build test WARNING on v4.7 next-20160803]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Kirti-Wankhede/Add-Mediated-device-support
On Thu, Aug 04, 2016 at 02:16:14AM +0300, Michael S. Tsirkin wrote:
> This allows increasing the rx queue size up to 1024: unlike with tx,
> guests don't put in huge S/G lists into RX so the risk of running into
> the max 1024 limitation due to some off-by-one seems small.
>
> It's helpful for use
On Wed, Aug 03, 2016 at 22:02:04 +0100, Alex Bennée wrote:
> Emilio G. Cota writes:
>
> > On Tue, Aug 02, 2016 at 18:27:42 +0100, Alex Bennée wrote:
(snip)
> >> +void wait_safe_cpu_work(void)
> >> +{
> >> +while (can_wait_for_safe() && atomic_mb_read(&safe_work_pending) > 0)
> >> {
> >
> > T
This allows increasing the rx queue size up to 1024: unlike with tx,
guests don't put in huge S/G lists into RX so the risk of running into
the max 1024 limitation due to some off-by-one seems small.
It's helpful for users like OVS-DPDK which don't do any buffering on the
host - 1K roughly matches
Hi Kirti,
[auto build test WARNING on vfio/next]
[also build test WARNING on v4.7 next-20160803]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Kirti-Wankhede/Add-Mediated-device-support
Emilio G. Cota writes:
> On Tue, Aug 02, 2016 at 18:27:42 +0100, Alex Bennée wrote:
>> From: Sergey Fedorov
>>
>> This patch is based on the ideas found in work of KONRAD Frederic [1],
>> Alex Bennée [2], and Alvise Rigo [3].
>>
>> This mechanism allows to perform an operation safely in a quies
> On 08/02/2016 12:07 PM, Alex Bennée wrote:
> > This will work but I wonder if it is time to call it a day for 32 on 64
> > support? I mean all this can be worked around but I wonder if it is
> > worth the effort if no one actually uses this combination.
>
> I've been meaning to bring up exactly
On 3 August 2016 at 21:08, Matthew Garrett wrote:
> Is there any mechanism for automatically mapping non-PCI MMIO devices
> to an appropriate range? From what I've found so far it seems like
> target machines tend to be responsible for mapping individual devices,
> but I want to make sure that I'm
Add a generic loader to QEMU which can be used to load images or set
memory values.
Signed-off-by: Alistair Francis
---
V10:
- Split out the PC setting and data loading
V9:
- Fix error messages
- Updated some incorrect logic
- Add address space loading support for all image types
- Explain w
Is there any mechanism for automatically mapping non-PCI MMIO devices
to an appropriate range? From what I've found so far it seems like
target machines tend to be responsible for mapping individual devices,
but I want to make sure that I'm not missing some generic "Just put
the device in a reasona
Signed-off-by: Alistair Francis
---
V10:
- Split the data loading and PC setting
V9:
- Clarify the image loading options
V8:
- Improve documentation
V6:
- Fixup documentation
V4:
- Re-write to be more comprehensive
docs/generic-loader.txt | 81 +++
Add a new function load_uimage_as() that allows the caller to
specify an AddressSpace to use when loading the uImage. The
original load_uimage() function doesn't have any change in
functionality.
Signed-off-by: Alistair Francis
---
V10:
- Add comment about the function in the header file.
hw/c
When loading ROMs allow the caller to specify an AddressSpace to use for
the load.
Signed-off-by: Alistair Francis
---
V10:
- Set the rom address space instead of leaving it NULL
- Cleanup ordering logic
V9:
- Fixup the ROM ordering
- Don't allow address space and memory region to be specifie
Add a new function load_elf_as() that allows the caller to specify an
AddressSpace to use when loading the ELF. The original load_elf()
function doesn't have any change in functionality.
Signed-off-by: Alistair Francis
Reviewed-by: Peter Maydell
---
V8:
- Introduce an RFC version of AddressSpac
Add a new function load_image_targphys_as() that allows the caller
to specify an AddressSpace to use when loading a targphys. The
original load_image_targphys() function doesn't have any change in
functionality.
Signed-off-by: Alistair Francis
---
V10:
- Add comment about the function in the hea
Prevously the specified MemoryRegion was ignored during the rom register
reset. This patch uses the rom MemoryRegion is avaliable.
Signed-off-by: Alistair Francis
Reviewed-by: Peter Maydell
---
hw/core/loader.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/core/loade
If the caller didn't specify an architecture for the ELF machine
the load_elf() function will auto detect it based on the ELF file.
Signed-off-by: Alistair Francis
---
V10:
- Base checks on the EM_NONE macro
V9:
- Update documentation
V8:
- Move into load_elf64/load_elf32
V7:
- Fix typo
inc
This work is based on the original work by Li Guang with extra
features added by Peter C and myself.
The idea of this loader is to allow the user to load multiple images
or values into QEMU at startup.
Memory values can be loaded like this: -device
loader,addr=0xfd1a0104,data=0x800e,data-len
If we don't provide the page size in target-ppc:cpu_get_dump_info(),
the default one (TARGET_PAGE_SIZE, 4KB) is used to create
the compressed dump. It works fine with Macintosh, but not with
pseries as the kernel default page size is 64KB.
Without this patch, if we generate a compressed dump in th
On 07/26/2016 12:53 AM, Aurelien Jarno wrote:
Now on the less technical side, I really like the idea of being able to
transform more or less in place the TCG instruction stream. Your more or
less recent patches towards that direction are great. That said I am a
bit worried that we loop many times
VFIO IOMMU drivers are designed for the devices which are IOMMU capable.
Mediated device only uses IOMMU APIs, the underlying hardware can be
managed by an IOMMU domain.
Aim of this change is:
- To use most of the code of TYPE1 IOMMU driver for mediated devices
- To support direct assigned device
Add file Documentation/vfio-mediated-device.txt that include details of
mediated device framework.
Signed-off-by: Kirti Wankhede
Signed-off-by: Neo Jia
Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d
---
Documentation/vfio-mediated-device.txt | 235 +
1 file
Design for Mediated Device Driver:
Main purpose of this driver is to provide a common interface for mediated
device management that can be used by different drivers of different
devices.
This module provides a generic interface to create the device, add it to
mediated bus, add device to IOMMU grou
MPCI VFIO driver registers with MDEV core driver. MDEV core driver creates
mediated device and calls probe routine of MPCI VFIO driver. This driver
adds mediated device to VFIO core module.
Main aim of this module is to manage all VFIO APIs for each mediated PCI
device. Those are:
- get region info
This series adds Mediated device support to Linux host kernel. Purpose
of this series is to provide a common interface for mediated device
management that can be used by different devices. This series introduces
Mdev core module that create and manage mediated devices, VFIO based driver
for mediate
On Wed, Aug 03, 2016 at 07:23:36PM +0200, Cornelia Huck wrote:
> On Wed, 3 Aug 2016 16:53:36 +0200
> Cornelia Huck wrote:
>
> > On Wed, 3 Aug 2016 17:40:07 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Aug 03, 2016 at 04:33:28PM +0200, Cornelia Huck wrote:
> > > > On Wed, 3 Aug 2016 1
On Fri, Jul 29, 2016 at 10:55 AM, Peter Maydell
wrote:
> On 14 July 2016 at 01:03, Alistair Francis
> wrote:
>> Signed-off-by: Alistair Francis
>> ---
>> V9:
>> - Clarify the image loading options
>> V8:
>> - Improve documentation
>> V6:
>> - Fixup documentation
>> V4:
>> - Re-write to be m
On 07/25/2016 08:45 PM, Aurelien Jarno wrote:
> +#define TS_DEAD 1
> +#define TS_SYNC 2
I am not sure that TS_SYNC is the best name for that. There we really
want to tell that at this moment in the TCG instruction stream the
operand is in memory. It doesn't implied it is synced. Maybe TS_MEM?
On 07/25/2016 04:53 PM, Aurelien Jarno wrote:
On 2016-06-23 20:48, Richard Henderson wrote:
@@ -1287,18 +1287,10 @@ void tcg_op_remove(TCGContext *s, TCGOp *op)
int next = op->next;
int prev = op->prev;
-if (next >= 0) {
-s->gen_op_buf[next].prev = prev;
-} else {
-
On Wed, 3 Aug 2016, Juergen Gross wrote:
> On 02/08/16 20:27, Stefano Stabellini wrote:
> > On Tue, 2 Aug 2016, Juergen Gross wrote:
> >> Instead of calling xen_be_register() for each supported backend type
> >> for hvm and pv guests in their machine init functions use a common
> >> function in ord
On Wed, Aug 03, 2016 at 09:09:25AM +0200, David Hildenbrand wrote:
[...]
> > > > > Other architectures are not
> > > > > +# supported yet.
> > > >
> > > > What if we provide a generic comparison function that does like
> > > > the following pseudocode:
> > > >
> > > > def basic_comparison(mod
On Wed, 3 Aug 2016 17:22:36 +0100
"Daniel P. Berrange" wrote:
> The virtio-console.c file handles both serial consoles
> and interactive consoles, since they're backed by the
> same device model.
>
> Since serial devices are expected to be reliable and
> need to notify the guest when the backen
On 08/02/2016 12:07 PM, Alex Bennée wrote:
This will work but I wonder if it is time to call it a day for 32 on 64
support? I mean all this can be worked around but I wonder if it is
worth the effort if no one actually uses this combination.
I've been meaning to bring up exactly this question d
On Wed, 3 Aug 2016 16:53:36 +0200
Cornelia Huck wrote:
> On Wed, 3 Aug 2016 17:40:07 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Wed, Aug 03, 2016 at 04:33:28PM +0200, Cornelia Huck wrote:
> > > On Wed, 3 Aug 2016 17:30:22 +0300
> > > "Michael S. Tsirkin" wrote:
> > >
> > > > On Mon, Aug 01,
using atoi() for converting string to int may be error prone in case if
string supplied in the argument is not a fold of numerical number,
This is not a bug because in the existing code,
static QemuOptsList runtime_tcp_opts = {
.name = "gluster_tcp",
.head = QTAILQ_HEAD_INITIALIZER(runtim
The following changes since commit cc0100f464c94bf80ad36cd432f4a1ed58126b60:
MAINTAINERS: Update the Xilinx maintainers (2016-08-01 15:31:32 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to e911765cbb9e9ddf5d95
From: "Emilio G. Cota"
This is safer against overflow. g_renew is available in all
version of glib, while g_realloc_n is only available in 2.24.
Signed-off-by: Emilio G. Cota
Message-Id: <1469459025-23606-3-git-send-email-c...@braap.org>
[Rewritten to use g_new/g_renew. - Paolo]
Signed-off-by:
On 08/03/2016 12:44 PM, Max Reitz wrote:
On 02.08.2016 02:12, John Snow wrote:
Key:
[] : patches are identical
[] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, re
On 02.08.2016 02:12, John Snow wrote:
> Key:
> [] : patches are identical
> [] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences,
> respectively
>
> 001/10:[] [-C
On 03/08/2016 18:22, Daniel P. Berrange wrote:
> The virtio-console.c file handles both serial consoles
> and interactive consoles, since they're backed by the
> same device model.
>
> Since serial devices are expected to be reliable and
> need to notify the guest when the backend is opened
> or
On 03.08.2016 13:21, Kevin Wolf wrote:
> There is no reason why an NBD server couldn't be started for any node,
> even if it's not on the top level. This converts nbd-server-add to
> accept a node-name.
>
> Note that there is a semantic difference between using a BlockBackend
> name and the node n
Am 03.08.2016 um 15:19 schrieb John Snow:
> I also have to admit that I misread the report; I was under the
> impression that this was affecting Linux/Windows guests in some
> capacity, but re-reading the report I realize that you meant that you
> have observed behavior with a test case on Windows
On 03/08/2016 12:52, Peter Maydell wrote:
> On 2 August 2016 at 20:39, Paolo Bonzini wrote:
>> The following changes since commit cc0100f464c94bf80ad36cd432f4a1ed58126b60:
>>
>> MAINTAINERS: Update the Xilinx maintainers (2016-08-01 15:31:32 +0100)
>>
>> are available in the git repository at:
The write_console_data() method in sclpconsole-lm.c checks
whether the return value of qemu_chr_fe_write() has the
value of -EAGAIN and if so then increments the buffer offset
by the value of EAGAIN. Fortunately qemu_chr_fe_write() will
never return EAGAIN directly, rather it returns -1 with
errno
On 02.08.2016 02:12, John Snow wrote:
> From: Fam Zheng
>
> The added group of operations enables tracking of the changed bits in
> the dirty bitmap.
>
> Signed-off-by: Fam Zheng
> Reviewed-by: Max Reitz
Indeed. :-)
Max
> Signed-off-by: John Snow
> ---
> block/dirty-bitmap.c | 52
The mux chardev was not checking the return value of any
qemu_chr_fe_write() call so would silently loose data
on EAGAIN.
Similarly the qemu_chr_fe_printf method would not check
errors and was not in a position to retry even if it
could check.
Signed-off-by: Daniel P. Berrange
---
qemu-char.c |
The qemu_chr_fe_write method will return -1 on EAGAIN if the
chardev backend write would block. Almost no callers of the
qemu_chr_fe_write() method check the return value, instead
blindly assuming data was successfully sent. In most cases
this will lead to silent data loss on interactive consoles,
The continue_send() method in ipmi_bmc_extern.c directly
assigns the return value of qemu_chr_fe_write() to the
variable tracking the I/O buffer offset. This ignores the
possibility that the return value could be -1 and so will
cause I/O go backwards on EAGAIN. Fortunately 'outpos' is
unsigned, so
This series does a global fix and/or workaround for bad usage of
qemu_chr_fe_write(). Essentially only about 4/5 places in the code
got the usage correct, by handling errors. Everything else would
silently loose data if used with a chardev backend that can return
EAGAIN. One specific instance of th
The virtio-console.c file handles both serial consoles
and interactive consoles, since they're backed by the
same device model.
Since serial devices are expected to be reliable and
need to notify the guest when the backend is opened
or closed, the virtio-console.c file wires up support
for chardev
On 03.08.2016 13:21, Kevin Wolf wrote:
> There is no reason why an NBD server couldn't be started for any node,
> even if it's not on the top level. This converts nbd-server-add to
> accept a node-name.
>
> Note that there is a semantic difference between using a BlockBackend
> name and the node n
On 03.08.2016 17:22, Sascha Silbe wrote:
> Dear Vladimir,
>
> Vladimir Sementsov-Ogievskiy writes:
>
>> 109 iotest is broken for raw after 0965a41e998ab820b5
>> [mirror: double performance of the bulk stage if the disc is full]
>>
>> The problem is with finishing block-job with error: before spe
On 03.08.2016 13:21, Kevin Wolf wrote:
> The builtin NBD server uses its own BlockBackend now instead of reusing
> the monitor/guest device one.
>
> This means that it has its own writethrough setting now. The builtin
> NBD server always uses writeback caching now regardless of whether the
> guest
On Sun, Jul 31, 2016 at 06:06:30PM -0700, Ashish Mittal wrote:
A quick first pass review...
> +/* insure init once */
> +static pthread_mutex_t of_global_ctx_lock;
There is no need for this since .bdrv_open() and .bdrv_create() run
under the QEMU global mutex.
> +
> +/* HyperScale Driver Versi
On 03/08/2016 16:55, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> When calling make with a CFLAGS=.. argument, the -g/-O filter is not
> applied, which may result with build failure with ASAN for example. It
> could be solved with an 'override' directive on CFLAGS, but that
Hi
- Original Message -
>
>
> On 03/08/2016 16:55, marcandre.lur...@redhat.com wrote:
> > @@ -2851,11 +2851,6 @@ static void tcp_chr_disconnect(CharDriverState *chr)
> > return;
> > }
> >
> > -s->connected = 0;
> > -if (s->listen_ioc) {
> > -s->listen_tag
From: "Daniel P. Berrange"
When VNC is started with '-vnc none' there will be no
listener socket present. When we try to populate the
VncServerInfo we'll crash accessing a NULL 'lsock'
field.
#0 qio_channel_socket_get_local_address (ioc=0x0,
errp=errp@entry=0x7ffd5b8aa0f0) at io/channel-socke
On 03.08.2016 13:21, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> drive-mirror to accept a node-name without lifting the restriction that
> we're operating at a root node.
>
> In case o
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Wednesday, August 3, 2016 10:30 PM
> To: Gonglei
> Cc: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org;
> peter.huangp...@huawei.com; luoneng...@huawei.com;
> cornelia.h...@de.ibm.com; stefa...@redhat
On 03/08/2016 16:55, marcandre.lur...@redhat.com wrote:
> @@ -2851,11 +2851,6 @@ static void tcp_chr_disconnect(CharDriverState *chr)
> return;
> }
>
> -s->connected = 0;
> -if (s->listen_ioc) {
> -s->listen_tag = qio_channel_add_watch(
> -QIO_CHANNEL(s
On 03.08.2016 13:21, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> change-backing-file to accept a node-name without lifting the
> restriction that we're operating at a root node.
>
> In
From: "Daniel P. Berrange"
The vnc_server_info_get will allocate the VncServerInfo
struct and then call vnc_init_basic_info_from_server_addr
to populate the basic fields. If this returns an error
though, the qapi_free_VncServerInfo call will then crash
because the VncServerInfo struct instance wa
On 03.08.2016 13:21, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> blockdev-snapshot-delete-internal-sync to accept a node-name without
> lifting the restriction that we're operating at a
Dear Vladimir,
Vladimir Sementsov-Ogievskiy writes:
> 109 iotest is broken for raw after 0965a41e998ab820b5
> [mirror: double performance of the bulk stage if the disc is full]
>
> The problem is with finishing block-job with error: before specified
> patch mirror was not very async and it creat
On Wed, Aug 03, 2016 at 03:17:06PM +, Zeng, Xin wrote:
>
>
> > -Original Message-
> > From: Michael S. Tsirkin [mailto:m...@redhat.com]
> > Sent: Wednesday, August 3, 2016 10:30 PM
> > To: Gonglei
> > Cc: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org;
> > peter.huangp...@hua
in the git repository at:
git://git.kraxel.org/qemu tags/pull-vnc-20160803-1
for you to fetch changes up to 12e29b1682e0a50ed57c324152addb585ae5ce69:
vnc: ensure connection sharing/limits is always configured (2016-08-03
15:06:32 +0200)
--
From: Marc-André Lureau
In all cases, even when the dict doesn't contain 'ram', the qmp response
must be unref.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
tests/postcopy-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/postcopy-test.c b/tests/
On 03.08.2016 13:21, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> blockdev-snapshot-internal-sync to accept a node-name without lifting
> the restriction that we're operating at a root n
From: "Daniel P. Berrange"
The connection sharing / limits are only set in the
vnc_display_open() method and so missed when VNC is running
with '-vnc none'. This in turn prevents clients being added
to the VNC server with the QMP "add_client" command.
This was introduced in
commit e5f34cdd2da
On 03.08.2016 13:21, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> drive-mirror to accept a node-name without lifting the restriction that
> we're operating at a root node.
>
> In case o
From: Marc-André Lureau
qdev_get_dev_path() returns an allocated string, free it when no longer
needed.
Signed-off-by: Marc-André Lureau
Reviewed-by: Gerd Hoffmann
---
hw/usb/desc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/desc.c b/hw/usb/desc.c
index adb026e..5e0e1d1 100644
From: Marc-André Lureau
Allows one to specify a destroy function for the test data.
Signed-off-by: Marc-André Lureau
---
tests/libqtest.c | 15 +++
tests/libqtest.h | 7 ++-
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
inde
From: Marc-André Lureau
Release the qstring allocated in qjson_new().
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
migration/qjson.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/qjson.c b/migration/qjson.c
index 5cae55a..f345904 100644
--- a/migration/qjson.c
On 03.08.2016 13:21, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> drive-backup and the corresponding transaction action to accept a
> node-name without lifting the restriction that we're
On 03.08.2016 13:21, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> blockdev-mirror to accept a node-name without lifting the restriction
> that we're operating at a root node.
>
> Signed
From: Marc-André Lureau
Simplify a bit the code by using g_strdup_printf() and store it in a
non-const value so casting is no longer needed, and ownership is
clearer.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
hw/core/bus.c | 21 ++---
include/hw/qde
From: Marc-André Lureau
Free the timer allocated in instance_init.
Signed-off-by: Marc-André Lureau
Reviewed-by: Andrew Baumann
---
hw/sd/sd.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 87c6dc1..8e88e83 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@
From: Marc-André Lureau
A few strings are allocated and never freed.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
tests/postcopy-test.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
index bf4e579..41ed1a9
-08-01 15:31:32 +0100)
>
> are available in the git repository at:
>
> git://git.kraxel.org/qemu tags/pull-usb-20160803-1
>
> for you to fetch changes up to 0e39bb022b5fa8c11964968885f3263c02ce42b0:
>
> xen: use a common function for pv and hvm gues
From: Marc-André Lureau
The list is created during instance init and further populated with
usb_desc_set_string(). Clear it when unrealizing the device.
Signed-off-by: Marc-André Lureau
Reviewed-by: Gerd Hoffmann
---
hw/usb/bus.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/hw/u
1 - 100 of 254 matches
Mail list logo
