Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2016-08-04 Thread Markus Armbruster
Eric Blake writes: > On 08/03/2016 05:37 AM, Markus Armbruster wrote: >> Commit 9af9e0f, 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but >> they keep coming back. checkpatch.pl tries to flag them since commit >> 5d596c2, but it's not very good at it. Offenders tracked down with >> Coccin

Re: [Qemu-devel] fix incorrect identify implementation in nvme

2016-08-04 Thread Markus Armbruster
Keith Busch writes: > On Thu, Aug 04, 2016 at 09:42:13PM +0200, Christoph Hellwig wrote: >> Third resent of this series after this didn't get picked up the >> previous times. The Qemu NVMe implementation mistakes the cns >> field in the Identify command as a boolean. This was never >> true, and

Re: [Qemu-devel] qtest protocol: should memset/read/write etc of a size of 0 bytes be permitted?

2016-08-04 Thread Markus Armbruster
Eric Blake writes: > On 08/04/2016 12:46 PM, Peter Maydell wrote: >> I've upgraded to a more recent version of clang, which now produces >> undefined-behaviour warnings for passing NULL pointers to some library >> functions. One of the things it has shown up is that some of the >> qtest tests ask

Re: [Qemu-devel] [PULL 1/2] spapr: Error out when CPU hotplug is attempted on older pseries machines

2016-08-04 Thread David Gibson
On Thu, Aug 04, 2016 at 04:14:53PM +0530, Bharata B Rao wrote: > On Wed, Aug 03, 2016 at 03:25:50PM +1000, David Gibson wrote: > > From: Bharata B Rao > > > > CPU hotplug and coldplug aren't supported prior to pseries-2.7. Further, > > earlier machine types don't use CPU core objects at all. Th

Re: [Qemu-devel] [PATCH 3/7] vdi: Use QEMU UUID API

2016-08-04 Thread Markus Armbruster
Eric Blake writes: > On 08/04/2016 12:58 PM, Stefan Weil wrote: >> Hi, >> >> On 08/02/16 11:18, Fam Zheng wrote: >>> The QEMU UUID api, including the data structure (qemu_uuid_t), is fully >>> compatible with libuuid. Use it, and remove the unused code. >>> >>> Signed-off-by: Fam Zheng >>> ---

Re: [Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

2016-08-04 Thread Kirti Wankhede
On 8/4/2016 12:51 PM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Thursday, August 04, 2016 3:04 AM >> >> >> 2. Physical device driver interface >> This interface provides vendor driver the set APIs to manage physical >> device related work in their own drive

[Qemu-devel] [RFC PATCH 4/4] Enable aarch64 mttcg litmus tests in travis CI

2016-08-04 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index 881ba9d..f84f800 100644 --- a/.travis.yml +++ b/.travis.yml @@ -33,6 +33,7 @@ addons: - libvte-2.90-dev - sparse - uuid-dev + - gcc-aarch64

[Qemu-devel] [RFC PATCH 1/4] tests/tcg: Add x86 mttcg litmus test

2016-08-04 Thread Pranith Kumar
This adds the x86 store-after-load re-ordering litmus test. Most of the supporting files are mostly unmodified and generated by the litmus tool. Signed-off-by: Pranith Kumar --- tests/tcg/mttcg/x86/Makefile | 42 ++ tests/tcg/mttcg/x86/README.txt| 22 + tests/tcg/mttcg/x86/SAL.c

[Qemu-devel] [RFC PATCH 0/4] Add MTTCG litmus tests

2016-08-04 Thread Pranith Kumar
This patch series adds litmus tests to test that MTTCG is properly following the consistency semantics. This series has the one possible re-ordering test on x86 and some subset of tests for ARM64. We run these tests using the qemu-user binary of the corresponding architecture(set the QEMU env vari

[Qemu-devel] [RFC PATCH 2/4] Enable x86 mttcg litmus tests in travis CI

2016-08-04 Thread Pranith Kumar
Enable the store-after-load litmus test to be run on travis-CI. Signed-off-by: Pranith Kumar --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index f30b10e..881ba9d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -99,3 +99,6 @@ matrix: - sud

[Qemu-devel] something broken in "v2.7.0-rc1" or just a behavior change?

2016-08-04 Thread Dennis Luehring
my scenario works with before "v2.7.0-rc1" git "v2.5.0" OK git "v2.6.0" OK git "v2.7.0-rc0" OK git "v2.7.0-rc1" FAILS [qemu-git] build qemu from git at ~2016/08/04 git rev-parse HEAD 09704e6ded83fa0bec14baf32f800f6512156ca0 [scenario] qemu/sparc64-softmmu/qemu-system-sparc64 --version QEMU emu

Re: [Qemu-devel] [QUESTION]stuck in SeaBIOS because of losing a SMI

2016-08-04 Thread Xulei (Stone)
> > >On 03/08/2016 11:43, Xulei (Stone) wrote: >> Hi, all: >> Recently I use a shell script to continuously reset a vm to see what may >> happen. >> After one day, the vm is stuck. Looking from the following seabios log and >> kvm trace log, it seems like losing a SMI or SeaBIOS can not handle a

[Qemu-devel] [Help]: Does qemu-system-aarch64 support virtio-9p? I got a problem when remap host file to guest in AArch64.

2016-08-04 Thread Kevin Zhao
Hi All, I have a problem may about Qemu and kindly need your help. Does qemu-system-aarch64 support virtio-9p ? Recently I have tried to use qemu remapped the file from host to guest. As I know, Qemu has supported this so long as guest kernel has support 9p(virtfs). Reference to this link

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Fam and Jsnow for Bitmap support

2016-08-04 Thread Fam Zheng
On Thu, 08/04 14:18, John Snow wrote: > These files are currently unmaintained. > > I'm proposing that Fam and I co-maintain them; under the model that > whomever between us isn't authoring a given series will be responsible > for reviewing it. > > Signed-off-by: John Snow > --- > MAINTAINERS |

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-04 Thread kwangwoo....@sk.com
Hi Igor, Thank you for your guide to split the hotplug patch. Currently I'm looking at the Linux kernel codes related with huge page size. > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Tuesday, August 02, 2016 9:18 PM > To: Peter Maydell > Cc: Xiao Guangr

[Qemu-devel] [Bug 1490611]

2016-08-04 Thread Nish Aravamudan
** Attachment added: "attachment" https://bugs.launchpad.net/bugs/1490611/+attachment/4714298/+files/attachment -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1490611 Title: Using qemu >=2.2.1 to

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-08-04 Thread Robie Basak
Rejected: Rejected by Brian Murray: There was a security update to qemu today, so the SRU will need to be redone on top of that. ** Changed in: qemu (Ubuntu Xenial) Status: In Progress => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is s

Re: [Qemu-devel] [PATCH for-2.7 v3 35/36] ahci: fix sglist leak on retry

2016-08-04 Thread John Snow
On 08/04/2016 10:46 AM, Markus Armbruster wrote: John, can you review this one? I'm very sorry for the delay. marcandre.lur...@redhat.com writes: From: Marc-André Lureau ahci-test /x86_64/ahci/io/dma/lba28/retry triggers the following leak: Direct leak of 16 byte(s) in 1 object(s) all

Re: [Qemu-devel] [PATCH 4/4] error: Fix error_printf() calls lacking newlines

2016-08-04 Thread Eric Blake
On 08/03/2016 05:37 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/i386/pc.c | 2 +- > kvm-all.c| 2 +- > ui/vnc.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > I'm guessing these were found with a slight tweak to the Coccinelle script in 1/4?

Re: [Qemu-devel] [PATCH 3/4] vfio: Use error_report() instead of error_printf() for errors

2016-08-04 Thread Eric Blake
On 08/03/2016 05:37 AM, Markus Armbruster wrote: > Cc: Alex Williamson > Signed-off-by: Markus Armbruster > --- > hw/vfio/platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Eric Blake > diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c > index 1798a00..a559e

Re: [Qemu-devel] [PATCH 2/4] checkpatch: Fix newline detection in error_setg() & friends

2016-08-04 Thread Eric Blake
On 08/03/2016 05:37 AM, Markus Armbruster wrote: > Commit 5d596c2's regexp assumes the error message string is the first > argument. Correct for error_report(), wrong for all the others. > Relax the regexp to match newline in anywhere. This might cause > additional false positives. Might, but th

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2016-08-04 Thread Eric Blake
On 08/03/2016 05:37 AM, Markus Armbruster wrote: > Commit 9af9e0f, 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but > they keep coming back. checkpatch.pl tries to flag them since commit > 5d596c2, but it's not very good at it. Offenders tracked down with > Coccinelle script scripts/coccine

[Qemu-devel] [Bug 1609968] [NEW] "cannot set up guest memory" b/c no automatic clearing of Linux' cache

2016-08-04 Thread Celmor
Public bug reported: Version: qemu-2.6.0-1 Kernel: 4.4.13-1-MANJARO Full script (shouldn't matter though): https://pastebin.com/Hp24PWNE Problem: When host has been up and used for a while cache has been filled as much that guest can't be started without droping caches. Expected behavior: Qemu

Re: [Qemu-devel] qtest protocol: should memset/read/write etc of a size of 0 bytes be permitted?

2016-08-04 Thread Eric Blake
On 08/04/2016 12:46 PM, Peter Maydell wrote: > I've upgraded to a more recent version of clang, which now produces > undefined-behaviour warnings for passing NULL pointers to some library > functions. One of the things it has shown up is that some of the > qtest tests ask for "memset" with size zer

Re: [Qemu-devel] [PATCH 3/7] vdi: Use QEMU UUID API

2016-08-04 Thread Eric Blake
On 08/04/2016 12:58 PM, Stefan Weil wrote: > Hi, > > On 08/02/16 11:18, Fam Zheng wrote: >> The QEMU UUID api, including the data structure (qemu_uuid_t), is fully >> compatible with libuuid. Use it, and remove the unused code. >> >> Signed-off-by: Fam Zheng >> --- >> block/vdi.c | 49 +

Re: [Qemu-devel] qtest protocol: should memset/read/write etc of a size of 0 bytes be permitted?

2016-08-04 Thread Peter Maydell
On 4 August 2016 at 19:49, John Snow wrote: > > > On 08/04/2016 02:46 PM, Peter Maydell wrote: >> (2) declare that size == 0 is not valid and make it return a failure >> code back down the qtest pipe (and fix the offending tests) >> > > This is probably the nicer thing to do -- if memset of length

Re: [Qemu-devel] fix incorrect identify implementation in nvme

2016-08-04 Thread Keith Busch
On Thu, Aug 04, 2016 at 09:42:13PM +0200, Christoph Hellwig wrote: > Third resent of this series after this didn't get picked up the > previous times. The Qemu NVMe implementation mistakes the cns > field in the Identify command as a boolean. This was never > true, and is actively harmful since N

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2016 at 11:24:26AM +, Gonglei (Arei) wrote: > > > +The first driver-read-only field, \field{version} specifies the virtio > > > crypto's > > > +version, which is reserved for back-compatibility in future.It's > > > currently > > > +defined for the version field: > > > + > > >

Re: [Qemu-devel] [PATCH] virtio-net: allow increasing rx queue size

2016-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2016 at 09:35:15AM +0200, Cornelia Huck wrote: > On Thu, 4 Aug 2016 02:16:14 +0300 > "Michael S. Tsirkin" wrote: > > > This allows increasing the rx queue size up to 1024: unlike with tx, > > guests don't put in huge S/G lists into RX so the risk of running into > > the max 1024 l

Re: [Qemu-devel] [PATCH v6 0/2] virtio-crypto: virtio crypto device specification

2016-08-04 Thread Michael S. Tsirkin
On Wed, Aug 03, 2016 at 07:23:36PM +0200, Cornelia Huck wrote: > On Wed, 3 Aug 2016 16:53:36 +0200 > Cornelia Huck wrote: > > > On Wed, 3 Aug 2016 17:40:07 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Aug 03, 2016 at 04:33:28PM +0200, Cornelia Huck wrote: > > > > On Wed, 3 Aug 2016 1

[Qemu-devel] fix incorrect identify implementation in nvme

2016-08-04 Thread Christoph Hellwig
Third resent of this series after this didn't get picked up the previous times. The Qemu NVMe implementation mistakes the cns field in the Identify command as a boolean. This was never true, and is actively harmful since NVMe1.1 (which the Qemu device claims to support) supports more than two Ide

Re: [Qemu-devel] [PATCH v2] balloon: Fix failure of updating guest memory status

2016-08-04 Thread Ladi Prosek
On Thu, Aug 4, 2016 at 6:01 PM, Michael S. Tsirkin wrote: > On Thu, Aug 04, 2016 at 05:14:14PM +0200, Ladi Prosek wrote: >> On Wed, Aug 3, 2016 at 9:25 AM, Ladi Prosek wrote: >> > On Tue, Aug 2, 2016 at 2:11 AM, Michael S. Tsirkin wrote: >> >> On Mon, Aug 01, 2016 at 11:59:31PM +, Li, Liang

[Qemu-devel] [PATCH 1/2] nvme: fix identify to be NVMe 1.1 compliant

2016-08-04 Thread Christoph Hellwig
NVMe 1.1 requires devices to implement a Namespace List subcommand of the identify command. Qemu not only not implements this features, but also misinterprets it as an Identify Controller request. Due to this any OS trying to use the Namespace List will fail the probe. Signed-off-by: Christoph H

[Qemu-devel] [PATCH 2/2] nvme: bump PCI revision

2016-08-04 Thread Christoph Hellwig
The broken Identify implementation in earlier Qemu versions means we need to blacklist it from issueing the NVMe 1.1 Identify Namespace List command. As we want to be able to use it in newer Qemu versions we need a way to identify those. Bump the PCI revision as a guest visible indicator of this

Re: [Qemu-devel] [PATCH 3/7] vdi: Use QEMU UUID API

2016-08-04 Thread Stefan Weil
Hi, On 08/02/16 11:18, Fam Zheng wrote: > The QEMU UUID api, including the data structure (qemu_uuid_t), is fully > compatible with libuuid. Use it, and remove the unused code. > > Signed-off-by: Fam Zheng > --- > block/vdi.c | 49 ++--- > 1 file cha

Re: [Qemu-devel] qtest protocol: should memset/read/write etc of a size of 0 bytes be permitted?

2016-08-04 Thread John Snow
On 08/04/2016 02:46 PM, Peter Maydell wrote: I've upgraded to a more recent version of clang, which now produces undefined-behaviour warnings for passing NULL pointers to some library functions. One of the things it has shown up is that some of the qtest tests ask for "memset" with size zero. I

[Qemu-devel] qtest protocol: should memset/read/write etc of a size of 0 bytes be permitted?

2016-08-04 Thread Peter Maydell
I've upgraded to a more recent version of clang, which now produces undefined-behaviour warnings for passing NULL pointers to some library functions. One of the things it has shown up is that some of the qtest tests ask for "memset" with size zero. In our current implementation this results in qtes

Re: [Qemu-devel] [PATCH] ide: fix DMA register transitions

2016-08-04 Thread John Snow
On 08/02/2016 06:05 PM, John Snow wrote: ATA8-APT defines the state transitions for both a host controller and for the hardware device during the lifecycle of a DMA transfer, in section 9.7 "DMA command protocol." One of the interesting tidbits here is that when a device transitions from DDMA0

Re: [Qemu-devel] [PATCH for-2.7] atapi: fix halted DMA reset

2016-08-04 Thread John Snow
On 08/02/2016 02:55 PM, John Snow wrote: Followup to 87ac25fd, this time for ATAPI DMA. Reported-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/atapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 95056d9..6189675 100644 --- a/hw/ide/atapi

[Qemu-devel] [PATCH] MAINTAINERS: Add Fam and Jsnow for Bitmap support

2016-08-04 Thread John Snow
These files are currently unmaintained. I'm proposing that Fam and I co-maintain them; under the model that whomever between us isn't authoring a given series will be responsible for reviewing it. Signed-off-by: John Snow --- MAINTAINERS | 14 ++ 1 file changed, 14 insertions(+) di

[Qemu-devel] [PULL 1/1] Xen PCI passthrough: fix passthrough failure when no interrupt pin

2016-08-04 Thread Stefano Stabellini
From: Bruce Rogers Commit 5a11d0f7 mistakenly converted a log message into an error condition when no pin interrupt is found for the pci device being passed through. Revert that part of the commit. Signed-off-by: Bruce Rogers Signed-off-by: Stefano Stabellini Acked-by: Anthony PERARD --- hw/

[Qemu-devel] xen-20160804-tag

2016-08-04 Thread Stefano Stabellini
t tags/xen-20160804-tag for you to fetch changes up to 0968c91ce00f42487fb11de5da38e53b5dc6bc7f: Xen PCI passthrough: fix passthrough failure when no interrupt pin (2016-08-04 10:42:48 -0700) Xen

Re: [Qemu-devel] [PATCH v4 for-2.7 0/7] Fixing i686 host / sparc64 guest crash

2016-08-04 Thread Richard Henderson
On 08/04/2016 10:07 PM, Peter Maydell wrote: On 4 August 2016 at 17:26, Richard Henderson wrote: This is a revision of my "third" attempt, tweaked a bit for Aurelien's review. I've sort of lost track of where we are with the release process, so I'll understand if we've gone too far now. in

Re: [Qemu-devel] [PATCH v1 5/5] target-ppc: add vector permute right indexed instruction

2016-08-04 Thread Richard Henderson
On 08/04/2016 06:33 PM, Rajalakshmi Srinivasaraghavan wrote: +if (s & 0x10) { +result.u8[i] = a->u8[15 - index]; +} else { +result.u8[i] = b->u8[15 - index]; +} Fold these "15 -" into the computation of index above? r~

Re: [Qemu-devel] [PATCH v1 3/5] target-ppc: add vector count trailing zeros instructions

2016-08-04 Thread Richard Henderson
On 08/04/2016 06:33 PM, Rajalakshmi Srinivasaraghavan wrote: +#define ctzb(v) ((v) ? ctz32((uint32_t)(v)) : 8) +#define ctzh(v) ((v) ? ctz32((uint32_t)(v)) : 16) You don't need these casts. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v1 4/5] target-ppc: add vector bit permute doubleword instruction

2016-08-04 Thread Richard Henderson
On 08/04/2016 06:33 PM, Rajalakshmi Srinivasaraghavan wrote: +uint64_t perm = 0; Move the variable inside the loop. +VECTOR_FOR_INORDER_I(i, u64) { +perm = 0; +VECTOR_FOR_INORDER_I(j, u16) { Surely this is more clearly written as for (j = 0; j < 8; ++j) since u16

Re: [Qemu-devel] [PATCH v4 for-2.7 0/7] Fixing i686 host / sparc64 guest crash

2016-08-04 Thread Peter Maydell
On 4 August 2016 at 17:26, Richard Henderson wrote: > This is a revision of my "third" attempt, tweaked a bit for Aurelien's > review. I've sort of lost track of where we are with the release process, > so I'll understand if we've gone too far now. > include/exec/gen-icount.h | 2 +- > includ

Re: [Qemu-devel] [PATCH v1 2/5] target-ppc: add vector extract instructions

2016-08-04 Thread Richard Henderson
On 08/04/2016 06:33 PM, Rajalakshmi Srinivasaraghavan wrote: +#define VEXTRACT(suffix, element, index) \ +void helper_vextract##suffix(ppc_avr_t *r, ppc_avr_t *b, uint32_t splat) \ +{

Re: [Qemu-devel] [PATCH v1 1/5] target-ppc: add vector insert instructions

2016-08-04 Thread Richard Henderson
On 08/04/2016 06:33 PM, Rajalakshmi Srinivasaraghavan wrote: +#if defined(HOST_WORDS_BIGENDIAN) +#define VINSERT(suffix, element, index) \ +void helper_vinsert##suffix(ppc_avr_t *r, ppc_avr_t *b, uint32_t splat) \ +{

[Qemu-devel] [PATCH v4 for-2.7 7/7] tcg: Lower indirect registers in a separate pass

2016-08-04 Thread Richard Henderson
Rather than rely on recursion during the middle of register allocation, lower indirect registers to loads and stores off the indirect base into plain temps. For an x86_64 host, with sufficient registers, this results in identical code, modulo the actual register assignments. For an i686 host, wit

[Qemu-devel] [PATCH v4 for-2.7 4/7] tcg: Compress dead_temps and mem_temps into a single array

2016-08-04 Thread Richard Henderson
We only need two bits per temporary. Fold the two bytes into one, and reduce the memory and cachelines required during compilation. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 119 +++--- 1 file changed, 6

[Qemu-devel] [PATCH v4 for-2.7 5/7] tcg: Include liveness info in the dumps

2016-08-04 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- include/qemu/log.h | 2 +- tcg/tcg.c | 68 +- util/log.c | 19 ++- 3 files changed, 61 insertions(+), 28 deletions(-) diff --git a/include/qemu/log.

[Qemu-devel] [PATCH v4 for-2.7 6/7] tcg: Require liveness analysis

2016-08-04 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 21 - 1 file changed, 21 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index b0a88ba..3c1f526 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -23,7 +23,6 @@ */ /* define it to use liveness analysis

[Qemu-devel] [PATCH v4 for-2.7 3/7] tcg: Fold life data into TCGOp

2016-08-04 Thread Richard Henderson
Reduce the size of other bitfields to make room. This reduces the cache footprint of compilation. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 9 +++-- tcg/tcg.h | 26 ++ 2 files changed, 17 insertions(+), 18 deletions(-) diff --git

[Qemu-devel] [PATCH v4 for-2.7 2/7] tcg: Reorg TCGOp chaining

2016-08-04 Thread Richard Henderson
Instead of using -1 as end of chain, use 0, and link through the 0 entry as a fully circular double-linked list. Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 2 +- tcg/optimize.c| 8 ++-- tcg/tcg-op.c | 2 +- tcg/tcg.c | 35

[Qemu-devel] [PATCH v4 for-2.7 1/7] tcg: Compress liveness data to 16 bits

2016-08-04 Thread Richard Henderson
This reduces both memory usage and per-insn cacheline usage during code generation. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 58 ++ tcg/tcg.h | 16 ++-- 2 files changed, 32 insertions(+), 42

[Qemu-devel] [PATCH v4 for-2.7 0/7] Fixing i686 host / sparc64 guest crash

2016-08-04 Thread Richard Henderson
This is a revision of my "third" attempt, tweaked a bit for Aurelien's review. I've sort of lost track of where we are with the release process, so I'll understand if we've gone too far now. r~ Richard Henderson (7): tcg: Compress liveness data to 16 bits tcg: Reorg TCGOp chaining tcg: F

Re: [Qemu-devel] [PATCH v2] balloon: Fix failure of updating guest memory status

2016-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2016 at 05:14:14PM +0200, Ladi Prosek wrote: > On Wed, Aug 3, 2016 at 9:25 AM, Ladi Prosek wrote: > > On Tue, Aug 2, 2016 at 2:11 AM, Michael S. Tsirkin wrote: > >> On Mon, Aug 01, 2016 at 11:59:31PM +, Li, Liang Z wrote: > >>> > On Wed, Jul 06, 2016 at 12:49:06PM +, Li, L

Re: [Qemu-devel] [PATCH 1/2] ide: ide-cd without drive property for empty drive

2016-08-04 Thread Eric Blake
On 08/01/2016 01:47 PM, Kevin Wolf wrote: > Am 14.07.2016 um 21:48 hat Eric Blake geschrieben: >> On 07/14/2016 07:49 AM, Kevin Wolf wrote: >>> This allows to create an empty ide-cd device without manually creating a >>> BlockBackend. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> hw/ide/qdev.c |

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Daniel P. Berrange
On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to maintain

Re: [Qemu-devel] [PATCH for-2.7 v2] block/qdev: Let 'drive' property fall back to node name

2016-08-04 Thread Eric Blake
On 08/04/2016 06:09 AM, Kevin Wolf wrote: > If a qdev block device is created with an anonymous BlockBackend (i.e. > a node name rather than a BB name was given for the drive property), > qdev used to return an empty string when the property was read. This > patch fixes it to return the node name i

Re: [Qemu-devel] [Qemu-block] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Jeff Cody
On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to maintain

Re: [Qemu-devel] [PATCH v2 for-2.7] Update ancient copyright string in -version output

2016-08-04 Thread Eric Blake
On 08/04/2016 05:14 AM, Peter Maydell wrote: > Currently the -version command line argument prints a string ending > with "Copyright (c) 2003-2008 Fabrice Bellard". This is now some > eight years out of date; abstract it out of the several places that > print the string and update it to: > > Copy

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-08-04 Thread Nish Aravamudan
On 04.08.2016 [10:49:47 -], Robie Basak wrote: > Uploaded to Xenial, thanks. Am I right in thinking that the new option > force_size is required to be used with the patch to fix the problem? > It's probably worth mentioning this in the Test Case in the bug > description; otherwise it will appea

Re: [Qemu-devel] [PATCH for-2.7 v3 17/36] machine: use class base init generated name

2016-08-04 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Aug 4, 2016 at 5:58 PM Markus Armbruster wrote: > >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Remove machine class name initialization from DEFINE_PC_MACHINE, rely on >> > class base init name generation instead. Ge

Re: [Qemu-devel] [PATCH v2] balloon: Fix failure of updating guest memory status

2016-08-04 Thread Ladi Prosek
On Wed, Aug 3, 2016 at 9:25 AM, Ladi Prosek wrote: > On Tue, Aug 2, 2016 at 2:11 AM, Michael S. Tsirkin wrote: >> On Mon, Aug 01, 2016 at 11:59:31PM +, Li, Liang Z wrote: >>> > On Wed, Jul 06, 2016 at 12:49:06PM +, Li, Liang Z wrote: >>> > > > > > > After live migration, 'guest-stats' can

Re: [Qemu-devel] [PATCH for-2.7 v3 32/36] tests: add qtest_add_data_func_full

2016-08-04 Thread Marc-André Lureau
Hi - Original Message - > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Allows one to specify a destroy function for the test data. > > > > Signed-off-by: Marc-André Lureau > > --- > > tests/libqtest.c | 15 +++ > > tests/libqtest.h | 7 ++-

Re: [Qemu-devel] [PATCH for-2.7 v3 03/36] qga: free the whole blacklist

2016-08-04 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > Hi > > > > - Original Message - > >> Copying the QGA maintainer. > >> > >> marcandre.lur...@redhat.com writes: > >> > >> > From: Marc-André Lureau > >> > > >> > Free the list, not just the elements. > >> > > >> > Signed

Re: [Qemu-devel] [PATCH for-2.7 v3 32/36] tests: add qtest_add_data_func_full

2016-08-04 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Allows one to specify a destroy function for the test data. > > Signed-off-by: Marc-André Lureau > --- > tests/libqtest.c | 15 +++ > tests/libqtest.h | 7 ++- > 2 files changed, 21 insertions(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH for-2.7 v3 35/36] ahci: fix sglist leak on retry

2016-08-04 Thread Markus Armbruster
John, can you review this one? marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > ahci-test /x86_64/ahci/io/dma/lba28/retry triggers the following leak: > > Direct leak of 16 byte(s) in 1 object(s) allocated from: > #0 0x7fc4b2a25e20 in malloc (/lib64/libasan.so.3+0xc6e20) >

Re: [Qemu-devel] [PATCH for-2.7 v3 23/36] pc: keep gsi reference

2016-08-04 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Further cleanup would need to call qemu_free_irq() at the appropriate > time, but for now this silences ASAN about direct leaks. > > Signed-off-by: Marc-André Lureau I looked into cleaning up the qemu_irq allocation mess long ago

Re: [Qemu-devel] [PATCH for-2.7 v3 03/36] qga: free the whole blacklist

2016-08-04 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Copying the QGA maintainer. >> >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Free the list, not just the elements. >> > >> > Signed-off-by: Marc-André Lureau >> > --- >> > include/glib-compa

Re: [Qemu-devel] [Patch v1 25/29] qmp: add QMP interface "query-cpu-model-comparison"

2016-08-04 Thread Eduardo Habkost
On Thu, Aug 04, 2016 at 09:34:16AM +0200, David Hildenbrand wrote: > ## > > # @CpuModelCompareResult: > > #

Re: [Qemu-devel] [Patch v1 26/29] qmp: add QMP interface "query-cpu-model-baseline"

2016-08-04 Thread Eduardo Habkost
On Thu, Aug 04, 2016 at 09:32:22AM +0200, David Hildenbrand wrote: > ## > > # @query-cpu-model-baseline: > > #

Re: [Qemu-devel] [PATCH for-2.7 v3 17/36] machine: use class base init generated name

2016-08-04 Thread Marc-André Lureau
Hi On Thu, Aug 4, 2016 at 5:58 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Remove machine class name initialization from DEFINE_PC_MACHINE, rely on > > class base init name generation instead. Get rid of some leaks that way. > > > > Si

[Qemu-devel] [PULL 2/5] linux-user: Fix memchr() argument in open_self_cmdline()

2016-08-04 Thread riku . voipio
From: Peter Maydell In open_self_cmdline() we look for a 0 in the buffer we read from /prc/self/cmdline. We were incorrectly passing the length of our buf[] array to memchr() as the length to search, rather than the number of bytes we actually read into it, which could be shorter. This was spotte

[Qemu-devel] [PULL 4/5] linux-user: Fix target_semid_ds structure definition

2016-08-04 Thread riku . voipio
From: Peter Maydell The target_semid_ds structure is not correct for all architectures: the padding fields should only exist for: * 32-bit ABIs * x86 It is also misnamed, since it is following the kernel semid64_ds structure (QEMU doesn't support the legacy semid_ds structure at all). Rename t

[Qemu-devel] [PULL 0/5] linux-user fixes for 2.7

2016-08-04 Thread riku . voipio
iku.voipio/qemu.git tags/pull-linux-user-20160804 for you to fetch changes up to ef4330c23bb47b97a859dbdbae1c784fd2ca402f: linux-user: Handle brk() attempts with very large sizes (2016-08-04 16:38:17 +0300) linux-user important fix

[Qemu-devel] [PULL 1/5] linux-user: Use correct alignment for long long on i386 guests

2016-08-04 Thread riku . voipio
From: Peter Maydell For i386, the ABI specifies that 'long long' (8 byte values) need only be 4 aligned, but we were requiring them to be 8-aligned. This meant we were laying out the target_epoll_event structure wrongly. Add a suitable ifdef to abitypes.h to specify the i386-specific alignment re

[Qemu-devel] [PULL 5/5] linux-user: Handle brk() attempts with very large sizes

2016-08-04 Thread riku . voipio
From: Peter Maydell In do_brk(), we were inadvertently truncating the size of a requested brk() from the guest by putting it into an 'int' variable. This meant that we would incorrectly report success back to the guest rather than a failed allocation, typically resulting in the guest then segfaul

[Qemu-devel] [PULL 3/5] linux-user: Don't write off end of new_utsname buffer

2016-08-04 Thread riku . voipio
From: Peter Maydell Use g_strlcpy() rather than strcpy() to copy the uname string into the structure we return to the guest for the uname syscall. This avoids overrunning the buffer if the user passed us an overlong string via the QEMU command line. We fix a comment typo while we're in the neigh

Re: [Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin

2016-08-04 Thread Anthony PERARD
On Wed, Jul 27, 2016 at 09:30:48AM -0600, Bruce Rogers wrote: > Commit 5a11d0f7 mistakenly converted a log message into an error > condition when no pin interrupt is found for the pci device being > passed through. Revert that part of the commit. > > Signed-off-by: Bruce Rogers Acked-by: Anthony

[Qemu-devel] [PATCH v2] trace: add syslog tracing backend

2016-08-04 Thread Paul Durrant
This patch adds a tracing backend which sends output using syslog(). The syslog backend is limited to POSIX compliant systems. openlog() is called with facility set to LOG_DAEMON, with the LOG_PID option. Trace events are logged at level LOG_INFO. Signed-off-by: Paul Durrant Cc: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH for-2.7 v3 17/36] machine: use class base init generated name

2016-08-04 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Remove machine class name initialization from DEFINE_PC_MACHINE, rely on > class base init name generation instead. Get rid of some leaks that way. > > Signed-off-by: Marc-André Lureau > --- > hw/core/machine.c| 1 + > includ

Re: [Qemu-devel] [PATCH for-2.7 v3 03/36] qga: free the whole blacklist

2016-08-04 Thread Marc-André Lureau
Hi - Original Message - > Copying the QGA maintainer. > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Free the list, not just the elements. > > > > Signed-off-by: Marc-André Lureau > > --- > > include/glib-compat.h | 9 + > > qga/main.c

Re: [Qemu-devel] [PATCH for-2.7 v3 04/36] qga: free remaining leaking state

2016-08-04 Thread Markus Armbruster
Copying the QGA maintainer. marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > qga/guest-agent-command-state.c | 7 +++ > qga/guest-agent-core.h | 1 + > qga/main.c | 6 ++ > 3 files changed, 14 inser

Re: [Qemu-devel] [PATCH for-2.7 v3 03/36] qga: free the whole blacklist

2016-08-04 Thread Markus Armbruster
Copying the QGA maintainer. marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Free the list, not just the elements. > > Signed-off-by: Marc-André Lureau > --- > include/glib-compat.h | 9 + > qga/main.c| 8 ++-- > 2 files changed, 11 insertions(+), 6 del

[Qemu-devel] [PATCH v1 3/5] target-ppc: add vector count trailing zeros instructions

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
The following vector count trailing zeros instructions are added from ISA 3.0. vctzb - Vector Count Trailing Zeros Byte vctzh - Vector Count Trailing Zeros Halfword vctzw - Vector Count Trailing Zeros Word vctzd - Vector Count Trailing Zeros Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan

[Qemu-devel] [PATCH v1 0/5] POWER9 TCG enablement - part3

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
This series contains 14 new instructions for POWER9 described in ISA3.0. Patches: 01: Adds vector insert instructions. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doub

[Qemu-devel] [PATCH v1 2/5] target-ppc: add vector extract instructions

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
The following vector extract instructions are added from ISA 3.0. vextractub - Vector Extract Unsigned Byte vextractuh - Vector Extract Unsigned Halfword vextractuw - Vector Extract Unsigned Word vextractd - Vector Extract Unsigned Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- tar

[Qemu-devel] [PATCH v1 1/5] target-ppc: add vector insert instructions

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
The following vector insert instructions are added from ISA 3.0. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |4 target

[Qemu-devel] [PATCH v1 5/5] target-ppc: add vector permute right indexed instruction

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
Add vpermr instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 23 +++ target-ppc/translate/vmx-impl.c | 18 ++ target-ppc/translate/vmx-ops.c |1 + 4 f

[Qemu-devel] [PATCH v1 4/5] target-ppc: add vector bit permute doubleword instruction

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
Add vbpermd instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 20 target-ppc/translate/vmx-impl.c |1 + target-ppc/translate/vmx-ops.c |1 + 4 files changed, 23 in

[Qemu-devel] [RESEND PATCH V5 2/6] coroutine: add a macro for the coroutine stack size

2016-08-04 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- include/qemu/coroutine_int.h | 2 ++ util/coroutine-sigaltstack.c | 2 +- util/coroutine-ucontext.c| 2 +- util/coroutine-win32.c | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Marc-André Lureau
Hi On Thu, Aug 4, 2016 at 4:44 PM Paolo Bonzini wrote: > > > On 03/08/2016 04:36, Fam Zheng wrote: > > On Tue, 08/02 15:45, Paolo Bonzini wrote: > >> > >> > >> - Original Message - > >>> From: "Fam Zheng" > >>> To: qemu-devel@nongnu.org > >>> Cc: f...@redhat.com, berra...@redhat.com, pb

[Qemu-devel] [RESEND PATCH V5 5/6] oslib-posix: add a configure switch to debug stack usage

2016-08-04 Thread Peter Lieven
this adds a knob to track the maximum stack usage of stacks created by qemu_alloc_stack. Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini --- configure | 19 +++ util/oslib-posix.c | 37 + 2 files changed, 56 insertions(+) diff

[Qemu-devel] [RESEND PATCH V5 1/6] oslib-posix: add helpers for stack alloc and free

2016-08-04 Thread Peter Lieven
the allocated stack will be adjusted to the minimum supported stack size by the OS and rounded up to be a multiple of the system pagesize. Additionally an architecture dependent guard page is added to the stack to catch stack overflows. Signed-off-by: Peter Lieven Reviewed-by: Eric Blake --- in

[Qemu-devel] [RESEND PATCH V5 3/6] coroutine-ucontext: use helper for allocating stack memory

2016-08-04 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- util/coroutine-ucontext.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c index 31254ab..b7dea8c 100644 --- a/util/corouti

[Qemu-devel] [RESEND PATCH V5 4/6] coroutine-sigaltstack: use helper for allocating stack memory

2016-08-04 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- util/coroutine-sigaltstack.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c index 9c2854c..ccf4861 100644 --- a/util/

[Qemu-devel] [RESEND PATCH V5 6/6] coroutine: reduce stack size to 64kB

2016-08-04 Thread Peter Lieven
evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 64kB which should still give enough head room. The guard page added i

  1   2   >