[Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-10 Thread P J P
From: Prasad J Pandit At various places in 9pfs back-end, it creates full path by concatenating two path strings. It could lead to a path traversal issue if one of the parameter was a relative path. Add check to avoid it. Reported-by: Felix Wilhelm

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

2016-08-10 Thread Peter Xu
On Wed, Aug 10, 2016 at 10:51:51AM +0200, Igor Mammedov wrote: [...] > > > Upstream guest kernel 4.7.0+ (d52bd54db) crashes when booting with irq > > > remapping on: > > > > > > ./qemu-system-x86_64 -enable-kvm -smp > > > 1,sockets=9,cores=32,threads=1,maxcpus=288 -device > > >

[Qemu-devel] [PATCH v4 8/9] vl: Switch qemu_uuid to QemuUUID

2016-08-10 Thread Fam Zheng
Update all qemu_uuid users as well, especially get rid of the duplicated low level g_strdup_printf, sscanf and snprintf calls with QEMU UUID API. Since qemu_uuid_parse is quite tangled with qemu_uuid, it's switching to QemuUUID is done here too to keep everything in sync and avoid code churn.

[Qemu-devel] [PATCH v4 9/9] tests: Add uuid tests

2016-08-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/Makefile.include | 2 + tests/test-uuid.c | 173 + 2 files changed, 175 insertions(+) create mode 100644 tests/test-uuid.c diff --git a/tests/Makefile.include b/tests/Makefile.include

[Qemu-devel] [PATCH v4 5/9] crypto: Switch to QEMU UUID API

2016-08-10 Thread Fam Zheng
The uuid generation doesn't return error, so update the function signature and calling code accordingly. Signed-off-by: Fam Zheng --- crypto/block-luks.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/crypto/block-luks.c

[Qemu-devel] [PATCH v4 7/9] configure: Remove detection code for UUID

2016-08-10 Thread Fam Zheng
All code now uses built-in UUID implementation. Remove the code of libuuid and make --enable-uuid and --disable-uuid only print a message. Signed-off-by: Fam Zheng --- configure | 43 --- 1 file changed, 4 insertions(+), 39 deletions(-)

[Qemu-devel] [PATCH v4 6/9] tests: No longer dependent on CONFIG_UUID

2016-08-10 Thread Fam Zheng
crypto now uses built-in uuid implementation, so this check is not needed. Signed-off-by: Fam Zheng --- tests/test-crypto-block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-crypto-block.c b/tests/test-crypto-block.c index a38110d..1957a86

[Qemu-devel] [PATCH v4 4/9] vpc: Use QEMU UUID API

2016-08-10 Thread Fam Zheng
Previously we conditionally generated footer->uuid, when libuuid was available. Now that we have a built-in implementation, we can switch to it. Signed-off-by: Fam Zheng --- block/vpc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/block/vpc.c

[Qemu-devel] [PATCH v4 3/9] vdi: Use QEMU UUID API

2016-08-10 Thread Fam Zheng
The UUID operations we need from libuuid is fully supported by QEMU UUID implementation. Use it, and remove the unused code. Signed-off-by: Fam Zheng --- block/vdi.c | 73 ++--- 1 file changed, 17 insertions(+), 56

[Qemu-devel] [PATCH v4 2/9] vhdx: Use QEMU UUID API

2016-08-10 Thread Fam Zheng
This removes our dependency to libuuid, so that the driver can always be built. Similar to how we handled data plane configure options, --enable-vhdx and --disable-vhdx are also changed to a nop with a message saying it's obsolete. Signed-off-by: Fam Zheng ---

[Qemu-devel] [PATCH v4 1/9] util: Add UUID API

2016-08-10 Thread Fam Zheng
A number of different places across the code base use CONFIG_UUID. Some of them are soft dependency, some are not built if libuuid is not available, some come with dummy fallback, some throws runtime error. It is hard to maintain, and hard to reason for users. Since UUID is a simple standard

[Qemu-devel] [PATCH v4 0/9] UUID clean ups for 2.8

2016-08-10 Thread Fam Zheng
v4: Use memcpy instead of pointer type cast. [Richard] Keep parameter order consistent with libuuid. [Jeff] qemu_uuid_convert -> qemu_uuid_bswap. [Jeff] v3: Negative tests. [Daniel] Update QemuUUID type from array to struct. [Markus] Add qemu_uuid_unparse_strdup. Add

Re: [Qemu-devel] [PATCH v4 00/17] qapi: remove the 'middle' mode

2016-08-10 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v4 00/17] qapi: remove the 'middle' mode Message-id: 20160810180235.32469-1-marcandre.lur...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v3 1/9] util: Add UUID API

2016-08-10 Thread Fam Zheng
On Wed, 08/10 16:25, Richard Henderson wrote: > On 08/09/2016 12:19 PM, Fam Zheng wrote: > >+/* Version 4 UUID (pseudo random numbers), RFC4122 4.4. */ > >+ > >+typedef struct { > >+unsigned char data[16]; > >+} QemuUUID; > ... > >+void qemu_uuid_generate(QemuUUID *uuid) > >+{ > >+int i; >

Re: [Qemu-devel] [PATCH] migration: fix live migration failure with compression

2016-08-10 Thread Amit Shah
On (Wed) 10 Aug 2016 [18:58:21], Dr. David Alan Gilbert wrote: > * Li, Liang Z (liang.z...@intel.com) wrote: > > > Subject: Re: [PATCH] migration: fix live migration failure with > > > compression > > > > > > * Liang Li (liang.z...@intel.com) wrote: > > > > Because of commit 11808bb0c422, which

[Qemu-devel] [PATCH v7 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-10 Thread Gonglei
The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). The virtio crypto device can provide five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. Signed-off-by: Gonglei

[Qemu-devel] [PATCH v7 0/2] virtio-crypto: virtio crypto device specific

2016-08-10 Thread Gonglei
This is the specification (version 7) about a new virtio crypto device. If you have any comments, please let me know, thanks :) CC: Michael S. Tsirkin CC: Cornelia Huck CC: Stefan Hajnoczi CC: Lingli Deng

[Qemu-devel] [PATCH v7 2/2] virtio-crypto: Add conformance clauses

2016-08-10 Thread Gonglei
Add the conformance targets and clauses for virtio-crypto device. Signed-off-by: Gonglei --- conformance.tex | 30 ++ 1 file changed, 30 insertions(+) diff --git a/conformance.tex b/conformance.tex index f59e360..915a9f0 100644 ---

[Qemu-devel] [PATCH] qemu-img: change opening method for the output in dd

2016-08-10 Thread Reda Sallahi
dd was creating an output image regardless of whether there was one already created. With this patch we try to open first the output image and resize it if necessary. Signed-off-by: Reda Sallahi --- Depends on: [PATCH v2] qemu-img: add conv=notrunc option to dd qemu-img.c

[Qemu-devel] [PATCH v2] qemu-img: add conv=notrunc option to dd

2016-08-10 Thread Reda Sallahi
This adds the conv=notrunc option to dd which tells dd to not truncate the output. For the time being we make it mandatory to specify conv=notrunc. Signed-off-by: Reda Sallahi --- Depends on: [PATCH v5] qemu-img: add skip option to dd Changes from v1: * Added comment

Re: [Qemu-devel] [PATCH 2/2] intel-iommu: restrict EIM to quirkless KVM

2016-08-10 Thread Peter Xu
On Wed, Aug 10, 2016 at 06:59:14PM +0200, Radim Krčmář wrote: > 2016-08-10 11:29+0800, Peter Xu: > > On Tue, Aug 09, 2016 at 05:03:33PM +0200, Radim Krčmář wrote: > >> APIC in QEMU doesn't support x2APIC so exposing EIM is pointless and KVM > >> has a quirk that needs to be disabled unless we want

Re: [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-10 Thread Fam Zheng
On Wed, 08/10 21:06, Max Reitz wrote: > On 10.08.2016 21:04, Colin Lord wrote: > > On 08/10/2016 02:37 PM, Max Reitz wrote: > >> On 08.08.2016 20:07, Colin Lord wrote: > >>> From: Marc Mari > >>> > >>> Extend the current module interface to allow for block drivers to be > >>>

Re: [Qemu-devel] [PATCH] docker: Add a glib2-2.22 image

2016-08-10 Thread Fam Zheng
On Tue, 08/09 10:15, Fam Zheng wrote: > It's a variation of our existing centos6, plus two more lines to > downgrade glib2 to version 2.22 which we download from vault.centos.org. > > Suggested-by: Paolo Bonzini > Signed-off-by: Fam Zheng > --- >

Re: [Qemu-devel] [PATCH] qemu-img: add conv=notrunc option to dd

2016-08-10 Thread Fam Zheng
On Thu, 08/11 05:07, Reda Sallahi wrote: > This adds the conv=notrunc option to dd which tells dd to not truncate the > output. > > For the time being we make it mandatory to specify conv=notrunc. > > Signed-off-by: Reda Sallahi > --- > qemu-img-cmds.hx | 4 ++-- >

Re: [Qemu-devel] [PATCH for 2.7] ppc: parse cpu features once

2016-08-10 Thread Bharata B Rao
On Wed, Aug 10, 2016 at 09:08:01PM +0200, Cédric Le Goater wrote: > From: Greg Kurz > > Considering that features are converted to global properties and > global properties are automatically applied to every new instance > of created CPU (at object_new() time), there is no point

[Qemu-devel] [PATCH] qemu-img: add conv=notrunc option to dd

2016-08-10 Thread Reda Sallahi
This adds the conv=notrunc option to dd which tells dd to not truncate the output. For the time being we make it mandatory to specify conv=notrunc. Signed-off-by: Reda Sallahi --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 31 ---

Re: [Qemu-devel] [PATCH for-2.8] dmg: Move the driver to block-obj-y

2016-08-10 Thread Fam Zheng
On Wed, 08/10 20:30, Max Reitz wrote: > On 03.08.2016 10:01, Fam Zheng wrote: > > dmg.o was moved to block-obj-m in 5505e8b76 to become a separate module, > > so that its reference to libbz2, since 6b383c08c, doesn't add an extra > > library to the main executable. > > > > We are working on

Re: [Qemu-devel] [QUESTION]stuck in SeaBIOS and vm cannot be reset any more

2016-08-10 Thread Xulei (Stone)
> On 09/08/2016 10:04, Xulei (Stone) wrote: > > Following your suggestion, i'm now sure it is caused by missing SMI. > > I have tried adding dprintf() like this: > > > > --- a/roms/seabios/src/fw/smm.c > > +++ b/roms/seabios/src/fw/smm.c > > @@ -65,7 +65,8 @@ handle_smi(u16 cs) > > u8 cmd

Re: [Qemu-devel] [PATCH repost] virtio-balloon: Remove needless precompiled directive

2016-08-10 Thread Li, Liang Z
> On Tue, Aug 09, 2016 at 08:30:42AM +0800, Liang Li wrote: > > Since there in wrapper around madvise(), the virtio-balloon code is > > able to work without the precompiled directive, the directive can be > > removed. > > > > Signed-off-by: Liang Li > > Suggested-by: Thomas

Re: [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation

2016-08-10 Thread Brad Smith
On 08/08/16 12:11, Peter Maydell wrote: The various host OSes are irritatingly variable about the name of the linker emulation we need to pass to ld's -m option to build the i386 option ROMs. Instead of doing this via a CONFIG ifdef, check in configure whether any of the emulation names we know

Re: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks

2016-08-10 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1470817370-145190-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks

2016-08-10 Thread Fam Zheng
On Wed, 08/10 16:56, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > === OUTPUT BEGIN === > Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' > Cloning into 'dtc'... > Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf' > BUILD

Re: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks

2016-08-10 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks Message-id: 1470817370-145190-1-git-send-email-pbonz...@redhat.com

Re: [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation

2016-08-10 Thread Brad Smith
On 08/08/16 12:11, Peter Maydell wrote: The various host OSes are irritatingly variable about the name of the linker emulation we need to pass to ld's -m option to build the i386 option ROMs. Instead of doing this via a CONFIG ifdef, check in configure whether any of the emulation names we know

Re: [Qemu-devel] [PULL 1/1] Add optionrom compatible with fw_cfg DMA version

2016-08-10 Thread Brad Smith
On 08/08/16 04:50, Paolo Bonzini wrote: On 07/08/2016 01:53, Brad Smith wrote: On 07/14/16 09:52, Paolo Bonzini wrote: diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile index 2cdda87..d88ce11 100644 --- a/pc-bios/optionrom/Makefile +++ b/pc-bios/optionrom/Makefile @@ -9,22

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-10 Thread Alex Williamson
On Thu, 11 Aug 2016 02:53:10 +0530 Kirti Wankhede wrote: > On 8/10/2016 12:30 AM, Alex Williamson wrote: > > On Thu, 4 Aug 2016 00:33:52 +0530 > > Kirti Wankhede wrote: > > > > ... > > >> + > >> + switch (info.index) { > >> +

[Qemu-devel] [Bug 1611979] [NEW] GTK+ interface, backspace is broken in the monitor console

2016-08-10 Thread Bug Report
Public bug reported: this has been broken for over 2 years ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1611979 Title: GTK+

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-10 Thread Kirti Wankhede
On 8/10/2016 12:30 AM, Alex Williamson wrote: > On Thu, 4 Aug 2016 00:33:52 +0530 > Kirti Wankhede wrote: > ... >> + >> +switch (info.index) { >> +case VFIO_PCI_CONFIG_REGION_INDEX: >> +case VFIO_PCI_BAR0_REGION_INDEX ...

[Qemu-devel] [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-10 Thread P J P
From: Li Qiang When net transport abstraction layer initialises the pkt, the maximum fragmentation count is not checked. This could lead to an integer overflow causing a NULL pointer dereference. Add check to avoid it. Reported-by: Li Qiang Signed-off-by:

[Qemu-devel] [V1 2/4] hw/iommu: AMD IOMMU interrupt remapping

2016-08-10 Thread David Kiarie
Introduce AMD IOMMU interrupt remapping and hook it onto the existing interrupt remapping infrastructure Signed-off-by: David Kiarie --- hw/i386/amd_iommu.c | 226 +++- hw/i386/amd_iommu.h | 2 + 2 files changed, 227

[Qemu-devel] [V1 4/4] hw/iommu: share common between IOMMUs

2016-08-10 Thread David Kiarie
Enabling interrupt remapping with kernel_irqchip=on should result in error for both VT-d and AMD-Vi Signed-off-by: David Kiarie --- hw/i386/intel_iommu.c | 9 - hw/i386/x86-iommu.c | 8 2 files changed, 8 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [V1 0/4] AMD-Vi Interrupt Remapping

2016-08-10 Thread David Kiarie
On Wed, Aug 10, 2016 at 10:42 PM, David Kiarie wrote: Sorry, forgot to cc Peter. Hello all, > > The following patchset adds AMD-Vi interrupt remapping logic > to Qemu and hooks it onto existing interrupt remapping infrastructure.It > has > a dependency on "Explicit SID

[Qemu-devel] [V1 3/4] hw/acpi: report IOAPIC on IVRS

2016-08-10 Thread David Kiarie
Report IOAPIC via IVRS which effectively allows linux AMD-Vi driver to enable interrupt remapping Signed-off-by: David Kiarie --- hw/i386/acpi-build.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 49bd183..da602c3

[Qemu-devel] [V1 1/4] hw/iommu: Prepare for AMD IOMMU interrupt remapping

2016-08-10 Thread David Kiarie
Introduce macros and trace events for use in AMD IOMMU interrupt remapping Signed-off-by: David Kiarie --- hw/i386/amd_iommu.h | 72 hw/i386/trace-events | 7 + 2 files changed, 79 insertions(+) diff --git

[Qemu-devel] [V1 0/4] AMD-Vi Interrupt Remapping

2016-08-10 Thread David Kiarie
Hello all, The following patchset adds AMD-Vi interrupt remapping logic to Qemu and hooks it onto existing interrupt remapping infrastructure.It has a dependency on "Explicit SID for IOAPIC" patchset though. I would appreciate your feedback! For quick testing https://github.com/aslaq/qemu IR

Re: [Qemu-devel] [Qemu-block] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-10 Thread Colin Lord
On 08/10/2016 03:24 PM, Colin Lord wrote: > On 08/10/2016 03:04 PM, Colin Lord wrote: >> On 08/10/2016 02:37 PM, Max Reitz wrote: >>> On 08.08.2016 20:07, Colin Lord wrote: From: Marc Mari Extend the current module interface to allow for block drivers to be

Re: [Qemu-devel] [RFC PATCH 1/4] tests/tcg: Add x86 mttcg litmus test

2016-08-10 Thread Pranith Kumar
Alex Bennée writes: > Pranith Kumar writes: > >> This adds the x86 store-after-load re-ordering litmus test. >> >> Most of the supporting files are mostly unmodified and generated by >> the litmus tool. >> >> Signed-off-by: Pranith Kumar >> --- >>

[Qemu-devel] [PATCH] qht: support resetting an uninitialized qht

2016-08-10 Thread Emilio G. Cota
tb_flush() is called when debugging the guest (under both KVM and TCG accelerators) with gdb. tb_flush() resets TCG's qht, which segfaults if we're using KVM due to the qht not being initialized. Fix this adding a magic number field to struct qht to track whether a qht has been initialized with

Re: [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-10 Thread Max Reitz
On 10.08.2016 21:04, Colin Lord wrote: > On 08/10/2016 02:37 PM, Max Reitz wrote: >> On 08.08.2016 20:07, Colin Lord wrote: >>> From: Marc Mari >>> >>> Extend the current module interface to allow for block drivers to be >>> loaded dynamically on request. The only block drivers

Re: [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-10 Thread Colin Lord
On 08/10/2016 03:04 PM, Colin Lord wrote: > On 08/10/2016 02:37 PM, Max Reitz wrote: >> On 08.08.2016 20:07, Colin Lord wrote: >>> From: Marc Mari >>> >>> Extend the current module interface to allow for block drivers to be >>> loaded dynamically on request. The only block

Re: [Qemu-devel] [PATCH v7 4/4] blockdev: Modularize nfs block driver

2016-08-10 Thread Colin Lord
On 08/10/2016 03:04 PM, Max Reitz wrote: > On 08.08.2016 20:07, Colin Lord wrote: >> Modularizes the nfs block driver so that it gets dynamically loaded. >> >> Signed-off-by: Colin Lord >> Reviewed-by: Stefan Hajnoczi >> --- >> block/Makefile.objs | 1 + >>

Re: [Qemu-devel] [PATCH v7 0/4] Dynamic module loading for block drivers

2016-08-10 Thread Max Reitz
On 08.08.2016 20:07, Colin Lord wrote: > One more minor revision from v6, no big changes. > > v7: > - Add ifdef around qemu_iscsi_opts in vl.c (first patch) > > v6: > - Fix bug so that users can specify a modularized driver on the cli > without qemu exiting > - Remove extra lines from Makefile

Re: [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-10 Thread Colin Lord
On 08/10/2016 02:37 PM, Max Reitz wrote: > On 08.08.2016 20:07, Colin Lord wrote: >> From: Marc Mari >> >> Extend the current module interface to allow for block drivers to be >> loaded dynamically on request. The only block drivers that can be >> converted into modules are the

Re: [Qemu-devel] [PATCH for 2.7] ppc: parse cpu features once

2016-08-10 Thread Cédric Le Goater
On 08/10/2016 09:08 PM, Cédric Le Goater wrote: > From: Greg Kurz > > Considering that features are converted to global properties and > global properties are automatically applied to every new instance > of created CPU (at object_new() time), there is no point in > parsing

[Qemu-devel] [PATCH] net: vmxnet: initialise local tx descriptor

2016-08-10 Thread P J P
From: Li Qiang In Vmxnet3 device emulator while processing transmit(tx) queue, when it reaches end of packet, it calls vmxnet3_complete_packet. In that local 'txcq_descr' object is not initialised, which could leak host memory bytes a guest. Reported-by: Li Qiang

[Qemu-devel] [PATCH v1 09/10] target-ppc: improve stxvw4x implementation

2016-08-10 Thread Nikunj A Dadhania
Manipulate data and store 8bytes instead of 4bytes. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate/vsx-impl.inc.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/target-ppc/translate/vsx-impl.inc.c

[Qemu-devel] [PATCH for 2.7] ppc: parse cpu features once

2016-08-10 Thread Cédric Le Goater
From: Greg Kurz Considering that features are converted to global properties and global properties are automatically applied to every new instance of created CPU (at object_new() time), there is no point in parsing cpu_model string every time a CPU created. So move parsing

Re: [Qemu-devel] [PATCH v7 4/4] blockdev: Modularize nfs block driver

2016-08-10 Thread Max Reitz
On 08.08.2016 20:07, Colin Lord wrote: > Modularizes the nfs block driver so that it gets dynamically loaded. > > Signed-off-by: Colin Lord > Reviewed-by: Stefan Hajnoczi > --- > block/Makefile.objs | 1 + > configure | 4 ++-- > 2 files

[Qemu-devel] [PATCH v1 04/10] target-ppc: Implement darn instruction

2016-08-10 Thread Nikunj A Dadhania
From: Ravi Bangoria darn: Deliver A Random Number For both CRN and RRN, returning 64-bit random number. Signed-off-by: Ravi Bangoria [ use /dev/random to get the number ] Signed-off-by: Nikunj A Dadhania

[Qemu-devel] [PATCH v1 10/10] target-ppc: add stxvb16x and stxvh8x

2016-08-10 Thread Nikunj A Dadhania
stxvb16x: Store VSX Vector Byte*16 stxvh8x: Store VSX Vector Halfword*8 Signed-off-by: Nikunj A Dadhania --- target-ppc/translate/vsx-impl.inc.c | 55 + target-ppc/translate/vsx-ops.inc.c | 2 ++ 2 files changed, 57 insertions(+)

[Qemu-devel] [PATCH v1 06/10] target-ppc: add stxsi[bh]x instruction

2016-08-10 Thread Nikunj A Dadhania
stxsibx - Store VSX Scalar as Integer Byte Indexed stxsihx - Store VSX Scalar as Integer Halfword Indexed Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 2 ++ target-ppc/translate/vsx-impl.inc.c | 2 ++ target-ppc/translate/vsx-ops.inc.c |

[Qemu-devel] [PATCH v1 05/10] target-ppc: add lxsi[bw]zx instruction

2016-08-10 Thread Nikunj A Dadhania
lxsibzx - Load VSX Scalar as Integer Byte & Zero Indexed lxsihzx - Load VSX Scalar as Integer Halfword & Zero Indexed Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 2 ++ target-ppc/translate/vsx-impl.inc.c | 2 ++

[Qemu-devel] [PATCH v1 07/10] target-ppc: improve lxvw4x implementation

2016-08-10 Thread Nikunj A Dadhania
Load 8byte at a time and manipulate. Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + target-ppc/mem_helper.c | 5 + target-ppc/translate/vsx-impl.inc.c | 34 -- 3 files changed, 26

[Qemu-devel] [PATCH v1 02/10] target-ppc: consolidate load operations

2016-08-10 Thread Nikunj A Dadhania
Implement macro to consolidate store operations using newer tcg_gen_qemu_ld functions. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 70 +++--- 1 file changed, 26 insertions(+), 44 deletions(-) diff --git

[Qemu-devel] [PATCH v1 00/10] POWER9 TCG enablements - part4

2016-08-10 Thread Nikunj A Dadhania
This series contains 10 new instructions for POWER9 ISA3.0. Use newer qemu load/store tcg helpers and optimize stxvw4x and lxvw4x. Patches: 01: xxspltib: VSX Vector Splat Immediate Byte 02: Use tcg_gen_qemu_ld and write consolidated macro 03: Use tcg_gen_qemu_st and write

[Qemu-devel] [PATCH v1 03/10] target-ppc: consolidate store operations

2016-08-10 Thread Nikunj A Dadhania
Implement macro to consolidate store operations using newer tcg_gen_qemu_st functions. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git

[Qemu-devel] [PATCH v1 08/10] target-ppc: add lxvb16x and lxvh8x

2016-08-10 Thread Nikunj A Dadhania
lxvb16x: Load VSX Vector Byte*16 lxvh8x: Load VSX Vector Halfword*8 Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + target-ppc/mem_helper.c | 6 target-ppc/translate/vsx-impl.inc.c | 57

[Qemu-devel] [PATCH v1 01/10] target-ppc: add xxspltib instruction

2016-08-10 Thread Nikunj A Dadhania
xxspltib: VSX Vector Splat Immediate Byte Copy the immediate byte in each byte of target VSR Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 2 ++ target-ppc/translate/vsx-impl.inc.c | 22 ++

Re: [Qemu-devel] [PATCH] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-10 Thread Aurelien Jarno
On 2016-08-10 14:55, Pranith Kumar wrote: > Change the flag type to 'uint8_t' to fix the implicit conversion error. > > Signed-off-by: Pranith Kumar > --- > fpu/softfloat-specialize.h | 2 +- > include/fpu/softfloat.h| 4 ++-- > 2 files changed, 3 insertions(+), 3

[Qemu-devel] [PATCH] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-10 Thread Pranith Kumar
Change the flag type to 'uint8_t' to fix the implicit conversion error. Signed-off-by: Pranith Kumar --- fpu/softfloat-specialize.h | 2 +- include/fpu/softfloat.h| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fpu/softfloat-specialize.h

Re: [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-10 Thread Max Reitz
On 08.08.2016 20:07, Colin Lord wrote: > From: Marc Mari > > Extend the current module interface to allow for block drivers to be > loaded dynamically on request. The only block drivers that can be > converted into modules are the drivers that don't perform any init >

Re: [Qemu-devel] [PATCH v7 2/4] blockdev: Add dynamic generation of module_block.h

2016-08-10 Thread Max Reitz
On 08.08.2016 20:07, Colin Lord wrote: > From: Marc Mari > > To simplify the addition of new block modules, add a script that generates > module_block.h automatically from the modules' source code. > > This script assumes that the QEMU coding style rules are followed. > >

Re: [Qemu-devel] [PATCH for-2.8] dmg: Move the driver to block-obj-y

2016-08-10 Thread Max Reitz
On 03.08.2016 10:01, Fam Zheng wrote: > dmg.o was moved to block-obj-m in 5505e8b76 to become a separate module, > so that its reference to libbz2, since 6b383c08c, doesn't add an extra > library to the main executable. > > We are working on on-demand loading of block drivers which will be >

[Qemu-devel] [PATCH v4 17/17] qmp-commands.txt: fix some styling

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau Add some missing lines, remove superflous @ in command name, remove trailing spaces. Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 31 ++- 1 file changed, 18

[Qemu-devel] [PATCH v4 15/17] build-sys: remove qmp-commands-old.h

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- Makefile.target | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Makefile.target b/Makefile.target index

[Qemu-devel] [PATCH v4 14/17] monitor: use qmp_dispatch()

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau Replace the old manual dispatch and validation code by the generic one provided by qapi common code. Note that it is now possible to call the following commands that used to be disabled by compile-time conditionals: - dump-skeys - query-spice

[Qemu-devel] [PATCH v4 13/17] qmp: update qmp_query_spice fallback

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau The following "use qmp_dispatch()" commit will use the generated dispatch command table that is unaware of compile time conditionals. There are a few commands that are under #ifdef conditions in qmp-commands.hx. Move the qmp_query_spice

[Qemu-devel] [Bug 495566] Re: qemu network adapter initialization fails when using macaddr=

2016-08-10 Thread T. Huth
A check for multicast MAC addresses has been introduced by this commit here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d60b20cf2ae6644b051 So I think we can close this ticket now. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you

[Qemu-devel] [PATCH v4 11/17] qapi: remove the "middle" mode

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau Now that the register function is always generated, we can remove the so-called "middle" mode from the generator script. Signed-off-by: Marc-André Lureau --- scripts/qapi-commands.py | 15 +++ 1 file

[Qemu-devel] [PATCH v4 09/17] monitor: implement 'qmp_query_commands' without qmp_cmds

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau One step towards getting rid of the static qmp_cmds table. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- monitor.c | 29 ++--- 1 file changed, 18

[Qemu-devel] [PATCH v4 12/17] qapi: check invalid arguments on no-args commands

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau The generated marshal functions do not visit arguments from commands that take no arguments. Thus they fail to catch invalid members. Visit the arguments, if provided, to throw an error in case of invalid members. Currently,

[Qemu-devel] [PATCH v4 07/17] qapi: export the marshallers

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau Make it possible to call marshallers manually, without going through qmp_dispatch(). (this is currently only possible in middle-mode, but it's also useful in general) Signed-off-by: Marc-André Lureau ---

[Qemu-devel] [PATCH v4 16/17] Replace qmp-commands.hx by doc/qmp-commands.txt

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau The only remaining function of qmp-commands.hx is to let us generate qmp-commands.txt from it. Replace qmp-commands.hx by qmp-commands.txt. (a later update will move the documentation in the respective json files and again generate the text

[Qemu-devel] [PATCH v4 10/17] monitor: remove mhandler.cmd_new

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau This is no longer necessary now that we aren't using middle mode anymore. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- monitor.c | 13 +--

[Qemu-devel] [PATCH v4 06/17] monitor: unregister conditional commands

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau The current monitor dispatch codes doesn't know commands that have been filtered out during qmp-commands.hx preprocessing. query-commands doesn't list them either. However, qapi generator doesn't filter them out, and they are listed in the

[Qemu-devel] [PATCH v4 08/17] monitor: use qmp_find_command() (using generated qapi code)

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau Stop using the so-called 'middle' mode. Instead, use qmp_find_command() from generated qapi commands registry. Update and fix the documentation too. Signed-off-by: Marc-André Lureau --- monitor.c

[Qemu-devel] [PATCH v4 05/17] monitor: register gen:false commands manually

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau Since a few commands are using 'gen': false, they are not registered automatically by the generator. Register manually instead. This is in preparation for removal of qapi 'middle' mode generation. Note that qmp_init_marshal() function isn't

[Qemu-devel] [PATCH v4 03/17] qapi-schema: add 'device_add'

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau Even though device_add is not fully qapi'fied, we may add it to the json schema with 'gen': false, so registration and documentation can be generated. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v4 04/17] monitor: simplify invalid_qmp_mode()

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau handle_qmp_command() will switch to use qmp_dispatch(). It won't have a pointer to the marshaller function anymore, but only the name of the command to invoke. Simplify invalid_qmp_mode() so it can just be called with the command name.

[Qemu-devel] [PATCH v4 02/17] qapi-schema: use generated marshaller for 'qmp_capabilities'

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau qapi'fy the 'qmp_capabilities' command, makes the command visible in query-qmp-schema. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH v4 00/17] qapi: remove the 'middle' mode

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau Hi, Although some QMP commands are still not fully qapi'fied, it is possible to use more qapi common and generated code by dropping the 'middle' mode and use qmp_dispatch(). v4: - export all marshaller functions (so we can keep calling them

[Qemu-devel] [PATCH v4 01/17] build-sys: define QEMU_VERSION_{MAJOR, MINOR, MICRO}

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau There are better chances to find what went wrong at build time than a later assert in qmp_query_version Signed-off-by: Marc-André Lureau --- qmp.c | 16 +++- scripts/create_config |

Re: [Qemu-devel] [RFC v2 PATCH] tcg: Optimize fence instructions

2016-08-10 Thread Pranith Kumar
Hi Richard, On Wed, Aug 10, 2016 at 6:44 AM, Richard Henderson wrote: > On 08/10/2016 04:42 AM, Pranith Kumar wrote: >> >> +/* Eliminate duplicate and unnecessary fence instructions */ >> +void tcg_optimize_mb(TCGContext *s) >> +{ >> +int oi, oi_next; >> +TCGArg

Re: [Qemu-devel] [PATCH] migration: fix live migration failure with compression

2016-08-10 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > Subject: Re: [PATCH] migration: fix live migration failure with compression > > > > * Liang Li (liang.z...@intel.com) wrote: > > > Because of commit 11808bb0c422, which remove some condition checks of > > > 'f->ops->writev_buffer',

Re: [Qemu-devel] About a virtio 9p backend issue

2016-08-10 Thread Greg Kurz
Le Wed, 10 Aug 2016 20:28:27 +0530 (IST), P J P a écrit : > +-- On Wed, 10 Aug 2016, Greg Kurz wrote --+ > | As Michael already pointed in a previous mail, this will break legal paths > | with a component ending in ".." like "foo../bar". The fix should only ban > | paths

Re: [Qemu-devel] [PATCH] qemu-img: add seek option to dd

2016-08-10 Thread Max Reitz
On 10.08.2016 17:03, Reda Sallahi wrote: > This patch adds the seek option which allows qemu-img dd to skip a number of > blocks on the output before copying the input. > > A test case was added to test the seek option. > > Signed-off-by: Reda Sallahi > --- > Depends on: >

Re: [Qemu-devel] [PULL 0/3] virtio/vhost: fixes

2016-08-10 Thread Peter Maydell
On 10 August 2016 at 16:30, Michael S. Tsirkin wrote: > The following changes since commit 53279c76cf071fed07a336948d37c72e3613e0b7: > > Update version for v2.7.0-rc2 release (2016-08-08 17:26:11 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [RFC PATCH 1/4] tests/tcg: Add x86 mttcg litmus test

2016-08-10 Thread Alex Bennée
Pranith Kumar writes: > This adds the x86 store-after-load re-ordering litmus test. > > Most of the supporting files are mostly unmodified and generated by > the litmus tool. > > Signed-off-by: Pranith Kumar > --- > tests/tcg/mttcg/x86/Makefile

Re: [Qemu-devel] [PATCH] trace: Remove 'trace_events_dstate_init'

2016-08-10 Thread Lluís Vilanova
Lluís Vilanova writes: > Removes the event state array used for early initialization. Since only > events with the "vcpu" property need a late initialization fixup, > threats their initialization specially. > Assumes that the user won't touch the state of "vcpu" events between > early and late

Re: [Qemu-devel] [PATCH 2/2] intel-iommu: restrict EIM to quirkless KVM

2016-08-10 Thread Radim Krčmář
2016-08-10 11:29+0800, Peter Xu: > On Tue, Aug 09, 2016 at 05:03:33PM +0200, Radim Krčmář wrote: >> APIC in QEMU doesn't support x2APIC so exposing EIM is pointless and KVM >> has a quirk that needs to be disabled unless we want x2APIC message with >> destination 0xff to be misinterpreted as a

  1   2   3   >