Re: [Qemu-devel] [PATCH 0/5] spapr: convert SPAPR devices to trace framework

2016-09-15 Thread David Gibson
On Thu, Sep 15, 2016 at 10:09:34AM +1000, David Gibson wrote: > On Wed, Sep 14, 2016 at 08:48:22PM +0200, Laurent Vivier wrote: > > Define and use trace_spapr_XXX functions instead of > > DPRINTF to trace some SPAPR devices: spapr_vio, spapr_drc, spapr_rtas, > > spapr_llan, spapr_vscsi. > > > >

Re: [Qemu-devel] Virtual Machine Generation ID

2016-09-15 Thread Michael S. Tsirkin
On Thu, Sep 15, 2016 at 05:23:28PM -0700, Ed Swierk wrote: > I'm wondering what it will take to finish up work on vmgenid. > > https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg05599.html > > It appears all of the designs explored through the 19 iterations were > problematic in some way.

[Qemu-devel] Virtual Machine Generation ID

2016-09-15 Thread Ed Swierk
I'm wondering what it will take to finish up work on vmgenid. https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg05599.html It appears all of the designs explored through the 19 iterations were problematic in some way. Is any of them vaguely acceptable to all involved in the discussions?

Re: [Qemu-devel] [PATCH v3 0/2] block: allow flush on devices with open tray

2016-09-15 Thread Paolo Bonzini
On 16/09/2016 02:09, John Snow wrote: > > > On 09/15/2016 08:06 PM, Paolo Bonzini wrote: >> >> >> On 16/09/2016 01:42, John Snow wrote: >>> One more try. >>> >>> The move to blk_flush altered the behavior of migration and flushing >>> nodes that are not reachable via the guest, but are still

Re: [Qemu-devel] [PATCH v3 0/2] block: allow flush on devices with open tray

2016-09-15 Thread John Snow
On 09/15/2016 08:06 PM, Paolo Bonzini wrote: On 16/09/2016 01:42, John Snow wrote: One more try. The move to blk_flush altered the behavior of migration and flushing nodes that are not reachable via the guest, but are still reachable via QEMU and may or may not need to be flushed. This is

Re: [Qemu-devel] [PATCH v3 0/2] block: allow flush on devices with open tray

2016-09-15 Thread Paolo Bonzini
On 16/09/2016 01:42, John Snow wrote: > One more try. > > The move to blk_flush altered the behavior of migration and flushing > nodes that are not reachable via the guest, but are still reachable > via QEMU and may or may not need to be flushed. > > This is likely the simplest solution for

[Qemu-devel] [PATCH v3 0/2] block: allow flush on devices with open tray

2016-09-15 Thread John Snow
One more try. The move to blk_flush altered the behavior of migration and flushing nodes that are not reachable via the guest, but are still reachable via QEMU and may or may not need to be flushed. This is likely the simplest solution for now until we nail down our policy a bit more. This is

[Qemu-devel] [PATCH v3 1/2] block: reintroduce bdrv_flush_all

2016-09-15 Thread John Snow
Commit fe1a9cbc moved the flush_all routine from the bdrv layer to the block-backend layer. In doing so, however, the semantics of the routine changed slightly such that flush_all now used blk_flush instead of bdrv_flush. blk_flush can fail if the attached device model reports that it is not

[Qemu-devel] [PATCH v3 2/2] qemu: use bdrv_flush_all for vm_stop et al

2016-09-15 Thread John Snow
Bypass the usual check to see if we are "allowed" to flush via the block model, and manually flush the BDS nodes themselves instead. This allows us to do things like migrate when we have a device with an open tray, but has a node that may need to be flushed. Specifically, this allows us to

[Qemu-devel] [PATCH] 9pfs: fix potential segfault during walk

2016-09-15 Thread Greg Kurz
If the call to fid_to_qid() returns an error, we will call v9fs_path_free() on uninitialized paths. Let's fix this by initializing dpath and path before calling fid_to_qid(). Signed-off-by: Greg Kurz --- Thanks Paolo (and Coverity) for spotting this. Cc'ing stable as this is a

Re: [Qemu-devel] [PATCH v2 0/5] ps2: fix keyboard set 3 and misc improvements

2016-09-15 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1473969987-5890-1-git-send-email-hpous...@reactos.org Subject: [Qemu-devel] [PATCH v2 0/5] ps2: fix keyboard set 3 and misc improvements === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v4 3/3] 9pfs: handle walk of ".." in the root directory

2016-09-15 Thread Paolo Bonzini
On 30/08/2016 20:40, Greg Kurz wrote: > + > +err = fid_to_qid(pdu, fidp, ); > +if (err < 0) { > +goto out; > +} > + > v9fs_path_init(); > v9fs_path_init(); The "out" label can now be reached without having initialized dpath and path. This upsets Coverity (and

Re: [Qemu-devel] [PULL 36/42] block: Allow node name for 'qemu-io' HMP command

2016-09-15 Thread Paolo Bonzini
On 05/09/2016 20:13, Kevin Wolf wrote: > When using a node name, create a temporary BlockBackend that is used to > run the qemu-io command. > > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > --- > hmp.c | 13 + > 1 file changed, 13

Re: [Qemu-devel] [RFC 4/4] virtio-net: Add MTU feature support

2016-09-15 Thread Paolo Bonzini
On 06/09/2016 18:11, Maxime Coquelin wrote: > VirtIONet *n = VIRTIO_NET(vdev); > struct virtio_net_config netcfg; > > +if (virtio_vdev_has_feature(vdev, VIRTIO_NET_F_MTU)) { > +virtio_stw_p(vdev, , n->mtu); > +} This write needs to be unconditional, otherwise you are

Re: [Qemu-devel] [PATCH v3 09/10] ppc/pnv: add a LPC controller

2016-09-15 Thread Benjamin Herrenschmidt
On Thu, 2016-09-15 at 14:45 +0200, Cédric Le Goater wrote: > This version of the LPC controller model doesn't yet implement > support for the SerIRQ deserializer present in the Naples version > of the chip though some preliminary work is there. The version in my branch has this support btw.

Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure

2016-09-15 Thread Benjamin Herrenschmidt
On Thu, 2016-09-15 at 14:45 +0200, Cédric Le Goater wrote: >  - The PCB translation is too much of a constraint for a specific >    XSCOM address space, unless someone can explain me how to address 8 >    bytes at 0xb0021 and another 8 different bytes at 0xb0022. I don't >    think the address

Re: [Qemu-devel] Adding resolutions to the VGA driver

2016-09-15 Thread Benjamin Herrenschmidt
On Thu, 2016-09-15 at 13:21 -0400, Programmingkid wrote: > There has been talk about what resolutions to add support for in the > VGA driver. What do you think of this list: We should add check for the vram amount. There's only 16M emulated iirc, we need to check the combination resolution/depth

Re: [Qemu-devel] [PULL v5 00/18] tcg queued patches

2016-09-15 Thread Richard Henderson
On 09/15/2016 08:53 AM, Peter Maydell wrote: On 14 September 2016 at 17:19, Richard Henderson wrote: Changes since last: * Some cleanup in the size+alignment patch * Bug fixed in GETPC patch causing "make check" failure. The pc adjustment moved to the (really) very

Re: [Qemu-devel] [PATCH v2 0/3] trace: Add events to track vCPU lifecycle

2016-09-15 Thread Lluís Vilanova
no-reply writes: > Hi, > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > Type: series > Message-id: 147395313099.671.7091947764472506776.st...@fimbulvetr.bsc.es >

Re: [Qemu-devel] [s390] possible deadlock in handle_sigp?

2016-09-15 Thread Paolo Bonzini
On 15/09/2016 21:21, David Hildenbrand wrote: > Smells like having to provide a lock per CPU. Trylock that lock, if that's not > possible, cc=busy. SIGP SET ARCHITECTURE has to lock all CPUs. Makes sense. On the other hand: - you have to trylock both the source and the destination, I think.

[Qemu-devel] [PULL v3 6/6] MAINTAINERS: add virtio-* tests

2016-09-15 Thread Michael S. Tsirkin
From: Greg Kurz Except virtio-9p, all virtio-* tests are orphan. This patch tries to fix it, according to the following logic: - when the related subsystem has its own section in MAINTAINERS, the test is added there - otherwise it is added to the "parent" section (aka. SCSI,

[Qemu-devel] [PULL v3 4/6] hw/i386: Introduce AMD IOMMU

2016-09-15 Thread Michael S. Tsirkin
From: David Kiarie Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU. The IOMMU does basic translation, error checking and has a minimal IOTLB implementation. This IOMMU bypassed the need for target aborts by responding with IOMMU_NONE access rights and exempts

Re: [Qemu-devel] [PULL v3 6/6] MAINTAINERS: add virtio-* tests

2016-09-15 Thread Andreas Färber
Am 15.09.2016 um 22:38 schrieb Michael S. Tsirkin: > From: Greg Kurz > > Except virtio-9p, all virtio-* tests are orphan. This patch tries to fix > it, according to the following logic: > > - when the related subsystem has its own section in MAINTAINERS, the test > is added

[Qemu-devel] [PULL v3 2/6] hw/pci: Prepare for AMD IOMMU

2016-09-15 Thread Michael S. Tsirkin
From: David Kiarie Introduce PCI macros from for use by AMD IOMMU Signed-off-by: David Kiarie --- include/hw/pci/pci.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index

[Qemu-devel] [PULL v3 5/6] hw/i386: AMD IOMMU IVRS table

2016-09-15 Thread Michael S. Tsirkin
From: David Kiarie Add IVRS table for AMD IOMMU. Generate IVRS or DMAR depending on emulated IOMMU. Signed-off-by: David Kiarie --- include/hw/acpi/aml-build.h | 1 + include/hw/i386/x86-iommu.h | 12 +++ hw/acpi/aml-build.c | 2 +-

[Qemu-devel] [PULL v3 0/6] virtio,pci: fixes and updates

2016-09-15 Thread Michael S. Tsirkin
The following changes since commit d1eb8f2acba579830cf3798c3c15ce51be852c56: fpu: add mechanism to check for invalid long double formats (2016-09-15 12:43:18 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to

[Qemu-devel] [PULL v3 1/6] virtio-bus: Plug devices after features are negotiated

2016-09-15 Thread Michael S. Tsirkin
From: Maxime Coquelin Currently, devices are plugged before features are negotiated. If the backend doesn't support VIRTIO_F_VERSION_1, the transport needs to rewind some settings. This is the case for CCW, for which a post_plugged callback had been introduced, where

[Qemu-devel] [PULL v3 3/6] hw/i386/trace-events: Add AMD IOMMU trace events

2016-09-15 Thread Michael S. Tsirkin
From: David Kiarie Signed-off-by: David Kiarie --- hw/i386/trace-events | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/i386/trace-events b/hw/i386/trace-events index 5b99eba..26d6098 100644 ---

[Qemu-devel] [PATCH v2 2/5] ps2: correctly handle 'get/set scancode' command

2016-09-15 Thread Hervé Poussineau
When getting scancode, current scancode must be preceded from reply ack. When setting scancode, we must reject invalid scancodes. Signed-off-by: Hervé Poussineau --- hw/input/ps2.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/input/ps2.c

[Qemu-devel] [PATCH v2 1/5] ps2: reject unknown commands, instead of blindly accepting them

2016-09-15 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/input/ps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index a8aa36f..00a1792 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -290,7 +290,7 @@ void ps2_write_keyboard(void

[Qemu-devel] [PATCH v2 3/5] ps2: allow keycode translation for all scancode sets

2016-09-15 Thread Hervé Poussineau
Change ps2_put_keycode to get an untranslated scancode, which is translated if needed. As qemu_input_key_value_to_scancode() gives translated scancodes, untranslate them in ps2_keyboard_event first before giving them to ps2_put_keycode. Results are not changed, except for some keys in

[Qemu-devel] [PATCH v2 4/5] ps2: use QEMU qcodes instead of scancodes

2016-09-15 Thread Hervé Poussineau
This fixes problems with translated set 1, where most make code were wrong. This fixes problems with set 3 for extended keys (like arrows) and lot of other keys. Added a FIXME for set 3, where most keys must not (by default) deliver a break code. Detailed list of changes on untranslated set 2:

[Qemu-devel] [PATCH v2 5/5] ps2: do not generate invalid key codes for unknown keys

2016-09-15 Thread Hervé Poussineau
Instead, print a warning message. Signed-off-by: Hervé Poussineau --- hw/input/ps2.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 98da984..0d14de0 100644 --- a/hw/input/ps2.c +++

[Qemu-devel] [PATCH v2 0/5] ps2: fix keyboard set 3 and misc improvements

2016-09-15 Thread Hervé Poussineau
Hi, This patchset is a welcome cleanup of scancodes used in PS/2 keyboard emulation. - Patches 1 and 2 are fixes to let Linux use set 3 if instructed so. - Patch 3 makes scancodes untranslated by default and translates them if required, instead of receiving translated scancodes by default and

Re: [Qemu-devel] [s390] possible deadlock in handle_sigp?

2016-09-15 Thread David Hildenbrand
> On 09/12/2016 08:03 PM, Paolo Bonzini wrote: > > > > > > On 12/09/2016 19:37, Christian Borntraeger wrote: > >> On 09/12/2016 06:44 PM, Paolo Bonzini wrote: > >>> I think that two CPUs doing reciprocal SIGPs could in principle end up > >>> waiting on each other to complete their

Re: [Qemu-devel] [PATCH 1/1] block: add cache mode with direct IO and without flushes

2016-09-15 Thread Denis V. Lunev
On 09/15/2016 07:09 PM, Kevin Wolf wrote: > Am 15.09.2016 um 15:19 hat Denis V. Lunev geschrieben: >> This mode could be very useful for flush bottlenecks evaluation and for >> running non-persistent VMs, when host crash is considered not fatal. >> >> Signed-off-by: Denis V. Lunev

Re: [Qemu-devel] [PULL v2 0/6] virtio,pci: fixes and updates

2016-09-15 Thread Peter Maydell
On 15 September 2016 at 16:22, Michael S. Tsirkin wrote: > The following changes since commit d1eb8f2acba579830cf3798c3c15ce51be852c56: > > fpu: add mechanism to check for invalid long double formats (2016-09-15 > 12:43:18 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v3 34/34] target-alpha: Emulate LL/SC using cmpxchg helpers

2016-09-15 Thread Richard Henderson
On 09/15/2016 10:48 AM, Alex Bennée wrote: Ahh ok. The ARM code just allocates temps on demand including for its zero register which I guess means multiple ones could be assigned. There is also temp allocation logic to free them at the end of the block. I wonder if this is something that should

[Qemu-devel] [PULL 1/1] vfio/pci: Fix regression in MSI routing configuration

2016-09-15 Thread Alex Williamson
From: David Gibson d1f6af6 "kvm-irqchip: simplify kvm_irqchip_add_msi_route" was a cleanup of kvmchip routing configuration, that was mostly intended for x86. However, it also contains a subtle change in behaviour which breaks EEH[1] error recovery on certain VFIO

[Qemu-devel] [PULL 0/1] VFIO fixes 2016-09-15

2016-09-15 Thread Alex Williamson
The following changes since commit 9f16390cd3cdd85fa20739f07120f4d697c11837: Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20160914-1' into staging (2016-09-15 14:56:36 +0100) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git

Re: [Qemu-devel] [PULL 00/17] Second batch of misc patches for QEMU 2.8

2016-09-15 Thread Peter Maydell
On 15 September 2016 at 15:21, Paolo Bonzini wrote: > The following changes since commit 083d012a388e7e2a8bfd9144c2c9bcceb29a78fc: > > cutils: Add generic prefetch (2016-09-13 19:13:32 +0200) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 10/10] qemu-iotests/118: Test media change with qdev name

2016-09-15 Thread Sascha Silbe
Dear Eric, Eric Blake writes: > arglist = (all other parameters) > if self.device_name: > arglist.append(id=self.device_name) > else: > arglist.append(device='drive0') > invoke(self.vm.qmp, arglist) That would be: qmp_args = {'cmd': 'blockdev-change-medium',

Re: [Qemu-devel] [PATCH v3 34/34] target-alpha: Emulate LL/SC using cmpxchg helpers

2016-09-15 Thread Alex Bennée
Richard Henderson writes: > On 09/15/2016 07:38 AM, Alex Bennée wrote: >>> +lab_fail = gen_new_label(); >>> > +lab_done = gen_new_label(); >>> > +tcg_gen_brcond_i64(TCG_COND_NE, addr, cpu_lock_addr, lab_fail); >>> > +tcg_temp_free_i64(addr); >>> > >>> > -

[Qemu-devel] Adding resolutions to the VGA driver

2016-09-15 Thread Programmingkid
There has been talk about what resolutions to add support for in the VGA driver. What do you think of this list: 512x342 640x400 640x480 800x600 1024x600 1024x640 1152x864 1200x700 1280x720 1280x768 1280x800 1366x768 1440x900 1920x1200 2304x1440 2560x1080 2560x1600 2880x1800 4096x2304 4096x3072

Re: [Qemu-devel] [PATCH v3 2/2] mirror: fix improperly filled copy_bitmap for mirror block job

2016-09-15 Thread Eric Blake
On 09/15/2016 11:34 AM, Denis V. Lunev wrote: > bdrv_is_allocated_above() returns true in the case even for completel s/completel/completely/ > zeroed areas as BDRV_BLOCK_ALLOCATED flag is set in both cases. > > The patch stops using bdrv_is_allocated_above() wrapper and switches to >

Re: [Qemu-devel] [PULL 00/21] Trivial patches for 2016-09-15

2016-09-15 Thread Peter Maydell
On 15 September 2016 at 13:53, Michael Tokarev wrote: > This is a respin from the yesterday's pull request, > now with only 21 patch out of 27. Other 6 patches > has already been applied to master from other trees > (what a waste of time :) ). > > Resending only the cover

Re: [Qemu-devel] [PATCH v2 0/3] trace: Add events to track vCPU lifecycle

2016-09-15 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 147395313099.671.7091947764472506776.st...@fimbulvetr.bsc.es Subject: [Qemu-devel] [PATCH v2 0/3]

Re: [Qemu-devel] [PATCH] msmouse: Fix segfault caused by free the chr before chardev cleanup.

2016-09-15 Thread Paolo Bonzini
On 15/09/2016 16:31, Lin Ma wrote: > Segfault happens when leaving qemu with msmouse backend: > > #0 0x7fa8526ac975 in raise () at /lib64/libc.so.6 > #1 0x7fa8526add8a in abort () at /lib64/libc.so.6 > #2 0x558be78846ab in error_exit (err=16, msg=0x558be799da10 ... > #3

Re: [Qemu-devel] [PULL v2 0/6] virtio,pci: fixes and updates

2016-09-15 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1473952956-16264-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PULL v2 0/6] virtio,pci: fixes and updates === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v3 34/34] target-alpha: Emulate LL/SC using cmpxchg helpers

2016-09-15 Thread Richard Henderson
On 09/15/2016 07:38 AM, Alex Bennée wrote: +lab_fail = gen_new_label(); > +lab_done = gen_new_label(); > +tcg_gen_brcond_i64(TCG_COND_NE, addr, cpu_lock_addr, lab_fail); > +tcg_temp_free_i64(addr); > > -lab_fail = gen_new_label(); > -lab_done = gen_new_label(); >

Re: [Qemu-devel] [PULL v2 0/6] virtio,pci: fixes and updates

2016-09-15 Thread Michael S. Tsirkin
On Thu, Sep 15, 2016 at 09:25:51AM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 1473952956-16264-1-git-send-email-...@redhat.com > Subject:

[Qemu-devel] [PATCH 1/1] tests: allow to specify list of formats to test for check-block.sh

2016-09-15 Thread Denis V. Lunev
This would make code better and allow to test specific format. Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Kevin Wolf CC: Paolo Bonzini --- tests/check-block.sh | 13 - 1 file changed, 8

Re: [Qemu-devel] [PATCH v3 33/34] target-alpha: Introduce MMU_PHYS_IDX

2016-09-15 Thread Richard Henderson
On 09/15/2016 03:10 AM, Alex Bennée wrote: /* User-space cannot access KSEG addresses. */ > -if (mmu_idx != MMU_KERNEL_IDX) { > +if (mmu_idx < MMU_KERNEL_IDX) { > goto exit; > } I'm confused by this change. It's not the same test and when is

[Qemu-devel] [PATCH v3 2/2] mirror: fix improperly filled copy_bitmap for mirror block job

2016-09-15 Thread Denis V. Lunev
bdrv_is_allocated_above() returns true in the case even for completel zeroed areas as BDRV_BLOCK_ALLOCATED flag is set in both cases. The patch stops using bdrv_is_allocated_above() wrapper and switches to bdrv_get_block_status_above() to distinguish zeroed areas and areas with data to avoid

[Qemu-devel] [PATCH v3 0/2] mirror: fix improperly filled copy_bitmap for mirror block job

2016-09-15 Thread Denis V. Lunev
bdrv_is_allocated_above() returns true in the case even for completel zeroed areas as BDRV_BLOCK_ALLOCATED flag is set in both cases. The patch stops using bdrv_is_allocated_above() wrapper and switches to bdrv_get_block_status_above() to distinguish zeroed areas and areas with data to avoid

Re: [Qemu-devel] [PATCH 10/10] qemu-iotests/118: Test media change with qdev name

2016-09-15 Thread Eric Blake
On 09/15/2016 11:28 AM, Sascha Silbe wrote: > Dear Eric, > > Sascha Silbe writes: > >> result = self.vm.qmp('blockdev-change-medium', >> id=self.device_name or 'drive0', >> filename=new_img, >>

Re: [Qemu-devel] [PATCH] vfio: Fix regression in MSI routing configuration

2016-09-15 Thread Alex Williamson
On Thu, 15 Sep 2016 16:11:48 +1000 David Gibson wrote: > d1f6af6 "kvm-irqchip: simplify kvm_irqchip_add_msi_route" was a cleanup > of kvmchip routing configuration, that was mostly intended for x86. > However, it also contains a subtle change in behaviour which

[Qemu-devel] [PATCH v3 1/2] block: sync bdrv_co_get_block_status_above() with bdrv_is_allocated_above()

2016-09-15 Thread Denis V. Lunev
They should work very similar, covering same areas if backing store is shorter than the image. This change is necessary for the followup patch switching to bdrv_get_block_status_above() in mirror to avoid assert in check_block. This change should be made very carefully. Let us assume that we have

Re: [Qemu-devel] [PATCH 10/10] qemu-iotests/118: Test media change with qdev name

2016-09-15 Thread Sascha Silbe
Dear Eric, Sascha Silbe writes: > result = self.vm.qmp('blockdev-change-medium', > id=self.device_name or 'drive0', > filename=new_img, > format=iotests.imgfmt) Sorry, my eyes deceived me. I thought

[Qemu-devel] [PATCH v7] migrate: move max-bandwidth and downtime-limit to migrate_set_parameter

2016-09-15 Thread Ashijeet Acharya
Mark the old commands 'migrate_set_speed' and 'migrate_set_downtime' as deprecated. Move max-bandwidth and downtime-limit into migrate-set-parameters for setting maximum migration speed and expected downtime limit parameters respectively. Change downtime units to milliseconds (only for

Re: [Qemu-devel] [PULL 00/18] Block layer patches

2016-09-15 Thread Peter Maydell
On 14 September 2016 at 17:40, Max Reitz wrote: > The following changes since commit 507e4ddc3abf67391bcbc9624fd60b969c159b78: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into > staging (2016-09-13 17:55:35 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH 10/10] qemu-iotests/118: Test media change with qdev name

2016-09-15 Thread Eric Blake
On 09/15/2016 11:16 AM, Sascha Silbe wrote: >>> +if self.device_name is not None: >>> +result = self.vm.qmp('blockdev-change-medium', >>> + id=self.device_name, filename=new_img, >>> + format=iotests.imgfmt) >>> +

Re: [Qemu-devel] [PATCH 10/10] qemu-iotests/118: Test media change with qdev name

2016-09-15 Thread Sascha Silbe
Dear Eric, (replying only to the Python coding part, haven't looked at the patch itself) Eric Blake writes: > On 08/19/2016 11:50 AM, Kevin Wolf wrote: >> @@ -76,9 +79,15 @@ class GeneralChangeTestsBaseClass(ChangeBaseClass): >> self.assert_qmp(result,

Re: [Qemu-devel] [PATCH 05/10] block: Accept device model name for x-blockdev-insert-medium

2016-09-15 Thread Eric Blake
On 09/15/2016 03:37 AM, Kevin Wolf wrote: > Am 14.09.2016 um 22:57 hat Eric Blake geschrieben: >> On 08/19/2016 11:50 AM, Kevin Wolf wrote: >>> In order to remove the necessity to use BlockBackend names in the >>> external API, we want to allow qdev device names in all device related >>> commands.

Re: [Qemu-devel] [PULL 00/17] Second batch of misc patches for QEMU 2.8

2016-09-15 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1473949316-31264-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel] [PULL 00/17] Second batch of misc patches for QEMU 2.8 === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 1/1] block: add cache mode with direct IO and without flushes

2016-09-15 Thread Kevin Wolf
Am 15.09.2016 um 15:19 hat Denis V. Lunev geschrieben: > This mode could be very useful for flush bottlenecks evaluation and for > running non-persistent VMs, when host crash is considered not fatal. > > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Max

[Qemu-devel] [PATCH v2 1/5] exec: [tcg] Refactor flush of per-CPU virtual TB cache

2016-09-15 Thread Lluís Vilanova
The function is reused in later patches. Signed-off-by: Lluís Vilanova --- cputlb.c|2 +- include/exec/exec-all.h |6 ++ translate-all.c |9 +++-- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/cputlb.c b/cputlb.c

[Qemu-devel] [PATCH v2 0/5] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches

2016-09-15 Thread Lluís Vilanova
Avoids generating TCG code to call guest code tracing events in vCPUs that are not dynamically tracing that event. Currently, events with the 'tcg' property always generate TCG code to trace that event at guest code execution time, when their dynamic tracing state is checked. This series adds a

Re: [Qemu-devel] [PATCH v6] migrate: move max-bandwidth and downtime-limit to migrate_set_parameter

2016-09-15 Thread Eric Blake
On 09/14/2016 12:40 PM, Ashijeet Acharya wrote: > Mark the old commands 'migrate_set_speed' and 'migrate_set_downtime' as > deprecated. > Move max-bandwidth and downtime-limit into migrate-set-parameters for > setting maximum migration speed and expected downtime limit parameters > respectively. >

Re: [Qemu-devel] [PULL v5 00/18] tcg queued patches

2016-09-15 Thread Peter Maydell
On 14 September 2016 at 17:19, Richard Henderson wrote: > Changes since last: > * Some cleanup in the size+alignment patch > * Bug fixed in GETPC patch causing "make check" failure. > The pc adjustment moved to the (really) very last place, > where it's now applied

Re: [Qemu-devel] [PATCH v6] migrate: move max-bandwidth and downtime-limit to migrate_set_parameter

2016-09-15 Thread Ashijeet Acharya
On Thu, Sep 15, 2016 at 9:18 PM, Eric Blake wrote: > On 09/14/2016 12:40 PM, Ashijeet Acharya wrote: >> Mark the old commands 'migrate_set_speed' and 'migrate_set_downtime' as >> deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-parameters for >> setting

Re: [Qemu-devel] [PATCH 04/10] block: Accept device model name for blockdev-open/close-tray

2016-09-15 Thread Eric Blake
On 09/15/2016 03:35 AM, Kevin Wolf wrote: >>> >>> -- "device": block device name (json-string) >>> +- "device": block device name (deprecated, use @id instead) >>> +(json-string, optional) >>> +- "id": the name or QOM path of the guest device (json-string, optional) >>> - "force":

[Qemu-devel] [PATCH v2 4/5] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events

2016-09-15 Thread Lluís Vilanova
If an event is dynamically disabled, the TCG code that calls the execution-time tracer is not generated. Removes the overheads of execution-time tracers for dynamically disabled events. As a bonus, also avoids checking the event state when the execution-time tracer is called from TCG-generated

Re: [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages

2016-09-15 Thread Paolo Bonzini
On 15/09/2016 17:07, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> /me hides in the corner... >> >> Cc: Dave Gilbert >> Signed-off-by: Paolo Bonzini >> --- >> hw/i386/kvm/apic.c | 1 - >> 1 file changed, 1 deletion(-)

[Qemu-devel] [PATCH v2 5/5] trace: [tcg, trivial] Re-align generated code

2016-09-15 Thread Lluís Vilanova
Last patch removed a nesting level in generated code. Re-align all code generated by backends to be 4-column aligned. Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/dtrace.py |2 +- scripts/tracetool/backend/ftrace.py | 20 ++--

[Qemu-devel] [PATCH v2 3/5] exec: [tcg] Switch physical TB cache based on vCPU tracing state

2016-09-15 Thread Lluís Vilanova
Uses the per-vCPU event state in CPUState->trace_dstate (a bitmap) as an index to a physical TB cache that will contain code specific to the set of dynamically enabled events. Two vCPUs tracing different events will execute code from different physical TB caches. Two vCPUs tracing the same events

[Qemu-devel] [PULL v2 1/6] virtio-bus: Plug devices after features are negotiated

2016-09-15 Thread Michael S. Tsirkin
From: Maxime Coquelin Currently, devices are plugged before features are negotiated. If the backend doesn't support VIRTIO_F_VERSION_1, the transport needs to rewind some settings. This is the case for CCW, for which a post_plugged callback had been introduced, where

Re: [Qemu-devel] [PATCH 01/16] cpus: pass CPUState to run_on_cpu helpers

2016-09-15 Thread Alex Bennée
Paolo Bonzini writes: > From: Alex Bennée > > CPUState is a fairly common pointer to pass to these helpers. This means > if you need other arguments for the async_run_on_cpu case you end up > having to do a g_malloc to stuff additional data into the

[Qemu-devel] [PATCH v2 2/5] exec: [tcg] Use multiple physical TB caches

2016-09-15 Thread Lluís Vilanova
The physical TB cache is split into 2^E caches, where E is the number of events with the "vcpu" and without the "disable" properties. The virtual TB cache on each vCPU uses a (potentially) different physical TB cache. This is later exploited to support different tracing event states on a

[Qemu-devel] [Bug 1623998] [NEW] pulseaudio Invalid argument error

2016-09-15 Thread John Arbuckle
Public bug reported: When using qemu-system-ppc on Ubuntu Mate 15 with the usb audio card, I see these error messages: pulseaudio: set_sink_input_volume() failed pulseaudio: Reason: Invalid argument pulseaudio: set_sink_input_mute() failed pulseaudio: Reason: Invalid argument No audio plays.

[Qemu-devel] [PULL v2 0/6] virtio,pci: fixes and updates

2016-09-15 Thread Michael S. Tsirkin
The following changes since commit d1eb8f2acba579830cf3798c3c15ce51be852c56: fpu: add mechanism to check for invalid long double formats (2016-09-15 12:43:18 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to

[Qemu-devel] [PATCH v2 1/3] trace: Properly initialize dynamic event states in hot-plugged vCPUs

2016-09-15 Thread Lluís Vilanova
Every time a vCPU is hot-plugged, it will "inherit" its tracing state from the global state array. That is, if *any* existing vCPU has an event enabled, new vCPUs will have too. Signed-off-by: Lluís Vilanova --- bsd-user/main.c|1 - linux-user/main.c |1

[Qemu-devel] [PATCH] hmp: Remove dead code in hmp_qemu_io()

2016-09-15 Thread Kevin Wolf
blk can never be NULL, drop the check. This fixes a Coverity warning. Signed-off-by: Kevin Wolf --- hmp.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/hmp.c b/hmp.c index ad33b44..0a16aef 100644 --- a/hmp.c +++ b/hmp.c @@ -1924,6 +1924,7

[Qemu-devel] [PATCH v2 2/3] trace: Add event "guest_cpu_enter"

2016-09-15 Thread Lluís Vilanova
Signals the hot-plugging of a new virtual (guest) CPU. Signed-off-by: Lluís Vilanova --- trace-events |8 trace/control-target.c |3 +++ 2 files changed, 11 insertions(+) diff --git a/trace-events b/trace-events index 616cc52..16a1cb4 100644 ---

[Qemu-devel] [PATCH v2 3/3] trace: Add event "guest_cpu_reset"

2016-09-15 Thread Lluís Vilanova
Signals the reset of the state a virtual (guest) CPU. Signed-off-by: Lluís Vilanova --- qom/cpu.c|3 +++ trace-events |5 + 2 files changed, 8 insertions(+) diff --git a/qom/cpu.c b/qom/cpu.c index 7e2e523..5f0ec6e 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@

Re: [Qemu-devel] [PULL 0/5] virtio,pci: fixes and updates

2016-09-15 Thread Michael S. Tsirkin
On Thu, Sep 15, 2016 at 02:55:29PM +0100, Peter Maydell wrote: > On 14 September 2016 at 02:32, Michael S. Tsirkin wrote: > > On Tue, Sep 13, 2016 at 11:32:32PM +0300, Michael S. Tsirkin wrote: > >> The following changes since commit > >>

[Qemu-devel] [PATCH v2 0/3] trace: Add events to track vCPU lifecycle

2016-09-15 Thread Lluís Vilanova
Adds events to track vCPU hot-(un)plugging and reset. As a bonus, first patch fixes per-vCPU dynamic event state initialization, making the current late initialization code obsolete. NOTE: This series is missing CPU hot-unplug, since I could not find a generic point to hook the event.

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-15 Thread Paolo Bonzini
On 15/09/2016 16:13, Brijesh Singh wrote: > 1) something like this > > diff --git a/target-i386/helper.c b/target-i386/helper.c > index a9d8aef..6322265 100644 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -1379,13 +1379,22 @@ void x86_cpu_exec_exit(CPUState *cs) > } > >

Re: [Qemu-devel] [PATCH 4/4] 9pfs: introduce v9fs_path_sprintf() helper

2016-09-15 Thread Greg Kurz
On Thu, 15 Sep 2016 17:09:08 +0200 Cédric Le Goater wrote: > On 09/15/2016 04:24 PM, Greg Kurz wrote: > > This helper is similar to v9fs_string_sprintf(), but it includes the > > terminating NUL character in the size field. > > NULL > The null character is often abbreviated

Re: [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine

2016-09-15 Thread Michael S. Tsirkin
On Thu, Sep 15, 2016 at 11:19:09AM -0300, Eduardo Habkost wrote: > On Wed, Sep 14, 2016 at 12:01:49PM +0200, Igor Mammedov wrote: > > commit (a4d3c834 pc: Add 2.8 machine) didn't ammend > > PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in > > > > {\ > > .driver =

[Qemu-devel] [PULL v2 5/6] hw/i386: AMD IOMMU IVRS table

2016-09-15 Thread Michael S. Tsirkin
From: David Kiarie Add IVRS table for AMD IOMMU. Generate IVRS or DMAR depending on emulated IOMMU. Signed-off-by: David Kiarie --- include/hw/acpi/aml-build.h | 1 + include/hw/i386/x86-iommu.h | 12 +++ hw/acpi/aml-build.c | 2 +-

[Qemu-devel] [PULL v2 6/6] MAINTAINERS: add virtio-* tests

2016-09-15 Thread Michael S. Tsirkin
From: Greg Kurz Except virtio-9p, all virtio-* tests are orphan. This patch tries to fix it, according to the following logic: - when the related subsystem has its own section in MAINTAINERS, the test is added there - otherwise it is added to the "parent" section (aka. SCSI,

[Qemu-devel] [PATCH v2 1/7] block: Remove bdrv_is_snapshot

2016-09-15 Thread Alberto Garcia
This is unnecessary and has been unused since 5433c24f0f9306c82ad9bcc. Signed-off-by: Alberto Garcia Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake --- block.c | 5 - include/block/block.h | 1 - 2 files changed, 6

[Qemu-devel] [PULL v2 4/6] hw/i386: Introduce AMD IOMMU

2016-09-15 Thread Michael S. Tsirkin
From: David Kiarie Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU. The IOMMU does basic translation, error checking and has a minimal IOTLB implementation. This IOMMU bypassed the need for target aborts by responding with IOMMU_NONE access rights and exempts

Re: [Qemu-devel] [PATCH 1/4] 9pfs: drop unused fmt strings in the proxy backend

2016-09-15 Thread Cédric Le Goater
On 09/15/2016 04:24 PM, Greg Kurz wrote: > The v9fs_request() function doesn't use its fmt argument: it passes literal > format strings to proxy_marshal() for all commands. > > This patch simply drops the unused fmt argument and updates all callers > accordingly. Reviewed-by: Cédric Le Goater

Re: [Qemu-devel] [PATCH 4/4] 9pfs: introduce v9fs_path_sprintf() helper

2016-09-15 Thread Cédric Le Goater
On 09/15/2016 04:24 PM, Greg Kurz wrote: > This helper is similar to v9fs_string_sprintf(), but it includes the > terminating NUL character in the size field. NULL > This is to avoid doing v9fs_string_sprintf((V9fsString *) ) and > then bumping the size. > > Affected users are changed to use

Re: [Qemu-devel] [PATCH] linux-user: fix settime old value location

2016-09-15 Thread Peter Maydell
On 15 September 2016 at 15:52, Marc-André Lureau wrote: > old_value is the 4th argument of timer_settime(), not the 2nd. > > Signed-off-by: Marc-André Lureau > --- > linux-user/syscall.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH 3/4] 9pfs: drop useless v9fs_string_null() function

2016-09-15 Thread Cédric Le Goater
On 09/15/2016 04:24 PM, Greg Kurz wrote: > The v9fs_string_null() function just calls v9fs_string_free(). Also it > only has 4 users, whereas v9fs_string_free() has 87. > > This patch converts users to call directly v9fs_string_free() and drops > the useless function. Reviewed-by: Cédric Le

Re: [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages

2016-09-15 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > /me hides in the corner... > > Cc: Dave Gilbert > Signed-off-by: Paolo Bonzini > --- > hw/i386/kvm/apic.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c >

[Qemu-devel] [PATCH 2/4] 9pfs: drop duplicate line in proxy backend

2016-09-15 Thread Greg Kurz
This double free did not cause harm because v9fs_string_free() sets str->data to NULL and g_free(NULL) is valid. Signed-off-by: Greg Kurz --- hw/9pfs/9p-proxy.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c index

  1   2   3   >