[Qemu-devel] [PULL 08/44] ppc: Fix signal delivery in ppc-user and ppc64-user

2016-09-21 Thread David Gibson
From: Benjamin Herrenschmidt There were a number of bugs in the implementation: - The structure alignment was wrong for 64-bit. - Also 64-bit only does RT signals. - On 64-bit, we need to put a pointer to the (aligned) vector registers in the frame and use it for restoring - We had end

[Qemu-devel] [PULL 22/44] target-ppc: consolidate load operations

2016-09-21 Thread David Gibson
From: Nikunj A Dadhania Implement macro to consolidate load operations using newer tcg_gen_qemu_ld functions. Signed-off-by: Nikunj A Dadhania Signed-off-by: David Gibson --- target-ppc/translate.c | 58 +- 1 file changed, 20 insertions(+), 38 d

[Qemu-devel] [PULL 27/44] target-ppc: convert st[16, 32, 64]r to use new macro

2016-09-21 Thread David Gibson
From: Nikunj A Dadhania Make byte-swap routines use the common GEN_QEMU_STORE macro Signed-off-by: Nikunj A Dadhania Signed-off-by: David Gibson --- target-ppc/translate.c | 32 ++-- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/target-ppc/transla

[Qemu-devel] [PULL 19/44] spapr_vio: convert to trace framework instead of DPRINTF

2016-09-21 Thread David Gibson
From: Laurent Vivier Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake Signed-off-by: David Gibson --- hw/ppc/spapr_vio.c | 17 +++-- hw/ppc/trace-events | 4 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/hw/ppc/spapr_vio.c b/hw/ppc/spapr_vio.c index 4

[Qemu-devel] [PULL 10/44] libqos: define SPAPR libqos functions

2016-09-21 Thread David Gibson
From: Laurent Vivier Define spapr_alloc_init()/spapr_alloc_init_flags()/spapr_alloc_uninit() to allocate and use SPAPR guest memory Define qtest_spapr_vboot()/qtest_spapr_boot()/qtest_spapr_shutdown() to start SPAPR guest with QOSState initialized for it (memory management) Move qtest_irq

[Qemu-devel] [PULL 20/44] spapr_llan: convert to trace framework instead of DPRINTF

2016-09-21 Thread David Gibson
From: Laurent Vivier Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake Signed-off-by: David Gibson --- hw/net/spapr_llan.c | 61 ++--- hw/net/trace-events | 16 ++ 2 files changed, 41 insertions(+), 36 deletions(-) diff --git a/

[Qemu-devel] [PULL 00/44] ppc-for-2.8 queue 20160922

2016-09-21 Thread David Gibson
The following changes since commit a008535b9fa396226ff9cf78b8ac5f3584bda58e: build-sys: fix make install regression (2016-09-20 11:32:43 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160922 for you to fetch changes up to 2832da4b6fc549d5

[Qemu-devel] [PULL 09/44] qtest: replace strtoXX() by qemu_strtoXX()

2016-09-21 Thread David Gibson
From: Laurent Vivier Check the result of qemu_strtoXX() and assert if the string cannot be converted. Signed-off-by: Laurent Vivier Reviewed-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: David Gibson --- qtest.c | 49 ++--- 1 file changed

[Qemu-devel] [PULL 13/44] adb-keys.h: initial commit

2016-09-21 Thread David Gibson
From: John Arbuckle Add the adb-keys.h file. It maps ADB transition key codes with values. Signed-off-by: John Arbuckle Signed-off-by: David Gibson --- include/hw/input/adb-keys.h | 141 1 file changed, 141 insertions(+) create mode 100644 include

[Qemu-devel] [PULL 06/44] target-ppc: add vector bit permute doubleword instruction

2016-09-21 Thread David Gibson
From: Rajalakshmi Srinivasaraghavan Add vbpermd instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan Signed-off-by: David Gibson --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 20 target-ppc/translate/vmx-impl.inc.c

[Qemu-devel] [PULL 15/44] adb.c: correct several key assignments

2016-09-21 Thread David Gibson
From: John Arbuckle The original pc_to_adb_keycode mapping did have several keys that were incorrectly mapped. This patch fixes these mappings. Signed-off-by: John Arbuckle Signed-off-by: David Gibson --- hw/input/adb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PULL 12/44] MAINTAINERS: add sPAPR tests

2016-09-21 Thread David Gibson
From: Greg Kurz Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a9fab46..847b614 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -628,6 +628,10 @@ F: pc-bios/spapr-rtas.bin F: pc-bios/sl

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-21 Thread Cédric Le Goater
On 09/22/2016 08:00 AM, Bharata B Rao wrote: > On Thu, Sep 22, 2016 at 03:30:08PM +1000, David Gibson wrote: >> On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: >>> Hi, >>> >>> Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 >>> to newer QEMU-2.7 is broken like th

[Qemu-devel] [PULL 01/44] MAINTAINERS: Add some missing ppc-related files

2016-09-21 Thread David Gibson
From: Thomas Huth There are some powerpc related files in the QEMU source tree which are currently not covered by the MAINTAINERS file and thus not properly classified by the get_maintainer.pl script. So let's add them to the proper sections. Signed-off-by: Thomas Huth Signed-off-by: David Gibs

[Qemu-devel] [PULL 04/44] target-ppc: add vector extract instructions

2016-09-21 Thread David Gibson
From: Rajalakshmi Srinivasaraghavan The following vector extract instructions are added from ISA 3.0. vextractub - Vector Extract Unsigned Byte vextractuh - Vector Extract Unsigned Halfword vextractuw - Vector Extract Unsigned Word vextractd - Vector Extract Unsigned Doubleword Signed-off-by: R

[Qemu-devel] [PULL 02/44] ppc: restrict the use of the rfi instruction

2016-09-21 Thread David Gibson
From: Benjamin Herrenschmidt Power ISA 2.x has deleted the rfi instruction and rfid shoud be used instead on cpus following this instruction set or later. This will raise an invalid exception when rfi is used on such processors: Book3S 64-bit processors. Signed-off-by: Benjamin Herrenschmidt R

[Qemu-devel] [PATCH] qtest: fix make check complaint in crypto module

2016-09-21 Thread Gonglei
CCtests/test-crypto-tlscredsx509.o CCtests/crypto-tls-x509-helpers.o CCtests/pkix_asn1_tab.o tests/pkix_asn1_tab.c:7:22: warning: libtasn1.h: No such file or directory tests/pkix_asn1_tab.c:9: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘pkix_asn1_tab’ make: **

Re: [Qemu-devel] [PATCH] net: mcf: check buffer descriptor length

2016-09-21 Thread P J P
Hello Paolo, +-- On Wed, 21 Sep 2016, Paolo Bonzini wrote --+ | Not exactly, because addr changes on every call to mcf_fec_read_bd. True, but the initial address 's->tx_descriptor' and 's->etdsr' could be set by user in imx_fec_write(). If bd.flags is set to FEC_BD_W, addr is reset to initi

[Qemu-devel] [PATCH] crypto: add CTR mode support

2016-09-21 Thread Gonglei
Introduce CTR mode support for the cipher APIs. CTR mode uses a counter rather than a traditional IV. The counter has additional properties, including a nonce and initial counter block. We reuse the ctx->iv as the counter for conveniences. Both libgcrypt and nettle support CTR mode, the cipher-bui

Re: [Qemu-devel] KVM-PR is broken with current QEMU

2016-09-21 Thread Thomas Huth
On Wed, 21 Sep 2016 07:45:35 +1000 Benjamin Herrenschmidt wrote: > On Tue, 2016-09-20 at 13:44 +0200, Thomas Huth wrote: > > > > Seems like KVM PR is using the "degraded" ISA variants (without the > > 1TB > > segments), but the new POWERPC_MMU_64K flag has not been added to > > those. > > Has th

Re: [Qemu-devel] [PATCH v2 2/2] e1000: fix buliding complaint

2016-09-21 Thread Jason Wang
On 2016年09月13日 14:00, Dmitry Fleytman wrote: >On 9 Sep 2016, at 10:15 AM, Gonglei (Arei) wrote: > >Who can pick up this patch? Dmitry or Jason? Thanks! Jason, would you please? Picked in my tree. Thanks

Re: [Qemu-devel] [PATCH V14 00/12] Introduce COLO-Proxy

2016-09-21 Thread Jason Wang
On 2016年09月08日 17:46, Zhang Chen wrote: COLO-proxy is a part of COLO project. COLO project is composed of COLO-frame, COLO-proxy and block-replication. It is used to compare the network package to help COLO decide whether to do checkpoint. With COLO-proxy's help, COLO greatly improves the perfo

Re: [Qemu-devel] [PATCH v4 7/9] ppc/xics: Add "native" XICS subclass

2016-09-21 Thread Cédric Le Goater
On 09/22/2016 02:02 AM, David Gibson wrote: > On Mon, Sep 19, 2016 at 11:59:35AM +0530, Nikunj A Dadhania wrote: >> From: Benjamin Herrenschmidt >> >> This provides MMIO based ICP access as found on POWER8 >> >> Signed-off-by: Benjamin Herrenschmidt >> Signed-off-by: Nikunj A Dadhania >> --- >>

Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-21 Thread Leon Alrae
On Wed, Sep 21, 2016 at 07:12:20PM +, Riku Voipio wrote: > On Wed, Sep 21, 2016 at 02:16:54PM +0100, Leon Alrae wrote: > > On Mon, Sep 19, 2016 at 01:44:37PM +0200, Aleksandar Markovic wrote: > > > From: Aleksandar Markovic > > > > > > v6->v7: > > > > > > - Rebased to the latest code. > >

Re: [Qemu-devel] [PATCH] linux-user: fix mremap for 64bit targets on 32bit hosts

2016-09-21 Thread Riku Voipio
Hi, On Sat, Sep 17, 2016 at 09:20:14PM -0400, Felix Janda wrote: > Signed-off-by: Felix Janda Have you run the mremap tests of ltp with this on your host/guest combo? > --- > linux-user/mmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/linux-user/mmap.c b/li

Re: [Qemu-devel] [PATCH v4 5/9] ppc/xics: Use a helper to add a new ICS

2016-09-21 Thread Cédric Le Goater
On 09/22/2016 01:40 AM, David Gibson wrote: > On Mon, Sep 19, 2016 at 11:59:33AM +0530, Nikunj A Dadhania wrote: >> From: Benjamin Herrenschmidt >> >> Signed-off-by: Benjamin Herrenschmidt >> [Move object allocation and adding child to the helper] >> Signed-off-by: Nikunj A Dadhania >> Reviewed-

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-21 Thread Bharata B Rao
On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-09-22 at 10:51 +0530, Bharata B Rao wrote: > > The flag values are expected to remain same for a machine version for > > the migration to succeed, but this expectation is broken now. Should > > we make the additi

[Qemu-devel] [PATCH] pci-testdev: enhance to support new testcases

2016-09-21 Thread Peter Xu
pci-testdev is used mostly in kvm-unit-test for some eventfd tests. However I see it a good framework for other tests as well (e.g., the IOMMU unit test in the future). So enhanced it to support more testcases. The original memory handlers and protocol are strict and not easy to change (we need to

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-21 Thread Benjamin Herrenschmidt
On Thu, 2016-09-22 at 10:51 +0530, Bharata B Rao wrote: > The flag values are expected to remain same for a machine version for > the migration to succeed, but this expectation is broken now. Should > we make the addition of these flags conditional on machine type > version ? > But these flags are

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-21 Thread Bharata B Rao
On Thu, Sep 22, 2016 at 03:30:08PM +1000, David Gibson wrote: > On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: > > Hi, > > > > Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 > > to newer QEMU-2.7 is broken like this: > > > > qemu-system-ppc64: error while loa

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-21 Thread David Gibson
On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: > Hi, > > Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 > to newer QEMU-2.7 is broken like this: > > qemu-system-ppc64: error while loading state for instance 0x0 of device 'cpu' > qemu-system-ppc64: load of mig

Re: [Qemu-devel] [PATCH v6 3/3] intel_iommu: allow UNMAP notifiers

2016-09-21 Thread Peter Xu
On Thu, Sep 22, 2016 at 03:24:43PM +1000, David Gibson wrote: > On Wed, Sep 21, 2016 at 12:58:56PM +0800, Peter Xu wrote: > > Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. > > Before that is achieved, let's open a door for vhost DMAR support, which > > only requires cache in

Re: [Qemu-devel] [PATCH v3 00/10] virtio-crypto: introduce framework and device emulation

2016-09-21 Thread Gonglei (Arei)
Hi Michael, Stefan and Paolo, Would you please help to review virtio stuff in the patch set? Thanks! Regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Monday, September 19, 2016 4:16 PM > Subject: [PATCH v3 00/10] virtio-crypto: introduce framework and device > emula

Re: [Qemu-devel] Missing fix for ui/gtk.c?

2016-09-21 Thread Gerd Hoffmann
On Mi, 2016-09-21 at 11:33 -0500, Wei Huang wrote: > Hi, > > I found that you had a fix for setlocale() in ui/gtk.c. Without it, > non-ASCII can't display correctly on Fedora 24. But I didn't see it in > QEMU tree. Did it slip through the cracks? Problem is setting the locale has side effects els

Re: [Qemu-devel] [PATCH v2] ide: Fix memory leak in ide_register_restart_cb()

2016-09-21 Thread Ashijeet Acharya
On Thu, Sep 22, 2016 at 1:08 AM, John Snow wrote: > > > On 09/21/2016 01:53 PM, Ashijeet Acharya wrote: >> >> Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add >> idebus_unrealize() in hw/ide/qdev.c to have calls to >> qemu_del_vm_change_state_handler() to deal with the dangl

Re: [Qemu-devel] [PATCH v4 3/8] block: don't make snapshots for filters

2016-09-21 Thread Pavel Dovgalyuk
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, September 21, 2016 6:37 PM > To: Pavel Dovgalyuk; qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; jasow...@redhat.com; quint...@redhat.com; > m...@redhat.com > Subject: Re: [PATCH v4 3/8] blo

Re: [Qemu-devel] [PATCH v4 0/8] replay additions

2016-09-21 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 21/09/2016 13:33, Pavel Dovgalyuk wrote: > > This set of patches includes several fixes for replay and > > adds network record/replay for network devices. It also makes possible > > saving/restoring vmstate in replay mode. > > > > Record and r

Re: [Qemu-devel] [PATCH 0/7] virtio: avoid inappropriate QEMU termination

2016-09-21 Thread Fam Zheng
On Wed, 09/21 09:29, Eric Blake wrote: > On 09/21/2016 09:01 AM, Fam Zheng wrote: > > On Wed, 09/21 15:44, Greg Kurz wrote: > >> On Wed, 21 Sep 2016 06:35:04 -0700 (PDT) > >> no-re...@patchew.org wrote: > >> > >>> Hi, > >>> > >>> Your series failed automatic build test. Please find the testing comm

Re: [Qemu-devel] [PATCH v4 2/8] replay: save/load initial state

2016-09-21 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 21/09/2016 17:49, Pavel Dovgalyuk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> On 21/09/2016 13:33, Pavel Dovgalyuk wrote: > >>> +New VM snapshots may be created in replay mode. They can be used later > >>> +to recover the

Re: [Qemu-devel] [Qemu-ppc] KVM-PR is broken with current QEMU

2016-09-21 Thread Thomas Huth
On Thu, 22 Sep 2016 11:57:15 +1000 David Gibson wrote: > On Wed, Sep 21, 2016 at 10:22:11AM +0200, Thomas Huth wrote: > > On 20.09.2016 16:39, Cédric Le Goater wrote: > > > On 09/20/2016 04:24 PM, Thomas Huth wrote: > > >> On 20.09.2016 16:04, Cédric Le Goater wrote: > > [...] > > >>> There are o

Re: [Qemu-devel] [PATCH v6 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-21 Thread David Gibson
On Wed, Sep 21, 2016 at 12:58:54PM +0800, Peter Xu wrote: > IOMMU Notifier list is used for notifying IO address mapping changes. > Currently VFIO is the only user. > > However it is possible that future consumer like vhost would like to > only listen to part of its notifications (e.g., cache inva

Re: [Qemu-devel] [PATCH v6 3/3] intel_iommu: allow UNMAP notifiers

2016-09-21 Thread David Gibson
On Wed, Sep 21, 2016 at 12:58:56PM +0800, Peter Xu wrote: > Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. > Before that is achieved, let's open a door for vhost DMAR support, which > only requires cache invalidations (UNMAP operations). > > Meanwhile, converting hw_error()

[Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-21 Thread Bharata B Rao
Hi, Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 to newer QEMU-2.7 is broken like this: qemu-system-ppc64: error while loading state for instance 0x0 of device 'cpu' qemu-system-ppc64: load of migration failed: Invalid argument Bisecting tells us that 4e0806110c8b896ceff3

Re: [Qemu-devel] [PATCH qemu] spapr_pci: Add numa node id

2016-09-21 Thread David Gibson
On Wed, Sep 14, 2016 at 07:03:50AM -0500, Michael Roth wrote: > Quoting Alexey Kardashevskiy (2016-09-14 04:39:10) > > On 14/09/16 09:29, Michael Roth wrote: > > > Quoting Alexey Kardashevskiy (2016-07-27 03:03:38) > > >> This adds a numa id property to a PHB to allow linking passed PCI device > >

Re: [Qemu-devel] [PATCH qemu] spapr_pci: Add numa node id

2016-09-21 Thread David Gibson
On Wed, Sep 14, 2016 at 07:39:10PM +1000, Alexey Kardashevskiy wrote: > On 14/09/16 09:29, Michael Roth wrote: > > Quoting Alexey Kardashevskiy (2016-07-27 03:03:38) > >> This adds a numa id property to a PHB to allow linking passed PCI device > >> to CPU/memory. It is up to the management stack to

Re: [Qemu-devel] [PATCH v5 1/8] linux-user: Add support for adjtimex() syscall

2016-09-21 Thread Riku Voipio
On Wed, Sep 14, 2016 at 10:19:54PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This patch implements Qemu user mode adjtimex() syscall support. > > Syscall adjtimex() reads and optionally sets parameters for a clock > adjustment algorithm used in network synchonization or s

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

2016-09-21 Thread Chao Gao
Hi, we had 3 problems left here. 1. IRQremapping can't work with x2apic_cluster mode. 2. apic_id > 255 can't receive devices interrupts. 3. windows crash when present IRQremapping capability to it. I test with latest kernel v4.8-rc7 and find all of them are unsolved. Also in the qemu and kernel co

Re: [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select

2016-09-21 Thread Riku Voipio
On Sun, Sep 04, 2016 at 03:49:22PM +0200, Laurent Vivier wrote: > Le 11/07/2016 à 18:59, Peter Maydell a écrit : > > On 8 July 2016 at 00:17, Laurent Vivier wrote: > >> TARGET_NR_select can have three different implementations: > >> > >> 1- to always return -ENOSYS > >> > >> microblaze, ppc

Re: [Qemu-devel] [Qemu-ppc] KVM-PR is broken with current QEMU

2016-09-21 Thread David Gibson
On Wed, Sep 21, 2016 at 10:22:11AM +0200, Thomas Huth wrote: > On 20.09.2016 16:39, Cédric Le Goater wrote: > > On 09/20/2016 04:24 PM, Thomas Huth wrote: > >> On 20.09.2016 16:04, Cédric Le Goater wrote: > [...] > >>> There are other issues after in the guest (kernel crashing). But I think > >>> t

[Qemu-devel] [PATCH] qapi: make the json schema files more regular.

2016-09-21 Thread David Anderson
This makes it easier to parse the schema file for tool generation: each paragraph is either a non-docstring comment, or a docstring immediately followed by a Python dict describing an API item. Signed-off-by: David Anderson --- qapi-schema.json | 3 +-- qapi/block-core.json | 5 - 2 file

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-21 Thread Kirti Wankhede
> My concern is that a type id seems arbitrary but we're specifying that > it be unique. We already have something unique, the name. So why try > to make the type id unique as well? A vendor can accidentally create > their vendor driver so that a given name means something ver

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-21 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Thursday, September 22, 2016 11:02 AM > > On Thu, 22 Sep 2016 02:33:01 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Wednesday, September 21, 2016 12:37 PM > > > > > >

Re: [Qemu-devel] [PATCH for 2.8 2/2] Added Traditional Chinese translation

2016-09-21 Thread Peter Xu
On Thu, Sep 22, 2016 at 11:16:03AM +0800, Fam Zheng wrote: > On Thu, 09/22 10:34, Peter Xu wrote: > > So we are using traditional Chinese? That's fine to me though. :) > > We have had simplified Chinese in the tree since years ago. This one is in > addition to that. Yeah I just realized that. :)

Re: [Qemu-devel] [PATCH for 2.8 2/2] Added Traditional Chinese translation

2016-09-21 Thread Peter Xu
On Wed, Sep 21, 2016 at 09:44:03PM -0500, Wei Huang wrote: > > > On 09/21/2016 09:34 PM, Peter Xu wrote: > > On Wed, Sep 21, 2016 at 11:27:24AM -0500, Wei Huang wrote: > >> Add Traditional Chinese (zh_TW) translation to QEMU. The translations > >> use other virt software, such as virt-manger, as

Re: [Qemu-devel] [PATCH for 2.8 2/2] Added Traditional Chinese translation

2016-09-21 Thread Fam Zheng
On Thu, 09/22 10:34, Peter Xu wrote: > So we are using traditional Chinese? That's fine to me though. :) We have had simplified Chinese in the tree since years ago. This one is in addition to that. Fam

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-21 Thread Alex Williamson
On Thu, 22 Sep 2016 02:33:01 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Wednesday, September 21, 2016 12:37 PM > > > > On Wed, 21 Sep 2016 03:56:21 + > > "Tian, Kevin" wrote: > > > > > > From: Kirti Wankhede [mailto:kwankh...@nvidia

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-21 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Thursday, September 22, 2016 10:33 AM > > > > > > Another example is class-specific attributes such > > > as 'resolution', etc. which you listed under 'display class'. All those > > > attributes should be moved to mdev directory. Only class ID is > > > required under ea

Re: [Qemu-devel] [PATCH v2 2/8] nvdimm acpi: prebuild nvdimm devices for available slots

2016-09-21 Thread Xiao Guangrong
On 09/21/2016 07:48 PM, Igor Mammedov wrote: On Fri, 12 Aug 2016 14:54:04 +0800 Xiao Guangrong wrote: For each NVDIMM present or intended to be supported by platform, platform firmware also exposes an ACPI Namespace Device under the root device So it builds nvdimm devices for all slots to s

Re: [Qemu-devel] [PATCH for 2.8 2/2] Added Traditional Chinese translation

2016-09-21 Thread Wei Huang
On 09/21/2016 09:34 PM, Peter Xu wrote: > On Wed, Sep 21, 2016 at 11:27:24AM -0500, Wei Huang wrote: >> Add Traditional Chinese (zh_TW) translation to QEMU. The translations >> use other virt software, such as virt-manger, as references. >> >> CC: Peter Xu >> CC: Fam Zheng >> Signed-off-by: Wei

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-21 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, September 21, 2016 12:43 PM > > On Wed, 21 Sep 2016 04:10:53 + > "Tian, Kevin" wrote: > > > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > > Sent: Wednesday, September 21, 2016 12:23 AM > > > > > > > > >

Re: [Qemu-devel] [PATCH for 2.8 2/2] Added Traditional Chinese translation

2016-09-21 Thread Peter Xu
On Wed, Sep 21, 2016 at 11:27:24AM -0500, Wei Huang wrote: > Add Traditional Chinese (zh_TW) translation to QEMU. The translations > use other virt software, such as virt-manger, as references. > > CC: Peter Xu > CC: Fam Zheng > Signed-off-by: Wei Huang Reviewed-by: Peter Xu So we are using

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-21 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, September 21, 2016 12:37 PM > > On Wed, 21 Sep 2016 03:56:21 + > "Tian, Kevin" wrote: > > > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > > Sent: Tuesday, September 20, 2016 10:22 PM > > > >> > > > >> '

Re: [Qemu-devel] [PATCH] eepro100: Frame Reception

2016-09-21 Thread Jason Wang
On 2016年08月24日 00:46, Mateus Krepsky Ludwich wrote: Changed E100 device so it updates EOF, F, and Actual Count fields of Receive Frame Descriptor (RFD). Actual Count fields were updated before this patch I think? Assuming RFD.actual_count equals to size. Signed-off-by: Mateus Krepsky Ludwi

Re: [Qemu-devel] [PATCH 0/7] virtio: avoid inappropriate QEMU termination

2016-09-21 Thread Gonglei
On 2016/9/21 21:13, Greg Kurz wrote: > This series is a follow up to Stefan's work to eradicate most calls to > exit() we currently have in the virtio code. > > It addresses all exit() call sites in the blk, net and scsi device code, > where the error is about a missing or malformed in/out heade

Re: [Qemu-devel] [PATCH] rbd : disable rbd_cache_writethrough_until_flush for cache=unsafe

2016-09-21 Thread Josh Durgin
On 07/27/2016 05:26 AM, Alexandre Derumier wrote: ceph force writethrough until a flush is detected. With cache=unsafe, we never send flush. So we need to tell to ceph to set rbd_cache_writethrough_until_flush=false in this case. This speedup a lot qemu-img convert which use cache=unsafe by defa

Re: [Qemu-devel] [PATCH] monitor: fix crash for platforms without a CPU 0

2016-09-21 Thread David Gibson
On Wed, Sep 21, 2016 at 09:14:02AM -0300, Eduardo Habkost wrote: > On Wed, Sep 21, 2016 at 03:29:26PM +1000, David Gibson wrote: > > Now that we allow CPU hot unplug on a few platforms, we can end up in a > > situation where we don't have a CPU with index 0. Or at least we could, > > if we didn't

Re: [Qemu-devel] [PATCH v4 9/9] ppc/xics: move set_nr_{irqs, servers} to xics.c

2016-09-21 Thread David Gibson
On Mon, Sep 19, 2016 at 11:59:37AM +0530, Nikunj A Dadhania wrote: > Get this duplicate code in the base implementation. > > Signed-off-by: Nikunj A Dadhania > --- > hw/intc/xics.c| 74 > --- > hw/intc/xics_kvm.c| 34 +++---

Re: [Qemu-devel] [PATCH] monitor: fix crash for platforms without a CPU 0

2016-09-21 Thread David Gibson
On Wed, Sep 21, 2016 at 10:50:49AM -0400, Luiz Capitulino wrote: > On Wed, 21 Sep 2016 15:29:26 +1000 > David Gibson wrote: > > > Now that we allow CPU hot unplug on a few platforms, we can end up in a > > situation where we don't have a CPU with index 0. Or at least we could, > > if we didn't h

Re: [Qemu-devel] [PATCH v4 5/9] ppc/xics: Use a helper to add a new ICS

2016-09-21 Thread David Gibson
On Mon, Sep 19, 2016 at 11:59:33AM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > Signed-off-by: Benjamin Herrenschmidt > [Move object allocation and adding child to the helper] > Signed-off-by: Nikunj A Dadhania > Reviewed-by: David Gibson > --- > hw/intc/xics.c|

Re: [Qemu-devel] [PATCH v4 7/9] ppc/xics: Add "native" XICS subclass

2016-09-21 Thread David Gibson
On Mon, Sep 19, 2016 at 11:59:35AM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > This provides MMIO based ICP access as found on POWER8 > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Nikunj A Dadhania > --- > default-configs/ppc64-softmmu.mak | 3 +- > hw/in

Re: [Qemu-devel] [PATCH v4 8/9] ppc/xics: Add xics to the monitor "info pic" command

2016-09-21 Thread David Gibson
On Mon, Sep 19, 2016 at 11:59:36AM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > Useful to debug interrupt problems. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Nikunj A Dadhania > --- > hmp-commands-info.hx | 2 ++ > hw/intc/xics.c| 38 ++

Re: [Qemu-devel] [PATCH] Add resolutions via the command-line

2016-09-21 Thread Benjamin Herrenschmidt
On Wed, 2016-09-21 at 19:18 -0400, G 3 wrote: >  > That can be done, but I was hoping to be able to do this via a   > command-line switch. But you still do that ! Your switch puts stuff in /options which OpenBIOS then picks up to construct the final list that it puts in the driver node. > That w

Re: [Qemu-devel] [PATCH] net: hmp_host_net_remove: Del the -net option of the removed host_net

2016-09-21 Thread Jason Wang
On 2016年09月05日 17:11, Shmulik Ladkani wrote: Upon hmp_host_net_remove(), the appropriate -net client is deleted (according to the given vlan_id and device id), as well as the corresponsing hub port. However, the relevant '-net' option that was added by former hmp_host_net_add() call is still p

Re: [Qemu-devel] [PATCH] Add resolutions via the command-line

2016-09-21 Thread G 3
On Sep 21, 2016, at 5:53 PM, Benjamin Herrenschmidt wrote: On Wed, 2016-09-21 at 14:26 -0400, G 3 wrote: Nodes like chose, aliases, openprom are of class IOService. options is of class IODTNVRAM. It looks like this class has problems. I'm thinking since Alexander Graf did work in the mac_nvra

Re: [Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-21 Thread ashish mittal
libqnio source has been updated. qemu changes should now build properly. https://github.com/MittalAshish/libqnio.git I will work on the other suggestions and get back. Regards, Ashish On Wed, Sep 21, 2016 at 8:03 AM, Paolo Bonzini wrote: > > > On 21/09/2016 03:07, Ashish Mittal wrote: >> +int3

Re: [Qemu-devel] [PATCH 16/16] cpus-common: lock-free fast path for cpu_exec_start/end

2016-09-21 Thread Emilio G. Cota
On Mon, Sep 19, 2016 at 14:50:59 +0200, Paolo Bonzini wrote: (snip) > @@ -212,24 +216,75 @@ void end_exclusive(void) > /* Wait for exclusive ops to finish, and begin cpu execution. */ > void cpu_exec_start(CPUState *cpu) > { > -qemu_mutex_lock(&qemu_cpu_list_mutex); > -exclusive_idle();

Re: [Qemu-devel] [PATCH 16/16] cpus-common: lock-free fast path for cpu_exec_start/end

2016-09-21 Thread Emilio G. Cota
On Wed, Sep 21, 2016 at 20:19:18 +0200, Paolo Bonzini wrote: (snip) > No, this is not true. Barriers order stores and loads within a thread > _and_ establish synchronizes-with edges. > > In the example above you are violating causality: > > - cpu0 stores cpu->running before loading pending_cpus

Re: [Qemu-devel] [PATCH] Add resolutions via the command-line

2016-09-21 Thread Benjamin Herrenschmidt
On Wed, 2016-09-21 at 14:26 -0400, G 3 wrote: > > Nodes like chose, aliases, openprom are of class IOService. options   > is of class IODTNVRAM. It looks like this class has problems. I'm   > thinking since Alexander Graf did work in the mac_nvram.c file, he   > might know what is wrong. What is

Re: [Qemu-devel] [PATCH v2 4/4] iotests: fix expected error message

2016-09-21 Thread Marc-André Lureau
- Original Message - > On 09/21/2016 03:10 PM, Marc-André Lureau wrote: > > Missing argument returns a corresponding error message for all types > > now. > > > > The "old" qmp dispatch code didn't return QERR_MISSING_PARAMETER for > > argument structure members (it returned QERR_INVALID_

Re: [Qemu-devel] [PATCH v2 3/4] qapi: return a 'missing parameter' error

2016-09-21 Thread Eric Blake
On 09/21/2016 03:10 PM, Marc-André Lureau wrote: > The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing > parameters, but the qapi qmp_dispatch() code uses > QERR_INVALID_PARAMETER_TYPE. > > Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where > appropriate. > > Signed-o

Re: [Qemu-devel] [PATCH v2 4/4] iotests: fix expected error message

2016-09-21 Thread Eric Blake
On 09/21/2016 03:10 PM, Marc-André Lureau wrote: > Missing argument returns a corresponding error message for all types > now. > > The "old" qmp dispatch code didn't return QERR_MISSING_PARAMETER for > argument structure members (it returned QERR_INVALID_PARAMETER). Only > for top-level argument i

[Qemu-devel] [PATCH] Fix tlb_vaddr_to_host with CONFIG_USER_ONLY

2016-09-21 Thread Benjamin Herrenschmidt
We use the wrong argument name for the g2h() macro ! The result ends up being something like (target_ulong)(uint64) + guest_base which is obviously wrong. Signed-off-by: Benjamin Herrenschmidt --- include/exec/cpu_ldst.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includ

Re: [Qemu-devel] [PATCH v2 2/4] qapi: assert list entry has a value

2016-09-21 Thread Eric Blake
On 09/21/2016 03:10 PM, Marc-André Lureau wrote: > This helps to figure out the expectations. > > Signed-off-by: Marc-André Lureau > --- > qapi/qmp-input-visitor.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake > > diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visit

Re: [Qemu-devel] [PATCH v2 1/4] qapi: add assert about root value

2016-09-21 Thread Eric Blake
On 09/21/2016 03:10 PM, Marc-André Lureau wrote: > qiv->root should not be null, make that clearer with some assert. > > Signed-off-by: Marc-André Lureau > --- > qapi/qmp-input-visitor.c | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com

Re: [Qemu-devel] [PATCH 5/6] target-i386: Automatically set level/xlevel/xlevel2 when needed

2016-09-21 Thread Richard Henderson
On 09/21/2016 01:14 PM, Eduardo Habkost wrote: On Wed, Sep 21, 2016 at 12:53:08PM -0700, Richard Henderson wrote: On 09/21/2016 11:26 AM, Eduardo Habkost wrote: +/* Set cpuid_*level* based on cpuid_min_*level, if not explicitly set */ +if (!env->cpuid_level) { +env->cpuid_level

Re: [Qemu-devel] [PATCH] dma: xlnx-zynq-devcfg: Fix up XLNX_ZYNQ_DEVCFG_R_MAX

2016-09-21 Thread Alistair Francis
On Wed, Sep 21, 2016 at 11:09 AM, Nathan Rossi wrote: > Whilst according to the Zynq TRM this device covers a register region of > 0x000 - 0x120. The register region is also shared with XADCIF prefix > registers at 0x100 and above. Due to how the devcfg and the xadc devices > are implemented in QE

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-21 Thread Corey Minyard
On 09/21/2016 03:20 PM, Eduardo Habkost wrote: Hi, I was looking at the monitor code handling the "current CPU", and noticed that qmp_inject_nmi() looks suspicious: it is a QMP command, but uses monitor_get_cpu_index(). In addition to the "inject-nmi" QMP command, qmp_inject_nmi() is used at: *

[Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-21 Thread Eduardo Habkost
Hi, I was looking at the monitor code handling the "current CPU", and noticed that qmp_inject_nmi() looks suspicious: it is a QMP command, but uses monitor_get_cpu_index(). In addition to the "inject-nmi" QMP command, qmp_inject_nmi() is used at: * hmp_inject_nmi() * ipmi_do_hw_op() (IPMI_SEND_NM

Re: [Qemu-devel] [PATCH 2/2] target-mips: reimplement SC instruction and use cmpxchg

2016-09-21 Thread Richard Henderson
On 09/21/2016 01:07 AM, Leon Alrae wrote: +tcg_gen_brcond_tl(TCG_COND_EQ, addr, cpu_lladdr, l1); +tcg_temp_free(addr); +tcg_gen_movi_tl(t0, 0); +tcg_gen_br(done); + +gen_set_label(l1); +/* generate cmpxchg */ +val = tcg_temp_new(); +gen_load_gpr(val, rt); +tcg_

Re: [Qemu-devel] [PATCH 5/6] target-i386: Automatically set level/xlevel/xlevel2 when needed

2016-09-21 Thread Eduardo Habkost
On Wed, Sep 21, 2016 at 12:53:08PM -0700, Richard Henderson wrote: > On 09/21/2016 11:26 AM, Eduardo Habkost wrote: > > +/* Set cpuid_*level* based on cpuid_min_*level, if not explicitly set > > */ > > +if (!env->cpuid_level) { > > +env->cpuid_level = env->cpuid_min_level; > > +

[Qemu-devel] [PATCH v2 4/4] iotests: fix expected error message

2016-09-21 Thread Marc-André Lureau
Missing argument returns a corresponding error message for all types now. The "old" qmp dispatch code didn't return QERR_MISSING_PARAMETER for argument structure members (it returned QERR_INVALID_PARAMETER). Only for top-level argument it did return QERR_MISSING_PARAMETER. It is preferable to have

[Qemu-devel] [PATCH v2 3/4] qapi: return a 'missing parameter' error

2016-09-21 Thread Marc-André Lureau
The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing parameters, but the qapi qmp_dispatch() code uses QERR_INVALID_PARAMETER_TYPE. Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where appropriate. Signed-off-by: Marc-André Lureau Reviewed-by: Alberto Garcia --- qapi/

[Qemu-devel] [PATCH v2 2/4] qapi: assert list entry has a value

2016-09-21 Thread Marc-André Lureau
This helps to figure out the expectations. Signed-off-by: Marc-André Lureau --- qapi/qmp-input-visitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c index be52aaf..c1019d6 100644 --- a/qapi/qmp-input-visitor.c +++ b/qapi/qmp-input-visit

[Qemu-devel] [PATCH] timer: a9gtimer: check auto-increment register value

2016-09-21 Thread P J P
From: Prasad J Pandit ARM A9MP processor has a peripheral timer with an auto-increment register, which holds an increment step value. A user could set this value to zero, when auto-increment control bit is enabled. This leads to an infinite loop in 'a9_gtimer_update' while updating comparator val

[Qemu-devel] [PATCH v2 0/4] qapi: return 'missing parameter' error

2016-09-21 Thread Marc-André Lureau
Hi, 'monitor: use qmp_dispatch()' patch broke some iotests expecting a 'missing parameter' error. This series fixes qapi visitors to return this error for all types. v2: - add some assert() for expected values in qmp-input-visitor, making it more explicit when qmp_input_get_object() may return

[Qemu-devel] [PATCH v2 1/4] qapi: add assert about root value

2016-09-21 Thread Marc-André Lureau
qiv->root should not be null, make that clearer with some assert. Signed-off-by: Marc-André Lureau --- qapi/qmp-input-visitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c index 64dd392..be52aaf 100644 --- a/qapi/qmp-input-visitor.c +

Re: [Qemu-devel] [PATCH v3] scripts: Add a script to check for bug URLs in the git log

2016-09-21 Thread Paolo Bonzini
On 21/09/2016 21:42, Thomas Huth wrote: > Basic idea of this script is to check the git log for URLs > to the QEMU bugtracker at launchpad.net and to figure out > whether the related bug has been marked there as "Fix released" > (i.e. closed) already. So this script can e.g. be used after > each pu

Re: [Qemu-devel] [PATCH] qmp: fix object-add assert() without props

2016-09-21 Thread Paolo Bonzini
On 21/09/2016 21:41, Marc-André Lureau wrote: > Since commit ad739706bbadee49, user_creatable_add_type() expects to be > given a qdict. However, if object-add is called without props, you reach > the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: > Assertion `qdict' failed.",

Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema

2016-09-21 Thread Marc-André Lureau
Hi - Original Message - > On 09/13/2016 08:01 AM, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > docs/qmp-commands.txt | 29 - > > qapi-schema.json | 13 + > > 2 files changed, 13 insertions(+), 29 deletions(-) > >

Re: [Qemu-devel] [PATCH v3] scripts: Add a script to check for bug URLs in the git log

2016-09-21 Thread Eric Blake
On 09/21/2016 02:42 PM, Thomas Huth wrote: > Basic idea of this script is to check the git log for URLs > to the QEMU bugtracker at launchpad.net and to figure out > whether the related bug has been marked there as "Fix released" > (i.e. closed) already. So this script can e.g. be used after > each

  1   2   3   4   5   >