[Qemu-devel] [Bug 1258168] Re: QEMU fails to build on CentOS 5.10 with --disable-pie reporting "/usr/bin/ld: -f may not be used without -shared "

2016-09-22 Thread T. Huth
libcacard has been removed from the QEMU sources and is an external project now, so this problem should not exist anymore with the latest version of QEMU. If it still persists, please feel free to re-open this ticket. ** Changed in: qemu Status: New => Invalid -- You received this bug not

Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-09-22 Thread Xiao Long Jiang
Hi, I have tested this patch on arch s390 system. It works fine. :-) On 2016/9/23 上午4:39, Marc-André Lureau wrote: Since commit ad739706bbadee49, user_creatable_add_type() expects to be given a qdict. However, if object-add is called without props, you reach the assert: "qemu/qom/object_interfa

Re: [Qemu-devel] [PATCH V5 2/2] arm: virt: add PMU property to mach-virt machine type

2016-09-22 Thread Andrew Jones
On Thu, Sep 22, 2016 at 11:13:23AM -0400, Wei Huang wrote: > CPU vPMU is now turned off by default, but it was ON in virt-2.7 > machine type. To solve this problem, this patch adds a PMU option > in machine state, which is used to control CPU's vPMU status. This > PMU option is not exposed to comma

Re: [Qemu-devel] [PATCH 1/1] qom: fix qdict visit in user_creatable_add_type

2016-09-22 Thread Xiao Long Jiang
Hi Markus, On 2016/9/22 下午7:56, Markus Armbruster wrote: Xiao Long Jiang writes: This fixes a Qemu crash that introduced by commit ad73970 ("qom: Wrap prop visit in visit_start_struct"). Not all of the callers of user_creatable_add_type always pass qdict, so we should check qdict against NUL

Re: [Qemu-devel] [PATCH V5 1/2] arm64: Add an option to turn on/off vPMU support

2016-09-22 Thread Andrew Jones
On Thu, Sep 22, 2016 at 11:13:22AM -0400, Wei Huang wrote: > This patch adds a pmu=[on/off] option to enable/disable vPMU support > in guest vCPU. This option is only available for cortex-a57/cortex-53/ > host under both TCG and KVM modes, but unavailable on ARMv7 and other > processors. It allows

Re: [Qemu-devel] [PATCH] hw/arm/boot: allow using a command line specified dtb without a kernel

2016-09-22 Thread Michael Olbrich
On Thu, Sep 22, 2016 at 05:23:17PM +0100, Peter Maydell wrote: > On 10 September 2016 at 16:07, Michael Olbrich > wrote: > > When kernel and device tree are specified in the QEMU commandline, then > > this device tree may be modified e.g. to add virtio_mmio devices. > > With a bootloader e.g. on

Re: [Qemu-devel] [PATCH v2] net: imx: limit buffer descriptor count

2016-09-22 Thread Jason Wang
On 2016年09月23日 13:17, Jason Wang wrote: On 2016年09月22日 18:32, Paolo Bonzini wrote: On 22/09/2016 12:31, P J P wrote: From: Prasad J Pandit i.MX Fast Ethernet Controller uses buffer descriptors to manage data flow to/fro receive & transmit queues. While transmitting packets, it could cont

Re: [Qemu-devel] [PATCH v4 1/8] record/replay: add network support

2016-09-22 Thread Jason Wang
On 2016年09月21日 19:33, Pavel Dovgalyuk wrote: This patch adds support of recording and replaying network packets in irount rr mode. Record and replay for network interactions is performed with the network filter. Each backend must have its own instance of the replay filter as follows: -netdev

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread David Gibson
On Fri, Sep 23, 2016 at 01:27:19PM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2016-09-23 at 11:37 +1000, David Gibson wrote: > > > > For KVM HV there's a bit of a nit: that would disallow migration > > between host cpus which aren't exactly the same model, but are close > > enough that migrati

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

2016-09-22 Thread Lan Tianyu
On 2016年09月23日 13:26, Peter Xu wrote: > On Thu, Sep 22, 2016 at 12:34:36PM +0800, Chao Gao wrote: >> Hi, we had 3 problems left here. >> 1. IRQremapping can't work with x2apic_cluster mode. >> 2. apic_id > 255 can't receive devices interrupts. >> 3. windows crash when present IRQremapping capabilit

Re: [Qemu-devel] [PATCH 2/3] qemu: Implement virtio-pstore device

2016-09-22 Thread Namhyung Kim
On Thu, Sep 22, 2016 at 01:23:16PM +0100, Stefan Hajnoczi wrote: > On Sun, Sep 04, 2016 at 11:38:59PM +0900, Namhyung Kim wrote: > > +static void virtio_pstore_handle_io(VirtIODevice *vdev, VirtQueue *vq) > > +{ > > +VirtIOPstore *s = VIRTIO_PSTORE(vdev); > > +VirtQueueElement *elem; > > +

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-09-22 Thread Namhyung Kim
Hi Stefan, On Thu, Sep 22, 2016 at 12:57:44PM +0100, Stefan Hajnoczi wrote: > On Sun, Sep 04, 2016 at 11:38:58PM +0900, Namhyung Kim wrote: > > The virtio pstore driver provides interface to the pstore subsystem so > > that the guest kernel's log/dump message can be saved on the host > > machine.

Re: [Qemu-devel] [PATCH] imx_fec: fix error in qemu_send_packet argument

2016-09-22 Thread Jason Wang
On 2016年09月22日 22:28, Paolo Bonzini wrote: This uses the wrong frame size for packets composed of multiple descriptors. Signed-off-by: Paolo Bonzini --- hw/net/imx_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 1c415ab..5

Re: [Qemu-devel] [PATCH] tcg: increase MAX_OP_PER_INSTR to 395

2016-09-22 Thread Laurent Desnogues
Hello, On Fri, Sep 23, 2016 at 1:53 AM, Joseph Myers wrote: > MAX_OP_PER_INSTR is currently 266, reported in commit > 14dcdac82f398cbac874c8579b9583fab31c67bf to be the worst case for the > ARM A64 decoder. > > Whether or not it was in fact the worst case at that time in 2014, I'm > observing the

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

2016-09-22 Thread Peter Xu
On Thu, Sep 22, 2016 at 12:34:36PM +0800, Chao Gao wrote: > Hi, we had 3 problems left here. > 1. IRQremapping can't work with x2apic_cluster mode. > 2. apic_id > 255 can't receive devices interrupts. > 3. windows crash when present IRQremapping capability to it. For (3), I don't know whether it's

[Qemu-devel] [PATCH v2] x86: ioapic: boost default version to 0x20

2016-09-22 Thread Peter Xu
It's 2.8 now, and maybe it's time to switch IOAPIC default version to 0x20. Signed-off-by: Peter Xu --- V2: - keep compatible for qemu version <= 2.7 [Paolo] hw/intc/ioapic.c| 2 +- include/hw/compat.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/intc/ioapic.c

Re: [Qemu-devel] [PATCH 0/7] e1000e: A few fixes for RX data path

2016-09-22 Thread Jason Wang
On 2016年09月15日 14:14, Dmitry Fleytman wrote: This series contains a few RX logic fixes for e1000e. These fixes improve compliance to HW device specification and fix occasional interruptions of RX traffic with the latest linux driver. Dmitry Fleytman (7): e1000e: Flush all receive queues on

Re: [Qemu-devel] [V0 1/1] virtio crypto device specification: asymmetric crypto service

2016-09-22 Thread Zeng, Xin
On Wednesday, September 21, 2016 3:03 PM, Gonglei (Arei) Wrote: > > -Original Message- > > From: Xin Zeng [mailto:xin.z...@intel.com] > > Sent: Wednesday, September 21, 2016 1:15 PM > > To: virtio-...@lists.oasis-open.org; qemu-devel@nongnu.org; Gonglei > (Arei) > > Cc: m...@redhat.com; bri

Re: [Qemu-devel] [PATCH v2] net: mcf: limit buffer descriptor count

2016-09-22 Thread Jason Wang
On 2016年09月22日 18:33, Paolo Bonzini wrote: On 22/09/2016 12:32, P J P wrote: From: Prasad J Pandit ColdFire Fast Ethernet Controller uses buffer descriptors to manage data flow to/fro receive & transmit queues. While transmitting packets, it could continue to read buffer descriptors if a bu

Re: [Qemu-devel] [PATCH v2] net: imx: limit buffer descriptor count

2016-09-22 Thread Jason Wang
On 2016年09月22日 18:32, Paolo Bonzini wrote: On 22/09/2016 12:31, P J P wrote: From: Prasad J Pandit i.MX Fast Ethernet Controller uses buffer descriptors to manage data flow to/fro receive & transmit queues. While transmitting packets, it could continue to read buffer descriptors if a buffer

[Qemu-devel] [PULL 16/23] docker: Generate /packages.txt in fedora image

2016-09-22 Thread Fam Zheng
Put the list of package names in an environment, and output their package names to the target file in the end. Signed-off-by: Fam Zheng Message-Id: <1474429768-25027-3-git-send-email-f...@redhat.com> Reviewed-by: Daniel P. Berrange --- tests/docker/dockerfiles/fedora.docker | 14 --

[Qemu-devel] [PULL 22/23] docker: Terminate instances at SIGTERM and SIGHUP

2016-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <1474429768-25027-9-git-send-email-f...@redhat.com> Reviewed-by: Daniel P. Berrange --- tests/docker/docker.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 71b0d27..37d8319 10075

[Qemu-devel] [PULL 21/23] docker: Support showing environment information

2016-09-22 Thread Fam Zheng
Add a make variable SHOW_ENV. When it's set to non empty, print the package information and environment variables. Signed-off-by: Fam Zheng Message-Id: <1474429768-25027-8-git-send-email-f...@redhat.com> Reviewed-by: Daniel P. Berrange --- tests/docker/Makefile.include | 2 +- tests/docker/run

[Qemu-devel] [PULL 18/23] docker: Update fedora image to latest

2016-09-22 Thread Fam Zheng
Now that 23 is becoming an "old" release with 24 available. Fedora has a quick release cycle, so use latest to follow more closely. Signed-off-by: Fam Zheng Message-Id: <1474429768-25027-5-git-send-email-f...@redhat.com> Reviewed-by: Daniel P. Berrange --- tests/docker/dockerfiles/fedora.docker

[Qemu-devel] [PULL 19/23] docker: Flatten default target list in test-quick

2016-09-22 Thread Fam Zheng
Previously it is expanded to a whitespace separated list which is not the most appropriate format. Since it's only two items, flatten it. Signed-off-by: Fam Zheng Message-Id: <1474429768-25027-6-git-send-email-f...@redhat.com> Reviewed-by: Daniel P. Berrange --- tests/docker/test-quick | 2 +-

Re: [Qemu-devel] [PATCH] mcf_fec: fix error in qemu_send_packet argument

2016-09-22 Thread Jason Wang
On 2016年09月22日 22:28, Paolo Bonzini wrote: This uses the wrong frame size for packets composed of multiple descriptors. Signed-off-by: Paolo Bonzini --- hw/net/mcf_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/mcf_fec.c b/hw/net/mcf_fec.c index 0ee8ad9..5

[Qemu-devel] [PULL 15/23] docker: Generate /packages.txt in centos6 image

2016-09-22 Thread Fam Zheng
Put the list of package names in an environment, and output their package names to the target file in the end. Signed-off-by: Fam Zheng Message-Id: <1474429768-25027-2-git-send-email-f...@redhat.com> Reviewed-by: Daniel P. Berrange --- tests/docker/dockerfiles/centos6.docker | 6 -- 1 file

[Qemu-devel] [PULL 17/23] docker: Generate /packages.txt in ubuntu image

2016-09-22 Thread Fam Zheng
Put the list of package names in an environment, and output their package names to the target file in the end. Signed-off-by: Fam Zheng Message-Id: <1474429768-25027-4-git-send-email-f...@redhat.com> Reviewed-by: Daniel. P. Berrange --- tests/docker/dockerfiles/ubuntu.docker | 4 +++- 1 file ch

[Qemu-devel] [PULL 11/23] uuid: Tighten uuid parse

2016-09-22 Thread Fam Zheng
sscanf is relatively loose (tolerate) on some invalid formats that we should fail instead of generating a wrong uuid structure, like with whitespaces and short strings. Add and use a helper function to first check the format. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Co

[Qemu-devel] [PULL 23/23] docker: exec $CMD

2016-09-22 Thread Fam Zheng
This is the last command to run (unless DEBUG), make it 'exec' to simplify the process tree. Signed-off-by: Fam Zheng Message-Id: <1474429768-25027-10-git-send-email-f...@redhat.com> Reviewed-by: Daniel P. Berrange --- tests/docker/run | 15 +-- 1 file changed, 9 insertions(+), 6 de

[Qemu-devel] [PULL 12/23] tests: Add uuid tests

2016-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Jeff Cody Message-Id: <1474432046-325-12-git-send-email-f...@redhat.com> --- tests/Makefile.include | 2 + tests/test-uuid.c | 177 + 2 files changed, 179 insertions(+) create mode 100644 tests/test-uui

[Qemu-devel] [PULL 14/23] tests: Ignore test-uuid

2016-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <1474432046-325-14-git-send-email-f...@redhat.com> Reviewed-by: Jeff Cody Reviewed-by: Daniel P. Berrange --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index b4a9cfc..24ac6cf 100644 --- a/tests/.

[Qemu-devel] [PULL 04/23] vhdx: Use QEMU UUID API

2016-09-22 Thread Fam Zheng
This removes our dependency to libuuid, so that the driver can always be built. Similar to how we handled data plane configure options, --enable-vhdx and --disable-vhdx are also changed to a nop with a message saying it's obsolete. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: J

[Qemu-devel] [PULL 05/23] vdi: Use QEMU UUID API

2016-09-22 Thread Fam Zheng
The UUID operations we need from libuuid are fully supported by QEMU UUID implementation. Use it, and remove the unused code. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody Message-Id: <1474432046-325-5-git-send-email-f...@redhat.com> --- block/vdi.c | 73 +

[Qemu-devel] [PULL 13/23] Add UUID files to MAINTAINERS

2016-09-22 Thread Fam Zheng
I understand that we've been keeping eyes on the uncovered files. Since I'm adding some more files I volunteer to look after them in the futuer. Signed-off-by: Fam Zheng Reviewed-by: Jeff Cody Message-Id: <1474432046-325-13-git-send-email-f...@redhat.com> --- MAINTAINERS | 7 +++ 1 file cha

[Qemu-devel] [PULL 20/23] docker: Print used options before doing configure

2016-09-22 Thread Fam Zheng
This makes the configure command more obvious which usually has useful information. Signed-off-by: Fam Zheng Message-Id: <1474429768-25027-7-git-send-email-f...@redhat.com> Reviewed-by: Daniel P. Berrange --- tests/docker/common.rc | 14 -- 1 file changed, 8 insertions(+), 6 deletio

[Qemu-devel] [PULL 08/23] tests: No longer dependent on CONFIG_UUID

2016-09-22 Thread Fam Zheng
crypto now uses built-in uuid implementation, so this check is not needed. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody Message-Id: <1474432046-325-8-git-send-email-f...@redhat.com> Reviewed-by: Daniel P. Berrange --- tests/test-crypto-block.c | 2 +- 1 file changed

[Qemu-devel] [PULL 09/23] configure: Remove detection code for UUID

2016-09-22 Thread Fam Zheng
All code now uses built-in UUID implementation. Remove the code of libuuid and make --enable-uuid and --disable-uuid only print a message. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody Message-Id: <1474432046-325-9-git-send-email-f...@redhat.com> --- configure | 43 ++

[Qemu-devel] [PULL 10/23] vl: Switch qemu_uuid to QemuUUID

2016-09-22 Thread Fam Zheng
Update all qemu_uuid users as well, especially get rid of the duplicated low level g_strdup_printf, sscanf and snprintf calls with QEMU UUID API. Since qemu_uuid_parse is quite tangled with qemu_uuid, its switching to QemuUUID is done here too to keep everything in sync and avoid code churn. Sign

[Qemu-devel] [PULL 07/23] crypto: Switch to QEMU UUID API

2016-09-22 Thread Fam Zheng
The uuid generation doesn't return error, so update the function signature and calling code accordingly. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody Message-Id: <1474432046-325-7-git-send-email-f...@redhat.com> Reviewed-by: Daniel P. Berrange --- crypto/block-luks.

[Qemu-devel] [PULL 01/23] docker: Handle exceptions when looking for docker command

2016-09-22 Thread Fam Zheng
From: Eduardo Habkost When trying to run docker tests on a host without the docker command, we get the following Python backtrace: $ make docker-test-quick@centos6 V=1 .../qemu/tests/docker/docker.py build qemu:centos6 .../qemu/tests/docker/dockerfiles/centos6.docker Traceback (most rece

[Qemu-devel] [PULL 02/23] util: Add UUID API

2016-09-22 Thread Fam Zheng
A number of different places across the code base use CONFIG_UUID. Some of them are soft dependency, some are not built if libuuid is not available, some come with dummy fallback, some throws runtime error. It is hard to maintain, and hard to reason for users. Since UUID is a simple standard with

[Qemu-devel] [PULL 03/23] uuid: Make null_uuid static

2016-09-22 Thread Fam Zheng
So that it doesn't have to be zeroed at each call. Suggested-by: Eric Blake Signed-off-by: Fam Zheng Reviewed-by: Jeff Cody Message-Id: <1474432046-325-3-git-send-email-f...@redhat.com> --- util/uuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/uuid.c b/util/uuid.

[Qemu-devel] [PULL 00/23] Various patches

2016-09-22 Thread Fam Zheng
The following changes since commit 430da7a81d356e368ccd88dcca60f38da9aa5b9a: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160915' into staging (2016-09-22 15:39:54 +0100) are available in the git repository at: g...@github.com:famz/qemu tags/various-pull-request for yo

[Qemu-devel] [PULL 06/23] vpc: Use QEMU UUID API

2016-09-22 Thread Fam Zheng
Previously we conditionally generated footer->uuid, when libuuid was available. Now that we have a built-in implementation, we can switch to it. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody Message-Id: <1474432046-325-6-git-send-email-f...@redhat.com> --- block/vpc.c

[Qemu-devel] [PATCH v7 3/3] intel_iommu: allow UNMAP notifiers

2016-09-22 Thread Peter Xu
Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. Before that is achieved, let's open a door for vhost DMAR support, which only requires cache invalidations (UNMAP operations). Meanwhile, converting hw_error() to error_report() and exit(1), to make the error messages clean and

[Qemu-devel] [PATCH v7 2/3] memory: introduce IOMMUOps.notify_flag_changed

2016-09-22 Thread Peter Xu
The new interface can be used to replace the old notify_started() and notify_stopped(). Meanwhile it provides explicit flags so that IOMMUs can know what kind of notifications it is requested for. Acked-by: David Gibson Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 6 -- hw/ppc/spapr

[Qemu-devel] [PATCH v7 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-22 Thread Peter Xu
IOMMU Notifier list is used for notifying IO address mapping changes. Currently VFIO is the only user. However it is possible that future consumer like vhost would like to only listen to part of its notifications (e.g., cache invalidations). This patch introduced IOMMUNotifier and IOMMUNotfierFla

[Qemu-devel] [PATCH v7 0/3] Introduce IOMMUNotifier struct

2016-09-22 Thread Peter Xu
V7: - add comments to memory_region_notify_iommu() to better clarify the interface [David] - vfio_iommu_map_notify(): remove pointless "IOMMUTLBEntry *iotlb = data" [David] - typo fix on English [David] V6: - use IOMMUTLBEntry directly for IOMMUNotifier.notify() [David] - add explicit comment

Re: [Qemu-devel] [PATCH 4/7] e1000e: Fix PBACLR implementation

2016-09-22 Thread Jason Wang
On 2016年09月22日 17:01, Dmitry Fleytman wrote: On 22 Sep 2016, at 09:40 AM, Jason Wang wrote: On 2016年09月15日 14:14, Dmitry Fleytman wrote: This patch fixes incorrect check for interrypt type being used. PBSCLR register is valid for MSI-X only. See spec. 10.2.3.13 MSI—X PBA Clear Signed-of

[Qemu-devel] [PATCH] KVM: x86: handle KVM_SET_VCPU_EVENTS/KVM_VCPUEVENT_VALID_SMM properly

2016-09-22 Thread herongguang
From: He Rongguang handle KVM_VCPUEVENT_VALID_SMM properly, or kvm-kmod/kernel will crash in migration destination in gfn_to_rmap() since kvm_memslots_for_spte_role is false, whilst (vcpu->arch.hflags & HF_SMM_MASK) is true Signed-off-by: herongguang --- arch/x86/kvm/x86.c | 1 + 1 file change

Re: [Qemu-devel] [PATCH 3/3] tests/docker/Makefile.include: add a generic docker-run target

2016-09-22 Thread Fam Zheng
On Thu, 09/22 14:57, Alex Bennée wrote: > This re-factors the docker makefile to include a docker-run target which > can be controlled entirely from environment variables specified on the > make command line. This allows us to run against any given docker image > we may have in our repository, for

Re: [Qemu-devel] [PATCH 2/3] tests/docker: test-build script

2016-09-22 Thread Fam Zheng
On Thu, 09/22 14:57, Alex Bennée wrote: > Much like test-quick but only builds. This is useful for some of the > build targets like ThreadSanitizer that don't yet pass "make check". > > Signed-off-by: Alex Bennée > --- > tests/docker/test-build | 18 ++ > 1 file changed, 18 inser

Re: [Qemu-devel] [PATCH 1/3] tests/docker: add travis dockerfile

2016-09-22 Thread Fam Zheng
On Thu, 09/22 14:57, Alex Bennée wrote: > This target grabs the latest Travis containers from their repository at > quay.io and then installs QEMU's build dependencies. With this it is > possible to run on broadly the same setup as they have on travis-ci.org. This is nice, Thanks! > > Signed-off

Re: [Qemu-devel] [PATCH v5 0/3] block: allow flush on devices with open tray

2016-09-22 Thread Fam Zheng
On Thu, 09/22 21:45, John Snow wrote: > When I said "Final re-send," I was lying. Here's a v5. > The title is also a misnomer by now :) > > The move to blk_flush altered the behavior of migration and flushing > nodes that are not reachable via the guest, but are still reachable > via QEMU and may

Re: [Qemu-devel] [PATCH v7 02/20] qapi: Add lock-mode in blockdev-add options

2016-09-22 Thread Fam Zheng
On Thu, 09/22 09:58, Eric Blake wrote: > On 08/08/2016 08:13 AM, Fam Zheng wrote: > > To allow overriding the default locking behavior when opening the image. > > > > Signed-off-by: Fam Zheng > > --- > > qapi/block-core.json | 19 ++- > > 1 file changed, 18 insertions(+), 1 delet

[Qemu-devel] [PATCH] hmp: fix qemu crash due to ioapic state dump w/ split irqchip

2016-09-22 Thread Wanpeng Li
From: Wanpeng Li The qemu will crash when info ioapic through hmp if irqchip is split. Below message is splat: KVM_GET_IRQCHIP failed: Unknown error -6 This patch fix it by dumping the ioapic state from the qemu emulated ioapic if irqchip is split. Cc: Paolo Bonzini Cc: Richard Henderson C

Re: [Qemu-devel] [PATCH] pci-testdev: enhance to support new testcases

2016-09-22 Thread Peter Xu
On Thu, Sep 22, 2016 at 01:18:24PM +0200, Andrew Jones wrote: > On Thu, Sep 22, 2016 at 02:15:08PM +0800, Peter Xu wrote: > > pci-testdev is used mostly in kvm-unit-test for some eventfd tests. > > However I see it a good framework for other tests as well (e.g., the > > IOMMU unit test in the futur

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Benjamin Herrenschmidt
On Fri, 2016-09-23 at 11:37 +1000, David Gibson wrote: > > For KVM HV there's a bit of a nit: that would disallow migration > between host cpus which aren't exactly the same model, but are close > enough that migration will work in practice. In that case we should use the architected PVR Cheers,

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Thu, Sep 22, 2016 at 02:34:19PM +0530, Nikunj A Dadhania wrote: >> Benjamin Herrenschmidt writes: >> >> > On Thu, 2016-09-22 at 11:45 +0530, Bharata B Rao wrote: >> >> On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote

Re: [Qemu-devel] [PATCH v3 08/10] ppc/pnv: add a XScomDevice to PnvCore

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 10:33:21AM +0200, Cédric Le Goater wrote: > On 09/21/2016 08:12 AM, David Gibson wrote: > > On Thu, Sep 15, 2016 at 02:45:58PM +0200, Cédric Le Goater wrote: > >> Now that we are using real HW ids for the cores in PowerNV chips, we > >> can route the XSCOM accesses to them.

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 12:32:24PM +0200, Paolo Bonzini wrote: > > > On 22/09/2016 12:04, Benjamin Herrenschmidt wrote: > > On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: > >> Something like this works for KVM: > >> > >> diff --git a/target-ppc/machine.c b/target-ppc/machine.c > >> i

Re: [Qemu-devel] [PATCH v3 10/10] ppc/pnv: add a ISA bus

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 10:44:13AM +0200, Cédric Le Goater wrote: > > >> +static ISABus *pnv_isa_create(PnvChip *chip) > >> +{ > >> +PnvLpcController *lpc = &chip->lpc; > >> +ISABus *isa_bus; > >> +qemu_irq *irqs; > >> +PnvChipClass *pcc = PNV_CHIP_GET_CLASS(chip); > >> + > >> +

Re: [Qemu-devel] [PATCH v6 3/3] intel_iommu: allow UNMAP notifiers

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 01:55:38PM +0800, Peter Xu wrote: > On Thu, Sep 22, 2016 at 03:24:43PM +1000, David Gibson wrote: > > On Wed, Sep 21, 2016 at 12:58:56PM +0800, Peter Xu wrote: > > > Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. > > > Before that is achieved, let's op

Re: [Qemu-devel] [PATCH v4 5/9] ppc/xics: Use a helper to add a new ICS

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 08:21:00AM +0200, Cédric Le Goater wrote: > On 09/22/2016 01:40 AM, David Gibson wrote: > > On Mon, Sep 19, 2016 at 11:59:33AM +0530, Nikunj A Dadhania wrote: > >> From: Benjamin Herrenschmidt > >> > >> Signed-off-by: Benjamin Herrenschmidt > >> [Move object allocation and

Re: [Qemu-devel] [PULL 00/44] ppc-for-2.8 queue 20160922

2016-09-22 Thread David Gibson
32:43 +0100) > > > > are available in the git repository at: > > > > git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160922 > > > > for you to fetch changes up to 2832da4b6fc549d5feb2cf9fe53ad98cee894327: > > > > monitor:

Re: [Qemu-devel] [PATCH v6 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 03:17:46PM +0800, Peter Xu wrote: > On Thu, Sep 22, 2016 at 03:20:48PM +1000, David Gibson wrote: > > On Wed, Sep 21, 2016 at 12:58:54PM +0800, Peter Xu wrote: > > > IOMMU Notifier list is used for notifying IO address mapping changes. > > > Currently VFIO is the only user.

Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 10:25:59AM +0200, Cédric Le Goater wrote: > >> @@ -493,6 +525,8 @@ static void pnv_chip_power9_class_init(ObjectClass > >> *klass, void *data) > >> k->chip_cfam_id = 0x100d10498000ull; /* P9 Nimbus DD1.0 */ > >> k->cores_mask = POWER9_CORE_MASK; > >> k->c

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr_pci: Add numa node id

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 02:49:34PM +1000, David Gibson wrote: > On Wed, Sep 14, 2016 at 07:03:50AM -0500, Michael Roth wrote: > > Quoting Alexey Kardashevskiy (2016-09-14 04:39:10) > > > On 14/09/16 09:29, Michael Roth wrote: > > > > Quoting Alexey Kardashevskiy (2016-07-27 03:03:38) > > > >> This

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 09:37:16PM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-09-22 at 13:27 +0200, Cédric Le Goater wrote: > > > > TCG migration succeeds and proceeds ahead. But fails somewhere > > > ahead in > > > powerpc exception handler: > > > > > > [qemu]$ ./ppc64-softmmu/qemu-syst

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 02:34:19PM +0530, Nikunj A Dadhania wrote: > Benjamin Herrenschmidt writes: > > > On Thu, 2016-09-22 at 11:45 +0530, Bharata B Rao wrote: > >> On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote: > >> > > >> > On Thu, 2016-09-22 at 10:51 +0530, Bharata

Re: [Qemu-devel] [PATCH v6 3/3] intel_iommu: allow UNMAP notifiers

2016-09-22 Thread David Gibson
On Thu, Sep 22, 2016 at 09:44:10AM +0200, Paolo Bonzini wrote: > > > On 22/09/2016 07:55, Peter Xu wrote: > > I posted patch 3 just to make sure everything is coherent, and let > > Paolo decide which way to choose (since I still think it's okay > > actually... but again both are ok to me). Also i

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr_pci: Add numa node id

2016-09-22 Thread David Gibson
On Wed, Jul 27, 2016 at 06:03:38PM +1000, Alexey Kardashevskiy wrote: > This adds a numa id property to a PHB to allow linking passed PCI device > to CPU/memory. It is up to the management stack to do CPU/memory pinning > to the node with the actual PCI device. > > Signed-off-by: Alexey Kardashevs

[Qemu-devel] [Bug 1305402] Re: libvirt fails to start VirtualMachines

2016-09-22 Thread Leo Arias
This has just happened to me. For some reason, all my machines had machine='pc-i440fx-wily'. After an update in yakkety, they stopped working. $ qemu-system-x86_64 -enable-kvm -machine help | grep wily So I updated the machine xml to a supported machine as Charles suggested, and they work again.

[Qemu-devel] [PATCH v5 0/3] block: allow flush on devices with open tray

2016-09-22 Thread John Snow
When I said "Final re-send," I was lying. Here's a v5. The title is also a misnomer by now :) The move to blk_flush altered the behavior of migration and flushing nodes that are not reachable via the guest, but are still reachable via QEMU and may or may not need to be flushed. This is intended f

[Qemu-devel] [PATCH v5 1/3] block: reintroduce bdrv_flush_all

2016-09-22 Thread John Snow
Commit fe1a9cbc moved the flush_all routine from the bdrv layer to the block-backend layer. In doing so, however, the semantics of the routine changed slightly such that flush_all now used blk_flush instead of bdrv_flush. blk_flush can fail if the attached device model reports that it is not "avai

[Qemu-devel] [PATCH v5 2/3] qemu: use bdrv_flush_all for vm_stop et al

2016-09-22 Thread John Snow
Reimplement bdrv_flush_all for vm_stop. In contrast to blk_flush_all, bdrv_flush_all does not have device model restrictions. This allows us to flush and halt unconditionally without error. This allows us to do things like migrate when we have a device with an open tray, but has a node that may ne

[Qemu-devel] [PATCH v5 3/3] block-backend: remove blk_flush_all

2016-09-22 Thread John Snow
We can teach Xen to drain and flush each device as it needs to, instead of trying to flush ALL devices. This removes the last user of blk_flush_all. The function is therefore removed under the premise that any new uses of blk_flush_all would be the wrong paradigm: either flush the single device th

Re: [Qemu-devel] [RFC/PATCH] migration: SMRAM dirty bitmap not fetched from kvm-kmod and not send to destination

2016-09-22 Thread Herongguang (Stephen)
On 2016/9/22 21:16, Herongguang (Stephen) wrote: On 2016/9/14 17:05, Paolo Bonzini wrote: On 14/09/2016 09:55, Herongguang (Stephen) wrote: Hi, We found a problem that when a redhat 6 VM reboots (in grub countdown UI), migrating this VM will result in VM’s memory difference between source

Re: [Qemu-devel] [PATCH] linux-user: fix mremap for 64bit targets on 32bit hosts

2016-09-22 Thread Felix Janda
Riku Voipio wrote: > Hi, > > On Sat, Sep 17, 2016 at 09:20:14PM -0400, Felix Janda wrote: > > Signed-off-by: Felix Janda > > Have you run the mremap tests of ltp with this on your host/guest > combo? I have just run the tests. My host is arm and my guest is aarch64. Without the patch all but m

[Qemu-devel] [PATCH] tcg: increase MAX_OP_PER_INSTR to 395

2016-09-22 Thread Joseph Myers
MAX_OP_PER_INSTR is currently 266, reported in commit 14dcdac82f398cbac874c8579b9583fab31c67bf to be the worst case for the ARM A64 decoder. Whether or not it was in fact the worst case at that time in 2014, I'm observing the instruction 0x4c006020 (st1 {v0.16b-v2.16b}, [x1]) generate 386 ops from

Re: [Qemu-devel] [Bug 1305402] Re: libvirt fails to start VirtualMachines

2016-09-22 Thread Ryan Harper
Machine type changes may be related to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1626070 There's a PPA in the bug with a fix for at least the wily machine type. On Thu, Sep 22, 2016 at 6:05 PM, Leo Arias wrote: > This has just happened to me. For some reason, all my machines had > m

Re: [Qemu-devel] [RFC PATCH v2 06/16] sev: add Secure Encrypted Virtulization (SEV) support

2016-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2016 at 04:12:04PM -0500, Brijesh Singh wrote: > Hi, > > On 09/22/2016 10:12 AM, Paolo Bonzini wrote: > > > > > > > > > > to use encrypted guest launch > > > # $QEMU \ > > > -object sev-receive-info,id=launch0 \ > > > -object sev-send-info,id=send0 \ > > > -ob

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some more files to the HMP section

2016-09-22 Thread Eric Blake
On 09/22/2016 02:32 PM, Thomas Huth wrote: > The hmp-commands-info.hx, hmp.h and include/monitor/hmp-target.h > files were classified as unmaintained. Let's add them to the > HMP section. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions

[Qemu-devel] [PATCH 2/5] apic: add send_msi() to APICCommonClass

2016-09-22 Thread Radim Krčmář
The MMIO based interface to APIC doesn't work well with MSIs that have upper address bits set (remapped x2APIC MSIs). A specialized interface is a quick and dirty way to avoid the shortcoming. Signed-off-by: Radim Krčmář --- hw/i386/kvm/apic.c | 19 +-- hw/i386/xen/

Re: [Qemu-devel] [PATCH] tcg: try sti when moving a constant into a dead memory temp

2016-09-22 Thread Richard Henderson
On 09/15/2016 06:16 AM, Paolo Bonzini wrote: This comes from free from unifying tcg_reg_alloc_mov and tcg_reg_alloc_movi's handling of TEMP_VAL_CONST. It triggers often on moves to cc_dst, such as the following translation of "sub $0x3c,%esp": before: after: subl

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some more files to the HMP section

2016-09-22 Thread Luiz Capitulino
On Thu, 22 Sep 2016 21:32:38 +0200 Thomas Huth wrote: > The hmp-commands-info.hx, hmp.h and include/monitor/hmp-target.h > files were classified as unmaintained. Let's add them to the > HMP section. > > Signed-off-by: Thomas Huth Reviewed-by: Luiz Capitulino I probably should downgrade the s

[Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-09-22 Thread Marc-André Lureau
These 2 tests exhibit two qmp bugs fixed by the previous patches. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrange Reviewed-by: Eric Blake --- tests/test-qemu-qmp.c | 69 ++ tests/Makefile.include | 2 ++ tests/.gitignore

[Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-09-22 Thread Marc-André Lureau
Since commit ad739706bbadee49, user_creatable_add_type() expects to be given a qdict. However, if object-add is called without props, you reach the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: Assertion `qdict' failed.", because the qdict isn't created in this case (it's opti

Re: [Qemu-devel] [PATCH v2 10/14] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode

2016-09-22 Thread Radim Krčmář
2016-09-22 16:36+0200, Paolo Bonzini: > On 22/09/2016 14:50, Igor Mammedov wrote: >> +#ifdef KVM_CAP_X2APIC_API >> +if (kvm_check_extension(s, KVM_CAP_X2APIC_API)) { >> +has_x2apic_ids = !kvm_vm_enable_cap(s, KVM_CAP_X2APIC_API, 0, >> +KVM_X2A

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-22 Thread Corey Minyard
On 09/22/2016 01:42 PM, Eduardo Habkost wrote: On Wed, Sep 21, 2016 at 03:38:25PM -0500, Corey Minyard wrote: On 09/21/2016 03:20 PM, Eduardo Habkost wrote: Hi, I was looking at the monitor code handling the "current CPU", and noticed that qmp_inject_nmi() looks suspicious: it is a QMP command

[Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-22 Thread Radim Krčmář
Cluster x2APIC cannot work without KVM's x2apic API when the maximal APIC ID is > 8. Make the code simpler by completely forbidding EIM without KVM's x2apic API. Signed-off-by: Radim Krčmář --- I think it the dependency would be nicer in the eim setter, but the other dependency, for interrup

Re: [Qemu-devel] [RFC PATCH v2 06/16] sev: add Secure Encrypted Virtulization (SEV) support

2016-09-22 Thread Brijesh Singh
Hi, On 09/22/2016 10:12 AM, Paolo Bonzini wrote: to use encrypted guest launch # $QEMU \ -object sev-receive-info,id=launch0 \ -object sev-send-info,id=send0 \ -object sev-guest-info,id=sev0,launch=launch0,send=send0 \ . References to other objects should be im

[Qemu-devel] [PATCH 0/5] intel_iommu: fix EIM

2016-09-22 Thread Radim Krčmář
intel_iommu exposed EIM (extended interrupt mode) feature, which in turn made the guest think that using x2APIC is a good idea. It was not: QEMU clamped all addresses to 8 bits (effectively allowing only APIC IDs below 8 in cluster mode) and 0xff was also interpreted as x2APIC broadcast even in ph

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/44] ppc-for-2.8 queue 20160922

2016-09-22 Thread Richard Henderson
git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160922 for you to fetch changes up to 2832da4b6fc549d5feb2cf9fe53ad98cee894327: monitor: fix crash for platforms without a CPU 0 (2016-09-22 15:53:01 +1000

[Qemu-devel] [PATCH v2] build-sys: generate tests/.gitignore

2016-09-22 Thread Marc-André Lureau
It's too easy to forget about updating the .gitignore, so this is an attempt at generating it instead. This approach assumes that the files to clean are the one to put in the .gitignore. Signed-off-by: Marc-André Lureau --- v2: - fix make check-clean - improve adding $(QEMU_IOTESTS_HELPERS-y)

Re: [Qemu-devel] [PATCH] build: handle deprecation of major() in sys/types.h

2016-09-22 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20160922205647.18237-1-rkrc...@redhat.com Subject: [Qemu-devel] [PATCH] build: handle deprecation of

Re: [Qemu-devel] [PATCH] build-sys: generate .gitignore

2016-09-22 Thread Eric Blake
On 09/22/2016 03:47 PM, Marc-André Lureau wrote: >> >> # Consolidated targets >> +tests-cleanfiles = *.o >> +tests-cleanfiles = .gitignore >> +tests-cleanfiles += qht-bench$(EXESUF) Missed this on the first round: you meant to use += on the .gitignore line. Without it, you aren't excluding ANY

[Qemu-devel] [PATCH] MAINTAINERS: Add some more files to the HMP section

2016-09-22 Thread Thomas Huth
The hmp-commands-info.hx, hmp.h and include/monitor/hmp-target.h files were classified as unmaintained. Let's add them to the HMP section. Signed-off-by: Thomas Huth --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9da3d09..

Re: [Qemu-devel] [PULL 00/13] AVR target

2016-09-22 Thread Bastian Koppelmann
On 09/22/2016 06:10 PM, Richard Henderson wrote: > On 09/21/2016 11:40 PM, Thomas Huth wrote: >> Slowly we're getting really a lot of target-something folders in the >> main directory. Maybe we should rather introduce a singly "target" >> folder instead and put all the targets under that folder? So

  1   2   3   4   5   6   7   >