On Fri, Sep 30, 2016 at 4:55 PM, Paolo Bonzini wrote:
>
>
> On 20/09/2016 17:42, David Kiarie wrote:
>> Hi all,
>>
>> This patchset adds basic AMD IOMMU emulation support to Qemu.
>>
>> Resent this with some changes suggested by Michael.
>
>
> Hi David,
Hi Paolo,
>
> please fix the problems belo
2016-09-30 13:40+0800, Peter Xu:
> On Thu, Sep 29, 2016 at 01:23:29PM +0200, Radim Krčmář wrote:
>
> [...]
>
>> @@ -2481,11 +2482,14 @@ static void vtd_realize(DeviceState *dev, Error
>> **errp)
>> if (s->intr_eim == ON_OFF_AUTO_AUTO && !x86_iommu->intr_supported) {
>> s->intr_eim
On Thu, Sep 29, 2016 at 04:11:27PM +0200, Pradeep Kiruvale wrote:
> Hi Stefan,
>
> On 28 September 2016 at 10:29, Stefan Hajnoczi wrote:
>
> > On Mon, Sep 26, 2016 at 05:41:55PM +0200, Pradeep Kiruvale wrote:
> > > I want to add couple of new cli options for the virtio-net driver and use
> > > t
On Wed, Sep 21, 2016 at 03:18:47PM +0200, Paolo Bonzini wrote:
> Opinions, reviews and bug reports?
Looks good in general but I've skipped the tricky parts.
Stefan
signature.asc
Description: PGP signature
Hi Markus,
On 22/09/2016 17:42, Markus Armbruster wrote:
> Eric Auger writes:
>
>> To prepare for migration to realize, let's use a local error
>> object in vfio_initfn. Also let's use the same error prefix for all
>> error messages.
>>
>> On top of the 1-1 conversion, we start using a common er
On Fri, Sep 30, 2016 at 09:29:58AM +0200, Jiri Denemark wrote:
> On Thu, Sep 29, 2016 at 18:14:53 -0300, Eduardo Habkost wrote:
> > Instead of translating the feature name entries when adding
> > property names, store the actual property names in the feature
> > name array.
> >
> > Signed-off-by:
On Fri, Sep 30, 2016 at 10:02:49AM +0200, Paolo Bonzini wrote:
> On 29/09/2016 23:14, Eduardo Habkost wrote:
> > +/* Return the feature property name for a feature flag bit */
> > +static const char *x86_cpu_feature_name(FeatureWord w, int bitnr)
> > +{
> > +/* XSAVE components are automaticall
Hi Markus,
On 22/09/2016 19:01, Markus Armbruster wrote:
> Eric Auger writes:
>
>> Pass an error object to prepare for migration to VFIO-PCI realize.
>>
>> Signed-off-by: Eric Auger
>>
>> ---
>>
>> v2: creation
>> ---
>> hw/vfio/common.c | 20 +++-
>> hw/vfio/pci.c
On Wed, Sep 21, 2016 at 03:18:59PM +0200, Paolo Bonzini wrote:
> This is only called from virtio_bus_set_host_notifier.
>
> Signed-off-by: Paolo Bonzini
> ---
> hw/virtio/virtio-bus.c | 60
> +-
> 1 file changed, 25 insertions(+), 35 deletions(-)
Markus,
On 22/09/2016 17:49, Markus Armbruster wrote:
> Eric Auger writes:
>
>> Pass an error object to prepare for migration to VFIO-PCI realize.
>> The returned value will be removed later on.
>>
>> The case where error recovery cannot be enabled is not converted into
>> an error object but di
Hi,
On 22/09/2016 19:24, Markus Armbruster wrote:
> Eric Auger writes:
>
>> This patch converts VFIO PCI to realize function.
>>
>> Also original initfn errors now are propagated using QEMU
>> error objects. All errors are formatted with the same pattern:
>> "vfio: %s: the error description"
>>
On Wed, Sep 21, 2016 at 03:18:57PM +0200, Paolo Bonzini wrote:
> ioeventfd_disabled was the only reason for the default
> implementation of virtio_device_start_ioeventfd_impl not to use
> virtio_bus_set_host_notifier. This is now fixed, and the sole entry
> point to set up ioeventfd can now be vir
Markus,
On 22/09/2016 18:27, Markus Armbruster wrote:
> Eric Auger writes:
>
>> Pass an error object to prepare for migration to VFIO-PCI realize.
>>
>> The error object is propagated downto vfio_intx_enable_kvm
>
> down to vfio_intx_enable_kvm().
>
> (feel free to omit the () I automatically
Hi Markus,
On 22/09/2016 18:52, Markus Armbruster wrote:
> Eric Auger writes:
>
>> Pass an error object to prepare for migration to VFIO-PCI realize.
>> The error is cascaded downto vfio_add_std_cap and then vfio_msi(x)_setup,
>> vfio_setup_pcie_cap.
>>
>> vfio_add_ext_cap does not return anythi
On Wed, Sep 21, 2016 at 03:18:55PM +0200, Paolo Bonzini wrote:
> Make virtio_device_start_ioeventfd_impl use the same logic as
> dataplane to set up the host notifier. This removes the need
> for the set_handler argument in set_host_notifier_internal.
>
> This is a first step towards using virtio
On Wed, Sep 21, 2016 at 03:18:54PM +0200, Paolo Bonzini wrote:
> This reverts commit 872dd82c83745a603d2e07a03d34313eb6467ae4.
> virtio_add_queue_aio is unused.
>
> Signed-off-by: Paolo Bonzini
> ---
> hw/virtio/virtio.c | 38 --
> include/hw/virtio/vi
Hi
On Thu, Sep 29, 2016 at 12:13 PM Fam Zheng wrote:
> Previously all qtest cases in a category, such as check-qtest-y, are
> executed in a single long gtester command. This patch separates each
> test into its own make target to allow better parallism, unless gcov is
> configured.
>
> Slightly
On Wed, Sep 21, 2016 at 03:18:51PM +0200, Paolo Bonzini wrote:
> This will be used to forbid iothread configuration when the
> proxy does not allow using ioeventfd. To simplify the implementation,
> change the direction of the ioeventfd_disabled callback too.
>
> Signed-off-by: Paolo Bonzini
> -
On Fri, 12 Aug 2016 14:54:06 +0800
Xiao Guangrong wrote:
> Read FIT whose function index is 0x is reserved by QEMU to read
> the piece of FIT buffer. Please refer to docs/specs/acpi_nvdimm.txt for
> detailed info
Pls, squash this patch into 3/8
>
> Signed-off-by: Xiao Guangrong
> ---
On Fri, 12 Aug 2016 14:54:05 +0800
Xiao Guangrong wrote:
> _FIT is required for hotplug support, guest will inquire the updated
> device info from it if a hotplug event is received
>
> As FIT buffer is not completely mapped into guest address space, so a
> new function, Read FIT whose function i
On Wed, Sep 21, 2016 at 03:18:50PM +0200, Paolo Bonzini wrote:
> Allow customization of the start and stop of ioeventfd. This will
> allow direct start of dataplane without passing through the default
> ioeventfd handlers, which in turn allows using the dataplane logic
> instead of virtio_add_queu
Cao jin writes:
> On 09/29/2016 10:42 PM, Markus Armbruster wrote:
>> Cao jin writes:
>>
>
>>> static int vmxnet3_post_load(void *opaque, int version_id)
>>> {
>>> VMXNET3State *s = opaque;
>>> -PCIDevice *d = PCI_DEVICE(s);
>>>
>>> net_tx_pkt_init(&s->tx_pkt, PCI_DEVICE(s),
Hi
On Fri, Sep 30, 2016 at 2:55 PM Denis V. Lunev wrote:
> From: Denis Plotnikov
>
> Unfortunately, there is no public Windows API to start trimming the
> filesystem. The only viable way here is to call 'defrag.exe /L' for
> each volume.
>
> This is working since Win8 and Win2k12.
>
> Signed-of
Signed-off-by: Fam Zheng
---
hw/nvram/spapr_nvram.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/nvram/spapr_nvram.c b/hw/nvram/spapr_nvram.c
index 4de5f70..b679e0b 100644
--- a/hw/nvram/spapr_nvram.c
+++ b/hw/nvram/spapr_nvram.c
@@ -39,6 +39,7 @@ typedef struct sPAPRNVRAM {
Am 30.09.2016 um 04:04 hat Fam Zheng geschrieben:
> On Thu, 09/29 12:39, Kevin Wolf wrote:
> > Am 29.09.2016 um 11:55 hat Fam Zheng geschrieben:
> > > On Thu, 09/29 11:29, Kevin Wolf wrote:
> > > > Am 28.09.2016 um 09:04 hat Fam Zheng geschrieben:
> > > > > Handling this is similar to what is done
Signed-off-by: Fam Zheng
---
hw/block/onenand.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/hw/block/onenand.c b/hw/block/onenand.c
index 8d84227..9b058e8 100644
--- a/hw/block/onenand.c
+++ b/hw/block/onenand.c
@@ -778,6 +778,7 @@ static int onenand_initfn(SysBusDevice *sbd)
Signed-off-by: Fam Zheng
---
hw/sd/sd.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 8e88e83..6c18fb8 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -124,6 +124,7 @@ struct SDState {
qemu_irq readonly_cb;
qemu_irq inserted_cb;
BlockBackend
Signed-off-by: Fam Zheng
---
hw/block/m25p80.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index d29ff4c..3c1765a 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -380,6 +380,7 @@ typedef struct Flash {
SSISlave parent_obj;
Signed-off-by: Fam Zheng
---
hw/block/nand.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/block/nand.c b/hw/block/nand.c
index c69e675..75b5a68 100644
--- a/hw/block/nand.c
+++ b/hw/block/nand.c
@@ -64,6 +64,7 @@ struct NANDFlashState {
int page_shift, oob_shift, erase_shif
Signed-off-by: Fam Zheng
---
hw/block/fdc.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index b79873a..20684b8 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -158,6 +158,7 @@ typedef enum FDiskFlags {
typedef struct
The cases is about live snapshot features. Disable image locking because
otherwise a few tests are going to fail because we reuse the same images
at blockdev-add.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/085 | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qe
Signed-off-by: Fam Zheng
---
tests/ahci-test.c | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 9c0adce..838ff45 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -1132,10 +1132,14 @@ static void
Signed-off-by: Fam Zheng
---
tests/postcopy-test.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
index 41ed1a9..3ec4d01 100644
--- a/tests/postcopy-test.c
+++ b/tests/postcopy-test.c
@@ -371,12 +371,14 @@ static void tes
So the image lock won't complain.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/046 | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046
index e528b67..f15ccbf 100755
--- a/tests/qemu-iotests/046
+++ b/test
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
tests/qemu-iotests/153 | 197 +
tests/qemu-iotests/153.out | 426 +
tests/qemu-iotests/group | 1 +
3 files changed, 624 insertions(+)
create mode 100755 tests/qemu-iotest
With image locking, opening /dev/null can fail when multiple tests run
in parallel (make -j2, for example). Use null-co:// as the null protocol
doesn't do image locking.
While it's arguable we could special-case /dev/null, /dev/zero,
/dev/urandom etc in raw-posix driver, it is not really necessary
Otherwise the error handling we are expecting will be masked by the
preceding image locking check, and is going to be indistinguishable
because the error messages are all the same.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/087 | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/qemu
Signed-off-by: Fam Zheng
---
hw/block/pflash_cfi01.c | 10 ++
hw/block/pflash_cfi02.c | 9 +
2 files changed, 19 insertions(+)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index 62d7a56..df82471 100644
--- a/hw/block/pflash_cfi01.c
+++ b/hw/block/pflash_cfi01.c
By the time _img_info is run, QEMU process's resources may still be on
its way being cleaned up, asynchronously, even though the process itself
is already gone after the "kill -KILL" and "wait" commands in
_cleanup_qemu.
Change the last HMP command to 'q' to ensure the locks are released.
Signed-
We should wait for the QEMU process to terminate and close the image
before we check the data.
Also use shared lock in migration source and target.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/091 | 9 +++--
tests/qemu-iotests/091.out | 1 +
2 files changed, 8 insertions(+), 2 deleti
The VM is running, qemu-io would fail the lock acquisition.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
tests/qemu-iotests/030 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
index 107049b..acae67e 100755
--- a/tests/qe
Signed-off-by: Fam Zheng
---
hw/block/nvme.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index cef3bb4..318dc94 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -829,7 +829,7 @@ static int nvme_init(PCIDevice *pci_dev)
{
Nv
Otherwise the error handling we are expecting will be masked by the
preceding image locking check, and is going to be indistinguishable
because the error messages are all the same.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
tests/qemu-iotests/087 | 2 ++
1 file changed, 2 insertions(+)
Signed-off-by: Fam Zheng
---
hw/scsi/scsi-generic.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
index 7a588a7..4f131e8 100644
--- a/hw/scsi/scsi-generic.c
+++ b/hw/scsi/scsi-generic.c
@@ -502,12 +502,19 @@ static void scsi_generic_rea
Signed-off-by: Fam Zheng
---
hw/usb/dev-storage.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index c607f76..6d0c00e 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -600,6 +600,11 @@ static void usb_msd_realize_storage(USBDe
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
qemu-nbd.c| 7 ++-
qemu-nbd.texi | 2 ++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 99297a5..6585b2c 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -102,6 +102,7 @@ static void usage(const c
As a very special case, in sync=none mode, the source is the backing image of
the target, which will be RO opened again. This won't work with image locking
because the first open could be exclusive.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
blockdev.c | 5 +
1 file changed, 5 inse
Signed-off-by: Fam Zheng
---
hw/scsi/scsi-disk.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 88beaf4..fb406a0 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2288,6 +2288,12 @@ static void scsi_realize(SCSIDevice *dev, E
Signed-off-by: Fam Zheng
---
hw/ide/core.c | 10 +-
hw/ide/qdev.c | 2 +-
include/hw/ide/internal.h | 3 ++-
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index b0e42a6..a426baf 100644
--- a/hw/ide/core.c
+++ b/hw/i
If specified, BDRV_O_NO_LOCK flag will be set when opening the image.
Signed-off-by: Fam Zheng
---
qemu-img.c | 91 +-
1 file changed, 72 insertions(+), 19 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index ceffefe..e8d0e78 100644
Signed-off-by: Fam Zheng
---
hw/block/virtio-blk.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 3a6112f..ce65615 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -896,6 +896,11 @@ static void virtio_blk_device_realiz
Signed-off-by: Fam Zheng
---
hw/core/qdev-properties.c| 10 ++
include/hw/block/block.h | 1 +
include/hw/qdev-properties.h | 3 +++
3 files changed, 14 insertions(+)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 311af6d..829b143 100644
--- a/hw/core/
Signed-off-by: Fam Zheng
---
qemu-img-cmds.hx | 44 ++--
qemu-img.c | 1 +
qemu-img.texi| 3 +++
3 files changed, 26 insertions(+), 22 deletions(-)
diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
index f054599..eaca454 100644
--- a/qemu-img-cm
They are wrappers of POSIX fcntl "file private locking".
Signed-off-by: Fam Zheng
---
include/qemu/osdep.h | 2 ++
util/osdep.c | 29 +
2 files changed, 31 insertions(+)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 9e9fa61..f773f49 100644
-
Signed-off-by: Fam Zheng
---
block/block-backend.c | 18 ++
include/sysemu/block-backend.h | 2 ++
2 files changed, 20 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index 0bd19ab..dc1ad36 100644
--- a/block/block-backend.c
+++ b/block/block-ba
virtlockd in libvirt locks the first byte, we lock byte 1 to avoid
the intervene.
Both file and host device protocols are covered.
The complication is with reopen. We have three different locking states,
namely "unlocked", "shared locked" and "exclusively locked".
When we reopen, the new fd may
Signed-off-by: Fam Zheng
---
qemu-io.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index db129ea..5c14eba 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -108,6 +108,7 @@ static void open_help(void)
" -r, -- open file read-only\n"
Later the block layer will automatically lock the images to avoid unexpected
concurrent accesses to the same image, which will easily corrupt the metadata
or user data, unless in some very special cases, like migration.
The exceptional cases like shared storage migration and testing should
set BDR
Block drivers can implement this new operation .bdrv_lockf to actually lock the
image in the protocol specific way.
Signed-off-by: Fam Zheng
---
block.c | 52 +++
include/block/block.h | 4 +++-
include/block/block_int.h | 5 +++
Signed-off-by: Fam Zheng
---
qapi/block-core.json | 18 ++
1 file changed, 18 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 92193ab..22e8d04 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2754,3 +2754,21 @@
'data' : { 'parent':
Hi all,
I wanted to post something before the long holiday as promised, but I couldn't
refine or test enough due to limited time. Please take this as an RFC and do a
high level review. Thanks.
v8: Move user interface option from block device to qdev. [Kevin]
Add "exclusive" back. [Kevin]
On 09/29/2016 11:23 PM, Maxime Coquelin wrote:
On 09/29/2016 10:21 PM, Michael S. Tsirkin wrote:
On Thu, Sep 29, 2016 at 10:05:22PM +0200, Maxime Coquelin wrote:
On 09/29/2016 07:57 PM, Michael S. Tsirkin wrote:
On Thu, Sep 29, 2016 at 05:30:53PM +0200, Maxime Coquelin wrote:
...
Befo
On 27/09/2016 17:24, Michal Privoznik wrote:
> v3 of:
> http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg05058.html
>
> diff to v3:
> - Rework 2/2 so that no malloc() is done in signal handler since it's not
> re-entrant.
>
> Michal Privoznik (2):
> util: Introduce qemu_get_pid_nam
On 9/30/2016 8:40 AM, Jike Song wrote:
> On 09/30/2016 10:58 AM, Jike Song wrote:
>> On 09/29/2016 11:06 PM, Kirti Wankhede wrote:
>>>
>>>
>>> On 9/29/2016 7:47 AM, Jike Song wrote:
+Guangrong
On 08/25/2016 11:53 AM, Kirti Wankhede wrote:
>>>
>>> ...
>>>
> +static long vfio_iom
On 30/09/2016 12:45, Dr. David Alan Gilbert wrote:
>> >
>> > This version of the implementation depends on port io, but if there's
>> > interest I'll add mmio as well.
> Other than a couple of nits I'll mention below (and Stefan's comment)
> I don't see why we shouldn't have this; although we'll
Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are
loaded at image open and becomes BdrvDirtyBitmap's for corresponding
drive. These bitmaps are deleted from Qcow2 image after loading to avoid
conflicts.
Extra data in bitmaps is not supported for now.
Signed-off-by: Vladimir
Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for
qcow2 bitmap loading, to handle unallocated bitmap parts, marked as
all-ones.
Reviewed-by: Kevin Wolf
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 7 +++
include/block/dirty-bitmap.h |
On 26/09/2016 22:23, Hervé Poussineau wrote:
> Signed-off-by: Hervé Poussineau
> ---
> hmp-commands-info.hx | 12 -
> hmp.c | 65
> ++
> hmp.h | 2 ++
> hw/intc/i8259.c| 36
On 22/09/2016 12:13, Alex Bennée wrote:
> Hi,
>
> This is v2 of the ThreadSanitizer fixes. Changes from the last
> version:
>
> - added Marc-André's review tags
> - added qga/command: use QEMU atomic primitives
> - simplified ui/vnc-enc-tight: remove switch and have single return
> - fi
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 7 +++
include/block/dirty-bitmap.h | 3 +++
2 files changed, 10 insertions(+)
diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index 0314581..392d660 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bi
Public bug reported:
I'm trying to install Windows 7 as guest, but the machine still hangs
(more precisely, the windows icon keeps flashing, but never goes past
this stage).
I think this is a different bug from
https://bugs.launchpad.net/qemu/+bug/1581936.
Specifically, its happens when the OVMF
ping
For now there are some notes mostly about accessory patches. What about
migration itself?
On 16.08.2016 13:25, Vladimir Sementsov-Ogievskiy wrote:
v2:
some bugs fixed, iotests a bit changed and merged into one test.
based on block-next (https://github.com/XanClic/qemu/commits/block-next)
For now bitmap directory entry some times called 'bitmap header'. This
patch leaves only one name - 'bitmap directory entry'. The name 'bitmap
header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap
header extension' (which is extension of qcow2 header)
Signed-off-by: Vladimir Seme
On 30/09/2016 12:28, Denis V. Lunev wrote:
> From: Evgeny Yakovlev
>
> Current CPU definition for AMD Opteron third generation includes
> features like SSE4a and LAHF_LM support in emulated CPUID. These
> features are present in K8 rev.E or K10 CPUs and later. However,
> current G3 family and m
Realize block bitmap stroing interface, to allow qcow2 images store
persistent bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-bitmap.c | 241 +++
block/qcow2.c| 2 +
block/qcow2.h| 2 +
3 files changed, 245
Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be
needed in future, to save this flag back to Qcow2 for persistent
bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 15 +++
block/qcow2-bitmap.c | 2 ++
include/block/dir
New field BdrvDirtyBitmap.persistent means, that bitmap should be saved
on bdrv_close, using format driver. Format driver should maintain bitmap
storing.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 30 ++
block/dirty-bitmap.c
Create block/qcow2-bitmap.c
Add data structures and constraints accordingly to docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/Makefile.objs | 2 +-
block/qcow2-bitmap.c | 47 +++
block/qcow2.h| 29 +
This flag means that the bitmap is now in use by the software or was not
successfully saved. In any way, with this flag set the bitmap data must
be considered inconsistent and should not be loaded.
With current implementation this flag is never set, as we just remove
bitmaps from the image after l
Make getter signature const-correct. This allows other functions with
const dirty bitmap parameter use bdrv_dirty_bitmap_granularity().
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Reviewed-by: Kevin Wolf
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 2 +-
i
From: Denis Plotnikov
Unfortunately, there is no public Windows API to start trimming the
filesystem. The only viable way here is to call 'defrag.exe /L' for
each volume.
This is working since Win8 and Win2k12.
Signed-off-by: Denis V. Lunev
Signed-off-by: Denis Plotnikov
CC: Michael Roth
CC:
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 1 +
include/qemu/hbitmap.h | 8
qapi/block-core.json | 5 -
util/hbitmap.c | 8
4 files changed, 21 insertions(+), 1 deletion(-)
diff --git a
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/165 | 87 ++
tests/qemu-iotests/165.out | 5 +++
tests/qemu-iotests/group | 1 +
3 files changed, 93 insertions(+)
create mode 100755 tests/qemu-iotests/165
create mode 100644
Check bitmap header constraints as specified in docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-bitmap.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 8cf40f0..1c3abe
Optional. Default is false.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
---
blockdev.c | 22 --
qapi/block-core.json | 7 ++-
qmp-commands.hx | 5 -
3 files changed, 30 insertions(+), 4 deletions(-)
diff --git a/blockde
Calculate refcounts for dirty bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-bitmap.c | 60 ++
block/qcow2-refcount.c | 14 +++-
block/qcow2.h | 5 +
3 files changed, 74 insertions(+), 5 deletions(-)
d
Make dirty iter resistant to resetting bits in corresponding HBitmap.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/qemu/hbitmap.h | 24 ++--
util/hbitmap.c | 23 ++-
2 files changed, 24 insertions(+), 23 deletions(-)
diff --git a/includ
Add dirty bitmap extension as specified in docs/specs/qcow2.txt.
For now, just mirror extension header into Qcow2 state and check
constraints.
For now, disable image resize if it has bitmaps. It will be fixed later.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.c | 83
v7:
https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags%2Fqcow2-bitmap-v7
based on block-next (https://github.com/XanClic/qemu/commits/block-next)
- a lot of refactoring and reordering of patches.
- dead code removed (bdrv_dirty_bitmap_load, etc.)
- do not maintain extra data
Add autoclear bit for handling rewriting image by old qemu version.
If autoclear bit is not set, but bitmaps extension is found it
would not be loaded and warning will be generated.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-bitmap.c | 4
block/qcow2.c| 12 +++
Add optional 'persistent' flag to qmp command block-dirty-bitmap-add.
Default is false.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
---
blockdev.c | 12 +++-
qapi/block-core.json | 7 ++-
qmp-commands.hx | 5 -
3 files changed, 21 i
On Fri, Sep 30, 2016 at 11:48:44AM +0200, Kashyap Chamarthy wrote:
> On Fri, Sep 30, 2016 at 04:53:38PM +0800, Wang WeiWei wrote:
> > Kevin Wolf's advice:
> > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
>
> IIUC, what Stefan meant is to write a simple descriptive commit mess
This will not touch loaded bitmaps, as they are alredy removed from the
image.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-bitmap.c | 38 ++
block/qcow2.c| 9 ++---
block/qcow2.h| 2 ++
3 files changed, 46 insertions(+), 3
On Fri, Sep 30, 2016 at 12:42:27PM +0200, Thomas Huth wrote:
> On 30.09.2016 12:19, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Fix the decoding of iss_sf in disas_ld_lit.
> > The SF (Sixty-Four) field in the ISS (Instruction Specific Syndrome)
> > is a bit that specifies the w
On Fri, 30 Sep 2016 12:30:08 +0200
Laurent Vivier wrote:
> On 30/09/2016 12:18, Greg Kurz wrote:
> > On Thu, 29 Sep 2016 19:15:07 +0200
> > Laurent Vivier wrote:
> >
> >> but disable MSI-X tests on SPAPR as we can't check the result
> >> (the memory region used on PC is not readable on SPAPR)
Test that hbitmap iter is resistant to bitmap resetting.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
---
tests/test-hbitmap.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c
index 0ed918c..e24377f
From: Yi Min Zhao
For efficiency we now assign one msix io region for each pci device
and provide it with the pointer to the zPCI device as opaque
parameter. In addition, we remove msix address space and add msix io
region as a subregion to the root memory region of pci device.
Signed-off-by: Yi
commit 9c5ce8db2e5c ("vl: Switch qemu_uuid to QemuUUID") changed most
users of qemu_uuid but not all. Fix a build error on s390/kvm.
Reviewed-by: Fam Zheng
Signed-off-by: Christian Borntraeger
---
target-s390x/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-s390
From: Sascha Silbe
According to the PoP, subchannels are only considered operational if
they are enabled _and_ the device number is valid. With the current
checks being enabled _or_ having a valid device number was
sufficient. This caused qemu to allow IO on subchannels that were not
enabled.
Fi
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
docs/specs/qcow2.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index 80cdfd0..d3e292f 100644
--- a/docs/specs/qcow2.txt
+++ b/docs/specs/qcow2.txt
@@ -472,8 +472,7 @@ Structure
201 - 300 of 352 matches
Mail list logo
