[Qemu-devel] [PULL v2 05/20] trace: remove global 'uint16 dstate[]' array

From: "Daniel P. Berrange" Instead of having a global dstate array, declare a single 'uint16 TRACE_${EVENT_NAME}_DSTATE' variable for each trace event. Record a pointer to this variable in the TraceEvent struct too. By turning trace_event_get_state_dynamic_by_id into a

[Qemu-devel] [PULL v2 13/20] trace: dynamically allocate trace_dstate in CPUState

From: "Daniel P. Berrange" The CPUState struct has a bitmap tracking which VCPU events are currently active. This is indexed based on the event ID values, and sized according the maximum TraceEventVCPUID enum value. When we start dynamically assigning IDs at runtime, we

[Qemu-devel] [PULL v2 03/20] trace: convert code to use event iterators

From: "Daniel P. Berrange" This converts the HMP/QMP monitor API implementations and some internal trace control methods to use the new trace event iterator APIs. Reviewed-by: Stefan Hajnoczi Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PULL v2 02/20] trace: add trace event iterator APIs

From: "Daniel P. Berrange" Currently methods which want to iterate over trace events, do so using the trace_event_count() and trace_event_id() methods. This leaks the concept of a single ID enum to the callers. There is an alternative trace_event_pattern() method which can

[Qemu-devel] [PULL v2 00/20] Tracing patches

The following changes since commit 627eae7d729277c84f8e0ac07a8caab39c92c38d: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-10-10 16:23:40 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you

[Qemu-devel] [PULL v2 11/20] trace: don't abort qemu if ftrace can't be initialized

From: "Daniel P. Berrange" If the ftrace backend is compiled into QEMU, any attempt to start QEMU while non-root will fail due to the inability to open /sys/kernel/debug/tracing/tracing_on. Add a fallback into the code so that it connects up the trace_marker_fd variable to

[Qemu-devel] [PULL v2 01/20] trace: move colo trace events to net/ sub-directory

From: "Daniel P. Berrange" The colo patch series added various trace events to the top level trace-events file, despite the files using them being in a sub-dir. commit 30656b097e9dd7978d3fe9416cb9f5a421a9e63e Author: Zhang Chen Date:

Re: [Qemu-devel] [PATCHv2] monitor: deprecate 'default' option

* Markus Armbruster (arm...@redhat.com) wrote: > Marc-André Lureau writes: > > > This option does nothing since commit 06ac27f. Deprecate it. > > > > Signed-off-by: Marc-André Lureau > > --- > > vl.c | 11

Re: [Qemu-devel] [PATCH 2/5] cpus: use atomic_read to read seqlock-protected variables

Paolo Bonzini writes: > There is a data race if the variable is written concurrently to the > read. In C11 this has undefined behavior. Use atomic_read. The > write side does not need atomic_set, because it is protected by a > mutex. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

> I received a mail saying my series failed the automatic build test but > it builds completely fine (after applying Dan's patch obviously) in my > local environment. > > Going through the config output of the test script, I see that the > supporting library for SSH which is "libssh2" seems to be

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

Am 12.10.2016 um 10:37 hat Ashijeet Acharya geschrieben: > On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf wrote: > > Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > > > Of course, we must be able to build qemu correctly both with ssh enabled > > and disabled, so if you

Re: [Qemu-devel] [PATCH] qcow2: Support BDRV_REQ_MAY_UNMAP

Am 12.10.2016 um 03:14 hat Fam Zheng geschrieben: > On Wed, 09/28 15:04, Fam Zheng wrote: > > Handling this is similar to what is done to the L2 entry in the case of > > compressed clusters. > > Kevin, Max, is there anything else I need to do before this patch can be > applied? Hm, actually, it

Re: [Qemu-devel] [PATCH v8 1/6] vfio: Mediated device Core driver

> From: Kirti Wankhede > Sent: Tuesday, October 11, 2016 4:29 AM > [...] > + > +/* > + * mdev_unregister_device : Unregister a parent device > + * @dev: device structure representing parent device. > + * > + * Remove device from list of registered parent devices. Give a chance to > free > + *

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf wrote: > Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > Of course, we must be able to build qemu correctly both with ssh enabled > and disabled, so if you can indeed see a (different) build error with > disabled libssh2,

Re: [Qemu-devel] [PATCHv2 0/7] Improve PCI IO window orgnaization for pseries

Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1476247497-6976-1-git-send-email-da...@gibson.dropbear.id.au Subject: [Qemu-devel] [PATCHv2 0/7] Improve PCI IO window orgnaization for pseries Type: series === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH 0/7] Improve PCI IO window orgnaization for pseries

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/7] Improve PCI IO window orgnaization for pseries Message-id: 1476246592-24228-1-git-send-email-da...@gibson.dropbear.id.au Type: series === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v2 3/8] nvdimm acpi: introduce _FIT

On 10/11/2016 07:49 PM, Igor Mammedov wrote: On Mon, 10 Oct 2016 21:09:30 +0800 Xiao Guangrong wrote: On 10/10/2016 08:51 PM, Igor Mammedov wrote: On Sat, 8 Oct 2016 15:17:14 +0800 Xiao Guangrong wrote: On 09/30/2016 09:14

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > I received a mail saying my series failed the automatic build test but > it builds completely fine (after applying Dan's patch obviously) in my > local environment. The reason why patchew fails to build your series is because it doesn't

Re: [Qemu-devel] [PATCHv2 3/7] libqos: Limit spapr-pci to 32-bit MMIO for now

On 12/10/2016 06:44, David Gibson wrote: > Currently the functions in pci-spapr.c (like pci-pc.c on which it's based) > don't distinguish between 32-bit and 64-bit PCI MMIO. At the moment, the > qemu side implementation is a bit weird and has a single MMIO window > straddling 32-bit and 64-bit

Re: [Qemu-devel] [PATCH] mmap-alloc: check before use for ptr pointer

On 12/10/2016 09:54, Gonglei (Arei) wrote: > >> -Original Message- >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo >> Bonzini >> Sent: Wednesday, October 12, 2016 3:41 PM >> To: Gonglei (Arei); Michael Tokarev; qemu-devel@nongnu.org >> Cc:

Re: [Qemu-devel] [PATCH v2] char: serial: check divider value against baud base

On 12/10/2016 07:58, P J P wrote: > From: Prasad J Pandit > > 16550A UART device uses an oscillator to generate frequencies > (baud base), which decide communication speed. This speed could > be changed by dividing it by a divider. If the divider is > greater than the

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

On Tue, Oct 11, 2016 at 1:07 PM, Ashijeet Acharya wrote: > This series adds blockdev-add support for SSH block driver. > > Patch 1 prepares the code for the addition of a new option prefix, > which is "server.". This is accomplished by adding a >

Re: [Qemu-devel] [PATCH v14 08/21] qapi: allow QObjectInputVisitor to be created with QemuOpts

"Daniel P. Berrange" writes: > Instead of requiring all callers to go through the mutli-step multi-step > process of turning QemuOpts into a suitable QObject for visiting, > add a new constructor that encapsulates this logic. This will > allow QObjectInputVisitor to be a

Re: [Qemu-devel] [PATCHv2 2/7] libqos: Correct error in PCI hole sizing for spapr

On 12/10/2016 06:44, David Gibson wrote: > In pci-spapr.c (as in pci-pc.c from which it was derived), the > pci_hole_start/pci_hole_size and pci_iohole_start/pci_iohole_size pairs[1] > essentially define the region of PCI (not CPU) addresses in which MMIO > or PIO BARs respectively will be

Re: [Qemu-devel] [PATCHv2 1/7] libqos: Isolate knowledge of spapr memory map to qpci_init_spapr()

On 12/10/2016 06:44, David Gibson wrote: > The libqos code for accessing PCI on the spapr machine type uses IOBASE() > and MMIOBASE() macros to determine the address in the CPU memory map of > the windows to PCI address space. > > This is a detail of the implementation of PCI in the machine

Re: [Qemu-devel] [PATCH] mmap-alloc: check before use for ptr pointer

> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, October 12, 2016 3:41 PM > To: Gonglei (Arei); Michael Tokarev; qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org; Herongguang (Stephen) > Subject: Re: [PATCH]

Re: [Qemu-devel] [PATCH v6 21/20] linux-user/bsd-user: initialize trace events subsystem

On Fri, Oct 07, 2016 at 02:51:17PM +0100, Daniel P. Berrange wrote: > The bsd-user/linux-user programs make use of the CPU emulation > code and this now requires that the trace events subsystem > is enabled, otherwise it'll crash trying to allocate an empty > trace events bitmap for the CPU

Re: [Qemu-devel] [PATCH] mmap-alloc: check before use for ptr pointer

On 12/10/2016 09:37, Gonglei (Arei) wrote: >> -Original Message- >> From: Michael Tokarev [mailto:m...@tls.msk.ru] >> Sent: Wednesday, October 12, 2016 2:46 PM >> Subject: Re: [PATCH] mmap-alloc: check before use for ptr pointer >> >> 12.10.2016 05:05, Gonglei wrote: >>> If ptr mmap

Re: [Qemu-devel] [PATCH] mmap-alloc: check before use for ptr pointer

> -Original Message- > From: Michael Tokarev [mailto:m...@tls.msk.ru] > Sent: Wednesday, October 12, 2016 2:46 PM > Subject: Re: [PATCH] mmap-alloc: check before use for ptr pointer > > 12.10.2016 05:05, Gonglei wrote: > > If ptr mmap failed, we don't need to do a superfluous > >

[Qemu-devel] [PATCH] target-i386: fix 32-bit addresses in LEA

This was found with test-i386. The issue is that instructions such as addr32 lea (%eax), %rax did not perform a 32-bit extension, because the LEA translation skipped the gen_lea_v_seg step. That step does not just add segments, it also takes care of extending from address size to pointer

[Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link

From: Li Qiang In v9fs_link dispatch function, it doesn't put the 'oldfidp' fid object, this will make the 'oldfidp->ref' never reach to 0, thus leading a memory leak issue. This patch fix this. Signed-off-by: Li Qiang --- hw/9pfs/9p.c | 1 + 1 file

Re: [Qemu-devel] x86 Instruction Testing?

On 12/10/2016 01:51, Taylor Edward Heimbichner wrote: > I'm writing to ask if any executable that you use to test QEMU > systematically tests all, or at least a large portion, of the x86 > instruction set? We're working on a project that involves dynamic taint > analysis and would like to use an

[Qemu-devel] [PATCH] test-i386: fix bitrot for 64-bit

Signed-off-by: Paolo Bonzini --- tests/tcg/test-i386.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/tcg/test-i386.c b/tests/tcg/test-i386.c index b05572b..0f7b943 100644 --- a/tests/tcg/test-i386.c +++ b/tests/tcg/test-i386.c @@ -2250,14

Re: [Qemu-devel] [PATCH] mmap-alloc: check before use for ptr pointer

12.10.2016 05:05, Gonglei wrote: If ptr mmap failed, we don't need to do a superfluous calculation for offset variable by ptr (MAP_FAILED). What's the point? There's no problem in extra calculation if mmap failed, yes, but do we really care? As of it is now, it is more compact and readable,

[Qemu-devel] [PATCH V3] colo-proxy: fix memory leak

Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity and add some comments. Signed-off-by: Zhang Chen --- net/colo-compare.c| 34 +++--- net/filter-rewriter.c | 17 + trace-events | 1

Re: [Qemu-devel] [PATCH] char: serial: check divider value against baud base

+-- On Tue, 11 Oct 2016, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote --+ | Your series seems to have some coding style problems. | === OUTPUT BEGIN === | Checking PATCH 1/1: char: serial: check divider value against baud base... | ERROR: braces {} are necessary for all arms of this

[Qemu-devel] [PATCH v2] char: serial: check divider value against baud base

From: Prasad J Pandit 16550A UART device uses an oscillator to generate frequencies (baud base), which decide communication speed. This speed could be changed by dividing it by a divider. If the divider is greater than the baud base, speed is set to zero, leading to a

<    1   2   3   4