Re: [Qemu-devel] [PULL 27/27] target-arm: Correctly handle 'sub pc, pc, 1' for ARMv6

2016-10-13 Thread Alex Bennée
Peter Maydell writes: > In the ARM v6 architecture, 'sub pc, pc, 1' is not an interworking > branch, so the computed new value is written to r15 as a normal > value. The architecture says that in this case, bits [1:0] of > the value written must be ignored if we are in ARM mode (or > bit [0] ign

Re: [Qemu-devel] [PATCH 0/7] blockjobs: preliminary refactoring work, Pt 1

2016-10-13 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1476399422-8028-1-git-send-email-js...@redhat.com Subject: [Qemu-devel] [PATCH 0/7] blockjobs: preliminary refactoring work, Pt 1 === TEST SCRIPT BEGIN === #!/bin/bash BASE=

Re: [Qemu-devel] [PATCH 07/11] spapr: add hotplug interrupt machine options

2016-10-13 Thread David Gibson
On Wed, Oct 12, 2016 at 06:13:55PM -0500, Michael Roth wrote: > This adds machine options of the form: > > -machine pseries,legacy-hotplug-events=true > -machine pseries,legacy-hotplug-events=false > > to denote whether or not we wish to force the use of "legacy" style > hotplug events, which

Re: [Qemu-devel] [PATCH 06/11] spapr: update spapr hotplug documentation

2016-10-13 Thread David Gibson
On Wed, Oct 12, 2016 at 06:13:54PM -0500, Michael Roth wrote: > This updates the existing documentation to reflect recent updates to > the hotplug event structure, which are in draft form but slated > for inclusion in PAPR/LoPAPR. > > Signed-off-by: Michael Roth Reviewed-by: David Gibson > ---

Re: [Qemu-devel] [PATCH 02/11] spapr_hcall: use spapr_ovec_* interfaces for CAS options

2016-10-13 Thread David Gibson
On Fri, Oct 14, 2016 at 02:02:31PM +1100, David Gibson wrote: > On Wed, Oct 12, 2016 at 06:13:50PM -0500, Michael Roth wrote: > > Currently we access individual bytes of an option vector via > > ldub_phys() to test for the presence of a particular capability > > within that byte. Currently this is

Re: [Qemu-devel] [PATCH 03/11] spapr: add option vector handling in CAS-generated resets

2016-10-13 Thread David Gibson
On Wed, Oct 12, 2016 at 06:13:51PM -0500, Michael Roth wrote: > In some cases, ibm,client-architecture-support calls can fail. This > could happen in the current code for situations where the modified > device tree segment exceeds the buffer size provided by the guest > via the call parameters. In

Re: [Qemu-devel] [PATCH 08/11] spapr_events: add support for dedicated hotplug event source

2016-10-13 Thread David Gibson
On Wed, Oct 12, 2016 at 06:13:56PM -0500, Michael Roth wrote: > Hotplug events were previously delivered using an EPOW interrupt > and were queued by linux guests into a circular buffer. For traditional > EPOW events like shutdown/resets, this isn't an issue, but for hotplug > events there are case

Re: [Qemu-devel] [PATCH 05/11] spapr: fix inheritance chain for default machine options

2016-10-13 Thread David Gibson
On Wed, Oct 12, 2016 at 06:13:53PM -0500, Michael Roth wrote: > Rather than machine instances having backward-compatible option > defaults that need to be repeatedly re-enabled for every new machine > type we introduce, we set the defaults appropriate for newer machine > types, then add code to exp

Re: [Qemu-devel] [PATCH 09/11] spapr: Add DRC count indexed hotplug identifier type

2016-10-13 Thread David Gibson
On Wed, Oct 12, 2016 at 06:13:57PM -0500, Michael Roth wrote: > From: Bharata B Rao > > Add support for DRC count indexed hotplug ID type which is primarily > needed for memory hot unplug. This type allows for specifying the > number of DRs that should be plugged/unplugged starting from a given >

Re: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes

2016-10-13 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes Type: series Message-id: 1476392335-9256-1-git-send-email-ebl...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tot

Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

2016-10-13 Thread Alex Williamson
On Fri, 14 Oct 2016 09:01:01 +0530 Kirti Wankhede wrote: > On 10/13/2016 8:06 PM, Alex Williamson wrote: > > On Thu, 13 Oct 2016 14:52:09 +0530 > > Kirti Wankhede wrote: > > > >> On 10/13/2016 3:14 AM, Alex Williamson wrote: > >>> Under the device we have "mtty2", shouldn't that be > >>> "m

Re: [Qemu-devel] [RFC PATCH 00/11] spapr: option vector re-work and memory unplug support

2016-10-13 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH 00/11] spapr: option vector re-work and memory unplug support Type: series Message-id: 1476314039-9520-1-git-send-email-mdr...@linux.vnet.ibm.com === TEST SCRIPT BEG

Re: [Qemu-devel] [PATCHv3 0/7] Improve PCI IO window orgnaization for pseries

2016-10-13 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1476316647-9433-1-git-send-email-da...@gibson.dropbear.id.au Subject: [Qemu-devel] [PATCHv3 0/7] Improve PCI IO window orgnaization for pseries === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] [PATCH v4 00/12] qapi: Allow blockdev-add for NBD

2016-10-13 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v4 00/12] qapi: Allow blockdev-add for NBD Type: series Message-id: 20160928205602.17275-1-mre...

Re: [Qemu-devel] [PATCH v2 03/20] target-ppc: move back cpu_exec_init() to init

2016-10-13 Thread David Gibson
On Thu, Oct 13, 2016 at 06:24:45PM +0200, Laurent Vivier wrote: > We have now the cpu_exec_realize() in realize, > so the init part must be in init. > > As cpu_exec_unrealize() is called from cpu_common_finalize(), > remove the call from ppc_cpu_unrealizefn(). > > CC: Bharata B Rao > CC: Alexand

Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-13 Thread David Gibson
On Thu, Oct 13, 2016 at 06:24:43PM +0200, Laurent Vivier wrote: > Extract the realize part to cpu_exec_realize(), update all > calls to cpu_exec_init() to add cpu_exec_realize() to > have no functionnal change. > > Put in cpu_exec_init() what initializes the CPU, > in cpu_exec_realize() what adds

Re: [Qemu-devel] [PATCH v3 00/13] pc: q35: x2APIC support in kvm_apic mode

2016-10-13 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1476352367-69400-1-git-send-email-imamm...@redhat.com Subject: [Qemu-devel] [PATCH v3 00/13] pc: q35:

Re: [Qemu-devel] [PATCH v5] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-13 Thread P J P
+-- On Fri, 14 Oct 2016, P J P wrote --+ | +if (gtb->control & R_CONTROL_AUTO_INCREMENT && gtb->inc) { | +inc = update.new - gtb->compare; | +inc = MAX(QEMU_ALIGN_DOWN(inc, gtb->inc), gtb->inc); | +DB_PRINT("Auto incrementi

[Qemu-devel] [PATCH v6] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-13 Thread P J P
From: Prasad J Pandit ARM A9MP processor has a peripheral timer with an auto-increment register, which holds an increment step value. A user could set this value to zero. When auto-increment control bit is enabled, it leads to an infinite loop in 'a9_gtimer_update' while updating comparator value

Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

2016-10-13 Thread Kirti Wankhede
On 10/13/2016 8:06 PM, Alex Williamson wrote: > On Thu, 13 Oct 2016 14:52:09 +0530 > Kirti Wankhede wrote: > >> On 10/13/2016 3:14 AM, Alex Williamson wrote: >>> On Thu, 13 Oct 2016 00:32:48 +0530 >>> Kirti Wankhede wrote: >>> On 10/12/2016 9:29 PM, Alex Williamson wrote: > On We

Re: [Qemu-devel] [PATCH 01/11] spapr_ovec: initial implementation of option vector helpers

2016-10-13 Thread David Gibson
On Wed, Oct 12, 2016 at 06:13:49PM -0500, Michael Roth wrote: > PAPR guests advertise their capabilities to the platform by passing > an ibm,architecture-vec structure via an > ibm,client-architecture-support hcall as described by LoPAPR v11, > B.6.2.3. during early boot. > > Using this informatio

Re: [Qemu-devel] [PATCH 02/11] spapr_hcall: use spapr_ovec_* interfaces for CAS options

2016-10-13 Thread David Gibson
On Wed, Oct 12, 2016 at 06:13:50PM -0500, Michael Roth wrote: > Currently we access individual bytes of an option vector via > ldub_phys() to test for the presence of a particular capability > within that byte. Currently this is only done for the "dynamic > reconfiguration memory" capability bit. I

Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

2016-10-13 Thread Kirti Wankhede
On 10/14/2016 7:52 AM, Jike Song wrote: > On 10/11/2016 04:28 AM, Kirti Wankhede wrote: >> + >> +Under per-physical device sysfs: >> + >> + >> +* mdev_supported_types: >> +List of current supported mediated device types and its details are >> added >> +in this

Re: [Qemu-devel] [PATCH 2/3] tests/boot-sector: Use mkstemp() to create a unique file name

2016-10-13 Thread Fam Zheng
On Tue, 10/11 17:19, Thomas Huth wrote: > The pxe-test is run for three different targets now (x86_64, i386 > and ppc64), and the bios-tables-test is run for two targets (x86_64 > and i386). But each of the tests is using an invariant name for the > disk image with the boot sector code - so if the

[Qemu-devel] [PATCH v2] target-mips: Fix Loongson pandn instruction.

2016-10-13 Thread Heiher
From: Heiher pandn FD, FS, FT Operation: FD = ((NOT FS) AND FT) Signed-off-by: Heiher Signed-off-by: Fuxin Zhang --- target-mips/translate.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 55c2ca0..1412347 100644

Re: [Qemu-devel] [PATCH 2/2] target-mips: Fix Loongson multimedia instructions.

2016-10-13 Thread Heiher
On Fri, Oct 14, 2016 at 12:44 AM, Yongbok Kim wrote: > > > On 13/10/2016 08:10, Heiher wrote: >> From: Heiher >> >> Needed to emit FPU exception on Loongson multimedia instructions >> executing if Status:CU1 is clear. or FPR changes may be missed >> on Linux. >> >> Signed-off-by: Heiher >> Signe

Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

2016-10-13 Thread Jike Song
On 10/11/2016 04:28 AM, Kirti Wankhede wrote: > + > +Under per-physical device sysfs: > + > + > +* mdev_supported_types: > +List of current supported mediated device types and its details are added > +in this directory in following format: > + > +|- > +|--- Vend

Re: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes

2016-10-13 Thread Eric Blake
On 10/13/2016 07:00 PM, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > /tmp/qemu-test/src/nbd/clie

Re: [Qemu-devel] [QEMU PATCH v6 0/2] migration: migrate QTAILQ

2016-10-13 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1476394254-7987-1-git-send-email-du...@linux.vnet.ibm.com Type: series Subject: [Qemu-devel] [QEMU PATCH v6 0/2] m

Re: [Qemu-devel] [PATCH 0/4] machine, hostmem, pc: Register properties as class properties

2016-10-13 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1476394002-8392-1-git-send-email-ehabk...@redhat.com Type: series Subject: [Qemu-devel] [PATCH 0/4] machine, hostm

Re: [Qemu-devel] [PATCH v2 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

2016-10-13 Thread Stefano Stabellini
On Fri, 2 Sep 2016, Olaf Hering wrote: > Implement SUSE specific unplug protocol for emulated PCI devices > in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. > This protocol was implemented and used since Xen 3.0.4. > It is used in all SUSE/SLES/openSUSE releases up to SLES11SP3 and > openS

Re: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes

2016-10-13 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1476392335-9256-1-git-send-email-ebl...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v6 00/15] nbd: effici

[Qemu-devel] [PATCH 5/7] Blockjobs: Internalize user_pause logic

2016-10-13 Thread John Snow
BlockJobs will begin hiding their state in preparation for some refactorings anyway, so let's internalize the user_pause mechanism instead of leaving it to callers to correctly manage. Signed-off-by: John Snow --- blockdev.c | 12 +--- blockjob.c | 22

Re: [Qemu-devel] [PATCHv3 7/7] spapr: Improved placement of PCI host bridges in guest memory map

2016-10-13 Thread David Gibson
On Thu, Oct 13, 2016 at 10:40:32AM +0200, Laurent Vivier wrote: > > > On 13/10/2016 01:57, David Gibson wrote: > > Currently, the MMIO space for accessing PCI on pseries guests begins at > > 1 TiB in guest address space. Each PCI host bridge (PHB) has a 64 GiB > > chunk of address space in which

[Qemu-devel] [PATCH 0/7] blockjobs: preliminary refactoring work, Pt 1

2016-10-13 Thread John Snow
This is a follow-up to patches 1-6 of: [PATCH v2 00/11] blockjobs: Fix transactional race condition That series started trying to refactor blockjobs with the goal of internalizing BlockJob state as a side effect of having gone through the effort of figuring out which commands were "safe" to call o

Re: [Qemu-devel] [PATCH v4 07/20] ppc/pnv: add XSCOM handlers to PnvCore

2016-10-13 Thread David Gibson
On Thu, Oct 13, 2016 at 08:50:41AM +0200, Cédric Le Goater wrote: > On 10/13/2016 02:51 AM, David Gibson wrote: > > On Mon, Oct 03, 2016 at 09:24:43AM +0200, Cédric Le Goater wrote: > >> Now that we are using real HW ids for the cores in PowerNV chips, we > >> can route the XSCOM accesses to them.

Re: [Qemu-devel] [PATCH v1 3/3] target-ppc: implement xxbr[qdwh] instruction

2016-10-13 Thread David Gibson
On Thu, Oct 13, 2016 at 01:14:35PM -0500, Richard Henderson wrote: > On 10/12/2016 07:21 PM, David Gibson wrote: > > > +static void gen_bswap32x4(TCGv_i64 outh, TCGv_i64 outl, > > > + TCGv_i64 inh, TCGv_i64 inl) > > > +{ > > > +TCGv_i64 hi = tcg_temp_new_i64(); > > > +

Re: [Qemu-devel] [PULL 0/4] ppc patches for qemu-2.7 stable branch

2016-10-13 Thread David Gibson
a: > >> > >> Update version for v2.7.0 release (2016-09-02 13:44:11 +0100) > >> > >> are available in the git repository at: > >> > >> git://github.com/dgibson/qemu.git tags/ppc-for-2.7-20161013 > >> > >> for you to fetch changes

[Qemu-devel] [PATCH 6/7] blockjobs: split interface into public/private, Part 1

2016-10-13 Thread John Snow
To make it a little more obvious which functions are intended to be public interface and which are intended to be for use only by jobs themselves, split the interface into "public" and "private" files. Convert blockjobs (e.g. block/backup) to using the private interface. Leave blockdev and others

[Qemu-devel] [PATCH 4/7] blockjob: centralize QMP event emissions

2016-10-13 Thread John Snow
There's no reason to leave this to blockdev; we can do it in blockjobs directly and get rid of an extra callback for most users. All non-internal events, even those created outside of QMP, will consistently emit events. Signed-off-by: John Snow --- block/commit.c| 8 block

[Qemu-devel] [PATCH 3/7] Replication/Blockjobs: Create replication jobs as internal

2016-10-13 Thread John Snow
Bubble up the internal interface to commit and backup jobs, then switch replication tasks over to using this methodology. Signed-off-by: John Snow --- block/backup.c| 3 ++- block/mirror.c| 21 ++--- block/replication.c | 14 +++--- blockdev

[Qemu-devel] [PATCH 1/7] blockjobs: hide internal jobs from management API

2016-10-13 Thread John Snow
If jobs are not created directly by the user, do not allow them to be seen by the user/management utility. At the moment, 'internal' jobs are those that do not have an ID. As of this patch it is impossible to create such jobs. Signed-off-by: John Snow --- blockdev.c | 17 ++

[Qemu-devel] [PATCH 2/7] blockjobs: Allow creating internal jobs

2016-10-13 Thread John Snow
Add the ability to create jobs without an ID. Signed-off-by: John Snow --- block/backup.c| 2 +- block/commit.c| 2 +- block/mirror.c| 3 ++- block/stream.c| 2 +- blockjob.c| 25 - include/block/blockjob

[Qemu-devel] [PATCH 7/7] blockjobs: fix documentation

2016-10-13 Thread John Snow
(Trivial) Fix wrong function names in documentation. Signed-off-by: John Snow --- include/block/blockjob_int.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h index 8eced19..10ebb38 100644 --- a/include/block/bl

[Qemu-devel] [PATCH v10 07/10] hbitmap: serialization

2016-10-13 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and bitmap array element (unsigned long) size. Therefore Little Endian is chosen. These functions are appropriate for dirty bit

[Qemu-devel] [PATCH v10 08/10] block: BdrvDirtyBitmap serialization interface

2016-10-13 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Several functions to provide necessary access to BdrvDirtyBitmap for block-migration.c Signed-off-by: Vladimir Sementsov-Ogievskiy [Add the "finish" parameters. - Fam] Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Max Reitz Signed-off-by: Jo

[Qemu-devel] [PATCH v10 04/10] block: Support meta dirty bitmap

2016-10-13 Thread John Snow
From: Fam Zheng The added group of operations enables tracking of the changed bits in the dirty bitmap. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Signed-off-by: John Snow --- block/dirty-bitmap.c | 52 include/block/dirty-bitmap.h |

[Qemu-devel] [PATCH v10 01/10] block: Hide HBitmap in block dirty bitmap interface

2016-10-13 Thread John Snow
From: Fam Zheng HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place, now the new BdrvDirtyBitm

[Qemu-devel] [PATCH v10 00/10] Dirty bitmap changes for migration/persistence work

2016-10-13 Thread John Snow
Key: [] : patches are identical [] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/10:[] [--] 'block: Hide HBitmap in block dirty bitmap interface'

[Qemu-devel] [PATCH v10 10/10] block: More operations for meta dirty bitmap

2016-10-13 Thread John Snow
From: Fam Zheng Callers can create an iterator of meta bitmap with bdrv_dirty_meta_iter_new(), then use the bdrv_dirty_iter_* operations on it. Meta iterators are also counted by bitmap->active_iterators. Also add a couple of functions to retrieve granularity and count. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v10 02/10] HBitmap: Introduce "meta" bitmap to track bit changes

2016-10-13 Thread John Snow
From: Fam Zheng Upon each bit toggle, the corresponding bit in the meta bitmap will be set. Signed-off-by: Fam Zheng [Amended text inline. --js] Reviewed-by: Max Reitz Signed-off-by: John Snow --- include/qemu/hbitmap.h | 21 +++ util/hbitmap.c | 69 +

[Qemu-devel] [PATCH v10 06/10] block: Assert that bdrv_release_dirty_bitmap succeeded

2016-10-13 Thread John Snow
From: Fam Zheng We use a loop over bs->dirty_bitmaps to make sure the caller is only releasing a bitmap owned by bs. Let's also assert that in this case the caller is releasing a bitmap that does exist. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Signed-off-by: John Snow --- block/dirty-

[Qemu-devel] [PATCH v10 09/10] tests: Add test code for hbitmap serialization

2016-10-13 Thread John Snow
From: Fam Zheng Signed-off-by: Fam Zheng [Fixed minor constant issue. --js] Signed-off-by: John Snow Signed-off-by: John Snow --- tests/test-hbitmap.c | 156 +++ 1 file changed, 156 insertions(+) diff --git a/tests/test-hbitmap.c b/tests/test-

[Qemu-devel] [PATCH v10 05/10] block: Add two dirty bitmap getters

2016-10-13 Thread John Snow
From: Fam Zheng For dirty bitmap users to get the size and the name of a BdrvDirtyBitmap. Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Max Reitz Signed-off-by: John Snow --- block/dirty-bitmap.c | 10 ++ include/block/dirty-bitmap.h | 2 ++ 2 files changed,

[Qemu-devel] [PATCH v10 03/10] tests: Add test code for meta bitmap

2016-10-13 Thread John Snow
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Max Reitz Signed-off-by: John Snow --- tests/test-hbitmap.c | 116 +++ 1 file changed, 116 insertions(+) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c inde

[Qemu-devel] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

2016-10-13 Thread Jianjun Duan
Currently we cannot directly transfer a QTAILQ instance because of the limitation in the migration code. Here we introduce an approach to transfer such structures. We created VMStateInfo vmstate_info_qtailq for QTAILQ. Similar VMStateInfo can be created for other data structures such as list. This

[Qemu-devel] [QEMU PATCH v6 0/2] migration: migrate QTAILQ

2016-10-13 Thread Jianjun Duan
v6: - Split from Power specific patches. - Dropped VMS_LINKED flag. - Rebased to master. - Added comments to clarify about put/get in VMStateInfo. Previous versions are: v5: - Rebased to David's ppc-for-2.8. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg00270.

[Qemu-devel] [QEMU PATCH v6 1/2] migration: extend VMStateInfo

2016-10-13 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 6 ++- hw/net/vmxnet3.c| 18 +++

[Qemu-devel] [PATCH 2/4] pc: Register TYPE_PC_MACHINE properties as class properties

2016-10-13 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 56 ++-- 1 file changed, 26 insertions(+), 30 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 93ff49c..f4b0cda 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -2134,41 +2134,11 @@ st

[Qemu-devel] [PATCH 3/4] hostmem: Register TYPE_MEMORY_BACKEND properties as class properties

2016-10-13 Thread Eduardo Habkost
The NULL errp arguments on the property registration calls were changed to &error_abort. Signed-off-by: Eduardo Habkost --- backends/hostmem.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/backends/hostmem.c b/backends/hostmem.c

[Qemu-devel] [PATCH 4/4] hostmem-file: Register TYPE_MEMORY_BACKEND_FILE properties as class properties

2016-10-13 Thread Eduardo Habkost
To do the conversion, the file_backend_class_init() was moved after the getter/setter functions. The old file_backend_instance_init() function was removed because it is not needed anymore. The NULL errp arguments on the property registration calls were changed to &error_abort. Signed-off-by: Edua

[Qemu-devel] [PATCH 0/4] machine, hostmem, pc: Register properties as class properties

2016-10-13 Thread Eduardo Habkost
This series changes the existing machine, pc, and hostmem code to register their QOM properties as class properties on class_init instead of instance properties on instance_init. Eduardo Habkost (4): machine: Register TYPE_MACHINE properties as class properties pc: Register TYPE_PC_MACHINE pro

[Qemu-devel] [PATCH 1/4] machine: Register TYPE_MACHINE properties as class properties

2016-10-13 Thread Eduardo Habkost
When doing the conversion, the NULL errp arguments on the property registration calls were changed to &error_abort. Signed-off-by: Eduardo Habkost --- hw/core/machine.c | 206 ++ 1 file changed, 98 insertions(+), 108 deletions(-) diff --git a/

[Qemu-devel] [PATCH v6 15/15] nbd: Implement NBD_CMD_WRITE_ZEROES on client

2016-10-13 Thread Eric Blake
Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants a hole. The generic block code takes care of falling back to the obvious write of lots of zeroes if we return -ENOTSUP

[Qemu-devel] [PATCH v6 13/15] nbd: Improve server handling of shutdown requests

2016-10-13 Thread Eric Blake
NBD commit 6d34500b clarified how clients and servers are supposed to behave before closing a connection. It added NBD_REP_ERR_SHUTDOWN (for the server to announce it is about to go away during option haggling, so the client should quit sending NBD_OPT_* other than NBD_OPT_ABORT) and ESHUTDOWN (for

[Qemu-devel] [PATCH v6 12/15] nbd: Support shorter handshake

2016-10-13 Thread Eric Blake
The NBD Protocol allows the server and client to mutually agree on a shorter handshake (omit the 124 bytes of reserved 0), via the server advertising NBD_FLAG_NO_ZEROES and the client acknowledging with NBD_FLAG_C_NO_ZEROES (only possible in newstyle, whether or not it is fixed newstyle). It doesn

Re: [Qemu-devel] [PATCH v3 0/4] target-arm: Handle tagged addresses when loading PC

2016-10-13 Thread Peter Maydell
On 13 October 2016 at 20:09, Tom Hanson wrote: > Looking at arm_cpu_do_interrupt_aarch64() and the ARM spec, the > new PC value is always an offset from the appropriate VBAR. The > only place I can find the the VBAR being set is at boot time > (i.e. UEFI). Any guest system software can set the VB

[Qemu-devel] [PATCH v6 11/15] nbd: Less allocation during NBD_OPT_LIST

2016-10-13 Thread Eric Blake
Since we know that the maximum name we are willing to accept is small enough to stack-allocate, rework the iteration over NBD_OPT_LIST responses to reuse a stack buffer rather than allocating every time. Furthermore, we don't even have to allocate if we know the server's length doesn't match what

[Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes

2016-10-13 Thread Eric Blake
v5 was here, but missed 2.7 freeze: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg04053.html Since then, I've rebased the series, and the bulk of the changes were to use consistent NBDFoo CamelCase naming, as well as to improve the commit messages for questions raised on v5. Also avail

[Qemu-devel] [PATCH v6 05/15] nbd: Rename struct nbd_request and nbd_reply

2016-10-13 Thread Eric Blake
Our coding convention prefers CamelCase names, and we already have other existing structs with NBDFoo naming. Let's be consistent, before later patches add even more structs. Signed-off-by: Eric Blake --- v6: new patch --- block/nbd-client.h | 2 +- include/block/nbd.h | 10 ++ block/

[Qemu-devel] [PATCH v6 10/15] nbd: Let client skip portions of server reply

2016-10-13 Thread Eric Blake
The server has a nice helper function nbd_negotiate_drop_sync() which lets it easily ignore fluff from the client (such as the payload to an unknown option request). We can't quite make it common, since it depends on nbd_negotiate_read() which handles coroutine magic, but we can copy the idea into

[Qemu-devel] [PATCH v6 08/15] nbd: Share common option-sending code in client

2016-10-13 Thread Eric Blake
Rather than open-coding each option request, it's easier to have common helper functions do the work. That in turn requires having convenient packed types for handling option requests and replies. Signed-off-by: Eric Blake --- v6: comment and formatting tweaks v5: no change v4: rebase v3: rebas

[Qemu-devel] [PATCH v6 01/15] nbd: Add qemu-nbd -D for human-readable description

2016-10-13 Thread Eric Blake
The NBD protocol allows servers to advertise a human-readable description alongside an export name during NBD_OPT_LIST. Add an option to pass through the user's string to the NBD client. Doing this also makes it easier to test commit 200650d4, which is the client counterpart of receiving the desc

[Qemu-devel] [PATCH v6 14/15] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-10-13 Thread Eric Blake
Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants to allow a hole. Note that when it comes to requiring full allocation, vs. permitting optimizations, the NBD spec inte

[Qemu-devel] [PATCH v6 04/15] nbd: Rename NbdClientSession to NBDClientSession

2016-10-13 Thread Eric Blake
It's better to use consistent capitalization of the namespace used for NBD functions; we have more instances of NBD* than Nbd*. Signed-off-by: Eric Blake --- v6: new patch --- block/nbd-client.h | 6 +++--- block/nbd-client.c | 26 +- block/nbd.c| 4 ++-- 3 fil

[Qemu-devel] [PATCH v6 02/15] nbd: Treat flags vs. command type as separate fields

2016-10-13 Thread Eric Blake
Current upstream NBD documents that requests have a 16-bit flags, followed by a 16-bit type integer; although older versions mentioned only a 32-bit field with masking to find flags. Since the protocol is in network order (big-endian over the wire), the ABI is unchanged; but dealing with the flags

[Qemu-devel] [PATCH v6 06/15] nbd: Share common reply-sending code in server

2016-10-13 Thread Eric Blake
Rather than open-coding NBD_REP_SERVER, reuse the code we already have by adding a length parameter. Additionally, the refactoring will make adding NBD_OPT_GO in a later patch easier. Signed-off-by: Eric Blake --- v6: improve (and add) function comments v5: no change v4: no change v3: rebase to

[Qemu-devel] [PATCH v6 09/15] nbd: Let server know when client gives up negotiation

2016-10-13 Thread Eric Blake
The NBD spec says that a client should send NBD_OPT_ABORT rather than just dropping the connection, if the client doesn't like something the server sent during option negotiation. This is a best-effort attempt only, and can only be done in places where we know the server is still in sync with what

[Qemu-devel] [PATCH v6 03/15] nbd: Rename NBDRequest to NBDRequestData

2016-10-13 Thread Eric Blake
We have both 'struct NBDRequest' and 'struct nbd_request'; making it confusing to see which does what. Furthermore, we want to rename nbd_request to align with our normal CamelCase naming conventions. So, rename the struct which is used to associate the data received during request callbacks, whi

[Qemu-devel] [PATCH v6 07/15] nbd: Send message along with server NBD_REP_ERR errors

2016-10-13 Thread Eric Blake
The NBD Protocol allows us to send human-readable messages along with any NBD_REP_ERR error during option negotiation; make use of this fact for clients that know what to do with our message. Signed-off-by: Eric Blake --- v6: tweak comments, fix indentation v5: don't leak 'msg' v4: new patch ---

Re: [Qemu-devel] [PATCH 2/5] cpus: use atomic_read to read seqlock-protected variables

2016-10-13 Thread Paolo Bonzini
> Is tsan happy with the way seqlocks are written right now? I honestly don't know. But if there are tsan bugs there's not much we can do. The alternative below has overhead on ARM and PPC and does not quite fit in atomic.h. In any case, a bigger issue is that this patch breaks on 32-bit becaus

Re: [Qemu-devel] [PATCH 3/4] sockets: add AF_VSOCK support

2016-10-13 Thread Michael Roth
Quoting Stefan Hajnoczi (2016-10-12 10:06:10) > On Fri, Oct 07, 2016 at 11:42:35AM -0500, Michael Roth wrote: > > Quoting Stefan Hajnoczi (2016-10-06 11:40:17) > > > Add the AF_VSOCK address family so that qemu-ga will be able to use > > > virtio-vsock. > > > > > > The AF_VSOCK address family uses

Re: [Qemu-devel] [PATCH 4/4] qga: add vsock-listen method

2016-10-13 Thread Michael Roth
Quoting Stefan Hajnoczi (2016-10-12 10:07:33) > On Fri, Oct 07, 2016 at 12:07:41PM -0500, Michael Roth wrote: > > Quoting Stefan Hajnoczi (2016-10-06 11:40:18) > > > Add AF_VSOCK (virtio-vsock) support as an alternative to virtio-serial. > > > > > > $ qemu-system-x86_64 -device vhost-vsock-pci,g

Re: [Qemu-devel] [PATCH] tests: add mac99 and g3beige in boot-serial-test

2016-10-13 Thread Thomas Huth
On 13.10.2016 21:53, Laurent Vivier wrote: > g3beige (pmac_oldworld) and mac99 (pmac_newworld) are missing in > boot-serial-test. > > Perhaps because serial output of OpenBIOS is only enabled with > '-nographic' IIRC clearly, I've left them out because they are basically already tested with the p

[Qemu-devel] [PATCH v3] usb: Change *_exitfn return type from int to void

2016-10-13 Thread Akanksha Srivastava
The *_exitfn functions cannot fail and should not be returning int. This also removes the passthru_exitfn since this callback does nothing as of now. This was suggested as a Bite-sized task for code cleanup. Signed-off-by: Akanksha Srivastava --- hw/usb/ccid-card-emulated.c | 3 +-- hw/usb/cci

Re: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-13 Thread P J P
+-- On Thu, 13 Oct 2016, Peter Maydell wrote --+ | I suggest you try putting in some sample values for the | various variables to confirm that your new code produces the | same answers that the old code did. Yep, sent a revised patch v5. Thank you. -- Prasad J Pandit / Red Hat Product Security Tea

[Qemu-devel] [PATCH v5] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-13 Thread P J P
From: Prasad J Pandit ARM A9MP processor has a peripheral timer with an auto-increment register, which holds an increment step value. A user could set this value to zero. When auto-increment control bit is enabled, it leads to an infinite loop in 'a9_gtimer_update' while updating comparator value

[Qemu-devel] [PATCH] tests: add mac99 and g3beige in boot-serial-test

2016-10-13 Thread Laurent Vivier
g3beige (pmac_oldworld) and mac99 (pmac_newworld) are missing in boot-serial-test. Perhaps because serial output of OpenBIOS is only enabled with '-nographic' Signed-off-by: Laurent Vivier --- tests/boot-serial-test.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/boot-serial-tes

Re: [Qemu-devel] [PATCH 0/5] More thread sanitizer fixes and atomic.h improvements

2016-10-13 Thread Emilio G. Cota
On Thu, Oct 13, 2016 at 03:39:55 -0400, Paolo Bonzini wrote: > > On Mon, Oct 10, 2016 at 15:59:02 +0200, Paolo Bonzini wrote: > > > See each patch. My attempt at fixing whatever I did when I obviously > > > didn't know enough^W about the C11 memory model, and at setting a > > > better example for

Re: [Qemu-devel] [PATCH 2/5] cpus: use atomic_read to read seqlock-protected variables

2016-10-13 Thread Emilio G. Cota
On Mon, Oct 10, 2016 at 15:59:04 +0200, Paolo Bonzini wrote: > There is a data race if the variable is written concurrently to the > read. In C11 this has undefined behavior. Use atomic_read. The > write side does not need atomic_set, because it is protected by a > mutex. Is tsan happy with the

Re: [Qemu-devel] [PATCH v3 0/4] target-arm: Handle tagged addresses when loading PC

2016-10-13 Thread Tom Hanson
On 10/12/2016 01:50 PM, Thomas Hanson wrote: ... > > Still looking into handling of tagged addresses for exceptions and > exception returns. Will handle that as a separate patch set. Peter, Looking at arm_cpu_do_interrupt_aarch64() and the ARM spec, the new PC value is always an offset fro

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-13 Thread Peter Maydell
On 13 October 2016 at 19:29, Stefan Weil wrote: > scripts/tracetool generates a C preprocessor macro from the name of the > build directory. Any characters which are possible in a directory name > but not allowed in a macro name must be substituted, otherwise builds > will fail. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 2/4] block/ssh: Add InetSocketAddress and accept it

2016-10-13 Thread Ashijeet Acharya
On Tue, Oct 11, 2016 at 1:07 PM, Ashijeet Acharya wrote: > Add InetSocketAddress compatibility to SSH driver. > > Add a new option "server" to the SSH block driver which then accepts > a InetSocketAddress. > > "host" and "port" are supported as legacy options and are mapped to > their InetSocketAd

[Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-13 Thread Stefan Weil
scripts/tracetool generates a C preprocessor macro from the name of the build directory. Any characters which are possible in a directory name but not allowed in a macro name must be substituted, otherwise builds will fail. Signed-off-by: Stefan Weil --- I had problems with a build directory of

Re: [Qemu-devel] [PATCH v1 3/3] target-ppc: implement xxbr[qdwh] instruction

2016-10-13 Thread Richard Henderson
On 10/12/2016 07:21 PM, David Gibson wrote: +static void gen_bswap32x4(TCGv_i64 outh, TCGv_i64 outl, + TCGv_i64 inh, TCGv_i64 inl) +{ +TCGv_i64 hi = tcg_temp_new_i64(); +TCGv_i64 lo = tcg_temp_new_i64(); + +tcg_gen_bswap64_i64(hi, inh); +tcg_gen_bswap64_i6

Re: [Qemu-devel] [PATCH v7 00/22] qcow2: persistent dirty bitmaps

2016-10-13 Thread John Snow
On 10/01/2016 09:37 AM, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: v7: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags%2Fqcow2-bitmap-v7 based on block-next (https://github.com/XanClic/qemu/commits/block-next) It should be noted that (a

Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-13 Thread Eduardo Habkost
On Thu, Oct 13, 2016 at 06:44:14PM +0200, Markus Armbruster wrote: > machine_set_property() replaces '_' by '-' in the property name. > Except it fails to replace an initial '_'. Screwed up in commit > b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property > '._-foo-bar' not found". > >

Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-13 Thread Eduardo Habkost
On Thu, Oct 13, 2016 at 06:44:14PM +0200, Markus Armbruster wrote: > machine_set_property() replaces '_' by '-' in the property name. > Except it fails to replace an initial '_'. Screwed up in commit > b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property > '._-foo-bar' not found". > >

[Qemu-devel] [PATCH 16/18] iothread: release AioContext around aio_poll

2016-10-13 Thread Paolo Bonzini
This is the first step towards having fine-grained critical sections in dataplane threads, which will resolve lock ordering problems between address_space_* functions (which need the BQL when doing MMIO, even after we complete RCU-based dispatch) and the AioContext. Because AioContext does not use

[Qemu-devel] dpdk/vpp and cross-version migration for vhost

2016-10-13 Thread Michael S. Tsirkin
Hi! So it looks like we face a problem with cross-version migration when using vhost. It's not new but became more acute with the advent of vhost user. For users to be able to migrate between different versions of the hypervisor the interface exposed to guests by hypervisor must stay unchanged. T

  1   2   3   4   >