Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

On 30.09.2016 14:09, Fam Zheng wrote: > Hi all, > > I wanted to post something before the long holiday as promised, but I couldn't > refine or test enough due to limited time. Please take this as an RFC and do > a > high level review. Thanks. I did that, looked at some patches in more and at

Re: [Qemu-devel] [PATCH v8 12/36] virtio-blk: Apply lock-mode when realize

On 22.10.2016 02:08, Max Reitz wrote: > On 30.09.2016 14:09, Fam Zheng wrote: >> Signed-off-by: Fam Zheng >> --- >> hw/block/virtio-blk.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c >> index 3a6112f..ce65615

Re: [Qemu-devel] [PATCH v8 15/36] qdev: Add "lock-mode" to block device options

On 30.09.2016 14:09, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > hw/core/qdev-properties.c| 10 ++ > include/hw/block/block.h | 1 + > include/hw/qdev-properties.h | 3 +++ > 3 files changed, 14 insertions(+) Why don't you add _conf.lock_mode in this

Re: [Qemu-devel] [PATCH v8 12/36] virtio-blk: Apply lock-mode when realize

On 30.09.2016 14:09, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index 3a6112f..ce65615 100644 > --- a/hw/block/virtio-blk.c > +++

Re: [Qemu-devel] [PATCH v8 05/36] raw-posix: Add image locking support

On 30.09.2016 14:09, Fam Zheng wrote: > virtlockd in libvirt locks the first byte, we lock byte 1 to avoid > the intervene. s/the intervene/a conflict/? > > Both file and host device protocols are covered. > > The complication is with reopen. We have three different locking states, > namely

[Qemu-devel] [Bug 1635695] Re: ovmf + smp + hyper-v + windows 7: doesn't work

*** This bug is a duplicate of bug 1593605 *** https://bugs.launchpad.net/bugs/1593605 Sigh, the Windows bug that keeps on giving. And, users avoiding libvirt and sticking with the QEMU command line, despite the fact that using libvirt & its tools would save them from this bug. Anyway, this

Re: [Qemu-devel] [QEMU PATCH v7 0/3] migration: migrate QTAILQ

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [QEMU PATCH v7 0/3] migration: migrate QTAILQ Type: series Message-id: 1477090378-31597-1-git-send-email-du...@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [QEMU PATCH v7 1/3] migration: extend VMStateInfo

Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 6 ++-

[Qemu-devel] [QEMU PATCH v7 2/3] migration: migrate QTAILQ

Currently we cannot directly transfer a QTAILQ instance because of the limitation in the migration code. Here we introduce an approach to transfer such structures. We created VMStateInfo vmstate_info_qtailq for QTAILQ. Similar VMStateInfo can be created for other data structures such as list.

[Qemu-devel] [QEMU PATCH v7 3/3] tests/migration: Add test for QTAILQ migration

Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 162 +++ 1 file changed, 162 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index

[Qemu-devel] [QEMU PATCH v7 0/3] migration: migrate QTAILQ

Hi all, I fixed some issues and addressed feedbacks. Comments are welcome. v7: - Fixed merge errors. - Simplified macro definitions related to pointer arithmetic based QTAILQ access. - Added test case for QTAILQ migration in tests/test-vmstate.c. Previous versions are: v6: -

Re: [Qemu-devel] [PATCH v2] qapi: fix memory leak in QmpOutputVisitor

On 10/21/2016 04:32 PM, Eric Blake wrote: > In fact, applying this patch regresses to the very state that f24582d > tried to prevent. However, I'm unable to see a difference in valgrind > on tests/test-qmp-output-visitor either with or without this patch, > which sadly means our testsuite is not

Re: [Qemu-devel] target-ppc: gdbstub breakpoints get stuck in an infinite loop on next/continue

On Fri, 2016-10-21 at 15:18 +0100, Mark Cave-Ayland wrote: >  > bd6fefe71cec5a0c7d2be4ac96307f25db56abf9 is the first bad commit > commit bd6fefe71cec5a0c7d2be4ac96307f25db56abf9 > Author: Benjamin Herrenschmidt > Date:   Wed Jul 27 16:56:32 2016 +1000 > > ppc: Make

[Qemu-devel] [PATCH V7 1/2] arm: Add an option to turn on/off vPMU support

This patch adds a pmu=[on/off] option to enable/disable vPMU support in guest vCPU. This option is only available for cortex-a57/cortex-53/ host under both KVM mode, but unavailable on ARMv7 and other processors. It allows virt tools, such as libvirt, to determine the exsitence of vPMU and

[Qemu-devel] [PATCH V7 2/2] arm: virt: add PMU property to mach-virt machine type

CPU vPMU is now turned ON by default, but this feature wasn't introduced until virt-2.7 machine type. To solve this problem, this patch adds a PMU option in machine state, which is used to control CPU's vPMU status. This PMU option is not exposed to command line and is turned off in virt-2.6

[Qemu-devel] [PATCH V7 0/2] Add option to configure guest vPMU

This patchset adds a pmu=[on/off] option to enable/disable vPMU support for guest VM. There are several reasons to justify this option. First, vPMU can be problematic for cross-migration between different SoC as perf counters are architecture-dependent. It is more flexible to have an option to

Re: [Qemu-devel] [PATCH v2] qapi: fix memory leak in QmpOutputVisitor

On 10/21/2016 10:39 AM, Eric Blake wrote: > On 10/21/2016 09:01 AM, Markus Armbruster wrote: >> Pino Toscano writes: >> >>> qmp_output_start_struct() and qmp_output_start_list() create a new >>> QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor, >>>

Re: [Qemu-devel] [PATCH] qapi: fix memory leak in QmpOutputVisitor

On 10/18/2016 06:22 AM, Pino Toscano wrote: > On Tuesday, 18 October 2016 06:13:30 CEST Eric Blake wrote: >> On 10/18/2016 04:17 AM, Pino Toscano wrote: >>> qmp_output_start_struct() and qmp_output_start_list() create a new >>> QObject (QDict, QList) and push it to the stack of the

Re: [Qemu-devel] [PATCH v8 04/36] osdep: Add qemu_lock_fd and qemu_unlock_fd

On 30.09.2016 14:09, Fam Zheng wrote: > They are wrappers of POSIX fcntl "file private locking". > > Signed-off-by: Fam Zheng > --- > include/qemu/osdep.h | 2 ++ > util/osdep.c | 29 + > 2 files changed, 31 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

On 10/21/2016 02:44 PM, Max Reitz wrote: >> Now I think I can drop this assignment, as bdrv_aligned_preadv have >> 'return ret < 0 ? ret : 0;' in the end... Am I right? Can bdrv_pwrite >> and friends return positive value on success? > > I think so, but if they do return positive value they're

[Qemu-devel] [PATCH 12/13] virtio: inline virtio_queue_set_host_notifier_fd_handler

Of the three possible parameter combinations for virtio_queue_set_host_notifier_fd_handler: - assign=true/set_handler=true is only called from virtio_device_start_ioeventfd - assign=false/set_handler=false is called from set_host_notifier_internal but it only does something when reached

Re: [Qemu-devel] chardev's and fd's in monitors

On 21/10/2016 11:12, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 20/10/2016 10:37, Daniel P. Berrange wrote: >>> You have a problem of context - if you have multiple monitors, how do >>> you know which to send the error back to if you're not in the event >>>

[Qemu-devel] [PATCH 11/13] virtio: use virtio_bus_set_host_notifier to start/stop ioeventfd

ioeventfd_disabled was the only reason for the default implementation of virtio_device_start_ioeventfd not to use virtio_bus_set_host_notifier. This is now fixed, and the sole entry point to set up ioeventfd can be virtio_bus_set_host_notifier. Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v8 03/36] block: Introduce image file locking

On 30.09.2016 14:09, Fam Zheng wrote: > Block drivers can implement this new operation .bdrv_lockf to actually lock > the > image in the protocol specific way. > > Signed-off-by: Fam Zheng > --- > block.c | 52 >

[Qemu-devel] [PATCH 08/13] Revert "virtio: Introduce virtio_add_queue_aio"

This reverts commit 872dd82c83745a603d2e07a03d34313eb6467ae4. virtio_add_queue_aio is unused. Reviewed-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 38

[Qemu-devel] [PATCH 13/13] virtio: inline set_host_notifier_internal

This is only called from virtio_bus_set_host_notifier. Reviewed-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-bus.c | 62 +- 1

[Qemu-devel] [PATCH 03/13] virtio: move ioeventfd_started flag to VirtioBusState

This simplifies the code and removes the ioeventfd_started and ioeventfd_set_started callback. The only difference is in how virtio-ccw handles an error---it doesn't disable ioeventfd forever anymore. It was the only backend to do so, and if desired this behavior should be implemented in

[Qemu-devel] [PATCH 09/13] virtio: remove set_handler argument from set_host_notifier_internal

Make virtio_device_start_ioeventfd_impl use the same logic as dataplane to set up the host notifier. This removes the need for the set_handler argument in set_host_notifier_internal. This is a first step towards using virtio_bus_set_host_notifier as the sole entry point to set up ioeventfds. At

[Qemu-devel] [PATCH 10/13] virtio: remove ioeventfd_disabled altogether

Now that there is not anymore a switch from the generic ioeventfd handler to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is always called with !bus->ioeventfd_started, hence virtio_bus_stop_ioeventfd does nothing in this case. Move the invocation to vhost.c, which is the only

[Qemu-devel] [PATCH 04/13] virtio: add start_ioeventfd and stop_ioeventfd to VirtioDeviceClass

Allow customization of the start and stop of ioeventfd. This will allow direct start of dataplane without passing through the default ioeventfd handlers, which in turn allows using the dataplane logic instead of virtio_add_queue_aio. It will also enable some code simplification, because the sole

[Qemu-devel] [PATCH 06/13] virtio-blk: always use dataplane path if ioeventfd is active

Override start_ioeventfd and stop_ioeventfd to start/stop the whole dataplane logic. This has some positive side effects: - no need anymore for virtio_add_queue_aio (i.e. a revert of commit 0ff841f6d138904d514efa1d885bcaf54583852d) - no need anymore to switch from generic ioeventfd handlers

[Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

Override start_ioeventfd and stop_ioeventfd to start/stop the whole dataplane logic. This has some positive side effects: - no need anymore for virtio_add_queue_aio (i.e. a revert of commit 1c627137c10ee2dcf59e0383ade8a9abfa2d4355) - no need anymore to switch from generic ioeventfd handlers

[Qemu-devel] [PATCH 01/13] virtio: disable ioeventfd as early as possible

Avoid "tricking" virtio-blk-dataplane into thinking that ioeventfd will be available when it is not. This bug has always been there, but it will break TCG+ioeventfd=on once the dataplane code will be always used when ioeventfd=on. Reviewed-by: Cornelia Huck

[Qemu-devel] [PATCH 05/13] virtio: introduce virtio_device_ioeventfd_enabled

This will be used to forbid iothread configuration when the proxy does not allow using ioeventfd. To simplify the implementation, change the direction of the ioeventfd_disabled callback too. Reviewed-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck

[Qemu-devel] [PATCH v3 00/13] virtio: cleanup ioeventfd start/stop

This series started as an attempt to always use the dataplane path for virtio-blk and virtio-scsi when ioeventfd is active. The aim was three-fold: 1) to add more coverage for dataplane 2) to remove virtio_add_queue_aio 3) to simplify the dataplane start/stop code It achieves the first two

[Qemu-devel] [PATCH 02/13] virtio: move ioeventfd_disabled flag to VirtioBusState

This simplifies the code and removes the ioeventfd_set_disabled callback. Reviewed-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- hw/s390x/virtio-ccw.c | 11 +--

Re: [Qemu-devel] [PATCH v8 02/36] qapi: Add ImageLockMode

On 30.09.2016 14:09, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > qapi/block-core.json | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 92193ab..22e8d04 100644 > --- a/qapi/block-core.json >

Re: [Qemu-devel] [PATCH v3] block/replication: Clarify 'top-id' parameter usage

On 12.10.2016 06:50, Changlong Xie wrote: > The replication driver only supports the 'top-id' parameter for the > secondary side; it must not be supplied for the primary side. > > Reviewed-by: Eric Blake > Signed-off-by: Changlong Xie > --- >

[Qemu-devel] Mysterious RST connection with virtio-net NATting VM

I have a NATting VM (let's call this vm/nat) sitting in front of another VM (let's call this one vm/wget), with vm/wget residing in a private virtual network, with all network connectivity for vm/wget going through vm/nat. Additionally, I have a web server running on a physical machine from

Re: [Qemu-devel] [RFC 00/13] Multifd v2

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1477078935-7182-1-git-send-email-quint...@redhat.com Subject: [Qemu-devel] [RFC 00/13] Multifd v2 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] less confusing block file names

On 10/19/2016 09:11 PM, Eric Blake wrote: Based on a suggestion here: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00350.html Eric Blake (2): block: Rename raw_bsd to raw.c block: rename raw-{posix,win32} to file-*.c include/block/block_int.h | 2 +-

[Qemu-devel] [PULL 1/3] xen-usb: do not reference PAGE_SIZE

PAGE_SIZE is undefined on ARM64. Use XC_PAGE_SIZE instead, which is always 4096 even when page granularity is 64K. For this to actually work with 64K pages, more changes are required. Signed-off-by: Stefano Stabellini Reviewed-by: Juergen Gross

[Qemu-devel] [PULL 3/3] xen_platform: SUSE xenlinux unplug for emulated PCI

From: Olaf Hering Implement SUSE specific unplug protocol for emulated PCI devices in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. This protocol was implemented and used since Xen 3.0.4. It is used in all SUSE/SLES/openSUSE releases up to SLES11SP3 and openSUSE 12.3. In

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

On 20.10.2016 14:22, Vladimir Sementsov-Ogievskiy wrote: > On 01.10.2016 19:26, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are > > [...] > >> diff --git a/block/qcow2.c b/block/qcow2.c >>

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

On 21.10.2016 13:59, Vladimir Sementsov-Ogievskiy wrote: > 07.10.2016 22:25, Max Reitz пишет: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are >>> loaded at image open and becomes BdrvDirtyBitmap's for

[Qemu-devel] [PULL 2/3] xen_platform: unplug also SCSI disks

From: Olaf Hering Using 'vdev=sd[a-o]' will create an emulated LSI controller, which can be used by the emulated BIOS to boot from disk. If the HVM domU has also PV driver the disk may appear twice in the guest. To avoid this an unplug of the emulated hardware is needed, similar

[Qemu-devel] [PULL 0/3] tags/xen-20161021-tag

/xen-20161021-tag for you to fetch changes up to 35132016dc1c27de2b1354b161df6cc22f3ac5bf: xen_platform: SUSE xenlinux unplug for emulated PCI (2016-10-21 12:11:38 -0700) Xen 2016/10/21

Re: [Qemu-devel] [PATCH v4 RESEND 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

On Fri, Oct 21, 2016 at 03:14:00PM +0800, Jason Wang wrote: > > > On 2016年10月17日 23:44, Aviv B.D wrote: > > From: "Aviv Ben-David" > > > > This capability asks the guest to invalidate cache before each map > > operation. > > We can use this invalidation to trap map

Re: [Qemu-devel] [PATCH v3 1/2] xen_platform: unplug also SCSI disks

On Fri, 21 Oct 2016, Olaf Hering wrote: > Using 'vdev=sd[a-o]' will create an emulated LSI controller, which can > be used by the emulated BIOS to boot from disk. If the HVM domU has also > PV driver the disk may appear twice in the guest. To avoid this an > unplug of the emulated hardware is

Re: [Qemu-devel] [PATCH 12/22] qcow2-bitmap: add IN_USE flag

On 21.10.2016 17:34, Vladimir Sementsov-Ogievskiy wrote: > 07.10.2016 22:44, Max Reitz пишет: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> This flag means that the bitmap is now in use by the software or was not >>> successfully saved. In any way, with this flag set the bitmap

Re: [Qemu-devel] [RESEND PATCH v3 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration

On Fri, Oct 21, 2016 at 10:25:21AM -0700, Dave Hansen wrote: > On 10/20/2016 11:24 PM, Liang Li wrote: > > Dave Hansen suggested a new scheme to encode the data structure, > > because of additional complexity, it's not implemented in v3. > > So, what do you want done with this patch set? Do you

[Qemu-devel] [PATCH 08/13] migration: Create thread infrastructure for multifd send side

We make the locking and the transfer of information specific, even if we are still transmiting things through the main thread. Signed-off-by: Juan Quintela --- migration/ram.c | 55 +-- 1 file changed, 53 insertions(+), 2

[Qemu-devel] [PATCH 12/13] migration: [HACK]Transfer pages over new channels

We switch for sending the page number to send real pages. [HACK] How we calculate the bandwidth is beyond repair, there is a hack there that would work for x86 and archs that have 4kb pages. If you are having a nice day just go to migration/ram.c and look at acct_update_position(). Now you are

Re: [Qemu-devel] [PATCH v3 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

On Fri, 21 Oct 2016, Olaf Hering wrote: > Implement SUSE specific unplug protocol for emulated PCI devices > in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. > This protocol was implemented and used since Xen 3.0.4. > It is used in all SUSE/SLES/openSUSE releases up to SLES11SP3 and >

Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

On 17.10.2016 19:19, Vladimir Sementsov-Ogievskiy wrote: > On 07.10.2016 22:24, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Realize block bitmap stroing interface, to allow qcow2 images store >>> persistent bitmaps. >>> >>> Signed-off-by: Vladimir

[Qemu-devel] [PATCH 06/13] migration: Start of multiple fd work

We create new channels for each new thread created. We only send through them a character to be sure that we are creating the channels in the right order. Note: Reference count/freeing of channels is not done Signed-off-by: Juan Quintela --- include/migration/migration.h |

[Qemu-devel] [PATCH 05/13] migration: create multifd migration threads

Creation of the threads, nothing inside yet. Signed-off-by: Juan Quintela --- include/migration/migration.h | 4 ++ migration/migration.c | 6 ++ migration/ram.c | 148 ++ 3 files changed, 158 insertions(+)

[Qemu-devel] [PATCH 10/13] migration: Create thread infrastructure for multifd recv side

We make the locking and the transfer of information specific, even if we are still receiving things through the main thread. Signed-off-by: Juan Quintela --- migration/ram.c | 47 --- 1 file changed, 44 insertions(+), 3

[Qemu-devel] [PATCH 13/13] migration: flush receive queue

From: Juan Quintela Each time that we sync the bitmap, it is a possiblity that we receive a page that is being processed by a different thread. We fix this problem just making sure that we wait for all receiving threads to finish its work before we procedeed with the next

[Qemu-devel] [PATCH 03/13] migration: Add multifd capability

Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 + migration/migration.c | 9 + qapi-schema.json | 5 +++-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/include/migration/migration.h

[Qemu-devel] [PATCH 09/13] migration: Send the fd number which we are going to use for this page

We are still sending the page through the main channel, that would change later in the series Signed-off-by: Juan Quintela --- migration/ram.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH 11/13] migration: Test new fd infrastructure

We just send the address through the alternate channels and test that it is ok. Signed-off-by: Juan Quintela --- migration/ram.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH 04/13] migration: Create x-multifd-threads parameter

Indicates the number of threads that we would create. By default we create 2 threads. Signed-off-by: Juan Quintela --- hmp.c | 7 +++ include/migration/migration.h | 2 ++ migration/migration.c | 24

[Qemu-devel] [PATCH 02/13] migration: [HACK] Don't create decompression threads if not enabled

This is a partial fix, we also need to not allow reception of compression packages if not enabled. Signed-off-by: Juan Quintela --- migration/ram.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index bc6154f..495a931 100644 ---

[Qemu-devel] [PATCH 01/13] migration: create Migration Incoming State at init time

Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 - migration/migration.c | 38 +- migration/savevm.c| 4 ++-- 3 files changed, 19 insertions(+), 24 deletions(-) diff --git

[Qemu-devel] [PATCH 07/13] migration: create ram_multifd_page

The function still don't use multifd, but we have simplified ram_save_page, xbzrle and RDMA stuff is gone. We have added a new counter and a new flag for this type of pages. Signed-off-by: Juan Quintela --- hmp.c | 2 ++

[Qemu-devel] [RFC 00/13] Multifd v2

Hi This is a version against current code. It is based on top of QIO work. It improves the thread synchronization and fixes the problem when we could have two threads handing the same page. Please comment, Juan. Juan Quintela (13): migration: create Migration Incoming State at init time

[Qemu-devel] [PATCH v2] target-i386: Print warning when mixing [+-]foo and foo=(on|off)

Print a warning when mixing [+-]foo and foo=(on|off) in the -cpu argument in a way that will break in the future. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Coding style fixes * Print "compatibility won't be kept" warning only once * Move subprocess test code

Re: [Qemu-devel] [PATCH v11 01/19] block: Add bdrv_drain_all_{begin, end}()

On 10/21/2016 03:03 PM, Alberto Garcia wrote: On Fri 21 Oct 2016 08:55:51 PM CEST, John Snow wrote: bdrv_drain_all() doesn't allow the caller to do anything after all pending requests have been completed but before block jobs are resumed. This patch splits

Re: [Qemu-devel] [PATCH] target-i386: Print warning when mixing [+-]foo and foo=(on|off)

On Fri, Oct 21, 2016 at 12:15:30PM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: [...] > total: 5 errors, 0 warnings, 73 lines checked I'm ashamed. Sorry for the noise. I will submit v2 addressing that. -- Eduardo

Re: [Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

Am 21.10.2016 um 10:06 schrieb Dr. David Alan Gilbert: The problem isn't the version of the contents of the section, it's the naming of the devices. I think you can work around it by adding aliases for the old names. Dave How should I add such aliases? Are there other devices with vmstate

Re: [Qemu-devel] [PATCH] target-i386: Print warning when mixing [+-]foo and foo=(on|off)

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1477075788-26632-1-git-send-email-ehabk...@redhat.com Subject: [Qemu-devel] [PATCH] target-i386:

Re: [Qemu-devel] [PATCH] target-i386: Print warning when mixing [+-]foo and foo=(on|off)

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] target-i386: Print warning when mixing [+-]foo and foo=(on|off) Type: series Message-id: 1477075788-26632-1-git-send-email-ehabk...@redhat.com === TEST SCRIPT BEGIN

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

On 10/21/2016 11:51 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/15/2016 05:48 AM, Halil Pasic wrote: >>> >>> >>> On 10/14/2016 07:18 PM, Jianjun Duan wrote: +/* + * Offsets of layout of a tail queue head.

Re: [Qemu-devel] [PATCH v11 01/19] block: Add bdrv_drain_all_{begin, end}()

On Fri 21 Oct 2016 08:55:51 PM CEST, John Snow wrote: bdrv_drain_all() doesn't allow the caller to do anything after all pending requests have been completed but before block jobs are resumed. This patch splits bdrv_drain_all() into _begin() and _end()

Re: [Qemu-devel] [PATCH v11 01/19] block: Add bdrv_drain_all_{begin, end}()

On 10/20/2016 04:25 AM, Alberto Garcia wrote: On Wed 19 Oct 2016 07:11:20 PM CEST, Kevin Wolf wrote: bdrv_drain_all() doesn't allow the caller to do anything after all pending requests have been completed but before block jobs are resumed. This patch splits bdrv_drain_all() into _begin()

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > > > On 10/15/2016 05:48 AM, Halil Pasic wrote: > > > > > > On 10/14/2016 07:18 PM, Jianjun Duan wrote: > >> +/* > >> + * Offsets of layout of a tail queue head. > >> + */ > >> +#define QTAILQ_FIRST_OFFSET 0 >

[Qemu-devel] [PATCH] target-i386: Print warning when mixing [+-]foo and foo=(on|off)

Print a warning when mixing [+-]foo and foo=(on|off) in the -cpu argument in a way that will break in the future. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 20 tests/test-x86-cpuid-compat.c | 19 ++- 2 files

[Qemu-devel] [PATCH v2] vfio/pci: fix out-of-sync BAR information on reset

When a PCI device is reset, pci_do_device_reset resets all BAR addresses in the relevant PCIDevice's config buffer. The VFIO configuration space stays untouched, so the guest OS may choose to skip restoring the BAR addresses as they would seem intact. The PCI device may be left non-operational.

[Qemu-devel] [Bug 1635695] [NEW] ovmf + smp + hyper-v + windows 7: doesn't work

Public bug reported: - using ovmf - enable smp (>1 processors/cores) - enable hyper-v features (eg. -cpu Haswell,hv_time,hv_relaxed,hv_vapic,hv_spinlocks=0x1fff) - try to boot or install windows 7 x64 Result: black screen and hangs ** Affects: qemu Importance: Undecided Status:

Re: [Qemu-devel] [PATCH] vfio/pci: fix out-of-sync BAR information on reset

Hi Alex, On Fri, Oct 21, 2016 at 2:03 PM, Alex Williamson wrote: > On Fri, 21 Oct 2016 13:00:33 -0400 > Ido Yariv wrote: > > > When a PCI device is reset, pci_do_device_reset resets all BAR addresses > > in the relevant PCIDevice's config buffer. >

Re: [Qemu-devel] [PATCH v14 02/21] qdict: implement a qdict_crumple method for un-flattening a dict

On 21.10.2016 11:58, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > >> On Tue, Oct 18, 2016 at 04:32:13PM +0200, Markus Armbruster wrote: >>> "Daniel P. Berrange" writes: >>> The qdict_flatten() method will take a dict whose elements are

Re: [Qemu-devel] [PATCH v14 00/21] QAPI/QOM work for non-scalar object properties

"Daniel P. Berrange" writes: > An update of a series previously posted > > v1: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04618.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01454.html > v3:

[Qemu-devel] [Qemu-ppc] target-ppc: gdbstub breakpoints get stuck in an infinite loop on next/continue

> Hi all, > > I've just noticed the above regression in git master whilst trying to > debug something in openbios-ppc via QEMU's gdbstub. Reproduction here is > fairly easy using a debug build of OpenBIOS which I've uploaded to > https://www.ilande.co.uk/tmp/qemu/openbios-qemu.elf.nostrip for

Re: [Qemu-devel] QOM properties vs C functions/fields (was Re: [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn())

Peter Maydell writes: > On 18 October 2016 at 21:49, Eduardo Habkost wrote: >> On Tue, Oct 18, 2016 at 09:30:01PM +0100, Peter Maydell wrote: >>> Lots of stuff in a device's C struct is strictly internal >>> and not to be messed with. I thought

Re: [Qemu-devel] [PATCH v2] i2c: Fix SMBus read transactions to avoid double events

On 10/21/2016 12:57 PM, Peter Maydell wrote: On 2 August 2016 at 17:00, wrote: From: Corey Minyard Change 2293c27faddf (i2c: implement broadcast write) added broadcast capability to the I2C bus, but it broke SMBus read transactions. An SMBus read

Re: [Qemu-devel] [PATCH] trivial: Restore blank line in qapi-schema

Eric Blake writes: > Commit de63ab6 accidentally undid part of commit a43edcf, > because the two patches were written in parallel, and the > blank line was not noticed as a casualty of merge conflicts. > > Signed-off-by: Eric Blake Applied to qapi-next,

Re: [Qemu-devel] [Bug 1626972] Re: [PATCH] util: secure memfd_create fallback mechanism

Hi On Fri, Oct 21, 2016 at 6:03 AM Rafael David Tinoco < rafael.tin...@canonical.com> wrote: > Judging by the outputs above, looks like vhost_dev_log_is_shared is > returning false, making (2) - vhost_dev_start - to use a different log > allocation (malloc) than the one that was tested for

Re: [Qemu-devel] [PATCH] vfio/pci: fix out-of-sync BAR information on reset

On Fri, 21 Oct 2016 13:00:33 -0400 Ido Yariv wrote: > When a PCI device is reset, pci_do_device_reset resets all BAR addresses > in the relevant PCIDevice's config buffer. > > The VFIO configuration space stays untouched, so the guest OS may choose > to skip restoring the BAR

Re: [Qemu-devel] ?==?utf-8?q? [PATCH v7 05/10] linux-user: Add support for ustat() syscall

Sure, thanks for all other efforts that you put regarding my patches. I may post another version in some time. There is no rush wrt 2.8 as far as I am concerned. Original Message Subject: Re: [PATCH v7 05/10] linux-user: Add support for ustat() syscall Date: Friday, October

Re: [Qemu-devel] [PATCH v2] i2c: Fix SMBus read transactions to avoid double events

On 2 August 2016 at 17:00, wrote: > From: Corey Minyard > > Change 2293c27faddf (i2c: implement broadcast write) added broadcast > capability to the I2C bus, but it broke SMBus read transactions. > An SMBus read transaction does two i2c_start_transaction()

Re: [Qemu-devel] [V6] fsdev: add IO throttle support to fsdev devices

On Fri 21 Oct 2016 06:21:59 PM CEST, Pradeep Jagadeesh wrote: > +static bool fsdev_throttle_check_for_wait(FsThrottle *fst, bool is_write) > +{ > + return throttle_schedule_timer(>ts, >tt, is_write); ^ There's an extra whitespace there. > +static void

Re: [Qemu-devel] [PATCH v14 01/21] option: make parse_option_bool/number non-static

Eric Blake writes: > On 10/21/2016 11:55 AM, Markus Armbruster wrote: > >> >> On first glance, this patch makes the boolean values recognized on the >> command line consistent regardless of which part of the code is used to >> recognize them, by extending the QemuOpts parser

[Qemu-devel] [PATCH] migration: Remove unneeded NULL check from migrate_fd_error()

All the callers of migrate_fd_error() pass a non-NULL error parameter, and if any did pass NULL then we would segfault in error_copy(), so remove the unnecessary NULL check earlier in the function. (Spotted by Coverity.) Signed-off-by: Peter Maydell --- This seems

Re: [Qemu-devel] [PATCH 0/5] More thread sanitizer fixes and atomic.h improvements

Paolo Bonzini writes: > See each patch. My attempt at fixing whatever I did when I obviously > didn't know enough^W about the C11 memory model, and at setting a > better example for future generations... Are you posting a v2 of this? Alternatively I can slurp them into my

Re: [Qemu-devel] [RESEND PATCH v3 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration

On 10/20/2016 11:24 PM, Liang Li wrote: > Dave Hansen suggested a new scheme to encode the data structure, > because of additional complexity, it's not implemented in v3. So, what do you want done with this patch set? Do you want it applied as-is so that we can introduce a new host/guest ABI

Re: [Qemu-devel] [PATCH v14 01/21] option: make parse_option_bool/number non-static

On 10/21/2016 11:55 AM, Markus Armbruster wrote: > > On first glance, this patch makes the boolean values recognized on the > command line consistent regardless of which part of the code is used to > recognize them, by extending the QemuOpts parser to accept the option > visitor's additional

[Qemu-devel] [RFC PATCH] memory: Don't use memcpy for ram marked as skip_dump

With a vfio assigned device we lay down a base MemoryRegion registered as an IO region, giving us read & write accessors. If the region supports mmap, we lay down a higher priority sub-region MemoryRegion on top of the base layer initialized as a RAM pointer to the mmap. Finally, if we have any

Re: [Qemu-devel] [PATCH v7 05/10] linux-user: Add support for ustat() syscall

On Thu, Sep 22, 2016 at 06:56:54PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This patch implements Qemu user mode ustat() syscall support. > > Syscall ustat() returns information about a mounted filesystem. > > Its declaration is: > >

[Qemu-devel] [PATCH] vfio/pci: fix out-of-sync BAR information on reset

When a PCI device is reset, pci_do_device_reset resets all BAR addresses in the relevant PCIDevice's config buffer. The VFIO configuration space stays untouched, so the guest OS may choose to skip restoring the BAR addresses as they would seem intact. The PCI device may be left non-operational.

  1   2   3   >