Re: [Qemu-devel] [RFC 09/17] ppc: Validate compatibility modes when setting

2016-10-30 Thread Alexey Kardashevskiy
On 30/10/16 22:12, David Gibson wrote: > Current ppc_set_compat() will attempt to set any compatiblity mode > specified, regardless of whether it's available on the CPU. The caller is > expected to make sure it is setting a possible mode, which is awkwward > because most of the information to

Re: [Qemu-devel] [RFC 10/17] pseries: Rewrite CAS PVR compatibility logic

2016-10-30 Thread David Gibson
On Mon, Oct 31, 2016 at 04:00:14PM +1100, Alexey Kardashevskiy wrote: > On 30/10/16 22:12, David Gibson wrote: > > During boot, PAPR guests negotiate CPU model support with the > > ibm,client-architecture-support mechanism. The logic to implement this in > > qemu is very convoluted. This cleans

[Qemu-devel] [PATCH v4] vfio: Add support for mmapping sub-page MMIO BARs

2016-10-30 Thread Yongji Xie
Now the kernel commit 05f0c03fbac1 ("vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive") allows VFIO to mmap sub-page BARs. This is the corresponding QEMU patch. With those patches applied, we could passthrough sub-page BARs to guest, which can help to improve IO performance

Re: [Qemu-devel] [RFC 10/17] pseries: Rewrite CAS PVR compatibility logic

2016-10-30 Thread Alexey Kardashevskiy
On 30/10/16 22:12, David Gibson wrote: > During boot, PAPR guests negotiate CPU model support with the > ibm,client-architecture-support mechanism. The logic to implement this in > qemu is very convoluted. This cleans it up to be cleaner, using the new > ppc_check_compat() call. > > The new

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-10-30 Thread Alexey Kardashevskiy
On 31/10/16 13:53, David Gibson wrote: > On Fri, Oct 28, 2016 at 12:07:12PM +0200, Greg Kurz wrote: >> On Fri, 28 Oct 2016 18:56:40 +1100 >> Alexey Kardashevskiy wrote: >> >>> At the moment sPAPR PHB creates a root buf of TYPE_PCI_BUS type. >>> This means that vfio-pci devices

Re: [Qemu-devel] [PATCH v3] util/mmap-alloc: check parameter before using

2016-10-30 Thread Cao jin
On 10/28/2016 10:22 PM, Michael Tokarev wrote: 28.10.2016 11:56, Cao jin wrote: Also refactor a little bit for readability See comments below... Signed-off-by: Cao jin --- util/mmap-alloc.c | 17 - 1 file changed, 8 insertions(+), 9

Re: [Qemu-devel] [PATCH v10 10/19] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-10-30 Thread Jike Song
On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers > about DMA_UNMAP. > Exported two APIs vfio_register_notifier() and vfio_unregister_notifier(). > Vendor driver should register notifer using these APIs. > Vendor driver should

Re: [Qemu-devel] [PATCH v3] vfio: Add support for mmapping sub-page MMIO BARs

2016-10-30 Thread Yongji Xie
On 2016/10/31 3:59, Alex Williamson wrote: On Wed, 26 Oct 2016 16:56:13 +0800 Yongji Xie wrote: Now the kernel commit 05f0c03fbac1 ("vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive") allows VFIO to mmap sub-page BARs. This is the

Re: [Qemu-devel] [PATCH] x86/cpuid:add AVX512_4VNNIW and AVX512_4FMAPS features.

2016-10-30 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] x86/cpuid:add AVX512_4VNNIW and AVX512_4FMAPS features. Message-id: 1477646144-7055-1-git-send-email-he.c...@linux.intel.com === TEST SCRIPT BEGIN ===

[Qemu-devel] How to print value of float instruction argument

2016-10-30 Thread Programmingkid
I'm trying to print the value of the arguments sent to gen_fmadds() in target-ppc/translate/fp-impl.inc.c. How do I do this? I have tried printf("cpu_fpr[rA(ctx->opcode)] = %d\n", cpu_fpr[rA(ctx->opcode)]), but that always prints the same value of 138 even if I change the values sent to fmadds.

Re: [Qemu-devel] [PATCH] atapi: classify read_cd as conditionally returning data

2016-10-30 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] atapi: classify read_cd as conditionally returning data Message-id: 1477693948-14419-1-git-send-email-js...@redhat.com === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCHv2 0/3] Move getting XWindow ID from baum driver to graphical backend

2016-10-30 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCHv2 0/3] Move getting XWindow ID from baum driver to graphical backend Message-id:

Re: [Qemu-devel] [PATCH v9 00/12] virtio-crypto: introduce framework and device emulation

2016-10-30 Thread Gonglei (Arei)
> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Monday, October 31, 2016 4:00 AM > Subject: Re: [Qemu-devel] [PATCH v9 00/12] virtio-crypto: introduce framework > and device emulation > > > > On 10/20/2016 01:45 PM, Gonglei wrote: > > The front-end linux kernel driver

Re: [Qemu-devel] [Qemu-ppc] [PATCH] 4/4] target-ppc: Implement bcdctz. instruction

2016-10-30 Thread David Gibson
On Thu, Oct 27, 2016 at 06:08:20PM -0200, jos...@linux.vnet.ibm.com wrote: > On Thu, Oct 27, 2016 at 12:47:34PM +1100, David Gibson wrote: > > On Wed, Oct 26, 2016 at 11:18:58AM -0200, Jose Ricardo Ziviani wrote: > > > bcdctz. converts from BCD to Zoned numeric format. Zoned format uses > > > a

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-10-30 Thread David Gibson
On Fri, Oct 28, 2016 at 12:07:12PM +0200, Greg Kurz wrote: > On Fri, 28 Oct 2016 18:56:40 +1100 > Alexey Kardashevskiy wrote: > > > At the moment sPAPR PHB creates a root buf of TYPE_PCI_BUS type. > > This means that vfio-pci devices attached to it (and this is > > a default

Re: [Qemu-devel] [PATCH 0/6] Expand the building of qemu-user docker images

2016-10-30 Thread Fam Zheng
On Fri, 10/28 17:33, Alex Bennée wrote: > Hi Fam, > > These are a little bit of a work in progress so maybe not all ready to > be taken yet although review would be welcome. > > This adds some tweaks to allow us to build the cross-arch debian > images with direct make invocations and then see

Re: [Qemu-devel] [PATCH v2 4/4] target-ppc: Implement bcdctz. instruction

2016-10-30 Thread David Gibson
On Fri, Oct 28, 2016 at 03:18:04PM -0200, Jose Ricardo Ziviani wrote: > bcdctz. converts from BCD to Zoned numeric format. Zoned format uses > a byte to represent a digit where the most significant nibble is 0x3 > or 0xf, depending on the preferred signal. > > Signed-off-by: Jose Ricardo Ziviani

Re: [Qemu-devel] [PATCH v2 0/4] POWER9 TCG enablements - BCD functions part I

2016-10-30 Thread David Gibson
On Fri, Oct 28, 2016 at 03:18:00PM -0200, Jose Ricardo Ziviani wrote: > v2: > - implements all fixes and suggestions Ok, I think the implementations are correct now, but there is still some polish necessary - comments on the individual patches. I have to wonder what the chip designers were

Re: [Qemu-devel] [PATCH v2 3/4] target-ppc: Implement bcdcfz. instruction

2016-10-30 Thread David Gibson
On Fri, Oct 28, 2016 at 03:18:03PM -0200, Jose Ricardo Ziviani wrote: > bcdcfz. converts from Zoned numeric format to BCD. Zoned format uses > a byte to represent a digit where the most significant nibble is 0x3 > or 0xf, depending on the preferred signal. > > Signed-off-by: Jose Ricardo Ziviani

Re: [Qemu-devel] [PATCH 6/6] tests/docker/Makefile.include: expand docker help text

2016-10-30 Thread Fam Zheng
On Fri, 10/28 17:33, Alex Bennée wrote: > No we can query what has and hasn't been built we can make this list > available in the help text. This is useful as some of the bootstrapped > builds can take some time to build. I'm not sure how useful it is to list built images without checking if it's

Re: [Qemu-devel] [PATCH 5/6] tests/docker/docker.py: expand images command

2016-10-30 Thread Fam Zheng
On Fri, 10/28 17:33, Alex Bennée wrote: > Modern docker cli commands can filter by repository but as we want to > work on all instances do this by hand in python: > >/tests/docker/docker.py images --repo qemu > > Will return a space delimited list for the benefit of our Makefile > recipes. >

Re: [Qemu-devel] [PATCH 3/6] tests/docker: add optional libs to travis.docker

2016-10-30 Thread Fam Zheng
On Fri, 10/28 17:33, Alex Bennée wrote: > In our .travis.yml we install a bunch of extra libraries which are not > part of the packaged QEMU's builddeps. We include them here to make our > docker container more closely match the state of the system after docker > has installed the rest of the

Re: [Qemu-devel] [PATCH 2/6] tests/docker/test-user: a simple linux-user test

2016-10-30 Thread Fam Zheng
On Fri, 10/28 17:33, Alex Bennée wrote: > This is useful for checking an appropriately updated cross-arch docker > actually starts without having to do a full build. Can we call it "test-pass"? Fam > > Signed-off-by: Alex Bennée > --- > tests/docker/test-user | 18

Re: [Qemu-devel] [PATCH 1/6] tests/docker/Makefile.include: fix diff-index call

2016-10-30 Thread Fam Zheng
On Fri, 10/28 17:33, Alex Bennée wrote: > The whole thing is wrapped inside a call quiet-command as well as being > the actual call taking a --quiet argument so the redirect is > superfluous. For reasons I have yet to determine this also seems to be > causing the source preparation step to skip

Re: [Qemu-devel] [PATCH] 2/4] target-ppc: Implement bcdctn. instruction

2016-10-30 Thread David Gibson
On Thu, Oct 27, 2016 at 02:13:13PM -0200, jos...@linux.vnet.ibm.com wrote: > On Thu, Oct 27, 2016 at 12:20:17PM +1100, David Gibson wrote: > > On Wed, Oct 26, 2016 at 11:18:56AM -0200, Jose Ricardo Ziviani wrote: > > > bcdctn. converts from BCD to National numeric format. National format > > >

Re: [Qemu-devel] [PATCH v2 2/4] target-ppc: Implement bcdctn. instruction

2016-10-30 Thread David Gibson
On Fri, Oct 28, 2016 at 03:18:02PM -0200, Jose Ricardo Ziviani wrote: > bcdctn. converts from BCD to National numeric format. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 1/4] target-ppc: Implement bcdcfn. instruction

2016-10-30 Thread David Gibson
On Fri, Oct 28, 2016 at 03:18:01PM -0200, Jose Ricardo Ziviani wrote: > bcdcfn. converts from National numeric format to BCD. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. > > Signed-off-by:

Re: [Qemu-devel] [PATCH V8] fsdev: add IO throttle support to fsdev devices

2016-10-30 Thread Greg Kurz
Hi Pradeep, There are still a couple of issues to address with this v8, even if we're not that far from the final version. On Sun, 30 Oct 2016 11:30:43 -0400 Pradeep Jagadeesh wrote: > Date: Sun, 30 Oct 2016 10:53:16 -0400 > Subject: [PATCH V8] fsdev: add IO throttle

Re: [Qemu-devel] [PATCH v3 0/4] POWER9 TCG enablements - part7

2016-10-30 Thread David Gibson
On Sun, Oct 30, 2016 at 08:44:54AM +0530, Nikunj A Dadhania wrote: > This series contains 7 new instructions for POWER9 ISA3.0 > Vector Rotate Left Dword > Vector Rotate Left Word > Vector Parity Byte Applied to ppc-for-2.8. > > Changelog: > v2: > * added internal.h with MASK

Re: [Qemu-devel] [PATCH v4 00/10] Convert msix_init() to error

2016-10-30 Thread Michael S. Tsirkin
On Wed, Oct 19, 2016 at 02:47:35PM +0800, Cao jin wrote: > v4 changelog > 1. add the missed comment of "errp" in the msix_init's function comment > 2. fix typo: msic --> msix > 3. fix a build failure due to "copy" error, in patch >"megasas: change behaviour of msix switch" > 4. separate the

[Qemu-devel] [PULL 45/47] ipmi: Add graceful shutdown handling to the external BMC

2016-10-30 Thread Michael S. Tsirkin
From: Corey Minyard I misunderstood the workings of the power settings, the power off is a force off operation and there needs to be a separate graceful shutdown operation. So replace the force off operation with a graceful shutdown. Signed-off-by: Corey Minyard

[Qemu-devel] [PULL 43/47] ipmi: Implement shutdown via ACPI overtemp

2016-10-30 Thread Michael S. Tsirkin
From: Corey Minyard This is allowed by the IPMI specification for graceful shutdown, so implement it. Signed-off-by: Corey Minyard Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/ipmi/ipmi.c

Re: [Qemu-devel] [PATCH qemu v3 0/6] Fast (de)inflating & fast live migration

2016-10-30 Thread Michael S. Tsirkin
On Fri, Oct 21, 2016 at 02:48:18PM +0800, Liang Li wrote: > This patch set intends to do two optimizations, one is to speed up > the (de)inflating process of virtio balloon, and another one which > is to speed up the live migration process. We put them together > because both of them are required

[Qemu-devel] [PULL 38/47] nvdimm acpi: introduce _FIT

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong _FIT is required for hotplug support, guest will inquire the updated device info from it if a hotplug event is received As FIT buffer is not completely mapped into guest address space, so a new function, Read FIT whose UUID is UUID

[Qemu-devel] [PULL 37/47] nvdimm acpi: introduce fit buffer

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong The buffer is used to save the FIT info for all the presented nvdimm devices which is updated after the nvdimm device is plugged or unplugged. In the later patch, it will be used to construct NVDIMM ACPI _FIT method which reflects the

[Qemu-devel] [PULL 41/47] ipmi_bmc_sim: Remove an unnecessary mutex

2016-10-30 Thread Michael S. Tsirkin
From: Corey Minyard Get rid of the unnecessary mutex, it was a vestige of something else that was not done. That way we don't have to free it. Signed-off-by: Corey Minyard Reviewed-by: Marc-André Lureau Reviewed-by:

[Qemu-devel] [PULL 36/47] nvdimm acpi: prebuild nvdimm devices for available slots

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong For each NVDIMM present or intended to be supported by platform, platform firmware also exposes an ACPI Namespace Device under the root device So it builds nvdimm devices for all slots to support vNVDIMM hotplug Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 46/47] acpi/ipmi: Initialize the fwinfo before fetching it

2016-10-30 Thread Michael S. Tsirkin
From: Corey Minyard The initialization was missed before, resulting in some bad data in the smbus case. Signed-off-by: Corey Minyard Cc: qemu-sta...@nongnu.org Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 44/47] ipmi: fix build config variable name for ipmi_bmc_extern.o

2016-10-30 Thread Michael S. Tsirkin
From: "Daniel P. Berrange" The original commit: commit 67aa56fc03bea44ccf384ea400515a8a58844a50 Author: Corey Minyard Date: Thu Dec 17 12:50:06 2015 -0600 ipmi: Add an external connection simulation interface defined a new variable

[Qemu-devel] [PULL 32/47] acpi nvdimm: fix Arg6 usage

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong As the function only has 5 args, we use local7 instead of it Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL 47/47] acpi: fix assert failure caused by commit 35c5a52d

2016-10-30 Thread Michael S. Tsirkin
From: Haozhong Zhang Commit 35c5a52d "acpi: do not use TARGET_PAGE_SIZE" changed struct NvdimmDsmIn from a variable-size structure to a fixed-size structure of 4096 bytes. It forgot to adjust an assert in nvdimm_dsm_set_label_data(..., NvdimmDsmIn *in, ...):

[Qemu-devel] [PULL 33/47] nvdimm acpi: compile nvdimm acpi code arch-independently

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong As the arch dependent info, TARGET_PAGE_SIZE, has been dropped from nvdimm acpi code, it can be compiled arch-independently Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 35/47] nvdimm acpi: use common macros instead of magic names

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong There are some names repeatedly used in acpi code, define them as macros to refine the code Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 30/47] acpi nvdimm: fix device physical address base

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong According to ACPI 6.0 spec, "Memory Device Physical Address Region Base" in memdev is defined as "This field provides the Device Physical Address base of the region". This field should be zero in our case Signed-off-by: Xiao Guangrong

[Qemu-devel] [PULL 42/47] ipmi: chassis poweroff should use qemu_system_shutdown_request()

2016-10-30 Thread Michael S. Tsirkin
From: Cédric Le Goater When issuing a chassis 'powerdown' control command, the routine qemu_system_shutdown_request() should be used to exit the guest. qemu_system_powerdown_request() will initiate a soft shutdown which is not what is required by the IPMI (28.3 Chassis Control

[Qemu-devel] [PULL 28/47] acpi nvdimm: fix wrong buffer size returned by DSM method

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong Currently, 'RLEN' is the totally buffer size written by QEMU and it is ACPI internally used only. The buffer size returned to guest should not include 'RLEN' itself Signed-off-by: Xiao Guangrong Reviewed-by:

[Qemu-devel] [PULL 31/47] acpi nvdimm: fix ARG3 conflict

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong As ARG3 is a reserved name, we rename it to FARG Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 25/47] cryptodev: introduce an unified wrapper for crypto operation

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei We use an opaque point to the VirtIOCryptoReq which can support different packets based on different algorithms. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 40/47] ipmi: Remove hotplug from IPMI BMCs

2016-10-30 Thread Michael S. Tsirkin
From: Corey Minyard No hotplug support, make sure it doesn't happen. Signed-off-by: Corey Minyard Reviewed-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 29/47] acpi nvdimm: fix OperationRegion definition

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong Based on ACPI spec: RegionOffset := TermArg => Integer However, Named object is not a TermArg. This patch moves OperationRegion to NCAL() and uses localX as its RegionOffset Suggested-by: Igor Mammedov Signed-off-by:

[Qemu-devel] [PULL 20/47] virtio-crypto: add virtio crypto device emulation

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei Introduce the virtio crypto realization, I'll finish the core code in the following patches. The thoughts came from virtio net realization. For more information see: http://qemu-project.org/Features/VirtioCrypto Signed-off-by: Gonglei

[Qemu-devel] [PULL 19/47] cryptodev: introduce a new cryptodev backend

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei The new cryptodev backend named cryptodev-builtin, which realized by QEMU cipher APIs. These APIs can be backed by either nettle or gcrypt. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL 39/47] pc: memhp: enable nvdimm device hotplug

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong _GPE.E04 is dedicated for nvdimm device hotplug Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL 17/47] cryptodev: add symmetric algorithm operation stuff

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei This patch adds session operation and crypto operation stuff in the cryptodev backend, including function pointers and corresponding structures. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 24/47] virtio-crypto: add data queue processing handler

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei Introduces VirtIOCryptoReq structure to store crypto request so that we can easily support asynchronous crypto operation in the future. At present, we only support cipher and algorithm chaining. Signed-off-by: Gonglei

[Qemu-devel] [PULL 15/47] virtio: inline set_host_notifier_internal

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini This is only called from virtio_bus_set_host_notifier. Reviewed-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 34/47] acpi nvdimm: rename result_size to dsm_out_buf_siz

2016-10-30 Thread Michael S. Tsirkin
From: Xiao Guangrong Rename it as dsm_out_buf_siz is more descriptive Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 14/47] virtio: inline virtio_queue_set_host_notifier_fd_handler

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini Of the three possible parameter combinations for virtio_queue_set_host_notifier_fd_handler: - assign=true/set_handler=true is only called from virtio_device_start_ioeventfd - assign=false/set_handler=false is called from set_host_notifier_internal

[Qemu-devel] [PULL 23/47] virtio-crypto: add control queue handler

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei Realize the symmetric algorithm control queue handler, including plain cipher and chainning algorithms. Currently the control queue is used to create and close session for symmetric algorithm. Signed-off-by: Gonglei Reviewed-by:

[Qemu-devel] [PULL 13/47] virtio: use virtio_bus_set_host_notifier to start/stop ioeventfd

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini ioeventfd_disabled was the only reason for the default implementation of virtio_device_start_ioeventfd not to use virtio_bus_set_host_notifier. This is now fixed, and the sole entry point to set up ioeventfd can be virtio_bus_set_host_notifier.

[Qemu-devel] [PULL 27/47] virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei This patch includes two parts: Cryptodev Backends and virtio-crypto stuff. I can maintain cryptodev backends which introduced by myself. For virtio-crypto stuff, I can share the work with Michael (The whole virtio supporter). Signed-off-by: Gonglei

[Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini Now that there is not anymore a switch from the generic ioeventfd handler to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is always called with !bus->ioeventfd_started, hence virtio_bus_stop_ioeventfd does nothing in this case. Move

[Qemu-devel] [PULL 18/47] virtio-crypto: introduce virtio_crypto.h

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei Introduce the virtio_crypto.h which follows virtio-crypto specification. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL 11/47] virtio: remove set_handler argument from set_host_notifier_internal

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini Make virtio_device_start_ioeventfd_impl use the same logic as dataplane to set up the host notifier. This removes the need for the set_handler argument in set_host_notifier_internal. This is a first step towards using virtio_bus_set_host_notifier as the

[Qemu-devel] [PULL 26/47] virtio-crypto: using bh to handle dataq's requests

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei Make crypto operations are executed asynchronously, so that other QEMU threads and monitor couldn't be blocked at the virtqueue handling context. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 08/47] virtio-blk: always use dataplane path if ioeventfd is active

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini Override start_ioeventfd and stop_ioeventfd to start/stop the whole dataplane logic. This has some positive side effects: - no need anymore for virtio_add_queue_aio (i.e. a revert of commit 0ff841f6d138904d514efa1d885bcaf54583852d) - no need anymore

[Qemu-devel] [PULL 16/47] cryptodev: introduce cryptodev backend interface

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei cryptodev backend interface is used to realize the active work for virtual crypto device. This patch only add the framework, doesn't include specific operations. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 07/47] virtio: introduce virtio_device_ioeventfd_enabled

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini This will be used to forbid iothread configuration when the proxy does not allow using ioeventfd. To simplify the implementation, change the direction of the ioeventfd_disabled callback too. Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 22/47] virtio-crypto: set capacity of algorithms supported

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei Expose the capacity of algorithms supported by virtio crypto device to the frontend driver using pci configuration space. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 10/47] Revert "virtio: Introduce virtio_add_queue_aio"

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini This reverts commit 872dd82c83745a603d2e07a03d34313eb6467ae4. virtio_add_queue_aio is unused. Reviewed-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 04/47] virtio: move ioeventfd_disabled flag to VirtioBusState

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini This simplifies the code and removes the ioeventfd_set_disabled callback. Reviewed-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini Reviewed-by: Michael S.

[Qemu-devel] [PULL 05/47] virtio: move ioeventfd_started flag to VirtioBusState

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini This simplifies the code and removes the ioeventfd_started and ioeventfd_set_started callback. The only difference is in how virtio-ccw handles an error---it doesn't disable ioeventfd forever anymore. It was the only backend to do so, and if desired

[Qemu-devel] [PULL 21/47] virtio-crypto-pci: add virtio crypto pci support

2016-10-30 Thread Michael S. Tsirkin
From: Gonglei This patch adds virtio-crypto-pci, which is the pci proxy for the virtio crypto device. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL 02/47] virtio/migration: Migrate balloon to VMState

2016-10-30 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Replace the load/save with a vmsd. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 31

[Qemu-devel] [PULL 09/47] virtio-scsi: always use dataplane path if ioeventfd is active

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini Override start_ioeventfd and stop_ioeventfd to start/stop the whole dataplane logic. This has some positive side effects: - no need anymore for virtio_add_queue_aio (i.e. a revert of commit 1c627137c10ee2dcf59e0383ade8a9abfa2d4355) - no need anymore

[Qemu-devel] [PULL 06/47] virtio: add start_ioeventfd and stop_ioeventfd to VirtioDeviceClass

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini Allow customization of the start and stop of ioeventfd. This will allow direct start of dataplane without passing through the default ioeventfd handlers, which in turn allows using the dataplane logic instead of virtio_add_queue_aio. It will also enable

[Qemu-devel] [PULL 03/47] virtio: disable ioeventfd as early as possible

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini Avoid "tricking" virtio-blk-dataplane into thinking that ioeventfd will be available when it is not. This bug has always been there, but it will break TCG+ioeventfd=on once the dataplane code will be always used when ioeventfd=on. Reviewed-by: Cornelia

[Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

2016-10-30 Thread Michael S. Tsirkin
The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' into staging (2016-10-28 17:59:04 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PULL 01/47] virtio/migration: Add VMStateDescription to VirtioDeviceClass

2016-10-30 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Provide a vmsd pointer for VirtIO devices to use instead of the load/save methods. We'll eventually kill off the load/save methods. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [Bug 1637693] Re: QEMU not able to create vm with pflash and UEFI bios

2016-10-30 Thread Zach
Seems to work when using virt-install to do a manual uefi install ** Project changed: qemu => virt-manager -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1637693 Title: QEMU not able to create vm

Re: [Qemu-devel] [PATCH v9 00/12] virtio-crypto: introduce framework and device emulation

2016-10-30 Thread Halil Pasic
On 10/20/2016 01:45 PM, Gonglei wrote: > The front-end linux kernel driver (Experimental at present) is publicly > accessible from: > >https://github.com/gongleiarei/virtio-crypto-linux-driver.git Hi! I'm very interested in making sure this work for the s390x architecture too. So to

Re: [Qemu-devel] [PATCH v3] vfio: Add support for mmapping sub-page MMIO BARs

2016-10-30 Thread Alex Williamson
On Wed, 26 Oct 2016 16:56:13 +0800 Yongji Xie wrote: > Now the kernel commit 05f0c03fbac1 ("vfio-pci: Allow to mmap > sub-page MMIO BARs if the mmio page is exclusive") allows VFIO > to mmap sub-page BARs. This is the corresponding QEMU patch. > With those patches

Re: [Qemu-devel] [RFC 17/17] pseries: Default to POWER8 compatibility mode

2016-10-30 Thread David Gibson
On Sun, Oct 30, 2016 at 10:12:08PM +1100, David Gibson wrote: > Currently, the pseries machine defaults to running in the "raw" mode of > whatever the CPU version is - that is, without any compatibility options > enabled in the CPU. > > However, migration is only really safe in "raw" mode if

Re: [Qemu-devel] [PATCH v4 00/10] Convert msix_init() to error

2016-10-30 Thread Michael S. Tsirkin
On Wed, Oct 19, 2016 at 02:47:35PM +0800, Cao jin wrote: > v4 changelog > 1. add the missed comment of "errp" in the msix_init's function comment > 2. fix typo: msic --> msix > 3. fix a build failure due to "copy" error, in patch >"megasas: change behaviour of msix switch" > 4. separate the

Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-10-30 Thread Michael S. Tsirkin
On Sat, Oct 22, 2016 at 07:00:41AM +, Rafael David Tinoco wrote: > Commit 31190ed7 added a migration blocker in vhost_dev_init() to > check if memfd would succeed. It is better if this blocker first > checks if vhost backend requires shared log. This will avoid a > situation where a blocker is

Re: [Qemu-devel] [PATCH v1] docs/vhost-user: extend the vhost-user protocol to support the vhost-pci based inter-vm communication

2016-10-30 Thread Michael S. Tsirkin
On Mon, Oct 24, 2016 at 03:10:02PM +0800, Wei Wang wrote: > Signed-off-by: Wei Wang As the implementation is not going to be merged for this QEMU release, I think we shouldn't drop the doc either. I'll review and respond a bit later so we can finalize the protocol

Re: [Qemu-devel] [PATCH] atapi: classify read_cd as conditionally returning data

2016-10-30 Thread Hervé Poussineau
Le 29/10/2016 à 00:32, John Snow a écrit : For the purposes of byte_count_limit verification, add a new flag that identifies read_cd as sometimes returning data, then check the BCL in its command handler after we know that it will indeed return data. Reported-by: Hervé Poussineau

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-30 Thread Greg Kurz
On Sun, 30 Oct 2016 15:02:17 +0100 Pradeep Jagadeesh wrote: > On 10/30/2016 2:35 PM, Greg Kurz wrote: [...] > > > > I'll be AFK most of tomorrow and soft freeze starts next Tuesday... do you > > *really* need this to be in 2.8 ? > > > If everything is OK, then we

[Qemu-devel] (no subject)

2016-10-30 Thread Pradeep Jagadeesh
Date: Sun, 30 Oct 2016 10:53:16 -0400 Subject: [PATCH V8] fsdev: add IO throttle support to fsdev devices Uses throttling APIs to limit I/O bandwidth and number of operations on the devices which use 9p-local driver. This adds the support for the 9p-local driver. For now this functionality can

Re: [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend

2016-10-30 Thread Samuel Thibault
Gerd Hoffmann, on Wed 26 Oct 2016 12:17:44 +0200, wrote: > > +/* All consoles share the same window */ > > No. That is the default setup, but try "View / Detach tab". Window ID > changing at runtime ... So we would need to make baum register for notification of Window ID change. It

[Qemu-devel] [PATCHv2 0/3] Move getting XWindow ID from baum driver to graphical backend

2016-10-30 Thread Samuel Thibault
Hello, This is a respin of moving getting XWindow ID from baum to actual graphical backends. This only contains the new API, the move of existing code to the new API, and the addition of support for SDL2. Gtk will need more discussion and work. Samuel Samuel Thibault (3): console: add API to

[Qemu-devel] [PATCH 2/3] console: move window ID code from baum to sdl

2016-10-30 Thread Samuel Thibault
This moves the SDL bits for window ID from the baum driver to SDL, as well as fixing the build for non-X11. Signed-off-by: Samuel Thibault --- backends/baum.c | 25 +++-- ui/sdl.c| 25 + 2 files changed, 28

[Qemu-devel] [PATCH 1/3] console: add API to get underlying gui window ID

2016-10-30 Thread Samuel Thibault
This adds two console functions, qemu_console_set_window_id and qemu_graphic_console_get_window_id, to let graphical backend record the window id in the QemuConsole structure, and let the baum driver read it. Signed-off-by: Samuel Thibault --- include/ui/console.h

[Qemu-devel] [PATCH 3/3] sdl2: set window ID

2016-10-30 Thread Samuel Thibault
This uses the console API to record the window ID of the SDL2 windows. Signed-off-by: Samuel Thibault --- ui/sdl2.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 30d2a3c..b464f16 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@

Re: [Qemu-devel] helper_compute_fprf() purpose

2016-10-30 Thread Peter Maydell
On 30 October 2016 at 01:43, Programmingkid wrote: > What is the purpose for the helper_compute_fprf() > function in target-ppc/fpu_helper.c? It updates the FPRF field in the FPSCR for those floating point instructions which are specified as updating it. thanks -- PMM

Re: [Qemu-devel] [PATCH 8/8] slirp: VMStatify remaining except for loop

2016-10-30 Thread Samuel Thibault
Hello, Dr. David Alan Gilbert (git), on Thu 27 Oct 2016 16:32:17 +0100, wrote: > This converts the remaining components, except for the loop, to VMState. > > +/* TODO: Add loop */ > +VMSTATE_UINT16_V(ip_id, Slirp, 2), > +VMSTATE_STRUCT_ARRAY(bootp_clients, Slirp,

Re: [Qemu-devel] [PATCH 7/8] slirp: VMStatify socket level

2016-10-30 Thread Samuel Thibault
Hello, Dr. David Alan Gilbert (git), on Thu 27 Oct 2016 16:32:16 +0100, wrote: > -case AF_INET: > -qemu_put_be32(f, so->so_faddr.s_addr); > -qemu_put_be16(f, so->so_fport); > -break; > +if (version_id >= 4 && !is_inet) { > +error_report("%s: so_ffamily

Re: [Qemu-devel] [PATCH 6/8] slirp: VMStatify sbuf

2016-10-30 Thread Samuel Thibault
Dr. David Alan Gilbert (git), on Thu 27 Oct 2016 16:32:15 +0100, wrote: > From: "Dr. David Alan Gilbert" > > Convert the sbuf structure to a VMStateDescription. > Note this uses the VMSTATE_WITH_TMP mechanism to calculate > and reload the offsets based on the pointers. > >

[Qemu-devel] [PATCH 1/2] iconv: detect and make curses depend on it

2016-10-30 Thread Samuel Thibault
curses will use it for proper wide output support. Signed-off-by: Samuel Thibault --- configure | 40 vl.c | 2 +- 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/configure b/configure index

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-30 Thread Pradeep Jagadeesh
On 10/30/2016 2:35 PM, Greg Kurz wrote: On Sun, 30 Oct 2016 14:04:49 +0100 Pradeep Jagadeesh wrote: More remarks below. fsdev/Makefile.objs | 1 + fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 76 +++

  1   2   >