[Qemu-devel] [PATCH] migration: fix missing assignment for has_x_checkpoint_delay

2016-10-31 Thread zhanghailiang
We forgot to assign true to params->has_x_checkpoint_delay parameter in qmp_query_migrate_parameters. Without this, qmp command 'query-migrate-parameters' doesn't show the default value for x-checkpoint-delay option. It doesn't influence output of hmp command 'info migrate_parameters'.

Re: [Qemu-devel] [PATCH v10 01/19] vfio: Mediated device Core driver

2016-10-31 Thread Jike Song
On 11/01/2016 11:44 AM, Alex Williamson wrote: > On Tue, 01 Nov 2016 11:08:15 +0800 > Jike Song wrote: >> On 10/27/2016 05:29 AM, Kirti Wankhede wrote: >>> +static int mdev_attach_iommu(struct mdev_device *mdev) >>> +{ >>> + int ret; >>> + struct iommu_group *group; >>> +

Re: [Qemu-devel] [PATCH v5 28/33] cputlb: make tlb_flush_by_mmuidx safe for MTTCG

2016-10-31 Thread Pranith Kumar
Hi Alex, Alex Bennée writes: > These flushes allow a per-mmuidx granularity to the TLB flushing and are > currently only used by the ARM model. As it is possible to hammer the > other vCPU threads with flushes (and build up long queues of identical > flushes) we extend mechanism used for the

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-31 Thread ashish mittal
>> >> +## >> >> +{ 'struct': 'BlockdevOptionsVxHS', >> >> + 'data': { 'vdisk_id': 'str', >> >> +'server': 'InetSocketAddress' } } >> > >> > Is there any way to use a Unix socket, or is this server ONLY accessible >> > over IPv4/IPv6? >> > >> >> Right now we support IPv4 only. > > IMHO

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-10-31 Thread David Gibson
On Mon, Oct 31, 2016 at 03:10:23PM +1100, Alexey Kardashevskiy wrote: > On 31/10/16 13:53, David Gibson wrote: > > On Fri, Oct 28, 2016 at 12:07:12PM +0200, Greg Kurz wrote: > >> On Fri, 28 Oct 2016 18:56:40 +1100 > >> Alexey Kardashevskiy wrote: > >> > >>> At the moment sPAPR PHB

Re: [Qemu-devel] [PATCH v10 10/19] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-10-31 Thread Dong Jia Shi
* Alex Williamson [2016-10-29 08:03:01 -0600]: > On Sat, 29 Oct 2016 16:07:05 +0530 > Kirti Wankhede wrote: > > > On 10/29/2016 2:03 AM, Alex Williamson wrote: > > > On Sat, 29 Oct 2016 01:32:35 +0530 > > > Kirti Wankhede

Re: [Qemu-devel] [PATCH v10 01/19] vfio: Mediated device Core driver

2016-10-31 Thread Alex Williamson
On Tue, 01 Nov 2016 11:08:15 +0800 Jike Song wrote: > On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > > +static int mdev_attach_iommu(struct mdev_device *mdev) > > +{ > > + int ret; > > + struct iommu_group *group; > > + > > + group = iommu_group_alloc(); > > + if

Re: [Qemu-devel] [PULL 03/18] migration: Enter into COLO mode after migration if COLO is enabled

2016-10-31 Thread Hailiang Zhang
On 2016/11/1 6:27, Eric Blake wrote: On 10/30/2016 05:46 AM, Amit Shah wrote: From: zhanghailiang Add a new migration state: MIGRATION_STATUS_COLO. Migration source side enters this state after the first live migration successfully finished if COLO is enabled

Re: [Qemu-devel] [PULL 37/47] nvdimm acpi: introduce fit buffer

2016-10-31 Thread Xiao Guangrong
On 10/31/2016 07:09 PM, Igor Mammedov wrote: On Mon, 31 Oct 2016 17:52:24 +0800 Xiao Guangrong wrote: On 10/31/2016 05:45 PM, Igor Mammedov wrote: On Sun, 30 Oct 2016 23:25:05 +0200 "Michael S. Tsirkin" wrote: From: Xiao Guangrong

[Qemu-devel] [PATCH] docs: fix COLO architecture diagram

2016-10-31 Thread Zhang Chen
Fix COLO-Proxy part of COLO architecture diagram Signed-off-by: Zhang Chen --- docs/COLO-FT.txt | 72 +--- 1 file changed, 37 insertions(+), 35 deletions(-) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index

Re: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data

2016-10-31 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data Message-id: 1477970211-25754-1-git-send-email-js...@redhat.com === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH v2 1/3] atapi: classify read_cd as conditionally returning data

2016-10-31 Thread John Snow
For the purposes of byte_count_limit verification, add a new flag that identifies read_cd as sometimes returning data, then check the BCL in its command handler after we know that it will indeed return data. Reported-by: Hervé Poussineau Signed-off-by: John Snow

[Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data

2016-10-31 Thread John Snow
v2: - Actually applied the changes this time ... - And added a test to the AHCI suite... - ...Which revealed a few small issues in the suite. The AHCI test should be sufficient in terms of general proof for ATAPI regardless of the HBA used.

[Qemu-devel] [PATCH v2 2/3] ahci-test: Create smaller test ISO images

2016-10-31 Thread John Snow
These can simply be the size of the number of sectors we're reading, plus one for a buffer. We don't need them to be any larger. Signed-off-by: John Snow --- tests/ahci-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ahci-test.c

[Qemu-devel] [PATCH v2 3/3] ahci-test: test atapi read_cd with bcl, nb_sectors = 0

2016-10-31 Thread John Snow
Commit 9ef2e93f introduced the concept of tagging ATAPI commands as NONDATA, but this introduced a regression for certain commands better described as CONDDATA. read_cd is such a command that both requires a non-zero BCL if a transfer size is set, but is perfectly content to accept a zero BCL if

Re: [Qemu-devel] [PATCH v10 01/19] vfio: Mediated device Core driver

2016-10-31 Thread Jike Song
On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > Design for Mediated Device Driver: > Main purpose of this driver is to provide a common interface for mediated > device management that can be used by different drivers of different > devices. > > This module provides a generic interface to create

[Qemu-devel] [PATCH 1/1] net: skip virtio-net config of deleted nic's peers

2016-10-31 Thread yuri . benditovich
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1373816 qemu core dump happens during repetitive unpug-plug with multiple queues and Windows RSS-capable guest. If back-end delete requested during virtio-net device initialization, driver still can

Re: [Qemu-devel] [Qemu-stable] [Qemu-ppc] [PULL 0/4] ppc patches for qemu-2.7 stable branch

2016-10-31 Thread David Gibson
On Tue, Oct 25, 2016 at 06:57:33PM -0500, Michael Roth wrote: > Quoting David Gibson (2016-10-24 20:41:29) > > On Mon, Oct 17, 2016 at 04:24:31PM -0500, Michael Roth wrote: > > > Quoting Peter Maydell (2016-10-17 13:45:21) > > > > On 17 October 2016 at 19:13, Michael Roth

Re: [Qemu-devel] [V2,1/7] nios2: Add disas entries

2016-10-31 Thread Marek Vasut
On 10/31/2016 10:27 PM, Romain Naour wrote: > Hi Marek, all, Hi, > Le 18/10/2016 à 06:17, Marek Vasut a écrit : >> On 10/15/2016 03:15 PM, Romain Naour wrote: >>> Hi Marek, >> >> Hi! >> >>> Le 28/09/2016 à 01:30, Marek Vasut a écrit : Add nios2 disassembler support. This patch is composed

Re: [Qemu-devel] [PULL 10/18] COLO: Add checkpoint-delay parameter for migrate-set-parameters

2016-10-31 Thread Hailiang Zhang
On 2016/11/1 1:17, Juan Quintela wrote: Amit Shah wrote: From: zhanghailiang Add checkpoint-delay parameter for migrate-set-parameters, so that we can control the checkpoint frequency when COLO is in periodic mode. @@ -587,6 +593,7 @@

Re: [Qemu-devel] [PATCH 13/14] raw-posix: Implement image locking

2016-10-31 Thread Fam Zheng
On Mon, 10/31 17:01, Eric Blake wrote: > On 10/31/2016 10:38 AM, Fam Zheng wrote: > > This implements open flag sensible image locking for local file > > and host device protocol. > > > > virtlockd in libvirt locks the first byte, so we start looking at the > > file bytes from 1. > > What

Re: [Qemu-devel] [PULL 06/18] COLO: Introduce checkpointing protocol

2016-10-31 Thread Hailiang Zhang
On 2016/11/1 2:25, Eduardo Habkost wrote: On Sun, Oct 30, 2016 at 04:16:58PM +0530, Amit Shah wrote: [...] +static void colo_wait_handle_message(QEMUFile *f, int *checkpoint_request, + Error **errp) +{ +COLOMessage msg; +Error *local_err = NULL; + +

Re: [Qemu-devel] [PATCH 1/1] migration: fix compiler warning on uninitialized variable

2016-10-31 Thread Hailiang Zhang
On 2016/11/1 5:50, Jeff Cody wrote: Some older GCC versions (e.g. 4.4.7) report a warning on an uninitialized variable for 'request', even though all possible code paths that reference 'request' will be initialized. To appease these versions, initialize the variable to 0. Thanks for

[Qemu-devel] [PULL for-2.8 1/5] qga: minimal support for fstrim for Windows guests

2016-10-31 Thread Michael Roth
From: "Denis V. Lunev" Unfortunately, there is no public Windows API to start trimming the filesystem. The only viable way here is to call 'defrag.exe /L' for each volume. This is working since Win8 and Win2k12. Signed-off-by: Denis V. Lunev Signed-off-by:

[Qemu-devel] [PULL for-2.8 5/5] qga: add vsock-listen method

2016-10-31 Thread Michael Roth
From: Stefan Hajnoczi Add AF_VSOCK (virtio-vsock) support as an alternative to virtio-serial. $ qemu-system-x86_64 -device vhost-vsock-pci,guest-cid=3 ... (guest)# qemu-ga -m vsock-listen -p 3:1234 Signed-off-by: Stefan Hajnoczi Reviewed-by:

[Qemu-devel] [PULL for-2.8 2/5] qga: drop unused sockaddr in accept(2) call

2016-10-31 Thread Michael Roth
From: Stefan Hajnoczi ga_channel_listen_accept() is currently hard-coded to support only AF_UNIX because the struct sockaddr_un type is used. This function should work with any address family. Drop the sockaddr since the client address is unused and is an optional argument

[Qemu-devel] [PULL for-2.8 4/5] sockets: add AF_VSOCK support

2016-10-31 Thread Michael Roth
From: Stefan Hajnoczi Add the AF_VSOCK address family so that qemu-ga will be able to use virtio-vsock. The AF_VSOCK address family uses address tuples. The cid is the unique identifier comparable to an IP address. AF_VSOCK does not use name resolution so it's

[Qemu-devel] [PULL for-2.8 0/5] qemu-ga patch queue for 2.8

2016-10-31 Thread Michael Roth
The following changes since commit e80b4b8fb6babce7dcc91ea9ddeecbc351fd4646: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20161031.0' into staging (2016-10-31 18:19:06 +) are available in the git repository at: git://github.com/mdroth/qemu.git

[Qemu-devel] [PULL for-2.8 3/5] qga: drop unnecessary GA_CHANNEL_UNIX_LISTEN checks

2016-10-31 Thread Michael Roth
From: Stefan Hajnoczi Throughout the code there are c->listen_channel checks which manage the listen socket file descriptor (waiting for accept(2), closing the file descriptor, etc). These checks are currently preceded by explicit c->method == GA_CHANNEL_UNIX_LISTEN checks.

Re: [Qemu-devel] [PATCH v2 3/4] sockets: add AF_VSOCK support

2016-10-31 Thread Michael Roth
Quoting Michael Roth (2016-10-25 18:51:19) > Quoting Stefan Hajnoczi (2016-10-14 04:00:55) > > Add the AF_VSOCK address family so that qemu-ga will be able to use > > virtio-vsock. > > > > The AF_VSOCK address family uses address tuples. The cid is > > the unique identifier

Re: [Qemu-devel] [PATCH v3 3/4] target-ppc: Implement bcdcfz. instruction

2016-10-31 Thread David Gibson
On Mon, Oct 31, 2016 at 03:34:48PM -0200, Jose Ricardo Ziviani wrote: > bcdcfz. converts from Zoned numeric format to BCD. Zoned format uses > a byte to represent a digit where the most significant nibble is 0x3 > or 0xf, depending on the preferred signal. > > Signed-off-by: Jose Ricardo Ziviani

Re: [Qemu-devel] [PATCH v3 1/4] target-ppc: Implement bcdcfn. instruction

2016-10-31 Thread David Gibson
On Mon, Oct 31, 2016 at 03:34:46PM -0200, Jose Ricardo Ziviani wrote: > bcdcfn. converts from National numeric format to BCD. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 2/4] target-ppc: Implement bcdctn. instruction

2016-10-31 Thread David Gibson
On Mon, Oct 31, 2016 at 03:34:47PM -0200, Jose Ricardo Ziviani wrote: > bcdctn. converts from BCD to National numeric format. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. > > Signed-off-by:

[Qemu-devel] [PATCH v3 2/2] target-m68k: add 680x0 divu/divs variants

2016-10-31 Thread Laurent Vivier
Update helper to set the throwing location in case of div-by-0. Cleanup divX.w and add quad word variants of divX.l. Signed-off-by: Laurent Vivier --- linux-user/main.c | 7 ++ target-m68k/cpu.h | 4 -- target-m68k/helper.h| 8 ++-

[Qemu-devel] [PATCH v3 1/2] target-m68k: add 64bit mull

2016-10-31 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 62 +++-- 1 file changed, 50 insertions(+), 12 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index c00978d..93e201c 100644 ---

[Qemu-devel] [PATCH v3 0/2] 680x0 mul and div instructions

2016-10-31 Thread Laurent Vivier
This series is another subset of the series I sent in May: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00501.html It must be applied on top of series: "target-m68k: 680x0 instruction set, part 2" This subset contains reworked patches of mul and div instructions: - "add 64bit mull":

[Qemu-devel] AppleSMC location

2016-10-31 Thread Greg Hazel
Hi, An OS X guest (which works on q35) hangs during boot on i440fx. This error appears on the console: “SMC::smcInitEventSources ERROR: failed to create fInterruptSource” This used to work in QEMU 2.2, but broke in 2.3. I narrowed it down to this commit:

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

2016-10-31 Thread Michael S. Tsirkin
On Mon, Oct 31, 2016 at 10:50:31AM +0100, Igor Mammedov wrote: > On Sun, 30 Oct 2016 23:23:18 +0200 > "Michael S. Tsirkin" wrote: > > > The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: > > > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH 1/1] net: skip virtio-net config of deleted nic's peers

2016-10-31 Thread Michael S. Tsirkin
On Tue, Nov 01, 2016 at 12:01:17AM +0200, yuri.benditov...@daynix.com wrote: > From: Yuri Benditovich > > https://bugzilla.redhat.com/show_bug.cgi?id=1373816 > qemu core dump happens during repetitive unpug-plug > with multiple queues and Windows RSS-capable guest. >

Re: [Qemu-devel] [PATCH 13/14] raw-posix: Implement image locking

2016-10-31 Thread Richard W.M. Jones
On Mon, Oct 31, 2016 at 05:01:44PM -0500, Eric Blake wrote: > On 10/31/2016 10:38 AM, Fam Zheng wrote: > > This implements open flag sensible image locking for local file > > and host device protocol. > > > > virtlockd in libvirt locks the first byte, so we start looking at the > > file bytes

Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-10-31 Thread Michael S. Tsirkin
On Mon, Oct 31, 2016 at 08:35:33AM -0200, Rafael David Tinoco wrote: > On Sun, Oct 30, 2016 at 5:26 PM, Michael S. Tsirkin wrote: > > > > On Sat, Oct 22, 2016 at 07:00:41AM +, Rafael David Tinoco wrote: > > > Commit 31190ed7 added a migration blocker in vhost_dev_init() to >

Re: [Qemu-devel] [PULL 03/18] migration: Enter into COLO mode after migration if COLO is enabled

2016-10-31 Thread Eric Blake
On 10/30/2016 05:46 AM, Amit Shah wrote: > From: zhanghailiang > > Add a new migration state: MIGRATION_STATUS_COLO. Migration source side > enters this state after the first live migration successfully finished > if COLO is enabled by command

Re: [Qemu-devel] [PULL 08/27] hostmem-file: make option 'size' optional

2016-10-31 Thread Eduardo Habkost
On Mon, Oct 31, 2016 at 03:47:53PM -0400, Paolo Bonzini wrote: > > > - Original Message - > > From: "Eduardo Habkost" > > To: "Paolo Bonzini" > > Cc: qemu-devel@nongnu.org, "Haozhong Zhang" > > Sent: Monday, October

Re: [Qemu-devel] [PATCH 13/14] raw-posix: Implement image locking

2016-10-31 Thread Eric Blake
On 10/31/2016 10:38 AM, Fam Zheng wrote: > This implements open flag sensible image locking for local file > and host device protocol. > > virtlockd in libvirt locks the first byte, so we start looking at the > file bytes from 1. What happens if we try to use a raw file with less than 3 bytes?

Re: [Qemu-devel] [PATCH 00/15] optimize Qemu RSS usage

2016-10-31 Thread Michael R. Hines
On 10/18/2016 05:47 AM, Peter Lieven wrote: Am 12.10.2016 um 23:18 schrieb Michael R. Hines: Peter, Greetings from DigitalOcean. We're experiencing the same symptoms without this patch. We have, collectively, many gigabytes of un-planned-for RSS being used per-hypervisor that we would like

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

2016-10-31 Thread Jeff Cody
On Fri, Oct 28, 2016 at 11:47:11PM -0700, Ashish Mittal wrote: > Source code for the qnio library that this code loads can be downloaded from: > https://github.com/MittalAshish/libqnio.git > > Sample command line using the JSON syntax: > ./qemu-system-x86_64 -name instance-0008 -S -vnc

Re: [Qemu-devel] git master build failure (migration/colo.c)

2016-10-31 Thread Jeff Cody
On Mon, Oct 31, 2016 at 08:08:46PM +, Mark Cave-Ayland wrote: > I've just done a git pull and get the following build error here: > > cc -I/home/build/src/qemu/git/qemu/tcg > -I/home/build/src/qemu/git/qemu/tcg/i386 > -I/home/build/src/qemu/git/qemu/linux-headers >

[Qemu-devel] [PATCH 1/1] migration: fix compiler warning on uninitialized variable

2016-10-31 Thread Jeff Cody
Some older GCC versions (e.g. 4.4.7) report a warning on an uninitialized variable for 'request', even though all possible code paths that reference 'request' will be initialized. To appease these versions, initialize the variable to 0. Reported-by: Mark Cave-Ayland

Re: [Qemu-devel] [V2,1/7] nios2: Add disas entries

2016-10-31 Thread Romain Naour
Hi Marek, all, Le 18/10/2016 à 06:17, Marek Vasut a écrit : > On 10/15/2016 03:15 PM, Romain Naour wrote: >> Hi Marek, > > Hi! > >> Le 28/09/2016 à 01:30, Marek Vasut a écrit : >>> Add nios2 disassembler support. This patch is composed from binutils files >>> from commit "Opcodes and assembler

[Qemu-devel] [PULL v2 for-2.8 09/15] target-sparc: Implement BCOPY/BFILL inline

2016-10-31 Thread Richard Henderson
Tested-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target-sparc/translate.c | 63 1 file changed, 63 insertions(+) diff --git a/target-sparc/translate.c b/target-sparc/translate.c

[Qemu-devel] [PULL v2 for-2.8 00/15] target-sparc updates

2016-10-31 Thread Richard Henderson
-10-31 11:12:02 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-sparc-20161031-2 for you to fetch changes up to 5a7267b6a9e94c264ca77a7ca5a239e70dac81da: target-sparc: Use tcg_gen_atomic_cmpxchg_tl (2016-10-31 14:46:48 -0600

Re: [Qemu-devel] [v2] nvic: set pending status for not active interrupts

2016-10-31 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Monday, October 31, 2016 11:15 AM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw) > > Cc: QEMU Developers ; qemu-arm a...@nongnu.org>;

[Qemu-devel] [PULL] Update OpenBIOS images

2016-10-31 Thread Mark Cave-Ayland
Hi Peter, Here are the OpenBIOS updates for the 2.8 release. Please pull. ATB, Mark. The following changes since commit e80b4b8fb6babce7dcc91ea9ddeecbc351fd4646: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20161031.0' into staging (2016-10-31 18:19:06 +) are

Re: [Qemu-devel] [PATCH] net: split colo_compare_pkt_info into two trace events

2016-10-31 Thread Eric Blake
On 10/31/2016 06:42 AM, Alex Bennée wrote: > > Zhang Chen writes: >> It looks good for me, but it not the root cause of this bug. >> We better fix this in UST trace event codes > > I didn't get a chance to dig into the details but yes we need to confirm > if

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

2016-10-31 Thread ashish mittal
Thanks! Will fix these in the next patch! On Mon, Oct 31, 2016 at 12:05 PM, Eric Blake wrote: > On 10/29/2016 01:47 AM, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/MittalAshish/libqnio.git > > For

[Qemu-devel] git master build failure (migration/colo.c)

2016-10-31 Thread Mark Cave-Ayland
I've just done a git pull and get the following build error here: cc -I/home/build/src/qemu/git/qemu/tcg -I/home/build/src/qemu/git/qemu/tcg/i386 -I/home/build/src/qemu/git/qemu/linux-headers -I/home/build/src/qemu/git/qemu/linux-headers -I. -I/home/build/src/qemu/git/qemu

[Qemu-devel] [QEMU PATCH v10 1/3] migration: extend VMStateInfo

2016-10-31 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 6 ++-

[Qemu-devel] [QEMU PATCH v10 3/3] tests/migration: Add test for QTAILQ migration

2016-10-31 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index

[Qemu-devel] [QEMU PATCH v10 0/3] migration: migrate QTAILQ

2016-10-31 Thread Jianjun Duan
Hi all, I addressed some review comments. Comments are welcome. v10: - Fixed a typo. Previous versions are: v9: - No more hard encoding of QTAILQ layout information (link: http://lists.nongnu.org/archive/html/qemu-ppc/2016-10/msg01042.html) v8: - Fixed a style issue. (link:

[Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ

2016-10-31 Thread Jianjun Duan
Currently we cannot directly transfer a QTAILQ instance because of the limitation in the migration code. Here we introduce an approach to transfer such structures. We created VMStateInfo vmstate_info_qtailq for QTAILQ. Similar VMStateInfo can be created for other data structures such as list.

Re: [Qemu-devel] [PULL 08/27] hostmem-file: make option 'size' optional

2016-10-31 Thread Paolo Bonzini
- Original Message - > From: "Eduardo Habkost" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "Haozhong Zhang" > Sent: Monday, October 31, 2016 7:20:10 PM > Subject: Re: [Qemu-devel] [PULL 08/27] hostmem-file:

[Qemu-devel] [Bug 1230232] Re: mac99 does not find mac os x 10.4 dvd

2016-10-31 Thread Mark Cave-Ayland
I've set this to "Fix released" since this bug was fixed with the last set of macio rewrites which were released with QEMU 2.6, although both 2.7 and the upcoming 2.8 release include further fixes in this area. ** Changed in: qemu Status: New => Fix Released -- You received this bug

[Qemu-devel] [PULL 13/14] blockjobs: split interface into public/private, Part 1

2016-10-31 Thread Jeff Cody
From: John Snow To make it a little more obvious which functions are intended to be public interface and which are intended to be for use only by jobs themselves, split the interface into "public" and "private" files. Convert blockjobs (e.g. block/backup) to using the private

[Qemu-devel] [PULL 14/14] blockjobs: fix documentation

2016-10-31 Thread Jeff Cody
From: John Snow (Trivial) Fix wrong function names in documentation. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Reviewed-by: Jeff Cody Message-id: 1477584421-1399-8-git-send-email-js...@redhat.com Signed-off-by:

[Qemu-devel] [PULL 12/14] Blockjobs: Internalize user_pause logic

2016-10-31 Thread Jeff Cody
From: John Snow BlockJobs will begin hiding their state in preparation for some refactorings anyway, so let's internalize the user_pause mechanism instead of leaving it to callers to correctly manage. Signed-off-by: John Snow Reviewed-by: Kevin Wolf

[Qemu-devel] [PULL 11/14] blockjob: centralize QMP event emissions

2016-10-31 Thread Jeff Cody
From: John Snow There's no reason to leave this to blockdev; we can do it in blockjobs directly and get rid of an extra callback for most users. All non-internal events, even those created outside of QMP, will consistently emit events. Signed-off-by: John Snow

[Qemu-devel] [PULL 10/14] Replication/Blockjobs: Create replication jobs as internal

2016-10-31 Thread Jeff Cody
From: John Snow Bubble up the internal interface to commit and backup jobs, then switch replication tasks over to using this methodology. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Reviewed-by: Jeff Cody

[Qemu-devel] [PULL 06/14] block/gluster: improve defense over string to int conversion

2016-10-31 Thread Jeff Cody
From: Prasanna Kumar Kalever using atoi() for converting string to int may be error prone in case if string supplied in the argument is not a fold of numerical number, This is not a bug because in the existing code, static QemuOptsList runtime_tcp_opts = {

[Qemu-devel] [PULL 09/14] blockjobs: Allow creating internal jobs

2016-10-31 Thread Jeff Cody
From: John Snow Add the ability to create jobs without an ID. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Reviewed-by: Jeff Cody Message-id: 1477584421-1399-3-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody

[Qemu-devel] [PULL 08/14] blockjobs: hide internal jobs from management API

2016-10-31 Thread Jeff Cody
From: John Snow If jobs are not created directly by the user, do not allow them to be seen by the user/management utility. At the moment, 'internal' jobs are those that do not have an ID. As of this patch it is impossible to create such jobs. Signed-off-by: John Snow

[Qemu-devel] [PULL 03/14] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support

2016-10-31 Thread Jeff Cody
Add checks to see if the system compiling QEMU has support for SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek data is unsupported in gluster. Note: this is not a check on whether the gluster server itself supports SEEK_DATA (that is already done during runtime), but rather

[Qemu-devel] [PULL 04/14] block/gluster: memory usage: use one glfs instance per volume

2016-10-31 Thread Jeff Cody
From: Prasanna Kumar Kalever Currently, for every drive accessed via gfapi we create a new glfs instance (call glfs_new() followed by glfs_init()) which could consume memory in few 100 MB's, from the table below it looks like for each instance ~300 MB VSZ was

[Qemu-devel] [PULL 05/14] block: Turn on "unmap" in active commit

2016-10-31 Thread Jeff Cody
From: Fam Zheng We already specified BDRV_O_UNMAP when opening images in 'qemu-img commit', but didn't turn on the "unmap" in the active commit job. This patch fixes that so that zeroed clusters in top image can be discarded which is desired in the virt-sparsify use case, where

[Qemu-devel] [PULL 02/14] rbd: make the code more readable

2016-10-31 Thread Jeff Cody
From: Xiubo Li Make it a bit clearer and more readable. Signed-off-by: Xiubo Li Reviewed-by: Stefan Hajnoczi Reviewed-by: John Snow Reviewed-by: Jeff Cody Message-id:

[Qemu-devel] [PULL 01/14] qapi: add release designator to gluster logfile option

2016-10-31 Thread Jeff Cody
The "logfile" option to BlockdevOptionsGluster will not be in QEMU until 2.8. Update comment to indicate this. Reported-by: Eric Blake Signed-off-by: Jeff Cody --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 00/14] Block patches for 2.8

2016-10-31 Thread Jeff Cody
The following changes since commit 6bc56d317f7b5004ea2d89d264bddc8b4d081700: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-mttcg' into staging (2016-10-31 15:29:12 +) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git

[Qemu-devel] [PULL 07/14] block/gluster: fix port type in the QAPI options list

2016-10-31 Thread Jeff Cody
From: Prasanna Kumar Kalever After introduction of qapi schema in gluster block driver code, the port type is now string as per InetSocketAddress { 'struct': 'InetSocketAddress', 'data': { 'host': 'str', 'port': 'str', '*to': 'uint16', '*ipv4':

Re: [Qemu-devel] [PATCH 1/2] target-m68k: add 64bit mull

2016-10-31 Thread Richard Henderson
On 10/29/2016 02:36 AM, Laurent Vivier wrote: Le 29/10/2016 à 01:25, Richard Henderson a écrit : On 10/28/2016 03:39 PM, Laurent Vivier wrote: +tcg_gen_movi_i32(QREG_CC_V, 0); +tcg_gen_mov_i32(QREG_CC_C, QREG_CC_V); movi CC, 0 Just to know, could you explain why it is

Re: [Qemu-devel] [PULL 0/5] VFIO updates 2016-10-31

2016-10-31 Thread Peter Maydell
On 31 October 2016 at 17:37, Alex Williamson <alex.william...@redhat.com> wrote: > The following changes since commit 0bb1137930f51a89fb1bfeb0c46aa68af0395167: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20161031' into > staging (2016-10-31 14:48:47 +)

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

2016-10-31 Thread Eric Blake
On 10/29/2016 01:47 AM, Ashish Mittal wrote: > Source code for the qnio library that this code loads can be downloaded from: > https://github.com/MittalAshish/libqnio.git For now, just an interface review: > > Sample command line using the JSON syntax: > ./qemu-system-x86_64 -name

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v9 2/3] migration: migrate QTAILQ

2016-10-31 Thread Halil Pasic
On 10/31/2016 07:25 PM, Jianjun Duan wrote: > > > On 10/31/2016 11:01 AM, Halil Pasic wrote: >> >> >> On 10/31/2016 06:32 PM, Jianjun Duan wrote: >> I think this got overly complicated. Here is a little patch on >>> top of your stuff which gets rid of 15 lines and IMHO simplifies

Re: [Qemu-devel] [PATCH] 9pfs: drop abusive error message from virtfs_reset()

2016-10-31 Thread Eric Blake
On 10/28/2016 05:26 PM, Greg Kurz wrote: > The virtfs_reset() function is called either when the virtio-9p device > gets reset, or when the client starts a new 9P session. In both cases, > if it finds fids from a previous session, the following is printed in > the monitor: > > 9pfs:virtfs_reset:

Re: [Qemu-devel] [PATCH] block/nbd: Fix the regression to free leaked visitor

2016-10-31 Thread Eric Blake
On 10/31/2016 12:51 PM, Ashijeet Acharya wrote: > This patch frees the leaked visitor in nbd_refresh_filename() and uses > visit_free() to fix it. > > Signed-off-by: Ashijeet Acharya > --- > block/nbd.c | 1 + > 1 file changed, 1 insertion(+) Would be nice to mention

[Qemu-devel] [PULL 2/2] target-i386: Print warning when mixing [+-]foo and foo=(on|off)

2016-10-31 Thread Eduardo Habkost
Print a warning when mixing [+-]foo and foo=(on|off) in the -cpu argument in a way that will break in the future. Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 24

Re: [Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-31 Thread Rakesh Ranjan
Hi Jeff, Thanks for your very useful information! We will take a look at it to do the needful. -Rakesh On 10/28/16, 2:50 PM, "Jeff Cody" wrote: >On Fri, Oct 28, 2016 at 01:26:41AM +, Rakesh Ranjan wrote: >> Hi Jeff et al, >> >> Thanks a lot for your due diligence to

[Qemu-devel] [PULL 1/2] tests: Remove unneeded "-vnc none" option

2016-10-31 Thread Eduardo Habkost
Some tests use the "-vnc none" option without any clear reason, making those tests break when --disable-vnc is specified on ./configure. Remove the unnecessary option. Reviewed-by: John Snow Tested-by: Corey Minyard Reviewed-by: Michael S. Tsirkin

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v9 2/3] migration: migrate QTAILQ

2016-10-31 Thread Jianjun Duan
On 10/31/2016 11:01 AM, Halil Pasic wrote: > > > On 10/31/2016 06:32 PM, Jianjun Duan wrote: > I think this got overly complicated. Here is a little patch on >> top of your stuff which gets rid of 15 lines and IMHO simplifies >> things quite a bit. What do you think?

Re: [Qemu-devel] [PATCH Risu 0/3] Risu support for PPC64LE

2016-10-31 Thread joserz
On Mon, Oct 31, 2016 at 02:45:24PM +, Peter Maydell wrote: > On 28 October 2016 at 18:46, Jose Ricardo Ziviani > wrote: > > From: Jose Ricardo Ziviani > > > > This is an initial effort to have RISU working for PPC64LE. > > > > I also made some

Re: [Qemu-devel] [PULL 00/29] Block layer patches

2016-10-31 Thread Peter Maydell
On 31 October 2016 at 17:25, Kevin Wolf <kw...@redhat.com> wrote: > The following changes since commit 0bb1137930f51a89fb1bfeb0c46aa68af0395167: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20161031' into > staging (2016-10-31 14:48:47 +) > >

Re: [Qemu-devel] [PULL 22/27] nbd: Improve server handling of shutdown requests

2016-10-31 Thread Eric Blake
On 10/31/2016 09:37 AM, Paolo Bonzini wrote: > From: Eric Blake > > NBD commit 6d34500b clarified how clients and servers are supposed > to behave before closing a connection. It added NBD_REP_ERR_SHUTDOWN > (for the server to announce it is about to go away during option >

Re: [Qemu-devel] [PULL for-2.8 00/15] target-sparc updates

2016-10-31 Thread Richard Henderson
On 10/31/2016 11:18 AM, Peter Maydell wrote: Looks like your variable name clashes with a #define in the windows headers :-( Oh good grief. Ok, I'll change the name, or something. That's horrible though. r~

[Qemu-devel] [PULL 0/2] x86 and machine queue, 2016-10-31

2016-10-31 Thread Eduardo Habkost
The following changes since commit 6bc56d317f7b5004ea2d89d264bddc8b4d081700: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-mttcg' into staging (2016-10-31 15:29:12 +) are available in the git repository at: git://github.com/ehabkost/qemu.git

Re: [Qemu-devel] [PATCH v2 3/3] hostmem-file: make option 'size' optional

2016-10-31 Thread Eduardo Habkost
On Fri, Oct 28, 2016 at 10:06:40AM +0800, Haozhong Zhang wrote: [...] > > > diff --git a/exec.c b/exec.c > > > index 264a25f..89065bd 100644 > > > --- a/exec.c > > > +++ b/exec.c > > > @@ -1234,7 +1234,7 @@ static int64_t get_file_size(int fd) > > > } > > > > > > static void

Re: [Qemu-devel] [PATCH v2] x86/cpuid:add AVX512_4VNNIW and AVX512_4FMAPS features.

2016-10-31 Thread Paolo Bonzini
On 31/10/2016 18:20, Eduardo Habkost wrote: > On Mon, Oct 31, 2016 at 04:27:26PM +0800, He Chen wrote: >> From: Luwei Kang >> >> The spec can be found in Intel Software Developer Manual or in >> Instruction Set Extensions Programming Reference. >> >> Signed-off-by: Luwei

Re: [Qemu-devel] [PULL 06/18] COLO: Introduce checkpointing protocol

2016-10-31 Thread Eduardo Habkost
On Sun, Oct 30, 2016 at 04:16:58PM +0530, Amit Shah wrote: [...] > +static void colo_wait_handle_message(QEMUFile *f, int *checkpoint_request, > + Error **errp) > +{ > +COLOMessage msg; > +Error *local_err = NULL; > + > +msg = colo_receive_message(f,

Re: [Qemu-devel] [PATCH v2 2/3] exec.c: check memory backend file size with 'size' option

2016-10-31 Thread Paolo Bonzini
On 31/10/2016 18:23, Eduardo Habkost wrote: > On Thu, Oct 27, 2016 at 12:22:59PM +0800, Haozhong Zhang wrote: >> If the memory backend file is not large enough to hold the required 'size', >> Qemu will report error and exit. >> >> Signed-off-by: Haozhong Zhang > >

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v9 2/3] migration: migrate QTAILQ

2016-10-31 Thread Halil Pasic
On 10/31/2016 06:32 PM, Jianjun Duan wrote: I think this got overly complicated. Here is a little patch on > top of your stuff which gets rid of 15 lines and IMHO simplifies > things quite a bit. What do you think? > > It is based on/inspired by Dave's

[Qemu-devel] [PULL 3/5] vfio: Handle zero-length sparse mmap ranges

2016-10-31 Thread Alex Williamson
As reported in the link below, user has a PCI device with a 4KB BAR which contains the MSI-X table. This seems to hit a corner case in the kernel where the region reports being mmap capable, but the sparse mmap information reports a zero sized range. It's not entirely clear that the kernel is

Re: [Qemu-devel] [PULL 08/27] hostmem-file: make option 'size' optional

2016-10-31 Thread Eduardo Habkost
On Mon, Oct 31, 2016 at 03:37:24PM +0100, Paolo Bonzini wrote: [...] > @@ -1309,21 +1317,27 @@ static void *file_ram_alloc(RAMBlock *block, > > file_size = get_file_size(fd); > > -if (memory < block->page_size) { > +if (!mem_size && file_size > 0) { > +mem_size =

[Qemu-devel] [PATCH] block/nbd: Fix the regression to free leaked visitor

2016-10-31 Thread Ashijeet Acharya
This patch frees the leaked visitor in nbd_refresh_filename() and uses visit_free() to fix it. Signed-off-by: Ashijeet Acharya --- block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nbd.c b/block/nbd.c index 8ef1438..ff9d01a 100644 --- a/block/nbd.c

  1   2   3   4   5   >