Re: [Qemu-devel] [PATCH v1 2/2] xlnx-ep108: Connect the AXI GPIO device

2016-11-11 Thread Edgar E. Iglesias
On Fri, Nov 11, 2016 at 03:42:31PM -0800, Alistair Francis wrote: > Connect the new Xilinx AXI GPIO devices based on the defaults used in > the ZCU102 reference board design. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Alistair Francis > --- > > hw/arm/xlnx-ep108.c | 26 ++

Re: [Qemu-devel] [PATCH v1 1/1] generic-loader: file: Only set a PC if a CPU is specified

2016-11-11 Thread Edgar E. Iglesias
On Fri, Nov 11, 2016 at 06:51:20PM -0800, Alistair Francis wrote: > This patch fixes the generic-loader file loading to only set the program > counter if a CPU is specified. This follows what is written in the > documentation and was always part of the original intention. Reviewed-by: Edgar E. Igl

[Qemu-devel] [PATCH v1 1/1] generic-loader: file: Only set a PC if a CPU is specified

2016-11-11 Thread Alistair Francis
This patch fixes the generic-loader file loading to only set the program counter if a CPU is specified. This follows what is written in the documentation and was always part of the original intention. Signed-off-by: Alistair Francis --- hw/core/generic-loader.c | 7 ++- 1 file changed, 6 in

Re: [Qemu-devel] TCP performance problems - GSO/TSO, MSS, 8139cp related

2016-11-11 Thread David Miller
From: Russell King - ARM Linux Date: Fri, 11 Nov 2016 22:33:08 + > "The new buffer management algorithm provides capabilities of Microsoft > Large-Send offload" and as yet I haven't found anything that describes > what this is or how it works. For once I will give Microsoft a big shout out h

Re: [Qemu-devel] TCP performance problems - GSO/TSO, MSS, 8139cp related

2016-11-11 Thread Russell King - ARM Linux
On Fri, Nov 11, 2016 at 09:23:43PM +, David Woodhouse wrote: > On Fri, 2016-11-11 at 21:05 +, Russell King - ARM Linux wrote: > > > > 18:59:38.782818 IP (tos 0x0, ttl 52, id 35619, offset 0, flags [DF], proto > > TCP (6), length 60) > >     84.xx.xxx.196.61236 > 195.92.253.2.http: Flags [

Re: [Qemu-devel] TCP performance problems - GSO/TSO, MSS, 8139cp related

2016-11-11 Thread Russell King - ARM Linux
On Fri, Nov 11, 2016 at 09:23:43PM +, David Woodhouse wrote: > It's also *fairly* unlikely that the kernel in the guest has developed > a bug and isn't setting gso_size sanely. I'm more inclined to suspect > that qemu isn't properly emulating those bits. But at first glance at > the code, it lo

Re: [Qemu-devel] [PULL 22/55] q35: ioapic: add support for emulated IOAPIC IR

2016-11-11 Thread Emilio G. Cota
On Fri, Nov 11, 2016 at 18:17:05 -0500, Peter Xu wrote: > > This commit (which sits between 2.6 and 2.7) doesn't let me boot a > > buildroot-generated x86_64 image when QEMU is configured with > > --with-coroutine=gthread (it deadlocks on the BQL shortly after > > the framebuffer comes up.) > > >

Re: [Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY and ULPI viewport from xilinx/qemu

2016-11-11 Thread Alistair Francis
On Mon, Apr 4, 2016 at 8:04 AM, Joscha Benz wrote: > Hi, > > excuse me for my delayed response. > > On 01.04.2016 02:40, Alistair Francis wrote: > >> Do you have any more specifics on what you need? At the moment we >> won't be able to take all of the code until the full register API is >> accepte

[Qemu-devel] [PATCH v1 0/2] xlxn-axi-gpio: Add and connect the Xilnx AXI GPIO

2016-11-11 Thread Alistair Francis
This patch series adds and connects the Xilnx AXI GPIO device. Datasheet: http://www.xilinx.com/support/documentation/ip_documentation/xps_gpio.pdf Alistair Francis (2): xlnx-axi-gpio: Add the Xilinx AXI GPIO device xlnx-ep108: Connect the AXI GPIO device hw/arm/xlnx-ep108.c |

[Qemu-devel] [PATCH v1 1/2] xlnx-axi-gpio: Add the Xilinx AXI GPIO device

2016-11-11 Thread Alistair Francis
Add the Xilinx AXI GPIO device. This is a commonly used device that lives in the programmable logic (PL) in Xilinx chips. Signed-off-by: Alistair Francis --- hw/gpio/Makefile.objs | 1 + hw/gpio/xlnx-axi-gpio.c | 269 include/hw/gpio/

[Qemu-devel] [PATCH v1 2/2] xlnx-ep108: Connect the AXI GPIO device

2016-11-11 Thread Alistair Francis
Connect the new Xilinx AXI GPIO devices based on the defaults used in the ZCU102 reference board design. Signed-off-by: Alistair Francis --- hw/arm/xlnx-ep108.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c index 4ec590

Re: [Qemu-devel] [PATCH] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-11 Thread Alex Williamson
On Sat, 12 Nov 2016 00:03:14 +0100 Paolo Bonzini wrote: > On 11/11/2016 22:11, Alex Williamson wrote: > > On Fri, 11 Nov 2016 20:46:53 + > > Felipe Franciosi wrote: > > > >> The trace you showed is exactly the same I encountered on vhost-scsi. And > >> the one my (hacky) patched fixed. T

Re: [Qemu-devel] [PULL 22/55] q35: ioapic: add support for emulated IOAPIC IR

2016-11-11 Thread Peter Xu
Hi, Emilio, On Fri, Nov 11, 2016 at 12:18:04PM -0500, Emilio G. Cota wrote: > On Tue, Jul 19, 2016 at 01:44:41 +0300, Michael S. Tsirkin wrote: > > From: Peter Xu > > > > This patch translates all IOAPIC interrupts into MSI ones. One pseudo > > ioapic address space is added to transfer the MSI m

Re: [Qemu-devel] [PATCH] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-11 Thread Paolo Bonzini
On 11/11/2016 22:11, Alex Williamson wrote: > On Fri, 11 Nov 2016 20:46:53 + > Felipe Franciosi wrote: > >> The trace you showed is exactly the same I encountered on vhost-scsi. And >> the one my (hacky) patched fixed. The summary of my investigation is on the >> patch description. I'm OO

Re: [Qemu-devel] kvm_mem_ioeventfd_add: error adding ioeventfd: File exists (was Re: [PULL 00/47] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups)

2016-11-11 Thread Alex Williamson
On Fri, 11 Nov 2016 23:48:58 +0200 "Michael S. Tsirkin" wrote: > Paolo tells me he has fixes for the kvm ioeventfd crashes > in vhost. I would appreciate testing and reports. I replied to Paolo's patch, it did not fix the problem for me. Thanks, Alex

Re: [Qemu-devel] Segmentation Fault running Raspberry Pi OS.

2016-11-11 Thread Julio Faracco
Hi guys, Thanks for the feedback. Basically, I'm using master branch. I'm not using any specific tag. $ ./qemu-system-arm --version QEMU emulator version 2.7.50 (v2.7.0-1871-g9b4b035-dirty) Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers I updated this branch (git pull on

Re: [Qemu-devel] Crashing in tcp_close

2016-11-11 Thread Samuel Thibault
Brian Candler, on Fri 11 Nov 2016 20:53:12 +, wrote: > On 11/11/2016 16:17, Samuel Thibault wrote: > >Could you increase the value given to valgrind's --num-callers= so we > >can make sure the context of this call? > > OK: re-run with --num-callers=250. It took a few iterations, but I captured

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-11 Thread Karl Rister
On 11/09/2016 11:13 AM, Stefan Hajnoczi wrote: > Recent performance investigation work done by Karl Rister shows that the > guest->host notification takes around 20 us. This is more than the "overhead" > of QEMU itself (e.g. block layer). > > One way to avoid the costly exit is to use polling ins

[Qemu-devel] kvm_mem_ioeventfd_add: error adding ioeventfd: File exists (was Re: [PULL 00/47] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups)

2016-11-11 Thread Michael S. Tsirkin
Paolo tells me he has fixes for the kvm ioeventfd crashes in vhost. I would appreciate testing and reports. -- MST

[Qemu-devel] [PATCH v4] target-m68k: add rol/ror/roxl/roxr instructions

2016-11-11 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- v4: - don't overwrite TCGv descriptor in rotate16_reg() v3: - fix rotate memory decoding - use "shx = shx < 0 ? size : shx;" - some cleanup v2: - use shift to do rotate_x() for 8 and 16bit value - rotate_x()/rotate32_x() are a no-op when shift % (size + 1)

Re: [Qemu-devel] TCP performance problems - GSO/TSO, MSS, 8139cp related

2016-11-11 Thread David Woodhouse
On Fri, 2016-11-11 at 21:05 +, Russell King - ARM Linux wrote: > > 18:59:38.782818 IP (tos 0x0, ttl 52, id 35619, offset 0, flags [DF], proto > TCP (6), length 60) >     84.xx.xxx.196.61236 > 195.92.253.2.http: Flags [S], cksum 0x88db > (correct), seq 158975430, win 29200, options [mss 1452,

Re: [Qemu-devel] [PATCH] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-11 Thread Alex Williamson
On Fri, 11 Nov 2016 20:46:53 + Felipe Franciosi wrote: > The trace you showed is exactly the same I encountered on vhost-scsi. And the > one my (hacky) patched fixed. The summary of my investigation is on the patch > description. I'm OOO so apologies for not being of more help. F. Paolo's

Re: [Qemu-devel] More platforms for the wiki

2016-11-11 Thread G 3
On Nov 11, 2016, at 4:03 PM, Max Filippov wrote: On Fri, Nov 11, 2016 at 5:02 AM, Stefan Hajnoczi wrote: On Fri, Nov 11, 2016 at 12:04:47AM -0500, G 3 wrote: http://fossboss.com/2016/08/13/use-qemu-test-operating-systems- distributions/ On this page I found a huge list of QEMU emulators.

Re: [Qemu-devel] More platforms for the wiki

2016-11-11 Thread Max Filippov
On Fri, Nov 11, 2016 at 5:02 AM, Stefan Hajnoczi wrote: > On Fri, Nov 11, 2016 at 12:04:47AM -0500, G 3 wrote: >> http://fossboss.com/2016/08/13/use-qemu-test-operating-systems-distributions/ >> >> On this page I found a huge list of QEMU emulators. I haven't heard of most >> of them, but some of

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-11 Thread Alex Williamson
On Fri, 11 Nov 2016 21:24:33 +0100 Paolo Bonzini wrote: > On 11/11/2016 05:09, Alex Williamson wrote: > > On Fri, 21 Oct 2016 22:48:10 +0200 > > Paolo Bonzini wrote: > > > >> Override start_ioeventfd and stop_ioeventfd to start/stop the > >> whole dataplane logic. This has some positive side

Re: [Qemu-devel] Crashing in tcp_close

2016-11-11 Thread Brian Candler
On 11/11/2016 16:17, Samuel Thibault wrote: Could you increase the value given to valgrind's --num-callers= so we can make sure the context of this call? OK: re-run with --num-callers=250. It took a few iterations, but I captured it again. (I have grepped out all the "invalid file descriptor"

Re: [Qemu-devel] [PATCH] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-11 Thread Felipe Franciosi
The trace you showed is exactly the same I encountered on vhost-scsi. And the one my (hacky) patched fixed. The summary of my investigation is on the patch description. I'm OOO so apologies for not being of more help. F. Sent from my phone > On 11 Nov 2016, at 20:38, Alex Williamson wrote: >

Re: [Qemu-devel] [PATCH] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-11 Thread Alex Williamson
On Fri, 11 Nov 2016 20:28:55 +0100 Paolo Bonzini wrote: > Following the recent refactoring of virtio notifiers [1], more specifically > the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to > start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] > by default, core virtio c

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-11 Thread Paolo Bonzini
On 11/11/2016 05:09, Alex Williamson wrote: > On Fri, 21 Oct 2016 22:48:10 +0200 > Paolo Bonzini wrote: > >> Override start_ioeventfd and stop_ioeventfd to start/stop the >> whole dataplane logic. This has some positive side effects: >> >> - no need anymore for virtio_add_queue_aio (i.e. a rev

Re: [Qemu-devel] [kvm-unit-tests PATCH v8 2/3] arm: pmu: Check cycle count increases

2016-11-11 Thread Wei Huang
On 11/11/2016 01:43 AM, Andrew Jones wrote: > On Tue, Nov 08, 2016 at 12:17:14PM -0600, Wei Huang wrote: >> From: Christopher Covington >> >> Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, >> even for the smallest delta of two subsequent reads. >> >> Signed-off-by: Christophe

Re: [Qemu-devel] [PULL 22/55] q35: ioapic: add support for emulated IOAPIC IR

2016-11-11 Thread Emilio G. Cota
On Fri, Nov 11, 2016 at 12:18:04 -0500, Emilio G. Cota wrote: > This commit (which sits between 2.6 and 2.7) Forgot to add the commit id -- cb135f59b8059c3a3 E.

Re: [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

2016-11-11 Thread Max Reitz
On 09.11.2016 20:15, Jeff Cody wrote: > On Tue, Nov 08, 2016 at 08:14:58AM +0100, Markus Armbruster wrote: >> Max Reitz writes: >> >>> On 07.11.2016 09:20, Markus Armbruster wrote: Max Reitz writes: > On 03.11.2016 08:56, Markus Armbruster wrote: >> Max Reitz writes: >> >>>

[Qemu-devel] [PATCH] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-11 Thread Paolo Bonzini
Following the recent refactoring of virtio notifiers [1], more specifically the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] by default, core virtio code requires 'ioeventfd_started' to be set to true/false when the

[Qemu-devel] [PULL 9/9] ahci-test: add QMP tray test for ATAPI

2016-11-11 Thread John Snow
Test QMP events for a CDROM device with or without a media inserted, including both guest-initiated and hw-initiated eject/load requests. Signed-off-by: John Snow Message-id: 1478553214-497-7-git-send-email-js...@redhat.com Signed-off-by: John Snow --- tests/ahci-test.c | 98 +++

[Qemu-devel] [PULL 8/9] libqos/ahci: Add get_sense and test_ready

2016-11-11 Thread John Snow
Required for tray tests once a medium may have changed. Signed-off-by: John Snow Message-id: 1478553214-497-6-git-send-email-js...@redhat.com Signed-off-by: John Snow --- tests/libqos/ahci.c | 50 ++ tests/libqos/ahci.h | 16 2 fi

[Qemu-devel] [PULL 3/9] ahci-test: test atapi read_cd with bcl, nb_sectors = 0

2016-11-11 Thread John Snow
Commit 9ef2e93f introduced the concept of tagging ATAPI commands as NONDATA, but this introduced a regression for certain commands better described as CONDDATA. read_cd is such a command that both requires a non-zero BCL if a transfer size is set, but is perfectly content to accept a zero BCL if th

Re: [Qemu-devel] [Qemu-ppc] [RFC 16/17] ppc: Remove counter-productive "sanity checks" in migration

2016-11-11 Thread Greg Kurz
On Tue, 8 Nov 2016 16:31:08 +1100 David Gibson wrote: > On Fri, Nov 04, 2016 at 04:52:39PM +1100, Alexey Kardashevskiy wrote: > > On 30/10/16 22:12, David Gibson wrote: > > > When vmstate for the ppc cpu was introduced in a90db158 "target-ppc: > > > Convert ppc cpu savevm to VMStateDescription"

[Qemu-devel] [PULL v2 32/34] vhost: drop legacy vring layout bits

2016-11-11 Thread Michael S. Tsirkin
From: Greg Kurz The legacy vring layout is not used anymore as we use the separate mappings even for legacy devices. This patch simply removes it. This also fixes a bug with virtio 1 devices when the vring descriptor table is mapped at a higher address than the used vring because the following f

[Qemu-devel] [PULL v2 30/34] nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong and use it to replace the raw number Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- hw/acpi/nvdimm.c | 30 +

[Qemu-devel] [PULL 5/9] libqtest: add qmp_eventwait_ref

2016-11-11 Thread John Snow
Wait for an event, but return a copy so we can investigate parameters. Signed-off-by: John Snow Reviewed-by: Eric Blake Message-id: 1478553214-497-3-git-send-email-js...@redhat.com Signed-off-by: John Snow --- tests/libqtest.c | 13 ++--- tests/libqtest.h | 22 ++ 2

[Qemu-devel] [PULL 0/9] Ide patches

2016-11-11 Thread John Snow
The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6: MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to 317a342cc0e06

[Qemu-devel] [PULL v2 23/34] nvdimm acpi: rename nvdimm_plugged_device_list

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong Its behavior has been changed as the nvdimm device which is being realized also will be handled in this function, so rename it to reflect the fact Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 7/9] libqos/ahci: Add ATAPI tray macros

2016-11-11 Thread John Snow
(1) Add START_STOP_UNIT command to ahci-test suite (2) Add eject/start macro commands; this is not a data transfer command so it is not well-served by the existing generic pipeline. Signed-off-by: John Snow Message-id: 1478553214-497-5-git-send-email-js...@redhat.com Signed-off-by: John Snow

[Qemu-devel] [PULL v2 27/34] nvdimm acpi: fix two comments

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong fixed the English issue and code-style issue Suggested-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- hw/acpi/nvdimm.c | 4 ++-- 1 file cha

[Qemu-devel] [PULL 1/9] atapi: classify read_cd as conditionally returning data

2016-11-11 Thread John Snow
For the purposes of byte_count_limit verification, add a new flag that identifies read_cd as sometimes returning data, then check the BCL in its command handler after we know that it will indeed return data. Reported-by: Hervé Poussineau Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-

[Qemu-devel] [PATCH v3] target-m68k: add rol/ror/roxl/roxr instructions

2016-11-11 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- v3: - fix rotate memory instruction decoding - use "shx = shx < 0 ? size : shx;" - some cleanup v2: - use shift to do rotate_x() for 8 and 16bit value - rotate_x()/rotate32_x() are a no-op when shift % (size + 1) == 0 - add some missing tcg_temp_free() ta

[Qemu-devel] [PULL v2 25/34] nvdimm acpi: rename nvdimm_acpi_hotplug

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong Rename it to nvdimm_plug() Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- include/hw/mem/nvdimm.h | 2 +- hw/acpi/nvdimm.c|

[Qemu-devel] [PULL 2/9] ahci-test: Create smaller test ISO images

2016-11-11 Thread John Snow
These can simply be the size of the number of sectors we're reading, plus one for a buffer. We don't need them to be any larger. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1477970211-25754-3-git-send-email-js...@redhat.com Signed-off-by: John Snow --- tests/ahci-test.c | 3 ++

[Qemu-devel] [PULL v2 24/34] nvdimm acpi: cleanup nvdimm_build_fit

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong inline buf_size to refine the code a bit Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- hw/acpi/nvdimm.c | 4 +--- 1 file changed,

[Qemu-devel] [PULL 6/9] libqos/ahci: Support expected errors

2016-11-11 Thread John Snow
Sometimes we know we'll get back an error, so let's have the test framework understand that. Signed-off-by: John Snow Message-id: 1478553214-497-4-git-send-email-js...@redhat.com Signed-off-by: John Snow --- tests/libqos/ahci.c | 16 tests/libqos/ahci.h | 3 ++- 2 files change

[Qemu-devel] [PULL 4/9] block-backend: Always notify on blk_eject

2016-11-11 Thread John Snow
blk_eject is only used by scsi-disk and atapi, and in both cases we only attempt to invoke blk_eject if we have a bona-fide change in tray state. The "issue" here is that the tray state does not generate a QMP event unless there is a medium/BDS attached to the device, so if libvirt et al are waiti

[Qemu-devel] [PULL v2 20/34] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong as it is never called when nvdimm hotplug happens Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- hw/i386/pc.c | 6 -- 1 file ch

[Qemu-devel] [PULL v2 34/34] docs: add PCIe devices placement guidelines

2016-11-11 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Proposes best practices on how to use PCI Express/PCI device in PCI Express based machines and explain the reasoning behind them. Reviewed-by: Laszlo Ersek Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- docs/pcie.

[Qemu-devel] [PULL v2 17/34] qdev: hotplug: drop HotplugHandler.post_plug callback

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong as nvdimm acpi is okay to build fit when the nvdimm device has not been 'realized' Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- i

[Qemu-devel] [PULL v2 26/34] nvdimm acpi: define DSM return codes

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong and use these codes to refine the code Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- hw/acpi/nvdimm.c | 46 +++

[Qemu-devel] [PULL v2 16/34] vhost: migration blocker only if shared log is used

2016-11-11 Thread Michael S. Tsirkin
From: Rafael David Tinoco Commit 31190ed7 added a migration blocker in vhost_dev_init() to check if memfd would succeed. It is better if this blocker first checks if vhost backend requires shared log. This will avoid a situation where a blocker is added inappropriately (e.g. shared log allocation

[Qemu-devel] [PULL v2 22/34] docs: improve the doc of Read FIT method

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong Improve the description and clearly document the length field Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- docs/specs/acpi_nvdimm

[Qemu-devel] [PULL v2 14/34] virtio: allow per-device-class legacy features

2016-11-11 Thread Michael S. Tsirkin
Legacy features are those that transitional devices only expose on the legacy interface. Allow different ones per device class. Cc: qemu-sta...@nongnu.org # dependency for the next patch Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck --- include/hw/virtio/virtio.h | 5 + hw/s3

[Qemu-devel] [PULL v2 21/34] nvdimm acpi: clean up nvdimm_build_acpi

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong To make the code more clearer, we 1) check ram_slots first, and build ssdt & nfit only when it is available 2) use nvdimm_get_plugged_device_list() to check if there is nvdimm device plugged Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael

[Qemu-devel] [PULL v2 13/34] acpi: fix DMAR device scope for IOAPIC

2016-11-11 Thread Michael S. Tsirkin
From: Peter Xu We should not use cpu_to_le16() here, instead each of device/function value is stored in a 8 byte field. Signed-off-by: Peter Xu Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/acpi-defs.h | 5 - hw/i386/acp

[Qemu-devel] [PULL v2 19/34] pc: memhp: move nvdimm hotplug out of memory hotplug

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong as they use completely different way to handle hotplug event Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- include/hw/mem/nvdimm.h

[Qemu-devel] [PULL v2 33/34] virtio: drop virtio_queue_get_ring_{size, addr}()

2016-11-11 Thread Michael S. Tsirkin
From: Greg Kurz These are not used anymore. Signed-off-by: Greg Kurz Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 2 -- hw/virtio/virtio.c | 11 --- 2 files changed, 13 deletions(-) diff --git

[Qemu-devel] [PULL v2 31/34] vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout

2016-11-11 Thread Michael S. Tsirkin
From: Greg Kurz With virtio 1, the vring layout is split in 3 separate regions of contiguous memory for the descriptor table, the available ring and the used ring, as opposed with legacy virtio which uses a single region. In case of memory re-mapping, the code ensures it doesn't affect the vring

[Qemu-devel] [PULL v2 09/34] virtio: make virtqueue_alloc_element static

2016-11-11 Thread Michael S. Tsirkin
From: Ladi Prosek The function does not fully initialize the returned VirtQueueElement and should be used only internally from the virtio module. Signed-off-by: Ladi Prosek Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/v

[Qemu-devel] [PULL v2 18/34] nvdimm acpi: drop the lock of fit buffer

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong as there is a global lock to protect vm-exit handlers and QMP/monitor, this lock can be dropped Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mam

[Qemu-devel] [PULL v2 29/34] nvdimm acpi: use aml_name_decl to define named object

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong to make the code more clearer Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- hw/acpi/nvdimm.c | 6 ++ 1 file changed, 2 inserti

[Qemu-devel] [PULL v2 10/34] virtio-crypto: tag as not hotpluggable and migration

2016-11-11 Thread Michael S. Tsirkin
From: Gonglei Currently the virtio-crypto device hasn't supported hotpluggable and live migration well. Let's tag it as not hotpluggable and migration actively and reopen them once we support them well. Suggested-by: Michael S. Tsirkin Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Si

[Qemu-devel] [PULL v2 15/34] virtio-net: mark VIRTIO_NET_F_GSO as legacy

2016-11-11 Thread Michael S. Tsirkin
virtio 1.0 spec says this is a legacy feature bit, hide it from guests in modern mode. Note: for cross-version migration compatibility, we keep the bit set in host_features. The result will be that a guest migrating cross-version will see host features change under it. As guests only seem to read

[Qemu-devel] [PULL v2 07/34] intel_iommu: fixing source id during IOTLB hash key calculation

2016-11-11 Thread Michael S. Tsirkin
From: Jason Wang Using uint8_t for source id will lose bus num and get the wrong/invalid IOTLB entry. Fixing by using uint16_t instead and enlarge level shift. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Michael S. Tsirkin Signed-off-by: Jason Wang Reviewed-by: Michael S

[Qemu-devel] [PULL v2 28/34] nvdimm acpi: rename nvdimm_dsm_reserved_root

2016-11-11 Thread Michael S. Tsirkin
From: Xiao Guangrong Rename it to nvdimm_dsm_handle_reserved_root_method Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- hw/acpi/nvdimm.c | 7 --- 1

[Qemu-devel] [PULL v2 11/34] intel_iommu: fix several incorrect endianess and bit fields

2016-11-11 Thread Michael S. Tsirkin
From: Peter Xu Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/intel_iommu.h | 9 - hw/i386/intel_iommu.c | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/include/hw/i386/intel_iommu.h b/includ

[Qemu-devel] [PULL v2 12/34] intel_iommu: fix incorrect assert

2016-11-11 Thread Michael S. Tsirkin
From: Peter Xu Reported-by: Michael S. Tsirkin Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 20c4d2c..

[Qemu-devel] [PULL v2 06/34] tests/vhost-user-bridge: use contrib/libvhost-user

2016-11-11 Thread Michael S. Tsirkin
From: Marc-André Lureau Use the libvhost-user library. This ended up being a rather large patch that cannot be easily splitted, due to massive code move and API changes. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-b

[Qemu-devel] [PULL v2 05/34] contrib: add libvhost-user

2016-11-11 Thread Michael S. Tsirkin
From: Marc-André Lureau Add a library to help implementing vhost-user backend (or slave). Dealing with vhost-user as an application developer isn't so easy: you have all the trouble with any protocol: validation, unix ancillary data, shared memory, eventfd, logging, and on top of that you need t

[Qemu-devel] [PULL v2 08/34] virtio: rename virtqueue_discard to virtqueue_unpop

2016-11-11 Thread Michael S. Tsirkin
From: Ladi Prosek The function undoes the effect of virtqueue_pop and doesn't do anything destructive or irreversible so virtqueue_unpop is a more fitting name. Signed-off-by: Ladi Prosek Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- incl

[Qemu-devel] [PULL v2 04/34] tests/vhost-user-bridge: do not accept more than one connection

2016-11-11 Thread Michael S. Tsirkin
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-bridge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index 97e45d8..5b618f6 100644 ---

[Qemu-devel] [PULL v2 01/34] tests/vhost-user-bridge: remove false comment

2016-11-11 Thread Michael S. Tsirkin
From: Marc-André Lureau dispatcher_remove() is in use. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-bridge.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c i

[Qemu-devel] [PULL v2 02/34] tests/vhost-user-bridge: remove unnecessary dispatcher_remove

2016-11-11 Thread Michael S. Tsirkin
From: Marc-André Lureau The call fd is not watched Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-bridge.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index

[Qemu-devel] [PULL v2 03/34] tests/vhost-user-bridge: indicate peer disconnected

2016-11-11 Thread Michael S. Tsirkin
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-bridge.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index 19b0e94..97e45d8 100644 --- a

[Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups

2016-11-11 Thread Michael S. Tsirkin
The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6: MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 2

Re: [Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

2016-11-11 Thread Michael S. Tsirkin
On Thu, Nov 03, 2016 at 08:57:56PM +0800, Cao jin wrote: > When user specify invalid property aer_log_max, device should fail to > create, and report appropriate message. > > Signed-off-by: Cao jin Was this tested outside of make check? > --- > v3 changelog: > 1. get rid of PCIE_AER_LOG_MAX_UNS

Re: [Qemu-devel] [PATCH] linux-user: manage two new IFLA host message types

2016-11-11 Thread Laurent Vivier
This is a bug fix: could you take it for 2.8? Laurent Le 27/10/2016 à 03:00, Laurent Vivier a écrit : > Add QEMU_IFLA_GSO_MAX_SEGS and QEMU_IFLA_GSO_MAX_SIZE > in host_to_target_data_link_rtattr(). > > These two messages are sent by the host kernel when > we use "sudo". > > Found with qemu-m68k

Re: [Qemu-devel] [PATCH v6 00/10] Convert msix_init() to error

2016-11-11 Thread Michael S. Tsirkin
On Sat, Nov 05, 2016 at 10:07:19AM +0800, Cao jin wrote: > v6 changelog: > 1. re-spin vfio-pci related code on patch 3: for -ENOTSUP, report & free > Error, >for other error, propagate the Error. (Marcel) I dropped this patchset for now, pls submit either patches that were tested, or note oth

Re: [Qemu-devel] [PATCH v2] acpi: Use apic_id_limit when calculating legacy ACPI table size

2016-11-11 Thread Eduardo Habkost
On Fri, Nov 11, 2016 at 07:13:25PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 11, 2016 at 02:45:42PM -0200, Eduardo Habkost wrote: > > The code that calculates the legacy ACPI table size for migration > > compatibility uses max_cpus when calculating legacy_aml_len (the size of > > the DSDT and

Re: [Qemu-devel] [PULL 22/55] q35: ioapic: add support for emulated IOAPIC IR

2016-11-11 Thread Emilio G. Cota
On Tue, Jul 19, 2016 at 01:44:41 +0300, Michael S. Tsirkin wrote: > From: Peter Xu > > This patch translates all IOAPIC interrupts into MSI ones. One pseudo > ioapic address space is added to transfer the MSI message. By default, > it will be system memory address space. When IR is enabled, it wi

Re: [Qemu-devel] [virtio-comment] Re: [PATCH v1] docs/vhost-user: extend the vhost-user protocol to support the vhost-pci based inter-vm communication

2016-11-11 Thread Michael S. Tsirkin
On Tue, Nov 08, 2016 at 12:17:38PM +, Marc-André Lureau wrote: > Yes, that's the trouble. At any time the Master may send a request and expects > an immediate reply. There is a race of getting a request from the Slave in the > middle with your proposed change. I'd rather avoid making the reques

Re: [Qemu-devel] [PATCH v2] acpi: Use apic_id_limit when calculating legacy ACPI table size

2016-11-11 Thread Michael S. Tsirkin
On Fri, Nov 11, 2016 at 02:45:42PM -0200, Eduardo Habkost wrote: > The code that calculates the legacy ACPI table size for migration > compatibility uses max_cpus when calculating legacy_aml_len (the size of > the DSDT and SSDT tables). However, the SSDT grows according to APIC ID > limit, not max_

[Qemu-devel] [PULL 09/12] block: Emit modules in bdrv_iterate_format()

2016-11-11 Thread Kevin Wolf
From: Max Reitz Some block drivers may not be loaded yet, but qemu supports them nonetheless. bdrv_iterate_format() should report them, too. Signed-off-by: Max Reitz Message-id: 20161012204907.25941-3-mre...@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- block.c | 18 +++

[Qemu-devel] [PULL 05/12] raw_bsd: don't check size alignment when only offset is set

2016-11-11 Thread Kevin Wolf
From: Tomáš Golembiovský We make sure that the size is aligned to sector length to prevent any round ups. Otherwise we could end up reading/writing data outside the area specified by user. This is only needed when user supplies the size option to avoid any surprises. It is not necessary when only

[Qemu-devel] [PULL 10/12] iotests: Skip test 162 if there is no SSH support

2016-11-11 Thread Kevin Wolf
From: Max Reitz Signed-off-by: Max Reitz Message-id: 20161012204907.25941-4-mre...@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- tests/qemu-iotests/162 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/162 b/tests/qemu-iotests/162 index f8eecb3..cad2b

[Qemu-devel] [PULL 12/12] raw-posix: Rename 'raw_s' to 'rs'

2016-11-11 Thread Kevin Wolf
From: Fam Zheng It is too confusing because it sounds like a BDRVRawState variable. Suggested-by: Max Reitz Signed-off-by: Fam Zheng Message-id: 1477565117-17230-1-git-send-email-f...@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- block/raw-posix.c | 56

[Qemu-devel] [PULL 08/12] block: Fix bdrv_iterate_format() sorting

2016-11-11 Thread Kevin Wolf
From: Max Reitz bdrv_iterate_format() did not actually sort the formats by name but by "pointer interpreted as string". That is probably not what we intended to do, so fix it (by changing qsort_strcmp() so it matches the example from qsort()'s manual page). Signed-off-by: Max Reitz Message-id:

[Qemu-devel] [PULL 11/12] iotests: Always use -machine accel=qtest

2016-11-11 Thread Kevin Wolf
From: Max Reitz Currently, we only use -machine accel=qtest when qemu is invoked through the common.qemu functions. However, we always want to use it, so move it from common.qemu directly into QEMU_OPTIONS. Signed-off-by: Max Reitz Message-id: 20161017183917.8837-1-mre...@redhat.com Reviewed-by

[Qemu-devel] [PULL 07/12] nfs: Fix memory leak in nfs_file_create()

2016-11-11 Thread Kevin Wolf
The leak was introduced in commit 94d6a7a7. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/nfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nfs.c b/block/nfs.c index 55c4e0b..d082783 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -676,6 +676,7 @@ static int nfs_f

[Qemu-devel] [PULL 04/12] raw_bsd: move check to prevent overflow

2016-11-11 Thread Kevin Wolf
From: Tomáš Golembiovský When only offset is specified but no size and the offset is greater than the real size of the containing device an overflow occurs when parsing the options. This overflow is harmless because we do check for this exact situation little bit later, but it leads to an error m

[Qemu-devel] [PULL 06/12] qcow2: Remove stale FIXME comment

2016-11-11 Thread Kevin Wolf
From: Alberto Garcia It was from the time when none of the global functions had a qcow2_ prefix. Signed-off-by: Alberto Garcia Signed-off-by: Kevin Wolf --- block/qcow2.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/qcow2.h b/block/qcow2.h index 92203a8..1823414 100644 --- a/blo

[Qemu-devel] [PULL 03/12] hmp: Make block_stream set an explicit job ID

2016-11-11 Thread Kevin Wolf
From: Alberto Garcia A job ID is always required in order to create a block job on a non-root node. The default ID (obtained with bdrv_get_device_name()) is otherwise empty in this scenario and the job cannot be created. The HMP block_stream command doesn't set a job ID and therefore it doesn't

[Qemu-devel] [PULL 01/12] block/nbd: Fix the leaked visitor

2016-11-11 Thread Kevin Wolf
From: Ashijeet Acharya This patch frees the leaked visitor in nbd_refresh_filename() and uses visit_free() to fix it. The leak was introduced by the commit 491d6c7. Signed-off-by: Ashijeet Acharya Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/nbd.c | 1 + 1 file changed, 1 inse

[Qemu-devel] [PULL 00/12] Block layer patches for 2.8.0-rc0

2016-11-11 Thread Kevin Wolf
The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6: MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to ff569b9424d1e6c7144d

[Qemu-devel] [PULL 02/12] block/ssh: Code cleanup for unused parameter

2016-11-11 Thread Kevin Wolf
From: Ashijeet Acharya This patch drops the unused parameter "BDRVSSHState" being passed into the ssh_config() function and does code cleanup. The unused parameter was introduced by the commit c322712. Signed-off-by: Ashijeet Acharya Signed-off-by: Kevin Wolf --- block/ssh.c | 5 ++--- 1 file

  1   2   3   >