Re: [Qemu-devel] [PATCH v11 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-13 Thread Kirti Wankhede
On 11/9/2016 2:58 AM, Alex Williamson wrote: > On Wed, 9 Nov 2016 01:29:19 +0530 > Kirti Wankhede wrote: > >> On 11/8/2016 11:16 PM, Alex Williamson wrote: >>> On Tue, 8 Nov 2016 21:56:29 +0530 >>> Kirti Wankhede wrote: >>> On 11/8/2016 5:15 AM, Alex Williamson wrote: > On Sat, 5

Re: [Qemu-devel] [PATCH 0/4] make SMBUS/SATA/PIT configurable and introduce

2016-11-13 Thread Chao Peng
On Thu, 2016-11-10 at 16:50 +0200, Michael S. Tsirkin wrote: > On Sat, Nov 05, 2016 at 03:19:47AM -0400, Chao Peng wrote: > > > > This patchset makes SMBUS/SATA/PIT configurable and introduces a > > new > > machine type q35-lite with these features disabled by default. This > > is > > useful for c

[Qemu-devel] [PATCH v7 03/10] pci: Convert msix_init() to Error and fix callers to check it

2016-11-13 Thread Cao jin
msix_init() reports errors with error_report(), which is wrong when it's used in realize(). The same issue was fixed for msi_init() in commit 1108b2f. For some devices(like e1000e, vmxnet3) who won't fail because of msix_init's failure, suppress the error report by passing NULL error object. Bon

[Qemu-devel] [PATCH v7 09/10] vmxnet3: remove unnecessary internal msix flag

2016-11-13 Thread Cao jin
Internal flag msix_used is unnecessary, it has the same effect as msix_enabled(). The corresponding msi flag is already dropped in commit 1070048e. CC: Dmitry Fleytman CC: Jason Wang CC: Markus Armbruster CC: Michael S. Tsirkin Reviewed-by: Markus Armbruster Reviewed-by: Dmitry Fleytman Si

[Qemu-devel] [PATCH v7 05/10] hcd-xhci: change behaviour of msix switch

2016-11-13 Thread Cao jin
Resolve the TODO, msix=auto means msix on; if user specify msix=on, then device creation fail on msix_init failure. CC: Gerd Hoffmann CC: Michael S. Tsirkin CC: Markus Armbruster CC: Marcel Apfelbaum Reviewed-by: Gerd Hoffmann Reviewed-by: Markus Armbruster Signed-off-by: Cao jin --- hw/u

[Qemu-devel] [PATCH v7 04/10] megasas: change behaviour of msix switch

2016-11-13 Thread Cao jin
Resolve the TODO, msix=auto means msix on; if user specify msix=on, then device creation fail on msix_init failure. Also undo the overwrites of user configuration of msix. CC: Michael S. Tsirkin CC: Hannes Reinecke CC: Paolo Bonzini CC: Markus Armbruster CC: Marcel Apfelbaum Reviewed-by: Mar

[Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2016-11-13 Thread Cao jin
v7 changelog: 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, please take a look, there is detailed description in the patch. 2. add the R-b from Hannes Reinecke Test: 1. make check: pass 2. After applied all the patch, command line test for all the affected devices, just m

[Qemu-devel] [PATCH v7 08/10] vmxnet3: fix reference leak issue

2016-11-13 Thread Cao jin
On migration target, msix_vector_use() will be called in vmxnet3_post_load() in second time, without a matching second call to msi_vector_unuse(), which results in vector reference leak. CC: Dmitry Fleytman CC: Jason Wang CC: Markus Armbruster CC: Michael S. Tsirkin Reviewed-by: Markus Armbru

[Qemu-devel] [PATCH v7 07/10] megasas: undo the overwrites of msi user configuration

2016-11-13 Thread Cao jin
Commit afea4e14 seems forgetting to undo the overwrites, which is unsuitable. CC: Hannes Reinecke CC: Paolo Bonzini CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Reviewed-by: Markus Armbruster Reviewed-by: Hannes Reinecke Signed-off-by: Cao jin --- hw/scsi/megasas.c |

[Qemu-devel] [PATCH v7 02/10] hcd-xhci: check & correct param before using it

2016-11-13 Thread Cao jin
usb_xhci_realize() corrects invalid values of property "intrs" automatically, but the uncorrected value is passed to msi_init(), which chokes on invalid values. Delay that until after the correction. Resources allocated by usb_xhci_init() are leaked when msi_init() fails. Fix by calling it after

[Qemu-devel] [PATCH v7 01/10] msix: Follow CODING_STYLE

2016-11-13 Thread Cao jin
CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Reviewed-by: Markus Armbruster Signed-off-by: Cao jin --- hw/pci/msix.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index 0ec1cb1..0cee631 100644 --- a/hw/pci/msix.

[Qemu-devel] [PATCH v7 10/10] msi_init: convert assert to return -errno

2016-11-13 Thread Cao jin
According to the disscussion: http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg08215.html Let leaf function returns reasonable -errno, let caller decide how to handle the return value. Suggested-by: Markus Armbruster CC: Markus Armbruster CC: Michael S. Tsirkin CC: Marcel Apfelbaum

[Qemu-devel] [PATCH v7 06/10] megasas: remove unnecessary megasas_use_msix()

2016-11-13 Thread Cao jin
Also move certain hunk above, to place msix init related code together. CC: Hannes Reinecke CC: Paolo Bonzini CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Reviewed-by: Markus Armbruster Reviewed-by: Hannes Reinecke Signed-off-by: Cao jin --- hw/scsi/megasas.c | 19 ++

Re: [Qemu-devel] virtIO question

2016-11-13 Thread zhun...@gmail.com
Hello,teacher,I may be found where the driver add mutiple buffer to virtqueue and then kick qemu side. It is when driver use NAPI to poll the device to get buffers,and it is in receive queue.but in transmit queue,every time driver add a buffer to virtqueue,then kick function is called!!!why ??is

Re: [Qemu-devel] [PATCH 2/4] hw/misc: add a TMP42{1, 2, 3} device model

2016-11-13 Thread Cédric Le Goater
On 05/23/2016 05:53 AM, Andrew Jeffery wrote: > Hi Cédric, > > On Fri, 2016-05-20 at 18:31 +0200, Cédric Le Goater wrote: >> Largely inspired by the TMP105 temperature sensor, this patch brings >> to Qemu a model for TMP42{1,2,3} temperature sensors. >> >> Specs can be found here : >> >> http

Re: [Qemu-devel] [Qemu-ppc] [RFC 16/17] ppc: Remove counter-productive "sanity checks" in migration

2016-11-13 Thread David Gibson
On Mon, Nov 14, 2016 at 01:34:55PM +1100, Alexey Kardashevskiy wrote: > On 12/11/16 05:13, Greg Kurz wrote: > > On Tue, 8 Nov 2016 16:31:08 +1100 > > David Gibson wrote: > > > >> On Fri, Nov 04, 2016 at 04:52:39PM +1100, Alexey Kardashevskiy wrote: > >>> On 30/10/16 22:12, David Gibson wrote: >

[Qemu-devel] [PATCH 3/3] tests: add XSCOM tests for the PowerNV machine

2016-11-13 Thread Cédric Le Goater
Add a couple of tests on the XSCOM bus of the PowerNV machine for the the POWER8 and POWER9 CPUs. The first tests reads the CFAM identifier of the chip. The second test goes further in the XSCOM address space and reaches the cores to read their DTS registers. Signed-off-by: Cédric Le Goater ---

[Qemu-devel] [PATCH 1/3] ppc/pnv: add a 'xscom_core_base' field to PnvChipClass

2016-11-13 Thread Cédric Le Goater
The XSCOM addresses for the core registers are encoded in a slightly different way on POWER8 and POWER9. Signed-off-by: Cédric Le Goater --- hw/ppc/pnv.c | 8 +++- include/hw/ppc/pnv.h | 1 + include/hw/ppc/pnv_xscom.h | 5 ++--- 3 files changed, 10 insertions(+), 4 delet

[Qemu-devel] [PATCH 0/3] ppc/pnv: XSCOM fixes and unit tests

2016-11-13 Thread Cédric Le Goater
Hello, Here is a little serie adding some fixes for the XSCOM registers of the POWER9 cores and a unit test. Thanks, C. Cédric Le Goater (3): ppc/pnv: add a 'xscom_core_base' field to PnvChipClass ppc/pnv: fix xscom address translation for POWER9 tests: add XSCOM tests for the PowerNV ma

[Qemu-devel] [PATCH 2/3] ppc/pnv: fix xscom address translation for POWER9

2016-11-13 Thread Cédric Le Goater
High addresses can overflow the uint32_t pcba variable after the 8byte shift. Signed-off-by: Cédric Le Goater --- hw/ppc/pnv_xscom.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ppc/pnv_xscom.c b/hw/ppc/pnv_xscom.c index f46646141a96..8da271872f59 100644 --- a/h

[Qemu-devel] [PATCH] crypto: add virtio-crypto driver

2016-11-13 Thread Gonglei
This patch introduces virtio-crypto driver for Linux Kernel. The virtio crypto device is a virtual cryptography device as well as a kind of virtual hardware accelerator for virtual machines. The encryption anddecryption requests are placed in the data queue and are ultimately handled by thebackend

Re: [Qemu-devel] [PULL V2 0/3] Net patches

2016-11-13 Thread Zhang Chen
Hi~ Jason~ Can you pick up this patch? [PATCH] docs: fix COLO architecture diagram Thanks Zhang Chen On 11/14/2016 10:54 AM, Jason Wang wrote: The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974: Merge remote-tracking branch 'bonzini/tags/for-upstream' into stag

Re: [Qemu-devel] virsh dump (qemu guest memory dump?): KASLR enabled linux guest support

2016-11-13 Thread Dave Young
On 11/09/16 at 04:38pm, Laszlo Ersek wrote: > On 11/09/16 15:47, Daniel P. Berrange wrote: > > On Wed, Nov 09, 2016 at 01:20:51PM +0100, Andrew Jones wrote: > >> On Wed, Nov 09, 2016 at 11:58:19AM +, Daniel P. Berrange wrote: > >>> On Wed, Nov 09, 2016 at 12:48:09PM +0100, Andrew Jones wrote: >

[Qemu-devel] [PULL V2 0/3] Net patches

2016-11-13 Thread Jason Wang
The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974: Merge remote-tracking branch 'bonzini/tags/for-upstream' into staging (2016-11-11 12:51:50 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch

Re: [Qemu-devel] [RFC 12/17] ppc: Migrate compatibility mode

2016-11-13 Thread David Gibson
On Thu, Nov 10, 2016 at 05:55:36PM -0600, Michael Roth wrote: > Quoting David Gibson (2016-11-09 19:59:37) > > On Tue, Nov 08, 2016 at 04:51:10PM +1100, Alexey Kardashevskiy wrote: > > > On 08/11/16 16:19, David Gibson wrote: > > > > On Fri, Nov 04, 2016 at 04:58:47PM +1100, Alexey Kardashevskiy wr

[Qemu-devel] [PULL V2 2/3] net: skip virtio-net config of deleted nic's peers

2016-11-13 Thread Jason Wang
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1373816 qemu core dump happens during repetitive unpug-plug with multiple queues and Windows RSS-capable guest. If back-end delete requested during virtio-net device initialization, driver still can try configure the device for mu

[Qemu-devel] [PULL V2 1/3] record/replay: add network support

2016-11-13 Thread Jason Wang
From: Pavel Dovgalyuk This patch adds support of recording and replaying network packets in irount rr mode. Record and replay for network interactions is performed with the network filter. Each backend must have its own instance of the replay filter as follows: -netdev user,id=net1 -device rtl8

[Qemu-devel] [PULL V2 3/3] net: fix sending of data with -net socket, listen backend

2016-11-13 Thread Jason Wang
From: "Daniel P. Berrange" The use of -net socket,listen was broken in the following commit commit 16a3df403b10c4ac347159e39005fd520b2648bb Author: Zhang Chen Date: Fri May 13 15:35:19 2016 +0800 net/net: Add SocketReadState for reuse codes This function is from net/socket.c,

Re: [Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-13 Thread Dong Jia Shi
* Kirti Wankhede [2016-11-05 02:40:44 +0530]: Hi Kirti, [...] > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 8d64528dcc22..e511073446a0 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c [...] > +static int vfio_pfn_a

Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

2016-11-13 Thread Hailiang Zhang
ping ? Anyone pick this up? On 2016/11/2 22:04, Eric Blake wrote: On 11/02/2016 02:44 AM, zhanghailiang wrote: VM can not get into colo state unless users enable 'x-colo' capability for migration, Here it is necessary to clarify this. Suggested-by: Eric Blake Signed-off-by: zhanghailiang --

Re: [Qemu-devel] [PATCH v2] migration: fix missing assignment for has_x_checkpoint_delay

2016-11-13 Thread Hailiang Zhang
ping ? On 2016/11/2 15:42, zhanghailiang wrote: We forgot to assign true to params->has_x_checkpoint_delay parameter in qmp_query_migrate_parameters. Without this, qmp command 'query-migrate-parameters' doesn't show the default value for x-checkpoint-delay option. This also fixes the fact that

Re: [Qemu-devel] [Qemu-ppc] [RFC 16/17] ppc: Remove counter-productive "sanity checks" in migration

2016-11-13 Thread Alexey Kardashevskiy
On 12/11/16 05:13, Greg Kurz wrote: > On Tue, 8 Nov 2016 16:31:08 +1100 > David Gibson wrote: > >> On Fri, Nov 04, 2016 at 04:52:39PM +1100, Alexey Kardashevskiy wrote: >>> On 30/10/16 22:12, David Gibson wrote: When vmstate for the ppc cpu was introduced in a90db158 "target-ppc: Conv

Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory

2016-11-13 Thread Samuel Thibault
Hello, Note: no-re...@patchew.org, on Sun 13 Nov 2016 15:13:47 -0800, wrote: > Your series seems to have some coding style problems. See output below for > more information: > > === OUTPUT BEGIN === > fatal: unrecognized argument: --no-patch > Checking PATCH 1/1: ... > ERROR: suspect code indent

Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory

2016-11-13 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] slirp: Fix access to freed memory Message-id: 20161113230102.12173-1-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

Re: [Qemu-devel] [V6, 2/7] nios2: Add architecture emulation support

2016-11-13 Thread Marek Vasut
On 11/13/2016 05:25 PM, Guenter Roeck wrote: > On 11/13/2016 04:43 AM, Marek Vasut wrote: >> On 11/13/2016 01:01 PM, Marek Vasut wrote: >>> On 11/13/2016 12:25 AM, Guenter Roeck wrote: Hi Marek, >>> >>> Hi! >>> On 11/12/2016 01:50 PM, Marek Vasut wrote: > On 11/07/2016 08:54 PM, Guent

Re: [Qemu-devel] [V6, 2/7] nios2: Add architecture emulation support

2016-11-13 Thread Marek Vasut
On 11/13/2016 05:09 PM, Guenter Roeck wrote: > Hi Marek, > > On 11/13/2016 04:01 AM, Marek Vasut wrote: >>> >>> diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c >>> index 564dbae..e0a9aff 100644 >>> --- a/hw/nios2/boot.c >>> +++ b/hw/nios2/boot.c >>> @@ -73,6 +73,11 @@ static void main_cpu_reset(voi

[Qemu-devel] [PATCH] slirp: Fix access to freed memory

2016-11-13 Thread Samuel Thibault
if_start() goes through the slirp->if_fastq and slirp->if_batchq list of pending messages, and accesses ifm->ifq_so->so_nqueued of its elements if ifm->ifq_so != NULL. When freeing a socket, we thus need to make sure that any pending message for this socket does not refer to the socket any more.

Re: [Qemu-devel] [V6, 2/7] nios2: Add architecture emulation support

2016-11-13 Thread Guenter Roeck
On 11/13/2016 04:43 AM, Marek Vasut wrote: On 11/13/2016 01:01 PM, Marek Vasut wrote: On 11/13/2016 12:25 AM, Guenter Roeck wrote: Hi Marek, Hi! On 11/12/2016 01:50 PM, Marek Vasut wrote: On 11/07/2016 08:54 PM, Guenter Roeck wrote: Hi Marek, On 11/07/2016 10:14 AM, Marek Vasut wrote: O

Re: [Qemu-devel] [V6, 2/7] nios2: Add architecture emulation support

2016-11-13 Thread Guenter Roeck
Hi Marek, On 11/13/2016 04:01 AM, Marek Vasut wrote: diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c index 564dbae..e0a9aff 100644 --- a/hw/nios2/boot.c +++ b/hw/nios2/boot.c @@ -73,6 +73,11 @@ static void main_cpu_reset(void *opaque) } } +static uint64_t translate_kernel_address(void *op

Re: [Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

2016-11-13 Thread Cao jin
On 11/12/2016 01:37 AM, Michael S. Tsirkin wrote: On Thu, Nov 03, 2016 at 08:57:56PM +0800, Cao jin wrote: When user specify invalid property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin Was this tested outside of make check? Yes, I j

Re: [Qemu-devel] [V6, 2/7] nios2: Add architecture emulation support

2016-11-13 Thread Marek Vasut
On 11/13/2016 01:01 PM, Marek Vasut wrote: > On 11/13/2016 12:25 AM, Guenter Roeck wrote: >> Hi Marek, > > Hi! > >> On 11/12/2016 01:50 PM, Marek Vasut wrote: >>> On 11/07/2016 08:54 PM, Guenter Roeck wrote: Hi Marek, On 11/07/2016 10:14 AM, Marek Vasut wrote: > On 11/07/2016 0

Re: [Qemu-devel] [V6, 2/7] nios2: Add architecture emulation support

2016-11-13 Thread Marek Vasut
On 11/13/2016 12:25 AM, Guenter Roeck wrote: > Hi Marek, Hi! > On 11/12/2016 01:50 PM, Marek Vasut wrote: >> On 11/07/2016 08:54 PM, Guenter Roeck wrote: >>> Hi Marek, >>> >>> On 11/07/2016 10:14 AM, Marek Vasut wrote: On 11/07/2016 04:58 AM, Guenter Roeck wrote: > On Tue, Oct 25, 2016 a

Re: [Qemu-devel] Crashing in tcp_close

2016-11-13 Thread Brian Candler
On 12/11/2016 10:44, Samuel Thibault wrote: Oops, sorry, my patch was completely bogus, here is a proper one. Excellent. I've run the original build process 18 times (each run takes about 25 minutes) without valgrind, and it hasn't crashed once. So this looks good. Thank you! Regards, Bri

Re: [Qemu-devel] target-alpha mttcg success

2016-11-13 Thread Richard Henderson
On 11/13/2016 10:39 AM, Alex Bennée wrote: There does appear to be a problem with delivery of ISA interrupts for smp, regardless whether mttcg is enabled or not, though PCI interrupts are working fine. This appears in that both serial console and ps2 keyboard are non-responsive, but one can ssh

[Qemu-devel] [Bug 1338591] Re: Cursor jumps on shape change with vmware vga

2016-11-13 Thread Ruslan
Setting SDL_VIDEO_X11_DGAMOUSE=0 environment variable works around this problem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1338591 Title: Cursor jumps on shape change with vmware vga Status in

Re: [Qemu-devel] target-alpha mttcg success

2016-11-13 Thread Alex Bennée
Richard Henderson writes: >> PID USER PR NIVIRTRES S P %CPU %MEM TIME+ COMMAND >> 7817 rth 20 0 5304360 712404 R 3 94.4 9.1 2:45.21 qemu-system-alp >> 7819 rth 20 0 5304360 712404 R 1 90.7 9.1 2:01.84 qemu-system-alp >> 7818 rth 20 0 5304360 7