Re: [Qemu-devel] Asynchronous / synchronous IO emulation

2016-11-25 Thread Dong, Eddie
> > The usage is to construct a secondary hot standby VM (SVM), identical with > the primary VM (PVM). > > When an virtual DMA happens in PVM side, we need to know at which > instruction boundary the virtual DMA is delivered, so that we can replay the > virtual DMA event at the 2nd VM side, to

Re: [Qemu-devel] [PATCH v2 0/1] qemu: fix the bug reported by qemu-iotests case 055

2016-11-25 Thread Hao QingFeng
Sorry, missed Cc qemu-stable in this patch. 在 2016-11-26 13:46, QingFeng Hao 写道: Hi all, v2 includes changes due to review comments by Kevin Wolf(thanks to Kevin). v2: * Add endian conversion for lba field in vmdk_write_extent. Based on master's commit: 00227fefd205: Update version for

[Qemu-devel] [PATCH v2 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2016-11-25 Thread QingFeng Hao
The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image with original test.img. The cause is that buf_len in vmdk_write_extent wasn't converted to little-endian before it was stored to disk. But later vmdk_read_extent read it and converted it

[Qemu-devel] [PATCH v2 0/1] qemu: fix the bug reported by qemu-iotests case 055

2016-11-25 Thread QingFeng Hao
Hi all, v2 includes changes due to review comments by Kevin Wolf(thanks to Kevin). v2: * Add endian conversion for lba field in vmdk_write_extent. Based on master's commit: 00227fefd205: Update version for v2.8.0-rc1 release v1: * Add patch to fix the bug reported by qemu-iotests case 055.

[Qemu-devel] [PATCH v2] virtio-crypto: fix uninitialized variables

2016-11-25 Thread Gonglei
Though crypto_cfg.reserve is an unused field, let me initialize the structure in order to make coverity happy. *** CID 1365923: Uninitialized variables (UNINIT) /hw/virtio/virtio-crypto.c: 851 in virtio_crypto_get_config() 845 stl_le_p(_cfg.mac_algo_h, c->conf.mac_algo_h); 846

[Qemu-devel] [PATCH] virtio-crypto: fix uninitialized variables

2016-11-25 Thread Gonglei
Though crypto_cfg.reserve is an unused field, let me initialize it in order to make coverity happy. *** CID 1365923: Uninitialized variables (UNINIT) /hw/virtio/virtio-crypto.c: 851 in virtio_crypto_get_config() 845 stl_le_p(_cfg.mac_algo_h, c->conf.mac_algo_h); 846

Re: [Qemu-devel] [PATCH v10 07/12] virtio-crypto: set capacity of algorithms supported

2016-11-25 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Subject: Re: [Qemu-devel] [PATCH v10 07/12] virtio-crypto: set capacity of > algorithms supported > > Gonglei writes: > > > Expose the capacity of algorithms supported by > > virtio crypto device to the frontend

Re: [Qemu-devel] [RFCv2 00/12] Clean up compatibility mode handling

2016-11-25 Thread Greg Kurz
On Wed, 16 Nov 2016 09:17:43 +1100 David Gibson wrote: > This series is a significant rework to how we handle CPU compatibility > modes on ppc. > > * Information about compatibility modes was previously open coded and >scattered across a number of functions in

[Qemu-devel] [RFC v2 20/20] pc: Initialize default bus lists

2016-11-25 Thread Eduardo Habkost
Populate the always_available_buses list for the PC machines. This will allow qmp-machine-info.py to run in strict mode for x86. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Use the new machine_class_add_always_available_bus() function, include bus IDs * Report

[Qemu-devel] [RFC v2 19/20] pci: validate interfaces on base_class_init

2016-11-25 Thread Eduardo Habkost
Make sure we don't forget to add the legacy-PCI or PCIe interface names on any PCI device class. Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * (new patch added to series) --- hw/pci/pci.c | 12 1 file changed, 12 insertions(+) diff --git

[Qemu-devel] [RFC v2 16/20] [incomplete] remove INTERFACE_LEGACY_PCI_DEVICE from PCIe-only devices

2016-11-25 Thread Eduardo Habkost
With this, only vmxnet3, pvscsi, vfio-pci, virtio-pci kept both interfaces. TODO: The pci-bridge classes still need to be redone, see FIXME comments. Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * (new patch added to series) --- hw/block/nvme.c

[Qemu-devel] [RFC v2 14/20] [automated] Add INTERFACE_LEGACY_PCI_DEVICE to all PCI device subclasses

2016-11-25 Thread Eduardo Habkost
Automatically add INTERFACE_LEGACY_PCI_DEVICE to all (direct) 76 TYPE_PCI_DEVICE subclasses that use a static TypeInfo struct. This was done automatically using a script. The next patches will fix a few remaining cases. I will keep it in a separate patch on the RFC phase, but this will be

[Qemu-devel] [RFC v2 15/20] eepro100: Add INTERFACE_LEGACY_PCI_DEVICE

2016-11-25 Thread Eduardo Habkost
Dynamic TypeInfo initialization, not handled by the script used in the previous patch. Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * (new patch added to series) --- hw/net/eepro100.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/net/eepro100.c

[Qemu-devel] [RFC v2 12/20] pci: Replace is_express with INTERFACE_PCIE_DEVICE

2016-11-25 Thread Eduardo Habkost
This patch changes all devices that set is_express=1 to implement INTERFACE_PCIE_DEVICE, and remove the is_express field completely. Cc: Shmulik Ladkani Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Signed-off-by: Eduardo

[Qemu-devel] [RFC v2 10/20] pvscsi: Set PCIDeviceClass::is_express=1

2016-11-25 Thread Eduardo Habkost
pvscsi has a custom DeviceClass::realize method to ensure QEMU_PCI_CAP_EXPRESS is set before pci_qdev_realize() is called. This is done because setting the QEMU_PCI_CAP_EXPRESS flag too late can crash QEMU due to the PCI config space allocation logic. Clearing QEMU_PCI_CAP_EXPRESS later, on the

[Qemu-devel] [RFC v2 13/20] [trivial] edu: Move edu_info outside function

2016-11-25 Thread Eduardo Habkost
Follow the same style as other classes. Declaring the struct inside the function doesn't allow us to use the same type of declaration to set the interfaces array. Cc: Jiri Slaby Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * (new patch added

[Qemu-devel] [RFC v2 11/20] pci: INTERFACE_LEGACY_PCI_DEVICE and INTERFACE_PCIE_DEVICE interfaces

2016-11-25 Thread Eduardo Habkost
Those two interfaces will be used to indicate which device types support legacy PCI or PCI-express buses. Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * Replacing v1 patch: "pci: Introduce INTERFACE_PCIE_DEVICE interface name" * (new patch added to series)

[Qemu-devel] [RFC v2 09/20] vmxnet3: Set PCIDeviceClass::is_express=1

2016-11-25 Thread Eduardo Habkost
vmxnet3 has a custom DeviceClass::realize method to ensure QEMU_PCI_CAP_EXPRESS is set before pci_qdev_realize() is called. This is done because setting the QEMU_PCI_CAP_EXPRESS flag too late can crash QEMU due to the PCI config space allocation logic. Clearing QEMU_PCI_CAP_EXPRESS later, on the

[Qemu-devel] [RFC v2 07/20] qmp: Add 'always-available-buses' field to 'query-machines'

2016-11-25 Thread Eduardo Habkost
The new field will return a list MachineBusInfo structs, containing information about the buses that are always created by the machine (even if -nodefaults is used). Note that some machine options may enable or disable some bus types and affect the set of available buses. Introspection of those

[Qemu-devel] [RFC v2 08/20] virtio-pci: Set PCIDeviceClass::is_express=1

2016-11-25 Thread Eduardo Habkost
virtio-pci has a custom DeviceClass::realize method to ensure QEMU_PCI_CAP_EXPRESS is set before pci_qdev_realize() is called. This is done because setting the QEMU_PCI_CAP_EXPRESS flag too late can crash QEMU due to the PCI config space allocation logic. Clearing QEMU_PCI_CAP_EXPRESS later, on

[Qemu-devel] [RFC v2 17/20] pci: Set device_type on bus classes

2016-11-25 Thread Eduardo Habkost
The default device_type for for TYPE_PCI_BUS will be INTERFACE_LEGACY_PCI_DEVICE. The device_type for TYPE_PCIE_BUS will be INTERFACE_PCIE_DEVICE. Note that specific bus instances may still override accepted_device_types. See the comments added to the code. Signed-off-by: Eduardo Habkost

[Qemu-devel] [RFC v2 03/20] qtest.py: make logging optional

2016-11-25 Thread Eduardo Habkost
Support the 'logging' parameter on QEMUQtestMachine, for test cases that don't require logging. Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * (none) --- scripts/qtest.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [RFC v2 06/20] qdev: Add 'accepted-device-types' property to BusClass

2016-11-25 Thread Eduardo Habkost
Each bus class will now be aware of the specific device types that can be plugged on it. That will be useful for: * Runtime check for which devices types can be plugged to the machine; * Validation of query-machines output by automated tests. By default, a single type name is used on all bus

[Qemu-devel] [RFC v2 02/20] qtest.py: Support QTEST_LOG environment variable

2016-11-25 Thread Eduardo Habkost
qtest logs everything to stderr by default, but we don't want it to be the default behavior on test cases. Implement the same behavior of libqtest.c, and redirect the qtest log to /dev/null by default unless the QTEST_LOG environment variable is set. Signed-off-by: Eduardo Habkost

[Qemu-devel] [RFC v2 05/20] tests: Add rules to non-gtester qtest test cases

2016-11-25 Thread Eduardo Habkost
Today, simple non-gtester binaries can be run easily by a single Makefile rule (e.g. check-tests/qemu-iotest-quick.sh), but we don't have anything to help us automatically run the same test binary for multiple architectures. This add check-simpleqtest-* rules that will help us run binaries

[Qemu-devel] [RFC v2 18/20] q35: Hack to make root bus accept legacy PCI devices

2016-11-25 Thread Eduardo Habkost
I don't know where in the code this information should be encoded, so suggestions are welcome. Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * (new patch added to series) --- hw/pci-host/q35.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[Qemu-devel] [RFC v2 01/20] qemu.py: Make logging optional

2016-11-25 Thread Eduardo Habkost
If a test case doesn't make QEMU generate any output, there's no need to redirect stdout and stderr to a file. On those cases, logging can be disabled so any errors are included on the test case output. Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * (none) ---

[Qemu-devel] [RFC v2 00/20] qmp: Report bus information on 'query-machines'

2016-11-25 Thread Eduardo Habkost
Changes v1 -> v2: * v1 series subject was: "qmp: Report supported device types on 'query-machines'" * Now we return additional bus information: bus ID, bus type, and the list of accepted device types on each bus * Now hotplug can be covered because accepted-device-types can be set by

[Qemu-devel] [RFC v2 04/20] qtest.py: Make 'binary' parameter optional

2016-11-25 Thread Eduardo Habkost
If the 'binary' parameter is omitted, use the $QTEST_QEMU_BINARY environment variable. Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * (none) --- scripts/qtest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/qtest.py

[Qemu-devel] [PULL 0/1] Coverity fix on target-i386

2016-11-25 Thread Eduardo Habkost
The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/x86-pull-request for you to fetch changes up to

[Qemu-devel] [PULL 1/1] target-i386: Remove unused local_err variable

2016-11-25 Thread Eduardo Habkost
local_err can never be set to non-NULL. Remove the variable. Detected by Coverity: *** CID 1365201: Possible Control flow issues (DEADCODE) /target-i386/cpu.c: 2050 in x86_cpu_parse_featurestr() 2044 prop->value = g_strdup(val); 2045 prop->errp = _fatal;

[Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros

2016-11-25 Thread Yuval Shaia
Use generic declaration of min and max macros instead of private ones. Signed-off-by: Yuval Shaia --- disas/m68k.c | 4 slirp/dhcpv6.c | 2 +- slirp/ip6_icmp.c | 2 +- slirp/slirp.c | 2 +- slirp/slirp.h | 5 - slirp/tcp_input.c | 14

[Qemu-devel] QEMU soundcards vulnerable to jack retasking?

2016-11-25 Thread bancfc
Recent security research shows that soundcards support surreptitiously switching line-out jacks into line-in by modifying the software stack. The way modern speakers and headphones are designed makes them readily usable as microphones. The Intel High Definition (HD) Audio standards which all

[Qemu-devel] Problems with qemu "modern" virtio on sparc64

2016-11-25 Thread Guenter Roeck
Hi, I am using virtio on sparc64 for my Linux kernel runtime tests. Starting with qemu v2.7, I noticed that the kernel either gets stuck or crashes. After adding some debug information to the kernel, I found that the problem happens in vp_reset(). Interestingly, when running v4.9-rc6 without

Re: [Qemu-devel] [PATCH v2] pci-assign: sync MSI/MSI-X cap and table with PCIDevice

2016-11-25 Thread Michael S. Tsirkin
On Fri, Nov 25, 2016 at 10:55:22AM +0800, Peter Xu wrote: > Since commit e1d4fb2d ("kvm-irqchip: x86: add msi route notify fn"), > kvm_irqchip_add_msi_route() starts to use pci_get_msi_message() to fetch > MSI info. This requires that we setup MSI related fields in PCIDevice. > For most devices,

Re: [Qemu-devel] [Bug in qemu-system-ppc running Mac OS 9 on Windows 10]

2016-11-25 Thread Howard Spoelstra
>> Hi all, >> >> I've been experiencing issues when installing Mac OS 9.x using >> qemu-system-ppc.exe in Windows 10. After booting from CD image, >> partitioning a fresh disk image often hangs Qemu. When using a >> pre-partitioned disk image, the OS installation process halts >> somewhere during

Re: [Qemu-devel] sane char device writes?

2016-11-25 Thread Paolo Bonzini
On 24/11/2016 08:51, Thomas Huth wrote: > > So for this to work an extra buffer would have to be stored in gtk.c > > somewhere, and possibly similar timer trick used as in console.c > > > > Any ideas how to do this without introducing too much insanity? > > > > Presumably using a GTK timer for

[Qemu-devel] [Bug in qemu-system-ppc running Mac OS 9 on Windows 10]

2016-11-25 Thread G 3
On Nov 25, 2016, at 9:26 AM, qemu-devel-requ...@nongnu.org wrote: Hi all, I've been experiencing issues when installing Mac OS 9.x using qemu-system-ppc.exe in Windows 10. After booting from CD image, partitioning a fresh disk image often hangs Qemu. When using a pre-partitioned disk image,

[Qemu-devel] [PATCH] MAINTAINERS: Update xen-devel mailing list address

2016-11-25 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4a60579..1379317 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -309,7 +309,7 @@ Guest CPU Cores (Xen): X86 M: Stefano

Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

2016-11-25 Thread Markus Armbruster
Yuval Shaia writes: > Signed-off-by: Yuval Shaia > --- > disas/m68k.c | 5 + > include/qemu/cutils.h | 3 +++ > slirp/slirp.h | 6 +- > 3 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/disas/m68k.c

[Qemu-devel] [PATCH] target-i386: Remove unused local_err variable

2016-11-25 Thread Eduardo Habkost
local_err can never be set to non-NULL. Remove the variable. Detected by Coverity: *** CID 1365201: Possible Control flow issues (DEADCODE) /target-i386/cpu.c: 2050 in x86_cpu_parse_featurestr() 2044 prop->value = g_strdup(val); 2045 prop->errp = _fatal;

Re: [Qemu-devel] [PATCH v10 07/12] virtio-crypto: set capacity of algorithms supported

2016-11-25 Thread Markus Armbruster
Gonglei writes: > Expose the capacity of algorithms supported by > virtio crypto device to the frontend driver using > pci configuration space. > > Signed-off-by: Gonglei > --- > hw/virtio/virtio-crypto.c | 43 >

Re: [Qemu-devel] [PATCH v10 07/10] hbitmap: serialization

2016-11-25 Thread Markus Armbruster
John Snow writes: > From: Vladimir Sementsov-Ogievskiy > > Functions to serialize / deserialize(restore) HBitmap. HBitmap should be > saved to linear sequence of bits independently of endianness and bitmap > array element (unsigned long) size.

[Qemu-devel] [Bug 1644754] [NEW] gluster partial reads refusal conflicts with qcow2

2016-11-25 Thread flumm
Public bug reported: there is an inconsistency in how qemu creates qcow2 files, which causes an error in the gluster (and possibly other block drivers) the problem is that the gluster backend expects the filesize to be 512 byte aligned, which is not the case anymore since 2.7.0 when using the

[Qemu-devel] [PATCH] cutils: Define min and max marcos

2016-11-25 Thread Yuval Shaia
Signed-off-by: Yuval Shaia --- disas/m68k.c | 5 + include/qemu/cutils.h | 3 +++ slirp/slirp.h | 6 +- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/disas/m68k.c b/disas/m68k.c index 8e7c3f7..7794abc 100644 --- a/disas/m68k.c +++

Re: [Qemu-devel] [PATCH v5 05/12] target-i386: Make plus_features/minus_features QOM-based

2016-11-25 Thread Markus Armbruster
Eduardo Habkost writes: > Instead of using custom feature name lookup code for > plus_features/minus_features, save the property names used in > "[+-]feature" and use object_property_set_bool() to set them. > > We don't need a feat2prop() call because we now have alias >

Re: [Qemu-devel] [kvm-unit-tests PATCH v11 1/3] arm: Add PMU test

2016-11-25 Thread Andre Przywara
Hi, On 25/11/16 14:26, Andrew Jones wrote: > On Fri, Nov 25, 2016 at 12:32:24PM +, Andre Przywara wrote: >> Hi Drew, >> >> >> >> On 23/11/16 17:15, Andrew Jones wrote: > + > +#if defined(__arm__) I guess you should use the arch specific header files we have in place

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-11-25 Thread Andrea Bolognani
On Wed, 2016-11-23 at 16:02 +1100, David Gibson wrote: > > > The change from OHCI to XHCI only affected the *default* USB > > > controller, which libvirt tries its best not to use anyway: > > > instead, it will prefer to use '-M ...,usb=off' along with > > > '-device ...' and set both the

Re: [Qemu-devel] [PATCH v3 11/11] tcg-mips: Adjust condition functions for mips64

2016-11-25 Thread Aurelien Jarno
On 2016-11-25 13:06, Richard Henderson wrote: > On 11/25/2016 04:31 AM, Jin Guojie wrote: > > 32-bit condition functions(like brcond_i32) should only > > compare the low half parts of two 64-bit host registers. > > However, MIPS64 does not have distinct instruction for > > such operation. The

Re: [Qemu-devel] [kvm-unit-tests PATCH v11 1/3] arm: Add PMU test

2016-11-25 Thread Andrew Jones
On Fri, Nov 25, 2016 at 12:32:24PM +, Andre Przywara wrote: > Hi Drew, > > > > On 23/11/16 17:15, Andrew Jones wrote: > >>> + > >>> +#if defined(__arm__) > >> > >> I guess you should use the arch specific header files we have in place > >> for that (lib/arm{.64}/asm/processor.h). Also

Re: [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI

2016-11-25 Thread Igor Mammedov
On Fri, 25 Nov 2016 13:31:17 +0100 Laszlo Ersek wrote: > On 11/25/16 05:00, Michael S. Tsirkin wrote: > > On Thu, Nov 24, 2016 at 09:37:41AM +0100, Laszlo Ersek wrote: > >> On 11/24/16 05:29, Michael S. Tsirkin wrote: > >>> On Wed, Nov 23, 2016 at 07:38:35PM -0500, Kevin

Re: [Qemu-devel] [PATCH v3 00/11] tcg mips64 and mips r6 improvements

2016-11-25 Thread Aurelien Jarno
On 2016-11-25 11:31, Jin Guojie wrote: > Changes since v2: > * Update against master(v2.8.0-rc1) > * Tested on Loongson as mips32r2(el) and mips64r2(el) hosts. > Loongson only implements little-endian mips32/mips64 ISA. > * Fully work for 32-bit and 64-bit guests. > Fix two

Re: [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI

2016-11-25 Thread Igor Mammedov
On Fri, 25 Nov 2016 03:55:29 -0500 (EST) Paolo Bonzini wrote: > > > Parked CPUs are exactly how it works on real hardware (the arbitrator is > > > the > > > BMC, while we have QEMU in its place). The problem is that, if you just > > > place the hotplugged CPU in reset

Re: [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-25 Thread Stefan Hajnoczi
On Fri, Nov 25, 2016 at 02:28:16PM +0300, Vladimir Sementsov-Ogievskiy wrote: > With the availability of sparse storage formats, it is often needed > to query status of a particular range and read only those blocks of > data that are actually present on the block device. > > To provide such

Re: [Qemu-devel] [PATCH for-2.8 v1 1/1] block/vmdk: Fix the endian problem of buf_len

2016-11-25 Thread Hao QingFeng
在 2016-11-25 20:05, Kevin Wolf 写道: Am 25.11.2016 um 11:48 hat Hao QingFeng geschrieben: 在 2016-11-25 18:21, Kevin Wolf 写道: [ Cc: Fam, qemu-stable ] Am 25.11.2016 um 11:06 hat QingFeng Hao geschrieben: The problem was triggered by qemu-iotests case 055. It failed when it was comparing the

Re: [Qemu-devel] [PATCH 6/7] hw: xilinx-pcie: Add support for Xilinx AXI PCIe Controller

2016-11-25 Thread Yongbok Kim
On 19/08/2016 20:09, Paul Burton wrote: > Add support for emulating the Xilinx AXI Root Port Bridge for PCI > Express as described by Xilinx' PG055 document. This is a PCIe > controller that can be used with certain series of Xilinx FPGAs, and is > used on the MIPS Boston board which will make

Re: [Qemu-devel] [PATCH for-2.9 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2016-11-25 Thread Andrea Bolognani
On Wed, 2016-11-23 at 14:02 +0200, Marcel Apfelbaum wrote: > The Generic Root Port behaves the same as the > Intel's IOH device with id 3420, without having > Intel specific attributes. >  > The device has two purposes: >  (1) Can be used on both X86 and ARM machines. >  (2) It will allow us to

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-11-25 Thread Andrea Bolognani
On Wed, 2016-11-23 at 16:00 +1100, David Gibson wrote: > > Existing libvirt versions assume that pseries guests have > > a legacy PCI root bus, and will base their PCI address > > allocation / PCI topology decisions on that fact: they > > will, for example, use legacy PCI bridges. >  > Um.. yeah..

[Qemu-devel] [Bug in qemu-system-ppc running Mac OS 9 on Windows 10]

2016-11-25 Thread Howard Spoelstra
Hi all, I've been experiencing issues when installing Mac OS 9.x using qemu-system-ppc.exe in Windows 10. After booting from CD image, partitioning a fresh disk image often hangs Qemu. When using a pre-partitioned disk image, the OS installation process halts somewhere during the process. The

Re: [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI

2016-11-25 Thread Laszlo Ersek
On 11/25/16 13:31, Laszlo Ersek wrote: > On 11/25/16 05:00, Michael S. Tsirkin wrote: >> On Thu, Nov 24, 2016 at 09:37:41AM +0100, Laszlo Ersek wrote: >>> On 11/24/16 05:29, Michael S. Tsirkin wrote: On Wed, Nov 23, 2016 at 07:38:35PM -0500, Kevin O'Connor wrote: > As a general comment -

Re: [Qemu-devel] [kvm-unit-tests PATCH v11 1/3] arm: Add PMU test

2016-11-25 Thread Andre Przywara
Hi Drew, On 23/11/16 17:15, Andrew Jones wrote: >>> + >>> +#if defined(__arm__) >> >> I guess you should use the arch specific header files we have in place >> for that (lib/arm{.64}/asm/processor.h). Also there are sysreg read >> wrappers (at least for arm64) in there already, can't we

Re: [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI

2016-11-25 Thread Laszlo Ersek
On 11/25/16 05:00, Michael S. Tsirkin wrote: > On Thu, Nov 24, 2016 at 09:37:41AM +0100, Laszlo Ersek wrote: >> On 11/24/16 05:29, Michael S. Tsirkin wrote: >>> On Wed, Nov 23, 2016 at 07:38:35PM -0500, Kevin O'Connor wrote: As a general comment - it does seem unfortunate that we keep

Re: [Qemu-devel] [PULL 0/3] M68k for 2.8 patches

2016-11-25 Thread Stefan Hajnoczi
On Thu, Nov 24, 2016 at 04:28:04PM +0100, Laurent Vivier wrote: > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are available in the git repository at: > >

Re: [Qemu-devel] Asynchronous / synchronous IO emulation

2016-11-25 Thread Stefan Hajnoczi
On Fri, Nov 25, 2016 at 09:17:08AM +, Dong, Eddie wrote: > > On Thu, Nov 24, 2016 at 08:44:06AM +, Dong, Eddie wrote: > > > Under certain situation, we have a requirement to apply the > > virtual DMA event in a deterministic way. Current Qemu uses asynchronous > > approach to

Re: [Qemu-devel] [PATCH v3 11/11] tcg-mips: Adjust condition functions for mips64

2016-11-25 Thread Richard Henderson
On 11/25/2016 04:31 AM, Jin Guojie wrote: 32-bit condition functions(like brcond_i32) should only compare the low half parts of two 64-bit host registers. However, MIPS64 does not have distinct instruction for such operation. The operands should be sign extended to fit the case. Gcc handles

Re: [Qemu-devel] [PATCH for-2.8 v1 1/1] block/vmdk: Fix the endian problem of buf_len

2016-11-25 Thread Kevin Wolf
Am 25.11.2016 um 11:48 hat Hao QingFeng geschrieben: > 在 2016-11-25 18:21, Kevin Wolf 写道: > >[ Cc: Fam, qemu-stable ] > > > >Am 25.11.2016 um 11:06 hat QingFeng Hao geschrieben: > >>The problem was triggered by qemu-iotests case 055. It failed when it > >>was comparing the compressed vmdk image

[Qemu-devel] [PATCH for-2.8 3/5] 9pfs: always free fids in virtfs_reset()

2016-11-25 Thread Greg Kurz
All PDU that may hold a reference on a fid have been cancelled: we can therefore free all the fids. Signed-off-by: Greg Kurz --- hw/9pfs/9p.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 3a48cdcdf975..75c6645de9ac

Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf()

2016-11-25 Thread Stefan Hajnoczi
On Thu, Nov 24, 2016 at 12:07:44PM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > programmingk...@gmail.com[*] reported a runtime failure on a > > 32-bit Mac OS compilation, where "%"PRId64 expands to "%qd". > > Fortunately, we had very few spots that were relying

[Qemu-devel] [PATCH for-2.8 2/5] 9pfs: cancel active PDUs in virtfs_reset()

2016-11-25 Thread Greg Kurz
According to the 9P spec [1], the version operation should abort any outstanding I/O, so that a new session may be started in a clean state. This also makes sense in case of reset: we don't want to keep stale state around. This patch modifies virtfs_reset() which is called in both cases, so that

Re: [Qemu-devel] [PATCH v3 10/11] tcg-mips: Adjust qemu_ld/st for mips64

2016-11-25 Thread Richard Henderson
On 11/25/2016 04:31 AM, Jin Guojie wrote: -#define LO_OFF(MIPS_BE * 4) -#define HI_OFF(4 - LO_OFF) +# define LO_OFF (MIPS_BE * sizeof(long)) +# define HI_OFF (sizeof(long) - LO_OFF) For n32, sizeof(long) == 4, and for n64, sizeof(long) == 8. So in the end this change must be wrong

[Qemu-devel] [PATCH for-2.8 5/5] 9pfs: clear migration blocker when resetting the device

2016-11-25 Thread Greg Kurz
The migration blocker survives a machine reset: if the guest mounts a 9p share and then gets rebooted with system_reset, it will be unmigratable until it remounts and umounts the 9p share again. This happens because the blocker gets freed in put_fid(), whereas virtfs_reset() calls free_fid()

[Qemu-devel] [PATCH for-2.8 4/5] 9pfs: drop useless loop in v9fs_reset()

2016-11-25 Thread Greg Kurz
We don't need to wait for the PDU active list to be empty: virtfs_reset() already takes care of that. Signed-off-by: Greg Kurz --- hw/9pfs/9p.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index

[Qemu-devel] [PATCH for-2.8 1/5] 9pfs: add missing coroutine_fn annotations

2016-11-25 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/9pfs/9p.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index aea7e9d39206..e4815a97922d 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -1571,7 +1571,7 @@ out_nofid: v9fs_string_free();

[Qemu-devel] [PATCH for-2.8 0/5] 9pfs: fix session reset

2016-11-25 Thread Greg Kurz
This series addresses two issues we currently have: 1) the version operation only does a partial cleanup of a previously active session. It can leave unfinished PDUs and stale fids behind. This violates the 9p specification. 2) if a guest mounts a 9p share and is then resetted with

[Qemu-devel] [PATCH 1/4] qcow2: Make qcow2_cache_table_release() work only in Linux

2016-11-25 Thread Alberto Garcia
We are using QEMU_MADV_DONTNEED to discard the memory of individual L2 cache tables. The problem with this is that those semantics are specific to the Linux madvise() system call. Other implementations of madvise() (including the very Linux implementation of posix_madvise()) don't do that, so we

[Qemu-devel] [PATCH 2/4] qcow2: Allow 'cache-clean-interval' in Linux only

2016-11-25 Thread Alberto Garcia
The cache-clean-interval option of qcow2 only works on Linux. However we allow setting it in other systems regardless of whether it works or not. In those systems this option is not simply a no-op: it actually invalidates perfectly valid cache tables for no good reason without freeing their

Re: [Qemu-devel] [PATCH v4 07/64] tcg/i386: Implement field extraction opcodes

2016-11-25 Thread Richard Henderson
On 11/25/2016 12:16 PM, Paolo Bonzini wrote: On 23/11/2016 14:01, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 12 +--- tcg/i386/tcg-target.inc.c | 38 ++ 2 files changed, 47

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-25 Thread Stefan Hajnoczi
On Fri, Nov 25, 2016 at 08:27:26AM +, Ketan Nilangekar wrote: > On 11/24/16, 9:38 PM, "Stefan Hajnoczi" wrote: > On Thu, Nov 24, 2016 at 11:31:14AM +, Ketan Nilangekar wrote: > > On 11/24/16, 4:41 PM, "Stefan Hajnoczi" wrote: > > On

Re: [Qemu-devel] [PATCH v3] target-ppc: add vextu[bhw][lr]x instructions

2016-11-25 Thread Richard Henderson
On 11/25/2016 10:34 AM, Nikunj A Dadhania wrote: +return int128_rshift(b->s128, index) & \ +MAKE_64BIT_MASK(0, size); \ Please test compilation with i686-linux. You need a call to int128_getlo to extract the low 64-bit

[Qemu-devel] [PATCH 4/4] docs: Specify that cache-clean-interval is only supported in Linux

2016-11-25 Thread Alberto Garcia
Make it clear that having Linux is a hard requirement for this feature. Signed-off-by: Alberto Garcia --- docs/qcow2-cache.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt index 5bb0607..1fdd6f9 100644 ---

[Qemu-devel] [PATCH 3/4] qcow2: Remove stale comment

2016-11-25 Thread Alberto Garcia
We haven't been using CONFIG_MADVISE since 02d0e095031b7fda77de8b Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index ab8ee2d..1d25147 100644 --- a/block/qcow2-cache.c +++

[Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-25 Thread Vladimir Sementsov-Ogievskiy
With the availability of sparse storage formats, it is often needed to query status of a particular range and read only those blocks of data that are actually present on the block device. To provide such information, the patch adds the BLOCK_STATUS extension with one new NBD_CMD_BLOCK_STATUS

[Qemu-devel] [PATCH for-2.8 0/4] Allow 'cache-clean-interval' in Linux only

2016-11-25 Thread Alberto Garcia
Hi all, The cache-clean-interval setting of qcow2 frees the memory of the L2 cache tables that haven't been used after a certain interval of time. QEMU uses madvise() with MADV_DONTNEED for this. After that call, the data in the specified cache tables is discarded by the kernel. The problem with

Re: [Qemu-devel] [PATCH v4 07/64] tcg/i386: Implement field extraction opcodes

2016-11-25 Thread Paolo Bonzini
On 23/11/2016 14:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/i386/tcg-target.h | 12 +--- > tcg/i386/tcg-target.inc.c | 38 ++ > 2 files changed, 47 insertions(+), 3 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 1/2] target-ppc: add vextu[bhw]lx instructions

2016-11-25 Thread Richard Henderson
On 11/25/2016 08:13 AM, Nikunj A Dadhania wrote: I think I can use "Int128 u128" in that union and that should do the trick ! I will try that out. Yes, that's what I meant. r~

Re: [Qemu-devel] [PATCH for-2.8 v1 1/1] block/vmdk: Fix the endian problem of buf_len

2016-11-25 Thread Hao QingFeng
在 2016-11-25 18:21, Kevin Wolf 写道: [ Cc: Fam, qemu-stable ] Am 25.11.2016 um 11:06 hat QingFeng Hao geschrieben: The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image with original test.img. The cause is that buf_len in

Re: [Qemu-devel] [PULL-for 2.8] Update OpenBIOS images

2016-11-25 Thread Stefan Hajnoczi
On Thu, Nov 24, 2016 at 09:41:09PM +, Mark Cave-Ayland wrote: > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH for-2.8 v1 1/1] block/vmdk: Fix the endian problem of buf_len

2016-11-25 Thread Kevin Wolf
[ Cc: Fam, qemu-stable ] Am 25.11.2016 um 11:06 hat QingFeng Hao geschrieben: > The problem was triggered by qemu-iotests case 055. It failed when it > was comparing the compressed vmdk image with original test.img. > > The cause is that buf_len in vmdk_write_extent wasn't converted to >

Re: [Qemu-devel] [PATCH v1 05/18] tests/test-rbcache: add test cases

2016-11-25 Thread Kevin Wolf
Am 25.11.2016 um 10:58 hat Pavel Butsykin geschrieben: > On 24.11.2016 15:20, Kevin Wolf wrote: > >Visualised, we test these requests: > > > >1: * > >2: ** > >3:* > >4:*** > >5: > > > >You test inserting the only element, inserting after the last element, >

[Qemu-devel] [PATCH v2 3/3] xen: ignore direction in bufioreq handling

2016-11-25 Thread Jan Beulich
There's no way to communicate back read data, so only writes can ever be usefully specified. Ignore the field, paving the road for eventually re-using the bit for something else in a few (many?) years time. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant

Re: [Qemu-devel] [PATCH v2 1/3] xen: fix quad word bufioreq handling

2016-11-25 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 25 November 2016 10:06 > To: qemu-devel@nongnu.org > Cc: Anthony Perard ; Paul Durrant > ; Stefano Stabellini ; xen- > devel

[Qemu-devel] [PATCH v1 1/1] block/vmdk: Fix the endian problem of buf_len

2016-11-25 Thread QingFeng Hao
The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image with original test.img. The cause is that buf_len in vmdk_write_extent wasn't converted to little-endian before it was stored to disk. But later vmdk_read_extent read it and converted it

[Qemu-devel] [PATCH v1 0/1] qemu: fix the bug reported by qemu-iotests case 055

2016-11-25 Thread QingFeng Hao
Hi all, This patch is to fix the bug reported by qemu-iotests case 055 and based on upstream master's commit: 00227fefd205: Update version for v2.8.0-rc1 release Jing Liu and I found the cause was in vmdk and the fix is in the followed patch. Thanks! Upstream master's qemu-iotests case 055

[Qemu-devel] [PATCH v2 2/3] xen: slightly simplify bufioreq handling

2016-11-25 Thread Jan Beulich
There's no point setting fields always receiving the same value on each iteration, as handle_ioreq() doesn't alter them anyway. Set state and count once ahead of the loop, drop the redundant clearing of data_is_ptr, and avoid the meaningless setting of df altogether. Also avoid doing an unsigned

[Qemu-devel] [PATCH v2 1/3] xen: fix quad word bufioreq handling

2016-11-25 Thread Jan Beulich
We should not consume the second slot if it didn't get written yet. Normal writers - i.e. Xen - would not update write_pointer between the two writes, but the page may get fiddled with by the guest itself, and we're better off avoiding to enter an infinite loop in that case. Reported-by:

[Qemu-devel] [PATCH v2 0/3] xen: XSA-197 follow-ups

2016-11-25 Thread Jan Beulich
1: fix quad word bufioreq handling 2: slightly simplify bufioreq handling 3: ignore direction in bufioreq handling Signed-off-by: Jan Beulich --- v2: Only patch 1 changed; see there.

Re: [Qemu-devel] [PATCH v1 05/18] tests/test-rbcache: add test cases

2016-11-25 Thread Pavel Butsykin
On 24.11.2016 15:20, Kevin Wolf wrote: Am 15.11.2016 um 07:37 hat Pavel Butsykin geschrieben: Signed-off-by: Pavel Butsykin --- tests/Makefile.include | 3 + tests/test-rbcache.c | 308 + 2 files changed, 311

Re: [Qemu-devel] [PATCH v6 0/2] GICv3 live migration support

2016-11-25 Thread Auger Eric
Hi Vijay, Christoffer, On 23/11/2016 13:39, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > This series introduces support for GICv3 live migration with > new VGIC implementation in 4.7-rc3 kernel. > In this series, patch 1 of the previous implementation > are

Re: [Qemu-devel] [PATCH v6 1/4] kernel: Add definitions for GICv3 attributes

2016-11-25 Thread Christoffer Dall
On Fri, Nov 25, 2016 at 02:12:12PM +0530, Vijay Kilari wrote: > On Fri, Nov 25, 2016 at 1:27 PM, Auger Eric wrote: > > Hi Vijay, > > > > On 23/11/2016 13:39, vijay.kil...@gmail.com wrote: > >> From: Vijaya Kumar K > >> > >> This temporary patch

[Qemu-devel] [PATCH v3] target-ppc: add vextu[bhw][lr]x instructions

2016-11-25 Thread Nikunj A Dadhania
From: Avinesh Kumar vextublx: Vector Extract Unsigned Byte Left vextuhlx: Vector Extract Unsigned Halfword Left vextuwlx: Vector Extract Unsigned Word Left vextubrx: Vector Extract Unsigned Byte Right-Indexed VX-form vextuhrx: Vector Extract Unsigned Halfword

  1   2   >