I recently upgraded to Fedora 25 which runs Wayland by default.
The GTK UI is now sending unknown keycodes to the guests. Although
alphanumeric keys work, the cursor keys are broken.
There is X11-specific code for keycode mapping in ui/gtk.c. Perhaps
something is needed to make that work under
On 30/11/16 21:11, morgenlette madeBy wrote:
> Hello
>
> I am studnet studying QEMU.
>
> I have a question open in QEMU.
>
> In function handle_aiocb_rw_linear() in block/raw-posix.c,
>
> i tried to open my device driver(mydev).
>
> this driver was confirmed safe operation by test program.
>
Say it in another way to make it easier to understand.
Signed-off-by: Zhang Chen
Signed-off-by: Eric Blake
Signed-off-by: Stefan Weil
---
docs/colo-proxy.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
On 2016年11月28日 23:51, Aviv B.D wrote:
> From: "Aviv Ben-David"
>
> * Advertize Cache Mode capability in iommu cap register.
> This capability is controlled by "cache-mode" property of intel-iommu
> device.
> To enable this option call QEMU with "-device
We can call this qmp command to start/stop replication outside of qemu.
Like Xen colo need this function.
Signed-off-by: Zhang Chen
Signed-off-by: Wen Congyang
---
docs/qmp-commands.txt | 17 +
migration/colo.c | 22
We can call this qmp command to do checkpoint outside of qemu.
Like Xen colo need this function.
Signed-off-by: Zhang Chen
Signed-off-by: Wen Congyang
---
docs/qmp-commands.txt | 24
migration/colo.c | 10
Xen need't this.
Signed-off-by: Zhang Chen
Signed-off-by: Wen Congyang
---
migration/savevm.c | 4
1 file changed, 4 insertions(+)
diff --git a/migration/savevm.c b/migration/savevm.c
index 0363372..bec6c7e 100644
---
Xen COLO depend on qemu COLO replication function.
So, We need new qmp commands for Xen to use qemu replication.
Zhang Chen (3):
Migration: Don't load vmdesc when xen is enabled
Add a new qmp command to start/stop replication
Add a new qmp command to do checkpoint, get replication error
On 30/11/16 16:36, Alastair D'Silva wrote:
> From: Alastair D'Silva
>
> This patch adds support for the Epson RX8900 I2C RTC.
>
> The following chip features are implemented:
> - RTC (wallclock based, ptimer 10x oversampling to pick up
> wallclock transitions)
> -
Signed-off-by: Pranith Kumar
---
tests/tcg/i386/litmus/Makefile | 42 ++
tests/tcg/i386/litmus/README.txt| 22 +
tests/tcg/i386/litmus/SAL.c | 491 +++
tests/tcg/i386/litmus/affinity.c| 159 +
tests/tcg/i386/litmus/affinity.h|
On 11/25/2016 08:26 AM, Andrew Jones wrote:
> On Fri, Nov 25, 2016 at 12:32:24PM +, Andre Przywara wrote:
>> Hi Drew,
>>
>>
>>
>> On 23/11/16 17:15, Andrew Jones wrote:
> +
> +#if defined(__arm__)
I guess you should use the arch specific header files we have in place
This patch defines four macros to assist creating system register
accessors under both ARMv7 and AArch64:
* DEFINE_GET_SYSREG32(name, ...)
* DEFINE_SET_SYSREG32(name, ...)
* DEFINE_GET_SYSREG64(name, ...)
* DEFINE_SET_SYSREG64(name, ...)
These macros are translated to inline functions
Signed-off-by: Pranith Kumar
---
.travis.yml | 8
1 file changed, 8 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index 9916178..881c525 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -99,6 +99,7 @@ matrix:
before_install:
- sudo apt-get
Signed-off-by: Pranith Kumar
---
tests/tcg/i386/test-i386.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tcg/i386/test-i386.c b/tests/tcg/i386/test-i386.c
index b0f8975..6a11c2f 100644
--- a/tests/tcg/i386/test-i386.c
+++
From: Christopher Covington
Calculate the numbers of cycles per instruction (CPI) implied by ARM
PMU cycle counter values. The code includes a strict checking facility
intended for the -icount option in TCG mode in the configuration file.
Signed-off-by: Christopher
Hello,
The following patch series adds litmus tests to test consistency for
MTTCG enabled qemu. These patches apply on top of the clean up
tests/tcg folder made by my previous patch series.
The tests were generated using the litmus tool. The sources and
instructions on how to generate these
Signed-off-by: Pranith Kumar
---
tests/tcg/Makefile | 156
tests/tcg/i386/Makefile | 88 ++
tests/tcg/{ => i386}/hello-i386.c | 0
tests/tcg/{ => i386}/pi_10.com | Bin
From: Christopher Covington
Ensure that reads of the PMCCNTR_EL0 are monotonically increasing,
even for the smallest delta of two subsequent reads.
Signed-off-by: Christopher Covington
Signed-off-by: Wei Huang
Reviewed-by: Andrew
Include a missing header and rename the function names to avoid
definition mis-match.
Signed-off-by: Pranith Kumar
---
tests/tcg/hello-i386.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tests/tcg/hello-i386.c b/tests/tcg/hello-i386.c
index
From: Christopher Covington
Beginning with a simple sanity check of the control register, add
a unit test for the ARM Performance Monitors Unit (PMU). PMU register
was read using the newly defined macros.
Signed-off-by: Christopher Covington
Signed-off-by: Pranith Kumar
---
tests/tcg/misc/Makefile | 81 +++
tests/tcg/{ => misc}/linux-test.c | 0
tests/tcg/{ => misc}/sha1.c | 0
tests/tcg/{ => misc}/test-mmap.c | 0
tests/tcg/{ => misc}/test_path.c | 0
Changes from v12:
* Define macros for system register accessors
* Re-write PMU code using the newly-defined macros
* Code tested under both AArch32 and AArch64 modes
Note:
1) Current KVM code has bugs in handling PMCCFILTR write. A fix (see
below) is required for this unit testing code to work
Signed-off-by: Pranith Kumar
---
tests/tcg/linux-test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/tcg/linux-test.c b/tests/tcg/linux-test.c
index 24fce2b..e676e39 100644
--- a/tests/tcg/linux-test.c
+++ b/tests/tcg/linux-test.c
@@ -41,6 +41,8 @@
#include
Signed-off-by: Pranith Kumar
---
tests/tcg/{ => mips}/hello-mips.c | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename tests/tcg/{ => mips}/hello-mips.c (100%)
diff --git a/tests/tcg/hello-mips.c b/tests/tcg/mips/hello-mips.c
similarity index 100%
rename from
From: Marc-André Lureau
This test doesn't depend on glib, and thus cannot use osdep.h.
Signed-off-by: Marc-André Lureau
Signed-off-by: Pranith Kumar
---
tests/tcg/test-i386-fprem.c | 6 +-
1 file changed, 5
This commit fixes the makefiles to bring them to the desired state.
Signed-off-by: Pranith Kumar
---
tests/tcg/alpha/Makefile | 38 +++--
tests/tcg/arm/Makefile | 32 +++--
tests/tcg/cris/Makefile
Signed-off-by: Pranith Kumar
---
tests/tcg/i386/Makefile | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/tcg/i386/Makefile b/tests/tcg/i386/Makefile
index 15f77af..97c1a97 100644
--- a/tests/tcg/i386/Makefile
+++ b/tests/tcg/i386/Makefile
Signed-off-by: Pranith Kumar
---
tests/tcg/arm/Makefile| 45 +++
tests/tcg/{ => arm}/hello-arm.c | 0
tests/tcg/{ => arm}/test-arm-iwmmxt.s | 0
3 files changed, 45 insertions(+)
create mode 100644
From: Marc-André Lureau
The previous value of the timer indicates the time to the next timer
expiration, which is likely not the same as when the timer was set.
Signed-off-by: Marc-André Lureau
Signed-off-by: Pranith Kumar
From: Marc-André Lureau
Fixes the following compiler warning:
tests/tcg/test-i386.c:2110:1: warning: specifying vector types with
__attribute__ ((mode)) is deprecated [-Wattributes]
typedef int __m64 __attribute__ ((__mode__ (__V2SI__)));
^~~
Signed-off-by:
From: Marc-André Lureau
- QEMU_INCLUDES because it uses qemu/include
- stdbool, for the bool usage
- sys/resource.h for rusage and friends
- qemu/compiler.h because it is no longer included in fprintf-fn.h
(we may want to include it from qemu/cutils.h instead)
You can call 'make tests-tcg' to build and run native tcg tests.
Signed-off-by: Pranith Kumar
---
tests/Makefile.include | 1 +
tests/tcg/Makefile.include | 33 +
2 files changed, 34 insertions(+)
create mode 100644
Hello,
This patch series cleans up the tcg tests in tests/tcg folder.
The tests have bit-rotten and were not compiling or running. I fixed
the Makefiles to make them compile though there are tests which do not
pass.
The motivation is to add litmus tests to each arch and have them run
using the
From: Marc-André Lureau
It's possible to run the test directly, tests/test-foo, but then
recompilation is not triggered and test environment variables aren't set
for you.
Signed-off-by: Marc-André Lureau
Signed-off-by: Pranith Kumar
From: Marc-André Lureau
tests/tcg/mmap test fails with values other than default target page
size. When creating a map beyond EOF, extra anonymous pages are added up
to the target page boundary. Currently, this operation is performed only
when
From: Marc-André Lureau
old_value is the 4th argument of timer_settime(), not the 2nd.
Signed-off-by: Marc-André Lureau
Signed-off-by: Pranith Kumar
---
linux-user/syscall.c | 2 +-
1 file changed, 1
From: Marc-André Lureau
I didn't remove it, as suggest by checkpatch, because it looks like it
may eventually be restored back.
Signed-off-by: Marc-André Lureau
Signed-off-by: Pranith Kumar
---
From: Michael Roth
Currently we set the initial isolation/allocation state for DRCs
associated with coldplugged LMBs to ISOLATED/UNUSABLE,
respectively, under the assumption that the guest will move this
state to UNISOLATED/USABLE.
In fact, this is only the case for
The following changes since commit 1cd56fd2e14f67ead2f0458b4ae052f19865c41c:
Update version for v2.8.0-rc2 release (2016-11-29 22:26:25 +)
are available in the git repository at:
git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20161201
for you to fetch changes up to
Richard Henderson writes:
> On 11/29/2016 11:56 PM, Nikunj A Dadhania wrote:
>> Lets bring full example here.
>>
>> TCGv nb = tcg_temp_new();
>> tcg_gen_andi_tl(nb, cpu_gpr[rB(ctx->opcode)], 0xFF);
>> tcg_gen_brcondi_tl(TCG_COND_EQ, nb, 0, l1);
>>
>> /* do
> From: Aviv B.D
> Sent: Monday, November 28, 2016 11:52 PM
>
> From: "Aviv Ben-David"
>
> This capability asks the guest to invalidate cache before each map operation.
> We can use this invalidation to trap map operations in the hypervisor.
'in the hypervisor" or "in the
> From: Peter Xu
> Sent: Wednesday, November 30, 2016 5:24 PM
>
> On Mon, Nov 28, 2016 at 05:51:50PM +0200, Aviv B.D wrote:
> > * intel_iommu's replay op is not implemented yet (May come in different
> > patch
> > set).
> > The replay function is required for hotplug vfio device and to move
Test case:
1. QEMU 1.1.2
2. Run fio inside the vm, give it some pressure. Watch the realtime
throughput
3. block_set_io_throttle drive_2 1 0 0 2000 0 0 # throttle
bps and iops, any value
4. Observed that the IO is very likely to freeze to zero. The fio process
stuck!
5. Kill the
From: Laszlo Ersek
According to ISO C99 / N1256 (referenced in HACKING):
> 6.5.8 Relational operators
>
> 4 For the purposes of these operators, a pointer to an object that is
> not an element of an array behaves the same as a pointer to the first
> element of an array of
From: Laszlo Ersek
* Commit 3e76099aacb4 ("loader: Allow a custom AddressSpace when loading
ROMs") introduced the "Rom.as" field:
(1) It modified the utility callers of rom_insert() to take "as" as a
new parameter from *their* callers, and set "rom->as" from that
From: Gonglei
Though crypto_cfg.reserve is an unused field, let me
initialize the structure in order to make coverity happy.
*** CID 1365923: Uninitialized variables (UNINIT)
/hw/virtio/virtio-crypto.c: 851 in virtio_crypto_get_config()
845
From: Wei Wang
Signed-off-by: Wei Wang
Reviewed-by: Marc-André Lureau
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
docs/specs/vhost-user.txt | 20
Comments on patches included:
- a spec update seems important for 2.8 as incorrect
spec makes people implement backends incorrectly.
- undefined behaviour fix seems important too -
who knows what would compiler optimizers come up with
Others are imho clearly uncontroversial.
The following
From: Peter Xu
"mask" needs to be inverted before use.
Signed-off-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/intel_iommu.c | 1 +
1 file changed, 1 insertion(+)
diff
On Thu, Dec 01, 2016 at 03:38:50AM +, Gonglei (Arei) wrote:
> Hi Michael,
>
> Pls pick up this one for 2.8.
>
> Thanks,
> -Gonglei
>
>
> > -Original Message-
> > From: Gonglei (Arei)
> > Sent: Saturday, November 26, 2016 11:08 AM
> > To: qemu-devel@nongnu.org
> > Cc:
On 11/30/2016 05:46 PM, r...@hev.cc wrote:
+static inline void gen_cop2_gslwlrc1(DisasContext *ctx, TCGv base,
+ int rt, int rs, int offset, int left)
+{
+TCGv_i32 t0, t1, t2;
+
+gen_base_offset_addr(ctx, base, rs, offset);
+t1 = tcg_temp_new_i32();
+/*
Hi Michael,
Pls pick up this one for 2.8.
Thanks,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Saturday, November 26, 2016 11:08 AM
> To: qemu-devel@nongnu.org
> Cc: m...@redhat.com; Gonglei (Arei)
> Subject: [PATCH v2] virtio-crypto: fix uninitialized variables
>
>
> From: Aviv B.D
> Sent: Monday, November 28, 2016 11:52 PM
>
> From: "Aviv Ben-David"
>
> * Advertize Cache Mode capability in iommu cap register.
> This capability is controlled by "cache-mode" property of intel-iommu
> device.
> To enable this option call QEMU with
On Thu, Dec 01, 2016 at 11:25:25AM +0800, Peter Xu wrote:
> On Wed, Nov 30, 2016 at 03:42:42PM +, Stefan Hajnoczi wrote:
> > Dear QEMU community,
> > QEMU 2.8.0-rc3 will be tagged on December 6th. If there are no
> > pending issues -rc3 will become the QEMU 2.8 final release on December
> >
On Wed, Nov 30, 2016 at 03:42:42PM +, Stefan Hajnoczi wrote:
> Dear QEMU community,
> QEMU 2.8.0-rc3 will be tagged on December 6th. If there are no
> pending issues -rc3 will become the QEMU 2.8 final release on December
> 13th. Let's make this tag a good one!
>
> If you are currently
On 30/11/16 16:36, Alastair D'Silva wrote:
> From: Alastair D'Silva
>
> Add a NULL check for i2c slave init callbacks, so that we no longer
> need to implement empty init functions.
>
> Signed-off-by: Alastair D'Silva
> ---
> hw/arm/pxa2xx.c | 9
On 01/12/16 11:42, Alastair D'Silva wrote:
> On Wed, 2016-11-30 at 09:18 +0100, Cédric Le Goater wrote:
>> On 11/30/2016 06:36 AM, Alastair D'Silva wrote:
>>> From: Alastair D'Silva
>>>
>>> The imx25 chip provides 3 i2c buses, but they have all been named
>>> "i2c", which
> From: Michael S. Tsirkin
> Sent: Tuesday, November 22, 2016 11:10 PM
>
> On Tue, Nov 22, 2016 at 12:11:21PM +0800, Jason Wang wrote:
> > Yes, that's the interesting point. The fault is not guaranteed but
> > conditional. And we have similar issue for IEC.
> >
> > So in conclusion (since I can't
On Nov 30, 2016, at 6:58 PM, Alistair Francis wrote:
On Fri, Nov 18, 2016 at 4:53 PM, Programmingkid
wrote:
On Nov 18, 2016, at 7:31 PM, Programmingkid wrote:
On Nov 18, 2016, at 4:10 PM, Alistair Francis wrote:
On Fri, Nov 11, 2016 at 8:53 AM, G 3
>
> Subject: [Qemu-devel] QEMU 2.8 release approaching
>
> Dear QEMU community,
> QEMU 2.8.0-rc3 will be tagged on December 6th. If there are no
> pending issues -rc3 will become the QEMU 2.8 final release on December
> 13th. Let's make this tag a good one!
>
> If you are currently looking
On Wed, Nov 30, 2016 at 05:05:34PM -0600, Michael Roth wrote:
> Currently we set the initial isolation/allocation state for DRCs
> associated with coldplugged LMBs to ISOLATED/UNUSABLE,
> respectively, under the assumption that the guest will move this
> state to UNISOLATED/USABLE.
>
> In fact,
On 11/30/2016 08:05 PM, Max Reitz wrote:
> When trying to invoke qemu-img commit with a base image file name that
> is not part of the top image's backing chain, the user receives a rather
> plain "Base not found" error message. This is not really helpful because
> it does not explain what "not
On 11/30/2016 05:06 PM, Michael Roth wrote:
> Currently objects specified on the command-line are only partially
> cleaned up when 'object_del' is issued in either HMP or QMP: the
> object itself is fully finalized, but the QemuOpts are not removed.
> This results in the following behavior:
>
>
Hi Stefan,
>
> On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote:
> > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c
> b/drivers/crypto/virtio/virtio_crypto_algs.c
> > new file mode 100644
> > index 000..08b077f
> > --- /dev/null
> > +++
Commit 87f68d318222563822b5c6b28192215fc4b4e441 (block: drop aio
functions that operate on the main AioContext) drops qemu_aio_wait
function references mostly while leaves these behind, clean up them.
Signed-off-by: Yaowei Bai
---
include/block/aio.h | 4 ++--
1
It's timer to expire, not clock.
Signed-off-by: Yaowei Bai
---
include/qemu/timer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index 309f3d0..c89ed2a 100644
--- a/include/qemu/timer.h
+++
Commit 49cf57281b7 (vl: delay thread initialization after daemonization)
makes the global mutex is taken after daemonization instead before
daemonization by qemu_init_main_loop().
Signed-off-by: Yaowei Bai
---
include/qemu/main-loop.h | 4 ++--
1 file changed, 2
When trying to invoke qemu-img commit with a base image file name that
is not part of the top image's backing chain, the user receives a rather
plain "Base not found" error message. This is not really helpful because
it does not explain what "not found" means, potentially leaving the user
From: Heiher
Signed-off-by: Heiher
---
target-mips/helper.c | 4 +-
target-mips/mips-defs.h | 5 +
target-mips/translate.c | 463 +--
target-mips/translate_init.c | 24 +++
4 files changed, 481
On Wed, 2016-11-30 at 09:18 +0100, Cédric Le Goater wrote:
> On 11/30/2016 06:36 AM, Alastair D'Silva wrote:
> > From: Alastair D'Silva
> >
> > The imx25 chip provides 3 i2c buses, but they have all been named
> > "i2c", which makes it difficult to predict which bus a
On Fri, Nov 18, 2016 at 4:53 PM, Programmingkid
wrote:
>
> On Nov 18, 2016, at 7:31 PM, Programmingkid wrote:
>
>>
>> On Nov 18, 2016, at 4:10 PM, Alistair Francis wrote:
>>
>>> On Fri, Nov 11, 2016 at 8:53 AM, G 3 wrote:
On Nov 11,
Currently objects specified on the command-line are only partially
cleaned up when 'object_del' is issued in either HMP or QMP: the
object itself is fully finalized, but the QemuOpts are not removed.
This results in the following behavior:
x86_64-softmmu/qemu-system-x86_64 -monitor stdio \
Currently we set the initial isolation/allocation state for DRCs
associated with coldplugged LMBs to ISOLATED/UNUSABLE,
respectively, under the assumption that the guest will move this
state to UNISOLATED/USABLE.
In fact, this is only the case for LMBs added via hotplug. For
coldplugged LMBs, the
On Tue, 29 Nov 2016 17:26:59 +0100
Paolo Bonzini wrote:
> It's pretty clean! I would rather avoid the duplicate enums, possibly
> by automatically generating large parts of ptc.h, but that's pretty
> much it. I see that you check that the constants match (that cpp
> stuff
Hi Richard,
On Wed, Nov 30, 2016 at 12:30:19PM -0800, Richard Henderson wrote:
> On 11/30/2016 10:39 AM, Jin Guojie wrote:
> > But even Su cannot provide an R6 machine.
>
> Ok, I guess we will just have to drop the R6 patches for now, until imgtec is
> able to provide feedback on them.
I'm
Quoting Michael Roth (2016-11-22 16:58:44)
> Quoting David Gibson (2016-11-22 00:15:10)
> > On Thu, Nov 17, 2016 at 07:40:25PM -0600, Michael Roth wrote:
> > > From: Jianjun Duan
> > >
> > > Currently migrated Devices are identified with an idstr which is
> > >
On 11/30/16 21:48, John Snow wrote:
>
>
> On 11/30/2016 07:03 AM, Laszlo Ersek wrote:
>> On 11/30/16 11:55, Gerd Hoffmann wrote:
>>> On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote:
Recent git releases support the diff.orderFile permanent setting.
>>>
>>> Cool.
>>>
configure
On 11/30/2016 03:02 PM, John Snow wrote:
>
>
> On 11/30/2016 02:44 PM, Eric Blake wrote:
>> As argued elsewhere, it's less code to maintain if we convert
>> from a dynamic string passed to qobject_from_jsonv() to instead
>> use a hand-built QDict.
>>
>> Rather than build up a QDict by manual
On Wed, Nov 30, 2016 at 01:44:19PM -0600, Eric Blake wrote:
> It's simpler to just use a C struct than it is to bundle things
> into a QDict in one function just to pull them back out in the
> caller. Plus, doing this gets rid of one more user of dynamic
> JSON through qobject_from_jsonf().
>
>
On 11/30/2016 02:44 PM, Eric Blake wrote:
> As argued elsewhere, it's less code to maintain if we convert
> from a dynamic string passed to qobject_from_jsonv() to instead
> use a hand-built QDict.
>
> Rather than build up a QDict by manual qdict_put*() calls, we
> can let QAPI do the work for
On 11/30/2016 02:44 PM, Eric Blake wrote:
> Use the preferred blockdev-change-medium command instead.
>
> Signed-off-by: Eric Blake
> ---
> tests/fdc-test.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/fdc-test.c b/tests/fdc-test.c
>
On 11/30/2016 02:44 PM, Eric Blake wrote:
> As argued elsewhere, it's less code to maintain if we convert
> from a dynamic string passed to qobject_from_jsonv() to instead
> use a hand-built QDict.
>
> Rather than build up a QDict by manual qdict_put*() calls, we
> can let QAPI do the work for
On 11/30/2016 07:03 AM, Laszlo Ersek wrote:
> On 11/30/16 11:55, Gerd Hoffmann wrote:
>> On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote:
>>> Recent git releases support the diff.orderFile permanent setting.
>>
>> Cool.
>>
>>> configure
>>> *Makefile*
>>> *.json
>>> *.txt
>>> *.h
>>> *.c
>>
On 11/29/2016 03:52 PM, Laurent Vivier wrote:
> It doesn't work because we work with word/byte where the bit sign has
> been extended to the long word. So in the case of 0 shift, with retrieve
> C= and not 0.
Ah, right. I wonder if it's better to always zero-extend the inputs for
left-shifts, as
- Original Message -
> From: "Eric Blake"
> To: qemu-devel@nongnu.org
> Cc: pbonz...@redhat.com, arm...@redhat.com
> Sent: Wednesday, November 30, 2016 8:50:05 PM
> Subject: Re: [Qemu-devel] [PATCH 00/36] Rip out dynamic JSON parsing
>
> On 11/30/2016 01:44 PM, Eric
Quite a few users of qdict_put() were manually wrapping a
non-QObject. We can make such call-sites shorter, by providing
common macros to do the tedious work. Also shorten nearby
qdict_put_obj(,,QOBJECT()) sequences.
Signed-off-by: Eric Blake
---
I'm okay if you want me to
On 11/30/16 16:42, Stefan Hajnoczi wrote:
> Dear QEMU community,
> QEMU 2.8.0-rc3 will be tagged on December 6th. If there are no
> pending issues -rc3 will become the QEMU 2.8 final release on December
> 13th. Let's make this tag a good one!
>
> If you are currently looking into pending issues
Except for the testsuite, there are no more callers of
qobject_from_json[fv](). We have no need to maintain dynamic
JSON parsing just for the check-qjson test, so delete the
functions. All callers of json_parser_parse() now pass NULL
for the varargs parameter; the next patch will clean that up.
On 11/30/2016 10:12 AM, Alex Bennée wrote:
>
> Richard Henderson writes:
>
>> On 11/30/2016 08:55 AM, Alex Bennée wrote:
>>>
>>> Nikunj A Dadhania writes:
>>>
Hi,
I was writing one instruction and hit following issue:
On 11/30/2016 10:39 AM, Jin Guojie wrote:
> Yesterday I successfully got in touch with a Debian developer from imgtec.
> Welcome Su Yunqiang.
> V4 patch can be tested on mips64 be hosts now.
> The following guests on a mips64
> big-endian host is OK:
> - Debian i386 with qemu-system-i386
> -
Back in commit 764c1ca (Nov 2009), we added qstring_append_int().
However, it did not see any use until commit 190c882 (Jan 2015).
Furthermore, it has a rather limited use case - to print anything
else, callers still have to format into a temporary buffer, unless
we want to introduce an explosion
We have two flavors of vararg usage in qtest; make it clear that
qmp() has different semantics than hmp(), and let the compiler
enforce that hmp() is used correctly. Since qmp() only accepts
exactly "%s" (asserting on misuse, which would be flagged during
'make check'), I figured that it is
As argued elsewhere, it's less code to maintain if we convert
from a dynamic string passed to qobject_from_jsonv() to instead
use hand-built QDict.
Signed-off-by: Eric Blake
---
Optional; the "%s" handling in earlier patches is sufficient to
handle this without hand-built
Now that there are no callers of dynamic JSON parsing, the
lexer does not need to special-case escape sequences.
Since the lexer is directly invoked on user-provided input,
this changes behavior when a QMP client passes (bad) JSON,
from:
{'execute':'qmp_capabilities','id':%s}
{"error": {"class":
As argued elsewhere, it's less code to maintain if we convert
from a dynamic string passed to qobject_from_jsonv() to instead
use a hand-built QDict.
Rather than build up a QDict by manual qdict_put*() calls, we
can let QAPI do the work for us. The result is more lines of
code to initialize the
When qmp_cmd() was first added, we used a shortcut of a format
string of "%p" to pass the QObject intact through the varargs.
But now that we have a way to directly invoke strings, we can
altogether avoid the no-op trip through the parser by just
flattening to a string ourselves.
Signed-off-by:
Now that there are no callers of dynamic JSON parsing, the
parser does not need to handle a va_list argument.
Signed-off-by: Eric Blake
---
include/qapi/qmp/json-parser.h | 6 +++---
monitor.c | 2 +-
qga/main.c | 2 +-
Use the new macro to avoid some boilerplate.
Signed-off-by: Eric Blake
---
blockdev.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 2802cea..18a3212 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3801,29
As argued elsewhere, it's less code to maintain if we convert
from a dynamic string passed to qobject_from_jsonv() to instead
use hand-built QDict.
Signed-off-by: Eric Blake
---
Optional; the "%s" handling in earlier patches is sufficient to
handle this without hand-built
As argued elsewhere, it's less code to maintain if we convert
from a dynamic string passed to qobject_from_jsonv() to instead
use a hand-built QDict.
Signed-off-by: Eric Blake
---
tests/tmp105-test.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
1 - 100 of 245 matches
Mail list logo