[Qemu-devel] [Bug 1484925] Re: Segfault with custom vnc client

2017-01-20 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1484925 Title: Segfault

[Qemu-devel] [Bug 744856] Re: can't boot when using more than 6 disks since qemu-kvm-0.13

2017-01-20 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/744856 Title: can't boot

Re: [Qemu-devel] [PATCH v2 0/2] hw/usb/dev-hid: Make usb-tablet work with OS X/macOS guests

2017-01-20 Thread Gabriel L. Somlo
On Fri, Jan 20, 2017 at 13:30:15 +0100, p...@philjordan.eu wrote: > This series makes the Qemu usb-tablet work correctly with OS X/macOS guests > without the need for a special guest driver. > > * The usb-tablet should not have a boot protocol of 2. Other OSes seem to > ignore this, but the

[Qemu-devel] [PATCH] hmp: fix block_set_io_throttle

2017-01-20 Thread Eric Blake
Commit 7a9877a made the 'device' parameter to BlockIOThrottle optional, favoring 'id' instead. But it forgot to update the HMP usage to set has_device, which makes all attempts to change throttling via HMP fail with "Need exactly one of 'device' and 'id'" CC: qemu-sta...@nongnu.org

Re: [Qemu-devel] [PATCH 0/3] arch_init: Move soundhw code to hw/audio/soundhw.c

2017-01-20 Thread Eduardo Habkost
Ping? Any feedback? On Tue, Jan 17, 2017 at 04:46:35PM -0200, Eduardo Habkost wrote: > This moves the arch_init.c soundhw code to its own file, renames > audio_init() to soundhw_init(), and renames hw/audio/audio.h to > hw/audio/soundhw.h. > > Eduardo Habkost (3): > audio: Move arch_init audio

Re: [Qemu-devel] [PATCH v3] hw/core/null-machine: Add the possibility to instantiate a CPU and RAM

2017-01-20 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 04:34:47PM -0800, Alistair Francis wrote: > On Wed, Jan 18, 2017 at 10:56 AM, Thomas Huth wrote: > > On 18.01.2017 18:57, Alistair Francis wrote: > >> On Wed, Jan 18, 2017 at 4:44 AM, Thomas Huth wrote: > >>> Sometimes it is useful to

Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-20 Thread Eduardo Habkost
On Fri, Jan 20, 2017 at 08:55:58AM +0800, Haozhong Zhang wrote: > On 01/16/17 11:00 +, Stefan Hajnoczi wrote: > > On Mon, Jan 16, 2017 at 01:55:34PM +0800, Xiao Guangrong wrote: > > > On 01/14/2017 02:02 AM, Eduardo Habkost wrote: > > > > On Fri, Jan 13, 2017 at 01:17:27PM +, Stefan

Re: [Qemu-devel] [PATCH v2] Introduce DEVICE_CATEGORY_CPU for CPU devices

2017-01-20 Thread Eduardo Habkost
On Fri, Jan 20, 2017 at 02:01:16PM +0100, Thomas Huth wrote: > Now that CPUs show up in the help text of "-device ?", > we should group them into an appropriate category. > > Signed-off-by: Thomas Huth Reviewed-by: Eduardo Habkost I assume Paolo will

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-20 Thread Eric Blake
On 01/20/2017 12:00 PM, Alex Bligh wrote: > >> On 20 Jan 2017, at 17:04, Vladimir Sementsov-Ogievskiy >> wrote: >> >> About extents: is 32bit length enough? We will have to send 4096 for empty >> 16tb disk.. > > The nbd protocol uniformly uses 32 bit lengths (for

Re: [Qemu-devel] [PATCH 0/6] ARMv7M: some simple bugfixes and cleanups

2017-01-20 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/6] ARMv7M: some simple bugfixes and cleanups Message-id: 1484937883-1068-1-git-send-email-peter.mayd...@linaro.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 4/6] hw/registerfields.h: Pull FIELD etc macros out of hw/register.h

2017-01-20 Thread Alistair Francis
On Fri, Jan 20, 2017 at 10:44 AM, Peter Maydell wrote: > hw/register.h provides macros like FIELD which make it easy to define > shift, mask and length constants for the fields within a register. > Unfortunately register.h also includes a lot of other things, some > of

Re: [Qemu-devel] [RFC 03/13] pc: don't return cpu pointer from pc_new_cpu() as it's not needed anymore

2017-01-20 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 06:13:19PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Applying to machine-next. Thanks! -- Eduardo

Re: [Qemu-devel] [RFC 02/13] pc: cleanup: move smbios_set_cpuid() into pc_build_smbios()

2017-01-20 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 06:13:18PM +0100, Igor Mammedov wrote: > move smbios_set_cpuid() close to the rest of smbios init code > where it belongs to instead of calling it from pc_cpus_init(). > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost

[Qemu-devel] [PATCH 0/6] ARMv7M: some simple bugfixes and cleanups

2017-01-20 Thread Peter Maydell
This set of six patches is some simple bug fixes which I've pulled out of Michael Davidsaver's old NVIC rewrite patchset, as an initial start on getting it upstream. None of them are particularly exciting, but they're self-contained so they might as well go through code review and get into master

[Qemu-devel] [PATCH] arm: stellaris: make MII accesses complete immediately

2017-01-20 Thread Peter Maydell
From: Michael Davidsaver When the guest attempts to start an MII register access via the MCTL register, clear the START bit, so that when the guest reads it back the register transaction will be signalled as having completed. This avoids the guest spinning as it polls the

Re: [Qemu-devel] [Bug 639651] Re: DRIVER_IRQL_NOT_LESS_OR_EQUAL booting WIndows XP with Synaptics driver installed

2017-01-20 Thread Michal Suchanek
Does qemu allow to disable the PS/2 port now? If so then there is easy workaround in case something similar ever happens. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/639651 Title:

[Qemu-devel] [PATCH 2/6] armv7m: Replace armv7m.hack with unassigned_access handler

2017-01-20 Thread Peter Maydell
From: Michael Davidsaver For v7m we need to catch attempts to execute from special addresses at 0xfff0 and above. Previously we did this with the aid of a hacky special purpose lump of memory in the address space and a check in translate.c for whether we were

[Qemu-devel] [PATCH 4/6] hw/registerfields.h: Pull FIELD etc macros out of hw/register.h

2017-01-20 Thread Peter Maydell
hw/register.h provides macros like FIELD which make it easy to define shift, mask and length constants for the fields within a register. Unfortunately register.h also includes a lot of other things, some of which will only compile in the softmmu build. Pull the FIELD macro and friends out into a

[Qemu-devel] [PATCH 5/6] armv7m: Fix reads of CONTROL register bit 1

2017-01-20 Thread Peter Maydell
From: Michael Davidsaver The v7m CONTROL register bit 1 is SPSEL, which indicates the stack being used. We were storing this information not in v7m.control but in the separate v7m.other_sp structure field. Unfortunately, the code handling reads of the CONTROL register

[Qemu-devel] [PATCH 3/6] armv7m: Explicit error for bad vector table

2017-01-20 Thread Peter Maydell
From: Michael Davidsaver Give an explicit error and abort when a load from the vector table fails. Architecturally this should HardFault (which will then immediately fail to load the HardFault vector and go into Lockup). Since we don't model Lockup, just report this guest

[Qemu-devel] [PATCH 1/6] armv7m: MRS/MSR: handle unprivileged access

2017-01-20 Thread Peter Maydell
From: Michael Davidsaver The MRS and MSR instruction handling has a number of flaws: * unprivileged accesses should only be able to read CONTROL and the xPSR subfields, and only write APSR (others RAZ/WI) * privileged access should not be able to write xPSR

[Qemu-devel] [PATCH 6/6] armv7m: Clear FAULTMASK on return from non-NMI exceptions

2017-01-20 Thread Peter Maydell
From: Michael Davidsaver FAULTMASK must be cleared on return from all exceptions other than NMI. Signed-off-by: Michael Davidsaver Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell ---

[Qemu-devel] [Bug 954099] Re: Assertion failed arp_table.c line 41 on raspberry pi fedora image boot up

2017-01-20 Thread Thomas Huth
Since there hasn't been any more complains about later binaries, I assume we can close this issue nowadays. (Feel free to re-open it otherwise) ** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [libvirt] [PATCH 0/9] i386: query-cpu-model-expansion test script

2017-01-20 Thread Eduardo Habkost
On Fri, Jan 20, 2017 at 03:30:54PM +0100, David Hildenbrand wrote: > Am 19.01.2017 um 18:45 schrieb Daniel P. Berrange: > > On Thu, Jan 19, 2017 at 06:21:22PM +0100, David Hildenbrand wrote: > >> > Also think about "query-cpu-model-expansion model=host type=static", > which will

Re: [Qemu-devel] [PATCH v3 2/4] compiler: rework BUG_ON using a struct

2017-01-20 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Jan 20, 2017 at 06:09:52PM +0100, Paolo Bonzini wrote: >> >> >> On 20/01/2017 17:57, Michael S. Tsirkin wrote: >> > On Fri, Jan 20, 2017 at 08:42:41AM +0100, Markus Armbruster wrote: >> >> "Michael S. Tsirkin" writes: >>

[Qemu-devel] [Bug 903365] Re: [feature request] bind nat (-net user) to other interface (like eth0:2)

2017-01-20 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/903365 Title: [feature request] bind nat (-net user) to other interface (like eth0:2)

Re: [Qemu-devel] [PATCH RFC v11 3/4] vfio-pci: pass the aer error to guest

2017-01-20 Thread Alex Williamson
On Fri, 20 Jan 2017 06:57:22 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Thursday, January 19, 2017 6:32 AM > > > > On Sat, 31 Dec 2016 17:13:07 +0800 > > Cao jin wrote: > > > > > From: Chen Fan

Re: [Qemu-devel] [PATCH RFC v11 2/4] vfio: new function to init aer cap for vfio device

2017-01-20 Thread Alex Williamson
On Fri, 20 Jan 2017 14:03:42 +0800 Cao jin wrote: > On 01/19/2017 06:09 AM, Alex Williamson wrote: > > On Sat, 31 Dec 2016 17:13:06 +0800 > > Cao jin wrote: > > > >> From: Chen Fan > >> > >> Introduce new

[Qemu-devel] [Bug 889827] Re: Qemu hangs on loadvm

2017-01-20 Thread Thomas Huth
QEMU 0.15 is pretty much outdated ... can you still reproduce this issue with the latest version of QEMU, or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 824074] Re: Provide runtime option to expose the supported list of keymaps for vnc

2017-01-20 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/824074 Title: Provide runtime option to expose the supported list of keymaps for vnc Status

Re: [Qemu-devel] [PATCH RFC v11 4/4] vfio: add 'aer' property to expose aercap

2017-01-20 Thread Alex Williamson
On Fri, 20 Jan 2017 14:04:08 +0800 Cao jin wrote: > On 01/19/2017 06:36 AM, Alex Williamson wrote: > > On Sat, 31 Dec 2016 17:13:08 +0800 > > Cao jin wrote: > > > >> From: Chen Fan > >> > >> Add 'aer'

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-20 Thread Alex Bligh
> On 20 Jan 2017, at 17:04, Vladimir Sementsov-Ogievskiy > wrote: > > About extents: is 32bit length enough? We will have to send 4096 for empty > 16tb disk.. The nbd protocol uniformly uses 32 bit lengths (for better or for worse). This is baked into the

[Qemu-devel] [Bug 1499908] Re: hda sound capture broken with VNC

2017-01-20 Thread Francois Gouget
As an alternative to compiling the source code yourselves, I have attached the capture.exe binary. ** Attachment added: "Executable to reproduce this bug" https://bugs.launchpad.net/qemu/+bug/1499908/+attachment/4806840/+files/capture.exe.bz2 -- You received this bug notification because

[Qemu-devel] [Bug 1499908] Re: hda sound capture broken with VNC

2017-01-20 Thread Francois Gouget
On Debian this is still present in QEMU 1:2.7+dfsg-3+b1 with the 4.8.11-1 Linux kernel. So no change in the past 5 quarters :-( So I'm attaching a tar file containing standalone and somewhat minimalist source code for reproducing this issue. Just compile it with MinGW by typing 'make', send the

Re: [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON

2017-01-20 Thread Michael S. Tsirkin
On Fri, Jan 20, 2017 at 08:21:28AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Jan 19, 2017 at 02:33:40PM +0100, Markus Armbruster wrote: > >> Paolo Bonzini writes: > >> > >> > On 19/01/2017 09:12, Markus Armbruster wrote:

Re: [Qemu-devel] [PATCH 0/7] virtio: use MemoryRegionCache for descriptors and rings

2017-01-20 Thread Michael S. Tsirkin
On Fri, Jan 20, 2017 at 06:07:50PM +0100, Paolo Bonzini wrote: > Patch posted during 2.8 hard freeze. Quick measurements give a 10% > performance improvement on various virtio-blk benchmarks, but the machine > I used seems to love my patches particularly today! > > Paolo Will review, thanks!

Re: [Qemu-devel] qemu-2.8-rc4 is broken

2017-01-20 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> >> From: Stefan Hajnoczi [mailto:stefa...@gmail.com] >> >> > >> >> > Yes, this option helps. >> >> > Thank you. >> >> >> >> Good news. This can be fixed in 2.8.1 once someone finds a solution.

Re: [Qemu-devel] [PATCH v3 2/4] compiler: rework BUG_ON using a struct

2017-01-20 Thread Michael S. Tsirkin
On Fri, Jan 20, 2017 at 06:09:52PM +0100, Paolo Bonzini wrote: > > > On 20/01/2017 17:57, Michael S. Tsirkin wrote: > > On Fri, Jan 20, 2017 at 08:42:41AM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >>> There are theoretical concerns that some

Re: [Qemu-devel] [PATCH v3 2/4] compiler: rework BUG_ON using a struct

2017-01-20 Thread Paolo Bonzini
On 20/01/2017 17:57, Michael S. Tsirkin wrote: > On Fri, Jan 20, 2017 at 08:42:41AM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >>> There are theoretical concerns that some compilers might not trigger >>> build failures on attempts to define an array of

[Qemu-devel] [PULL v4 00/35] Misc patches for 2017-01-11

2017-01-20 Thread Paolo Bonzini
The following changes since commit d1c82f7cc34443841095f490345f86c9d8baca34: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170120-v2' into staging (2017-01-20 15:53:58 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you

[Qemu-devel] [PATCH 7/7] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-01-20 Thread Paolo Bonzini
The virtio-net change is necessary because it uses virtqueue_fill and virtqueue_flush instead of the more convenient virtqueue_push. Signed-off-by: Paolo Bonzini --- hw/net/virtio-net.c | 14 +- hw/virtio/virtio.c | 138

[Qemu-devel] [PULL 35/35] pc.h: move x-mach-use-reliable-get-clock compat entry to PC_COMPAT_2_8

2017-01-20 Thread Paolo Bonzini
From: Marcelo Tosatti As noticed by David Gilbert, commit 6053a86 'kvmclock: reduce kvmclock differences on migration' added 'x-mach-use-reliable-get-clock' and a compatibility entry that turns it off; however it got merged after 2.8.0 was released but the entry has gone

[Qemu-devel] [PATCH 0/7] virtio: use MemoryRegionCache for descriptors and rings

2017-01-20 Thread Paolo Bonzini
Patch posted during 2.8 hard freeze. Quick measurements give a 10% performance improvement on various virtio-blk benchmarks, but the machine I used seems to love my patches particularly today! Paolo Paolo Bonzini (7): virtio: make virtio_should_notify static virtio: add virtio_*_phys_cached

Re: [Qemu-devel] [PULL v3 00/32] Misc patches for 2017-01-11

2017-01-20 Thread Paolo Bonzini
No cigar, conflicts with master. Paolo On 20/01/2017 14:31, Paolo Bonzini wrote: > The following changes since commit 2ccede18bd24fce5db83fef3674563a1f256717b: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2017-01-16 > 12:41:35 +) > >

[Qemu-devel] [PATCH 5/7] virtio: add MemoryListener to cache ring translations

2017-01-20 Thread Paolo Bonzini
The cached translations are RCU-protected to allow efficient use when processing virtqueues. Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 91 -- include/hw/virtio/virtio.h | 1 + 2 files changed, 89

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-20 Thread Vladimir Sementsov-Ogievskiy
About extents: is 32bit length enough? We will have to send 4096 for empty 16tb disk.. -- Best regards, Vladimir

[Qemu-devel] [PATCH 4/7] virtio: use MemoryRegionCache to access descriptors

2017-01-20 Thread Paolo Bonzini
For now, the cache is created on every virtqueue_pop. Later on, direct descriptors will be able to reuse it. Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 91 ++ 1 file changed, 50 insertions(+), 41 deletions(-)

Re: [Qemu-devel] [PATCH RFC 0/3] vfio: allow to notify unmap for very big region

2017-01-20 Thread Alex Williamson
On Fri, 20 Jan 2017 20:27:18 +0800 Peter Xu wrote: > On Fri, Jan 20, 2017 at 11:43:28AM +0800, Peter Xu wrote: > > [...] > > > > What I don't want to see is for this API bug to leak out into the rest > > > of the QEMU code such that intel_iommu code, or iommu code in general

[Qemu-devel] [PATCH 6/7] virtio: use VRingMemoryRegionCaches for descriptor ring

2017-01-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 848c30f..668a97f 100644 --- a/hw/virtio/virtio.c +++

Re: [Qemu-devel] [PATCH] block/iscsi: avoid data corruption with cache=writeback

2017-01-20 Thread Paolo Bonzini
On 16/01/2017 16:17, Peter Lieven wrote: > nb_cls_shrunk in iscsi_allocmap_update can become -1 if the > request starts and ends within the same cluster. This results > in passing -1 to bitmap_set and bitmap_clear and they don't > handle negative values properly. In the end this leads to data >

[Qemu-devel] [PATCH 3/7] virtio: use address_space_map/unmap to access descriptors

2017-01-20 Thread Paolo Bonzini
This makes little difference, but it makes the code change smaller for the next patch that introduces MemoryRegionCache. This is because map/unmap are similar to MemoryRegionCache init/destroy. Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 76

[Qemu-devel] [PATCH 1/7] virtio: make virtio_should_notify static

2017-01-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 2 +- include/hw/virtio/virtio.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index cc17b97..b1c5563 100644 --- a/hw/virtio/virtio.c +++

Re: [Qemu-devel] [PATCH v11 00/16] block: Image locking series

2017-01-20 Thread Fam Zheng
On Fri, 01/20 06:59, no-re...@patchew.org wrote: > Hi, > ERROR:/tmp/qemu-test/src/tests/test-image-lock.c:109:do_test_compat_one: > 'blk2' should not be NULL Failed because centos 6 doesn't support F_OFD_SETLK. Will respin to ignore locking in this case.

[Qemu-devel] [PATCH 17/17] block: document fields protected by AioContext lock

2017-01-20 Thread Paolo Bonzini
Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- include/block/block_int.h | 64 +- include/sysemu/block-backend.h | 14 ++--- 2 files changed, 49 insertions(+), 29 deletions(-) diff --git

[Qemu-devel] [PATCH 2/7] virtio: add virtio_*_phys_cached

2017-01-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/hw/virtio/virtio-access.h | 52 +++ 1 file changed, 52 insertions(+) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access.h index 91ae14d..2e92074 100644 ---

[Qemu-devel] [Bug 1658141] Re: QEMU's default msrs handling causes Windows 10 64 bit to crash

2017-01-20 Thread Francois Gouget
** Attachment added: "Executable to reproduce this bug" https://bugs.launchpad.net/qemu/+bug/1658141/+attachment/4806830/+files/exception.exe.bz2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH 10/17] aio: push aio_context_acquire/release down to dispatching

2017-01-20 Thread Paolo Bonzini
The AioContext data structures are now protected by list_lock and/or they are walked with FOREACH_RCU primitives. There is no need anymore to acquire the AioContext for the entire duration of aio_dispatch. Instead, just acquire it before and after invoking the callbacks. The next step is then to

[Qemu-devel] [PATCH 13/17] block: explicitly acquire aiocontext in bottom halves that need it

2017-01-20 Thread Paolo Bonzini
Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block/archipelago.c | 3 +++ block/blkdebug.c | 9 + block/blkreplay.c | 2 +- block/block-backend.c | 6 ++ block/curl.c | 26 ++

Re: [Qemu-devel] [PATCH RFC] vfio error recovery: kernel support

2017-01-20 Thread Michael S. Tsirkin
On Fri, Jan 20, 2017 at 06:13:22PM +0800, Cao jin wrote: > > > On 01/20/2017 04:16 AM, Michael S. Tsirkin wrote: > > This is a design and an initial patch for kernel side for AER > > support in VFIO. > > > > 0. What happens now (PCIE AER only) > >Fatal errors cause a link reset. > >Non

[Qemu-devel] [PATCH 04/17] block: move AioContext and QEMUTimer to libqemuutil

2017-01-20 Thread Paolo Bonzini
AioContext is fairly self contained, the only dependency is QEMUTimer but that in turn doesn't need anything else. So move them out of block-obj-y to avoid introducing a dependency from io/ to block-obj-y. Signed-off-by: Paolo Bonzini --- v1->v2: new patch [Daniel]

[Qemu-devel] [PATCH 11/17] block: explicitly acquire aiocontext in timers that need it

2017-01-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/curl.c| 2 ++ block/io.c | 5 + block/iscsi.c | 8 ++-- block/null.c| 4 block/qed.c | 12 block/qed.h | 3 +++

[Qemu-devel] [PATCH 14/17] block: explicitly acquire aiocontext in aio callbacks that need it

2017-01-20 Thread Paolo Bonzini
Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block/archipelago.c| 3 --- block/block-backend.c | 7 --- block/curl.c | 2 +- block/io.c | 6 +- block/iscsi.c | 3 --- block/linux-aio.c

[Qemu-devel] [PATCH 05/17] io: add methods to set I/O handlers on AioContext

2017-01-20 Thread Paolo Bonzini
This is in preparation for making qio_channel_yield work on AioContexts other than the main one. Cc: Daniel P. Berrange Signed-off-by: Paolo Bonzini --- v1->v2: removed QIOChannelRestart [Daniel] include/io/channel.h | 25

Re: [Qemu-devel] [PATCH v3 2/4] compiler: rework BUG_ON using a struct

2017-01-20 Thread Michael S. Tsirkin
On Fri, Jan 20, 2017 at 08:42:41AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > There are theoretical concerns that some compilers might not trigger > > build failures on attempts to define an array of size -1 and make it a > > variable sized array

[Qemu-devel] [PATCH 07/17] nbd: convert to use qio_channel_yield

2017-01-20 Thread Paolo Bonzini
In the client, read the reply headers from a coroutine, switching the read side between the "read header" coroutine and the I/O coroutine that reads the body of the reply. In the server, if the server can read more requests it will create a new "read request" coroutine as soon as a request has

[Qemu-devel] [PATCH 15/17] aio-posix: partially inline aio_dispatch into aio_poll

2017-01-20 Thread Paolo Bonzini
This patch prepares for the removal of unnecessary lockcnt inc/dec pairs. Extract the dispatching loop for file descriptor handlers into a new function aio_dispatch_handlers, and then inline aio_dispatch into aio_poll. aio_dispatch can now become void. Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 06/17] io: make qio_channel_yield aware of AioContexts

2017-01-20 Thread Paolo Bonzini
Support separate coroutines for reading and writing, and place the read/write handlers on the AioContext that the QIOChannel is registered with. Cc: Daniel P. Berrange Signed-off-by: Paolo Bonzini --- v1->v2: improved

[Qemu-devel] [PATCH 00/17] aio_context_acquire/release pushdown, part 2

2017-01-20 Thread Paolo Bonzini
This series pushes down aio_context_acquire/release to the point where we can actually reason on using different fine-grained mutexes. The main infrastructure is introduced in patch 1. The new API aio_co_wake starts a coroutine with aio_context_acquire/release protection, which requires tracking

Re: [Qemu-devel] [PATCH] virtio: Fix no interrupt when not creating msi controller

2017-01-20 Thread Michael S. Tsirkin
On Fri, Jan 20, 2017 at 10:50:49AM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > For ARM virt machine, if we use virt-2.7 which will not create ITS node, > the virtio-net can not recieve interrupts so it can't get ip address > through dhcp. > This fixes commit

[Qemu-devel] [PATCH 16/17] async: remove unnecessary inc/dec pairs

2017-01-20 Thread Paolo Bonzini
Pull the increment/decrement pair out of aio_bh_poll and into the callers. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- util/aio-posix.c | 8 +++- util/aio-win32.c | 8 util/async.c | 12 ++-- 3 files

[Qemu-devel] [PATCH 02/17] block-backend: allow blk_prw from coroutine context

2017-01-20 Thread Paolo Bonzini
qcow2_create2 calls this. Do not run a nested event loop, as that breaks when aio_co_wake tries to queue the coroutine on the co_queue_wakeup list of the currently running one. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini ---

Re: [Qemu-devel] Towards an ivshmem 2.0?

2017-01-20 Thread Jan Kiszka
On 2017-01-20 12:54, Wang, Wei W wrote: > On Tuesday, January 17, 2017 5:46 PM, Jan Kiszka wrote: >> On 2017-01-17 10:13, Wang, Wei W wrote: >>> Hi Jan, >>> >>> On Monday, January 16, 2017 9:10 PM, Jan Kiszka wrote: On 2017-01-16 13:41, Marc-André Lureau wrote: > On Mon, Jan 16, 2017 at

[Qemu-devel] [PATCH 09/17] qed: introduce qed_aio_start_io and qed_aio_next_io_cb

2017-01-20 Thread Paolo Bonzini
qed_aio_start_io and qed_aio_next_io will not have to acquire/release the AioContext, while qed_aio_next_io_cb will. Split the functionality and gain a little type-safety in the process. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [Bug 1658141] [NEW] QEMU's default msrs handling causes Windows 10 64 bit to crash

2017-01-20 Thread Francois Gouget
Public bug reported: Wine uses QEMU to run its conformance test suite on Windows virtual machines. Wine's conformance tests check the behavior of various Windows APIs and verify that they behave as expected. One such test checks handling of exceptions down. When run on Windows 10 64 bit in QEMU

Re: [Qemu-devel] [PULL v2 00/12] s390x update

2017-01-20 Thread Peter Maydell
> > are available in the git repository at: > > git://github.com/cohuck/qemu tags/s390x-20170120-v2 > > for you to fetch changes up to 8c797e758ad41b8dd6ea6f72c6f0194dedb30a2f: > > virtio-ccw: fix ring sizing (2017-01-20 10:02:02 +0100) > >

[Qemu-devel] [PATCH 08/17] coroutine-lock: reschedule coroutine on the AioContext it was running on

2017-01-20 Thread Paolo Bonzini
As a small step towards the introduction of multiqueue, we want coroutines to remain on the same AioContext that started them, unless they are moved explicitly with e.g. aio_co_schedule. This patch avoids that coroutines switch AioContext when they use a CoMutex. For now it does not make much of

[Qemu-devel] [PATCH 12/17] block: explicitly acquire aiocontext in callbacks that need it

2017-01-20 Thread Paolo Bonzini
This covers both file descriptor callbacks and polling callbacks, since they execute related code. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block/curl.c | 16 +--- block/iscsi.c | 4

Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-20 Thread Paolo Bonzini
On 19/01/2017 18:01, Stefan Hajnoczi wrote: >>> This is a big and somewhat risky change. Have you run any performance >>> benchmarks? >> >> Not recently; I ran them a year ago and there was no measurable difference. > > Good, please re-run for the final version. Done, went better than

Re: [Qemu-devel] [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/deflate process

2017-01-20 Thread Michael S. Tsirkin
On Thu, Jan 19, 2017 at 01:44:36AM +, Li, Liang Z wrote: > > > > > + *range = cpu_to_le64((base_pfn << > > > > > + VIRTIO_BALLOON_NR_PFN_BITS) | 0); > > > > > + *(range + 1) = cpu_to_le64(pages); > > > > > + vb->resp_pos += 2; > >

[Qemu-devel] [PATCH 01/17] aio: introduce aio_co_schedule and aio_co_wake

2017-01-20 Thread Paolo Bonzini
aio_co_wake provides the infrastructure to start a coroutine on a "home" AioContext. It will be used by CoMutex and CoQueue, so that coroutines don't jump from one context to another when they go to sleep on a mutex or waitqueue. However, it can also be used as a more efficient alternative to

[Qemu-devel] [PATCH 03/17] test-thread-pool: use generic AioContext infrastructure

2017-01-20 Thread Paolo Bonzini
Once the thread pool starts using aio_co_wake, it will also need qemu_get_current_aio_context(). Make test-thread-pool create an AioContext with qemu_init_main_loop, so that stubs/iothread.c and tests/iothread.c can provide the rest. Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

2017-01-20 Thread Stafford Horne
(+CC Rth) I believe you also have some experience with openrisc. Any thought on the below? On Sat, Jan 14, 2017 at 05:04:35PM +0900, Stafford Horne wrote: > Hello, > > On Sat, Jan 14, 2017 at 12:29:32PM +0800, Jia Liu wrote: > > Hi all, > > > > On Sat, Jan 14, 2017 at 6:02 AM, Stafford Horne

Re: [Qemu-devel] [PATCH] virtio: force VIRTIO_F_IOMMU_PLATFORM

2017-01-20 Thread Michael S. Tsirkin
On Fri, Jan 20, 2017 at 11:28:53AM +0800, Jason Wang wrote: > > > On 2017年01月20日 06:27, Michael S. Tsirkin wrote: > > On Thu, Jan 19, 2017 at 11:12:21AM +0800, Jason Wang wrote: > > > > > > On 2017年01月19日 01:50, Michael S. Tsirkin wrote: > > > > On Wed, Jan 18, 2017 at 10:42:48AM +0800, Jason

[Qemu-devel] [PATCH v3 4/7] ARM big-endian semihosting support.

2017-01-20 Thread Julian Brown
This patch introduces an ARM-specific version of the memory read/write, etc. functions used for semihosting, in order to byte-swap (big-endian) target memory that is to be interpreted by the (little-endian) host. The target_memory_rw_debug function is used that knows about the byte-reversal used

[Qemu-devel] [PATCH v3 7/7] ARM BE32 watchpoint fix.

2017-01-20 Thread Julian Brown
In BE32 mode, sub-word size watchpoints can fail to trigger because the address of the access is adjusted in the opcode helpers before being compared with the watchpoint registers. This patch reverses the address adjustment before performing the comparison with the help of a new CPUClass hook.

[Qemu-devel] [PATCH v3 1/7] Add cfgend parameter for ARM CPU selection.

2017-01-20 Thread Julian Brown
The new "cfgend" parameter can be given after the CPU name, e.g. "-cpu=arm926,cfgend=yes". Unlike earlier versions of the patch, CPU attribute parsing is left to board initialisation code: for the "virt" board, this was being done already, and this patch makes the integratorcp board init do so

[Qemu-devel] [PATCH v3 5/7] ARM big-endian system-mode gdbstub support.

2017-01-20 Thread Julian Brown
When debugging a big-endian (either BE8 or BE32) executable, GDB uses a big-endian byte ordering for its remote protocol. The gdb stub code in QEMU needs to interpret data in host (little-endian) order in arm_cpu_gdb_read_register and arm_cpu_gdb_write_register, so this patch arranges to

[Qemu-devel] [PATCH v3 3/7] Move target_memory_rw_debug function.

2017-01-20 Thread Julian Brown
This patch moves the target_memory_rw_debug function to include/exec/cpu-all.h, so that it can be used by the ARM semihosting code as well as the gdbstub code. (I tried Peter Maydell's suggestion of include/qom/cpu.h as a location for the function, but that raised uncomfortably-many dependency

[Qemu-devel] [PATCH v3 6/7] Fix Thumb-1 BE32 execution and disassembly.

2017-01-20 Thread Julian Brown
Thumb-1 code has some issues in BE32 mode (as currently implemented). In short, since bytes are swapped within words at load time for BE32 executables, this also swaps pairs of adjacent Thumb-1 instructions. This patch un-swaps those pairs of instructions again, both for execution, and for

[Qemu-devel] [PATCH v3 0/7] ARM BE8/BE32 big-endian system-mode fixes (semihosting, gdbstub)

2017-01-20 Thread Julian Brown
This is the third iteration of a series of patches to implement semihosting/gdbstub support for big-endian ARM system mode. The previous series started here: http://lists.nongnu.org/archive/html/qemu-devel/2016-12/msg00972.html I've (hopefully!) addressed all the comments from the second round

[Qemu-devel] [PATCH v3 2/7] Honour reset_sctlr EE/B bits during reset.

2017-01-20 Thread Julian Brown
This patch uses the reset value of the SCTLR register (e.g. as modified by the "cfgend" parameter introduced by the previous patch) to set the endianness used by QEMU when it is invoked without a kernel or firmware image. The intended use case is loading code via GDB as follows: (gdb) target

[Qemu-devel] [PATCH v3 3/3] block: get max_transfer limit for char (scsi-generic) devices

2017-01-20 Thread Eric Farman
We can get the maximum number of bytes for a single I/O transfer from the BLKSECTGET ioctl, but we only perform this for block devices. scsi-generic devices are represented as character devices, and so do not issue this today. Update this, so that virtio-scsi devices using the scsi-generic

[Qemu-devel] [PATCH v3 2/3] block: Fix target variable of BLKSECTGET ioctl

2017-01-20 Thread Eric Farman
Commit 6f6071745bd0 ("raw-posix: Fetch max sectors for host block device") introduced a routine to call the kernel BLKSECTGET ioctl, which stores the result back to user space. However, the size of the data returned depends on the routine handling the ioctl. The (compat_)blkdev_ioctl returns a

[Qemu-devel] [PATCH v3 1/3] hw/scsi: Fix debug message of cdb structure in scsi-generic

2017-01-20 Thread Eric Farman
When running with debug enabled, the scsi-generic cdb that is dumped skips byte 0 of the command, which is the opcode. This makes identifying which command is being issued/completed a little difficult. Example: 0x00 0x00 0x01 0x00 0x00 scsi-generic: scsi_read_data 0x0 scsi-generic: Data

[Qemu-devel] [PATCH v3 0/3] scsi-generic and BLKSECTGET

2017-01-20 Thread Eric Farman
In the Linux kernel, I see two (three) places where the BLKSECTGET ioctl is handled: (1) block/(compat_)ioctl.c -- (compat_)blkdev_ioctl (2) drivers/scsi/sg.c -- sg_ioctl The former has been around forever[1], and returns a short value measured in sectors. A sector is generally assumed to be

Re: [Qemu-devel] -M niagara -nodefaults crashes

2017-01-20 Thread Markus Armbruster
Artyom Tarasenko writes: > On Fri, Jan 20, 2017 at 2:26 PM, Markus Armbruster wrote: >> Watch this: >> >> $ gdb --args bld/sparc64-softmmu/qemu-system-* -nodefaults -M niagara >> [...] >> (gdb) r >> Starting program: >>

[Qemu-devel] [Bug 1657538] Re: qemu 2.7.x 2.8 softmmu dont work on BE machine

2017-01-20 Thread luigiburdo
i386-softmmu: ./qemu-system-i386 -nographic qemu-system-i386: Trying to execute code outside RAM or ROM at 0x000a This usually means one of the following happened: and so and so ./qemu-system-ppc -nographic nothing happen ... no exit on console . on 2.6.2 i have: qemu-system-ppc

Re: [Qemu-devel] [PULL 0/6] Net patches

2017-01-20 Thread Peter Maydell
On 20 January 2017 at 03:07, Jason Wang wrote: > The following changes since commit 0f6bcf68a99efdc531b209551f2b760b0bdcc554: > > Merge remote-tracking branch 'remotes/artyom/tags/pull-sun4v-20170118' into > staging (2017-01-19 18:34:13 +) > > are available in the git

[Qemu-devel] [PATCH] hw/isa/isa-bus: Set category of the "isabus-bridge" device

2017-01-20 Thread Thomas Huth
It has "bridge" in its name, so it should be in the category DEVICE_CATEGORY_BRIDGE. Signed-off-by: Thomas Huth --- hw/isa/isa-bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 9d07b11..0ffbc8d 100644 --- a/hw/isa/isa-bus.c +++

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: no ITS on older machine types

2017-01-20 Thread Peter Maydell
On 10 October 2016 at 17:35, Andrew Jones wrote: > We should avoid exposing new hardware (through DT and ACPI) on older > machine types. This patch keeps 2.7 and older from changing, despite > the introduction of ITS support for 2.8. > > Signed-off-by: Andrew Jones

  1   2   3   >