Re: [Qemu-devel] [RFC PATCH] MAINTAINERS: Add an entry for hw/core/null-machine.c

2017-01-22 Thread Marcel Apfelbaum
On 01/23/2017 07:54 AM, Thomas Huth wrote: The "Machine core" section sounds like a good match for this file. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b5ebfab..5be2033 100644 --- a/MAINTAINERS +++ b/MAINTAINE

Re: [Qemu-devel] qemu-2.8-rc4 is broken

2017-01-22 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > >> From: Alex Bennée [mailto:alex.ben...@linaro.org] > > > > Sorry, this is another problem which occurs only in icount replay mode: > > 1. cpu_handle_exception tries to force exception when is cannot occur due to >

[Qemu-devel] [PATCH v3 3/6] ACPI: Add Virtual Machine Generation ID support

2017-01-22 Thread ben
From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, and ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must be "auto" or in UUID forma

[Qemu-devel] [PATCH v3 5/6] qmp/hmp: add set-vm-generation-id commands

2017-01-22 Thread ben
From: Igor Mammedov Add set-vm-generation-id command to set Virtual Machine Generation ID counter. QMP command example: { "execute": "set-vm-generation-id", "arguments": { "guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87" } } HMP command example: set-v

[Qemu-devel] [PATCH v3 2/6] linker-loader: add new 'allocate and return address' cmd

2017-01-22 Thread ben
From: Ben Warren This adds a new linker-loader command to instruct the guest to allocate memory for a fw_cfg file and write the address back into another writeable fw_cfg file. Knowing this address, QEMU can then write into guest memory at runtime. Signed-off-by: Ben Warren --- hw/acpi/bios-l

[Qemu-devel] [PATCH v3 4/6] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

2017-01-22 Thread ben
From: Igor Mammedov Add commands to query Virtual Machine Generation ID counter. QMP command example: { "execute": "query-vm-generation-id" } HMP command example: info vm-generation-id Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Ben Warren --- hmp-commands-i

[Qemu-devel] [PATCH v3 6/6] PC: Support dynamic sysbus on pc_i440fx

2017-01-22 Thread ben
From: Ben Warren This allows pc_i440fx-based machines to add new devices such as VM Generation ID directly to the sysbus. Signed-off-by: Ben Warren --- hw/i386/pc_piix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 9f102aa..c8ad99c 100644 ---

[Qemu-devel] [PATCH v3 0/6] Add support for VM Generation ID

2017-01-22 Thread ben
From: Ben Warren This patch set adds support for passing a GUID to Windows guests. It is a re-implementation of previous patch sets written by Igor Mammedov et al, but this time passing the GUID data as a fw_cfg blob. This patch set has dependencies on new guest functionality, in particular the

[Qemu-devel] [PATCH v3 1/6] ACPI: Add a function for building named qword entries

2017-01-22 Thread ben
From: Ben Warren This is initially used to patch a 64-bit address into the VM Generation ID SSDT Signed-off-by: Ben Warren --- hw/acpi/aml-build.c | 28 include/hw/acpi/aml-build.h | 4 2 files changed, 32 insertions(+) diff --git a/hw/acpi/aml-build

Re: [Qemu-devel] [PATCH RFC v4 19/20] intel_iommu: unmap existing pages before replay

2017-01-22 Thread Peter Xu
On Mon, Jan 23, 2017 at 09:57:23AM +0800, Jason Wang wrote: > > > On 2017年01月22日 17:09, Peter Xu wrote: > >On Sun, Jan 22, 2017 at 04:13:32PM +0800, Jason Wang wrote: > >> > >>On 2017年01月20日 21:08, Peter Xu wrote: > >>>Previous replay works for domain switch only if the original domain does > >>>

Re: [Qemu-devel] [PATCH] qapi: Remove unwanted commas after #optional keyword

2017-01-22 Thread Markus Armbruster
Stefan Weil writes: > We don't want that commas to be part of the generated documentation, > so remove them. > > Signed-off-by: Stefan Weil > --- > > This is an alternative solution for the issue which is also addressed > by my previous patch http://patchwork.ozlabs.org/patch/718177/. > > It's a

Re: [Qemu-devel] [RFC 08/13] pc: add writeonly 'cpu' property to PCMachine

2017-01-22 Thread Bharata B Rao
On Thu, Jan 19, 2017 at 04:04:23PM +0100, Igor Mammedov wrote: > On Wed, 18 Jan 2017 16:57:13 -0200 > Eduardo Habkost wrote: > > > On Wed, Jan 18, 2017 at 06:13:24PM +0100, Igor Mammedov wrote: > > > it will allow generic numa code to set cpu to numa node mapping > > > in target independent manne

[Qemu-devel] [RFC PATCH] MAINTAINERS: Add an entry for hw/core/null-machine.c

2017-01-22 Thread Thomas Huth
The "Machine core" section sounds like a good match for this file. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b5ebfab..5be2033 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -813,6 +813,7 @@ M: Eduardo Habkost M

Re: [Qemu-devel] [PATCH] Change name of live migration thread

2017-01-22 Thread Amit Shah
On (Sun) 22 Jan 2017 [12:47:51], Pankaj Gupta wrote: > Change the name of live migration thread from 'migration' > to 'qemu_vm_migration' to identify it clearly. 'migration' > is a generic word and kernel also has tasks for process > migration with the name 'migration/cpu#'. Makes sense. Review

Re: [Qemu-devel] [PATCH 01/21] backup: move from done_bitmap to copy_bitmap

2017-01-22 Thread Jeff Cody
On Fri, Dec 23, 2016 at 05:28:44PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Use HBitmap copy_bitmap instead of done_bitmap. This is needed to unify > backup loop for full/incremental modes in future patches. > > We reset bit of the copy_bitmap immediately after checking it in > backup_do_cow()

Re: [Qemu-devel] [PATCH v4 0/2] block/qapi: refactor and optimize the qmp_query_blockstats()

2017-01-22 Thread Dou Liyang
Hi, Markus Here is the non-RFC patch. Any suggestions are welcome. :) Thanks, Liyang. At 01/15/2017 04:01 PM, Dou Liyang wrote: Change log v3 -> v4: 1. Develop these into the non-RFC patches. 2. Fix some comments. 3. do declarations first. Change log v2 -> v3: 1. Remove the unnece

Re: [Qemu-devel] [RFC PATCH 04/17] target/ppc/POWER9: Add ISAv3.00 MMU definition

2017-01-22 Thread Suraj Jitindar Singh
On Tue, 2017-01-17 at 11:33 +1100, Suraj Jitindar Singh wrote: > On Tue, 2017-01-17 at 08:36 +1100, David Gibson wrote: > > > > On Fri, Jan 13, 2017 at 05:28:10PM +1100, Suraj Jitindar Singh > > wrote: > > > > > > > > > POWER9 processors implement the mmu as defined in version 3.00 of > > > the

Re: [Qemu-devel] [RFC PATCH 05/17] target/ppc/POWER9: Adapt LPCR handling for POWER9

2017-01-22 Thread Suraj Jitindar Singh
On Tue, 2017-01-17 at 15:37 +1100, David Gibson wrote: > On Tue, Jan 17, 2017 at 11:48:31AM +1100, Suraj Jitindar Singh wrote: > > > > On Tue, 2017-01-17 at 08:40 +1100, David Gibson wrote: > > > > > > On Fri, Jan 13, 2017 at 05:28:11PM +1100, Suraj Jitindar Singh > > > wrote: > > > > > > > > >

Re: [Qemu-devel] Towards an ivshmem 2.0?

2017-01-22 Thread Wang, Wei W
On Saturday, January 21, 2017 12:38 AM, Jan Kiszka wrote: > On 2017-01-20 12:54, Wang, Wei W wrote: > > On Tuesday, January 17, 2017 5:46 PM, Jan Kiszka wrote: > >> On 2017-01-17 10:13, Wang, Wei W wrote: > >>> Hi Jan, > >>> > >>> On Monday, January 16, 2017 9:10 PM, Jan Kiszka wrote: > On 201

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Peter Xu
On Mon, Jan 23, 2017 at 10:01:11AM +0800, Jason Wang wrote: > > > On 2017年01月20日 21:08, Peter Xu wrote: > >This patch is based on Aviv Ben-David ()'s patch > >upstream: > > > > "IOMMU: enable intel_iommu map and unmap notifiers" > > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg014

Re: [Qemu-devel] [PATCH RFC v4 15/20] intel_iommu: provide its own replay() callback

2017-01-22 Thread Peter Xu
On Mon, Jan 23, 2017 at 11:12:27AM +0800, Jason Wang wrote: > > > On 2017年01月23日 10:54, Peter Xu wrote: > >+trace_vtd_page_walk_skip_read(iova, iova_next); > >+skipped_local++; > >+goto next; > >+} > >+ > >+if (vtd_slpte_

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Peter Xu
On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: > > > On 2017年01月22日 17:04, Peter Xu wrote: > >On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: > > > >[...] > > > >>>+static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, > >>>+

Re: [Qemu-devel] [PATCH RFC v4 15/20] intel_iommu: provide its own replay() callback

2017-01-22 Thread Jason Wang
On 2017年01月23日 10:54, Peter Xu wrote: +trace_vtd_page_walk_skip_read(iova, iova_next); +skipped_local++; +goto next; +} + +if (vtd_slpte_nonzero_rsvd(slpte, level)) { +trace_vtd_page_walk_skip_reserve(iova, iova_next); +

Re: [Qemu-devel] [PATCH RFC v4 15/20] intel_iommu: provide its own replay() callback

2017-01-22 Thread Peter Xu
On Mon, Jan 23, 2017 at 09:48:48AM +0800, Jason Wang wrote: > > > On 2017年01月22日 16:51, Peter Xu wrote: > >On Sun, Jan 22, 2017 at 03:56:10PM +0800, Jason Wang wrote: > > > >[...] > > > >>>+/** > >>>+ * vtd_page_walk_level - walk over specific level for IOVA range > >>>+ * > >>>+ * @addr: base GP

[Qemu-devel] [PULL 23/26] target-hppa: Implement shifts and deposits

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/translate.c | 309 1 file changed, 309 insertions(+) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 14fe4bb..093a65e 100644 --- a/target/hppa/translate.c +++ b/target/hppa/tran

[Qemu-devel] [PULL 21/26] target-hppa: Implement branches

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/translate.c | 477 1 file changed, 477 insertions(+) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 2ad651c..1d0976f 100644 --- a/target/hppa/translate.c +++ b/target/hppa/tran

[Qemu-devel] [PATCH] util/envlist: Fix 2 bugs in envlist_setenv and envlist_unsetenv

2017-01-22 Thread Hu Chaojian
From: chaojianhu In envlist_setenv, if any malloc fails, there will be inconsistency on el_count. And in envlist_unsetenv, if env is "", the strncmp will be passed, eventually wrong envlist_entry (shoud be the first one) will be removed. Finally, in envlist_parse, to delimit environments with

[Qemu-devel] [PULL 24/26] target-hppa: Implement loads and stores

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/helper.h| 3 + target/hppa/op_helper.c | 78 ++ target/hppa/translate.c | 618 3 files changed, 699 insertions(+) diff --git a/target/hppa/helper.h b/target/hppa/helper.h index ecff17c..8

[Qemu-devel] [PULL 18/26] target-hppa: Add framework and enable compilation

2017-01-22 Thread Richard Henderson
This is just about the minimum required to enable compilation without actually executing any instructions. This contains the HPPACPU structure and the required callbacks, the gdbstub, the basic translation loop, and a translate_one function that always results in an illegal instruction. Signed-of

[Qemu-devel] [PULL 26/26] target-hppa: Implement floating-point insns

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/helper.h| 55 target/hppa/op_helper.c | 394 ++ target/hppa/translate.c | 728 3 files changed, 1177 insertions(+) diff --git a/target/hppa/helper.h b/target/hppa/h

[Qemu-devel] [PULL 11/26] linux-user: Add HPPA target_syscall.h

2017-01-22 Thread Richard Henderson
Which is primarily a re-definition of errno numbers. Signed-off-by: Richard Henderson --- linux-user/hppa/target_syscall.h | 237 +++ 1 file changed, 237 insertions(+) create mode 100644 linux-user/hppa/target_syscall.h diff --git a/linux-user/hppa/target_sy

[Qemu-devel] [PULL 20/26] target-hppa: Implement basic arithmetic

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/helper.h| 2 + target/hppa/op_helper.c | 23 ++ target/hppa/translate.c | 882 3 files changed, 907 insertions(+) diff --git a/target/hppa/helper.h b/target/hppa/helper.h index 9c94dac..ecff1

[Qemu-devel] [PULL 22/26] target-hppa: Implement linux-user gateway page

2017-01-22 Thread Richard Henderson
For linux, page 0 is mapped as an execute-only gateway. A gateway page is a special bit in the page table that allows a B,GATE insn within that page to raise processor permissions. This is how system calls are implemented for HPPA. Rather than actually map anything here, or handle permissions at

[Qemu-devel] [PULL 25/26] target-hppa: Implement system and memory-management insns

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/helper.h| 3 + target/hppa/op_helper.c | 10 +++ target/hppa/translate.c | 206 3 files changed, 219 insertions(+) diff --git a/target/hppa/helper.h b/target/hppa/helper.h index 88db719..d51c

[Qemu-devel] [PULL 19/26] target-hppa: Add nullification framework

2017-01-22 Thread Richard Henderson
The HPPA cpu has a unique form of predicated execution in which almost any instruction can set the PSW[N] (or "nullify") bit, which suppresses execution (and even decoding) of the following instruction. Execution of a nullified insn clears the PSW[N] bit. This adds a generic framework for branchi

[Qemu-devel] [PULL 10/26] linux-user: Add HPPA termbits.h

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/hppa/termbits.h | 219 + 1 file changed, 219 insertions(+) create mode 100644 linux-user/hppa/termbits.h diff --git a/linux-user/hppa/termbits.h b/linux-user/hppa/termbits.h new file mode 100644 index 00

[Qemu-devel] [PULL 15/26] linux-user: Add HPPA signal handling

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/signal.c | 191 +++- 1 file changed, 190 insertions(+), 1 deletion(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index c750053..0a5bb4e 100644 --- a/linux-user/signal.c +++ b/linux-user/si

[Qemu-devel] [PULL 01/26] Revert "Remove remainders of HPPA backend"

2017-01-22 Thread Richard Henderson
This reverts commit d41f3c3cc7a5fb9de144cc4022da14a9ff010671. Signed-off-by: Richard Henderson --- configure |5 + disas.c |2 + disas/Makefile.objs |1 + disas/hppa.c | 2832 + linux-use

[Qemu-devel] [PULL 14/26] linux-user: Add HPPA target_signal.h and target_cpu.h

2017-01-22 Thread Richard Henderson
The cpu.h structure that these manipulate hasn't been defined yet, but we haven't enabled compilation yet either. Signed-off-by: Richard Henderson --- linux-user/hppa/target_cpu.h| 35 +++ linux-user/hppa/target_signal.h | 29 + 2 f

[Qemu-devel] [PULL 09/26] linux-user: Add HPPA syscall numbers

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/hppa/syscall_nr.h | 353 +++ 1 file changed, 353 insertions(+) create mode 100644 linux-user/hppa/syscall_nr.h diff --git a/linux-user/hppa/syscall_nr.h b/linux-user/hppa/syscall_nr.h new file mode 100644 in

[Qemu-devel] [PULL 16/26] linux-user: Add HPPA startup and main loop

2017-01-22 Thread Richard Henderson
Including support for the atomic memory op syscalls. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 24 +++ linux-user/main.c| 172 +++ 2 files changed, 196 insertions(+) diff --git a/linux-user/elfload.c b/linux-user/elfload

[Qemu-devel] [PULL 13/26] linux-user: Add HPPA target_structs.h

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/hppa/target_structs.h | 54 1 file changed, 54 insertions(+) create mode 100644 linux-user/hppa/target_structs.h diff --git a/linux-user/hppa/target_structs.h b/linux-user/hppa/target_structs.h new file mod

[Qemu-devel] [PULL 06/26] linux-user: Handle more IPV6 sockopts

2017-01-22 Thread Richard Henderson
All of the ones added have an "int" parameter that needs no more adjustment to pass on to the host. Signed-off-by: Richard Henderson --- linux-user/syscall.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/sysca

[Qemu-devel] [PULL 05/26] linux-user: Handle ERFKILL and EHWPOISON

2017-01-22 Thread Richard Henderson
With definitions for generic, alpha and mips taken from 4.9-rc2. Signed-off-by: Richard Henderson --- linux-user/alpha/target_syscall.h | 2 ++ linux-user/errno_defs.h| 3 +++ linux-user/mips/target_syscall.h | 5 + linux-user/mips64/target_syscall.h | 5 + linux-user/sysc

[Qemu-devel] [PULL 17/26] target-hppa: Add softfloat specializations

2017-01-22 Thread Richard Henderson
Like the original MIPS, HPPA has the MSB of an SNaN set. However, it has different rules for silencing an SNaN: (1) msb is cleared and (2) msb-1 must be set if the fraction is now zero, and (implementation defined) may be set always. I haven't checked real hardware but chose the set always alternat

[Qemu-devel] [PULL 08/26] linux-user: Add HPPA socket.h definitions

2017-01-22 Thread Richard Henderson
Split this out into a "cpu/sockbits.h" file now, like we ought to do for all of the other targets. Signed-off-by: Richard Henderson --- linux-user/hppa/sockbits.h | 97 ++ linux-user/socket.h| 2 + 2 files changed, 99 insertions(+) create mod

[Qemu-devel] [PULL 04/26] linux-user: Add SIOCGPGRP, SIOCGSTAMP, SIOCGSTAMPNS

2017-01-22 Thread Richard Henderson
From: Helge Deller Mirror syscall_defs.h for the element type of struct timeval and struct timespec, even though that's not 100% accurate for each guest. Signed-off-by: Helge Deller [rth: Changed the MK_ARRAY types as per above; added ioctl.h entries.] Signed-off-by: Richard Henderson --- lin

[Qemu-devel] [PULL 02/26] linux-user: Support stack-grows-up in elfload.c

2017-01-22 Thread Richard Henderson
HPPA is a (the) stack-grows-up target, and supporting that requires rearranging how we compute addresses while laying out the initial program stack. In addition, hppa32 requires 64-byte stack alignment so parameterize that as well. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 235

[Qemu-devel] [PULL 00/26] New hppa-linux target support

2017-01-22 Thread Richard Henderson
anch 'remotes/cohuck/tags/s390x-20170120-v2' into staging (2017-01-20 15:53:58 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-hppa-20170122 for you to fetch changes up to 0ce588d6c60c338c0856b0dac78d19fc7e698477: target-hppa: Implement float

[Qemu-devel] [PULL 03/26] linux-user: Handle TIOCSTART and TIOCSTOP

2017-01-22 Thread Richard Henderson
From: Helge Deller Some architectures (ppc, alpha, sparc, parisc, sh and xtensa) define the BSD TIOCSTART and TIOCSTOP ioctls in their kernel headers to provide compatibility to other operating systems. Those ioctls are not implemented in Linux, nevertheless, bash will use this ioctl if it's ava

[Qemu-devel] [PULL 12/26] linux-user: Add HPPA definitions to syscall_defs.h

2017-01-22 Thread Richard Henderson
--- linux-user/syscall_defs.h | 131 +- 1 file changed, 130 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 957b737..39848a8 100644 --- a/linux-user/syscall_defs.h +++ b/linux-user/syscall_defs.h @@

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Jason Wang
On 2017年01月23日 10:01, Jason Wang wrote: On 2017年01月20日 21:08, Peter Xu wrote: This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some con

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Jason Wang
On 2017年01月20日 21:08, Peter Xu wrote: This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some content, and added my own codes. Instead

Re: [Qemu-devel] [PATCH RFC v4 19/20] intel_iommu: unmap existing pages before replay

2017-01-22 Thread Jason Wang
On 2017年01月22日 17:09, Peter Xu wrote: On Sun, Jan 22, 2017 at 04:13:32PM +0800, Jason Wang wrote: On 2017年01月20日 21:08, Peter Xu wrote: Previous replay works for domain switch only if the original domain does not have mapped pages. For example, if we switch domain from A to B, it will only w

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Jason Wang
On 2017年01月22日 17:04, Peter Xu wrote: On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: [...] +static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, + uint16_t domain_id, hwaddr addr, + u

Re: [Qemu-devel] [PATCH RFC v4 15/20] intel_iommu: provide its own replay() callback

2017-01-22 Thread Jason Wang
On 2017年01月22日 17:36, Peter Xu wrote: Besides this one, I tried to fix the comments in this function as below, hope this is better (I removed 1-3 thing since I think that's clearer from below code): diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index e958f53..f3fe8c4 100644 --- a/

Re: [Qemu-devel] [PATCH RFC v4 15/20] intel_iommu: provide its own replay() callback

2017-01-22 Thread Jason Wang
On 2017年01月22日 16:51, Peter Xu wrote: On Sun, Jan 22, 2017 at 03:56:10PM +0800, Jason Wang wrote: [...] +/** + * vtd_page_walk_level - walk over specific level for IOVA range + * + * @addr: base GPA addr to start the walk + * @start: IOVA range start address + * @end: IOVA range end address

[Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-22 Thread Shannon Zhao
From: Shannon Zhao For ARM virt machine, if we use virt-2.7 which will not create ITS node, the virtio-net can not recieve interrupts so it can't get ip address through dhcp. This fixes commit 83d768b(virtio: set ISR on dataplane notifications). Signed-off-by: Shannon Zhao --- V2: Factor out a

[Qemu-devel] [Bug 1658506] [NEW] qemu/hw/intc/arm_gicv3_cpuif.c:2433: bad expression ?

2017-01-22 Thread dcb
Public bug reported: qemu/hw/intc/arm_gicv3_cpuif.c:2433]: (style) Expression '(X & 0x2000) == 0x1' is always false. Source code is ((lr & ICH_LR_EL2_HW) == 1 || (lr & ICH_LR_EL2_EOI) == 0)) { Maybe better code ((lr & ICH_LR_EL2_HW) != 0 || (lr & ICH_LR_EL2_EO

Re: [Qemu-devel] QEMU website (wiki) improvements

2017-01-22 Thread Stefan Weil
On 03/02/15 23:12, Stefan Hajnoczi wrote: On Sat, Feb 28, 2015 at 04:29:44PM +0100, Stefan Weil wrote: * It does not support secure access (https), so each login is insecure. Can we get a free server certificate? This is on my todo list. I'm travelling right now but will work on it over the

[Qemu-devel] [PATCH] qapi: Remove unwanted commas after #optional keyword

2017-01-22 Thread Stefan Weil
We don't want that commas to be part of the generated documentation, so remove them. Signed-off-by: Stefan Weil --- This is an alternative solution for the issue which is also addressed by my previous patch http://patchwork.ozlabs.org/patch/718177/. It's also possible to apply both patches. St

Re: [Qemu-devel] [PATCH v3 0/3] scsi-generic and BLKSECTGET

2017-01-22 Thread Fam Zheng
On Fri, 01/20 17:25, Eric Farman wrote: > Changes: > v2->v3: > - Move byte/sector conversions to patch 2 [Fam Zheng] > - Rename "max_sectors" when holding a byte value [Fam Zheng] > v1->v2: > - Patch 3, make hdev_get_max_transfer_length return bytes [Fam Zheng] Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH] qapi2texi: Suppress unwanted commas in generated output

2017-01-22 Thread Marc-André Lureau
Hi On Sun, Jan 22, 2017 at 5:39 PM Stefan Weil wrote: > Parts of the code use #optional followed by a comma. > > We don't want that comma to be part of the generated documentation, > so remove it, too. > > Signed-off-by: Stefan Weil > --- > > I added the generated documentation to https://qemu.

[Qemu-devel] [PATCH] qapi2texi: Suppress unwanted commas in generated output

2017-01-22 Thread Stefan Weil
Parts of the code use #optional followed by a comma. We don't want that comma to be part of the generated documentation, so remove it, too. Signed-off-by: Stefan Weil --- I added the generated documentation to https://qemu.weilnetz.de/doc/. See https://qemu.weilnetz.de/doc/qemu-qmp-ref.html fo

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-01-22 Thread Wouter Verhelst
On Sun, Jan 22, 2017 at 06:25:09PM +0800, Bob Chen wrote: > Hi folks, > > My time schedule doesn't allow me to wait for the community's solution, so I > started to work on quick fix, which is to add a 'bdrv_truncate' function to > the > current NBD's BlockDriver. Basically it's an 'active resize'

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-01-22 Thread Bob Chen
Hi folks, My time schedule doesn't allow me to wait for the community's solution, so I started to work on quick fix, which is to add a 'bdrv_truncate' function to the current NBD's BlockDriver. Basically it's an 'active resize' implementation. I also realized that the 'bdrv_truncate' caller stack

Re: [Qemu-devel] [PATCH RFC v4 15/20] intel_iommu: provide its own replay() callback

2017-01-22 Thread Peter Xu
On Sun, Jan 22, 2017 at 04:51:18PM +0800, Peter Xu wrote: > On Sun, Jan 22, 2017 at 03:56:10PM +0800, Jason Wang wrote: > > [...] > > > >+/** > > >+ * vtd_page_walk_level - walk over specific level for IOVA range > > >+ * > > >+ * @addr: base GPA addr to start the walk > > >+ * @start: IOVA range

Re: [Qemu-devel] [PATCH RFC v4 19/20] intel_iommu: unmap existing pages before replay

2017-01-22 Thread Peter Xu
On Sun, Jan 22, 2017 at 04:13:32PM +0800, Jason Wang wrote: > > > On 2017年01月20日 21:08, Peter Xu wrote: > >Previous replay works for domain switch only if the original domain does > >not have mapped pages. For example, if we switch domain from A to B, it > >will only work if A has no existing map

Re: [Qemu-devel] [PATCH] util/envlist: Fix 2 bugs in envlist_setenv and envlist_unsetenv

2017-01-22 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] util/envlist: Fix 2 bugs in envlist_setenv and envlist_unsetenv Message-id: cy1pr17mb031324368f190b92efa547acdb...@cy1pr17mb0313.namprd17.prod.outlook.com Type: series

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Peter Xu
On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: [...] > >+static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, > >+ uint16_t domain_id, hwaddr addr, > >+ uint8_t am) > >+{ > >+IntelIOMM

[Qemu-devel] [PATCH] util/envlist: Fix 2 bugs in envlist_setenv and envlist_unsetenv

2017-01-22 Thread Hu Chaojian
From: chaojianhu In envlist_setenv, if any malloc fails, there will be inconsistency on el_count. And in envlist_unsetenv, if env is "", the strncmp will be passed, eventually wrong envlist_entry (shoud be the first one) will be removed. Finally, in envlist_parse, to delimit environments with

Re: [Qemu-devel] [PATCH RFC v4 15/20] intel_iommu: provide its own replay() callback

2017-01-22 Thread Peter Xu
On Sun, Jan 22, 2017 at 03:56:10PM +0800, Jason Wang wrote: [...] > >+/** > >+ * vtd_page_walk_level - walk over specific level for IOVA range > >+ * > >+ * @addr: base GPA addr to start the walk > >+ * @start: IOVA range start address > >+ * @end: IOVA range end address (start <= addr < end) > >

Re: [Qemu-devel] [PATCH RFC v4 19/20] intel_iommu: unmap existing pages before replay

2017-01-22 Thread Jason Wang
On 2017年01月20日 21:08, Peter Xu wrote: Previous replay works for domain switch only if the original domain does not have mapped pages. For example, if we switch domain from A to B, it will only work if A has no existing mapping. If there is, then there's problem - current replay didn't make sure

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Jason Wang
On 2017年01月20日 21:08, Peter Xu wrote: This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some content, and added my own codes. Instead