Re: [Qemu-devel] [PATCH 01/18] block: move AioContext, QEMUTimer, main-loop to libqemuutil

2017-02-13 Thread Fam Zheng
On Mon, 02/13 14:52, Paolo Bonzini wrote: > --- /dev/null > +++ b/util/aiocb.c > @@ -0,0 +1,55 @@ > +/* > + * BlockAIOCB allocation > + * > + * Copyright (c) 2003-2017 Fabrice Bellard and the QEMU team Hmm, I'm not lawyer, just wondering if the QEMU team is a legal entity that can hold copyright?

Re: [Qemu-devel] [RFC PATCH 06/41] block: Involve block drivers in permission granting

2017-02-13 Thread Fam Zheng
On Mon, 02/13 18:22, Kevin Wolf wrote: > +int bdrv_child_try_set_perm(BdrvChild *c, uint64_t perm, uint64_t shared, > +Error **errp) > +{ > +int ret; > + > +ret = bdrv_child_check_perm(c, perm, shared, errp); > +if (ret < 0) { > +return ret; > +}

Re: [Qemu-devel] [PATCH 1/2] ppc/xics: remove set_nr_irqs() handler from XICSStateClass

2017-02-13 Thread David Gibson
On Mon, Feb 13, 2017 at 03:09:16PM +0100, Cédric Le Goater wrote: > Today, the ICS (Interrupt Controller Source) object is created and > realized by the init and realize routines of the XICS object, but some > of the parameters are only known at the machine level. > > These parameters are passed

[Qemu-devel] [Bug 912983] Re: Unable to install OS/2 Warp v3 past disk 2

2017-02-13 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/912983 Title: Unable to

[Qemu-devel] [Bug 922355] Re: qemu crashes when invoked on Pandaboard

2017-02-13 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/922355 Title: qemu

[Qemu-devel] [Bug 938945] Re: Slirp cannot be forward and makes segmentation faults

2017-02-13 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/938945 Title: Slirp

[Qemu-devel] [Bug 906864] Re: Always mouse grabbing with -usbdevice tablet

2017-02-13 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/906864 Title: Always

Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates

2017-02-13 Thread Programmingkid
On Feb 13, 2017, at 10:25 PM, Richard Henderson wrote: > On 02/10/2017 11:39 AM, Stafford Horne wrote: >> On Thu, Feb 09, 2017 at 09:10:51AM -0500, G 3 wrote: >>> >>> On Feb 8, 2017, at 11:52 PM, qemu-devel-requ...@nongnu.org wrote: >>> Message: 6 Date: Wed, 8 Feb 2017 20:51:32

Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-13 Thread Ketan Nilangekar
On 2/13/17, 3:23 PM, "Jeff Cody" wrote: On Mon, Feb 13, 2017 at 10:36:53PM +, Ketan Nilangekar wrote: > > > On 2/13/17, 8:32 AM, "Jeff Cody" wrote: > > On Mon, Feb 13, 2017 at 01:37:25PM +, Stefan Hajnoczi wrote: >

[Qemu-devel] [Bug 1662050] Re: qemu-img convert a overlay qcow2 image into a entire image

2017-02-13 Thread wayen
** Attachment added: "qemu-img map delta.qcow2 output" https://bugs.launchpad.net/qemu/+bug/1662050/+attachment/4818562/+files/qemu_img_map_delta_qcow2.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 2/2] virtio-blk: Inline request init, complete and free functions

2017-02-13 Thread Fam Zheng
On Mon, 02/13 14:28, Stefan Hajnoczi wrote: > On Tue, Feb 07, 2017 at 02:52:38PM +0100, Laszlo Ersek wrote: > > On 02/07/17 14:27, Fam Zheng wrote: > > > These are used in each request handling, inline them. > > > > > > Signed-off-by: Fam Zheng > > > --- > > >

Re: [Qemu-devel] [PATCH 13/24] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2017-02-13 Thread John Snow
On 02/03/2017 04:40 AM, Vladimir Sementsov-Ogievskiy wrote: > Realize block bitmap storing interface, to allow qcow2 images store > persistent bitmaps. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- >

Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-13 Thread Jeff Cody
On Mon, Feb 13, 2017 at 10:36:53PM +, Ketan Nilangekar wrote: > > > On 2/13/17, 8:32 AM, "Jeff Cody" wrote: > > On Mon, Feb 13, 2017 at 01:37:25PM +, Stefan Hajnoczi wrote: > > On Tue, Feb 07, 2017 at 03:12:36PM -0800, ashish mittal wrote: > > > On Tue,

Re: [Qemu-devel] [PATCH 1/1] mirror: do not increase offset during initial zero_or_discard phase - pls consider this as V3 patch

2017-02-13 Thread Denis V. Lunev
On 02/13/2017 10:13 PM, Jeff Cody wrote: > On Mon, Feb 13, 2017 at 06:16:36PM +0100, Max Reitz wrote: >> On 13.02.2017 08:10, Denis V. Lunev wrote: >>> On 02/03/2017 06:08 PM, Denis V. Lunev wrote: On 02/03/2017 06:06 PM, Denis V. Lunev wrote: > From: Anton Nefedov

[Qemu-devel] [PULL 19/24] target/openrisc: Implement muld, muldu, macu, msbu

2017-02-13 Thread Richard Henderson
Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 108 1 file changed, 108 insertions(+) diff --git a/target/openrisc/translate.c

[Qemu-devel] [PULL 14/24] target/openrisc: Use movcond where appropriate

2017-02-13 Thread Richard Henderson
Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/target/openrisc/translate.c

[Qemu-devel] [PULL 16/24] target/openrisc: Enable trap, csync, msync, psync for user mode

2017-02-13 Thread Richard Henderson
Not documented as disabled for user mode. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 32 1 file

[Qemu-devel] [PULL 13/24] target/openrisc: Keep SR_CY and SR_OV in a separate variables

2017-02-13 Thread Richard Henderson
This significantly streamlines carry and overflow production. Signed-off-by: Richard Henderson --- target/openrisc/cpu.h | 13 +++- target/openrisc/exception_helper.c | 31 -- target/openrisc/helper.h | 4 +- target/openrisc/translate.c

[Qemu-devel] [PULL 15/24] target/openrisc: Set flags on helpers

2017-02-13 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/openrisc/helper.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PULL 22/24] target/openrisc: Tidy ppc/npc implementation

2017-02-13 Thread Richard Henderson
The NPC SPR is really only supposed to be used for FPGA debugging. It contains the same contents as PC, unless one plays games. Follow the or1ksim implementation in flushing delayed branch state when it is changed. The PPC SPR need not be updated every instruction, merely when we exit the TB or

[Qemu-devel] [PULL 12/24] target/openrisc: Keep SR_F in a separate variable

2017-02-13 Thread Richard Henderson
This avoids having to keep merging and extracting the flag from SR. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- linux-user/elfload.c | 3 +- linux-user/main.c | 3 +-

[Qemu-devel] [PULL 23/24] target/openrisc: Tidy handling of delayed branches

2017-02-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/openrisc/cpu.h| 12 +--- target/openrisc/gdbstub.c| 2 +- target/openrisc/interrupt.c | 4 ++-- target/openrisc/sys_helper.c | 2 +- target/openrisc/translate.c | 40 5

[Qemu-devel] [PULL 21/24] target/openrisc: Optimize l.jal to next

2017-02-13 Thread Richard Henderson
This allows the tcg optimizer to see, and fold, all of the constants involved in a GOT base register load sequence. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 6 +- 1 file changed, 5

[Qemu-devel] [PULL 11/24] target/openrisc: Invert the decoding in dec_calc

2017-02-13 Thread Richard Henderson
Decoding the opcodes in the right order reduces by 100+ lines. Also, it happens to put the opcodes in the same order as Chapter 17. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 302

[Qemu-devel] [PULL 07/24] target/openrisc: Tidy insn dumping

2017-02-13 Thread Richard Henderson
Avoids warnings from unused variables etc. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 36 1 file

[Qemu-devel] [PULL 17/24] target/openrisc: Implement msync

2017-02-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 6c8f05c..dd4ba8c 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@

[Qemu-devel] [PULL 20/24] target/openrisc: Fix madd

2017-02-13 Thread Richard Henderson
Note that the specification for lf.madd.s is confused. It's the only mention of supposed FPMADDHI/FPMADDLO special registers. On the other hand, or1ksim implements a somewhat normal non-fused multiply and add. Mirror that. Reviewed-by: Bastian Koppelmann

[Qemu-devel] [PULL 06/24] target/openrisc: Implement lwa, swa

2017-02-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/openrisc/cpu.c | 1 + target/openrisc/cpu.h | 3 ++ target/openrisc/interrupt.c| 1 + target/openrisc/interrupt_helper.c | 1 + target/openrisc/machine.c | 24 ++--

[Qemu-devel] [PULL 01/24] target/openrisc: Rename the cpu from or32 to or1k

2017-02-13 Thread Richard Henderson
This is in keeping with the toolchain and or1ksim. Signed-off-by: Richard Henderson --- configure | 6 +++--- default-configs/or1k-linux-user.mak | 1 + default-configs/or1k-softmmu.mak| 4 default-configs/or32-linux-user.mak | 1 -

[Qemu-devel] [PULL 09/24] target/openrisc: Streamline arithmetic and OVE

2017-02-13 Thread Richard Henderson
Fix incorrect overflow calculation. Move overflow exception check to a helper function, to eliminate inline branches. Remove some incorrect special casing of R0. Implement multiply inline. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson

[Qemu-devel] [PULL 10/24] target/openrisc: Put SR[OVE] in TB flags

2017-02-13 Thread Richard Henderson
Removes a call at execution time for overflow exceptions. Signed-off-by: Richard Henderson --- target/openrisc/cpu.h | 4 ++-- target/openrisc/exception_helper.c | 2 +- target/openrisc/translate.c| 24 +++- 3 files changed, 18

[Qemu-devel] [PULL 05/24] target/openrisc: Fix exception handling status registers

2017-02-13 Thread Richard Henderson
From: Stafford Horne I am working on testing instruction emulation patches for the linux kernel. During testing I found these 2 issues: - sets DSX (delay slot exception) but never clears it - EEAR for illegal insns should point to the bad exception (as per openrisc spec)

[Qemu-devel] [PULL 00/24] target/openrisc patches

2017-02-13 Thread Richard Henderson
This is the v2 patch set that I posted last week. It even acquired some new R-b. Whee! r~ The following changes since commit 305e6c8a2ff7a6e3f4942b50e853230f18eeb5a9: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2017-02-13 16:44:04 +) are

[Qemu-devel] [PULL 08/24] target/openrisc: Rationalize immediate extraction

2017-02-13 Thread Richard Henderson
The architecture manual is consistent in using "I" for signed fields and "K" for unsigned fields. Mirror that. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 98

[Qemu-devel] [PULL 04/24] linux-user: Honor CLONE_SETTLS for openrisc

2017-02-13 Thread Richard Henderson
Threads work much better when you set the TLS register. This was fixed in the upstream kernel for Linux 4.9. Signed-off-by: Richard Henderson --- linux-user/openrisc/target_cpu.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 03/24] linux-user: Fix openrisc cpu_loop

2017-02-13 Thread Richard Henderson
We need to handle EXCP_DEBUG and EXCP_INTERRUPT. We need to send signals to the guest using queue_signal. Signed-off-by: Richard Henderson --- linux-user/main.c | 95 --- 1 file changed, 41 insertions(+), 54 deletions(-)

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2017-02-13 Thread Alexandre
Is it correct to assume that current 16.04.2 Xenial with the 2.5 QEMU package, doesn't have this patch and can't generate MiB aligned Azure images with qemu-img (no force_size support) ? Any recommended PPA backport of QEMU from 16.10 (2.6+) ? cheers. -- You received this bug notification

[Qemu-devel] [Bug 1012023] Re: Windows 7 bluescreen STOP: 00000005D

2017-02-13 Thread Thomas Huth
Looks like this is a duplicate of https://bugs.launchpad.net/qemu/+bug/921208 ... so closing this ticket here. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2017-02-13 Thread Thomas Huth
Bug has also been reported here: https://bugs.launchpad.net/qemu/+bug/1012023 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/921208 Title: win7/x64 installer hangs on startup with 0x005d.

[Qemu-devel] [Bug 994412] Re: reverse vnc to unix domain sockets does not work

2017-02-13 Thread Thomas Huth
Looks like this should work nowadays (of course you need to start a listening program first), so closing this bug ticket now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 966316] Re: Can't load Android VBOX image or even linux test image as well

2017-02-13 Thread Thomas Huth
Triaging old bug tickets ... Can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH V7 2/2] Add a new qmp command to do checkpoint, query xen replication status

2017-02-13 Thread Stefano Stabellini
On Wed, 8 Feb 2017, Eric Blake wrote: > On 02/07/2017 11:24 PM, Zhang Chen wrote: > > We can call this qmp command to do checkpoint outside of qemu. > > Xen colo will need this function. > > > > Signed-off-by: Zhang Chen > > Signed-off-by: Wen Congyang

[Qemu-devel] [Bug 1004050] Re: qemu-system-ppc64 by default has non-working keyboard

2017-02-13 Thread Thomas Huth
AFAIK an OHCI driver has been added to OpenBIOS in 2014, so marking this bug as fixed now. If you still have issues with OpenBIOS, please report them to the OpenBIOS project instead of the QEMU bug tracker, thanks! ** Changed in: qemu Status: New => Fix Released -- You received this bug

[Qemu-devel] [Bug 1018530] Re: No write access in a 9p/virtfs shared folder

2017-02-13 Thread Thomas Huth
Sounds like this was an Ubuntu- or libvirt-specific bug ... so closing this in the upstream QEMU bug tracker. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v12 12/24] tcg: handle EXCP_ATOMIC exception for system emulation

2017-02-13 Thread Richard Henderson
On 02/14/2017 06:33 AM, Pranith Kumar wrote: On Mon, Feb 13, 2017 at 2:19 PM, Richard Henderson wrote: On 02/13/2017 11:10 PM, Alex Bennée wrote: @@ -239,9 +240,16 @@ static void cpu_exec_step(CPUState *cpu) 1 | CF_NOCACHE | CF_IGNORE_ICOUNT);

Re: [Qemu-devel] [PATCH v3 1/4] sd: sdhci: check transfer mode register in multi block transfer

2017-02-13 Thread Alistair Francis
On Sat, Feb 11, 2017 at 7:06 AM, P J P wrote: > From: Prasad J Pandit > > In the SDHCI protocol, the transfer mode register value > is used during multi block transfer to check if block count > register is enabled and should be updated. Transfer mode >

Re: [Qemu-devel] [PATCH v3 3/4] sd: sdhci: conditionally invoke multi block transfer

2017-02-13 Thread Alistair Francis
On Sat, Feb 11, 2017 at 7:07 AM, P J P wrote: > From: Prasad J Pandit > > In sdhci_write invoke multi block transfer if it is enabled > in the transfer mode register 's->trnmod'. > > Signed-off-by: Prasad J Pandit Reviewed-by:

Re: [Qemu-devel] [PATCH v3 2/4] sd: sdhci: mask transfer mode register value

2017-02-13 Thread Alistair Francis
On Sat, Feb 11, 2017 at 7:06 AM, P J P wrote: > From: Prasad J Pandit > > In SDHCI protocol, the transfer mode register is defined > to be of 6 bits. Mask its value with '0x0037' so that an > invalid value couldn't be assigned. > > Signed-off-by:

[Qemu-devel] [Bug 821078] Re: virtio-serial-bus: Unexpected port id

2017-02-13 Thread Thomas Huth
Triaging old bug tickets ... Can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 988909] Re: Assert failed in arp_table.c

2017-02-13 Thread Thomas Huth
Triaging old bug tickets ... Can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v12 12/24] tcg: handle EXCP_ATOMIC exception for system emulation

2017-02-13 Thread Pranith Kumar
On Mon, Feb 13, 2017 at 2:19 PM, Richard Henderson wrote: > On 02/13/2017 11:10 PM, Alex Bennée wrote: >> >> @@ -239,9 +240,16 @@ static void cpu_exec_step(CPUState *cpu) >> 1 | CF_NOCACHE | CF_IGNORE_ICOUNT); >> tb->orig_tb = NULL; >>

[Qemu-devel] [Bug 989504] Re: assertion failed when attaching USB MSD device

2017-02-13 Thread Thomas Huth
Triaging old bug tickets ... Can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] linux-user: fill target sigcontext struct accordingly

2017-02-13 Thread joserz
Up On Wed, Feb 01, 2017 at 09:43:57PM +0100, Laurent Vivier wrote: > Le 31/01/2017 à 23:05, Jose Ricardo Ziviani a écrit : > > A segfault is noticed when an emulated program uses any of ucontext > > regs fields. Risu detected this issue in the following operation when > > handling a signal: > >

Re: [Qemu-devel] [PATCH v12 12/24] tcg: handle EXCP_ATOMIC exception for system emulation

2017-02-13 Thread Richard Henderson
On 02/13/2017 11:10 PM, Alex Bennée wrote: @@ -239,9 +240,16 @@ static void cpu_exec_step(CPUState *cpu) 1 | CF_NOCACHE | CF_IGNORE_ICOUNT); tb->orig_tb = NULL; tb_unlock(); -/* execute the generated code */ -trace_exec_tb_nocache(tb, pc); -

Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support

2017-02-13 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Hello David! Hi Alexey, > I have checked you series with 1G hugepage, but only in 1 Gbit/sec network > environment. Can you show the qemu command line you're using? I'm just trying to make sure I understand where your hugepages are;

[Qemu-devel] [PATCH 1/6] coroutine-lock: make CoMutex thread-safe

2017-02-13 Thread Paolo Bonzini
This uses the lock-free mutex described in the paper '"Blocking without Locking", or LFTHREADS: A lock-free thread library' by Gidenstam and Papatriantafilou. The same technique is used in OSv, and in fact the code is essentially a conversion to C of OSv's code. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 1/1] mirror: do not increase offset during initial zero_or_discard phase - pls consider this as V3 patch

2017-02-13 Thread Jeff Cody
On Mon, Feb 13, 2017 at 06:16:36PM +0100, Max Reitz wrote: > On 13.02.2017 08:10, Denis V. Lunev wrote: > > On 02/03/2017 06:08 PM, Denis V. Lunev wrote: > >> On 02/03/2017 06:06 PM, Denis V. Lunev wrote: > >>> From: Anton Nefedov > >>> > >>> If explicit zeroing out

[Qemu-devel] [PATCH v4] migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable

2017-02-13 Thread Ashijeet Acharya
Commit a3a3d8c7 introduced a segfault bug while checking for 'dc->vmsd->unmigratable' which caused QEMU to crash when trying to add devices which do no set their 'dc->vmsd' yet while initialization. Place a 'dc->vmsd' check prior to it so that we do not segfault for such devices. NOTE: This

[Qemu-devel] [PULL 14/14] virtio/migration: Migrate virtio-net to VMState

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin Message-Id: <20170203160651.19917-5-dgilb...@redhat.com> Signed-off-by: Dr. David Alan Gilbert Merge fix

[Qemu-devel] [PULL 07/14] migration: consolidate VMStateField.start

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: Halil Pasic The member VMStateField.start is used for two things, partial data migration for VBUFFER data (basically provide migration for a sub-buffer) and for locating next in QTAILQ. The implementation of the VBUFFER feature is broken when VMSTATE_ALLOC is

[Qemu-devel] [PULL 06/14] migrate: Introduce zero RAM checks to skip RAM migration

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: Ashijeet Acharya Migration of a "none" machine with no RAM crashes abruptly as bitmap_new() fails and thus aborts. Instead place zero RAM checks at appropriate places to skip migration of RAM in this case and complete migration successfully for devices only.

Re: [Qemu-devel] [PATCH 2/4] xhci: add qemu xhci controller

2017-02-13 Thread Marcel Apfelbaum
On 02/06/2017 01:55 PM, Gerd Hoffmann wrote: Turn existing TYPE_XHCI into an abstract base class. Create two child classes, TYPE_NEC_XHCI (same name as old xhci controller) and TYPE_QEMU_XHCI (using an ID from our namespace). Signed-off-by: Gerd Hoffmann ---

Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic

2017-02-13 Thread Yurii Zubrytskyi
Hi, It looks to me that this behavior can be achieved with "timer_mod_anticipate()" function instead of a separate check. On Sun, Feb 12, 2017 at 9:04 PM, Pavel Dovgalyuk wrote: > Ping? > > Pavel Dovgalyuk > > > > -Original Message- > > From: Pavel Dovgalyuk

[Qemu-devel] [PULL 03/14] migration: add MigrationState arg for ram_save_/compressed_/page()

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: Pavel Butsykin Cosmetic patch. The use of ms variable instead of migrate_get_current() looks nicer, especially when there reuse. Signed-off-by: Pavel Butsykin Message-Id: <20170203152321.19739-2-pbutsy...@virtuozzo.com> Reviewed-by: Dr.

Re: [Qemu-devel] [RFC PATCH 00/41] New op blocker system

2017-02-13 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH 00/41] New op blocker system Message-id: 1487006583-24350-1-git-send-email-kw...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] Estimation of qcow2 image size converted from raw image

2017-02-13 Thread John Snow
On 02/13/2017 12:16 PM, Daniel P. Berrange wrote: > On Mon, Feb 13, 2017 at 12:03:35PM -0500, John Snow wrote: >> Also keep in mind that changing the cluster size will give you different >> answers, too -- but that different cluster sizes will effect the runtime >> performance of the image as

[Qemu-devel] [PULL 01/14] migration: remove myself as maintainer

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: Amit Shah I'm switching jobs, and I'm not sure I can continue maintaining migration. Signed-off-by: Amit Shah Message-Id: <1486120416-11566-1-git-send-email-amit.s...@redhat.com> Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH 6/6] coroutine-lock: make CoRwlock thread-safe and fair

2017-02-13 Thread Paolo Bonzini
This adds a CoMutex around the existing CoQueue. Because the write-side can just take CoMutex, the old "writer" field is not necessary anymore. Instead of removing it altogether, count the number of pending writers during a read-side critical section and forbid further readers from entering.

[Qemu-devel] [PATCH 5/6] coroutine-lock: add mutex argument to CoQueue APIs

2017-02-13 Thread Paolo Bonzini
All that CoQueue needs in order to become thread-safe is help from an external mutex. Add this to the API. Signed-off-by: Paolo Bonzini --- block/backup.c | 2 +- block/io.c | 4 ++-- block/nbd-client.c | 2 +- block/qcow2-cluster.c

[Qemu-devel] [PATCH 2/6] coroutine-lock: add limited spinning to CoMutex

2017-02-13 Thread Paolo Bonzini
Running a very small critical section on pthread_mutex_t and CoMutex shows that pthread_mutex_t is much faster because it doesn't actually go to sleep. What happens is that the critical section is shorter than the latency of entering the kernel and thus FUTEX_WAIT always fails. With CoMutex

[Qemu-devel] [PATCH 3/6] test-aio-multithread: add performance comparison with thread-based mutexes

2017-02-13 Thread Paolo Bonzini
Add two implementations of the same benchmark as the previous patch, but using pthreads. One uses a normal QemuMutex, the other is Linux only and implements a fair mutex based on MCS locks and futexes. This shows that the slower performance of the 5-thread case is due to the fairness of CoMutex,

Re: [Qemu-devel] [PATCH 09/17] migration: Start of multiple fd work

2017-02-13 Thread Daniel P. Berrange
On Mon, Jan 23, 2017 at 10:32:13PM +0100, Juan Quintela wrote: > We create new channels for each new thread created. We only send through > them a character to be sure that we are creating the channels in the > right order. > > Note: Reference count/freeing of channels is not done > >

[Qemu-devel] [PULL 10/14] COLO: Don't process failover request while loading VM's state

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: zhanghailiang We should not do failover work while the main thread is loading VM's state. Otherwise the consistent of VM's memory and device state will be broken. We will restart the loading process after jump over the stage, The new failover status

[Qemu-devel] [PATCH 4/6] coroutine-lock: place CoMutex before CoQueue in header

2017-02-13 Thread Paolo Bonzini
This will avoid forward references in the next patch. It is also more logical because CoQueue is not anymore the basic primitive. Signed-off-by: Paolo Bonzini --- include/qemu/coroutine.h | 89 1 file changed, 44

Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support

2017-02-13 Thread Andrea Arcangeli
On Mon, Feb 13, 2017 at 06:57:22PM +0100, Andrea Arcangeli wrote: > Hello, > > On Mon, Feb 13, 2017 at 08:11:06PM +0300, Alexey Perevalov wrote: > > Another one request. > > QEMU could use mem_path in hugefs with share key simultaneously > > (-object > >

[Qemu-devel] [RFC PATCH 40/41] block: Pass BdrvChild to bdrv_aligned_preadv/pwritev

2017-02-13 Thread Kevin Wolf
This is where we want to check the permissions, so we need to have the BdrvChild around where they are stored. Signed-off-by: Kevin Wolf --- block/io.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/block/io.c b/block/io.c

[Qemu-devel] [PATCH 0/6] Make CoMutex/CoQueue/CoRwlock thread-safe

2017-02-13 Thread Paolo Bonzini
This is yet another tiny bit of the multiqueue work, this time affecting the synchronization infrastructure for coroutines. Currently, coroutines synchronize between the main I/O thread and the dataplane iothread through the AioContext lock. However, for multiqueue a single BDS will be used by

[Qemu-devel] [PULL 00/14] migration queue

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> The following changes since commit df96bfab49dab2d0373e49b51bbb51ce72e1601e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20170213-1' into staging (2017-02-13 10:54:49 +) are available in the git repos

[Qemu-devel] [RFC PATCH 35/41] stream: Use real permissions in streaming block job

2017-02-13 Thread Kevin Wolf
The correct permissions are relatively obvious here (and explained in code comments). For intermediate streaming, we need to reopen the top node read-write before creating the job now because the permissions system catches attempts to get the BLK_PERM_WRITE_UNCHANGED permission on a read-only

Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support

2017-02-13 Thread Andrea Arcangeli
Hello, On Mon, Feb 13, 2017 at 08:11:06PM +0300, Alexey Perevalov wrote: > Another one request. > QEMU could use mem_path in hugefs with share key simultaneously > (-object > memory-backend-file,id=mem,size=${mem_size},mem-path=${mem_path},share=on) > and vm > in this case will start and will

[Qemu-devel] [PULL 13/14] tests/migration: Add test for VMSTATE_WITH_TMP

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a test for VMSTATE_WITH_TMP to tests/test-vmstate.c Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Message-Id: <20170203160651.19917-4-dgilb...@redhat.com> Signed-off-by: Dr.

[Qemu-devel] [RFC PATCH 30/41] backup: Use real permissions in backup block job

2017-02-13 Thread Kevin Wolf
The backup block job doesn't have very complicated requirements: It needs to read from the source and write to the target, but it's fine with either side being changed. The only restriction is that we can't resize the image because the job uses a cached value. qemu-iotests 055 needs to be changed

[Qemu-devel] [RFC PATCH 36/41] hmp: Request permissions in qemu-io

2017-02-13 Thread Kevin Wolf
The HMP command 'qemu-io' is a bit tricky because it wants to work on the original BlockBackend, but additional permissions could be required. The details are explained in a comment in the code, but in summary, just request whatever permissions the current qemu-io command needs. Signed-off-by:

[Qemu-devel] [PULL 09/14] COLO: Shutdown related socket fd while do failover

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: zhanghailiang If the net connection between primary host and secondary host breaks while COLO/COLO incoming threads are doing read() or write(). It will block until connection is timeout, and the failover process will be blocked because of it. So it is

[Qemu-devel] [PULL 12/14] migration: Add VMSTATE_WITH_TMP

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" VMSTATE_WITH_TMP is for handling structures where some calculation or rearrangement of the data needs to be performed before the data hits the wire. For example, where the value on the wire is an offset from a non-migrated base, but the data

[Qemu-devel] [RFC PATCH 31/41] block: Fix pending requests check in bdrv_append()

2017-02-13 Thread Kevin Wolf
bdrv_append() cares about isolation of the node that it modifies, but not about activity in some subtree below it. Instead of using the recursive bdrv_requests_pending(), directly check bs->in_flight, which considers only the node in question. Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PULL 08/14] COLO: fix setting checkpoint-delay not working properly

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: zhanghailiang If we set checkpoint-delay through command 'migrate-set-parameters', It will not take effect until we finish last sleep chekpoint-delay, That's will be offensive espeically when we want to change its value from an extreme big one to a proper

[Qemu-devel] [RFC PATCH 33/41] block: Allow backing file links in change_parent_backing_link()

2017-02-13 Thread Kevin Wolf
Now that the backing file child role implements .attach/.detach callbacks, nothing prevents us from modifying the graph even if that involves changing backing file links. Signed-off-by: Kevin Wolf --- block.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PULL 11/14] migration: Add VMSTATE_UNUSED_VARRAY_UINT32

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" VMSTATE_UNUSED_VARRAY_UINT32 is used to skip a chunk of the stream that's an n-element array; note the array size and the dynamic value read never get multiplied so there's no overflow risk. Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [RFC PATCH 29/41] commit: Use real permissions for HMP 'commit'

2017-02-13 Thread Kevin Wolf
This is a little simpler than the commit block job because it's synchronous and only commits into the immediate backing file, but otherwise doing more or less the same. Signed-off-by: Kevin Wolf --- block/commit.c | 31 ++- 1 file changed, 26

[Qemu-devel] [RFC PATCH 27/41] block: Add bdrv_new_open_driver()

2017-02-13 Thread Kevin Wolf
This function allows to create more or less normal BlockDriverStates even for BlockDrivers that aren't globally registered (e.g. helper filters for block jobs). Signed-off-by: Kevin Wolf --- block.c | 31 ++- include/block/block.h | 2

[Qemu-devel] [PULL 04/14] add 'release-ram' migrate capability

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: Pavel Butsykin This feature frees the migrated memory on the source during postcopy-ram migration. In the second step of postcopy-ram migration when the source vm is put on pause we can free unnecessary memory. It will allow, in particular, to start relaxing the

[Qemu-devel] [PULL 05/14] migration: discard non-dirty ram pages after the start of postcopy

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: Pavel Butsykin After the start of postcopy migration there are some non-dirty pages which have already been migrated. These pages are no longer needed on the source vm so that we can free them and it doen't hurt to complete the migration. Signed-off-by: Pavel

[Qemu-devel] [RFC PATCH 19/41] hw/block: Request permissions

2017-02-13 Thread Kevin Wolf
This makes all device emulations with a qdev drive property request permissions on their BlockBackend. We don't block anything yet. Signed-off-by: Kevin Wolf --- hw/block/block.c | 19 ++- hw/block/fdc.c | 25

[Qemu-devel] [RFC PATCH 26/41] block: Factor out bdrv_open_driver()

2017-02-13 Thread Kevin Wolf
This is a function that doesn't do any option parsing, but just does some basic BlockDriverState setup and calls the .bdrv_open() function of the block driver. Signed-off-by: Kevin Wolf --- block.c | 112 +--- 1 file

[Qemu-devel] [PULL 02/14] MAINTAINERS: update my email address

2017-02-13 Thread Dr. David Alan Gilbert (git)
From: Amit Shah I'm leaving my job at Red Hat, this email address will stop working next week. Update it to one that I will have access to later. Signed-off-by: Amit Shah Message-Id: <1486120433-11628-1-git-send-email-amit.s...@redhat.com>

Re: [Qemu-devel] [PATCH v7 2/2] mach-virt: Provide sample configuration files

2017-02-13 Thread Laszlo Ersek
On 02/10/17 18:25, Andrea Bolognani wrote: > These are very much like the sample configuration files > for q35, and can be used both as documentation and as > a starting point for creating your own guest. > > Two sample configuration files are provided: > > * mach-virt-graphical.cfg can be

[Qemu-devel] [RFC PATCH 23/41] block: Include details on permission errors in message

2017-02-13 Thread Kevin Wolf
Instead of just telling that there was some conflict, we can be specific and tell which permissions were in conflict and which way the conflict is. Signed-off-by: Kevin Wolf --- block.c | 66 ++--- 1 file changed, 55

[Qemu-devel] [RFC PATCH 17/41] block: Request real permissions in blk_new_open()

2017-02-13 Thread Kevin Wolf
We can figure out the necessary permissions from the flags that the caller passed. Signed-off-by: Kevin Wolf --- block/block-backend.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index

[Qemu-devel] [RFC PATCH 41/41] block: Assertions for write permissions

2017-02-13 Thread Kevin Wolf
This adds assertions that ensure that the necessary write permissions have been granted before someone attempts to write to a node. Signed-off-by: Kevin Wolf --- block/io.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/block/io.c b/block/io.c

  1   2   3   4   >