This allows to specify display and head to use, simliar to vnc.
Signed-off-by: Gerd Hoffmann
---
ui/spice-core.c| 6 ++
ui/spice-display.c | 22 +-
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index d613f1a..e18ad77
This way you can use -spice multiple times on the command line
and qemu will actually pick up all options.
Signed-off-by: Gerd Hoffmann
---
ui/spice-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 39ccab7..d613f1a 100644
--- a/ui/spice-core.c
++
On Tue, Feb 21, 2017 at 6:49 AM Eric Blake wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Comparison symbol is misused. It may lead to memory corruption.
> Introduced in commit 7d3123e.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Message-Id: <20170203154757.36140-6-vsement...@virtuozzo.c
On Tue, Feb 21, 2017 at 6:49 AM Eric Blake wrote:
> The NBD Protocol is introducing some additional information
> about exports, such as minimum request size and alignment, as
> well as an advertised maximum request size. It will be easier
> to feed this information back to the block layer if we
On Tue, Feb 21, 2017 at 6:45 AM Eric Blake wrote:
> The NBD protocol would like to advertise the optimal I/O
> size to the client; but it would be a layering violation to
> peek into blk_bs(blk)->bl, when we only have a BB.
>
> This copies the existing blk_get_max_transfer() in reading
> a value
Hi
On Tue, Feb 21, 2017 at 12:00 PM Gerd Hoffmann wrote:
> This way you can use -spice multiple times on the command line
> and qemu will actually pick up all options.
>
>
Is this actually a good thing to have? vnc doesn't have it for example.
Perhaps some day we may want to have -spice for diff
On Tue, Feb 21, 2017 at 6:54 AM Eric Blake wrote:
> The NBD protocol has several constants defined in various extensions
> that we are about to implement. Expose them to the code, along with
> an easy way to map various constants to strings during diagnostic
> messages.
>
> Doing this points out
In 'qemu_chr_open_spice_vmc' if the 'psubtype' is NULL, it will
call 'char_spice_finalize'. But as the SpiceChardev is not inserted
in the 'spice_chars' list, the 'QLIST_REMOVE' will cause a segfault.
Add a detect to avoid it.
Signed-off-by: Li Qiang
---
spice-qemu-char.c | 5 -
1 file chang
On Di, 2017-02-21 at 08:15 +, Marc-André Lureau wrote:
> Hi
>
> On Tue, Feb 21, 2017 at 12:00 PM Gerd Hoffmann
> wrote:
>
> This way you can use -spice multiple times on the command line
> and qemu will actually pick up all options.
>
>
>
> Is this actually a good
Hi
- Original Message -
> In 'qemu_chr_open_spice_vmc' if the 'psubtype' is NULL, it will
> call 'char_spice_finalize'. But as the SpiceChardev is not inserted
> in the 'spice_chars' list, the 'QLIST_REMOVE' will cause a segfault.
> Add a detect to avoid it.
>
> Signed-off-by: Li Qiang
On 20/02/2017 21:16, Dr. David Alan Gilbert wrote:
>> p.has_max_bandwidth = true;
>> ret = qemu_strtosz_mebi(valuestr, NULL, &valuebw);
>> -if (ret < 0 || (size_t)valuebw != valuebw) {
>> +if (ret < 0 || valuebw > INT64_MAX
>> +
Ping!
Would be nice for us if we can get this into 2.9.
Thanks,
Fred
Le 17/02/2017 à 21:17, fred.kon...@greensocs.com a écrit :
From: KONRAD Frederic
This series allows to execute code from mmio areas.
The main goal of this is to be able to run code for example from an SPI device.
The three
Hi
On Tue, Feb 21, 2017 at 11:58 AM Gerd Hoffmann wrote:
> This allows to specify display and head to use, simliar to vnc.
>
>
Does "head" in qemu always match the head for multi-monitor spice? (with a
single qxl/virtio). I don't clearly understand the relation, I would need
to do some research.
* Cornelia Huck [2017-02-20 19:59:01 +0100]:
> On Fri, 17 Feb 2017 09:29:39 +0100
> Dong Jia Shi wrote:
>
> > Although Linux does not use format-0 channel command words (CCW0)
> > these are a non-optional part of the platform spec, and for the sake
> > of platform compliance, and possibly some
Daniel Henrique Barboza writes:
> The previous error message was displaying the values in miliseconds,
> being misleading with the command that accepts the value in seconds:
>
> { "execute": "migrate_set_downtime", "arguments": {"value": 3000}}
> {"error": {"class": "GenericError", "desc": "Param
Vincenzo Maffione writes:
> In the vhost-user example, a chardev with id chr0 is referenced by the
> vhost-user net backend, but the id is not specified in the chardev option.
>
> Signed-off-by: Vincenzo Maffione
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Signed-off-by: Paolo Bonzini
---
scripts/kvm/vmxcap | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap
index 2220255..af8de15 100755
--- a/scripts/kvm/vmxcap
+++ b/scripts/kvm/vmxcap
@@ -27,9 +27,9 @@ MSR_IA32_VMX_VMFUNC = 0x
Signed-off-by: Paolo Bonzini
---
scripts/kvm/vmxcap | 8
1 file changed, 8 insertions(+)
diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap
index af8de15..e0990c7 100755
--- a/scripts/kvm/vmxcap
+++ b/scripts/kvm/vmxcap
@@ -171,8 +171,11 @@ controls = [
13: 'Enable VM fun
On Di, 2017-02-21 at 08:52 +, Marc-André Lureau wrote:
> Hi
>
> On Tue, Feb 21, 2017 at 11:58 AM Gerd Hoffmann
> wrote:
>
> This allows to specify display and head to use, simliar to
> vnc.
>
>
>
> Does "head" in qemu always match the head for multi-monitor spice?
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> Change the qemu_strtosz() & friends to return -EINVAL when @endptr is
>> null and the conversion doesn't consume the string completely.
>> Matches how qemu_strtol() & friends work.
>>
>> Only test_qemu_strtosz_s
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> Change the qemu_strtosz() & friends to return -EINVAL when @endptr is
> >> null and the conversion doesn't consume the string completely.
> >> Matches how qe
Richard Henderson writes:
> On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote:
>> tcg_temp_free(t0);
>> +tcg_gen_extract_tl(cpu_ov32, cpu_ov, 31, 1);
>> +tcg_gen_extract_tl(cpu_ov, cpu_ov, 63, 1);
>> if (NARROW_MODE(ctx)) {
>> -tcg_gen_ext32s_tl(cpu_ov, cpu_ov);
>> +
Hi
On Tue, Feb 21, 2017 at 1:11 PM Gerd Hoffmann wrote:
> On Di, 2017-02-21 at 08:52 +, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Feb 21, 2017 at 11:58 AM Gerd Hoffmann
> > wrote:
> >
> > This allows to specify display and head to use, simliar to
> > vnc.
> >
> >
> >
>
Richard Henderson writes:
> On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote:
>> static void gen_neg(DisasContext *ctx)
>> {
>> -gen_op_arith_neg(ctx, 0);
>> +tcg_gen_neg_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]);
>> }
>>
>
> NACK. You're forgetting "neg.".
Oops, i totall
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> This will permit its use in parse_option_size().
>>
>> Cc: Dr. David Alan Gilbert
>> Cc: Eduardo Habkost (maintainer:X86)
>> Cc: Kevin Wolf (supporter:Block layer core)
>> Cc: Max Reitz (supporter:Block laye
Richard Henderson writes:
> On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote:
>> For 64-bit mode if the register RA contains 0x8000___, OV
>> and OV32 are set to 1.
>>
>> For 32-bit mode if the register RA contains 0x8000_, OV and OV32 are
>> set to 1.
>>
>> Use the tcg-ops for neg
On 20 February 2017 at 14:12, Gerd Hoffmann wrote:
> Hi,
>
> Here is the audio queue, bringing support for replay and fixing audio
> with SDL2.
>
> please pull,
> Gerd
>
> The following changes since commit 5d42ff913bb294c661aed8dfcd386fed9e185148:
>
> Merge remote-tracking branch 'remotes/h
On 20 February 2017 at 20:30, Yongbok Kim wrote:
> Hi,
>
> This is pull-req for target-mips.
>
> Regards,
> Yongbok
>
> The following changes since commit 56f9e46b841c7be478ca038d8d4085d776ab4b0d:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-02-20'
> into staging (2017-0
Signed-off-by: Gerd Hoffmann
---
ui/spice-display.c | 36 +---
1 file changed, 21 insertions(+), 15 deletions(-)
diff --git a/ui/spice-display.c b/ui/spice-display.c
index b80a9f3..23ccf2a 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -928,6 +928,17
Helper function (and DisplayChangeListenerOps ptr) to disable scanouts.
Replaces using dpy_gl_scanout_texture with 0x0 size and no texture
specified.
Allows cleanups to make the io and gfx emulation code more readable.
Signed-off-by: Gerd Hoffmann
---
include/ui/console.h | 2 ++
ui/console.c
Hi,
Upcoming intel vgpu support will need some updates for the qemu opengl
support, specifically we will need support for importing dma-bufs.
The kernel support for this is still brewing though and thus the qemu
patches are still experimental and a moving target.
While working on it I did some
Signed-off-by: Gerd Hoffmann
---
include/ui/sdl2.h | 1 +
ui/sdl2-gl.c | 16 +++-
ui/sdl2.c | 1 +
3 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h
index 2de792f..aaf226c 100644
--- a/include/ui/sdl2.h
+++ b/include/u
Signed-off-by: Gerd Hoffmann
---
hw/display/virtio-gpu-3d.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
index b526b3f..f49b7fe 100644
--- a/hw/display/virtio-gpu-3d.c
+++ b/hw/display/virtio-gpu-3d.c
@@ -185,8 +1
Signed-off-by: Gerd Hoffmann
---
include/ui/gtk.h | 1 +
ui/gtk-egl.c | 15 ++-
ui/gtk.c | 1 +
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/include/ui/gtk.h b/include/ui/gtk.h
index 408e21b..ca9a226 100644
--- a/include/ui/gtk.h
+++ b/include/ui/gtk.h
Eric Blake writes:
[...]
> 'git send-email -s' can also add Signed-off-by: lines, if you didn't add
> them earlier (but only if you use send-email, rather than attachments) :)
That's fine, as you *should* use git send-email.
If it looks unattractive to you because it needs some setup, then that
We'll add a variant which accepts dmabufs soon. Change
the name so we can easily disturgish the two variants.
Signed-off-by: Gerd Hoffmann
---
hw/display/virtio-gpu-3d.c | 14 +++---
include/ui/console.h | 19 +++
include/ui/gtk.h | 24 ++-
On 21 February 2017 at 09:41, Markus Armbruster wrote:
> Eric Blake writes:
>
> [...]
>> 'git send-email -s' can also add Signed-off-by: lines, if you didn't add
>> them earlier (but only if you use send-email, rather than attachments) :)
>
> That's fine, as you *should* use git send-email.
It h
On 02/21/17 02:43, Michael S. Tsirkin wrote:
> On Mon, Feb 20, 2017 at 09:55:40PM +0100, Laszlo Ersek wrote:
>> On 02/20/17 21:45, Eric Blake wrote:
>>> On 02/20/2017 02:19 PM, Dr. David Alan Gilbert wrote:
* Eric Blake (ebl...@redhat.com) wrote:
> On 02/20/2017 04:23 AM, Dr. David Alan Gi
On 21 February 2017 at 02:24, wrote:
> On Sat, Feb 18, 2017 at 10:41:41PM +, Peter Maydell wrote:
>>
>> Does the BE ppc64 risu build work for you? I tried
>> installing the cross-compiler, but the build fails
>> because there's no risu_ppc64.c. (ppc64le works fine.)
>> If we don't support the
* Alexey Perevalov (a.pereva...@samsung.com) wrote:
>
> Hello David,
Hi Alexey,
> On Tue, Feb 14, 2017 at 07:34:26PM +, Dr. David Alan Gilbert wrote:
> > * Alexey Perevalov (a.pereva...@samsung.com) wrote:
> > > Hi David,
> > >
> > > Thank your, now it's clear.
> > >
> > > On Mon, Feb 13,
Hi,
> It's always 0, except with virtio.
>
> But I think virtio linux driver multi-monitor code would work with a
> single qemu head (like qxl, fwiw last time I checked, multi-monitor
> virtio+spice worked, with 3d too).
> It seems to me the qemu "head" is quite different (lower-level) from
>
Applied to -trivial, thanks!
/mjt
Applied to -trivial, thanks!
/mjt
(restored cc:s)
On Mon, 20 Feb 2017 16:33:36 +0100
Thomas Huth wrote:
> On 20.02.2017 15:19, Cornelia Huck wrote:
> > From: Farhan Ali
> >
> > The current QEMU ROM infrastructure rejects late loading of ROMs.
> > And ELFs are currently loaded as ROM, this prevents delayed loading
> > of ELFs.
Hi,
First, sorry for such a long time delay on the AER job. I was on 12 days
holiday, and start to work on the patch 2 weeks ago, because I use a
newer version kernel(4.10 rc8) to start off the work, several tiny
problems slow me.
Now I meet a confusing issue on aer_inject module. When I use aer_
On 02/20/2017 04:33 PM, Thomas Huth wrote:
> On 20.02.2017 15:19, Cornelia Huck wrote:
>> From: Farhan Ali
>>
>> The current QEMU ROM infrastructure rejects late loading of ROMs.
>> And ELFs are currently loaded as ROM, this prevents delayed loading
>> of ELFs. So when loading ELF, allow the user
be478ca038d8d4085d776ab4b0d:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-02-20'
> into staging (2017-02-20 17:42:47 +)
>
> are available in the git repository at:
>
>
> git://git.kraxel.org/qemu tags/pull-usb-20170221-1
>
> for
On Tue, Feb 21, 2017 at 1:38 PM Gerd Hoffmann wrote:
> Hi,
>
> Upcoming intel vgpu support will need some updates for the qemu opengl
> support, specifically we will need support for importing dma-bufs.
> The kernel support for this is still brewing though and thus the qemu
> patches are still
On Wed, Feb 15, 2017 at 9:47 PM, Alex Williamson wrote:
> On Thu, 16 Feb 2017 10:28:39 +0800
> Peter Xu wrote:
>
> > On Wed, Feb 15, 2017 at 11:15:52AM -0700, Alex Williamson wrote:
> >
> > [...]
> >
> > > > Alex, do you like something like below to fix above issue that
> Jintack
> > > > has enc
On 20/02/2017 19:21, Denis V. Lunev wrote:
> This is a set of followup patches requested by Eric Blake.
>
> Signed-off-by: Anton Nefedov
> Signed-off-by: Denis V. Lunev
> CC: Paolo Bonzini
> CC: Eric Blake
>
> Anton Nefedov (3):
> i386/cpu: release GuestPanicInformation memory
> qapi: f
qemu_system_guest_panicked was already using current_cpu implicitly,
so it makes sense for it to receive a CPUState. This lets the
function call cpu_get_crash_info and free the result.
Signed-off-by: Paolo Bonzini
---
include/sysemu/sysemu.h | 2 +-
kvm-all.c | 2 +-
vl.c
The functions simplify the handling of QOM properties whose type
is a QAPI struct. They go through a QObject just like the other
functions that access a QOM property through its C type.
Like QAPI_CLONE, the functions are wrapped by macros that take a
QAPI type name and use it to build the name of
This is an alternative approach to simplifying the crash information
patches.
Currently, crash information is exposed twice, through a QOM property
and through a method. This is because accessing QOM properties with
QAPI struct types is a huge pain in the neck. Patch 1 fixes this by
providing a
Provide a generic implementation for all CPU subclasses.
Signed-off-by: Paolo Bonzini
---
include/qom/cpu.h | 1 -
qom/cpu.c | 11 ---
target/i386/cpu.c | 2 +-
3 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 1bc3ad2..0
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
> Add test for VMSTATE_ARRAY_OF_POINTER_TO_STRUCT with an array
> containing some null pointer.
>
> Signed-off-by: Halil Pasic
> Reviewed-by: Dr. David Alan Gilbert
> ---
> tests/test-vmstate.c | 51
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH 0/3] simplify struct QOM properties and use the
result for GUEST_PANICKED
Message-id: 20170221104256.5153-1-pbonz...@redhat.com
=== TEST SCRIPT BEGIN ===
#!
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Type: series
Subject: [Qemu-devel] [PATCH 0/3] simplify struct QOM properties and use the
result for GUEST_PANICKED
Message-i
On Mon 20 Feb 2017 05:52:04 PM CET, Stefan Hajnoczi wrote:
> The disk I/O throttling options have been listed for a long time but
> never explained on the QEMU man page.
> +@item bps=@var{b},bps_rd=@var{r},bps_wr=@var{w}
> +Specify bandwidth throttling limits in bytes per second, either for all
>
On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote:
> On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi wrote:
> > On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote:
> >> On 2/17/17, 1:42 PM, "Jeff Cody" wrote:
> >>
> >> On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashis
On 20 February 2017 at 17:34, Clement Deschamps
wrote:
> This patches add the Arasan SD controller to the BCM2835/36 platforms.
Cool!
> On the real hardware, both SD controllers are wired to the same SD card.
> Selection is done via multi-function pins through the GPIO controller. I'm
> not
>
Drop unused QIV_STACK_SIZE and unused qobject_input_start_struct()
parameter errp.
Signed-off-by: Markus Armbruster
---
qapi/qobject-input-visitor.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c
ind
The improvement is nice for QMP, but my real motivation is to avoid
embarrassingly horrible error messages for command line options once
we use the qobject input visitor there, as we do in "[PATCH RFC v2
0/2] block: Crude initial implementation of -blockdev".
Markus Armbruster (2):
qapi: Clean u
Error messages refer to nodes of the QObject being visited by name.
Trouble is the names are sometimes less than helpful:
* The name of the root QObject is whatever @name argument got passed
to the visitor, except NULL gets mapped to "null". We commonly pass
NULL. Not good.
Avoiding error
On 02/21/2017 11:49 AM, Dr. David Alan Gilbert wrote:
>> +static void test_arr_ptr_str_0_save(void)
>> +{
>> +TestStructTriv ar[AR_SIZE] = {{.i = 0}, {.i = 1}, {.i = 2}, {.i = 3} };
>> +TestArrayOfPtrToStuct sample = {.ar = {&ar[0], NULL, &ar[2], &ar[3]} };
>> +uint8_t wire_sample[] =
On Mon, Feb 20, 2017 at 03:59:42PM +0100, Peter Lieven wrote:
> Am 20.02.2017 um 15:50 schrieb Stefan Hajnoczi:
> > On Fri, Feb 17, 2017 at 05:00:24PM +0100, Peter Lieven wrote:
> > > +if (s->wr_in_order) {
> > > +/* reenter the coroutine that might have waited
> > > +
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
> Let's have a test for ptr arrays to some primitive type with some
> not-null and null ptrs intermixed.
>
> Signed-off-by: Halil Pasic
>
> ---
>
> Mainly for the sake of completeness and also to demonstrate that it works
> since in the previous v
Zhang Chen writes:
> We can call this qmp command to do checkpoint outside of qemu.
> Xen colo will need this function.
I know nothing about "Xen colo", but I'll try anyway.
I *guess* "Xen colo" is a long-running activity, and the new commands
interact with it. Correct?
>
> Signed-off-by: Zha
On Mon, Feb 20, 2017 at 01:37:58PM +, Peter Maydell wrote:
> On 20 February 2017 at 09:32, Stefan Hajnoczi wrote:
> > The following changes since commit 5dae13cd71f0755a1395b5a4cde635b8a6ee3f58:
> >
> > Merge remote-tracking branch 'remotes/rth/tags/pull-or-20170214' into
> > staging (2017-
On Mon, Feb 20, 2017 at 05:29:19PM +0100, Alberto Garcia wrote:
> On Mon, Feb 20, 2017 at 04:45:54PM +0100, Kevin Wolf wrote:
> > > I can imagine two solutions that do not need these parameters in
> > > blockdev-add:
> > >
> > > 1. I/O throttling is implemented by a BlockDriver. Users are expecte
Zhang Chen writes:
> Hi~ Markus.
>
> This patch set has been reviewed for a long time, can you pick up it?
>
> [PATCH V7 0/2] Add new qmp commands to suppurt Xen COLO
I think this should go through a COLO maintainer chain, or perhaps the
Xen maintainer, but not the QAPI maintainer (me). QAPI gu
On Mon, Feb 20, 2017 at 01:40:21PM -0600, Eric Blake wrote:
> On 02/20/2017 10:52 AM, Stefan Hajnoczi wrote:
> > The disk I/O throttling options have been listed for a long time but
> > never explained on the QEMU man page.
> >
> > Suggested-by: Nini Gu
> > Cc: Alberto Garcia
> > Signed-off-by:
On Mon, Feb 20, 2017 at 9:45 AM, Philippe Mathieu-Daudé wrote:
> On 02/20/2017 12:36 PM, Peter Maydell wrote:
>>
>> Switch the stm32f205 SoC to create the armv7m object directly
>> rather than via the armv7m_init() wrapper. This fits better
>> with the SoC model's very QOMified design.
>>
>> In pa
On Tue, Feb 21, 2017 at 10:59:18AM +, Stefan Hajnoczi wrote:
> On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote:
> > On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi wrote:
> > > On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote:
> > >> On 2/17/17, 1:42 PM, "Jeff Co
On Mon, Feb 20, 2017 at 9:46 AM, Philippe Mathieu-Daudé wrote:
> On 02/20/2017 12:36 PM, Peter Maydell wrote:
>>
>> The local variable 'nvic' in stm32f205_soc_realize() no longer
>> holds a direct pointer to the NVIC device; it is a pointer to
>> the ARMv7M container object. Rename it 'armv7m' acc
On Mon, Feb 20, 2017 at 7:35 AM, Peter Maydell wrote:
> Make the legacy armv7m_init() function use the newly QOMified
> armv7m object rather than doing everything by hand.
>
> We can return the armv7m object rather than the NVIC from
> armv7m_init() because its interface to the rest of the
> board
On Mon, Feb 20, 2017 at 8:23 AM, Philippe Mathieu-Daudé wrote:
> On 02/20/2017 12:35 PM, Peter Maydell wrote:
>>
>> Abstract the "load kernel" code out of armv7m_init() into its own
>> function. This includes the registration of the CPU reset function,
>> to parallel how we handle this for A prof
The qcow driver refuses to open images which are less than
2 bytes in size, but will happily create such images. Add
a check in the create path to avoid this discrepancy.
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
block/qco
Instead of requiring separate input/output buffers for
encrypting data, change encrypt_sectors() to assume
use of a single buffer, encrypting in place. One current
caller uses the same buffer for input/output already
and the other two callers are easily converted to do so.
Reviewed-by: Alberto Gar
Previously posted:
v1: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg00201.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05147.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05671.html
This series is a continuation of previous work to support L
The block/crypto.c defines a set of QemuOpts that provide
parameters for encryption. This will also be needed by
the qcow/qcow2 integration, so expose the relevant pieces
in a new block/crypto.h header.
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
Signed-off-by: Da
The previous commit:
commit a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd
Author: Eric Blake
Date: Mon Dec 5 09:49:34 2016 -0600
qcow2: Don't strand clusters near 2G intervals during commit
extended the 097 test case so that it did two passes, once
with an internal snapshot, once without
Document that use of guest virtual sector numbers as the basis for
the initialization vectors is a potential weakness, when combined
with internal snapshots or multiple images using the same passphrase.
This fixes the formatting of the itemized list too.
Reviewed-by: Max Reitz
Reviewed-by: Albert
When integrating the crypto support with qcow/qcow2, we don't
want to use the bare LUKS option names "hash-alg", "key-secret",
etc. We want to namespace them "luks-hash-alg", "luks-key-secret"
so that they don't clash with any general qcow options at a later
date.
Reviewed-by: Max Reitz
Reviewed-
Test 042 is designed to verify operation with zero sized images.
Such images are not supported with qcow (v1), so this test has
always failed.
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Signed-off-by: Daniel P. Berrange
---
tests/qemu-iotests/042 | 2 +-
1 file changed, 1 insertion(+),
Test 048 is designed to verify data preservation during an
image resize. The qcow (v1) format impl has never supported
resize so always fails.
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
Signed-off-by: Daniel P. Berrange
---
tests/qemu-iotests/048 | 2 +-
1 file changed, 1 insertion(+),
This converts the qcow driver to make use of the QCryptoBlock
APIs for encrypting image content. This is only wired up to
permit use of the legacy QCow encryption format. Users who wish
to have the strong LUKS format should switch to qcow2 instead.
With this change it is now required to use the QC
This converts the qcow2 driver to make use of the QCryptoBlock
APIs for encrypting image content, using the legacyy QCow2 AES
scheme.
With this change it is now required to use the QCryptoSecret
object for providing passwords, instead of the current block
password APIs / interactive prompting.
This extends the 087 iotest to cover LUKS encryption when doing
blockdev-add.
Two further tests are added to validate read/write of LUKS
encrypted images with a single file and with a backing file.
Reviewed-by: Alberto Garcia
Reviewed-by: Max Reitz
Signed-off-by: Daniel P. Berrange
---
tests/
Instead of requiring separate input/output buffers for
encrypting data, change qcow2_encrypt_sectors() to assume
use of a single buffer, encrypting in place. The current
callers all used the same buffer for input/output already.
Reviewed-by: Eric Blake
Reviewed-by: Fam Zheng
Reviewed-by: Alberto
Update the qcow2 specification to describe how the LUKS header is
placed inside a qcow2 file, when using LUKS encryption for the
qcow2 payload instead of the legacy AES-CBC encryption
Reviewed-by: Max Reitz
Signed-off-by: Daniel P. Berrange
---
docs/specs/qcow2.txt | 96
Now that qcow & qcow2 are wired up to get encryption keys
via the QCryptoSecret object, nothing is relying on the
interactive prompting for passwords. All the code related
to password prompting can thus be ripped out.
Reviewed-by: Max Reitz
Signed-off-by: Daniel P. Berrange
---
hmp.c
From: Paolo Bonzini
AioContext is fairly self contained, the only dependency is QEMUTimer but
that in turn doesn't need anything else. So move them out of block-obj-y
to avoid introducing a dependency from io/ to block-obj-y.
main-loop and its dependency iohandler also need to be moved, because
The 138 and 158 iotests exercise the legacy qcow2 aes encryption
code path and they work fine with qcow v1 too.
Reviewed-by: Alberto Garcia
Reviewed-by: Max Reitz
Signed-off-by: Daniel P. Berrange
---
tests/qemu-iotests/134 | 2 +-
tests/qemu-iotests/158 | 2 +-
2 files changed, 2 insertions(+
From: Paolo Bonzini
qcow2_create2 calls this. Do not run a nested event loop, as that
breaks when aio_co_wake tries to queue the coroutine on the co_queue_wakeup
list of the currently running one.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
Reviewed-by: Fam Zheng
Message-id: 20
On 21/02/2017 11:42, Paolo Bonzini wrote:
> The functions simplify the handling of QOM properties whose type
> is a QAPI struct. They go through a QObject just like the other
> functions that access a QOM property through its C type.
>
> Like QAPI_CLONE, the functions are wrapped by macros that
This adds support for using LUKS as an encryption format
with the qcow2 file. The use of the existing 'encryption=on'
parameter is replaced by a new parameter 'encryption-format'
which takes the values 'aes' or 'luks'. e.g.
# qemu-img create --object secret,data=123456,id=sec0 \
-f qcow2
Now that all encryption keys must be provided upfront via
the QCryptoSecret API and associated block driver properties
there is no need for any explicit encryption handling APIs
in the block layer. Encryption can be handled transparently
within the block driver. We only retain an API for querying
w
From: Paolo Bonzini
Once the thread pool starts using aio_co_wake, it will also need
qemu_get_current_aio_context(). Make test-thread-pool create
an AioContext with qemu_init_main_loop, so that stubs/iothread.c
and tests/iothread.c can provide the rest.
Reviewed-by: Stefan Hajnoczi
Signed-off-
From: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
Reviewed-by: Fam Zheng
Reviewed-by: Daniel P. Berrange
Message-id: 20170213135235.12274-13-pbonz...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
block/qed.h | 3 +++
block/curl.c|
While the crypto layer uses a fixed option name "key-secret",
the upper block layer may have a prefix on the options. e.g.
"luks-key-secret", "aes-key-secret", in order to avoid clashes
between crypto option names & other block option names. To
ensure the crypto layer can report accurate error mess
1 - 100 of 544 matches
Mail list logo
