Re: [Qemu-devel] [PULL v3 0/3] audio patch queue

On 1 March 2017 at 15:40, Gerd Hoffmann wrote: > Hi, > > Three little audio patches, adding replay support > and fixing audio with SDL2. > > v3: really fix osx build failure. > > The following changes since commit e7c83a885f865128ae3cf1946f8cb538b63cbfba: > > vhost-user:

[Qemu-devel] [PATCH] memory: show region offset and ROM/RAM type in "info mtree -f"

"info mtree -f" output is currently hard to use for large RAM regions, because there is no hint as to what part of the region is being mapped. Add the offset if it is nonzero. Secondly, FlatView has a readonly field, that can override the MemoryRegion in the presence of aliases. Take it into

[Qemu-devel] [PATCH 08/15] sheepdog: Use SocketAddress and socket_connect()

sd_parse_uri() builds a string from host and port parts for inet_connect(). inet_connect() parses it into host, port and options. Whether this gets exactly the same host, port and no options for all inputs is not obvious. Cut out the string middleman and build a SocketAddress for

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

On Thu, Mar 02, 2017 at 10:25:49AM -0800, Felipe Franciosi wrote: > Based on various discussions on the 2016 KVM Forum, I'm sending over a > vhost-user-scsi implementation for your consideration. > > This patchset introduces a new vhost-user SCSI device. While heavily > based on vhost-scsi, it is

Re: [Qemu-devel] [PATCH] Bugfix: Handle error if VM Generation ID device not present

On Thu, Mar 02, 2017 at 03:41:33PM -0600, Eric Blake wrote: > On 03/02/2017 03:36 PM, b...@skyportsystems.com wrote: > > From: Ben Warren > > > > This was crashing due to NULL-pointer dereference > > > > QMP Test case: > > == > > > > (QEMU)

[Qemu-devel] [PATCH 14/15] qapi-schema: Rename SocketAddressFlat's variant tcp to inet

QAPI type SocketAddressFlat differs from SocketAddress pointlessly: the discriminator value for variant InetSocketAddress is 'tcp' instead of 'inet'. Rename. The type is far only used by the Gluster block drivers. Take care to keep 'tcp' working there. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 05/11] translate-all: exit cpu_restore_state early if translating

On 03/03/2017 06:53 AM, Alex Bennée wrote: The translation code uses cpu_ld*_code which can trigger a tlb_fill which if it fails will attempt a fault resolution. This never works during translation as the TB being generated hasn't been added yet. However with the new locking regime we end up

[Qemu-devel] [PATCH 15/15] sheepdog: Support blockdev-add

Signed-off-by: Markus Armbruster --- qapi/block-core.json | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 28f1b10..3b1e4ad 100644 --- a/qapi/block-core.json +++

[Qemu-devel] [PATCH 13/15] qapi-schema: Rename GlusterServer to SocketAddressFlat

As its documentation says, it's not specific to Gluster. Rename it, as I'm going to use it for something else. Signed-off-by: Markus Armbruster --- block/gluster.c | 38 +++--- qapi-schema.json | 38

[Qemu-devel] [PATCH 07/15] sheepdog: Report errors in pseudo-filename more usefully

Errors in the pseudo-filename are all reported with the same laconic "Can't parse filename" message. Add real error reporting, such as: $ qemu-system-x86_64 --drive driver=sheepdog,filename=sheepdog:/// qemu-system-x86_64: --drive driver=sheepdog,filename=sheepdog:///: missing file path

[Qemu-devel] [PATCH 11/15] gluster: Don't duplicate qapi-util.c's qapi_enum_parse()

Signed-off-by: Markus Armbruster --- block/gluster.c | 30 +- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index 7236d59..6fbcf9e 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -12,6 +12,7

[Qemu-devel] [PATCH 09/15] sheepdog: Implement bdrv_parse_filename()

This permits configuration with driver-specific options in addition to pseudo-filename parsed as URI. For instance, --drive driver=sheepdog,host=fido,vdi=dolly instead of --drive driver=sheepdog,file=sheepdog://fido/dolly It's also a first step towards supporting blockdev-add.

[Qemu-devel] [PATCH 12/15] gluster: Plug memory leaks in qemu_gluster_parse_json()

To reproduce, run $ valgrind qemu-system-x86_64 --nodefaults -S --drive driver=gluster,volume=testvol,path=/a/b/c,server.0.type=xxx Signed-off-by: Markus Armbruster --- block/gluster.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-)

[Qemu-devel] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create()

sd_parse_uri() truncates long VDI names silently. Reject them instead. Signed-off-by: Markus Armbruster --- block/sheepdog.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index deb110e..72a52a6 100644 ---

[Qemu-devel] [PATCH 04/15] sheepdog: Mark sd_snapshot_delete() lossage FIXME

sd_snapshot_delete() should delete the snapshot whose ID matches @snapshot_id and whose name matches @name. But that's not what it does. If @snapshot_id is a valid ID, it deletes the snapshot with that ID, else it deletes the snapshot with that name. It doesn't use @name at all. Add suitable

[Qemu-devel] [PATCH 00/15] block: A bunch of fixes for Sheepdog and Gluster

Bad error handling, memory leaks, and lack of blockdev-add support. Markus Armbruster (15): sheepdog: Defuse time bomb in sd_open() error handling sheepdog: Fix error handling in sd_snapshot_delete() sheepdog: Fix error handling sd_create() sheepdog: Mark sd_snapshot_delete() lossage

[Qemu-devel] [PATCH 01/15] sheepdog: Defuse time bomb in sd_open() error handling

When qemu_opts_absorb_qdict() fails, sd_open() closes stdin, because sd->fd is still zero. Fortunately, qemu_opts_absorb_qdict() can't fail, because: 1. it only fails when qemu_opt_parse() fails, and 2. the only member of runtime_opts.desc[] is a QEMU_OPT_STRING, and 3. qemu_opt_parse() can't

[Qemu-devel] [PATCH 02/15] sheepdog: Fix error handling in sd_snapshot_delete()

As a bdrv_snapshot_delete() method, sd_snapshot_delete() must set an error and return negative errno on failure. It sometimes returns -1, and sometimes neglects to set an error. It also prints error messages with error_report(). Fix all that. Moreover, its handling of an attempt to delete an

[Qemu-devel] [PATCH 10/15] gluster: Drop assumptions on SocketTransport names

qemu_gluster_glfs_init() passes the names of QAPI enumeration type SocketTransport to glfs_set_volfile_server(). Works, because they were chosen to match. But the coupling is artificial. Use the appropriate literal strings instead. Signed-off-by: Markus Armbruster ---

[Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create()

As a bdrv_create() method, sd_create() must set an error and return negative errno on failure. It prints the error instead of setting it when connect_to_sdog() fails. Fix that. While there, return the value of connect_to_sdog() like we do elsewhere, instead of -EIO. No functional change, as

[Qemu-devel] [PATCH 05/15] sheepdog: Fix snapshot ID parsing in _open(), _create, _goto()

sd_parse_uri() and sd_snapshot_goto() screw up error checking after strtoul(), and truncate long tag names silently. Fix by replacing those parts by new sd_parse_snapid_or_tag(), which checks more carefully. sd_snapshot_delete() also parses snapshot IDs, but is currently too broken for me to

Re: [Qemu-devel] [PATCH] Bugfix: Handle error if VM Generation ID device not present

On 03/02/2017 03:36 PM, b...@skyportsystems.com wrote: > From: Ben Warren > > This was crashing due to NULL-pointer dereference > > QMP Test case: > == > > (QEMU) query-vm-generation-id > {"error": {"class": "GenericError", "desc": "VM Generation ID device

[Qemu-devel] [PATCH] Bugfix: Handle error if VM Generation ID device not present

From: Ben Warren This was crashing due to NULL-pointer dereference QMP Test case: == (QEMU) query-vm-generation-id {"error": {"class": "GenericError", "desc": "VM Generation ID device not found"}} HMP Test case: == virsh # qemu-monitor-command

[Qemu-devel] IPv6 gets removed on bridge

Hi, i have a short question iam using proxmox and my ipv6 settings gets removed every time a vm is added to the bridge. So can you confirm this function/bug/behavior? Before VM starts ~# sysctl -qa 2>/dev/null | grep 'disable_ipv6' net.ipv6.conf.all.disable_ipv6 = 0

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

On 2 March 2017 at 20:55, BALATON Zoltan wrote: > On Thu, 2 Mar 2017, Peter Maydell wrote: >> >> On 2 March 2017 at 20:18, BALATON Zoltan wrote: >>> >>> On Thu, 2 Mar 2017, Peter Maydell wrote: Don't use qemu_register_reset(). Set the

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

On Thu, 2 Mar 2017, BALATON Zoltan wrote: On Thu, 2 Mar 2017, Peter Maydell wrote: On 2 March 2017 at 20:18, BALATON Zoltan wrote: On Thu, 2 Mar 2017, Peter Maydell wrote: Don't use qemu_register_reset(). Set the appropriate dc->reset function pointers instead. Any

Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

On 25 February 2017 at 18:46, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > > v2: Split off small clean up to other patch > > hw/display/sm501.c | 6 +++--- > hw/display/sm501_template.h | 23 ++- > 2 files

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

On Thu, 2 Mar 2017, Peter Maydell wrote: On 2 March 2017 at 20:18, BALATON Zoltan wrote: On Thu, 2 Mar 2017, Peter Maydell wrote: Don't use qemu_register_reset(). Set the appropriate dc->reset function pointers instead. Any reason for that? This way I could save two

Re: [Qemu-devel] [PATCH v2 12/14] sm501: Implement reading 2D engine registers

On 2 March 2017 at 20:22, BALATON Zoltan wrote: > On Thu, 2 Mar 2017, Peter Maydell wrote: >> >> On 25 February 2017 at 21:47, BALATON Zoltan wrote: >>> >>> Clients normally only write to these registers, nothing is known to >>> ever read them but they are

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

On 2 March 2017 at 20:18, BALATON Zoltan wrote: > On Thu, 2 Mar 2017, Peter Maydell wrote: >> >> Don't use qemu_register_reset(). Set the appropriate dc->reset >> function pointers instead. > > > Any reason for that? This way I could save two more boilerplate functions >

Re: [Qemu-devel] [PATCH v2 10/14] sm501: Add support for panel layer

On 2 March 2017 at 20:15, BALATON Zoltan wrote: > On Thu, 2 Mar 2017, Peter Maydell wrote: >> >> This is another refactoring that's unrelated to adding panel >> layer support, right? (It's just changing from having src and >> offset updated at the end of the loop to dropping

Re: [Qemu-devel] [PATCH v2 05/14] sm501: Add emulation of chip connected via PCI

On 2 March 2017 at 20:13, BALATON Zoltan wrote: > On Thu, 2 Mar 2017, Peter Maydell wrote: >> >> On 25 February 2017 at 18:31, BALATON Zoltan wrote: >>> >>> Only the display controller part is created automatically on PCI >>> >>> Signed-off-by: BALATON

Re: [Qemu-devel] [PULL 0/2] docs: update sample configuration files

On 1 March 2017 at 13:51, Gerd Hoffmann wrote: > Hi, > > $subject says all. Finally merging this. Wasn't clear which > maintainer/tree this should though, so I guess everybody hoped for > someone else picking it up, causing the series lingering on the list > for quite a

Re: [Qemu-devel] [PATCH v2 12/14] sm501: Implement reading 2D engine registers

On Thu, 2 Mar 2017, Peter Maydell wrote: On 25 February 2017 at 21:47, BALATON Zoltan wrote: Clients normally only write to these registers, nothing is known to ever read them but they are documented as read/write so allow clients to also read the values. Signed-off-by:

Re: [Qemu-devel] [PATCH v2 11/14] sm501: Add some more missing registers

On Thu, 2 Mar 2017, Peter Maydell wrote: On 10 December 2016 at 02:05, BALATON Zoltan wrote: Values are not used yet, only stored to allow clients to initialise these without failing as long as no 2D engine function is called that would use the written value.

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

On Thu, 2 Mar 2017, Peter Maydell wrote: On 25 February 2017 at 23:53, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 110 ++--- 1 file changed, 105 insertions(+), 5

Re: [Qemu-devel] [PATCH v2 10/14] sm501: Add support for panel layer

On Thu, 2 Mar 2017, Peter Maydell wrote: On 25 February 2017 at 19:25, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- v2: Split off renaming a variable to separate clean up patch hw/display/sm501.c | 63

Re: [Qemu-devel] [PATCH v2 05/14] sm501: Add emulation of chip connected via PCI

On Thu, 2 Mar 2017, Peter Maydell wrote: On 25 February 2017 at 18:31, BALATON Zoltan wrote: Only the display controller part is created automatically on PCI Signed-off-by: BALATON Zoltan --- v2: Split off removing dependency on base address to

Re: [Qemu-devel] [PATCH v2 06/14] sm501: Add missing arbitration control register

On 3 December 2016 at 15:32, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > hw/display/sm501.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/display/sm501.c b/hw/display/sm501.c > index d9219bd..b977094 100644 > ---

Re: [Qemu-devel] [PATCH v2 06/14] sm501: Add missing arbitration control register

On 2 March 2017 at 20:08, Peter Maydell wrote: > On 3 December 2016 at 15:32, BALATON Zoltan wrote: >> Signed-off-by: BALATON Zoltan >> --- >> hw/display/sm501.c | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git

Re: [Qemu-devel] [PATCH v2 04/14] sm501: Get rid of base address in draw_hwc_line

On Thu, 2 Mar 2017, Peter Maydell wrote: On 25 February 2017 at 18:23, BALATON Zoltan wrote: Do not use the base address to access data in local memory. This is in preparation to allow chip connected via PCI where base address depends on where the BAR is mapped so it will

Re: [Qemu-devel] [PATCH] linux-user: Exclude more cpu model code when building s390x linux-user

Am 02.03.2017 um 20:59 schrieb Bruce Rogers: On 3/2/2017 at 12:53 PM, wrote: >> Am 02.03.2017 um 20:50 schrieb David Hildenbrand: >>> Am 02.03.2017 um 20:33 schrieb Bruce Rogers: Currently qemu-s390x segfaults. Avoid cpu model code which doesn't apply in linux

Re: [Qemu-devel] [PATCH v2 12/14] sm501: Implement reading 2D engine registers

On 25 February 2017 at 21:47, BALATON Zoltan wrote: > Clients normally only write to these registers, nothing is known to > ever read them but they are documented as read/write so allow clients > to also read the values. > > Signed-off-by: BALATON Zoltan >

Re: [Qemu-devel] po: created Polish translation

On 2 March 2017 at 19:44, Marcin Mikołajczak wrote: > Signed-off-by: Marcin Mikołajczak > --- > po/pl.po | 90 > > 1 file changed, 90 insertions(+) > create mode 100644 po/pl.po > diff --git a/po/pl.po

Re: [Qemu-devel] [PATCH v2 02/14] sm501: Use defines instead of constants where available

On Thu, 2 Mar 2017, Peter Maydell wrote: On 2 March 2017 at 18:53, Peter Maydell wrote: On 7 November 2016 at 09:03, BALATON Zoltan wrote: I just found a datasheet which says that the power-on-default for the misc-control register is

Re: [Qemu-devel] [PATCH v2 11/14] sm501: Add some more missing registers

On 10 December 2016 at 02:05, BALATON Zoltan wrote: > Values are not used yet, only stored to allow clients to initialise > these without failing as long as no 2D engine function is called that > would use the written value. > > Signed-off-by: BALATON Zoltan

Re: [Qemu-devel] [PATCH] linux-user: Exclude more cpu model code when building s390x linux-user

>>> On 3/2/2017 at 12:53 PM, wrote: > Am 02.03.2017 um 20:50 schrieb David Hildenbrand: >> Am 02.03.2017 um 20:33 schrieb Bruce Rogers: >>> Currently qemu-s390x segfaults. Avoid cpu model code which doesn't >>> apply in linux user case. >> >> That was also my impression, but it

[Qemu-devel] [PATCH v2 09/11] target/mips/op_helper: hold BQL before calling cpu_mips_get_count

We should hold the BQL before we transition to HW emulation. This is because all HW emulation needs to be serialised under MTTCG conditions. This is picked up by asserts that fire when cpu_mips_get_count triggers and IRQ. Reported-by: Yongbok Kim Signed-off-by: Alex

Re: [Qemu-devel] [PATCH v2] target/s390x: Fix broken user mode

Am 30.01.2017 um 14:15 schrieb Stefan Weil: > Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error. > > Signed-off-by: Stefan Weil > --- > > v2: Re-sent as v1 was damaged by my mailer. > > This is also broken in Debian. > > In addition, there is no

[Qemu-devel] [PATCH v2 10/11] target/arm/helper: make it clear the EC field is also in hex

..just like the rest of the displayed ESR register. Otherwise people might scratch their heads if a not obviously hex number is displayed for the EC field. Signed-off-by: Alex Bennée --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v2 07/11] s390x/misc_helper.c: wrap IO instructions in BQL

Helpers that can trigger IO events (including interrupts) need to be protected by the BQL. I've updated all the helpers that call into an ioinst_handle_* functions. Reported-by: Thomas Huth Signed-off-by: Alex Bennée --- target/s390x/misc_helper.c | 21

Re: [Qemu-devel] [PATCH v2 03/14] sm501: QOMify

On 3 December 2016 at 02:05, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan It would be helpful to mention in the commit message that we don't yet implement reset or vmstate and that those are coming in a later commit. (There is almost always

[Qemu-devel] [PATCH v2 11/11] hw/intc/arm_gic: modernise the DPRINTF

While I was debugging the icount issues I realised a bunch of the messages look quite similar. I've fixed this by including __func__ in the debug print. At the same time I move the a modern if (GATE) style printf which ensures the compiler can check for format string errors even if the code gets

[Qemu-devel] [PATCH v2 04/11] translate: downgrade IRQ BQL asserts to tcg_debug_assert

While on MTTCG hosts it is very important that updates to cpu->interrupt_request are protected by the BQL not all guests have been converted to the correct locking yet. As a result we are seeing breaking on non-MTTCG enabled guests in production builds. The locking in the guests needs to be fixed

Re: [Qemu-devel] [PATCH] linux-user: Exclude more cpu model code when building s390x linux-user

Am 02.03.2017 um 20:50 schrieb David Hildenbrand: > Am 02.03.2017 um 20:33 schrieb Bruce Rogers: >> Currently qemu-s390x segfaults. Avoid cpu model code which doesn't >> apply in linux user case. > > That was also my impression, but it does apply. However, for now it > doesn't matter, as also tcg

[Qemu-devel] [PATCH v2 06/11] sparc/sparc64: grab BQL before calling cpu_check_irqs

IRQ modification is part of device emulation and should be done while the BQL is held to prevent races when MTTCG is enabled. This adds assertions in the hw emulation layer and wraps the calls from helpers in the BQL. Reported-by: Mark Cave-Ayland Signed-off-by:

[Qemu-devel] [PATCH v2 01/11] vl/cpus: be smarter with icount and MTTCG

The sense of the test was inverted. Make it simple, if icount is enabled then we disabled MTTCG by default. If the user tries to force MTTCG upon us then we tell them "no". Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- cpus.c | 7

[Qemu-devel] [PATCH v2 08/11] target/xtensa: hold BQL for interrupt processing

Make sure we have the BQL held when processing interrupts. Reported-by: Thomas Huth Signed-off-by: Alex Bennée --- target/xtensa/helper.c| 1 + target/xtensa/op_helper.c | 7 +++ 2 files changed, 8 insertions(+) diff --git

[Qemu-devel] [PATCH v2 03/11] cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG

While we may fail the memory ordering check later that can be confusing. So in cases where TARGET_SUPPORT_MTTCG has yet to be defined we should say so specifically. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- cpus.c | 4 1 file

[Qemu-devel] [PATCH v2 02/11] target/i386/cpu.h: declare TCG_GUEST_DEFAULT_MO

This suppresses the incorrect warning when forcing MTTCG for x86 guests on x86 hosts. A future patch will still warn when TARGET_SUPPORT_MTTCG hasn't been defined for the guest (which is still pending for x86). Reported-by: Paolo Bonzini Signed-off-by: Alex Bennée

[Qemu-devel] [PATCH v2 00/11] MTTCG fixups for 2.9

Hi Peter, So perhaps predictably the merging of MTTCG has thrown up some issues during soft-freeze. The following patches fix up some of those: The following where in v1 and just have r-b tags: vl/cpus: be smarter with icount and MTTCG target/i386/cpu.h: declare TCG_GUEST_DEFAULT_MO

[Qemu-devel] [PATCH v2 05/11] translate-all: exit cpu_restore_state early if translating

The translation code uses cpu_ld*_code which can trigger a tlb_fill which if it fails will attempt a fault resolution. This never works during translation as the TB being generated hasn't been added yet. However with the new locking regime we end up double locking the tb_lock(). As the tcg_ctx.cpu

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

On 25 February 2017 at 23:53, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > hw/display/sm501.c | 110 > ++--- > 1 file changed, 105 insertions(+), 5 deletions(-) > > diff --git

[Qemu-devel] [PATCH] linux-user: Exclude more cpu model code when building s390x linux-user

Currently qemu-s390x segfaults. Avoid cpu model code which doesn't apply in linux user case. Signed-off-by: Bruce Rogers --- target/s390x/cpu_models.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/cpu_models.c

Re: [Qemu-devel] [PATCH] linux-user: Exclude more cpu model code when building s390x linux-user

Am 02.03.2017 um 20:33 schrieb Bruce Rogers: > Currently qemu-s390x segfaults. Avoid cpu model code which doesn't > apply in linux user case. That was also my impression, but it does apply. However, for now it doesn't matter, as also tcg isn't properly wired up. In general, linux-user can

[Qemu-devel] [PATCH] tests: check path to avoid a failing qga/get-vcpus test

The qga/get-vcpus test fails in a simple chroot environment, as used in an openSUSE Build Service local build, so first check that the sysfs based path exists in order to avoid calling this test in an environment where it won't work right. Signed-off-by: Bruce Rogers ---

Re: [Qemu-devel] [PATCH v2 10/14] sm501: Add support for panel layer

On 25 February 2017 at 19:25, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > > v2: Split off renaming a variable to separate clean up patch > > hw/display/sm501.c | 63 > +++--- > 1 file

[Qemu-devel] po: created Polish translation

Signed-off-by: Marcin Mikołajczak --- po/pl.po | 90 1 file changed, 90 insertions(+) create mode 100644 po/pl.po diff --git a/po/pl.po b/po/pl.po new file mode 100644 index 00..581e7ec09e --- /dev/null +++ b/po/pl.po @@

Re: [Qemu-devel] [PATCH v2 09/14] sm501: Misc clean ups

On 25 February 2017 at 19:19, BALATON Zoltan wrote: > - Rename a variable > - Move variable declarations out of loop to the beginning in draw_hwc_line > > Signed-off-by: BALATON Zoltan > --- > hw/display/sm501.c | 10 +- >

Re: [Qemu-devel] [PATCH v2 08/14] sm501: Fix hardware cursor

On 4 December 2016 at 18:01, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan Can you say in the commit message what the bugs you're fixing are, please? Otherwise it's a bit hard to disentangle here what's just refactoring and what's making

[Qemu-devel] [PATCH] linux-user: Exclude more cpu model code when building s390x linux-user

Currently qemu-s390x segfaults. Avoid cpu model code which doesn't apply in linux user case. --- target/s390x/cpu_models.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 2a894eec65..97e4e75f68 100644 ---

Re: [Qemu-devel] [PATCH v5 1/4] libvhost-user: replace vasprintf() to fix build

On 03/02/2017 12:25 PM, Felipe Franciosi wrote: > On gcc 3.4 and newer, simply using (void) in front of WUR functions is > not sufficient to ignore the return value. That prevents a build when > handling warnings as errors. > > libvhost-user had a usage of (void)vasprintf() which triggered such a

Re: [Qemu-devel] [PULL 00/27] migration queue

On 28 February 2017 at 12:40, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit 6181478f6395cdd9d6ffd99623d0c9f39ea53606: > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

On 03/02/2017 11:01 AM, Felipe Franciosi wrote: > Hi Eric, > > Ping on this? > http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg06169.html > [context: Re: [Qemu-devel] [PATCH 1/2] compiler: add ignore_value() macro] I'm still in favor of the patch, but only when it has a client. And

Re: [Qemu-devel] [PATCH v2 05/14] sm501: Add emulation of chip connected via PCI

On 25 February 2017 at 18:31, BALATON Zoltan wrote: > Only the display controller part is created automatically on PCI > > Signed-off-by: BALATON Zoltan > --- > > v2: Split off removing dependency on base address to separate patch > > hw/display/sm501.c |

Re: [Qemu-devel] [PATCH v2 04/14] sm501: Get rid of base address in draw_hwc_line

On 25 February 2017 at 18:23, BALATON Zoltan wrote: > Do not use the base address to access data in local memory. This is in > preparation to allow chip connected via PCI where base address depends > on where the BAR is mapped so it will be unknown. > > Signed-off-by: BALATON

Re: [Qemu-devel] [PATCH for-2.9 v3 0/2] migration: fixes to handling tls-hostname/tls-creds

On 03/02/2017 10:19 AM, Daniel P. Berrange wrote: > The need for these two patches was identified during implementation of > TLS encrypted migration in libvirt. > > Changed in v3: > > - Add to qapi-schema.json docs > > Daniel P. Berrange (2): > migration: allow clearing migration string

Re: [Qemu-devel] [PATCH v2 02/14] sm501: Use defines instead of constants where available

On 2 March 2017 at 18:53, Peter Maydell wrote: > On 7 November 2016 at 09:03, BALATON Zoltan wrote: > I just found a datasheet which says that the power-on-default > for the misc-control register is 0b...00x0.0001..xxx0.0xxx > which

[Qemu-devel] [PATCH 1/1] virtio: fail device if set_event_notifier fails

The function virtio_notify_irqfd used to ignore the return code of event_notifier_set. Let's fail the device should this occur. Signed-off-by: Halil Pasic --- This patch is most likely flawed because virtio_notify_irqfd is probably supposed to be thread-safe and

Re: [Qemu-devel] [PATCH v2 02/14] sm501: Use defines instead of constants where available

On 7 November 2016 at 09:03, BALATON Zoltan wrote: > This also fixes the initial value of misc_control register to match the > comment which is likely what was intended but the DAC_POWER bit was set > instead. This value is unused so it does not really matter but is > fixed

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1488479153-21203-1-git-send-email-fel...@nutanix.com Type: series Subject: [Qemu-devel] [PATCH v5 0/4] Introduce

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1488479153-21203-1-git-send-email-fel...@nutanix.com Type: series Subject: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH v5 4/4] vus: Introduce a vhost-user-scsi sample application

This commit introduces a vhost-user-scsi backend sample application. It must be linked with libiscsi and libvhost-user. To use it, compile with: make vhost-user-scsi And run as follows: ./vhost-user-scsi -u /tmp/vus.sock -i iscsi://uri_to_target/ The application is currently limited at one LUN

[Qemu-devel] [PATCH v5 2/4] vhost-scsi: create a vhost-scsi-common abstraction

In order to introduce a new vhost-user-scsi host device type, it makes sense to abstract part of vhost-scsi into a common parent class. This commit does exactly that. Signed-off-by: Felipe Franciosi --- hw/scsi/Makefile.objs | 2 +-

[Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

Based on various discussions on the 2016 KVM Forum, I'm sending over a vhost-user-scsi implementation for your consideration. This patchset introduces a new vhost-user SCSI device. While heavily based on vhost-scsi, it is implemented using vhost's userspace counterpart. The device has been coded

[Qemu-devel] [PATCH v5 1/4] libvhost-user: replace vasprintf() to fix build

On gcc 3.4 and newer, simply using (void) in front of WUR functions is not sufficient to ignore the return value. That prevents a build when handling warnings as errors. libvhost-user had a usage of (void)vasprintf() which triggered such a condition. This fixes it by replacing this call with

[Qemu-devel] [PATCH v5 3/4] vus: Introduce vhost-user-scsi host device

This commit introduces a vhost-user device for SCSI. This is based on the existing vhost-scsi implementation, but done over vhost-user instead. It also uses a chardev to connect to the backend. Unlike vhost-scsi (today), VMs using vhost-user-scsi can be live migrated. To use it, start Qemu with a

[Qemu-devel] [PATCH 1/1] event_notifier: prevent accidental use after close

Let's set the handles to the underlying facilities to their extremal value so no accidental misuse can happen, and to make it obvious that the notifier is dysfunctional. E.g. if we just close an fd but do not touch the int holding the fd eventually a read/write could succeed again when the fd gets

Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

> On 2 Mar 2017, at 18:08, Paolo Bonzini wrote: > > > > On 02/03/2017 18:39, Felipe Franciosi wrote: >>> Yeah, it wasn't previously noticed since these files weren't compiled >>> by default. Since you've added make rules to enable build, I'm afraid >>> you've got the

Re: [Qemu-devel] git master build failure in 9pfs

On 2 March 2017 at 17:40, Daniel P. Berrange wrote: > On Thu, Mar 02, 2017 at 05:28:24PM +, Mark Cave-Ayland wrote: >> Build platform is Debian Wheezy on an x86_64 host. > > IIUC, O_PATH was introduced in glibc 2.14 and Wheezy only has 2.13. > > So unless we want to make

Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

On 02/03/2017 18:39, Felipe Franciosi wrote: >> Yeah, it wasn't previously noticed since these files weren't compiled >> by default. Since you've added make rules to enable build, I'm afraid >> you've got the unfortunate job of cleaning up pre-existing build >> problems. I'd suggest just doing

Re: [Qemu-devel] [PULL v4 00/19] KVM and cpu-exec patches for 2.9 soft freeze

On 01/03/2017 18:58, Peter Maydell wrote: > Fails to build, ppc64, aarch64 (and probably others): > > In file included from /home/pm215/qemu/include/qemu/osdep.h:36:0, > from /home/pm215/qemu/kvm-all.c:16: > /home/pm215/qemu/kvm-all.c: In function ‘kvm_cpu_exec’: >

Re: [Qemu-devel] travis-ci 'make check' timeouts (was Re: [PULL 00/11] x86 queue, 2017-02-27)

On Thu, Mar 02, 2017 at 04:16:53PM +, Peter Maydell wrote: > On 2 March 2017 at 16:07, Eduardo Habkost wrote: > > Earlier this week I saw the wait_for_fds assertion (mentioned at > > the thread above) on a travis-ci job again, and I was suspecting > > it was the same

Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

> On 2 Mar 2017, at 17:17, Daniel P. Berrange wrote: > > On Thu, Mar 02, 2017 at 05:01:06PM +, Felipe Franciosi wrote: >> Hi Eric, >> >> Ping on this? >> http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg06169.html > > [snip] > >> CC

Re: [Qemu-devel] git master build failure in 9pfs

On Thu, Mar 02, 2017 at 05:28:24PM +, Mark Cave-Ayland wrote: > Does anyone else see the following error when trying to build git master? > > cc -I/home/build/src/qemu/git/qemu/hw/9pfs -Ihw/9pfs > -I/home/build/src/qemu/git/qemu/tcg > -I/home/build/src/qemu/git/qemu/tcg/i386 >

Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

> On 2 Mar 2017, at 17:32, Daniel P. Berrange wrote: > > On Thu, Mar 02, 2017 at 05:21:46PM +, Felipe Franciosi wrote: >> >>> On 2 Mar 2017, at 17:17, Daniel P. Berrange wrote: >>> >>> On Thu, Mar 02, 2017 at 05:01:06PM +, Felipe Franciosi

Re: [Qemu-devel] [PULL 00/28] Leak patches

On 1 March 2017 at 09:04, Marc-André Lureau wrote: > The following changes since commit e7c83a885f865128ae3cf1946f8cb538b63cbfba: > > vhost-user: delay vhost_user_stop (2017-02-28 19:11:15 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

On Thu, Mar 02, 2017 at 05:21:46PM +, Felipe Franciosi wrote: > > > On 2 Mar 2017, at 17:17, Daniel P. Berrange wrote: > > > > On Thu, Mar 02, 2017 at 05:01:06PM +, Felipe Franciosi wrote: > >> Hi Eric, > >> > >> Ping on this? > >>

[Qemu-devel] git master build failure in 9pfs

Does anyone else see the following error when trying to build git master? cc -I/home/build/src/qemu/git/qemu/hw/9pfs -Ihw/9pfs -I/home/build/src/qemu/git/qemu/tcg -I/home/build/src/qemu/git/qemu/tcg/i386 -I/home/build/src/qemu/git/qemu/linux-headers -I/home/build/src/qemu/git/qemu/linux-headers

Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application

On Thu, Mar 02, 2017 at 05:01:06PM +, Felipe Franciosi wrote: > Hi Eric, > > Ping on this? > http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg06169.html [snip] > CC contrib/ivshmem-client/main.o > >

<    1   2   3   4   >