Dear QEMU developers,
I have a problem when running qemu to build a system with versatilepb,
linux zImage and rootfs. the qemu cmdl is as follows.
../qemu/build/arm-softmmu/qemu-system-arm.exe -M versatilepb -kernel zImage
-dtb versatile-pb.dtb -initrd ramfs.gz -nographic -append "console=ttyAMA0
Cc: qemu-trivial
Philippe Mathieu-Daudé writes:
> This patchset fixes three easy-to-fix clang warnings.
>
> Philippe Mathieu-Daudé (3):
> usb-ccid: make ccid_write_data_block() cope with null buffers
> device_tree: fix compiler warnings (clang 5)
> qga: fix compiler warnings (clang 5)
>
>
> On 3 Mar 2017, at 18:52 PM, Philippe Mathieu-Daudé wrote:
>
> On 02/16/2017 09:29 AM, Dmitry Fleytman wrote:
>> Make VLAN stripping functions return number of bytes
>> copied to given Ethernet header buffer.
>>
>> This information should be used to re-compose
>> packet IOV after VLAN strippin
> On 3 Mar 2017, at 18:39 PM, Philippe Mathieu-Daudé wrote:
>
> Hi Dmitry,
>
> On 02/16/2017 09:29 AM, Dmitry Fleytman wrote:
>> In case of VLAN stripping ETH header is stored in a
>> separate chunk and length of IOV should take this into
>> account.
>>
>> This patch fixes checksum validation
Change malloc/free to g_malloc/g_free in util/envlist.c, except for
entry->env_var which is allocated using strdup(3).
Remove NULL checks for pointers returned from g_malloc as it exits
in case of failure. Update calls to envlist_create to reflect this.
Free array returned by envlist_to_environ u
On Sat, 4 Mar 2017, Peter Maydell wrote:
On 3 March 2017 at 20:11, BALATON Zoltan wrote:
On Fri, 3 Mar 2017, Peter Maydell wrote:
So what cases have you tested? The Linux kernel seems to support:
* sh embedded device, little endian
* PCI card, little endian host
* PCI card, big endian host
and
Signed-off-by: BALATON Zoltan
Reviewed-by: Peter Maydell
---
hw/display/sm501.c | 1132 ++-
hw/display/sm501_template.h | 52 +-
2 files changed, 594 insertions(+), 590 deletions(-)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 040
This is to allow clients to initialise these without failing as long
as no 2D engine function is called that would use the written value.
Saved values are not used yet (may get used when more of 2D engine is
added sometimes) and clients normally only write to most of these
registers, nothing is kno
Rework HWC handling to simplify it and fix cursor not updating on
screen as needed. Previously cursor was not updated because checking
for changes in a line overrode the update flag set for the cursor but
fixing this is not enough because the cursor should also be updated if
its shape or location c
This is not used by default on any emulated machine yet but it is
still useful to have it compiled so it can be added from the command
line for clients that can use it (e.g. MorphOS has no driver for any
other emulated video cards but can output via SM501)
Signed-off-by: BALATON Zoltan
---
defau
- Rename a variable
- Move variable declarations out of loop to the beginning in draw_hwc_line
Signed-off-by: BALATON Zoltan
Reviewed-by: Peter Maydell
---
hw/display/sm501.c | 10 +-
hw/display/sm501_template.h | 10 --
2 files changed, 9 insertions(+), 11 deletions(-)
Do not use the base address to access data in local memory. This is in
preparation to allow chip connected via PCI where base address depends
on where the BAR is mapped so it will be unknown.
Signed-off-by: BALATON Zoltan
Reviewed-by: Peter Maydell
---
hw/display/sm501.c | 6 ++
hw
Signed-off-by: BALATON Zoltan
Reviewed-by: Peter Maydell
---
v3: Added local_mem_size_index to vmstate, add vmstate for sysbus version too
hw/display/sm501.c | 100 -
1 file changed, 99 insertions(+), 1 deletion(-)
diff --git a/hw/display/sm
Fourth and hopefully last version with more changes according to
review comments. Also cc'ing David Gibson as PPC maintainer to check
the last patch and in case it's decided to go via PPC tree at the end
being too big for trivial and lack of maintenance for SH4.
BALATON Zoltan (13):
sm501: Fixed
Only the display controller part is created automatically on PCI
Signed-off-by: BALATON Zoltan
---
v2: Split off removing dependency on base address to separate patch
v3: Added reset function and PCI ID constant definitions in pci_ids.h
v4: Return error for invalid VRAM size, set bit in misc_con
Adding vmstate saving is not in this patch because the state structure
will be changed in further patches, then another patch will add
vmstate descriptor after those changes.
Signed-off-by: BALATON Zoltan
---
v2: Add memory regions to device state instead of allocating them
v3: Added reset funct
We only emulate the sysbus device in its default LE mode and PCI is LE
as well so specify this for registers. Colors were also off on both
SH4 and PPC which is also fixed here.
Signed-off-by: BALATON Zoltan
---
v2: Split off small clean up to other patch
v4: Set serial part to little endian as w
Signed-off-by: BALATON Zoltan
Reviewed-by: Peter Maydell
---
hw/display/sm501.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 6b72964..6e74200 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -474,6 +474,7 @@ typedef struct S
Signed-off-by: BALATON Zoltan
Reviewed-by: Peter Maydell
---
v3: Fix initial value of misc_control register as Peter Maydell suggested
Also use M_BYTE constant from cutils.h
hw/display/sm501.c | 29 +++--
hw/display/sm501_template.h | 2 +-
2 files changed
Signed-off-by: BALATON Zoltan
Reviewed-by: Peter Maydell
---
v2: Split off renaming a variable to separate clean up patch
hw/display/sm501.c | 63 +++---
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/hw/display/sm501.c b/hw/disp
On Fri, Mar 3, 2017 at 9:29 PM, John Snow wrote:
>
>
> On 03/03/2017 02:26 PM, Nir Soffer wrote:
>> On Fri, Mar 3, 2017 at 8:54 PM, John Snow wrote:
>>> Use the existing readline history function we are utilizing
>>> to provide persistent command history across instances of qmp-shell.
>>>
>>> Thi
if FTP_PROXY/HTTP_PROXY/HTTPS_PROXY standard environment variables available,
pass them to the docker daemon to build images.
this is required when building behind corporate proxy/firewall, but also help
when using local cache server (ie: apt/yum).
Signed-off-by: Philippe Mathieu-Daudé
---
tests
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index 1fe0ff39f2..5c030a90cd 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -
this fixes many warnings like:
target/mips/translate.c:6253:13: warning: Value stored to 'rn' is never read
rn = "invalid sel";
^~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 88 ++
Signed-off-by: Philippe Mathieu-Daudé
---
Makefile.objs| 1 +
target/mips/trace-events | 5 +
target/mips/translate.c | 25 +++--
3 files changed, 17 insertions(+), 14 deletions(-)
create mode 100644 target/mips/trace-events
diff --git a/Makefile.objs b/Ma
static code analyzer complain:
target/mips/helper.c:453:5: warning: Function call argument is an uninitialized
value
qemu_log_mask(CPU_LOG_MMU,
^~
'physical' and 'prot' are uninitialized if 'ret' is not TLBRET_MATCH.
Reported-by: Clang Static Analyzer
Signed-off-
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 4
1 file changed, 4 deletions(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index 8b4a072ecb..1fe0ff39f2 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -5137,7 +5137,6 @@ static v
static code analyzer complain:
device_tree.c:155:18: warning: Null pointer passed as an argument to a
'nonnull' parameter
while ((de = readdir(d)) != NULL) {
^~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
---
device_tree.c | 1 +
1 file
This patchset fixes two easy-to-fix clang warnings and replace few
qemu_log_mask() with trace points.
Philippe Mathieu-Daudé (5):
target-mips: fix compiler warnings (clang 5)
target-mips: remove old & unuseful comments
target-mips: log bad coprocessor0 register accesses with LOG_UNIMP
targ
static code analyzer complain:
qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to a
'nonnull' parameter
closedir(dp);
^~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
---
qga/commands-posix.c | 8 +---
1 file cha
static code analyzer complain:
hw/usb/dev-smartcard-reader.c:816:5: warning: Null pointer passed as an
argument to a 'nonnull' parameter
memcpy(p->abData, data, len);
^~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/dev-sm
This patchset fixes three easy-to-fix clang warnings.
Philippe Mathieu-Daudé (3):
usb-ccid: make ccid_write_data_block() cope with null buffers
device_tree: fix compiler warnings (clang 5)
qga: fix compiler warnings (clang 5)
device_tree.c | 1 +
hw/usb/dev-smartcard-reader
On 3 March 2017 at 03:24, David Gibson wrote:
> The following changes since commit ecb24d334af1a98ef0329f4b3b0e14ae8cb8770d:
>
> Merge remote-tracking branch 'remotes/rth/tags/pull-tgt-20170302' into
> staging (2017-03-02 22:06:41 +)
>
> are available in the git repository at:
>
> git://g
On 3 March 2017 at 16:28, Paolo Bonzini wrote:
> These cause compilation failures on CentOS 6 or other operating
> systems with older GCCs.
>
> Cc: David Gibson
> Cc: qemu-...@nongnu.org
> Signed-off-by: Paolo Bonzini
> ---
> It would probably be better to remove the
> sPAPRMachi
On 03/04/2017 05:21 AM, Greg Kurz wrote:
> On Fri, 3 Mar 2017 17:43:49 -0600
> Eric Blake wrote:
>
> It is acceptable to ignore O_PATH here because we have O_DIRECTORY, and
> we know openat_dir() will hence fail. But this code sits in a header
> file, and we probably don't want O_PATH to be sile
On 03/04/2017 04:54 AM, Greg Kurz wrote:
> The name argument can never be an empty string, and dirfd always point to
> the containing directory of the file name. AT_EMPTY_PATH is hence useless
> here. Also it breaks build with glibc version 2.13 and older.
>
> It is actually an oversight of a prev
On 3 March 2017 at 16:28, Paolo Bonzini wrote:
> These cause compilation failures on CentOS 6 or other operating
> systems with older GCCs.
>
> Cc: Richard Henderson
> Cc: Peter Maydell
> Signed-off-by: Paolo Bonzini
> ---
> Peter, please consider applying this as a build fix, because
>
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20170304110658.1402-1-sauravsachidan...@gmail.com
Subject: [Qemu-devel] [Qemu-trivial] [PATCH] util: Use g_malloc/g_free in
envlist.c
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
I don't know how to close bugs in launchpad, but this one can be closed
for a couple of reasons:
(1) I benchmarked virtio-mmio the other day using qemu-speed-test on aarch64
and I did not encounter the bug.
(2) aarch64 has supported virtio-pci for a while, for virtio-mmio is effectively
obsolete.
Fixed upstream, see previous comment.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/122
Title:
virtio-serial loses writes when used over
Change malloc/free to g_malloc/g_free in util/envlist.c, except for
entry->env_var which is allocated using strdup(3).
Remove NULL checks for pointers returned from g_malloc as it exits
in case of failure. Update calls to envlist_create to reflect this.
Free array returned by envlist_to_environ u
> Virtio will never support discard requests.
- what is that?
> Please use virtio-scsi.
- in some tests, SCSI emulation appears 7 times slower than the
paravirtualized bus.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://
Use the helper routine float[32,64]_maddsub_update_excp() in VSX_MADD
macro.
Signed-off-by: Nikunj A Dadhania
---
target/ppc/fpu_helper.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c
index 13bd6ce..c4d
Adds FPU_MADDSUB_UPDATE macro, this will be used for other routines
having float32/16
Signed-off-by: Nikunj A Dadhania
---
target/ppc/fpu_helper.c | 61 -
1 file changed, 30 insertions(+), 31 deletions(-)
diff --git a/target/ppc/fpu_helper.c b/tar
Current order of checking does not confirm with the spec
(ISA 3.0: MultiplyAddDP page-469). Change the order and make them
independent of each other.
For example: a = infinity, b = zero, c = SNaN, this should set both
VXIMZ and VXNAN
Signed-off-by: Nikunj A Dadhania
---
target/ppc/fpu_helper.c
Exception handling in fmadd/fmsub/fnmadd/fnmsub isnt correct as the
order of checking could give wrong settings in FPSCR.
For example, (x * y) + z, if x = infinity, y = zero and z = snan.
After the execution of instruction VXNAN and VXIMZ both should be set. For
this correct the ordering in the
On 3 March 2017 at 19:24, Richard Henderson wrote:
> On 03/04/2017 03:28 AM, Paolo Bonzini wrote:
>>
>> These cause compilation failures on CentOS 6 or other operating
>> systems with older GCCs.
>>
>> Cc: Richard Henderson
>> Cc: Peter Maydell
>> Signed-off-by: Paolo Bonzini
>> ---
>>
On 04/03/17 11:21, Greg Kurz wrote:
> On Fri, 3 Mar 2017 17:43:49 -0600
> Eric Blake wrote:
>
>> On 03/03/2017 12:14 PM, Eric Blake wrote:
>>> On 03/03/2017 11:25 AM, Greg Kurz wrote:
We should pass O_NOFOLLOW otherwise openat() will follow symlinks and make
QEMU vulnerable.
>>>
On 04/03/17 10:54, Greg Kurz wrote:
> The name argument can never be an empty string, and dirfd always point to
> the containing directory of the file name. AT_EMPTY_PATH is hence useless
> here. Also it breaks build with glibc version 2.13 and older.
>
> It is actually an oversight of a previous
On 4 March 2017 at 00:45, Richard Henderson wrote:
> On 03/03/2017 05:58 PM, Nikunj A Dadhania wrote:
>>
>> +#define FPU_MADDSUB_UPDATE(name, tp)\
>> +static void name(CPUPPCState *env, float64 arg1,\
>> + float64 arg2, fl
>> diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c
>> index 0535ad0..a547f58 100644
>> --- a/target/ppc/fpu_helper.c
>> +++ b/target/ppc/fpu_helper.c
>> @@ -747,17 +747,21 @@ static void float64_maddsub_update_excp(CPUPPCState
>> *env, float64 arg1,
>>
On 3 March 2017 at 16:30, Paolo Bonzini wrote:
> The following changes since commit 508e038a5d725f2aa729f58a1f5209b9be4227de:
>
> dtc: Revert unintentional submodule downgrade from commit 077dd74239a99
> (2017-03-03 12:48:42 +)
>
> are available in the git repository at:
>
> git://github.
On 3 March 2017 at 19:45, James Hanley wrote:
> I'm trying to clone clean and I'm getting the following when initing the
> submodules updated:
> It's unclear to me what should be done for a pristine clone - is there a
> step missing from pulling those submodules?
I just did:
git clone git://git
On 4 March 2017 at 00:00, wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
> === TEST BEGIN ===
> Using CC: /home/fam/bin/cc
> rm: cannot remove '/var/tmp/patchew-qemu-build/aarch64-softmmu': Directory
> not empty
> === OUTPUT END ===
Fam, can we dro
On 3 March 2017 at 20:56, BALATON Zoltan wrote:
> On Fri, 3 Mar 2017, Peter Maydell wrote:
>> Just noticed this. I think reporting the error upwards by
>> failing device realize is better than adjusting the value.
>> It's what we tend to do for other devices. Management tools
>> like libvirt prefe
On 3 March 2017 at 20:11, BALATON Zoltan wrote:
> On Fri, 3 Mar 2017, Peter Maydell wrote:
>> So what cases have you tested? The Linux kernel seems to support:
>> * sh embedded device, little endian
>> * PCI card, little endian host
>> * PCI card, big endian host
>> and there are also
>> * 16 bit
On Fri, 3 Mar 2017 17:43:49 -0600
Eric Blake wrote:
> On 03/03/2017 12:14 PM, Eric Blake wrote:
> > On 03/03/2017 11:25 AM, Greg Kurz wrote:
> >> We should pass O_NOFOLLOW otherwise openat() will follow symlinks and make
> >> QEMU vulnerable.
> >>
> >> O_PATH was used as an optimization: the fd
On Fri, 3 Mar 2017 12:28:01 -0600
Eric Blake wrote:
> On 03/03/2017 12:15 PM, Greg Kurz wrote:
>
> >
> > O_PATH | O_NOFOLLOW is a special case as described in the last paragraph
> > of O_PATH in the man page:
> >
> > If pathname is a symbolic link and the O_NOFOLLOW flag is
>
The name argument can never be an empty string, and dirfd always point to
the containing directory of the file name. AT_EMPTY_PATH is hence useless
here. Also it breaks build with glibc version 2.13 and older.
It is actually an oversight of a previous tentative patch to implement this
function. We
On Sat, 4 Mar 2017 11:21:28 +1100
Richard Henderson wrote:
> > Alessandro Di Federico (7):
> > Move *_cpu_dump_state to translate.c
> > *-user targets object files decoupling
> > Isolate coprocessor parts from target/arm/helper.c
>
> I have no idea what you're going for here. How does r
60 matches
Mail list logo
