Re: [Qemu-devel] [PATCH fixup 1/2] intel_iommu: use the correct memory region for device IOTLB notification

On Mon, Mar 20, 2017 at 11:36:38AM +0800, Jason Wang wrote: > We have a specific memory region for DMAR now, so it's wrong to > trigger the notifier with the root region. > > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Signed-off-by: Jason Wang

Re: [Qemu-devel] [PATCHv2 for-2.10 2/5] pseries: Implement HPT resizing

On Wed, Mar 15, 2017 at 12:44:18PM +0530, Bharata B Rao wrote: > On Tue, Mar 14, 2017 at 11:04 AM, David Gibson > wrote: > > > This patch implements hypercalls allowing a PAPR guest to resize its own > > hash page table. This will eventually allow for more flexible memory > > hotplug. > > > > Th

[Qemu-devel] [PATCH v2] ui/egl-helpers: fix egl 1.5 display init

Unfortunaly switching to getPlatformDisplayEXT isn't as easy as implemented by 0ea1523fb6703aa0dcd65e66b59e96fec028e60a. See the longish comment for the complete story. Cc: Frediano Ziglio Suggested-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- ui/egl-helpers.c | 58 +

[Qemu-devel] [PATCH v3]Fix Colo doc secondeary should be secondary

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang --- docs/COLO-FT.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index e

[Qemu-devel] [PULL for-2.9 0/3] fixes: vnc, cirrus, tcg display updates.

ository at: git://git.kraxel.org/qemu tags/pull-fixes-20170320-1 for you to fetch changes up to 7bc4f0846f5e15dad5a54490290241243b5a4416: vnc: fix a qio-channel leak (2017-03-20 09:07:34 +0100) fixes for 2.9: vnc, cirrus, t

[Qemu-devel] [PULL for-2.9 1/3] ui/console: ensure graphic updates don't race with TCG vCPUs

From: Alex Bennée Commit 8d04fb55.. tcg: drop global lock during TCG code execution ..broke the assumption that updates to the GUI couldn't happen at the same time as TCG vCPUs where running. As a result the TCG vCPU could still be updating a directly mapped frame-buffer while the display sid

[Qemu-devel] [PULL for-2.9 2/3] cirrus: fix off-by-one in cirrus_bitblt_rop_bkwd_transp_*_16

The switch from pointers to addresses (commit 026aeffcb4752054830ba203020ed6eb05bcaba8 and ffaf857778286ca54e3804432a2369a279e73aa7) added a off-by-one bug to 16bit backward blits. Fix. Reported-by: 李强 Signed-off-by: Gerd Hoffmann Reviewed-by: Li Qiang Message-id: 1489735296-19047-1-git-send-e

[Qemu-devel] [PULL for-2.9 3/3] vnc: fix a qio-channel leak

From: Marc-André Lureau Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrange Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170317092802.17973-1-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 1 + 1 file changed, 1 insertion(+) diff

[Qemu-devel] [PULL for-2.9 1/1] s390x/css: reassign subchannel if schid is changed after migration

From: Dong Jia Shi The subchannel is a means to access a device. While the device number is assigned by the administrator, the subchannel number is assigned by the channel subsystem in an ascending order on cold and hot plug. When doing unplug and replug operations, the same device may end up on

[Qemu-devel] [PULL for-2.9 0/1] s390x: one bugfix

The following changes since commit ebedf0f9cd46b617df331eecc857c379d574ac62: nios2: iic: Convert CPU prop to qom link (2017-03-18 18:22:54 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20170320 for you to fetch changes up to

[Qemu-devel] [PATCH] audio: catch missing sdl support

sdl is probed before audio, so we can simply look at $sdl so see whenever we have support or not. Throw an error in case sdl audio is requested without sdl being available. Reported-by: Peter Maydell Signed-off-by: Gerd Hoffmann --- configure | 10 -- 1 file changed, 8 insertions(+), 2

Re: [Qemu-devel] [PATCH fixup 2/2] vhost: genearlize iommu memory region

On Mon, Mar 20, 2017 at 11:36:39AM +0800, Jason Wang wrote: > We assumes the iommu_ops were attached to the root region of address > space. This may not true for all kinds of IOMMU implementation. So fix > this by not assume as->root has iommu_ops and: > > - register a memory listener to dma_as >

Re: [Qemu-devel] [PATCH] xen: use libxendevice model to restrict operations

> -Original Message- > From: Philippe Mathieu-Daudé [mailto:philippe.mathieu.da...@gmail.com] > On Behalf Of Philippe Mathieu-Daudé > Sent: 17 March 2017 21:21 > To: Paul Durrant ; qemu-devel@nongnu.org; xen- > de...@lists.xenproject.org > Cc: Anthony Perard ; Paolo Bonzini > ; Stefano Stab

[Qemu-devel] [PATCH 1/1] parallels: fix default options parsing

From: Edgar Kaziahmedov parallels block driver is completely broken since commit commit 75cdcd1553e74b5edc58aed23e3b2da8dabb1876 Author: Markus Armbruster Date: Tue Feb 21 21:14:08 2017 +0100 option: Fix checking of sizes for overflow and trailing crap Right now even simple

[Qemu-devel] ping Re: [PATCH 0/4] some migration bugs

06.03.2017 17:23, Denis V. Lunev wrote: On 02/25/2017 10:31 PM, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here are some migration related bugs, two about INACTIVE bdses and one use-after-free. I'm absolutely not sure, that these bugs should be fixed like I'm fixing, but problem definitely ex

Re: [Qemu-devel] [Bug 1217339] [PATCH v2] Unix signal to send ACPI-shutdown to Guest

On Sat, Mar 18, 2017 at 02:41:16PM +0100, Simon wrote: > Hi, > > The patch below adds the new command-line option `-powerdown' which > changes the behavior for both SIGHUP and SIGINT signals to cause a clean > power down of the guest using an ACPI shutdown request. If you need to add command line

[Qemu-devel] [PATCH] console: drop epoxy/gl.h include dependency

Use "unsigned int" instead of GLenum and GLuint, so we don't depend on these types from opengl headers. Drop all CONFIG_OPENGL #ifdefs from console.h Reported-by: Peter Maydell Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 14 +++--- 1 file changed, 3 insertions(+), 11 deleti

Re: [Qemu-devel] [PATCH] console: drop epoxy/gl.h include dependency

Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH] console: drop epoxy/gl.h include dependency Message-id: 1490003796-6261-1-git-send-email-kra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be inv

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 01/16] block: Add PreallocMode to BD.bdrv_truncate()

On Mon, Mar 13, 2017 at 10:39:46PM +0100, Max Reitz wrote: > Add a PreallocMode parameter to the bdrv_truncate() function implemented > by each block driver. Currently, we always pass PREALLOC_MODE_OFF and no > driver accepts anything else. > > Signed-off-by: Max Reitz > --- > include/block/bloc

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 12/16] block/qcow2: Extract qcow2_calc_size_usage()

On Mon, Mar 13, 2017 at 10:41:13PM +0100, Max Reitz wrote: > We will need very similar functionality for full/falloc preallocation in > qcow2_truncate(). Although we will not be able to reuse much of the > actual code, it still makes sense to keep all of this in one place. > > Signed-off-by: Max R

[Qemu-devel] [PATCH] hax: fix breakage in locking

use qemu_mutex_lock_iothread consistently in qemu_hax_cpu_thread_fn() as done in other _thread_fn functions, instead of grabbing directly the BQL. This way we ensure that iothread_locked is properly set. On v2.9.0-rc0, QEMU was dying in an assertion in the mutex code when running with '--enable-ha

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 01/16] block: Add PreallocMode to BD.bdrv_truncate()

On Mon, Mar 13, 2017 at 10:39:46PM +0100, Max Reitz wrote: > diff --git a/block/iscsi.c b/block/iscsi.c > index ab559a6f71..5d6265c4a6 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -2060,11 +2060,16 @@ static void iscsi_reopen_commit(BDRVReopenState > *reopen_state) > } > } > > -

[Qemu-devel] [PATCH v2] console: drop epoxy/gl.h include dependency

Use "unsigned int" instead of GLenum and GLuint, so we don't depend on these types from opengl headers. Drop all CONFIG_OPENGL #ifdefs from console.h Reported-by: Peter Maydell Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 14 +++--- include/ui/sdl2.h| 4 2 files ch

Re: [Qemu-devel] [PATCH v2] console: drop epoxy/gl.h include dependency

On 20 March 2017 at 10:20, Gerd Hoffmann wrote: > Use "unsigned int" instead of GLenum and GLuint, so we don't depend on > these types from opengl headers. Drop all CONFIG_OPENGL #ifdefs from > console.h > > Reported-by: Peter Maydell > Signed-off-by: Gerd Hoffmann > diff --git a/include/ui/sd

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 03/16] block: Add PreallocMode to blk_truncate()

On Mon, Mar 13, 2017 at 10:40:32PM +0100, Max Reitz wrote: > blk_truncate() itself will pass that value to bdrv_truncate(), and all > callers of blk_truncate() just set the parameter to PREALLOC_MODE_OFF > for now. > > Signed-off-by: Max Reitz > --- > include/sysemu/block-backend.h | 3 ++- > bl

Re: [Qemu-devel] [PATCH 1/4] arm: HVC and SMC encodings don't exist for M profile

Peter Maydell writes: > M profile doesn't have the HVC or SMC encodings, so make them always > UNDEF rather than generating calls to helper functions that assume > A/R profile. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > target/arm/translate.c | 3 +++ > 1 file changed

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 05/16] block/file-posix: Small fixes in raw_create()

On Mon, Mar 13, 2017 at 10:40:34PM +0100, Max Reitz wrote: > Variables should be declared at the start of a block, and if a certain > parameter value is not supported it may be better to return -ENOTSUP > instead of -EINVAL. > > Signed-off-by: Max Reitz > --- > block/file-posix.c | 5 +++-- > 1

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 06/16] block/file-posix: Extract raw_regular_truncate()

On Mon, Mar 13, 2017 at 10:40:35PM +0100, Max Reitz wrote: > This functionality is part of raw_create() which we will be able to > reuse nicely in raw_truncate(). > > Signed-off-by: Max Reitz > --- > block/file-posix.c | 144 > + > 1 file chan

Re: [Qemu-devel] [PATCH for-2.10 04/16] qemu-img: Expose PreallocMode for resizing

On Mon, Mar 13, 2017 at 10:40:33PM +0100, Max Reitz wrote: > @@ -3429,8 +3442,16 @@ static int img_resize(int argc, char **argv) > goto out; > } > > +current_size = blk_getlength(blk); > +if (current_size < 0) { > +error_report("Failed to inquire current image length

Re: [Qemu-devel] [PULL for-2.9 0/3] fixes: vnc, cirrus, tcg display updates.

-cirrus-20170316-1' > into staging (2017-03-16 16:40:44 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-fixes-20170320-1 > > for you to fetch changes up to 7bc4f0846f5e15dad5a54490290241243b5a44

Re: [Qemu-devel] [PATCH 2/4] arm: Don't decode MRS(banked) or MSR(banked) for M profile

Peter Maydell writes: > M profile doesn't have the MSR(banked) and MRS(banked) instructions > and uses the encodings for different kinds of M-profile MRS/MSR. > Guard the relevant bits of the decode logic to make sure we don't > accidentally fall into them by accident on M-profile. The ARMv7-A

Re: [Qemu-devel] [PATCH 3/4] arm: Enforce should-be-1 bits in MRS decoding

Peter Maydell writes: > The MRS instruction requires that bits [19..16] are all 1s, and for > A/R profile also that bits [7..0] are all 0s. At this point in the > decode tree we have checked all of the rest of the instruction but > were allowing these to be any value. If these bits are not set

Re: [Qemu-devel] [PATCH for-2.10 07/16] block/file-posix: Generalize raw_regular_truncate

On Mon, Mar 13, 2017 at 10:40:36PM +0100, Max Reitz wrote: > Currently, raw_regular_truncate() is intended for setting the size of a > newly created file. However, we also want to use it for truncating an > existing file in which case only the newly added space (when growing) > should be preallocat

Re: [Qemu-devel] [PATCH 4/4] arm: Fix APSR writes via M profile MSR

Peter Maydell writes: > Our implementation of writes to the APSR for M-profile via the MSR > instruction was badly broken. > > First and worst, we had the sense wrong on the test of bit 2 of the > SYSm field -- this is supposed to request an APSR write if bit 2 is 0 > but we were doing it if bit

Re: [Qemu-devel] [PATCH for-2.10 08/16] block/file-posix: Preallocation for truncate

On Mon, Mar 13, 2017 at 10:40:37PM +0100, Max Reitz wrote: > By using raw_regular_truncate() in raw_truncate(), we can now easily > support preallocation. > > Signed-off-by: Max Reitz > --- > block/file-posix.c | 22 ++ > 1 file changed, 10 insertions(+), 12 deletions(-) Rev

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 09/16] block/qcow2: Generalize preallocate()

On Mon, Mar 13, 2017 at 10:40:38PM +0100, Max Reitz wrote: > This patch adds two new parameters to the preallocate() function so we > will be able to use it not just for preallocating a new image but also > for preallocated image growth. > > The offset parameter allows the caller to specify a virt

Re: [Qemu-devel] [PATCH 2/4] arm: Don't decode MRS(banked) or MSR(banked) for M profile

On 20 March 2017 at 10:57, Alex Bennée wrote: > > Peter Maydell writes: > >> M profile doesn't have the MSR(banked) and MRS(banked) instructions >> and uses the encodings for different kinds of M-profile MRS/MSR. >> Guard the relevant bits of the decode logic to make sure we don't >> accidentally

Re: [Qemu-devel] [PATCH for-2.10 10/16] block/qcow2: Lock s->lock in preallocate()

On Mon, Mar 13, 2017 at 10:41:11PM +0100, Max Reitz wrote: > preallocate() is and will be called only from places that do not lock > s->lock: Currently that is qcow2_create2(), as of a future patch it will > be called from qcow2_truncate(), too. > > It therefore makes sense to move locking that mu

Re: [Qemu-devel] [PATCH v2] hw/arm/boot: take Linux/arm64 TEXT_OFFSET header field into account

On 13 March 2017 at 14:17, Ard Biesheuvel wrote: > The arm64 boot protocol stipulates that the kernel must be loaded > TEXT_OFFSET bytes beyond a 2 MB aligned base address, where TEXT_OFFSET > could be any 4 KB multiple between 0 and 2 MB, and whose value can be > found in the header of the Image

Re: [Qemu-devel] [PATCH v2] hw/arm/boot: take Linux/arm64 TEXT_OFFSET header field into account

On 20 March 2017 at 11:13, Peter Maydell wrote: > On 13 March 2017 at 14:17, Ard Biesheuvel wrote: >> The arm64 boot protocol stipulates that the kernel must be loaded >> TEXT_OFFSET bytes beyond a 2 MB aligned base address, where TEXT_OFFSET >> could be any 4 KB multiple between 0 and 2 MB, and

Re: [Qemu-devel] [PATCH 13/16] migration: Create thread infrastructure for multifd recv side

On 17/03/2017 20:36, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> On 17/03/2017 14:02, Dr. David Alan Gilbert wrote: > case RAM_SAVE_FLAG_MULTIFD_PAGE: > fd_num = qemu_get_be16(f); > -if (fd_num != 0) { > -

[Qemu-devel] KVM call minutes for 2017-03-14

Hi After a long while, we have had a kvm call. See the thread for the agenda for things that were discussed. My notes are a bit clear because I was also partipating. Please, reply with more things. - What to do with qemu to evolve? Making it more modular (seems to be a good idea) more con

[Qemu-devel] KVM call for 2016-03-28

Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [PULL 11/24] tcg: enable thread-per-vCPU

On 17/03/2017 21:43, Alex Bennée wrote: > There is currently cpu->running which is set/cleared by > cpu_exec_start/end. Although if we crash between cpu_exec_start and > sigsetjmp the same sort of brokenness might happen. I think cpu_exec_start/end should be moved into cpu_exec itself (but proba

Re: [Qemu-devel] callout to *file in bdrv_co_get_block_status

On 20/03/2017 03:46, Fam Zheng wrote: > On Fri, 03/17 12:20, Peter Lieven wrote: >> Am 17.03.2017 um 12:16 schrieb Paolo Bonzini: >>> >>> On 17/03/2017 12:11, Peter Lieven wrote: >> like VMDK or QCOW2 shouldn't we trust the information from the l2 tables >> in the VMDK or QCOW2? > It

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 11/16] block/qcow2: Metadata preallocation for truncate

On Mon, Mar 13, 2017 at 10:41:12PM +0100, Max Reitz wrote: > We can support PREALLOC_MODE_METADATA by invoking preallocate() in > qcow2_truncate(). > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 24 ++-- > 1 file changed, 22 insertions(+), 2 deletions(-) Reviewed-by: S

[Qemu-devel] [PATCH] numa, spapr: align default numa node memory size to 256MB

Since commit 224245b ("spapr: Add LMB DR connectors"), NUMA node memory size must be aligned to 256MB (SPAPR_MEMORY_BLOCK_SIZE). But when "-numa" option is provided without "mem" parameter, the memory is equally divided between nodes, but 8MB aligned. This can be not valid for pseries. In that ca

Re: [Qemu-devel] [PULL for-2.9 0/1] s390x: one bugfix

ohuck/qemu tags/s390x-20170320 > > for you to fetch changes up to 3c788ebc6f6eef5ac6e9cb4a28c578abcf08247d: > > s390x/css: reassign subchannel if schid is changed after migration > (2017-03-20 09:22:57 +0100) > > --

[Qemu-devel] [PATCH v3] console: drop epoxy/gl.h include dependency

Use "unsigned int" instead of GLenum and GLuint, so we don't depend on these types from opengl headers. Drop all CONFIG_OPENGL #ifdefs from console.h Reported-by: Peter Maydell Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 14 +++--- include/ui/sdl2.h| 4 ui/sdl2-gl

Re: [Qemu-devel] [PATCH for-2.10 13/16] block/qcow2: qcow2_calc_size_usage() for truncate

On Mon, Mar 13, 2017 at 10:41:14PM +0100, Max Reitz wrote: > This patch extends qcow2_calc_size_usage() so it can calculate the > additional space needed for preallocating image growth. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 137 > +-

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 14/16] block/qcow2: falloc/full preallocating growth

On Mon, Mar 13, 2017 at 10:41:15PM +0100, Max Reitz wrote: > Implement the preallocation modes falloc and full for growing qcow2 > images. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 36 +++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff --g

Re: [Qemu-devel] [PATCH] numa, spapr: align default numa node memory size to 256MB

On Mon, Mar 20, 2017 at 12:24:26PM +0100, Laurent Vivier wrote: > Since commit 224245b ("spapr: Add LMB DR connectors"), NUMA node > memory size must be aligned to 256MB (SPAPR_MEMORY_BLOCK_SIZE). That commit only enabled the feature for the pseries-2.5 machine type several releases back now... >

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 15/16] iotests: Add preallocated resize test for raw

On Mon, Mar 13, 2017 at 10:41:16PM +0100, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/106 | 92 > ++ > tests/qemu-iotests/106.out | 50 + > tests/qemu-iotests/group | 1 + > 3 files changed, 143

Re: [Qemu-devel] [PATCH] numa, spapr: align default numa node memory size to 256MB

On 20.03.2017 12:24, Laurent Vivier wrote: > Since commit 224245b ("spapr: Add LMB DR connectors"), NUMA node > memory size must be aligned to 256MB (SPAPR_MEMORY_BLOCK_SIZE). > > But when "-numa" option is provided without "mem" parameter, > the memory is equally divided between nodes, but 8MB al

Re: [Qemu-devel] [PATCH for-2.10 16/16] iotests: Add preallocated growth test for qcow2

On Mon, Mar 13, 2017 at 10:41:17PM +0100, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/125 | 130 +++ > tests/qemu-iotests/125.out | 386 > + > tests/qemu-iotests/group | 1 + > 3 files changed, 517 inserti

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 02/16] block: Add PreallocMode to bdrv_truncate()

On Mon, Mar 13, 2017 at 10:40:18PM +0100, Max Reitz wrote: > For block drivers that just pass a truncate request to the underlying > protocol, we can now pass the preallocation mode instead of aborting if > it is not PREALLOC_MODE_OFF. > > Signed-off-by: Max Reitz > --- > include/block/block.h

[Qemu-devel] [PATCH] linux-user: remove all traces of qemu from /proc/self/cmdline

Instead of post-processing the real contents use the remembered target argv. That removes all traces of qemu, including command line options, and handles QEMU_ARGV0. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 47 +++ 1 file changed, 7 in

Re: [Qemu-devel] [PATCH] numa, spapr: align default numa node memory size to 256MB

On 20/03/2017 12:30, Daniel P. Berrange wrote: > On Mon, Mar 20, 2017 at 12:24:26PM +0100, Laurent Vivier wrote: >> Since commit 224245b ("spapr: Add LMB DR connectors"), NUMA node >> memory size must be aligned to 256MB (SPAPR_MEMORY_BLOCK_SIZE). > > That commit only enabled the feature for the p

Re: [Qemu-devel] [RFC PATCH 0/4] Qemu: Add Xen vIOMMU support

On 20/03/2017 03:40, Lan Tianyu wrote: >>> Xen only supports emulated I440 and so we enable vIOMMU with emulated >>> I440 chipset. This works on Linux and Windows guest. >> Any plans to change this? Why is Xen not able to use Q35 with Intel >> IOMMU, with only special hooks for interrupt remappi

Re: [Qemu-devel] [PATCH] hax: fix breakage in locking

On 20/03/2017 11:15, Vincent Palatin wrote: > use qemu_mutex_lock_iothread consistently in qemu_hax_cpu_thread_fn() as > done in other _thread_fn functions, instead of grabbing directly the > BQL. This way we ensure that iothread_locked is properly set. > > On v2.9.0-rc0, QEMU was dying in an as

Re: [Qemu-devel] [PULL 11/24] tcg: enable thread-per-vCPU

Paolo Bonzini writes: > On 17/03/2017 21:43, Alex Bennée wrote: >> There is currently cpu->running which is set/cleared by >> cpu_exec_start/end. Although if we crash between cpu_exec_start and >> sigsetjmp the same sort of brokenness might happen. > > I think cpu_exec_start/end should be moved

Re: [Qemu-devel] callout to *file in bdrv_co_get_block_status

On Mon, 03/20 12:21, Paolo Bonzini wrote: > > > On 20/03/2017 03:46, Fam Zheng wrote: > > On Fri, 03/17 12:20, Peter Lieven wrote: > >> Am 17.03.2017 um 12:16 schrieb Paolo Bonzini: > >>> > >>> On 17/03/2017 12:11, Peter Lieven wrote: > >> like VMDK or QCOW2 shouldn't we trust the information

Re: [Qemu-devel] [PATCH] numa, spapr: align default numa node memory size to 256MB

On 20/03/2017 12:31, Thomas Huth wrote: > On 20.03.2017 12:24, Laurent Vivier wrote: >> Since commit 224245b ("spapr: Add LMB DR connectors"), NUMA node >> memory size must be aligned to 256MB (SPAPR_MEMORY_BLOCK_SIZE). >> >> But when "-numa" option is provided without "mem" parameter, >> the memor

[Qemu-devel] [PATCH v3]COLO:Fix Colo doc, secondeary should be secondary

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang --- docs/COLO-FT.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt

[Qemu-devel] [PATCH 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.9 machine types

The WRITE_POINTER linker/loader command that underlies VMGENID depends on commit baf2d5bfbac0 ("fw-cfg: support writeable blobs", 2017-01-12). That commit is not available in 2.8. Cc: "Michael S. Tsirkin" Cc: Ben Warren Cc: Igor Mammedov Signed-off-by: Laszlo Ersek --- include/hw/acpi/vmgenid

[Qemu-devel] [PATCH 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device

Multiple instances make no sense. Cc: "Michael S. Tsirkin" Cc: Ben Warren Cc: Igor Mammedov Signed-off-by: Laszlo Ersek --- hw/acpi/vmgenid.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c index c3ddcc8e7cb0..b5c0dfcf19e1 100644 --- a/hw/

[Qemu-devel] [PATCH 0/2] some remaining vmgenid tweaks for 2.9

We've discussed both of these earlier (multiple times), and I'd been hoping that Ben would submit them. I guess I can send out a reminder formatted as a patch series. (I don't intend to post several iterations of this.) Cc: "Michael S. Tsirkin" Cc: Ben Warren Cc: Igor Mammedov Thanks Laszlo L

Re: [Qemu-devel] [PATCH 1/2] acpi_piix4: fix migration of gpe fields

Hello Marcelo, cc:qemu, Sorry for re-using this old thread, but I have a problem loading some saved state from qemu-kvm-1.1.2, which fails for piix4_pm. You following patch was committed as : Am 15.1

Re: [Qemu-devel] qemu-ga static compilation

ping. On Tue, Mar 14, 2017 at 6:51 PM, Sameeh Jubran wrote: > Hi all, > > I am trying to compile qemu-ga for Windows statically using the following > commands: > > ./configure --disable-docs --target-list=x86_64-softmmu > --cross-prefix=x86_64-w64-mingw32- --static --enable-guest-agent-msi > --w

Re: [Qemu-devel] [PATCH v3] console: drop epoxy/gl.h include dependency

On 20 March 2017 at 11:24, Gerd Hoffmann wrote: > Use "unsigned int" instead of GLenum and GLuint, so we don't depend on > these types from opengl headers. Drop all CONFIG_OPENGL #ifdefs from > console.h > > Reported-by: Peter Maydell > Signed-off-by: Gerd Hoffmann This isn't sufficient to fix

Re: [Qemu-devel] qemu-ga static compilation

On 14 March 2017 at 16:51, Sameeh Jubran wrote: > Hi all, > > I am trying to compile qemu-ga for Windows statically using the following > commands: > > ./configure --disable-docs --target-list=x86_64-softmmu > --cross-prefix=x86_64-w64-mingw32- --static --enable-guest-agent-msi > --with-vss-sdk=/p

Re: [Qemu-devel] callout to *file in bdrv_co_get_block_status

Am 20.03.2017 um 12:49 schrieb Fam Zheng: > On Mon, 03/20 12:21, Paolo Bonzini wrote: >> >> On 20/03/2017 03:46, Fam Zheng wrote: >>> On Fri, 03/17 12:20, Peter Lieven wrote: Am 17.03.2017 um 12:16 schrieb Paolo Bonzini: > On 17/03/2017 12:11, Peter Lieven wrote: like VMDK or QCOW

Re: [Qemu-devel] [PATCH] vfio pci: kernel support of error recovery only for non fatal error

Sorry for late. On 03/14/2017 06:06 AM, Alex Williamson wrote: > On Mon, 27 Feb 2017 15:28:43 +0800 > Cao jin wrote: > >> 0. What happens now (PCIE AER only) >>Fatal errors cause a link reset. >>Non fatal errors don't. >>All errors stop the VM eventually, but not immediately >>be

Re: [Qemu-devel] callout to *file in bdrv_co_get_block_status

Am 20.03.2017 um 12:49 schrieb Fam Zheng: > On Mon, 03/20 12:21, Paolo Bonzini wrote: >> >> On 20/03/2017 03:46, Fam Zheng wrote: >>> On Fri, 03/17 12:20, Peter Lieven wrote: Am 17.03.2017 um 12:16 schrieb Paolo Bonzini: > On 17/03/2017 12:11, Peter Lieven wrote: like VMDK or QCOW

[Qemu-devel] [PULL 2/4] arm: Don't decode MRS(banked) or MSR(banked) for M profile

M profile doesn't have the MSR(banked) and MRS(banked) instructions and uses the encodings for different kinds of M-profile MRS/MSR. Guard the relevant bits of the decode logic to make sure we don't accidentally fall into them by accident on M-profile. (The bit being checked for this (bit 5) is pa

[Qemu-devel] [PULL 4/4] arm: Fix APSR writes via M profile MSR

Our implementation of writes to the APSR for M-profile via the MSR instruction was badly broken. First and worst, we had the sense wrong on the test of bit 2 of the SYSm field -- this is supposed to request an APSR write if bit 2 is 0 but we were doing it if bit 2 was 1. This bug was introduced i

[Qemu-devel] [PULL for-2.9 0/4] target-arm queue

'remotes/cohuck/tags/s390x-20170320' into staging (2017-03-20 10:51:30 +) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20170320 for you to fetch changes up to b28b3377d7e9ba35611d454d5a63ef50cab1f8c5: arm

[Qemu-devel] [PATCH for-2.9 4/5] keyval: Document issues with 'any' and alternate types

Signed-off-by: Markus Armbruster --- util/keyval.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/util/keyval.c b/util/keyval.c index 46cd540..93d5db6 100644 --- a/util/keyval.c +++ b/util/keyval.c @@ -61,6 +61,16 @@ * "key absent" already means "optional object/array absent",

[Qemu-devel] [PULL 1/4] arm: HVC and SMC encodings don't exist for M profile

M profile doesn't have the HVC or SMC encodings, so make them always UNDEF rather than generating calls to helper functions that assume A/R profile. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Message-id: 1487616072-9226-2-git-send-email-peter.mayd...@linaro.org --- target/arm/transla

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Fri, Mar 17, 2017 at 06:44:56PM -0700, ashish mittal wrote: > On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal wrote: > > On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange > > wrote: > >> On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: > >>> Thanks! There is one more input I ne

[Qemu-devel] [PATCH for-2.9 1/5] test-keyval: Tweaks to improve list coverage

We have a negative test case for a list index with leading zero. Add positive ones. Tweak the test case for list index greater or equal the number of elements: test "equal" instead of "greater" to guard against off-by-one mistakes. Signed-off-by: Markus Armbruster --- tests/test-keyval.c | 6 +

[Qemu-devel] [PULL 3/4] arm: Enforce should-be-1 bits in MRS decoding

The MRS instruction requires that bits [19..16] are all 1s, and for A/R profile also that bits [7..0] are all 0s. At this point in the decode tree we have checked all of the rest of the instruction but were allowing these to be any value. If these bits are not set then the result is architectural

[Qemu-devel] [PATCH for-2.9 5/5] MAINTAINERS: Add myself for files I touched recently

Signed-off-by: Markus Armbruster --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bf1aafb..3f20288 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1218,6 +1218,15 @@ M: Samuel Thibault S: Maintained F: backends/baum.c +Command li

[Qemu-devel] [PATCH for-2.9 0/5] keyval: Doc improvements and additional tests

These are basically leftovers from review of "block: Command line option -blockdev". Non-test code is unchanged. Nice to have in 2.9. Markus Armbruster (5): test-keyval: Tweaks to improve list coverage keyval: Improve some comments test-keyval: Cover alternate and 'any' type keyval: Docu

[Qemu-devel] [PATCH for-2.9 3/5] test-keyval: Cover alternate and 'any' type

Signed-off-by: Markus Armbruster --- tests/Makefile.include | 2 +- tests/test-keyval.c| 53 ++ 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 402e71c..86f9490 100644 --- a/t

[Qemu-devel] [PULL for v2.9 07/10] dma: rc4030: limit interval timer reload value

From: Prasad J Pandit The JAZZ RC4030 chipset emulator has a periodic timer and associated interval reload register. The reload value is used as divider when computing timer's next tick value. If reload value is large, it could lead to divide by zero error. Limit the interval reload value to avoi

[Qemu-devel] [PULL for v2.9 03/10] target-mips: log bad coprocessor0 register accesses with LOG_UNIMP

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Yongbok Kim Signed-off-by: Yongbok Kim --- target/mips/translate.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 1fe0ff3..

[Qemu-devel] [PULL for v2.9 02/10] target-mips: remove old & unuseful comments

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Yongbok Kim Signed-off-by: Yongbok Kim --- target/mips/translate.c | 4 1 file changed, 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 8b4a072..1fe0ff3 100644 --- a/targe

[Qemu-devel] [PATCH for-2.9 2/5] keyval: Improve some comments

Signed-off-by: Markus Armbruster --- util/keyval.c | 47 +++ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/util/keyval.c b/util/keyval.c index f646b36..46cd540 100644 --- a/util/keyval.c +++ b/util/keyval.c @@ -21,22 +21,36 @@ * *

[Qemu-devel] [PULL for v2.9 00/10] target-mips queue

The following changes since commit bedf13ecab38bcd479e9db6994ebc3b2c5c7a3ae: Merge remote-tracking branch 'remotes/kraxel/tags/pull-fixes-20170320-1' into staging (2017-03-20 10:05:45 +) are available in the git repository at: git://github.com/yongbok/upstream-qemu.git

[Qemu-devel] [PULL for v2.9 05/10] target-mips: replace few LOG_DISAS() with trace points

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Yongbok Kim Signed-off-by: Yongbok Kim --- Makefile.objs| 1 + target/mips/trace-events | 5 + target/mips/translate.c | 25 +++-- 3 files changed, 17 insertions(+), 14 delet

[Qemu-devel] [PULL for v2.9 04/10] target-mips: replace break by goto cp0_unimplemented

From: Philippe Mathieu-Daudé this fixes many warnings like: target/mips/translate.c:6253:13: warning: Value stored to 'rn' is never read rn = "invalid sel"; ^~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Yongbok

[Qemu-devel] [PULL for v2.9 06/10] target/mips: fix delay slot detection in gen_msa_branch()

It is unnecessary to test R6 from delay/forbidden slot check in gen_msa_branch(). https://bugs.launchpad.net/qemu/+bug/1663287 Reported-by: Brian Campbell Signed-off-by: Yongbok Kim --- target/mips/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/tran

[Qemu-devel] [PULL for v2.9 01/10] target-mips: fix compiler warnings (clang 5)

From: Philippe Mathieu-Daudé static code analyzer complain: target/mips/helper.c:453:5: warning: Function call argument is an uninitialized value qemu_log_mask(CPU_LOG_MMU, ^~ 'physical' and 'prot' are uninitialized if 'ret' is not TLBRET_MATCH. Reported-by: Cl

[Qemu-devel] [PULL for v2.9 08/10] dma/rc4030: translate memory accesses only when they occur

From: Hervé Poussineau This simplifies the code a lot, and this fixes big memory leaks introduced in a3d586f704609a45b6037534cb2f34da5dfd8895 Windows NT is now able to boot without using gigabytes of ram on the host. Signed-off-by: Hervé Poussineau Reviewed-by: Yongbok Kim Signed-off-by: Yong

[Qemu-devel] [PULL for v2.9 09/10] dma/rc4030: fix a mixed declarations and code warning

Signed-off-by: Yongbok Kim Reviewed-by: Hervé Poussineau --- hw/dma/rc4030.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c index 5f10b9d..0080141 100644 --- a/hw/dma/rc4030.c +++ b/hw/dma/rc4030.c @@ -99,8 +99,8 @@ typedef struct rc4030Stat

[Qemu-devel] [PULL for v2.9 10/10] MAINTAINERS: update for MIPS devices

Add myself to MIPSSIM and new entry for Fulong 2E. Add an entry for Boston machine (Paul Burton). cc: Paul Burton Signed-off-by: Yongbok Kim Reviewed-by: Thomas Huth --- MAINTAINERS | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[Qemu-devel] [PATCH for-2.9 0/6] qapi: Small qapi2texi fixes and addition tests

Code changes only in QAPI generator scripts and tests. Generated code is identical. Generated documentation is improved slightly. Markus Armbruster (6): qapi: Drop excessive Make dependencies on qapi2texi.py qapi2texi: Fix to actually fail when 'doc-required' is false qapi: Drop unused QAP

[Qemu-devel] [PATCH for-2.9 4/6] tests/qapi-schema: Make test-qapi.py print docs again

test-qapi.py used to print the internal representation of doc comments (commit 3313b61). This went away when we dropped the doc comments in positive tests (commit 87c16dc). Bring it back, because I'm going to add real positive doc comment tests. Signed-off-by: Markus Armbruster --- tests/qapi-

[Qemu-devel] [PATCH for-2.9 3/6] qapi: Drop unused QAPIDoc member optional

Unused since commit aa964b7 "qapi2texi: Convert to QAPISchemaVisitor" Signed-off-by: Markus Armbruster --- scripts/qapi.py | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index e88c047..6c4d554 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -106,7 +106

  1   2   3   4   >