Re: [Qemu-devel] [Qemu-ppc] Bug in qemu-system-ppc in Windows using the SDL2 GUI

Hi Thomas, i had been patched the qemu 2.8.91 on the git repository too and the patch gave positive result. i have no more the exit of qemu when a key was pressed . Thanks Luigi Da: Thomas Huth Inviato: venerdì 24 marzo 2017 10.33 A: Mark

Re: [Qemu-devel] [[RFC]PATCH:hw/sd:sd_init()] hw/sd : modified the sd_init() function

On Mon, Mar 27, 2017 at 4:43 PM, Stefan Hajnoczi wrote: > On Mon, Mar 27, 2017 at 04:01:02PM +0530, Tejaswini wrote: > > From: Tejaswini Poluri > > Please shorten the subject line: "[PATCH] hw/sd: simplify sd_init() > prototype" > > > @@ -573,16

Re: [Qemu-devel] [PATCH v2] qemu-ga: add guest-get-osinfo command

> On Mar 24, 2017, at 10:48 AM, Vinzenz Feenstra wrote: > >> >> On Mar 23, 2017, at 3:58 PM, Eric Blake > > wrote: >> >> On 03/16/2017 09:50 AM, Vinzenz 'evilissimo' Feenstra wrote: >>> From: Vinzenz Feenstra

Re: [Qemu-devel] [PATCH for-2.10 17/23] numa: remove no longer used numa_get_node_for_cpu()

On Wed, Mar 22, 2017 at 02:32:42PM +0100, Igor Mammedov wrote: > it's been replaced by fetching mapping info from possible_cpus > > Signed-off-by: Igor Mammedov Reviewed-by: David Gibson > --- > include/sysemu/numa.h | 4 > numa.c

Re: [Qemu-devel] [PATCH for-2.10 10/23] numa: mirror cpu to node mapping in MachineState::possible_cpus

On Wed, Mar 22, 2017 at 02:32:35PM +0100, Igor Mammedov wrote: > Introduce machine_set_cpu_numa_node() helper that stores > node mapping for CPU in MachineState::possible_cpus. > CPU and node it belongs to is specified by 'props' argument. > > Patch doesn't remove old way of storing mapping in >

Re: [Qemu-devel] [PATCH for-2.10 18/23] numa: remove no longer need numa_post_machine_init()

On Wed, Mar 22, 2017 at 02:32:43PM +0100, Igor Mammedov wrote: > CPUState::numa_node is still in use but now it's set by > board when it creates CPU objects. So there isn't any > need to set it again after all CPU's are created, > since it's been already set. > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH for-2.10 11/23] numa: do default mapping based on possible_cpus instead of node_cpu bitmaps

On Wed, Mar 22, 2017 at 02:32:36PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: David Gibson > --- > numa.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/numa.c

[Qemu-devel] [Bug 1256548] Re: qemu windows guest issues

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1256548 Title: qemu

[Qemu-devel] [Bug 1258626] Re: Curses Keyboard Broken On OS X

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1258626 Title: Curses

Re: [Qemu-devel] [PATCH for-2.10 05/23] numa: move source of default CPUs to NUMA node mapping into boards

On Wed, Mar 22, 2017 at 02:32:30PM +0100, Igor Mammedov wrote: > Originally CPU threads were by default assigned in > round-robin fashion. However it was causing issues in > guest since CPU threads from the same socket/core could > be placed on different NUMA nodes. > Commit fb43b73b (pc: fix

Re: [Qemu-devel] [PATCH for-2.10 06/23] spapr: add node-id property to sPAPR core

On Wed, Mar 22, 2017 at 02:32:31PM +0100, Igor Mammedov wrote: > it will allow switching from cpu_index to core based numa > mapping in follow up patches. > > Signed-off-by: Igor Mammedov Reviewed-by: David Gibson > --- >

Re: [Qemu-devel] [PATCH qemu] target-ppc/kvm: Enable in-kernel TCE acceleration for multi-tce

On Mon, Mar 27, 2017 at 04:22:19PM +1100, Alexey Kardashevskiy wrote: > This enables in-kernel handling of H_PUT_TCE_INDIRECT and > H_STUFF_TCE hypercalls. The host kernel support is there since v4.6, > in particular d3695aa4f452 > ("KVM: PPC: Add support for multiple-TCE hcalls"). > > H_PUT_TCE

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret

On Mon, Mar 27, 2017 at 10:32:40PM -0400, Jeff Cody wrote: > On Mon, Mar 27, 2017 at 03:26:33PM +0200, Markus Armbruster wrote: > > This reverts a part of commit 8a47e8e. We're having second thoughts > > on the QAPI schema (and thus the external interface), and haven't > > reached consensus, yet.

Re: [Qemu-devel] GSoC 2017 Proposal: TCG performance enhancements

On Mon, Mar 27, 2017 at 11:03 PM, Pranith Kumar wrote: > > If you think the project makes sense, I will add it to the GSoC wiki > so that others can also apply for it. Please let me know if you are > interested in mentoring it along with Alex. > One other thing is if you

Re: [Qemu-devel] GSoC 2017 Proposal: TCG performance enhancements

Hi Paolo, On Mon, Mar 27, 2017 at 7:32 AM, Paolo Bonzini wrote: > > > On 25/03/2017 17:52, Pranith Kumar wrote: >> * Implement an LRU translation block code cache. >> >> In the current TCG design, when the translation cache fills up, we flush >> all >> the translated

Re: [Qemu-devel] GSoC 2017 Proposal: TCG performance enhancements

Hi Richard, Thanks for the feedback. Please find some comments inline. On Mon, Mar 27, 2017 at 6:57 AM, Richard Henderson wrote: > > 128MB is really quite large. I doubt doubling the cache size will really > help that much. That said, it's really quite trivial to make this

Re: [Qemu-devel] [PATCH qemu] pci: Add missing drop of bus master AS reference

On Tue, Mar 28, 2017 at 05:33:48AM +0300, Michael S. Tsirkin wrote: > On Tue, Mar 28, 2017 at 11:06:28AM +1100, David Gibson wrote: > > On Mon, Mar 27, 2017 at 05:28:17PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 27/03/2017 06:40, Alexey Kardashevskiy wrote: > > > > The recent

Re: [Qemu-devel] [PATCH qemu] pci: Add missing drop of bus master AS reference

On Tue, Mar 28, 2017 at 11:06:28AM +1100, David Gibson wrote: > On Mon, Mar 27, 2017 at 05:28:17PM +0200, Paolo Bonzini wrote: > > > > > > On 27/03/2017 06:40, Alexey Kardashevskiy wrote: > > > The recent introduction of a bus master container added > > > memory_region_add_subregion() into the

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret

On Mon, Mar 27, 2017 at 03:26:33PM +0200, Markus Armbruster wrote: > This reverts a part of commit 8a47e8e. We're having second thoughts > on the QAPI schema (and thus the external interface), and haven't > reached consensus, yet. Issues include: > > * BlockdevOptionsRbd member @password-secret

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 08/11] rbd: Revert -blockdev and -drive parameter auth-supported

On Mon, Mar 27, 2017 at 03:26:32PM +0200, Markus Armbruster wrote: > This reverts half of commit 0a55679. We're having second thoughts on > the QAPI schema (and thus the external interface), and haven't reached > consensus, yet. Issues include: > > * The implementation uses deprecated

[Qemu-devel] [RFC for-2.10 3/3] pseries: Allow PCIe virtio and XHCI on pseries machine type

pseries now allows PCIe devices (both emulated and VFIO), although its PCI bus is in most respects a plain PCI bus - this uses paravirtualized access methods to PCIe extended config space defined in the PAPR spec. However, because the bus is not PCIe, it means that virtio-pci and XHCI devices

[Qemu-devel] [RFC for-2.10 2/3] pci: Allow host bridges to override PCI/PCIe hybrid device behaviour

Currently PCI/PCIe hybrid devices - that is, devices which can appear as either plain PCI or PCIe depending on where they're attached - will only appear in PCIe mode if they're attached to a PCIe bus via a root port or downstream port. This is correct for "standard" PCIe setups, but there are

[Qemu-devel] [RFC for-2.10 0/3] Rework handling of PCI/PCIe "hybrid" devices

A couple of devices - virtio-pci and XHCI - can present themselves to the guest as either PCI or PCIe devices depending on how they're attached. However, the logic is a little different between the two devices. In addition the logic in virtio makes it difficult to put a PCIe virtio device into a

[Qemu-devel] [RFC for-2.10 1/3] pci/pcie: Make a consistent helper for switching PCI/PCIe "hybrid" devices

virtio-pci and XHCI are "hybrid" devices in the sense that they can present themselves as either PCIe or plain PCI devices depending on the machine and bus they're connected to. For virtio-pci to present as PCIe it requires that it's connected to a PCIe bus and that it's not a root bus - this is

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 06/11] rbd: Clean up runtime_opts, fix -drive to reject filename

On Mon, Mar 27, 2017 at 03:26:30PM +0200, Markus Armbruster wrote: > runtime_opts is used for three different purposes: > > * qemu_rbd_open() uses it to accept options it recognizes, such as > "pool" and "image". Other .bdrv_open() methods do it similarly. > > * qemu_rbd_open() accepts

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 05/11] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=...

On Mon, Mar 27, 2017 at 03:26:29PM +0200, Markus Armbruster wrote: > The way we communicate extra key-value pairs from > qemu_rbd_parse_filename() to qemu_rbd_open() exposes option parameter > "keyvalue-pairs" on the command line. It's not wanted there. Hack: > rename the parameter to

Re: [Qemu-devel] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver

> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Tuesday, March 28, 2017 4:20 AM > To: Liu, Changpeng > Cc: virtio-...@lists.oasis-open.org; > virtualizat...@lists.linux-foundation.org; linux- > ker...@vger.kernel.org;

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 04/11] rbd: Clean up after the previous commit

On Mon, Mar 27, 2017 at 03:26:28PM +0200, Markus Armbruster wrote: > This code in qemu_rbd_parse_filename() > > found_str = qemu_rbd_next_tok(p, '\0', ); > p = found_str; > > has no effect. Drop it, and simplify qemu_rbd_next_tok(). > > Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 03/11] rbd: Don't limit length of parameter values

On Mon, Mar 27, 2017 at 03:26:27PM +0200, Markus Armbruster wrote: > We laboriously enforce parameter values are between one and some s/are/that are/ or maybe just s/are// > arbitrary limit in length. Only RBD_MAX_IMAGE_NAME_SIZE comes from > librbd.h, and I'm not sure it applies. Where the

Re: [Qemu-devel] [virtio-dev] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver

> -Original Message- > From: virtio-...@lists.oasis-open.org > [mailto:virtio-...@lists.oasis-open.org] On > Behalf Of Paolo Bonzini > Sent: Monday, March 27, 2017 7:34 PM > To: Liu, Changpeng ; virtio-...@lists.oasis-open.org; >

Re: [Qemu-devel] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver

> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Monday, March 27, 2017 10:56 PM > To: Liu, Changpeng > Cc: virtio-...@lists.oasis-open.org; > virtualizat...@lists.linux-foundation.org; linux- > ker...@vger.kernel.org; h...@lst.de;

Re: [Qemu-devel] [PATCH v2] KVM: pci-assign: do not map smm memory slot pages

From 8f5b9d2c2944ea7cd8149e9d3b4088f487217d20 Mon Sep 17 00:00:00 2001 From: herongguang Date: Mon, 27 Mar 2017 15:08:59 +0800 Subject: [PATCH] KVM: pci-assign: do not map smm memory slot pages in vt-d page table or VM memory are not put thus leaked in

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi wrote: > On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: > > Have you tested live migration? > > If live migration is not supported then a migration blocker should be > added using migrate_add_blocker(). > We do

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

On Tue, Mar 28, 2017 at 12:19:37AM +0200, Alexander Graf wrote: > KVM has a feature bitmap of CPUID bits that it knows works for guests. > QEMU removes bits that are not part of that bitmap automatically on VM > start. > > However, some times we just don't list features in that list because >

Re: [Qemu-devel] [PATCH qemu] pci: Add missing drop of bus master AS reference

On Mon, Mar 27, 2017 at 05:28:17PM +0200, Paolo Bonzini wrote: > > > On 27/03/2017 06:40, Alexey Kardashevskiy wrote: > > The recent introduction of a bus master container added > > memory_region_add_subregion() into the PCI device registering path but > > missed memory_region_del_subregion() in

Re: [Qemu-devel] [PATCH] trace: fix tcg tracing build breakage

On Mon, Mar 27, 2017 at 14:17:18 +0100, Stefan Hajnoczi wrote: > Commit 0ab8ed18a6fe98bfc82705b0f041fbf2a8ca5b60 ("trace: switch to > modular code generation for sub-directories") forgot to convert "tcg" > trace events to the modular code generation approach where each > sub-directory has its own

Re: [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen

On Mon, 27 Mar 2017, Juergen Gross wrote: > On 24/03/17 18:37, Stefano Stabellini wrote: > > On Fri, 24 Mar 2017, Juergen Gross wrote: > >> On 23/03/17 19:22, Stefano Stabellini wrote: > >>> On Thu, 23 Mar 2017, Paolo Bonzini wrote: > On 23/03/2017 14:55, Juergen Gross wrote: > > On

[Qemu-devel] [PATCH] i386: Allow cpuid bit override

KVM has a feature bitmap of CPUID bits that it knows works for guests. QEMU removes bits that are not part of that bitmap automatically on VM start. However, some times we just don't list features in that list because they don't make sense for normal scenarios, but may be useful in specific,

Re: [Qemu-devel] packed structures and unaligned accesses (sparc)

On 03/27/2017 07:34 PM, Peter Maydell wrote: > That all makes sense in isolation, but shouldn't something have > at least warned that "" isn't actually a uint32_t* in > the sense of being something you can validly pass to a > function that takes a uint32_t* ? This seems to be related to this gcc

Re: [Qemu-devel] packed structures and unaligned accesses (sparc)

On 03/28/2017 03:34 AM, Peter Maydell wrote: That all makes sense in isolation, but shouldn't something have at least warned that "" isn't actually a uint32_t* in the sense of being something you can validly pass to a function that takes a uint32_t* ? That's a long-known bug in the

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image

On Mon, Mar 27, 2017 at 03:26:26PM +0200, Markus Armbruster wrote: > qemu_rbd_open() neglects to check pool and image are present. > Reproducer: > > $ qemu-system-x86_64 -nodefaults -drive if=none,driver=rbd,pool=p > Segmentation fault (core dumped) This reproducer is wrong, I think.

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image

On Mon, Mar 27, 2017 at 08:58:28PM +0200, Markus Armbruster wrote: > Markus Armbruster writes: > > > Max Reitz writes: > > > >> On 27.03.2017 18:10, Max Reitz wrote: > >>> On 27.03.2017 15:26, Markus Armbruster wrote: > qemu_rbd_open() neglects to

Re: [Qemu-devel] slirp + ipxe + ipv6 dns issue

On 03/26/2017 02:39 PM, Samuel Thibault wrote: > Hello, > > Cole Robinson, on ven. 24 mars 2017 21:17:43 -0400, wrote: >> I bisected to this commit: >> >> slirp: Add RDNSS advertisement > > Mmm, I see. Could you try the attached patch to confirm that it fixes > the issue for you too? > I

Re: [Qemu-devel] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver

On Tue, Mar 28, 2017 at 04:39:25PM +0800, Changpeng Liu wrote: > Currently virtio-blk driver does not provide discard feature flag, so the > filesystems which built on top of the block device will not send discard > command. This is okay for HDD backend, but it will impact the performance > for

Re: [Qemu-devel] Problems with native Mingw-w64 build

Am 27.03.2017 um 07:48 schrieb Mark Cave-Ayland: Right, I see cygwin has a much newer version of glib available which explains how the builds are produced. What was the exact issue with global symbols which prevents the pre-built Win64 binaries from glib > 2.22 being used? Or is that

[Qemu-devel] [PATCH for-2.9] Fix check for target OS support

This check had several problems which are fixed here: * Calling "configure --help" was no longer possible on Cygwin. Fix this by introducing a third state for supported_os and by moving the error handling code. Move the error handling code for supported_cpu, too. * Fix the error text. Use

Re: [Qemu-devel] [PATCH v2] configure: use pkg-config for obtaining xen version

On Mon, 27 Mar 2017, Paul Durrant wrote: > > -Original Message- > > From: Juergen Gross [mailto:jgr...@suse.com] > > Sent: 27 March 2017 10:15 > > To: Paul Durrant ; qemu-devel@nongnu.org; xen- > > de...@lists.xenproject.org > > Cc: Anthony Perard

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 01/11] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}

On Mon, Mar 27, 2017 at 03:26:25PM +0200, Markus Armbruster wrote: > We use InetSocketAddress in the QAPI schema. However, the code > doesn't use inet_connect_saddr(), but formats "host" and "port" into a > configuration string for rados_conf_set(). Thus, members "numeric", > "to", "ipv4" and

Re: [Qemu-devel] [PATCH] spapr: fix memory hot-unplugging

Quoting Laurent Vivier (2017-03-27 08:22:42) > If, once the kernel has booted, we try to remove a memory > hotplugged while the kernel was not started, QEMU crashes on > an assert: > > qemu-system-ppc64: hw/virtio/vhost.c:651: >vhost_commit: Assertion `r >= 0' failed.

Re: [Qemu-devel] What's the next QEMU version after 2.9 ? (or: when is a good point in time to get rid of old interfaces)

On 27.03.2017 21:04, John Snow wrote: > > > On 03/27/2017 04:06 AM, Thomas Huth wrote: >> On 24.03.2017 23:10, John Snow wrote: >>> >>> >>> On 03/08/2017 03:26 AM, Thomas Huth wrote: Hi everybody, what will be the next version of QEMU after 2.9? Will we go for a 2.10

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 08/11] rbd: Revert -blockdev and -drive parameter auth-supported

On 03/27/2017 08:26 AM, Markus Armbruster wrote: > This reverts half of commit 0a55679. We're having second thoughts on > the QAPI schema (and thus the external interface), and haven't reached > consensus, yet. Issues include: > > Let's avoid painting ourselves into a corner now, and revert

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 08/11] rbd: Revert -blockdev and -drive parameter auth-supported

On 03/27/2017 02:14 PM, Markus Armbruster wrote: Removing the .json QMP support is fine. But I'm reluctant to give R-b without knowing for sure that -drive usage won't regress. >>> >>> auth-supported landed in master only on March 2nd. >> >> auth-supported via -blockdev-add only

Re: [Qemu-devel] [Bug 1675108] Re: Cocoa UI always crashes on startup

Brendan Shanks writes: > I just did a quick test on 10.12.3 with those two patches and didn't get > any crashes Awesome. I'm rolling the series now. I assume will pickup the patches in due course. -- Alex Bennée

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 08/11] rbd: Revert -blockdev and -drive parameter auth-supported

Eric Blake writes: > On 03/27/2017 01:31 PM, Markus Armbruster wrote: > - -## -# @RbdAuthMethod: -# -# An enumeration of rados auth_supported types -# -# Since: 2.9 -## -{ 'struct': 'RbdAuthMethod', - 'data': { 'auth':

Re: [Qemu-devel] [PATCH for-2.9] tests/virtio-9p-test: Don't call le*_to_cpus on fields of packed struct

On Mon, 27 Mar 2017 18:59:04 +0100 Peter Maydell wrote: > For a packed struct like 'P9Hdr' the fields within it may not be > aligned as much as the natural alignment for their types. This means > it is not valid to pass the address of such a field to a function > like

Re: [Qemu-devel] What's the next QEMU version after 2.9 ? (or: when is a good point in time to get rid of old interfaces)

On 03/27/2017 04:06 AM, Thomas Huth wrote: > On 24.03.2017 23:10, John Snow wrote: >> >> >> On 03/08/2017 03:26 AM, Thomas Huth wrote: >>> >>> Hi everybody, >>> >>> what will be the next version of QEMU after 2.9? Will we go for a 2.10 >>> (as I've seen it mentioned a couple of times on the

[Qemu-devel] [Bug 1675108] Re: Cocoa UI always crashes on startup

I just did a quick test on 10.12.3 with those two patches and didn't get any crashes -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1675108 Title: Cocoa UI always crashes on startup Status in

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 08/11] rbd: Revert -blockdev and -drive parameter auth-supported

On 03/27/2017 01:31 PM, Markus Armbruster wrote: >>> - >>> -## >>> -# @RbdAuthMethod: >>> -# >>> -# An enumeration of rados auth_supported types >>> -# >>> -# Since: 2.9 >>> -## >>> -{ 'struct': 'RbdAuthMethod', >>> - 'data': { 'auth': 'RbdAuthSupport' } } >>> - >> >> Removing the .json QMP

Re: [Qemu-devel] [PATCH 1/1] slirp: add SOCKS5 support

Le 27/03/2017 à 20:41, Eric Blake a écrit : > On 03/27/2017 01:21 PM, Laurent Vivier wrote: >> When the VM is used behind a firewall, This allows >> to use a SOCKS5 proxy server to connect the VM IP stack > > "allows to $verb" is not idiomatic English; the correct forms are > generally "allows

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image

Markus Armbruster writes: > Max Reitz writes: > >> On 27.03.2017 18:10, Max Reitz wrote: >>> On 27.03.2017 15:26, Markus Armbruster wrote: qemu_rbd_open() neglects to check pool and image are present. Reproducer: $ qemu-system-x86_64

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On 03/27/2017 01:25 PM, ashish mittal wrote: >>> >>> Sample command line using URI syntax: >>> qemu-img convert -f raw -O raw -n >>> /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad >>> vxhs://192.168.0.1:/c6718f6b-0401-441d-a8c3-1f0064d75ee0 >> >> Do we really need URI

Re: [Qemu-devel] [PATCH for-2.9] tests/bios-tables-test: Don't pass addresses of packed struct fields

On Mon, Mar 27, 2017 at 07:18:45PM +0100, Peter Maydell wrote: > Passing the address of a field in a packed struct to a function > that expects a pointer to normally aligned data will result in > a SEGBUS on architectures like SPARC that have strict alignment > requirements. > > Pass addresses of

Re: [Qemu-devel] [BUG] virtio-net linux driver fails to probe on MIPS Malta since 'hw/virtio-pci: fix virtio behaviour'

Hi Marcel, On Tue, Mar 21, 2017 at 04:16:58PM +0200, Marcel Apfelbaum wrote: > Can you please check if the below patch fixes the problem? > Please note it is not a solution. > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index f9b7244..5b4d429 100644 > ---

Re: [Qemu-devel] [PATCH 1/1] slirp: add SOCKS5 support

On 03/27/2017 01:21 PM, Laurent Vivier wrote: > When the VM is used behind a firewall, This allows > to use a SOCKS5 proxy server to connect the VM IP stack "allows to $verb" is not idiomatic English; the correct forms are generally "allows $subject to $verb" or "allows ${verb}ing". In this

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 10/11] Revert "rbd: add support for getting password from QCryptoSecret object"

Eric Blake writes: > On 03/27/2017 08:26 AM, Markus Armbruster wrote: >> This reverts commit 60390a2192e7b38aee18db6ce7fb740498709737. >> >> The commit's rationale >> >> Currently RBD passwords must be provided on the command line >> via >> >> $QEMU -drive

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 08/11] rbd: Revert -blockdev and -drive parameter auth-supported

Eric Blake writes: > On 03/27/2017 08:26 AM, Markus Armbruster wrote: >> This reverts half of commit 0a55679. We're having second thoughts on >> the QAPI schema (and thus the external interface), and haven't reached >> consensus, yet. Issues include: >> > >> Let's avoid

[Qemu-devel] [PATCH v3] Fix input-linux reading from device

The evdev devices in input-linux.c are read in blocks of one whole event. If there are not enough bytes available, they are discarded, instead of being kept for the next read operation. This results in lost events, of even non-working devices. This patch keeps track of the number of bytes to be

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 07/11] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts

Max Reitz writes: > On 27.03.2017 15:26, Markus Armbruster wrote: >> The conversion from QDict to QemuOpts is pointless. Simply get the >> stuff straight from the QDict. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 05/11] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=...

Max Reitz writes: > On 27.03.2017 15:26, Markus Armbruster wrote: >> The way we communicate extra key-value pairs from >> qemu_rbd_parse_filename() to qemu_rbd_open() exposes option parameter >> "keyvalue-pairs" on the command line. It's not wanted there. Hack: >> rename the

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 27, 2017 at 8:56 AM, Eric Blake wrote: > On 03/26/2017 09:50 PM, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqnio.git > > When sending a multi-patch series, please

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image

Max Reitz writes: > On 27.03.2017 18:10, Max Reitz wrote: >> On 27.03.2017 15:26, Markus Armbruster wrote: >>> qemu_rbd_open() neglects to check pool and image are present. >>> Reproducer: >>> >>> $ qemu-system-x86_64 -nodefaults -drive if=none,driver=rbd,pool=p >>>

Re: [Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o

> > ./trace.o, ./qapi/trace.o and ./util/trace.o are added into > > libqemuutil.a to avoid recursive dependencies between > > libqemuutil.a and libqemutrace.a. > > Why would libqemutrace.a depend on libqemuutil.a? Each trace.c calls trace_event_register_group to register events,

[Qemu-devel] [PATCH 0/1] slirp: add SOCKS5 support

This patch implements the SOCKS5 client part for "-net user" backend. It allows to route all internet traffic of the virtual machine to a SOCKS5 server. But all the local traffic (to the host) is sent to the host. It is needed because this SOCKS5 client doesn't route UDP traffic, and this allows

[Qemu-devel] [PATCH 1/1] slirp: add SOCKS5 support

When the VM is used behind a firewall, This allows to use a SOCKS5 proxy server to connect the VM IP stack directly to the Internet. This implementation doesn't manage UDP packets, so they are simply dropped (as with restrict=on), except for the localhost as we need it for DNS. Signed-off-by:

Re: [Qemu-devel] [PATCH 1/5] virtio: Error object based virtio_error()

On Mon, Mar 27, 2017 at 07:46:03PM +0200, Greg Kurz wrote: > This introduces an Error object based implementation of virtio_error(). It > allows to implement virtio_error() wrappers in device-specific code. > > Signed-off-by: Greg Kurz > --- > hw/virtio/virtio.c | 21

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

Jeff Cody writes: > On Mon, Mar 27, 2017 at 07:58:51AM +0200, Markus Armbruster wrote: >> Eric Blake writes: >> >> > On 03/24/2017 09:10 AM, Jeff Cody wrote: >> >> On Fri, Mar 24, 2017 at 08:49:20AM -0500, Eric Blake wrote: >> >>> On 03/24/2017 07:42 AM,

[Qemu-devel] [PATCH for-2.9] tests/bios-tables-test: Don't pass addresses of packed struct fields

Passing the address of a field in a packed struct to a function that expects a pointer to normally aligned data will result in a SEGBUS on architectures like SPARC that have strict alignment requirements. Pass addresses of local variables rather than addresses of packed structure fields to glib

Re: [Qemu-devel] [PATCH] i386: Allow monitor / mwait cpuid override

On Mon, Mar 27, 2017 at 06:42:49PM +0200, Alexander Graf wrote: > > > On 27/03/2017 18:33, Eduardo Habkost wrote: > > On Mon, Mar 27, 2017 at 06:10:43PM +0200, Alexander Graf wrote: > > > > > > > > > On 27/03/2017 17:46, Eduardo Habkost wrote: > > > > On Mon, Mar 27, 2017 at 04:26:50PM +0200,

[Qemu-devel] [PATCH for-2.9] tests/virtio-9p-test: Don't call le*_to_cpus on fields of packed struct

For a packed struct like 'P9Hdr' the fields within it may not be aligned as much as the natural alignment for their types. This means it is not valid to pass the address of such a field to a function like le32_to_cpus() which operate on uint32_t* and assume alignment. Doing this results in a

[Qemu-devel] [PATCH 4/5] 9pfs: drop pdu_push_and_notify()

Only pdu_complete() needs to notify the client that a request has completed. Signed-off-by: Greg Kurz --- hw/9pfs/9p.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 48babce836b6..09a8c79cf781 100644 ---

Re: [Qemu-devel] [PATCH] debug: made printf always compile in debug output

On 03/27/2017 06:50 AM, Danil Antonov wrote: >>From cddb60744808eedbadebdc4f0258ee6db694c4a3 Mon Sep 17 00:00:00 2001 > From: Danil Antonov > Date: Mon, 27 Mar 2017 14:43:10 +0300 > Subject: [PATCH] debug: made printf always compile in debug output > > Wrapped printf

[Qemu-devel] [PATCH 3/5] fsdev: don't allow unknown format in marshal/unmarshal

The code only uses well known format strings. An unknown format token is a bug. Signed-off-by: Greg Kurz --- fsdev/9p-iov-marshal.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c index

[Qemu-devel] [PATCH 2/5] virtio-9p: factor out virtio_9p_error_err()

When an unrecoverable is hit, we need to set the broken flag of the virtio device, detach the queue element and free it. This is currently open coded in handle_9p_output(). It is fine since this is the only function that can set the broken flag. But if we want to be able to do this from other

[Qemu-devel] [PATCH 5/5] 9pfs: handle broken transport

The 9p protocol is transport agnostic: if an error occurs when copying data to/from the client, this should be handled by the transport layer [1] and the 9p server should simply stop processing requests [2]. [1] can be implemented in the transport marshal/unmarshal handlers. In the case of

Re: [Qemu-devel] [PATCH] xen: additionally restrict xenforeignmemory operations

On Mon, 27 Mar 2017, Paul Durrant wrote: > > -Original Message- > [snip] > > > > This is OK but the file is growing too entangled. What do you think of > > the following, which moves the if CONFIG_XEN_CTRL_INTERFACE_VERSION > > < > > 40701 at the top? This way we don't have to add yet

[Qemu-devel] [PATCH 1/5] virtio: Error object based virtio_error()

This introduces an Error object based implementation of virtio_error(). It allows to implement virtio_error() wrappers in device-specific code. Signed-off-by: Greg Kurz --- hw/virtio/virtio.c | 21 - include/hw/virtio/virtio.h |1 + 2 files

[Qemu-devel] [PATCH 0/5] 9pfs: handle transport errors

The 9p protocol relies on a reliable transport, but the current code treats transport errors (ie, failure to marshal or unmarshal) as if they were coming from the backend. This doesn't make sense: if the transport failed, we should notify the guest that the transport is broken and needs to be

[Qemu-devel] packed structures and unaligned accesses (sparc)

At the moment the 9p QEMU tests fail on SPARC. This turns out to be because the test case itself gets a SIGBUS. Looking at the code I guess it makes sense, but I don't understand why the code didn't at least generate a warning. Here's a cutdown testcase: pm215@stadler:~$ cat packed.c #include

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: Have you tested live migration? If live migration is not supported then a migration blocker should be added using migrate_add_blocker(). > v10 changelog: > (1) Implemented accepting TLS creds per block device via the CLI > (see

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 11/11] rbd: Fix bugs around -drive parameter "server"

On 03/27/2017 08:26 AM, Markus Armbruster wrote: > qemu_rbd_open() takes option parameters as a flattened QDict, with > keys of the form server.%d.host, server.%d.port, where %d counts up > from zero. > > qemu_rbd_array_opts() extracts these values as follows. First, it > calls

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 10/11] Revert "rbd: add support for getting password from QCryptoSecret object"

On 03/27/2017 08:26 AM, Markus Armbruster wrote: > This reverts commit 60390a2192e7b38aee18db6ce7fb740498709737. > > The commit's rationale > > Currently RBD passwords must be provided on the command line > via > > $QEMU -drive file=rbd:pool/image:id=myname:\ >

Re: [Qemu-devel] GSoC 2017 Proposal: TCG performance enhancements

Hi Stefan, On Mon, Mar 27, 2017 at 11:54 AM, Stefan Hajnoczi wrote: > On Sat, Mar 25, 2017 at 12:52:35PM -0400, Pranith Kumar wrote: >> Alex Bennée, who mentored me last year, has agreed to mentor me again this >> time if the proposal is accepted. > > Thanks, the project idea

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret

On 03/27/2017 08:26 AM, Markus Armbruster wrote: > This reverts a part of commit 8a47e8e. We're having second thoughts > on the QAPI schema (and thus the external interface), and haven't > reached consensus, yet. Issues include: > > * BlockdevOptionsRbd member @password-secret isn't actually a

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 08/11] rbd: Revert -blockdev and -drive parameter auth-supported

On 03/27/2017 08:26 AM, Markus Armbruster wrote: > This reverts half of commit 0a55679. We're having second thoughts on > the QAPI schema (and thus the external interface), and haven't reached > consensus, yet. Issues include: > > Let's avoid painting ourselves into a corner now, and revert

Re: [Qemu-devel] [PATCH] iscsi: drop unused IscsiAIOCB.qiov field

On 03/27/2017 11:50 AM, Stefan Hajnoczi wrote: > The IscsiAIOCB.qiov field has been unused since commit > 063c3378a9e3c25cc0afac3c72e4823d0621e352 ("block/iscsi: introduce > bdrv_co_{readv, writev, flush_to_disk}") back in 2013. > > Signed-off-by: Stefan Hajnoczi > --- >

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret

On 27.03.2017 15:26, Markus Armbruster wrote: > This reverts a part of commit 8a47e8e. We're having second thoughts > on the QAPI schema (and thus the external interface), and haven't > reached consensus, yet. Issues include: > > * BlockdevOptionsRbd member @password-secret isn't actually a >

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 08/11] rbd: Revert -blockdev and -drive parameter auth-supported

On 27.03.2017 15:26, Markus Armbruster wrote: > This reverts half of commit 0a55679. We're having second thoughts on > the QAPI schema (and thus the external interface), and haven't reached > consensus, yet. Issues include: > > * The implementation uses deprecated rados_conf_set() key >

[Qemu-devel] [PATCH] iscsi: drop unused IscsiAIOCB.qiov field

The IscsiAIOCB.qiov field has been unused since commit 063c3378a9e3c25cc0afac3c72e4823d0621e352 ("block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}") back in 2013. Signed-off-by: Stefan Hajnoczi --- block/iscsi.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH RFC v3 for-2.9 07/11] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts

On 27.03.2017 15:26, Markus Armbruster wrote: > The conversion from QDict to QemuOpts is pointless. Simply get the > stuff straight from the QDict. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH] i386: Allow monitor / mwait cpuid override

On 27/03/2017 18:33, Eduardo Habkost wrote: On Mon, Mar 27, 2017 at 06:10:43PM +0200, Alexander Graf wrote: On 27/03/2017 17:46, Eduardo Habkost wrote: On Mon, Mar 27, 2017 at 04:26:50PM +0200, Alexander Graf wrote: KVM allows trap and emulate (read: NOP) of the MONITOR and MWAIT

  1   2   3   >