Re: [Qemu-devel] Performance problem and improvement about block drive on NFS shares with libnfs

On Sat, 04/01 13:23, Jaden Liang wrote: > Hello, > > I ran qemu with drive file via libnfs recently, and found some performance > problem and an improvement idea. > > I started qemu with 6 drives parameter like > nfs://127.0.0.1/dir/vm-disk-x.qcow2 > which linked to a local NFS server, then

[Qemu-devel] Performance problem and improvement about block drive on NFS shares with libnfs

Hello, I ran qemu with drive file via libnfs recently, and found some performance problem and an improvement idea. I started qemu with 6 drives parameter like nfs://127.0.0.1/dir/vm-disk-x.qcow2 which linked to a local NFS server, then used iometer in guest machine to test the 4K random read or

Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback

On 2017年03月31日 15:30, Liu, Yi L wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Friday, March 31, 2017 3:17 PM To: Liu, Yi L ; 'Peter Xu' Cc: Lan, Tianyu ; Tian, Kevin ;

Re: [Qemu-devel] [PATCH] Revert "vfio/pci-quirks.c: Disable stolen memory for igd VFIO"

> On Fri, 31 Mar 2017 19:03:49 +0200 > Igor Mammedov wrote: > > > On Thu, 30 Mar 2017 20:55:11 -0600 > > Alex Williamson wrote: > > > > > On Fri, 31 Mar 2017 02:27:11 + > > > "Zhang, Xiong Y" wrote: > > > > > > > >

Re: [Qemu-devel] [for-2.9 PATCH 3/3] 9pfs: drop useless loop in v9fs_reset()

> -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Friday, March 31, 2017 7:28 PM > To: qemu-devel@nongnu.org > Cc: Eric Blake; 李强; Greg Kurz > Subject: [for-2.9 PATCH 3/3] 9pfs: drop useless loop in v9fs_reset() > > We don't need to wait for the PDU active list to

Re: [Qemu-devel] [for-2.9 PATCH 2/3] 9pfs: cancel active PDUs in virtfs_reset()

> -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Friday, March 31, 2017 7:27 PM > To: qemu-devel@nongnu.org > Cc: Eric Blake; 李强; Greg Kurz > Subject: [for-2.9 PATCH 2/3] 9pfs: cancel active PDUs in virtfs_reset() > > According to the 9P spec [1], the version

Re: [Qemu-devel] [for-2.9 PATCH 1/3] 9pfs: clear migration blocker at session reset

> -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Friday, March 31, 2017 7:27 PM > To: qemu-devel@nongnu.org > Cc: Eric Blake; 李强; Greg Kurz > Subject: [for-2.9 PATCH 1/3] 9pfs: clear migration blocker at session reset > > The migration blocker survives a device

Re: [Qemu-devel] [PATCH for-2.10 0/5] x86/vIOMMU: move init back to machine init phase

On Fri, Mar 31, 2017 at 07:17:34PM +0300, Michael S. Tsirkin wrote: > On Fri, Mar 31, 2017 at 03:36:28PM +0800, Peter Xu wrote: > > At the very beginning, the x86 vIOMMUs are created via "-M iommu=on". > > We moved one step further a year ago to have the vIOMMUs just like a > > general device, so

[Qemu-devel] [PULL for-2.9 2/3] qapi/curl: Extend and fix blockdev-add schema

From: Max Reitz The curl block driver accepts more options than just "filename"; also, the URL is actually expected to be passed through the "url" option instead of "filename". Signed-off-by: Max Reitz Reviewed-by: Jeff Cody Reviewed-by:

[Qemu-devel] [PULL for-2.9 1/3] rbd: Fix regression in legacy key/values containing escaped :

From: Eric Blake Commit c7cacb3 accidentally broke legacy key-value parsing through pseudo-filename parsing of -drive file=rbd://..., for any key that contains an escaped ':'. Such a key is surprisingly common, thanks to mon_host specifying a 'host:port' string. The break

[Qemu-devel] [PULL for-2.9 3/3] block/curl: Check protocol prefix

From: Max Reitz If the user has explicitly specified a block driver and thus a protocol, we have to make sure the URL's protocol prefix matches. Otherwise the latter will silently override the former which might catch some users by surprise. Signed-off-by: Max Reitz

[Qemu-devel] [PULL for-2.9 0/3] Block patches

The following changes since commit 95b31d709ba343ad237c3630047ee7438bac4065: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20170331.0' into staging (2017-03-31 18:06:13 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git

[Qemu-devel] [RFC 19/19] virtio-mmio: Remove user_creatable flag

virtio-mmio needs to be wired and mapped by other device or board code, and won't work with -device. Remove the user_creatable flag from the device class. Cc: Peter Maydell Cc: Shannon Zhao Cc: "Michael S. Tsirkin"

Re: [Qemu-devel] [RFC v3 0/5] SMMUv3 Emmulation Support

Hi Eric On Thu, Mar 30, 2017 at 12:42 PM, Eric Auger wrote: > This series introduces the emulation code for ARM SMMUv3. > This is the continuation of Prem's work [1]. > > At the moment only AArch64 translation format is supported, ie. > no support for AArch32 (LPAE)

[Qemu-devel] [RFC 18/19] sysbus-ohci: Remove user_creatable flag

sysbus-ohci needs to be mappend and wired by device or board code, and won't work with -device. Remove the user_creatable flag from the device class. Cc: Gerd Hoffmann Signed-off-by: Eduardo Habkost --- hw/usb/hcd-ohci.c | 5 - 1 file changed, 5

[Qemu-devel] [RFC 16/19] generic-sdhci: Remove user_creatable flag

generic-sdhci needs to be wired by other devices' code, so it can't be used with -device. Remove the user_creatable flag from the device class. Cc: Peter Maydell Cc: "Edgar E. Iglesias" Cc: David Gibson Cc:

[Qemu-devel] [RFC 14/19] fw_cfg: Remove user_creatable flag

fw_cfg won't work with -device, as: * fw_cfg_init1() won't get called for the device; * The device won't appear at /machine/fw_cfg, and won't work with the -fw_cfg command-line option. Remove the user_creatable flag from the device class. Cc: "Michael S. Tsirkin" Cc: Laszlo

[Qemu-devel] [RFC 17/19] hpet: Remove user_creatable flag

hpet needs to be mappend and wired by the board code and won't work with -device. Remove the user_creatable flag from the device class. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Signed-off-by: Eduardo Habkost --- hw/timer/hpet.c | 5

[Qemu-devel] [RFC 10/19] sysbus-ahci: Remove user_creatable flag

The sysbus-ahci devices are supposed to be created and wired by code from other devices, like calxeda_init() and xlnx_zynqmp_realize(), and won't work with -device. Remove the user_creatable flag from the device class. Cc: John Snow Cc: qemu-bl...@nongnu.org Cc: Rob Herring

[Qemu-devel] [RFC 15/19] esp: Remove user_creatable flag

esp devices aren't going to work with -device, as they need to be wired by esp_init(). Remove the user_creatable flag from the device class. Cc: Paolo Bonzini Signed-off-by: Eduardo Habkost --- hw/scsi/esp.c | 5 - 1 file changed, 5 deletions(-)

[Qemu-devel] [RFC 11/19] allwinner-ahci: Remove user_creatable flag

allwinner-ahci needs to be created and wired by the alwinner-a10 device, and won't work with -device. Remove the user_creatable flag from the device class. Cc: John Snow Cc: qemu-bl...@nongnu.org Cc: Beniamino Galvani Cc: Peter Maydell

[Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag

unimplemented-device needs to be created and mapped using create_unimplemented_device(), and won't work with -device. Remove the user_creatable flag from the device class. Cc: Peter Maydell Signed-off-by: Eduardo Habkost --- hw/misc/unimp.c | 5

[Qemu-devel] [RFC 09/19] kvmvapic: Remove user_creatable flag

The kvmvapic device needs to be created by apic_common_realize() when apic-common.vapic=on is set, not using -device. Remove the user_creatable flag from the device class. Cc: Igor Mammedov Cc: Paolo Bonzini Cc: Richard Henderson Cc:

[Qemu-devel] [RFC 12/19] isabus-bridge: Remove user_creatable flag

isabus-bridge needs to be created by isa_bus_new(), and won't work with -device, as it won't create the TYPE_ISA_BUS bus itself. Remove the user_creatable flag from the device class. Cc: Marcel Apfelbaum Cc: "Michael S. Tsirkin" Signed-off-by: Eduardo Habkost

[Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

commit 33cd52b5d7b9adfd009e95f07e6c64dd88ae2a31 unset cannot_instantiate_with_device_add_yet in TYPE_SYSBUS, making all kinds of untested devices available to -device and device_add. The problem with that is: setting has_dynamic_sysbus on a machine-type lets it accept all the 288 sysbus device

[Qemu-devel] [RFC 08/19] ioapic: Remove user_creatable flag

An ioapic device is already created by the q35 initialization code, and using "-device ioapic" or "-device kvm-ioapic" will always fail with "Only 1 ioapics allowed". Remove the user_creatable flag from the ioapic device classes. Cc: Igor Mammedov Cc: "Michael S. Tsirkin"

[Qemu-devel] [RFC 06/19] iommu: Remove FIXME comment about user_creatable=true

amd-iommu and intel-iommu are really meant to be used with -device, so they need user_creatable=true. Remove the FIXME comment. Cc: Marcel Apfelbaum Cc: "Michael S. Tsirkin" Signed-off-by: Eduardo Habkost --- hw/i386/amd_iommu.c | 4

[Qemu-devel] [RFC 04/19] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo

sysbus-fdc and SUNW,fdtwo devices need to be wired by the fdc initialization code, and can't be used with -device. Unset user_creatable on their device classes. Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-bl...@nongnu.org Cc:

[Qemu-devel] [RFC 07/19] kvmclock: Remove user_creatable flag

kvmclock should be used by guests only when the appropriate CPUID feature flags are set on the VCPU, and it is automatically created by kvmclock_create() when those feature flags are set. This means creating a kvmclock device using -device is useless. Remove user_creatable from its device class.

[Qemu-devel] [RFC 00/19] sysbus: Don't allow -device/device_add by default

This series refactor the cannot_instantiate_with_device_add code for sysbus. First, cannot_instantiate_with_device_add is replaced by !user_creatable. Then, we change TYPE_SYS_BUS_DEVICE to set user_creatable=false by default, while keeping the existing devices that are not rejected by -device

[Qemu-devel] [RFC 01/19] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable

cannot_instantiate_with_device_add_yet was introduced by commit 837d37167dc446af8a91189108b363c04609e296 to replace no_user. It was supposed to be a temporary measure. When it was introduced, we had 54 cannot_instantiate_with_device_add_yet=true lines in the code. Today (3 years later) this

[Qemu-devel] [RFC 05/19] pflash_cfi01: Remove user_creatable flag

TYPE_CFI_PFLASH01 devices need to be mapped by pflash_cfi01_register() and can't be used with -device. Remove user_creatable from the device class. Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-bl...@nongnu.org Cc: Laszlo Ersek Signed-off-by:

[Qemu-devel] [RFC 02/19] s390: Add FIXME for unexplained user_creatable=false line

TYPE_S390_PCI_HOST_BRIDGE has user_creatable=false but has no comment explaining why. Add a FIXME to document that. Cc: Frank Blaschka Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Alexander Graf Cc:

[Qemu-devel] Project idea

Good day, I'd be interested in submitting the following ideas: I'd like to enchance qemu's debugging capabilities. I was thinking to add an option to qemu to disable cpu reset on tripple-fault. Or adding support for breakpoints in the GDB stub while using kvm or another accelerator. Or emulating a

Re: [Qemu-devel] host stalls when qemu-system-aarch64 with kvm and pflash

On Thu, Mar 30, 2017 at 9:47 AM, Laszlo Ersek wrote: > On 03/29/17 20:56, Christoffer Dall wrote: >> On Tue, Mar 28, 2017 at 01:24:15PM -0700, Radha Mohan wrote: >>> On Tue, Mar 28, 2017 at 1:16 PM, Christoffer Dall wrote: Hi Radha, On Tue, Mar

[Qemu-devel] hitting intermittent issue with live migration from qemu-kvm-ev 2.3.0 to qemu-kvm-ev 2.6.0

Hi, I'm running into an issue with live-migrating a guest from a host running qemu-kvm-ev 2.3.0-31 to a host running qemu-kvm-ev 2.6.0-27.1. This is a libvirt-tunnelled migration, in the context of upgrading an OpenStack install to newer software. The source host is running CentOS 7.2.1511,

Re: [Qemu-devel] [PATCH qemu] pci: Only unmap bus_master_enabled_region if was added previously

On Fri, Mar 31, 2017 at 03:47:11PM +1100, Alexey Kardashevskiy wrote: > Normally pci_init_bus_master() would be called either via > bus->machine_done.notify or directly from do_pci_register_device(). > > However if a device's realize() failed, pci_init_bus_master() is not > called, and

Re: [Qemu-devel] [PATCH] block/parallels.c: avoid integer overflow in allocate_clusters()

On 03/31/2017 04:47 PM, Max Reitz wrote: > On 31.03.2017 15:13, Peter Maydell wrote: >> Coverity (CID 1307776) points out that in the multiply: >> space = to_allocate * s->tracks; >> we are trying to calculate a 64 bit result but the types >> of to_allocate and s->tracks mean that we actually

[Qemu-devel] [PATCH] main-loop: Acquire main_context lock around os_host_main_loop_wait.

When running virt-rescue the serial console hangs from time to time. Virt-rescue runs an ordinary Linux kernel "appliance", but there is only a single idle process running inside, so the qemu main loop is largely idle. With virt-rescue >= 1.37 you may be able to observe the hang by doing: $

Re: [Qemu-devel] [PATCH for-2.9 2/2] block/curl: Check protocol prefix

On 31.03.2017 21:30, Eric Blake wrote: > On 03/31/2017 07:04 AM, Max Reitz wrote: >> If the user has explicitly specified a block driver and thus a protocol, >> we have to make sure the URL's protocol prefix matches. Otherwise the >> latter will silently override the former which might catch some

Re: [Qemu-devel] [PATCH for-2.9 v8 0/3] Fix wipe of unaligned qcow2 image [was add blkdebug tests]

On 31.03.2017 20:53, Eric Blake wrote: > Available as a tag at: > git fetch git://repo.or.cz/qemu/ericb.git nbd-blkdebug-v8 > > (which is somewhat of a misnomer for this current version of the > series, but historically correct) > > v6 was: >

Re: [Qemu-devel] [PATCH for-2.9] block/parallels: Avoid overflows

On 03/31/2017 02:05 PM, Max Reitz wrote: Change the types of variables in allocate_clusters() to int64_t so we do not have to worry about potential overflows. Add an assertion that our accesses to s->bat[] do not result in a buffer overflow and that the implicit conversion performed when

Re: [Qemu-devel] [PATCH qemu] pci: Only unmap bus_master_enabled_region if was added previously

> On 03/31/2017 12:47 AM, Alexey Kardashevskiy wrote: > > Normally pci_init_bus_master() would be called either via > > bus->machine_done.notify or directly from do_pci_register_device(). > > > > However if a device's realize() failed, pci_init_bus_master() is not > > called, and

Re: [Qemu-devel] [PATCH v3 00/11] MTTCG fix-ups for 2.9

Paolo Bonzini writes: > On 31/03/2017 13:21, Alex Bennée wrote: >> Anyway I think I'm getting closer to narrowing it down. On record I see >> replay_current_step jump backwards with this: >> >> /* A common event print, called when reading or saving an event */ >> static

Re: [Qemu-devel] [PATCH 5/5] cpu: throttle: fix throttle time slice

> > So I'm inclined _not_ to take your patch. One possibility could be to > > do the following: > > > > - for throttling between 0% and 80%, use the current algorithm. At 66%, > > the CPU will work for 10 ms and sleep for 40 ms. > > > > - for throttling above 80% adapt your algorithm to have

Re: [Qemu-devel] [PATCH for-2.9 2/2] block/curl: Check protocol prefix

On 03/31/2017 07:04 AM, Max Reitz wrote: > If the user has explicitly specified a block driver and thus a protocol, > we have to make sure the URL's protocol prefix matches. Otherwise the > latter will silently override the former which might catch some users by > surprise. > > Signed-off-by: Max

[Qemu-devel] [PATCH for-2.10 1/2] etsec: Rename (TYPE_)ETSEC_COMMON to (TYPE_)ETSEC

Types named *_COMMON are normally used when there's a common parent class for multiple classes. We have only one eTSEC type, so rename the TYPE_ETSEC_COMMON and ETSEC_COMMON macros to TYPE_ETSEC and TYPE_ETSEC_COMMON. Signed-off-by: Eduardo Habkost ---

Re: [Qemu-devel] [PATCH for-2.9 1/2] qapi/curl: Extend and fix blockdev-add schema

On 03/31/2017 07:04 AM, Max Reitz wrote: > The curl block driver accepts more options than just "filename"; also, > the URL is actually expected to be passed through the "url" option > instead of "filename". > > Signed-off-by: Max Reitz > --- > qapi/block-core.json | 103 >

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9 1/2] qapi/curl: Extend and fix blockdev-add schema

On Fri, Mar 31, 2017 at 02:04:30PM +0200, Max Reitz wrote: > The curl block driver accepts more options than just "filename"; also, > the URL is actually expected to be passed through the "url" option > instead of "filename". > > Signed-off-by: Max Reitz > --- >

[Qemu-devel] [PATCH for-2.10 0/2] etsec: (TYPE_)ETSEC_COMMON macro cleanup

When working on other things, I got confused by the etsec code, that didn't use the TYPE_ETSEC_COMMON macro in its type declaration, and had no subclasses despite being named ETSEC_COMMON. This is a very simple cleanup to remove the _COMMON suffix from the macros, and to use the TYPE_ETSEC macro

[Qemu-devel] [PATCH for-2.10 2/2] etsec: Use TYPE_ETSEC macro when registering/creating device

Instead of hardcoding the class name, use the TYPE_ETSEC macro when registering the class and creating devices. Signed-off-by: Eduardo Habkost --- hw/net/fsl_etsec/etsec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/fsl_etsec/etsec.c

Re: [Qemu-devel] [PATCH for-2.9 2/2] block/curl: Check protocol prefix

On 03/31/2017 07:04 AM, Max Reitz wrote: > If the user has explicitly specified a block driver and thus a protocol, > we have to make sure the URL's protocol prefix matches. Otherwise the > latter will silently override the former which might catch some users by > surprise. > > Signed-off-by: Max

Re: [Qemu-devel] [PATCH 5/5] cpu: throttle: fix throttle time slice

Ignoring the details below for a minute, this patch belongs in a separate series; all the rest of the patches in this set are nice simple ones. * Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 27/03/2017 09:21, Peter Xu wrote: > > @@ -641,8 +640,7 @@ static void

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

Hi, > -Original Message- > From: Max Reitz [mailto:mre...@redhat.com] > Sent: Friday, March 31, 2017 8:57 PM > To: Ciprian Barbu; qemu-devel@nongnu.org; Eric Blake; Alexandru Avadanii > Cc: Jeff Cody; Markus Armbruster; svc-armband; Kevin Wolf > Subject: Re: [Qemu-devel] nbd: Possible

Re: [Qemu-devel] [PATCH 4/5] hmp: info migrate_parameters format tunes

* Peter Xu (pet...@redhat.com) wrote: > Do the same (one per line) to the parameter list. > > CC: "Dr. David Alan Gilbert" > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > hmp.c | 22 ++ >

Re: [Qemu-devel] [PATCH 2/5] migration: rename max_size to threshold_size

* Peter Xu (pet...@redhat.com) wrote: > In migration codes (especially in migration_thread()), max_size is used > in many place for the threshold value that we will start to do the final > flush and jump to the next stage to dump the whole rest things to > destination. However its name is

Re: [Qemu-devel] [PATCH 3/5] hmp: info migrate_capability format tunes

* Peter Xu (pet...@redhat.com) wrote: > Dump the info in a single line is hard to read. Do it one per line. > Also, the first "capabilities:" didn't help much. Let's remove it. > > CC: "Dr. David Alan Gilbert" > Signed-off-by: Peter Xu agreed, although

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9 0/2] curl: Extend and fix blockdev-add schema

On Fri, Mar 31, 2017 at 02:04:29PM +0200, Max Reitz wrote: > Yes, it's yet another episode in our popular > get-blockdev-add-ready-for-2.9 drama! > > Right now, the schema for the curl block driver is seriously lacking. > This series improves things at least a bit. > > To improve things

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9 2/2] block/curl: Check protocol prefix

On Fri, Mar 31, 2017 at 02:04:31PM +0200, Max Reitz wrote: > If the user has explicitly specified a block driver and thus a protocol, > we have to make sure the URL's protocol prefix matches. Otherwise the > latter will silently override the former which might catch some users by > surprise. > >

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9 1/2] qapi/curl: Extend and fix blockdev-add schema

On Fri, Mar 31, 2017 at 02:04:30PM +0200, Max Reitz wrote: > The curl block driver accepts more options than just "filename"; also, > the URL is actually expected to be passed through the "url" option > instead of "filename". > > Signed-off-by: Max Reitz Reviewed-by: Jeff

[Qemu-devel] [PATCH v8 1/3] iotests: fix 097 when run with qcow

From: "Daniel P. Berrange" The previous commit: commit a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd Author: Eric Blake Date: Mon Dec 5 09:49:34 2016 -0600 qcow2: Don't strand clusters near 2G intervals during commit extended the 097 test case

[Qemu-devel] [PATCH v8 2/3] qcow2: Discard unaligned tail when wiping image

There is a subtle difference between the fast (qcow2v3 with no extra data) and slow path (qcow2v2 format [aka 0.10], or when a snapshot is present) of qcow2_make_empty(). The slow path fails to discard the final (partial) cluster of an unaligned image. The problem stems from the fact that

[Qemu-devel] [PATCH v8 3/3] iotests: Improve image-clear tests on non-aligned image

Tweak 097 and 176 to operate on an image that is not cluster-aligned, to give further coverage of clearing out an entire image, including the recent fix to eliminate the difference between fast path (97) and slow (176) for qcow2. Also tested on qcow (97 only, since qcow lacks snapshots).

[Qemu-devel] [PATCH for-2.9 v8 0/3] Fix wipe of unaligned qcow2 image [was add blkdebug tests]

Available as a tag at: git fetch git://repo.or.cz/qemu/ericb.git nbd-blkdebug-v8 (which is somewhat of a misnomer for this current version of the series, but historically correct) v6 was: https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg01562.html v7 was:

Re: [Qemu-devel] [PATCH 1/5] migration: set current_active_state once

* Peter Xu (pet...@redhat.com) wrote: > We set it right above this one. No need to set it twice. Ah good spot, yes set in the declaration of current_active_state. > CC: Juan Quintela > CC: "Dr. David Alan Gilbert" > Signed-off-by: Peter Xu

Re: [Qemu-devel] Problems with native Mingw-w64 build

Am 31.03.2017 um 19:08 schrieb Mark Cave-Ayland: On 28/03/17 16:16, Thomas Huth wrote: We've already got a page with instructions for building with MingW: http://wiki.qemu-project.org/Hosts/W32 So that might be a good place to add your experience with MSYS, I guess? Done. See

Re: [Qemu-devel] [PATCH for-2.9] block/parallels: Avoid overflows

On 03/31/2017 12:05 PM, Max Reitz wrote: > Change the types of variables in allocate_clusters() to int64_t so we do > not have to worry about potential overflows. > > Add an assertion that our accesses to s->bat[] do not result in a buffer > overflow and that the implicit conversion performed

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 27, 2017 at 6:04 PM, ashish mittal wrote: > On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi wrote: >> On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: >> >> Have you tested live migration? >> >> If live migration is not

Re: [Qemu-devel] [PATCH for-2.9] rbd: Fix regression in legacy key/values containing escaped :

Tested-by: Alexandru Avadanii Thank you very much for the quick fix! > -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Friday, March 31, 2017 6:28 PM > To: qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; jc...@redhat.com;

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

On 31.03.2017 19:49, Ciprian Barbu wrote: > Hi, > > Thank you for getting back! > > I'm trying to follow you, but I don't understand all the details. I would > like to ask this question though: > > What is the difference between v2.8.0 and this commit? With v2.8.0 the same > qemu command

Re: [Qemu-devel] [PATCH for-2.9] rbd: Fix regression in legacy key/values containing escaped :

On Fri, Mar 31, 2017 at 10:27:30AM -0500, Eric Blake wrote: > Commit c7cacb3 accidentally broke legacy key-value parsing through > pseudo-filename parsing of -drive file=rbd://..., for any key that > contains an escaped ':'. Such a key is surprisingly common, thanks > to mon_host specifying a

Re: [Qemu-devel] [RFC] Split migration bitmaps by ramblock

* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> Note that there are two reason for this, ARM and PPC do things like > >> guests with 4kb pages on hosts with 16/64kb hosts, and then we have >

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

Hi, Thank you for getting back! I'm trying to follow you, but I don't understand all the details. I would like to ask this question though: What is the difference between v2.8.0 and this commit? With v2.8.0 the same qemu command worked, but I admit it doesn't request sharing. We also use

Re: [Qemu-devel] [PATCH for-2.9? v4] ipmi: Fix macro issues

On 31 March 2017 at 11:04, Eric Blake wrote: > > Might also be worth adding that an audit of the code finds no semantic > change, that this is just cleaning up the compiler warning. We should include core detail of your detailed analysis in such a statement I think, because I

Re: [Qemu-devel] [PATCH for-2.9] rbd: Fix regression in legacy key/values containing escaped :

On 31.03.2017 17:27, Eric Blake wrote: > Commit c7cacb3 accidentally broke legacy key-value parsing through > pseudo-filename parsing of -drive file=rbd://..., for any key that > contains an escaped ':'. Such a key is surprisingly common, thanks > to mon_host specifying a 'host:port' string. The

Re: [Qemu-devel] [PATCH qemu] pci: Only unmap bus_master_enabled_region if was added previously

On 03/31/2017 12:47 AM, Alexey Kardashevskiy wrote: > Normally pci_init_bus_master() would be called either via > bus->machine_done.notify or directly from do_pci_register_device(). > > However if a device's realize() failed, pci_init_bus_master() is not > called, and do_pci_unregister_device()

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

On 31.03.2017 18:03, Ciprian Barbu wrote: > Hello, > > Similar to the other thread about possible regression with rbd, there might > be a regression with nbd. > This time we are launching an instance from an image (not volume) and try to > live migrate it: > > nova live-migration > > The

Re: [Qemu-devel] [PULL 0/1] VFIO fixes 2017-03-31

On 31 March 2017 at 18:01, Alex Williamson <alex.william...@redhat.com> wrote: > The following changes since commit 37c4a85cd256a51c5f58ee7e531f25f0e89b2c87: > > Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170331' into > staging (2017-03-31 12:43:27 +0100)

Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch

On Fri, Mar 31, 2017 at 07:31:57PM +0200, Paolo Bonzini wrote: > > > On 31/03/2017 19:31, Richard W.M. Jones wrote: > > On Fri, Mar 31, 2017 at 06:53:56PM +0200, Paolo Bonzini wrote: > >> glib is expecting QEMU to use g_main_context_acquire around accesses to > >> GMainContext. However QEMU is

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

Sorry, I think this one is more likely the cause, it's about migration: https://github.com/qemu/qemu/commit/6f5ef23a3ff09919b73eef8196969685cb2383ee From: Ciprian Barbu Sent: Friday, March 31, 2017 8:33 PM To: Ciprian Barbu ; qemu-devel@nongnu.org; Eric Blake

Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch

On 31/03/2017 19:31, Richard W.M. Jones wrote: > On Fri, Mar 31, 2017 at 06:53:56PM +0200, Paolo Bonzini wrote: >> glib is expecting QEMU to use g_main_context_acquire around accesses to >> GMainContext. However QEMU is not doing that, instead it is taking its >> own mutex. So we should add

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

I suspect the culprit here is [1]. I've started a git bisect between this commit and v2.8.0 and during this time I found similar erros "/root/qemu/nbd/server.c:nbd_receive_request():L706: read failed" I suspect this fix tried to solve a bunch of these read fails, but broke write requests. [1]

Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch

On Fri, Mar 31, 2017 at 06:53:56PM +0200, Paolo Bonzini wrote: > glib is expecting QEMU to use g_main_context_acquire around accesses to > GMainContext. However QEMU is not doing that, instead it is taking its > own mutex. So we should add g_main_context_acquire and > g_main_context_release in

Re: [Qemu-devel] [PATCH] Revert "vfio/pci-quirks.c: Disable stolen memory for igd VFIO"

On Fri, 31 Mar 2017 19:03:49 +0200 Igor Mammedov wrote: > On Thu, 30 Mar 2017 20:55:11 -0600 > Alex Williamson wrote: > > > On Fri, 31 Mar 2017 02:27:11 + > > "Zhang, Xiong Y" wrote: > > > > > > On Thu, 30 Mar

Re: [Qemu-devel] [PATCH 48/51] ram: Use ramblock and page offset instead of absolute offset

* Juan Quintela (quint...@redhat.com) wrote: > This removes the needto pass also the absolute offset. Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Quintela > --- > migration/ram.c| 56 >

Re: [Qemu-devel] [PATCH] block/parallels.c: avoid integer overflow in allocate_clusters()

On Fri, Mar 31, 2017 at 05:18:39PM +0100, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 10:40:33AM -0300, Eduardo Habkost wrote: > > On Fri, Mar 31, 2017 at 10:27:44AM -0300, Philippe Mathieu-Daudé wrote: > > > Hi, > > > > > > Eduardo you seem skilled regarding Coccinelle scripts, is it

Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch

On Fri, Mar 31, 2017 at 05:43:22PM +0100, Stefan Hajnoczi wrote: > The ISA serial port device's output can hang when the pipe on stdout > becomes full. This is a race condition where the vcpu thread executing > serial emulation code adds a watch on stdout while the main loop thread > is blocked

Re: [Qemu-devel] Problems with native Mingw-w64 build

On 28/03/17 16:16, Thomas Huth wrote: > On 28.03.2017 09:25, Mark Cave-Ayland wrote: > [...] >> I ended up starting again from scratch last night and trying the build >> with MSYS2 instead. MSYS2 has really improved since I last looked at it >> a couple of years back, and I was able to get a

[Qemu-devel] [PATCH for-2.9] block/parallels: Avoid overflows

Change the types of variables in allocate_clusters() to int64_t so we do not have to worry about potential overflows. Add an assertion that our accesses to s->bat[] do not result in a buffer overflow and that the implicit conversion performed when invoking bat_entry_off() does not result in an

Re: [Qemu-devel] [PATCH] Revert "vfio/pci-quirks.c: Disable stolen memory for igd VFIO"

On Thu, 30 Mar 2017 20:55:11 -0600 Alex Williamson wrote: > On Fri, 31 Mar 2017 02:27:11 + > "Zhang, Xiong Y" wrote: > > > > On Thu, 30 Mar 2017 18:27:21 +0800 > > > Xiong Zhang wrote: > > > > > > > This

[Qemu-devel] [PULL 1/1] Revert "vfio/pci-quirks.c: Disable stolen memory for igd VFIO"

From: Xiong Zhang This reverts commit c2b2e158cc7b1cb431bd6039824ec13c3184a775. The original patch intend to prevent linux i915 driver from using stolen meory. But this patch breaks windows IGD driver loading on Gen9+, as IGD HW will use stolen memory on Gen9+, once

[Qemu-devel] [PULL 0/1] VFIO fixes 2017-03-31

The following changes since commit 37c4a85cd256a51c5f58ee7e531f25f0e89b2c87: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170331' into staging (2017-03-31 12:43:27 +0100) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-updates

Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch

On 31/03/2017 18:43, Stefan Hajnoczi wrote: > The ISA serial port device's output can hang when the pipe on stdout > becomes full. This is a race condition where the vcpu thread executing > serial emulation code adds a watch on stdout while the main loop thread > is blocked in ppoll(2). If no

Re: [Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

* Juan Quintela (quint...@redhat.com) wrote: > This are the last postcopy fields still at MigrationState. Once there > Move MigrationSrcPageRequest to ram.c and remove MigrationState > parameters where appropiate. > > Signed-off-by: Juan Quintela > --- >

[Qemu-devel] [PATCH v1 1/3] applesmc: cosmetic whitespace and indentation cleanup

Signed-off-by: Gabriel Somlo --- hw/misc/applesmc.c | 100 +++-- 1 file changed, 51 insertions(+), 49 deletions(-) diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 77fab5b..986f2ac 100644 --- a/hw/misc/applesmc.c +++

[Qemu-devel] [PATCH v1 2/3] applesmc: consolidate port i/o into single contiguous region

Newer AppleSMC revisions support an error status (read) port in addition to the data and command ports currently supported. Register the full 32-bit region at once, and handle individual ports at various offsets within the region from the top-level applesmc_io_[write|read]() methods (ctual

[Qemu-devel] [PATCH v1 0/3] Update AppleSMC for OS X Sierra 10.12.4 guests

As of 10.12.4 (currently the latest Sierra update), OS X refuses to boot unless the AppleSMC supports a third I/O port, which provides the current error status when read. This series consists of three patches: - 1/3: indentation/whitespace cleanup for applesmc.c to the point

[Qemu-devel] [PATCH v1 3/3] applesmc: implement error status port

As of release 10.12.4, OS X (Sierra) refuses to boot unless the AppleSMC supports an additional I/O port, expected to provide an error status code. Update the [cmd|data]_write() and data_read() methods to implement the required state machine, and add an err_read() method to provide the error

Re: [Qemu-devel] [for-2.10 PATCH] fsdev: move stub to libqemustub.a

On Fri, 31 Mar 2017 16:06:35 +0200 Paolo Bonzini wrote: > On 31/03/2017 15:52, Greg Kurz wrote: > > The qemu_fsdev_add() stub is used by targets that don't build VirtFS, like > > CRIS for example. This can be handled by libqemustub.a. > > It can, the question is do we

[Qemu-devel] [PATCH] char: kick main loop after adding a watch

The ISA serial port device's output can hang when the pipe on stdout becomes full. This is a race condition where the vcpu thread executing serial emulation code adds a watch on stdout while the main loop thread is blocked in ppoll(2). If no timer or other event wakes up the main loop, there

  1   2   3   >