Re: [Qemu-devel] [RFC/BUG] xen-mapcache: buggy invalidate map cache?

On Tue, Apr 11, 2017 at 3:50 AM, Stefano Stabellini wrote: > On Mon, 10 Apr 2017, Stefano Stabellini wrote: >> On Mon, 10 Apr 2017, hrg wrote: >> > On Sun, Apr 9, 2017 at 11:55 PM, hrg wrote: >> > > On Sun, Apr 9, 2017 at 11:52 PM, hrg

[Qemu-devel] [Bug 897193] Re: virtfs: kernel compile fails

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/897193 Title: virtfs:

Re: [Qemu-devel] [PATCH 40/54] ram: Remove compression_switch and inline its logic

On Thu, Apr 06, 2017 at 03:08:59PM +0200, Juan Quintela wrote: > We can calculate its value, so not create a varible for it. > > Signed-off-by: Juan Quintela > > -- > > After Peter and Dave review, I dropped the variable and just inlined > the condition. > > Later, Juan.

Re: [Qemu-devel] [PATCH 11/54] ram: Change num_dirty_pages_period type to uint64_t

On Thu, Apr 06, 2017 at 03:08:30PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela Reviewed-by: Peter Xu -- peterx

Re: [Qemu-devel] [PATCH 09/54] ram: Change byte_xfer_now type to uint64_t

On Thu, Apr 06, 2017 at 03:08:28PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela Reviewed-by: Peter Xu -- peterx

Re: [Qemu-devel] [PATCH 08/54] ram: Move bytes_xfer_prev into RAMState

On Thu, Apr 06, 2017 at 03:08:27PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- peterx

Re: [Qemu-devel] [PATCH 02/54] ram: Rename flush_page_queue() to migration_page_queue_free()

On Thu, Apr 06, 2017 at 03:08:21PM +0200, Juan Quintela wrote: > It reflects better what it does. > > Signed-off-by: Juan Quintela Reviewed-by: Peter Xu Thanks, -- peterx

Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name

11.04.2017 00:49, John Snow wrote: On 02/17/2017 02:51 PM, Dr. David Alan Gilbert wrote: * Fam Zheng (f...@redhat.com) wrote: On Fri, 02/17 16:36, Vladimir Sementsov-Ogievskiy wrote: 17.02.2017 15:21, Fam Zheng wrote: On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: 16.02.2017

Re: [Qemu-devel] [PATCH v2 4/4] qga: improve error handling in transfer_memory_block

On 04/10/2017 10:20 PM, Michael Roth wrote: Quoting Philippe Mathieu-Daudé (2017-04-07 17:20:16) Suggested-by: Michael Roth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael Roth --- Michael should I use

Re: [Qemu-devel] [PATCH 20/21] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge

On Mon, 2017-04-10 at 18:14 +1000, David Gibson wrote: > > +    switch (size) { > > +    case 1: > > +    break; > > +    case 2: > > +    val = bswap16(val); > > An unconditional bswap() seems unlikely to be correct.  What's the > purpose of thise? Though it is :-) I *think* ... I did

Re: [Qemu-devel] [PATCH v3 02/21] mux: simplfy muxes_realize_done

On 04/04/2017 01:31 PM, Marc-André Lureau wrote: Hi Philippe - Original Message - Hi Marc-André, On 03/16/2017 06:21 AM, Marc-André Lureau wrote: mux_chr_event() already send events to all backends, rename it, export it, and use it from muxes_realize_done. This should help abstract

Re: [Qemu-devel] [PATCH v3 14/21] char-socket: add 'connected' property

On 03/16/2017 06:21 AM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- chardev/char-socket.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/chardev/char-socket.c

Re: [Qemu-devel] [PATCH v3 13/21] char-socket: add 'addr' property

On 03/16/2017 06:21 AM, Marc-André Lureau wrote: Add a property to lookup the connection details. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- chardev/char-socket.c | 13 + 1 file changed, 13

Re: [Qemu-devel] [PATCH v3 11/21] char-socket: introduce update_disconnected_filename()

On 03/16/2017 06:21 AM, Marc-André Lureau wrote: This helper will be used in yet another place in the following patch. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- chardev/char-socket.c | 15 +++ 1 file

Re: [Qemu-devel] [PATCH v3 04/21] container: don't leak container reference

On 03/16/2017 06:21 AM, Marc-André Lureau wrote: object_property_add_child() references the child, unref it after to avoid ref leaks. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- qom/container.c | 1 + 1 file

Re: [Qemu-devel] [PATCH v2 7/8] ppc/pnv: add initial IPMI sensors for the BMC simulator

On Mon, Apr 10, 2017 at 03:56:57PM +0200, Cédric Le Goater wrote: > Skiboot, the firmware for the PowerNV platform, expects the BMC to > provide some specific IPMI sensors. These sensors are exposed in the > device tree and their values are updated by the firmware at boot time. > > Sensors of

Re: [Qemu-devel] [PATCH v2 2/8] ppc/pnv: enable only one LPC bus

On Mon, Apr 10, 2017 at 03:56:52PM +0200, Cédric Le Goater wrote: > The firmware (skiboot) chooses the default LPC bus of a multichip > systems using a "primary" property. The LPC bus of chip 0 should be > the only connected in the system. Let's advertise it in the device > tree. > >

Re: [Qemu-devel] [PATCH v2 1/8] ppc/pnv: Add support for POWER8+ LPC Controller

On Mon, Apr 10, 2017 at 03:56:51PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > It adds the Naples chip which supports proper LPC interrupts via the > LPC controller rather than via an external CPLD. > > Signed-off-by: Benjamin Herrenschmidt

Re: [Qemu-devel] [PATCH v2 6/8] ppc/pnv: populate device tree for IPMI BT devices

On Mon, Apr 10, 2017 at 03:56:56PM +0200, Cédric Le Goater wrote: > When an ipmi-bt device [1] is defined on the ISA bus, we need to > populate the device tree with the object properties. Such devices are > created with the command line options : > >-device ipmi-bmc-sim,id=bmc0 -device

Re: [Qemu-devel] [PATCH v9 03/13] qemu-io: Switch 'alloc' command to byte-based length

Hi Eric, On 04/10/2017 10:17 PM, Eric Blake wrote: For the 'alloc' command, accepting an offset in bytes but a length in sectors, and reporting output in sectors, is confusing. Do everything in bytes, and adjust the expected output accordingly. Signed-off-by: Eric Blake

Re: [Qemu-devel] [PATCH v9 1/9] memory: add section range info for IOMMU notifier

On Mon, Apr 10, 2017 at 03:09:50PM +0800, Peter Xu wrote: > On Mon, Apr 10, 2017 at 02:39:22PM +1000, David Gibson wrote: > > On Fri, Apr 07, 2017 at 06:59:07PM +0800, Peter Xu wrote: > > > In this patch, IOMMUNotifier.{start|end} are introduced to store section > > > information for a specific

Re: [Qemu-devel] centos 7.2 guest doesn't boot without kvmvapic in TCG mode

+ Richard Henderson Anthony > -Original Message- > From: Xu, Anthony > Sent: Tuesday, April 4, 2017 5:19 PM > To: 'qemu-devel@nongnu.org' > Cc: 'Paolo Bonzini' ; 'Stefan Hajnoczi' > > Subject: [Qemu-devel] centos 7.2 guest

Re: [Qemu-devel] [PATCH 4/4] pam: setup pc.bios

> I think this is wrong, the high copy should remain read-only or pflash > stops working when you remove PAM. I tried to set pc.bios as read-only and isa.bios as read, it doesn't work. render_memory_region doesn't honor readonly field of alias MemoryRegion. Two FlatRanges created for pc.bios

Re: [Qemu-devel] [PATCH 1/4] pam:refactor PAM related code

> On 08/04/2017 08:45, Anthony Xu wrote: > > split PAM SMRAM functions in piix.c > > create mch_init_pam in q35.c > > Could you further move > > MemoryRegion *ram_memory; > MemoryRegion *system_memory; > MemoryRegion *pci_address_space; > PAMMemoryRegion pam_regions[13]; > >

Re: [Qemu-devel] [PATCH v3] migration/block: use blk_pwrite_zeroes for each zero cluster

On Tue, Apr 11, 2017 at 12:00 AM, Stefan Hajnoczi wrote: > On Sun, Apr 09, 2017 at 08:37:40PM +0800, jemmy858...@gmail.com wrote: >> From: Lidong Chen >> >> BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, >> this maybe cause the qcow2

[Qemu-devel] [PATCH v9 07/13] qcow2: Discard/zero clusters by byte count

Passing a byte offset, but sector count, when we ultimately want to operate on cluster granularity, is madness. Clean up the external interfaces to take both offset and count as bytes, while still keeping the assertion added previously that the caller must align the values to a cluster. Then

Re: [Qemu-devel] [PATCH v2 3/4] qga: fix compiler warnings (clang 5)

Quoting Philippe Mathieu-Daudé (2017-04-07 17:20:15) > static code analyzer complain: > > qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to a > 'nonnull' parameter > closedir(dp); > ^~~~ > > Reported-by: Clang Static Analyzer > Signed-off-by:

[Qemu-devel] [PATCH v9 13/13] tests: Add coverage for recent block geometry fixes

Use blkdebug's new geometry constraints to emulate setups that have caused recent regression fixes: write zeroes asserting when running through a loopback block device with max-transfer smaller than cluster size, and discard rounding away portions of requests not aligned to preferred boundaries.

Re: [Qemu-devel] [PATCH v2 4/4] qga: improve error handling in transfer_memory_block

Quoting Philippe Mathieu-Daudé (2017-04-07 17:20:16) > Suggested-by: Michael Roth > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael Roth > --- > > Michael should I use Signed-off-by instead of the Suggested-by

[Qemu-devel] [PATCH v9 03/13] qemu-io: Switch 'alloc' command to byte-based length

For the 'alloc' command, accepting an offset in bytes but a length in sectors, and reporting output in sectors, is confusing. Do everything in bytes, and adjust the expected output accordingly. Signed-off-by: Eric Blake --- qemu-io-cmds.c| 30

[Qemu-devel] [PATCH v9 08/13] blkdebug: Sanity check block layer guarantees

Commits 04ed95f4 and 1a62d0ac updated the block layer to auto-fragment any I/O to fit within device boundaries. Additionally, when using a minimum alignment of 4k, we want to ensure the block layer does proper read-modify-write rather than requesting I/O on a slice of a sector. Let's enforce that

[Qemu-devel] [PATCH v9 12/13] blkdebug: Add ability to override unmap geometries

Make it easier to simulate various unusual hardware setups (for example, recent commits 3482b9b and b8d0a98 affect the Dell Equallogic iSCSI with its 15M preferred and maximum unmap and write zero sizing, or b2f95fe deals with the Linux loopback block device having a max_transfer of 64k), by

[Qemu-devel] [PATCH v9 10/13] blkdebug: Add pass-through write_zero and discard support

In order to test the effects of artificial geometry constraints on operations like write zero or discard, we first need blkdebug to manage these actions. It also allows us to inject errors on those operations, just like we can for read/write/flush. We can also test the contract promised by the

[Qemu-devel] [PATCH v9 06/13] qcow2: Assert that cluster operations are aligned

We already audited (in commit 0c1bd469) that qcow2_discard_clusters() is only passed cluster-aligned start values; but we can further tighten the assertion that the only unaligned end value is at EOF. Recent commits have taken advantage of an unaligned tail cluster, for both discard and write

[Qemu-devel] [PATCH v9 09/13] blkdebug: Refactor error injection

Rather than repeat the logic at each caller of checking if a Rule exists that warrants an error injection, fold that logic into inject_error(); and rename it to rule_check() for legibility. This will help the next patch, which adds two more callers that need to check rules for the potential of

[Qemu-devel] [PATCH v9 05/13] qcow2: Optimize write zero of unaligned tail cluster

We've already improved discards to operate efficiently on the tail of an unaligned qcow2 image; it's time to make a similar improvement to write zeroes. The special case is only valid at the tail cluster of a file, where we must recognize that any sectors beyond the image end would implicitly

[Qemu-devel] [PATCH v9 11/13] blkdebug: Simplify override logic

Rather than store into a local variable, then copy to the struct if the value is valid, then reporting errors otherwise, it is simpler to just store into the struct and report errors if the value is invalid. This however requires that the struct store a 64-bit number, rather than a narrower type.

[Qemu-devel] [PATCH v9 02/13] iotests: Add test 179 to cover write zeroes with unmap

No tests were covering write zeroes with unmap. Additionally, I wanted to prove that my patch to optimize write zeroes for compat=0.10 images actually had an impact; for that, run: ./check -qcow2 -o compat=0.10 179 Writing the test to work correctly for both old and new qcow2 images is a bit

[Qemu-devel] [PATCH v9 04/13] qemu-io: Switch 'map' output to byte-based reporting

Mixing byte offset and sector allocation counts is a bit confusing. Also, reporting n/m sectors, where m decreases according to the remaining size of the file, isn't really adding any useful information. Update the output to use byte counts, and adjust the affected tests (./check -qcow2 102,

[Qemu-devel] [PATCH v9 01/13] qcow2: Unallocate unmapped zero clusters if no backing file

'qemu-img map' already coalesces information about unallocated clusters (those with status 0) and pure zero clusters (those with status BDRV_BLOCK_ZERO and no offset). Furthermore, all qcow2 images with no backing file already report all unallocated clusters (in the preallocation sense of

[Qemu-devel] [PATCH for-2.10 v9 00/13] add blkdebug tests

Available as a tag at: git fetch git://repo.or.cz/qemu/ericb.git nbd-blkdebug-v9 Prerequisite: Max's block-next tree: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg01298.html v6 was: https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg01562.html v7 and v8 were the first half of

Re: [Qemu-devel] [PATCH for-2.10 01/19] crypto: cipher: introduce context free function

On 2017/4/10 23:01, Eric Blake wrote: > On 04/10/2017 03:59 AM, Longpeng(Mike) wrote: >> Refactors the qcrypto_cipher_free(), splits it into two parts. One >> is gcrypt/nettle__cipher_free_ctx() to free the special context. > > Your mail forgot to include 'In-Reply-To:' and 'References:'

Re: [Qemu-devel] [PATCH]Enable kvmvapic only when host doesn't support VAPIC capability in KVM mode

> I think we shouldn't read it like that. It seems that KVM is always > returning the VAPIC capability except when the CPU is providing a > special acceleration [0]. > > I would say you can't really refer yourself at this bit to enable or > not kvmapic in QEMU. > > Does that make sense? > >

[Qemu-devel] [PATCH v2 1/5] cadence_gem: Read the correct queue descriptor

Read the correct descriptor instead of hardcoding the first (q=0). Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/net/cadence_gem.c | 4 ++-- 1 file changed, 2

[Qemu-devel] [PATCH v2 4/5] cadence_gem: Make the revision a property

Expose the Cadence GEM revision as a property. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/net/cadence_gem.c | 6 +- include/hw/net/cadence_gem.h | 1

[Qemu-devel] [PATCH v2 2/5] cadence_gem: Correct the multi-queue can rx logic

Correct the buffer descriptor busy logic to work correctly when using multiple queues. Signed-off-by: Alistair Francis --- hw/net/cadence_gem.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/net/cadence_gem.c

[Qemu-devel] [PATCH v2 5/5] xlnx-zynqmp: Set the Cadence GEM revision

Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- hw/arm/xlnx-zynqmp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index bc4e66b..e41b6fe 100644 ---

[Qemu-devel] [PATCH v2 3/5] cadence_gem: Correct the interupt logic

This patch fixes two mistakes in the interrupt logic. First we only trigger single-queue or multi-queue interrupts if the status register is set. This logic was already used for non multi-queue interrupts but it also applies to multi-queue interrupts. Secondly we need to lower the interrupts if

[Qemu-devel] [PATCH v2 0/5] Improve the Cadence GEM multi-queue support

Improve the Cadence GEM multi-queue support. This fixes a few bugs which were hanging around from the initial implementation. V2: - Fix up the interrupt updating logic and consolidate all the updates to a single function. - Improve the debug print information Alistair Francis (5):

Re: [Qemu-devel] [PATCH v1 3/5] cadence_gem: Only trigger interrupts if the status register is set

On Mon, Apr 10, 2017 at 5:44 AM, Peter Maydell wrote: > On 5 April 2017 at 00:40, Alistair Francis > wrote: >> Only trigger multi-queue GEM interrupts if the interrupt status register >> is set. This logic was already used for non

[Qemu-devel] [Bug 1681439] Re: qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync: Assertion `s->bus->dma->aiocb == NULL' failed.

** Changed in: qemu Assignee: (unassigned) => John Snow (jnsnow) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1681439 Title: qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync:

Re: [Qemu-devel] [PATCH fix for-2.9] cpus: fix wrong define name

On Mon, 10 Apr 2017 10:49:12 -0700 Richard Henderson wrote: > On 04/10/2017 10:44 AM, Greg Kurz wrote: > > On Mon, 10 Apr 2017 18:29:57 +0100 > > Peter Maydell wrote: > > > >> On 10 April 2017 at 18:26, Richard Henderson wrote:

Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name

On 02/17/2017 02:51 PM, Dr. David Alan Gilbert wrote: > * Fam Zheng (f...@redhat.com) wrote: >> On Fri, 02/17 16:36, Vladimir Sementsov-Ogievskiy wrote: >>> 17.02.2017 15:21, Fam Zheng wrote: On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: > 16.02.2017 16:48, Fam Zheng wrote:

[Qemu-devel] [Bug 1681439] Re: qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync: Assertion `s->bus->dma->aiocb == NULL' failed.

I don't think the assert you are talking about in the subject is added by 9972354856. That assertion was added by 86698a12f and has been present since QEMU 2.6. I don't see the relation immediately to AioContext patches. Is this only during boot/shutdown? If not, it looks like there might be some

Re: [Qemu-devel] [PATCH v2 9/9] tpm: Added support for TPM emulator

On 04/10/2017 12:14 PM, Stefan Berger wrote: On 04/10/2017 06:07 AM, Patrick Ohly wrote: On Mon, 2017-04-10 at 09:54 +, Marc-André Lureau wrote: By "public protocol", I mean qemu communication with a foreign project, swtpm or other. If qemu grows new needs, or if the protocol is found

Re: [Qemu-devel] [PATCH v1 2/5] cadence_gem: Correct the multi-queue can rx logic

On Mon, Apr 10, 2017 at 5:37 AM, Peter Maydell wrote: > On 5 April 2017 at 00:40, Alistair Francis > wrote: >> Correct the buffer descriptor busy logic to work correctly when using >> multiple queues. >> >> Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH v3 1/2] hw/acpi-defs: replace leading X with x_ in FADT field names

On Mon, Apr 10, 2017 at 05:28:44PM +0200, Laszlo Ersek wrote: > On 04/10/17 17:03, Ard Biesheuvel wrote: > > At the request of Michael, replace the leading capital X in the FADT > > field name Xfacs and Xdsdt with lower case x + underscore. > > > > Cc: Michael S. Tsirkin > >

[Qemu-devel] quick question about live VM migration

Hello, A very basic question... In a vanilla KVM env. (i.e. non open stack etc) when a VM is live migrated to another host does the MAC address of the vNICs and the DHCP IP address for these interfaces remain the same ? Thought the answer was a yes as the goal is to minimize disruption to the

Re: [Qemu-devel] [RFC/BUG] xen-mapcache: buggy invalidate map cache?

On Mon, 10 Apr 2017, Stefano Stabellini wrote: > On Mon, 10 Apr 2017, hrg wrote: > > On Sun, Apr 9, 2017 at 11:55 PM, hrg wrote: > > > On Sun, Apr 9, 2017 at 11:52 PM, hrg wrote: > > >> Hi, > > >> > > >> In xen_map_cache_unlocked(), map to guest memory

Re: [Qemu-devel] [PATCH 18/21] pci: Use the new pci_can_add_device() to enforce devfn_min/max

On Wed, Apr 05, 2017 at 02:41:43PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > This adds a devfn_max field to PCIBus and adds a pci_can_add_device() > function which, if no "addr" (aka devfn) is specified, will tell whether > there is any slot free

Re: [Qemu-devel] [PATCH 09/10] blockjob: reorganize block_job_completed_txn_abort

On 03/23/2017 01:39 PM, Paolo Bonzini wrote: > This splits the part that touches job states from the part that invokes > callbacks. It will be a bit simpler to understand once job states will > be protected by a different mutex than the AioContext lock. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [RFC/BUG] xen-mapcache: buggy invalidate map cache?

On Mon, 10 Apr 2017, hrg wrote: > On Sun, Apr 9, 2017 at 11:55 PM, hrg wrote: > > On Sun, Apr 9, 2017 at 11:52 PM, hrg wrote: > >> Hi, > >> > >> In xen_map_cache_unlocked(), map to guest memory maybe in entry->next > >> instead of first level entry (if

Re: [Qemu-devel] [PATCH v2 6/9] arm: Abstract out "are we singlestepping" test to utility function

On 04/10/2017 02:13 PM, Peter Maydell wrote: We now test for "are we singlestepping" in several places and it's not a trivial check because we need to care about both architectural singlestep and QEMU gdbstub singlestep. We're also about to add another place that needs to make this check, so

Re: [Qemu-devel] [PATCH fix for-2.9] cpus: fix wrong define name

On 04/10/2017 10:44 AM, Greg Kurz wrote: On Mon, 10 Apr 2017 18:29:57 +0100 Peter Maydell wrote: On 10 April 2017 at 18:26, Richard Henderson wrote: On 04/09/2017 11:06 PM, Nikunj A Dadhania wrote: --- a/cpus.c +++ b/cpus.c @@ -202,7 +202,7 @@

Re: [Qemu-devel] [PATCH fix for-2.9] cpus: fix wrong define name

On Mon, 10 Apr 2017 18:29:57 +0100 Peter Maydell wrote: > On 10 April 2017 at 18:26, Richard Henderson wrote: > > On 04/09/2017 11:06 PM, Nikunj A Dadhania wrote: > >> --- a/cpus.c > >> +++ b/cpus.c > >> @@ -202,7 +202,7 @@ void

[Qemu-devel] [PATCH v2 3/9] arm: Factor out "generate right kind of step exception"

We currently have two places that do: if (dc->ss_active) { gen_step_complete_exception(dc); } else { gen_exception_internal(EXCP_DEBUG); } Factor this out into its own function, as we're about to add a third place that needs the

[Qemu-devel] [PATCH v2 9/9] arm: Remove workarounds for old M-profile exception return implementation

Now that we've rewritten M-profile exception return so that the magic PC values are not visible to other parts of QEMU, we can delete the special casing of them elsewhere. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH v2 6/9] arm: Abstract out "are we singlestepping" test to utility function

We now test for "are we singlestepping" in several places and it's not a trivial check because we need to care about both architectural singlestep and QEMU gdbstub singlestep. We're also about to add another place that needs to make this check, so pull the condition out into a function.

[Qemu-devel] [PATCH v2 5/9] arm: Move condition-failed codepath generation out of if()

Move the code to generate the "condition failed" instruction codepath out of the if (singlestepping) {} else {}. This will allow adding support for handling a new is_jmp type which can't be neatly split into "singlestepping case" versus "not singlestepping case". Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH v2 8/9] arm: Implement M profile exception return properly

On M profile, return from exceptions happen when code in Handler mode executes one of the following function call return instructions: * POP or LDM which loads the PC * LDR to PC * BX register and the new PC value is 0xFFxx. QEMU tries to implement this by not treating the instruction

[Qemu-devel] [PATCH v2 1/9] arm: Don't implement BXJ on M-profile CPUs

For M-profile CPUs, the BXJ instruction does not exist at all, and the encoding should always UNDEF. We were accidentally implementing it to behave like A-profile BXJ; correct the error. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v2 4/9] arm: Move gen_set_condexec() and gen_set_pc_im() up in the file

Move the utility routines gen_set_condexec() and gen_set_pc_im() up in the file, as we will want to use them from a function placed earlier in the file than their current location. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH v2 2/9] arm: Thumb shift operations should not permit interworking branches

In Thumb mode, the only instructions which can cause an interworking branch by writing the PC are BLX, BX, BXJ, LDR, POP and LDM. Unlike ARM mode, data processing instructions which target the PC do not cause interworking branches. When we added support for doing interworking branches on writes

Re: [Qemu-devel] [PATCH fix for-2.9] cpus: fix wrong define name

On 04/10/2017 10:29 AM, Peter Maydell wrote: On 10 April 2017 at 18:26, Richard Henderson wrote: On 04/09/2017 11:06 PM, Nikunj A Dadhania wrote: --- a/cpus.c +++ b/cpus.c @@ -202,7 +202,7 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp) } else if

Re: [Qemu-devel] [PATCH fix for-2.9] cpus: fix wrong define name

On 10 April 2017 at 18:26, Richard Henderson wrote: > On 04/09/2017 11:06 PM, Nikunj A Dadhania wrote: >> --- a/cpus.c >> +++ b/cpus.c >> @@ -202,7 +202,7 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp) >> } else if (use_icount) { >>

Re: [Qemu-devel] [PATCH fix for-2.9] cpus: fix wrong define name

On 04/09/2017 11:06 PM, Nikunj A Dadhania wrote: While the configure script generates TARGET_SUPPORTS_MTTCG define, one of the define is cpus.c is checking wrong name: TARGET_SUPPORT_MTTCG Signed-off-by: Nikunj A Dadhania --- cpus.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support

> From: Andrew Baumann > Sent: Monday, 10 April 2017 10:05 > > From: Omar Rizwan [mailto:omar.riz...@gmail.com] > > Sent: Friday, 7 April 2017 23:13 > > I can't easily find documentation for that 0x4000 memory mapping, > > which I figured I'd keep in; should it just be removed from bcm2835? >

Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support

> From: Omar Rizwan [mailto:omar.riz...@gmail.com] > Sent: Friday, 7 April 2017 23:13 > On Fri, Apr 7, 2017 at 10:57 PM Andrew Baumann > wrote: > > > From: Omar Rizwan [mailto:omar.riz...@gmail.com] > > > Sent: Friday, 7 April 2017 22:43 > > Did you do any testing

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC v1 0/3] Enable MTTCG on PPC64

Cédric Le Goater writes: > On 04/07/2017 08:07 AM, Cédric Le Goater wrote: >> On 04/07/2017 07:24 AM, Nikunj A Dadhania wrote: >>> Cédric Le Goater writes: >>> Hello Nikunj, On 04/06/2017 12:22 PM, Nikunj A Dadhania wrote: > The series enables

[Qemu-devel] [PATCH v2 0/9] arm: Implement M profile exception return properly

On M profile, return from exceptions happen when code in Handler mode executes one of the following function call return instructions: * POP or LDM which loads the PC * LDR to PC * BX register and the new PC value is 0xFFxx. QEMU tries to implement this by not treating the

[Qemu-devel] [PATCH v2 7/9] arm: Track M profile handler mode state in TB flags

For M profile exception-return handling we'd like to generate different code for some instructions depending on whether we are in Handler mode or Thread mode. This isn't the same as "are we privileged or user", so we need an extra bit in the TB flags to distinguish. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC v1 0/3] Enable MTTCG on PPC64

Cédric Le Goater writes: > On 04/10/2017 06:44 PM, Nikunj A Dadhania wrote: >> Cédric Le Goater writes: >> >>> On 04/07/2017 08:07 AM, Cédric Le Goater wrote: On 04/07/2017 07:24 AM, Nikunj A Dadhania wrote: > Cédric Le Goater writes:

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC v1 0/3] Enable MTTCG on PPC64

On 04/10/2017 06:44 PM, Nikunj A Dadhania wrote: > Cédric Le Goater writes: > >> On 04/07/2017 08:07 AM, Cédric Le Goater wrote: >>> On 04/07/2017 07:24 AM, Nikunj A Dadhania wrote: Cédric Le Goater writes: > Hello Nikunj, > > On 04/06/2017

Re: [Qemu-devel] [Qemu-arm] [PATCH 5/7] arm: Move condition-failed codepath generation out of if()

On 10 April 2017 at 14:22, Philippe Mathieu-Daudé wrote: > I'm custom to think "let's change that and think how to protect the code to > help the next one who will modify it" and wonder if it isn't safer to > define: > > const bool singlestepping; > > singlestepping =

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC v1 0/3] Enable MTTCG on PPC64

Cédric Le Goater writes: > On 04/07/2017 08:07 AM, Cédric Le Goater wrote: >> On 04/07/2017 07:24 AM, Nikunj A Dadhania wrote: >>> Cédric Le Goater writes: >>> Hello Nikunj, On 04/06/2017 12:22 PM, Nikunj A Dadhania wrote: > The series enables

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC v1 0/3] Enable MTTCG on PPC64

On 04/07/2017 08:07 AM, Cédric Le Goater wrote: > On 04/07/2017 07:24 AM, Nikunj A Dadhania wrote: >> Cédric Le Goater writes: >> >>> Hello Nikunj, >>> >>> On 04/06/2017 12:22 PM, Nikunj A Dadhania wrote: The series enables Multi-Threaded TCG on PPC64 Patch 01: Use

Re: [Qemu-devel] Dual userfaultfd behavior

Hello, On 03/18/2017 02:27 AM, Mike Kravetz wrote: On 03/15/2017 06:47 AM, Alexey Perevalov wrote: Hi Andrea, thank you for so perfect design description, the main question who will do RFC patches, you or Mike or if you not against I could try. Sorry for not replying sooner, I have been

Re: [Qemu-devel] [Qemu-arm] [PATCH 6/7] arm: Implement M profile exception return properly

On 10 April 2017 at 11:39, Peter Maydell wrote: > On M profile, return from exceptions happen when privileged code > executes one of the following function call return instructions: > * POP or LDM which loads the PC > * LDR to PC > * BX register > and the new PC value

[Qemu-devel] [Bug 1670509] Re: sgabios outputs incorrect video modes

That patch is wrong. The correct patch has been submitted and checked on the QEMU mailing lists (http://patchwork.ozlabs.org/patch/737446/). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1670509

Re: [Qemu-devel] [PATCH v2 9/9] tpm: Added support for TPM emulator

On 04/10/2017 03:08 AM, Amarnath Valluri wrote: On 07.04.2017 17:41, Daniel P. Berrange wrote: On Fri, Apr 07, 2017 at 05:30:31PM +0300, Amarnath Valluri wrote: This change introduces a new TPM backend driver that can communicate with swtpm(software TPM emulator) using unix domain socket

Re: [Qemu-devel] [PATCH v2 9/9] tpm: Added support for TPM emulator

On 04/10/2017 06:07 AM, Patrick Ohly wrote: On Mon, 2017-04-10 at 09:54 +, Marc-André Lureau wrote: By "public protocol", I mean qemu communication with a foreign project, swtpm or other. If qemu grows new needs, or if the protocol is found limited or buggy, it may change. Subtle

Re: [Qemu-devel] [PATCH 05/10] blockjob: separate monitor and blockjob APIs

On 04/08/2017 05:52 AM, Paolo Bonzini wrote: > > > On 08/04/2017 08:03, John Snow wrote: >> Looks clean, though it may be useful to do a few more things; >> >> - Demarcate what you think is the monitor API in this file > > It's already there: > > +/* > + * API for block job drivers and the

[Qemu-devel] [Bug 1681439] Re: qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync: Assertion `s->bus->dma->aiocb == NULL' failed.

Just to clarify: the issue appeared in 2.8.0, but it is still present in current master. Commit c2b6428d38 ("block: quiesce AioContext when detaching from it") does not solve this issue, even though it contains the following tag: Fixes: 99723548561978da8ef44cf804fb7912698f5d88 -- You

[Qemu-devel] [Bug 1681439] [NEW] qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync: Assertion `s->bus->dma->aiocb == NULL' failed.

Public bug reported: Since upgrading to QEMU 2.8.0, my Windows 7 64-bit virtual machines started crashing due to the assertion quoted in the summary failing. The assertion in question was added by commit 9972354856 ("block: add BDS field to count in-flight requests"). My tests show that setting

Re: [Qemu-devel] [PATCH v3 0/2] block: Quiesce old aio context during bdrv_set_aio_context

On Mon, Apr 10, 2017 at 10:26:34AM +0800, Fam Zheng wrote: > v3: Use bdrv_parent_drained_begin/end. [Kevin] > Do it before releasing new_context. [Stefan] > > Fam Zheng (2): > block: Make bdrv_parent_drained_begin/end public > block: Quiesce old aio context during bdrv_set_aio_context >

Re: [Qemu-devel] [PATCH v2 for-2.10 0/8] RBD reopen, read_only cleanup

On 04/07/2017 04:55 PM, Jeff Cody wrote: > Changes from v1: > > Patch 2: Has v1 patch 8 (do not blindly xset bs->read_only) squashed into it > (thanks Stefan) > COW -> "copy-on-read" (Thanks John) > Drop unneeded call in vvfat, and bypass enable_write_target (Stefan)

Re: [Qemu-devel] [PATCH v3] migration/block: use blk_pwrite_zeroes for each zero cluster

On Sun, Apr 09, 2017 at 08:37:40PM +0800, jemmy858...@gmail.com wrote: > From: Lidong Chen > > BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, > this maybe cause the qcow2 file size is bigger after migration. > This patch check each cluster, use

[Qemu-devel] ping RE: [PATCH v3] SGABIOS: fix wrong video attrs for int 10h, ah==13h

http://patchwork.ozlabs.org/patch/737446/ -Original Message- From: Laurent Vivier [mailto:lviv...@redhat.com] Sent: Friday, March 10, 2017 2:10 PM To: Robinson, Herbie ; qemu-devel@nongnu.org Cc: qemu-triv...@nongnu.org Subject: Re: [PATCH v3] SGABIOS: fix

Re: [Qemu-devel] [PATCH 20/21] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge

On Wed, Apr 05, 2017 at 02:41:45PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > This is a model of the PCIe host bridge found on Power8 chips, > including IOMMU support, PCIe root complex etc... > > This implementation doesn't emulate the EEH error

Re: [Qemu-devel] [PATCH 21/21] ppc/pnv: Create a default PCI layout

On Wed, Apr 05, 2017 at 02:41:46PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > This creates a legacy PCIe->PCI bridge under the PHB by default to which > a bunch of standard devices are attached. Currently: > > - VGA (as specified by -vga) > -

  1   2   3   >