[Qemu-devel] Help needed: Sparc 64, kernel panic

Hi All Has anyone experienced any kernel panics with the Sparc64 in 2.9-rc4? I dont seem to be able to run it right out of the box. Ill appreciate any kind of help Regards -H

Re: [Qemu-devel] [virtio-dev] Vhost-pci RFC2.0

On 04/19/2017 11:24 PM, Stefan Hajnoczi wrote: On Wed, Apr 19, 2017 at 11:42 AM, Wei Wang wrote: On 04/19/2017 05:57 PM, Stefan Hajnoczi wrote: On Wed, Apr 19, 2017 at 06:38:11AM +, Wang, Wei W wrote: We made some design changes to the original vhost-pci design, and

Re: [Qemu-devel] [PATCH v2 7/7] intel_iommu: support passthrough (PT)

On Thu, Apr 20, 2017 at 04:55:24AM +, Liu, Yi L wrote: [...] > > > In my previous RFC patchset of fault event reporting, I registered > > > fault notifier when there is a VFIO group attached to VFIO container > > > and used the address space to check whether vIOMMU is added. The > > >

Re: [Qemu-devel] What's the next QEMU version after 2.9 ? (or: when is a good point in time to get rid of old interfaces)

Hi, > > You can have two floppy drives, but they are hooked to the same > > Yes, I'm aware. > > I'm just saying here "Spec-wise" because you can have two controllers, > one at 0x3F0 and one at 0x370. Oh, ok. Wasn't aware of this detail. Can't remember to have ever seen a pc with more than

Re: [Qemu-devel] [PATCH 7/7] intel_iommu: support passthrough (PT)

On Thu, Apr 20, 2017 at 01:18:28PM +0800, Jason Wang wrote: > > > On 2017年04月18日 12:21, Peter Xu wrote: > >On Tue, Apr 18, 2017 at 12:00:13PM +0800, Jason Wang wrote: > >> > >>On 2017年04月18日 11:50, Peter Xu wrote: > >>>On Tue, Apr 18, 2017 at 11:23:35AM +0800, Jason Wang wrote: > On

Re: [Qemu-devel] [PATCH 7/7] intel_iommu: support passthrough (PT)

On 2017年04月18日 12:21, Peter Xu wrote: On Tue, Apr 18, 2017 at 12:00:13PM +0800, Jason Wang wrote: On 2017年04月18日 11:50, Peter Xu wrote: On Tue, Apr 18, 2017 at 11:23:35AM +0800, Jason Wang wrote: On 2017年04月17日 18:58, Peter Xu wrote: [...] +static void

Re: [Qemu-devel] [PATCH 02/15] colo-compare: implement the process of checkpoint

On 2017年04月18日 14:58, Hailiang Zhang wrote: On 2017/4/18 11:55, Jason Wang wrote: On 2017年04月17日 19:04, Hailiang Zhang wrote: Hi Jason, On 2017/4/14 14:38, Jason Wang wrote: On 2017年04月14日 14:22, Hailiang Zhang wrote: Hi Jason, On 2017/4/14 13:57, Jason Wang wrote: On 2017年02月22日

Re: [Qemu-devel] [RFC v2 3/6] pci: Rename and change signatures of pci_bus_new() & related functions

On Wed, Apr 19, 2017 at 09:50:01AM -0300, Eduardo Habkost wrote: > On Wed, Apr 19, 2017 at 09:41:42AM +0100, Peter Maydell wrote: > > On 18 April 2017 at 23:17, Eduardo Habkost wrote: > > > pci_bus_new*() and pci_register_bus() work only when the 'parent' > > > argument is a

Re: [Qemu-devel] [PATCH v2 7/7] intel_iommu: support passthrough (PT)

> -Original Message- > From: Peter Xu [mailto:pet...@redhat.com] > Sent: Thursday, April 20, 2017 11:04 AM > To: Lan, Tianyu > Cc: Liu, Yi L ; qemu-devel@nongnu.org; Michael S . Tsirkin > ; Jason Wang ; Marcel

[Qemu-devel] vhost-net - virtio - multiqueue - rx queue selection

Hi folks, I have a question regarding the algorithm used to select rx queue of the VM in the case of multiqueue virtio-net on KVM. Given a 4-tuple, how can we calculate the index of the receive queue that virtio-net is going pick for that flow? From some of the email threads in some of the

[Qemu-devel] [PATCH] COLO-compare: Add compare_lock aviod comparison conflict

When network traffic heavy, compare_pri_rs_finalize() and compare_sec_rs_finalize() have a chance to confilct. Both of them call colo_compare_connection() to compare packet, But during compare_pri_rs_finalize() comparison, have secondary packet come and call compare_sec_rs_finalize(), that packet

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

On Wed, Apr 19, 2017 at 10:26 PM, Eduardo Habkost wrote: > On Wed, Apr 19, 2017 at 06:03:01PM -0400, Pranith Kumar wrote: >> On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost wrote: >> > On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote: >> >>

[Qemu-devel] [PATCH] qemu-img: check bs_n when use old style option

From: Lidong Chen When use old style option like -o backing_file, img_convert continue run when bs_n > 1, this patch fix this bug. Signed-off-by: Lidong Chen --- qemu-img.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-img.c

[Qemu-devel] [PATCH] sheepdog: Set error when connection fails

Signed-off-by: Fam Zheng --- block/sheepdog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index fb9203e..7e889ee 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -608,6 +608,7 @@ static int connect_to_sdog(BDRVSheepdogState *s,

Re: [Qemu-devel] [PATCH RFC 3/3] qemu-io: Add --unsafe-read option

On Tue, 04/18 08:27, Eric Blake wrote: > On 03/13/2017 09:39 PM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > qemu-io.c | 28 +--- > > 1 file changed, 21 insertions(+), 7 deletions(-) > > > > @@ -108,6 +112,7 @@ static void open_help(void) >

Re: [Qemu-devel] [PATCH RFC 2/3] qemu-img: Add --unsafe-read option to subcommands

On Tue, 04/18 08:20, Eric Blake wrote: > bool, please. (Just because existing code is lousy with using an int > for a bool doesn't mean we should perpetuate it) OK, will fix. > > > > @@ -3033,6 +3085,9 @@ static int img_rebase(int argc, char **argv) > > case OPTION_IMAGE_OPTS: > >

Re: [Qemu-devel] [PATCH v2 7/7] intel_iommu: support passthrough (PT)

On Wed, Apr 19, 2017 at 07:13:47AM +, Liu, Yi L wrote: > Peter, > > Besides the gPA->hPA mapping, pt mode enabling requires some sanity check on > s->pt_supported. See comments inline. > > > -Original Message- > > From: Qemu-devel

Re: [Qemu-devel] [PATCH v2 7/7] intel_iommu: support passthrough (PT)

On Wed, Apr 19, 2017 at 03:27:52PM +0800, Lan Tianyu wrote: > Hi All: > Sorry for later response. > On 2017年04月18日 17:04, Liu, Yi L wrote: > >> -Original Message- > >> From: Peter Xu [mailto:pet...@redhat.com] > >> Sent: Tuesday, April 18, 2017 3:27 PM > >> To: Liu, Yi L

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

On Wed, Apr 19, 2017 at 06:03:01PM -0400, Pranith Kumar wrote: > On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost wrote: > > On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote: > >> On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost > >> wrote:

Re: [Qemu-devel] [PATCH 1/1] target/ppc: Fix emulated userspace access to USPRG3

On Thu, Apr 20, 2017 at 11:44:17AM +1000, Sam Bobroff wrote: > On a fully emulated Power8 system, user space is currently unable to > read from USPRG3 (SPR number 0x103) because it receives an illegal > instruction exception. > > However the ISA indicates that it should have read access (to the >

[Qemu-devel] [PATCH 1/1] target/ppc: Fix emulated userspace access to USPRG3

On a fully emulated Power8 system, user space is currently unable to read from USPRG3 (SPR number 0x103) because it receives an illegal instruction exception. However the ISA indicates that it should have read access (to the content of SPR 0x113, similar to some other registers with user space

Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

On 04/19/2017 05:36 PM, Alistair Francis wrote: > On Wed, Apr 19, 2017 at 3:22 PM, Eric Blake wrote: >> Libvirt would like to be able to distinguish between a SHUTDOWN >> event triggered solely by guest request and one triggered by a >> SIGTERM or other action on the host.

[Qemu-devel] ppc MAINTAINERS update needed

The sections for e500, mpc8544ds, and ppce500 all list Scott Wood as a co-maintainer, but I'm getting bounce emails for scottw...@freescale.com as an unknown address. What is the appropriate tweak needed to the MAINTAINERS file? -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [Qemu-devel] [PATCH] e500, book3s: mfspr 259: Register mapped/aliased SPRG3 user read

On Wed, Apr 19, 2017 at 06:48:22PM +0200, Bernhard Kaindl wrote: > This patch registers mfspr 259 for Book3S and e500 family cores > following this research: > > mfspr 259 provides read-only mapped user access to SPRG3(SPR 275) according > to: > > - PowerISA 2.02, Book III (documents

Re: [Qemu-devel] [PATCH v11 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Apr 19, 2017 at 9:27 AM, Stefan Hajnoczi wrote: > On Mon, Apr 03, 2017 at 08:48:08PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqnio.git >> >> Sample command

[Qemu-devel] [PATCH v3] iotests: 109: Filter out "len" of failed jobs

Mirror calculates job len from current I/O progress: s->common.len = s->common.offset + (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE; The final "len" of a failed mirror job in iotests 109 depends on the subtle timing of the completion of read and write issued in the

Re: [Qemu-devel] [PATCH v2] iotests: 109: Filter out "len" of failed jobs

On Wed, 04/19 19:13, Kevin Wolf wrote: > Am 19.04.2017 um 11:17 hat Fam Zheng geschrieben: > > Mirror calculates job len from current I/O progress: > > > > s->common.len = s->common.offset + > > (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE; > > > > The final "len" of a

Re: [Qemu-devel] [PATCH v2] iotests: 109: Filter out "len" of failed jobs

On Wed, 04/19 18:38, Paolo Bonzini wrote: > > > On 19/04/2017 11:17, Fam Zheng wrote: > > Mirror calculates job len from current I/O progress: > > > > s->common.len = s->common.offset + > > (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE; > > > > The final "len" of a

Re: [Qemu-devel] [PATCH v3 3/6] vmdk: New functions to assist allocating multiple clusters

On Wed, 04/19 15:13, Ashijeet Acharya wrote: > > In the second iteration, remaining is always 0 because of "remaining -= > > n_bytes". What's the point of the while loop? > > > I need the while loop in case if I truncate the bytes according to the L2 > table margins[scroll up to handle

Re: [Qemu-devel] [PATCH v3 4/6] vmdk: Rename get_cluster_offset() to vmdk_get_cluster_offset()

On Wed, 04/19 15:21, Ashijeet Acharya wrote: > On Wed, Apr 19, 2017 at 18:27 Fam Zheng wrote: > > > On Sat, 04/01 20:14, Ashijeet Acharya wrote: > > > Rename the existing get_cluster_offset() function to > > > vmdk_get_cluster_offset() and have it make use of the new > > >

Re: [Qemu-devel] Jailhouse on Ultrascale+ (ZCU102)

On Wed, Apr 19, 2017 at 11:02:21AM +0200, Jan Kiszka wrote: > On 2017-04-19 10:45, Peter Maydell wrote: > > On 19 April 2017 at 05:37, Jan Kiszka wrote: > >> On 2017-04-19 05:48, Constantin Petra wrote: > >>> So from some reason, under QEMU something is not in place, but what

Re: [Qemu-devel] What's the next QEMU version after 2.9 ? (or: when is a good point in time to get rid of old interfaces)

On 04/19/2017 06:15 AM, Gerd Hoffmann wrote: > Hi, > >>> There is -global, which is actually used by libvirt to configure >>> built-in floppy devices. But as the name suggests it sets properties >>> globally, i.e. for all instances. Which works in this specific use >>> case, as there can be

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img: improve convert_iteration_sectors()

On 04/07/2017 07:34 AM, Vladimir Sementsov-Ogievskiy wrote: > Do not do extra call to _get_block_status() > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > Also, I'm not sure about last line: > s->status = s->target_has_backing ? BLK_BACKING_FILE : BLK_DATA;

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

On Wed, 19 Apr 2017, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 18 April 2017 18:41 > > To: Paul Durrant > > Cc: 'Stefano Stabellini' ; qemu-devel@nongnu.org; > >

Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

On Wed, Apr 19, 2017 at 3:22 PM, Eric Blake wrote: > Libvirt would like to be able to distinguish between a SHUTDOWN > event triggered solely by guest request and one triggered by a > SIGTERM or other action on the host. qemu_kill_report() is > already able to tell whether a

[Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

Libvirt would like to be able to distinguish between a SHUTDOWN event triggered solely by guest request and one triggered by a SIGTERM or other action on the host. qemu_kill_report() is already able to tell whether a shutdown was triggered by a host signal (but NOT by a host UI event, such as

Re: [Qemu-devel] [PATCH 49/59] ram: Remember last_page instead of last_offset

Hi Juan, On 04/19/2017 05:59 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela I think you missed Dave's Reviewed-by (he sent April 7) "Reviewed-by: Dr. David Alan Gilbert " -- Improve comment Fix typo ^ remove? --- migration/ram.c | 14

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost wrote: > On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote: >> On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost wrote: >> > On Wed, Apr 19, 2017 at 04:16:53PM -0400, Pranith Kumar wrote: >> >>

Re: [Qemu-devel] [PATCH 00/59] RAMState + qdev

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170419205923.8808-1-quint...@redhat.com Subject: [Qemu-devel] [PATCH 00/59] RAMState + qdev === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

[Qemu-devel] [PATCH v3] Split migration bitmaps by ramblock

Hi I messed up previous submission and sent the wrong patch. - This verios is a rebase on top of the ramstate series - Fixed the problem with postcopy Important bit is this one: -pds->start_list[pds->cur_entry] = (start - pds->offset) * tp_size; +pds->start_list[pds->cur_entry] =

[Qemu-devel] [PATCH 56/59] qdev: Export qdev_hot_removed

I need to move qdev_unplug to qdev-monitor in the following patch, and it needs access to this variable. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: zhanghailiang --- hw/core/qdev.c | 2 +-

[Qemu-devel] [PATCH 59/59] ram: Remove migration_bitmap_extend()

We have disabled memory hotplug, so we don't need to handle migration_bitamp there. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: zhanghailiang --- exec.c | 1 -

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote: > On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost wrote: > > On Wed, Apr 19, 2017 at 04:16:53PM -0400, Pranith Kumar wrote: > >> On Wed, Apr 19, 2017 at 4:13 PM, Eduardo Habkost > >> wrote:

[Qemu-devel] [PATCH 51/59] ram: Use ramblock and page offset instead of absolute offset

This removes the needto pass also the absolute offset. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 67 - 1 file changed, 28 insertions(+), 39

Re: [Qemu-devel] [Qemu-block] [PATCH 16/17] block: Make bdrv_is_allocated() byte-based

On 04/19/2017 05:12 PM, Eric Blake wrote: > On 04/19/2017 03:32 PM, John Snow wrote: > >>> @@ -279,9 +280,9 @@ static int mig_save_device_bulk(QEMUFile *f, >>> BlkMigDevState *bmds) >>> /* Skip unallocated sectors; intentionally treats failure as >>> * an allocated sector */

[Qemu-devel] [PATCH 49/59] ram: Remember last_page instead of last_offset

Signed-off-by: Juan Quintela -- Improve comment Fix typo Signed-off-by: Juan Quintela --- migration/ram.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 52ab14b..5b2045d

[Qemu-devel] [PATCH] ram: Split dirty bitmap by RAMBlock

Both the ram bitmap and the unsent bitmap are split by RAMBlock. Signed-off-by: Juan Quintela --- include/exec/ram_addr.h | 13 ++- include/migration/postcopy-ram.h | 3 - migration/postcopy-ram.c | 5 +- migration/ram.c | 215

[Qemu-devel] [PATCH 48/59] ram: Use page number instead of an address for the bitmap operations

We use an unsigned long for the page number. Notice that our bitmaps already got that for the index, so we have that limit. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- rename page to page_abs everywhere. fix trace types for

[Qemu-devel] [PATCH 57/59] qdev: Move qdev_unplug() to qdev-monitor.c

It is not used by linux-user, otherwise I need to to create one stub for migration_is_idle() on following patch. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: zhanghailiang Reviewed-by: Markus

[Qemu-devel] [PATCH 47/59] ram: reorganize last_sent_block

We were setting it far away of when we changed it. Now everything is done inside save_page_header. Once there, reorganize code to pass RAMState. We also set CONTINUE flag in a single place. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH 58/59] migration: Disable hotplug/unplug during migration

Until we have reviewed what can/can't be hotplugged during migration, disable it. We can enable it later for the things that we know that work. For instance, memory hotplug during postcopy doesn't work currently. Signed-off-by: Juan Quintela Reviewed-by: zhanghailiang

[Qemu-devel] [PATCH 54/59] migration: Remove MigrationState parameter from migration_is_idle()

Only user don't have a MigrationState handly. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 2 +- migration/migration.c | 8 +++- 2 files changed, 4 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH 46/59] ram: ram_discard_range() don't use the mis parameter

Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 3 +-- migration/postcopy-ram.c | 6 ++ migration/ram.c | 9 +++-- migration/savevm.c| 3 +-- 4 files changed, 7 insertions(+),

[Qemu-devel] [PATCH 55/59] qdev: qdev_hotplug is really a bool

Signed-off-by: Juan Quintela Reviewed-by: zhanghailiang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- hw/core/qdev.c | 4 ++-- include/hw/qdev-core.h | 2 +- 2 files changed, 3

[Qemu-devel] [PATCH 50/59] ram: Change offset field in PageSearchStatus to page

We are moving everything to work on pages, not addresses. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 51 ++- 1 file changed, 26 insertions(+), 25 deletions(-)

[Qemu-devel] [PATCH 44/59] ram: Add page-size to output in 'info migrate'

From: Chao Fan The number of dirty pages is output in 'pages' in the command 'info migrate', so add page-size to calculate the number of dirty pages in bytes. Signed-off-by: Chao Fan Signed-off-by: Li Zhijian

[Qemu-devel] [PATCH 52/59] ram: rename last_ram_offset() last_ram_pages()

We always use it as pages anyways. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- exec.c | 6 +++--- include/exec/ram_addr.h | 2 +- migration/ram.c | 11 +-- 3 files changed, 9 insertions(+), 10

[Qemu-devel] [PATCH 43/59] ram: Rename qemu_target_page_bits() to qemu_target_page_size()

It was used as a size in all cases except one. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- exec.c | 4 ++-- include/sysemu/sysemu.h | 2 +- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 8

[Qemu-devel] [PATCH 39/59] ram: Move QEMUFile into RAMState

We receive the file from save_live operations and we don't use it until 3 or 4 levels of calls down. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 84 + 1

[Qemu-devel] [PATCH 53/59] ram: Use RAMBitmap type for coherence

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index f972882..2af8080 100644 --- a/migration/ram.c +++

[Qemu-devel] [PATCH 42/59] ram: We don't need MigrationState parameter anymore

Remove it from callers and callees. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff

[Qemu-devel] [PATCH 40/59] ram: Remove compression_switch and inline its logic

We can calculate its value, so we don't create a variable for it. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- After Peter and Dave review, I dropped the variable and just inlined the condition. Fix typo Signed-off-by: Juan

[Qemu-devel] [PATCH 41/59] migration: Remove MigrationState from migration_in_postcopy

We need to call for the migrate_get_current() in more that half of the uses, so call that inside. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/migration/migration.h | 2 +-

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost wrote: > On Wed, Apr 19, 2017 at 04:16:53PM -0400, Pranith Kumar wrote: >> On Wed, Apr 19, 2017 at 4:13 PM, Eduardo Habkost wrote: >> > On Wed, Apr 19, 2017 at 04:00:49PM -0400, Pranith Kumar wrote: >> >>

[Qemu-devel] [PATCH 36/59] ram: Move dirty_pages_rate to RAMState

Treat it like the rest of ram stats counters. Export its value the same way. As an added bonus, no more MigrationState used in migration_bitmap_sync(); Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu

[Qemu-devel] [PATCH 33/59] ram: Move src_page_req* to RAMState

This are the last postcopy fields still at MigrationState. Once there Move MigrationSrcPageRequest to ram.c and remove MigrationState parameters where appropiate. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 17

[Qemu-devel] [PATCH 38/59] ram: Add QEMUFile to RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index b9f415c..62b44cf 100644 ---

[Qemu-devel] [PATCH 35/59] ram: Remove dirty_bytes_rate

It can be recalculated from dirty_pages_rate. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Dave was the one that reviewed it O:-) Signed-off-by: Juan Quintela ---

[Qemu-devel] [PATCH 31/59] ram: Remove ram_save_remaining

Just unfold it. Move ram_bytes_remaining() with the rest of exported functions. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 19 +++ 1 file changed, 7

[Qemu-devel] [PATCH 34/59] ram: Create ram_dirty_sync_count()

This is a ram field that was inside MigrationState. Move it to RAMState and make it the same that the other ram stats. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 2 +- migration/migration.c | 3 +--

Re: [Qemu-devel] [RFC v2 3/6] pci: Rename and change signatures of pci_bus_new() & related functions

On Wed, Apr 19, 2017 at 09:41:19PM +0300, Marcel Apfelbaum wrote: > On 04/19/2017 03:05 PM, Cornelia Huck wrote: > > On Tue, 18 Apr 2017 22:42:07 -0300 > > Eduardo Habkost wrote: > > > > > On Wed, Apr 19, 2017 at 10:29:26AM +1000, David Gibson wrote: > > > > On Tue, Apr 18,

[Qemu-devel] [PATCH 29/59] ram: Move bytes_transferred into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PATCH 25/59] ram: Move migration_dirty_pages to RAMState

Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/ram.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 88392e4..71f8ef3 100644 ---

[Qemu-devel] [PATCH 32/59] ram: Move last_req_rb to RAMState

It was on MigrationState when it is only used inside ram.c for postcopy. Problem is that we need to access it without being able to pass it RAMState directly. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 2 --

Re: [Qemu-devel] [Qemu-block] [PATCH 16/17] block: Make bdrv_is_allocated() byte-based

On 04/19/2017 03:32 PM, John Snow wrote: >> @@ -279,9 +280,9 @@ static int mig_save_device_bulk(QEMUFile *f, >> BlkMigDevState *bmds) >> /* Skip unallocated sectors; intentionally treats failure as >> * an allocated sector */ >> while (cur_sector < total_sectors && >>

[Qemu-devel] [PATCH 28/59] ram: Move migration_bitmap_rcu into RAMState

Once there, rename the type to be shorter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 86 +++-- 1 file changed, 47

[Qemu-devel] [PATCH 22/59] ram: Move xbzrle_cache_miss into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH 26/59] ram: Everything was init to zero, so use memset

And then init only things that are not zero by default. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 25 +++-- 1 file changed, 3 insertions(+), 22

[Qemu-devel] [PATCH 45/59] ram: Pass RAMBlock to bitmap_sync

We change the meaning of start to be the offset from the beggining of the block. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/exec/ram_addr.h | 2 ++ migration/ram.c | 8 2 files changed, 6

[Qemu-devel] [PATCH 23/59] ram: Move xbzrle_cache_miss_rate into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH 20/59] ram: Move xbzrle_bytes into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 3e500ae..4dc7869 100644 --- a/migration/ram.c +++

[Qemu-devel] [PATCH 24/59] ram: Move xbzrle_overflows into RAMState

Once there, remove the now unused AccountingInfo struct and var. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 21 + 1 file changed, 5 insertions(+),

[Qemu-devel] [PATCH 37/59] ram: Move postcopy_requests into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 6 ++ migration/migration.c | 5 ++--- migration/ram.c | 13 + 3 files changed, 13 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH 21/59] ram: Move xbzrle_pages into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Comment why we need bytes and pages Signed-off-by: Juan Quintela --- migration/ram.c | 11 +++ 1 file changed,

[Qemu-devel] [PATCH 19/59] ram: Move iterations into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/ram.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 85d66ea..3e500ae 100644 --- a/migration/ram.c +++

[Qemu-devel] [PATCH 18/59] ram: Remove norm_mig_bytes_transferred

Its value can be calculated by other exported. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 1 - migration/migration.c | 3 ++- migration/ram.c | 5 - 3 files changed, 2

[Qemu-devel] [PATCH 30/59] ram: Use the RAMState bytes_transferred parameter

Somewhere it was passed by reference, just use it from RAMState. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 75

[Qemu-devel] [PATCH 17/59] ram: Move norm_pages to RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PATCH 13/59] ram: Move iterations_prev into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- migration/ram.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PATCH 16/59] ram: Remove unused pages_skipped variable

For compatibility, we need to still send a value, but just specify it and comment the fact. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/migration/migration.h | 2 --

[Qemu-devel] [PATCH 27/59] ram: Move migration_bitmap_mutex into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH 15/59] ram: Remove unused dup_mig_bytes_transferred()

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/migration/migration.h | 1 - migration/ram.c | 5 - 2 files changed, 6 deletions(-) diff --git

[Qemu-devel] [PATCH 10/59] ram: Move num_dirty_pages_period into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c

[Qemu-devel] [PATCH 11/59] ram: Change num_dirty_pages_period type to uint64_t

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/exec/ram_addr.h | 2 +- migration/ram.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 09/59] ram: Change byte_xfer_{prev, now} type to uint64_t

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH 07/59] ram: Move start time into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Renamed start_time to time_last_bitmap_sync(peterx suggestion) Signed-off-by: Juan Quintela --- migration/ram.c | 20

[Qemu-devel] [PATCH 12/59] ram: Move xbzrle_cache_miss_prev into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- migration/ram.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c

[Qemu-devel] [PATCH 14/59] ram: Move dup_pages into RAMState

Once there rename it to its actual meaning, zero_pages. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 29 ++--- 1 file changed, 18 insertions(+),

[Qemu-devel] [PATCH 06/59] ram: Move bitmap_sync_count into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PATCH 08/59] ram: Move bytes_xfer_prev into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

  1   2   3   4   >