Re: [Qemu-devel] [PATCH v4 1/1] numa: equally distribute memory on nodes

2017-05-02 Thread Laurent Vivier
On 02/05/2017 22:09, Eduardo Habkost wrote: > On Tue, May 02, 2017 at 06:29:55PM +0200, Laurent Vivier wrote: > [...] >> diff --git a/numa.c b/numa.c >> index 6fc2393..750fd95 100644 >> --- a/numa.c >> +++ b/numa.c >> @@ -294,6 +294,42 @@ static void validate_numa_cpus(void) >> g_free(seen_cpu

Re: [Qemu-devel] [virtio-dev] [PATCH v18 0/2] virtio-crypto: virtio crypto device specification

2017-05-02 Thread Gonglei (Arei)
Hi Halil, Nice to see your feedback again :) > -Original Message- > From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Wednesday, May 03, 2017 5:55 AM > Subject: Re: [virtio-dev] [PATCH v18 0/2] virtio-crypto: virtio crypto device > specification > > > Hi Gonglei! > > I've st

Re: [Qemu-devel] [PATCH v3 1/4] Throttle: Create IOThrottle structure

2017-05-02 Thread Greg Kurz
s/Throttle/throttle On Tue, 2 May 2017 10:29:43 -0400 Pradeep Jagadeesh wrote: > This patchset introduces a new io throttle structure. This will be s/patchset/patch > used in both block and fsdev devices. > > Signed-off-by: Pradeep Jagadeesh > --- Reviewed-by: Greg Kurz > qapi/block-cor

Re: [Qemu-devel] Subject: [PATCH] target-ppc: Add global timer group A to open-pic.

2017-05-02 Thread David Gibson
On Tue, May 02, 2017 at 08:37:09PM -0500, alar...@ddci.com wrote: > David Gibson wrote on 04/25/2017 11:34:41 > PM: > > Thanks for the review David. I'll send an updated patch soon with all > your comments addressed and all other s/0/NULL or false/ as > appropriate and a better commit message.

Re: [Qemu-devel] [virtio-dev] Vhost-pci RFC2.0

2017-05-02 Thread Wei Wang
On 05/02/2017 08:48 PM, Stefan Hajnoczi wrote: On Thu, Apr 20, 2017 at 01:51:24PM +0800, Wei Wang wrote: On 04/19/2017 11:24 PM, Stefan Hajnoczi wrote: On Wed, Apr 19, 2017 at 11:42 AM, Wei Wang wrote: On 04/19/2017 05:57 PM, Stefan Hajnoczi wrote: On Wed, Apr 19, 2017 at 06:38:11AM +, W

Re: [Qemu-devel] [PATCH 0/5] Add qemu_vga.ndrv MacOS PPC VGA driver from QemuMacDrivers

2017-05-02 Thread David Gibson
On Tue, May 02, 2017 at 08:38:56AM +0100, Mark Cave-Ayland wrote: > On 02/05/17 02:50, David Gibson wrote: > > > On Mon, May 01, 2017 at 02:43:29PM +0100, Mark Cave-Ayland wrote: > >> Last year Ben posted an initial set of patches for OpenBIOS which provided > >> a > >> MacOS PPC VGA driver enabl

Re: [Qemu-devel] [PATCH qemu v5] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-05-02 Thread David Gibson
On Tue, May 02, 2017 at 06:25:50PM +0200, Cornelia Huck wrote: > On Sat, 29 Apr 2017 22:37:07 +1000 > Alexey Kardashevskiy wrote: > > > This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion > > as a parent. > > > > This moves IOMMU-related fields from MR to IOMMU MR. However to avo

Re: [Qemu-devel] [Qemu-devel RFC v3 1/5] msf2: Add Smartfusion2 System timer

2017-05-02 Thread sundeep subbaraya
Hi Alistair, On Wed, May 3, 2017 at 3:25 AM, Alistair Francis wrote: > On Fri, Apr 28, 2017 at 9:51 AM, Subbaraya Sundeep > wrote: >> Modelled System Timer in Microsemi's Smartfusion2 Soc. >> Timer has two 32bit down counters and two interrupts. >> >> Signed-off-by: Subbaraya Sundeep >> --- >>

Re: [Qemu-devel] [PATCH] maintainers: add maintainer for replay* files

2017-05-02 Thread Pavel Dovgalyuk
Indeed. I missed these ones. ⁣Отправлено с помощью BlueMail ​ На 2 Май 2017 г., 17:37, в 17:37, Stefan Hajnoczi написал:п>On Tue, May 02, 2017 at 09:16:49AM +0300, Pavel Dovgalyuk wrote: >> Updating MAINTAINERS to set Pavel Dovgalyuk as record/replay >maintainer. >> >> Signed-off-by: Pavel Dovg

Re: [Qemu-devel] [Qemu-block] [PATCH v3] migration/block:limit the time used for block migration

2017-05-02 Thread 858585 jemmy
On Mon, Apr 10, 2017 at 9:52 PM, Stefan Hajnoczi wrote: > On Sat, Apr 08, 2017 at 09:17:58PM +0800, 858585 jemmy wrote: >> On Fri, Apr 7, 2017 at 7:34 PM, Stefan Hajnoczi wrote: >> > On Fri, Apr 07, 2017 at 09:30:33AM +0800, 858585 jemmy wrote: >> >> On Thu, Apr 6, 2017 at 10:02 PM, Stefan Hajnoc

Re: [Qemu-devel] [PATCH v6 00/25] tcg cross-tb optimizations

2017-05-02 Thread Richard Henderson
On 05/02/2017 12:22 PM, Richard Henderson wrote: Changes since v5: ... * Alpha frontend patch rewritten; the former patch appears to drop clock interrupts, not exiting the kernel's idle loop. I never *really* figured out why, since both patches seem to annotate the same TBs in

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/5] hw/ppc: removing spapr_drc_detach_cb opaques

2017-05-02 Thread Bharata B Rao
On Tue, May 2, 2017 at 1:13 PM, Daniel Henrique Barboza < danie...@linux.vnet.ibm.com> wrote: > > > On 05/02/2017 12:40 AM, Bharata B Rao wrote: > > On Sun, Apr 30, 2017 at 10:55 PM, Daniel Henrique Barboza < > danie...@linux.vnet.ibm.com> wrote: > >> Following up the previous detach_cb change, th

Re: [Qemu-devel] [PATCH] hw/virtio: fix vhost user fails to startup when MQ

2017-05-02 Thread Yang, Zhiyong
Hi,Maxime: > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, May 2, 2017 8:23 PM > To: Yang, Zhiyong ; qemu-devel@nongnu.org > Cc: m...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] hw/virtio: fix vhost user fails to startup > when > MQ >

[Qemu-devel] [PATCH v2] target-ppc: Enable open-pic timers to count and generate interrupts

2017-05-02 Thread Aaron Larson
Previous QEMU open-pic implemented the 4 open-pic timers including all timer registers, but the timers did not "count" or generate any interrupts. The patch makes the timers both count and generate interrupts. The timer clock frequency is fixed at 100MHZ. Signed-off-by: Aaron Larson --- hw/in

Re: [Qemu-devel] [PATCH 0/2] VFIO: Make 8-byte accesses atomic

2017-05-02 Thread Alex Williamson
On Tue, 2 May 2017 23:41:01 -0300 jos...@linux.vnet.ibm.com wrote: > On Fri, Apr 21, 2017 at 12:06:15PM +0200, Paolo Bonzini wrote: > > > > > > On 20/04/2017 18:03, Alex Williamson wrote: > > > On Thu, 20 Apr 2017 00:19:23 -0700 > > > Richard Henderson wrote: > > > > > >> On 04/19/2017 12:

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

2017-05-02 Thread Zhang Chen
On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: Address Jason Wang's comments add vnet header length to SocketReadState. Instead of saying this, you can add "Suggested-by: Jason Wang " above your sign-off. OK. So we change net_fill_rstate() to read

Re: [Qemu-devel] [PATCH 0/2] VFIO: Make 8-byte accesses atomic

2017-05-02 Thread joserz
On Fri, Apr 21, 2017 at 12:06:15PM +0200, Paolo Bonzini wrote: > > > On 20/04/2017 18:03, Alex Williamson wrote: > > On Thu, 20 Apr 2017 00:19:23 -0700 > > Richard Henderson wrote: > > > >> On 04/19/2017 12:44 PM, Jose Ricardo Ziviani wrote: > >>> This patchset has two patches: > >>> [1] 8-byte

Re: [Qemu-devel] [PATCH v6 10/13] s390x/css: introduce and realize ccw-request callback

2017-05-02 Thread Dong Jia Shi
* Cornelia Huck [2017-05-02 18:04:07 +0200]: > On Tue, 2 May 2017 10:15:19 +0800 > Dong Jia Shi wrote: > > > * Auger Eric [2017-05-01 19:28:23 +0200]: > > > > > static void vfio_ccw_io_notifier_handler(void *opaque) > > > > { > > > > VFIOCCWDevice *vcdev = opaque; > > > > +struct c

Re: [Qemu-devel] [PATCH V3 04/10] net/filter-mirror.c: Add filter-mirror and filter-redirector vnet support.

2017-05-02 Thread Zhang Chen
On 05/02/2017 12:47 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: In this patch, we change the send packet format from struct {int size; const uint8_t buf[];} to {int size; int vnet_hdr_len; const uint8_t buf[];}. make other module(like colo-compare) know how to parse net pa

Re: [Qemu-devel] [PATCH V3 01/10] net: Add vnet_hdr_len related callback in NetClientInfo

2017-05-02 Thread Zhang Chen
On 05/02/2017 12:46 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: Add get_vnet_hdr_len and get_using_vnet_hdr callback that make we get vnet_hdr_len easily. Signed-off-by: Zhang Chen --- include/net/net.h | 6 ++ net/net.c | 18 ++ 2 files c

Re: [Qemu-devel] Subject: [PATCH] target-ppc: Add global timer group A to open-pic.

2017-05-02 Thread alarson
David Gibson wrote on 04/25/2017 11:34:41 PM: Thanks for the review David. I'll send an updated patch soon with all your comments addressed and all other s/0/NULL or false/ as appropriate and a better commit message. Just to clarify my concern; the patch causes the QEMU openpic timer to be har

Re: [Qemu-devel] [PATCH qemu v5] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-05-02 Thread Alexey Kardashevskiy
On 03/05/17 02:25, Cornelia Huck wrote: > On Sat, 29 Apr 2017 22:37:07 +1000 > Alexey Kardashevskiy wrote: > >> This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion >> as a parent. >> >> This moves IOMMU-related fields from MR to IOMMU MR. However to avoid >> dymanic QOM casting in

Re: [Qemu-devel] [PATCH RFC] xen/mapcache: store dma information in revmapcache entries for debugging

2017-05-02 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH RFC] xen/mapcache: store dma information in revmapcache entries for debugging Message-id: alpine.DEB.2.10.1705021646310.8859@sstabellini-ThinkPad-X260 Type: series === T

[Qemu-devel] [PATCH RFC] xen/mapcache: store dma information in revmapcache entries for debugging

2017-05-02 Thread Stefano Stabellini
The Xen mapcache is able to create long term mappings, they are called "locked" mappings. The third parameter of the xen_map_cache call specifies if a mapping is a "locked" mapping. >From the QEMU point of view there are two kinds of long term mappings: [a] device memory mappings, such as option

Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-02 Thread Eduardo Habkost
On Tue, May 02, 2017 at 04:42:02PM -0500, Eric Blake wrote: [...] > > -if (value) { > > -cpu->env.features[fp->w] |= fp->mask; > > -} else { > > -cpu->env.features[fp->w] &= ~fp->mask; > > +switch (value->type) { > > +case QTYPE_QBOOL: > > +if (value->u.q_boo

Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types

2017-05-02 Thread Eduardo Habkost
On Tue, May 02, 2017 at 04:37:03PM -0500, Eric Blake wrote: > On 05/02/2017 03:31 PM, Eduardo Habkost wrote: > > When parsing alternates from a string, there are some limitations in > > what we can do, but it is a valid use case in some situations. We can > > support booleans, integer types, and en

Re: [Qemu-devel] [PATCH 1/4] visitor: Add 'supported_qtypes' parameter to visit_start_alternate()

2017-05-02 Thread Eduardo Habkost
On Tue, May 02, 2017 at 04:29:32PM -0500, Eric Blake wrote: > On 05/02/2017 03:31 PM, Eduardo Habkost wrote: > > This will allow visitors to make decisions based on the supported qtypes > > of a given alternate type. The new parameter can replace the old > > 'promote_int' argument, as qobject-input

Re: [Qemu-devel] [PATCH 04/13] arm: Clean up handling of no-MPU PMSA CPUs

2017-05-02 Thread Alistair Francis
On Tue, Apr 25, 2017 at 5:07 AM, Peter Maydell wrote: > ARM CPUs come in two flavours: > * proper MMU ("VMSA") > * only an MPU ("PMSA") > For PMSA, the MPU may be implemented, or not (in which case there > is default "always acts the same" behaviour, but it isn't guest > programmable). > > QEMU

Re: [Qemu-devel] [PATCH 05/13] arm: Don't clear ARM_FEATURE_PMSA for no-mpu configs

2017-05-02 Thread Alistair Francis
On Tue, Apr 25, 2017 at 5:07 AM, Peter Maydell wrote: > Fix the handling of QOM properties for PMSA CPUs with no MPU: > > Allow no-MPU to be specified by either: > * has-mpu = false > * pmsav7_dregion = 0 > and make setting one imply the other. Don't clear the PMSA > feature bit in this situatio

Re: [Qemu-devel] [PATCH 02/13] arm: Add support for M profile CPUs having different MMU index semantics

2017-05-02 Thread Alistair Francis
On Tue, Apr 25, 2017 at 5:06 AM, Peter Maydell wrote: > The M profile CPU's MPU has an awkward corner case which we > would like to implement with a different MMU index. > > We can avoid having to bump the number of MMU modes ARM > uses, because some of our existing MMU indexes are only > used by

Re: [Qemu-devel] [PATCH v3 3/4] qmp: refactor duplicate code

2017-05-02 Thread Eric Blake
On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote: > This patchset factor out the duplicate qmp throttle interface code > that was present in both block and fsdev device files. Instead of adding the duplicate code in patch 2 then cleaning it out here, you should refactor this patch to be first (fix

Re: [Qemu-devel] [PATCH v3 2/4] fsdev: QMP interface for throttling

2017-05-02 Thread Eric Blake
On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote: > This patchset enables qmp interfaces for the fsdev > devices. This provides two interfaces one > for querying info of all the fsdev devices. The second one > to set the IO limits for the required fsdev device. > > Signed-off-by: Pradeep Jagadeesh

Re: [Qemu-devel] [PATCH 01/13] arm: Use the mmu_idx we're passed in arm_cpu_do_unaligned_access()

2017-05-02 Thread Alistair Francis
On Tue, Apr 25, 2017 at 5:06 AM, Peter Maydell wrote: > When identifying the DFSR format for an alignment fault, use > the mmu index that we are passed, rather than calling cpu_mmu_index() > to get the mmu index for the current CPU state. This doesn't actually > make any difference since the only

Re: [Qemu-devel] [PATCH v3 1/4] Throttle: Create IOThrottle structure

2017-05-02 Thread Eric Blake
On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote: > This patchset introduces a new io throttle structure. This will be > used in both block and fsdev devices. > > Signed-off-by: Pradeep Jagadeesh > --- > qapi/block-core.json | 76 ++ > qapi/iothrottle.j

Re: [Qemu-devel] [Qemu-devel RFC v3 1/5] msf2: Add Smartfusion2 System timer

2017-05-02 Thread Alistair Francis
On Fri, Apr 28, 2017 at 9:51 AM, Subbaraya Sundeep wrote: > Modelled System Timer in Microsemi's Smartfusion2 Soc. > Timer has two 32bit down counters and two interrupts. > > Signed-off-by: Subbaraya Sundeep > --- > hw/timer/Makefile.objs| 1 + > hw/timer/msf2_timer.c | 250 >

Re: [Qemu-devel] [virtio-dev] [PATCH v18 0/2] virtio-crypto: virtio crypto device specification

2017-05-02 Thread Halil Pasic
Hi Gonglei! I've started reviewing but it's going to take some time because I've missed the previous version (vacation) and v16 was a long time ago, so I have to re-check and re-learn things. My first impression is, it reads much better that v16 but still has some space for improvement. One ide

Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-02 Thread Eric Blake
On 05/02/2017 03:31 PM, Eduardo Habkost wrote: > Introduce a new CPUFeatureSetting QAPI data type, and use it to support > feature=force on -cpu. > > Signed-off-by: Eduardo Habkost > --- > qapi-schema.json | 32 + > target/i386/cpu.h | 2 ++ > ta

Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types

2017-05-02 Thread Eric Blake
On 05/02/2017 03:31 PM, Eduardo Habkost wrote: > When parsing alternates from a string, there are some limitations in > what we can do, but it is a valid use case in some situations. We can > support booleans, integer types, and enums. > > This will be used to support 'feature=force' in -cpu optio

Re: [Qemu-devel] [PATCH 1/4] visitor: Add 'supported_qtypes' parameter to visit_start_alternate()

2017-05-02 Thread Eric Blake
On 05/02/2017 03:31 PM, Eduardo Habkost wrote: > This will allow visitors to make decisions based on the supported qtypes > of a given alternate type. The new parameter can replace the old > 'promote_int' argument, as qobject-input-visitor can simply check if > QTYPE_QINT is set in supported_qtypes

[Qemu-devel] [Bug 1687653] Re: QEMU-KVM / detect_zeroes causes KVM to start unlimited number of threads on Guest-Sided High-IO with big Blocksize

2017-05-02 Thread Florian Strankowski
Just to make this clear: This bug affects only LVM-backed storages. File-based-storage is not affected. LVM-Thin and also LVM-Thick. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1687653 Title: QEM

Re: [Qemu-devel] [PATCH 0/4] x86: Support "-cpu feature=force"

2017-05-02 Thread Eduardo Habkost
On Tue, May 02, 2017 at 01:46:22PM -0700, no-re...@patchew.org wrote: [...] > TESTtests/qapi-schema/qapi-schema-test.out > TESTtests/qapi-schema/quoted-structural-chars.out > TESTtests/qapi-schema/redefined-builtin.out > TESTtests/qapi-schema/redefined-command.out > Files /t

Re: [Qemu-devel] [PATCH 0/4] x86: Support "-cpu feature=force"

2017-05-02 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/4] x86: Support "-cpu feature=force" Message-id: 20170502203115.22233-1-ehabk...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(gi

Re: [Qemu-devel] [PATCH 0/4] x86: Support "-cpu feature=force"

2017-05-02 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH 0/4] x86: Support "-cpu feature=force" Message-id: 20170502203115.22233-1-ehabk...@r

[Qemu-devel] [PATCH] fixup! tests: Add [+-]feature and feature=on|off test cases

2017-05-02 Thread Eduardo Habkost
On Tue, May 02, 2017 at 05:31:15PM -0300, Eduardo Habkost wrote: > Introduce a new CPUFeatureSetting QAPI data type, and use it to support > feature=force on -cpu. > > Signed-off-by: Eduardo Habkost I will include this in v2 to fix the coding style issues. Signed-off-by: Eduardo Habkost --- t

[Qemu-devel] [PATCH 3/4] tests: Add [+-]feature and feature=on|off test cases

2017-05-02 Thread Eduardo Habkost
Add test code to ensure features are enabled/disabled correctly in the command-line. The test case use the "feature-words" and "filtered-features" properties to check if the features were enabled/disabled correctly. Signed-off-by: Eduardo Habkost --- tests/test-x86-cpuid-compat.c | 107 +

[Qemu-devel] [PATCH 1/4] visitor: Add 'supported_qtypes' parameter to visit_start_alternate()

2017-05-02 Thread Eduardo Habkost
This will allow visitors to make decisions based on the supported qtypes of a given alternate type. The new parameter can replace the old 'promote_int' argument, as qobject-input-visitor can simply check if QTYPE_QINT is set in supported_qtypes. Signed-off-by: Eduardo Habkost --- include/qapi/vi

[Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types

2017-05-02 Thread Eduardo Habkost
When parsing alternates from a string, there are some limitations in what we can do, but it is a valid use case in some situations. We can support booleans, integer types, and enums. This will be used to support 'feature=force' in -cpu options, while keeping 'feature=on|off|true|false' represented

[Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-02 Thread Eduardo Habkost
Introduce a new CPUFeatureSetting QAPI data type, and use it to support feature=force on -cpu. Signed-off-by: Eduardo Habkost --- qapi-schema.json | 32 + target/i386/cpu.h | 2 ++ target/i386/cpu.c | 55 ++

[Qemu-devel] [PATCH 0/4] x86: Support "-cpu feature=force"

2017-05-02 Thread Eduardo Habkost
This series implements "-cpu feature=force", to allow a feature to be forcefully enabled even if the underlying accelerator report it as unsupported. This feature should be used only for testing and debugging. We use a new QAPI alternate type to keep command-line compatibility, and to keep compati

Re: [Qemu-devel] [PATCH v6 00/25] tcg cross-tb optimizations

2017-05-02 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v6 00/25] tcg cross-tb optimizations Message-id: 20170502192300.2124-1-...@twiddle.net === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log -

Re: [Qemu-devel] [PATCH v4 1/1] numa: equally distribute memory on nodes

2017-05-02 Thread Eduardo Habkost
On Tue, May 02, 2017 at 06:29:55PM +0200, Laurent Vivier wrote: [...] > diff --git a/numa.c b/numa.c > index 6fc2393..750fd95 100644 > --- a/numa.c > +++ b/numa.c > @@ -294,6 +294,42 @@ static void validate_numa_cpus(void) > g_free(seen_cpus); > } > > +void numa_legacy_auto_assign_ram(Machi

Re: [Qemu-devel] [PATCH] scripts/qmp/qom-set: fix the value argument passed to srv.command()

2017-05-02 Thread Philippe Mathieu-Daudé
On 05/02/2017 11:41 AM, Greg Kurz wrote: When invoking the script with -s, we end up passing a bogus value to QEMU: $ ./scripts/qmp/qom-set -s /var/tmp/qmp-sock-exp /machine.accel kvm {} $ ./scripts/qmp/qom-get -s /var/tmp/qmp-sock-exp /machine.accel /var/tmp/qmp-sock-exp This happens because s

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

2017-05-02 Thread Stefan Berger
On 05/02/2017 02:50 PM, Marc-André Lureau wrote: Hi On Tue, May 2, 2017 at 10:25 PM Patrick Ohly > wrote: On Tue, 2017-05-02 at 13:19 -0400, Stefan Berger wrote: > On 05/02/2017 01:09 PM, Marc-André Lureau wrote: > > On Tue, May 2, 2017 at 8:59 PM Ste

[Qemu-devel] [PATCH v6 22/25] target/aarch64: optimize indirect branches

2017-05-02 Thread Richard Henderson
From: "Emilio G. Cota" Measurements: [Baseline performance is that before applying this and the previous commit] -NBench, aarch64-softmmu. Host: Intel i7-4790K @ 4.00GHz 1.7x +-+-

[Qemu-devel] [PATCH v6 21/25] target/aarch64: optimize cross-page direct jumps in softmmu

2017-05-02 Thread Richard Henderson
From: "Emilio G. Cota" Perf numbers in next commit's log. Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 24de30d..1e

Re: [Qemu-devel] [PATCH v5++ 1/3] tcg/mips: implement goto_ptr

2017-05-02 Thread Aurelien Jarno
On 2017-05-02 18:21, Richard Henderson wrote: > On 04/30/2017 04:52 PM, Aurelien Jarno wrote: > > +/* jmp to the given host address (could be epilogue) */ > > +tcg_out_opc_reg(s, OPC_JR, 0, a0, 0); > > +tcg_out_nop(s); > > Any particular reason not to do the zeroing in the

Re: [Qemu-devel] [PATCH 01/14] target/sh4: split ctx->flags into ctx->tbflags and ctx->envflags

2017-05-02 Thread Aurelien Jarno
On 2017-05-02 09:16, Philippe Mathieu-Daudé wrote: > Hi Aurelien, > > On 05/01/2017 07:10 PM, Aurelien Jarno wrote: > > There is a confusion (and not only in the SH4 target) between tb->flags, > > env->flags and ctx->flags. To avoid it, split ctx->flags into > > ctx->tbflags and ctx->envflags. ctx

[Qemu-devel] [PATCH v6 18/25] target/s390: Use tcg_gen_lookup_and_goto_ptr

2017-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/s390x/translate.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 01c6217..f7c2123 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -

[Qemu-devel] [PATCH v6 15/25] tcg/s390: Implement goto_ptr

2017-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.h | 2 +- tcg/s390/tcg-target.inc.c | 24 +--- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.h b/tcg/s390/tcg-target.h index 6b7bcfb..957f0c0 100644 --- a/tcg/s390/tcg-target.h

[Qemu-devel] [PATCH v6 11/25] tb-hash: improve tb_jmp_cache hash function in user mode

2017-05-02 Thread Richard Henderson
From: "Emilio G. Cota" Optimizations to cross-page chaining and indirect branches make performance more sensitive to the hit rate of tb_jmp_cache. The constraint of reserving some bits for the page number lowers the achievable quality of the hashing function. However, user-mode does not have thi

[Qemu-devel] [PATCH v6 24/25] target/mips: optimize cross-page direct jumps in softmmu

2017-05-02 Thread Richard Henderson
From: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Aurelien Jarno Message-Id: <20170430145254.25616-3-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/mips/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/translate.c b/target/mips/t

[Qemu-devel] [PATCH v6 25/25] target/mips: optimize indirect branches

2017-05-02 Thread Richard Henderson
From: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Aurelien Jarno Message-Id: <20170430145254.25616-4-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/mips/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/translate.c b/target/mips/t

[Qemu-devel] [PATCH v6 23/25] tcg/mips: implement goto_ptr

2017-05-02 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aurelien Jarno Message-Id: <20170430145254.25616-2-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.h | 2 +- tcg/mips/tcg-target.inc.c | 13 + 2 files changed, 14 insertions

[Qemu-devel] [PATCH v6 13/25] tcg/aarch64: Implement goto_ptr

2017-05-02 Thread Richard Henderson
Measurements: SPECint06 (test set), x86_64-linux-user. Host: APM 64-bit ARMv8 (Atlas/A57) @ 2.4 GHz 1.45x +-+-+-+ |

[Qemu-devel] [PATCH v6 20/25] target/alpha: Use tcg_gen_lookup_and_goto_ptr

2017-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/alpha/translate.c | 54 +--- 1 file changed, 47 insertions(+), 7 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index df5d695..c2941ae 100644 --- a/target/alpha/translate.c +++

[Qemu-devel] [PATCH v6 17/25] tcg/arm: Implement goto_ptr

2017-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.h | 2 +- tcg/arm/tcg-target.inc.c | 25 + 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h index c114df7..5ef1086 100644 --- a/tcg/arm/tcg-target.h +++

[Qemu-devel] [PATCH v6 19/25] target/hppa: Use tcg_gen_lookup_and_goto_ptr

2017-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 9e8c233..e10abc5 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -517,7 +517,7 @@

[Qemu-devel] [PATCH v6 16/25] tcg/arm: Clarify tcg_out_bx for arm4 host

2017-05-02 Thread Richard Henderson
In theory this would re-enable usage of QEMU on an armv4 host. Whether this is worthwhile is debatable -- we've been unconditionally issuing the armv5t BX instruction in the prologue since 2011 without complaint. Possibly we should simply require an armv6 host. Signed-off-by: Richard Henderson -

[Qemu-devel] [PATCH v6 07/25] target/arm: optimize indirect branches

2017-05-02 Thread Richard Henderson
From: "Emilio G. Cota" Speed up indirect branches by jumping to the target if it is valid. Softmmu measurements (see later commit for user-mode results): Note: baseline (i.e. speedup == 1x) is QEMU v2.9.0. - Impact on Boot time | setup | ARM debian jessie boot+shutdown time | stddev | |-

[Qemu-devel] [PATCH v6 10/25] target/i386: optimize indirect branches

2017-05-02 Thread Richard Henderson
From: "Emilio G. Cota" Speed up indirect branches by jumping to the target if it is valid. Softmmu measurements (see later commit for user-mode numbers): Note: baseline (i.e. speedup == 1x) is QEMU v2.9.0. - SPECint06 (test set), x86_64-softmmu (Ubuntu 16.04 guest). Host: Int

[Qemu-devel] [PATCH v6 12/25] tcg/ppc: Implement goto_ptr

2017-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.h | 2 +- tcg/ppc/tcg-target.inc.c | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tcg/ppc/tcg-target.h b/tcg/ppc/tcg-target.h index a9aa974..5f4a40a 100644 --- a/tcg/ppc/tcg-target.h +++ b/tcg/ppc/tcg-target.h

[Qemu-devel] [PATCH v6 09/25] target/i386: optimize cross-page direct jumps in softmmu

2017-05-02 Thread Richard Henderson
From: "Emilio G. Cota" Instead of unconditionally exiting to the exec loop, use the gen_jr helper to jump to the target if it is valid. Perf impact: see next commit's log. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Message-Id: <1493263764-18657-10-git-send-email-c...@braap.o

[Qemu-devel] [PATCH v6 04/25] tcg: Introduce goto_ptr opcode and tcg_gen_lookup_and_goto_ptr

2017-05-02 Thread Richard Henderson
From: "Emilio G. Cota" Instead of exporting goto_ptr directly to TCG frontends, export tcg_gen_lookup_and_goto_ptr(), which calls goto_ptr with the pointer returned by the lookup_tb_ptr() helper. This is the only use case we have for goto_ptr and lookup_tb_ptr, so having this function is very con

[Qemu-devel] [PATCH v6 03/25] qemu/atomic: Loosen restrictions for 64-bit ILP32 hosts

2017-05-02 Thread Richard Henderson
We need to coordinate with the TCG_OVERSIZED_GUEST test in cputlb.c, and allow 64-bit atomics even though sizeof(void *) == 4. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/qemu/atomic.h | 34 ++ 1 file changed, 26 insertions(+), 8 deletio

[Qemu-devel] [PATCH v6 06/25] target/arm: optimize cross-page direct jumps in softmmu

2017-05-02 Thread Richard Henderson
From: "Emilio G. Cota" Instead of unconditionally exiting to the exec loop, use the lookup_and_goto_ptr helper to jump to the target if it is valid. Perf impact: see next commit's log. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Message-Id: <14932637

[Qemu-devel] [PATCH v6 14/25] tcg/sparc: Implement goto_ptr

2017-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.h | 2 +- tcg/sparc/tcg-target.inc.c | 11 ++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tcg/sparc/tcg-target.h b/tcg/sparc/tcg-target.h index 9348ddd..854a0af 100644 --- a/tcg/sparc/tcg-target.h +++ b/tc

[Qemu-devel] [PATCH v6 01/25] target/nios2: Fix 64-bit ilp32 compilation

2017-05-02 Thread Richard Henderson
Avoid a "cast from pointer to integer of different size" warning by using the proper host type. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/nios2/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/translate.c b/target/nios2/tran

[Qemu-devel] [PATCH v6 08/25] target/i386: introduce gen_jr helper to generate lookup_and_goto_ptr

2017-05-02 Thread Richard Henderson
From: "Emilio G. Cota" This helper will be used by subsequent changes. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Message-Id: <1493263764-18657-9-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target/i386/translate.c | 25 - 1 file cha

[Qemu-devel] [PATCH v6 05/25] tcg/i386: implement goto_ptr

2017-05-02 Thread Richard Henderson
From: "Emilio G. Cota" Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Message-Id: <1493263764-18657-6-git-send-email-c...@braap.org> [rth: Reuse goto_ptr epilogue for exit_tb 0.] Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 2

[Qemu-devel] [PATCH v6 00/25] tcg cross-tb optimizations

2017-05-02 Thread Richard Henderson
Changes since v5: * MIPS patches from Aurelien. * AArch64 patches from Emilio. * ARM32 backend support for goto_ptr * Alpha frontend patch rewritten; the former patch appears to drop clock interrupts, not exiting the kernel's idle loop. I never *really* figured out why, since both p

[Qemu-devel] [PATCH v6 02/25] tcg/sparc: Use the proper compilation flags for 32-bit

2017-05-02 Thread Richard Henderson
We have required a v9 cpu since 9b9c37c36439ee0452632253dac7a31897f27f70. However, the flags we were using did not reliably enable v8plus, which meant that the compiler didn't know it could inline 64-bit atomics. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- configure | 6 +++---

[Qemu-devel] crash in vhost-user-bridge on migration

2017-05-02 Thread Dr. David Alan Gilbert
Hi, I've started playing with vhost-user-bridge and have it basically up and going, but I've just tried migration and I've got a reliable crash for it; I'm not that sure I've got it set up right, so suggestions please: This is with qemu head, on an f26 host running an f25-ish guest. Program rec

Re: [Qemu-devel] [PATCH] RFC: vmcoreinfo device

2017-05-02 Thread Marc-André Lureau
Hi On Tue, May 2, 2017 at 11:17 AM Igor Mammedov wrote: > On Fri, 28 Apr 2017 14:28:38 + > Marc-André Lureau wrote: > > > Hi > > > > On Fri, Apr 28, 2017 at 6:12 PM Ladi Prosek wrote: > > > > > On Mon, Apr 24, 2017 at 3:03 PM, Marc-André Lureau > > > wrote: > > > > The VM coreinfo (vmcore

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

2017-05-02 Thread Marc-André Lureau
Hi On Tue, May 2, 2017 at 10:25 PM Patrick Ohly wrote: > On Tue, 2017-05-02 at 13:19 -0400, Stefan Berger wrote: > > On 05/02/2017 01:09 PM, Marc-André Lureau wrote: > > > On Tue, May 2, 2017 at 8:59 PM Stefan Berger < > stef...@linux.vnet.ibm.com> > > > wrote: > > > > > >> And who is going to i

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] Add qemu_vga.ndrv MacOS PPC VGA driver from QemuMacDrivers

2017-05-02 Thread Mark Cave-Ayland
On 02/05/17 16:52, Howard Spoelstra wrote: > Hi, > > I successfully tested this patch set with a build for OSX. > Installed versions of Mac OS 9.04, 9.1, 9.22, 10.0, 10.1, 10.2, 10.3 > and 10.4 all work. As do three images pulled from running systems with > 10.2, 10.3, 10.4 installed, including c

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

2017-05-02 Thread Patrick Ohly
On Tue, 2017-05-02 at 13:19 -0400, Stefan Berger wrote: > On 05/02/2017 01:09 PM, Marc-André Lureau wrote: > > On Tue, May 2, 2017 at 8:59 PM Stefan Berger > > wrote: > > > >> And who is going to implement that qemu-swtpm? Obviously this discussion > >> doesn't contribute to progress if nobody is

Re: [Qemu-devel] cpu_io_recompile, icount, and re-issued instructions

2017-05-02 Thread Michael Eager
On 05/02/2017 12:59 AM, Paolo Bonzini wrote: On 01/05/2017 03:57, Michael Eager wrote: I'm seeing incorrect values when there is a write to a memory-mapped I/O device when icount is set. What I see happening is that a TB with ~20 instructions is executed which contains a write to the MM I/O

Re: [Qemu-devel] [Research] Strato HiDrive as a Dropbox Replacement?

2017-05-02 Thread Michal Suchánek
On Tue, 2 May 2017 15:11:20 +0200 Kai Wagner wrote: > On 05/02/2017 03:01 PM, Kai Dupke wrote: > > On 05/02/2017 02:48 PM, Lenz Grimmer wrote: > >> I don't, as none of these services store my data in encrypted form > >> by default... > > Any service you know where this (encryption) is handled

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

2017-05-02 Thread Stefan Berger
On 05/02/2017 01:09 PM, Marc-André Lureau wrote: Hi On Tue, May 2, 2017 at 8:59 PM Stefan Berger wrote: On 05/02/2017 12:05 PM, Marc-André Lureau wrote: Hi On Tue, May 2, 2017 at 3:53 PM Amarnath Valluri < amarnath.vall...@intel.com> wrote: This change introduces a new TPM backend driver

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

2017-05-02 Thread Marc-André Lureau
Hi On Tue, May 2, 2017 at 8:59 PM Stefan Berger wrote: > On 05/02/2017 12:05 PM, Marc-André Lureau wrote: > > Hi > > On Tue, May 2, 2017 at 3:53 PM Amarnath Valluri < > amarnath.vall...@intel.com> wrote: > >> This change introduces a new TPM backend driver that can communicate with >> swtpm(soft

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Denis V. Lunev
On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: > On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >>> "Denis V. Lunev" writes: >>> On 05/02/2017 05:43 PM, Markus Armbruster wrote: > "Denis V. Lunev" writes: >

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: > > * Markus Armbruster (arm...@redhat.com) wrote: > > > "Denis V. Lunev" writes: > > > > > > > On 05/02/2017 05:43 PM, Markus Armbruster wrote: > > > >> "Denis V. Lunev" w

[Qemu-devel] [PATCH v17 22/23] qemu-iotests: Add test case 153 for image locking

2017-05-02 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/153 | 233 +++ tests/qemu-iotests/153.out | 390 + tests/qemu-iotests/group | 1 + 3 files changed, 624 insertions(+) create mode 100755 tests/qemu-iotests/153 create mode

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

2017-05-02 Thread Stefan Berger
On 05/02/2017 12:05 PM, Marc-André Lureau wrote: Hi On Tue, May 2, 2017 at 3:53 PM Amarnath Valluri mailto:amarnath.vall...@intel.com>> wrote: This change introduces a new TPM backend driver that can communicate with swtpm(software TPM emulator) using unix domain socket interface.

Re: [Qemu-devel] Writing a C library to generate qemu command lines and configuration files

2017-05-02 Thread Markus Armbruster
Paolo Bonzini writes: > On 02/05/2017 16:59, Richard W.M. Jones wrote: >>> To answer your question: you have to double comma after '=', or else it >>> terminates the value. There is no other quoting. >> >> Hmm, is that really right? I should avoid absolutes when it comes to QemuOpts... >>

Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

2017-05-02 Thread Michael Roth
Quoting Michael Roth (2017-05-02 11:46:36) > Quoting Eric Blake (2017-04-27 16:58:21) > > Commit 62c39b3 introduced test-qga, and at face value, appears > > to be testing the 'guest-sync' behavior that is recommended for > > guests in sending 0xff to QGA to force the parser to reset. But > > this

[Qemu-devel] [PATCH v17 21/23] file-posix: Add image locking to perm operations

2017-05-02 Thread Fam Zheng
This extends the permission bits of op blocker API to external using Linux OFD locks. Each permission in @perm and @shared_perm is represented by a locked byte in the image file. Requesting a permission in @perm is translated to a shared lock of the corresponding byte; rejecting to share the same

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Daniel P. Berrange
On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Denis V. Lunev" writes: > > > > > On 05/02/2017 05:43 PM, Markus Armbruster wrote: > > >> "Denis V. Lunev" writes: > > >> > > >>> Right now QMP and HMP monitors read 1 by

[Qemu-devel] [PATCH v17 18/23] block: Reuse bs as backing hd for drive-backup sync=none

2017-05-02 Thread Fam Zheng
Opening the backing image for the second time is bad, especially here when it is also in use as the active image as the source. The drive-backup job itself doesn't read from target->backing for COW, instead it gets data from the write notifier, so it's not a big problem. However, exporting the targ

Re: [Qemu-devel] [PATCH v17 18/23] block: Reuse bs as backing hd for drive-backup sync=none

2017-05-02 Thread Fam Zheng
On Wed, 05/03 00:35, Fam Zheng wrote: > Opening the backing image for the second time is bad, especially here > when it is also in use as the active image as the source. The > drive-backup job itself doesn't read from target->backing for COW, > instead it gets data from the write notifier, so it's

  1   2   3   4   >