[Qemu-devel] [Bug 1289788] Re: MIDI access (not only adlib) hangs WinNT on QEMU 1.7.x

2017-05-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1289788 Title: MIDI access

Re: [Qemu-devel] [virtio-dev] RE: [PATCH v18 1/2] virtio-crypto: Add virtio crypto device specification

2017-05-05 Thread Gonglei (Arei)
> > From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Friday, May 05, 2017 10:33 PM > > On 05/05/2017 07:56 AM, Gonglei (Arei) wrote: > >> > >> > >> On 05/04/2017 03:53 PM, Gonglei (Arei) wrote: > >>> Sorry, I missed one comment in the previous reply. > >>> > > > +\end{itemize*}

Re: [Qemu-devel] [virtio-dev] RE: [PATCH v18 1/2] virtio-crypto: Add virtio crypto device specification

2017-05-05 Thread Gonglei (Arei)
> > From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Friday, May 05, 2017 9:52 PM > > On 05/05/2017 05:39 AM, Gonglei (Arei) wrote: > >> > >> > >> On 05/04/2017 04:13 PM, Gonglei (Arei) wrote: > > > On 05/04/2017 03:33 PM, Gonglei (Arei) wrote: > >>> +\begin{descripti

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-05-05 Thread Samuel Thibault
FONNEMANN Mark, on sam. 06 mai 2017 01:06:31 +, wrote: > root@qemu:~# /initrd/bin/nslookup www.google.com 10.0.2.3 > Server:10.0.2.3 > Address 1: 10.0.2.3 > > nslookup: can't resolve 'www.google.com' That's so weird there's no pa

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-05-05 Thread FONNEMANN Mark
>So it's supposed to be using 10.0.2.3 I guess. Just to make sure, you could try >/initrd/bin/nslookup www.google.com 10.0.2.3 root@qemu:~# /initrd/bin/nslookup www.google.com 10.0.2.3 Server:10.0.2.3 Address 1: 10.0.2.3 nslookup: ca

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-05-05 Thread Samuel Thibault
FONNEMANN Mark, on sam. 06 mai 2017 00:33:40 +, wrote: > >The attached patch should be dumping the same kind of information. > > Nslookup does not produce any output in curses or in logfile (-D logfile.txt). Uh. So qemu can't be the culprit since it doesn't receive anything :) > root@qemu:~

[Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5)

2017-05-05 Thread Philippe Mathieu-Daudé
static code analyzer complain: linux-user/syscall.c:5575:9: warning: Dereference of undefined pointer value if (*host_rt_dev_ptr != 0) { ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 ins

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-05-05 Thread FONNEMANN Mark
>The attached patch should be dumping the same kind of information. Nslookup does not produce any output in curses or in logfile (-D logfile.txt). I tried it using the version installed on the root system (Busybox 1.0): root@qemu:~# nslookup BusyBox v1.00 (2010.04.14-20:01+00

Re: [Qemu-devel] [PATCH v5 4/5] slirp: fix leak

2017-05-05 Thread Samuel Thibault
Applied to my tree, thanks!

Re: [Qemu-devel] [Qemu-devel RFC v3 4/5] msf2: Add Smartfusion2 SoC.

2017-05-05 Thread Alistair Francis
On Fri, May 5, 2017 at 9:14 AM, sundeep subbaraya wrote: > Hi Alistair, > > On Fri, May 5, 2017 at 3:51 AM, Alistair Francis wrote: >> On Fri, Apr 28, 2017 at 9:51 AM, Subbaraya Sundeep >> wrote: >>> Smartfusion2 SoC has hardened Microcontroller subsystem >>> and flash based FPGA fabric. This pa

Re: [Qemu-devel] [PATCH v6 1/5] shutdown: Simplify shutdown_signal

2017-05-05 Thread Alistair Francis
On Fri, May 5, 2017 at 12:38 PM, Eric Blake wrote: > There is no signal 0 (kill(pid, 0) has special semantics to probe whether > a process is alive), rather than actually sending a signal 0). So we > can use the simpler 0, instead of -1, for our sentinel of whether a > shutdown request due to a s

Re: [Qemu-devel] [PATCH v4 1/1] slirp: add SOCKS5 support

2017-05-05 Thread Samuel Thibault
Hello, Laurent Vivier, on sam. 06 mai 2017 00:48:33 +0200, wrote: > @@ -617,6 +622,10 @@ void slirp_pollfds_poll(GArray *pollfds, int > select_error) > * Check sockets for reading > */ > else if (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR)) { > +

Re: [Qemu-devel] [PATCH v4 0/1] slirp: add SOCKS5 support

2017-05-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v4 0/1] slirp: add SOCKS5 support Message-id: 20170505224833.17769-1-laur...@vivier.eu === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log -

Re: [Qemu-devel] [PATCH v4 0/1] slirp: add SOCKS5 support

2017-05-05 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v4 0/1] slirp: add SOCKS5 support Message-id: 20170505224833.17769-1-laur...@vivier.

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-05-05 Thread Samuel Thibault
FONNEMANN Mark, on ven. 05 mai 2017 22:38:20 +, wrote: > >Could you run tcpdump inside the guest so we are sure what the nslookup call > >emits? > > Is there another way to determine this info? My guest OS is an embedded > system with BusyBox 1.25 and not much else. The attached patch shoul

Re: [Qemu-devel] [PATCH v11 9/9] tests: Add coverage for recent block geometry fixes

2017-05-05 Thread Eric Blake
On 05/05/2017 05:34 PM, Max Reitz wrote: > On 29.04.2017 21:14, Eric Blake wrote: >> Use blkdebug's new geometry constraints to emulate setups that >> have needed past regression fixes: write zeroes asserting >> when running through a loopback block device with max-transfer >> smaller than cluster

[Qemu-devel] [PATCH v4 0/1] slirp: add SOCKS5 support

2017-05-05 Thread Laurent Vivier
This patch implements the SOCKS5 client part for "-net user" backend. It allows to route all internet traffic of the virtual machine to a SOCKS5 server. But all the local traffic (to the host) is sent to the host. It is needed because this SOCKS5 client doesn't route UDP traffic, and this allows

[Qemu-devel] [PATCH v4 1/1] slirp: add SOCKS5 support

2017-05-05 Thread Laurent Vivier
When the VM is used behind a firewall, This allows the use of a SOCKS5 proxy server to connect the VM IP stack directly to the Internet. This implementation doesn't manage UDP packets, so they are simply dropped (as with restrict=on), except for the localhost as we need it for DNS. Signed-off-by:

Re: [Qemu-devel] [PATCH v12 00/10] qcow2 zero-cluster tweaks [was add blkdebug tests]

2017-05-05 Thread Eric Blake
On 05/05/2017 05:18 PM, Max Reitz wrote: > On 04.05.2017 05:07, Eric Blake wrote: >> I've collected several improvements for qcow2 zero-cluster handling. >> >> Available as a tag at: >> git fetch git://repo.or.cz/qemu/ericb.git nbd-blkdebug-v12 >> >> Marked as v12 for "hysterical raisins", since it

Re: [Qemu-devel] [PATCH v12 08/10] qcow2: Optimize write zero of unaligned tail cluster

2017-05-05 Thread Eric Blake
On 05/05/2017 05:06 PM, Max Reitz wrote: > On 04.05.2017 05:07, Eric Blake wrote: >> We've already improved discards to operate efficiently on the tail >> of an unaligned qcow2 image; it's time to make a similar improvement >> to write zeroes. The special case is only valid at the tail >> cluster

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-05-05 Thread FONNEMANN Mark
>Could you run tcpdump inside the guest so we are sure what the nslookup call >emits? Is there another way to determine this info? My guest OS is an embedded system with BusyBox 1.25 and not much else. Mark.

Re: [Qemu-devel] [PATCH v11 9/9] tests: Add coverage for recent block geometry fixes

2017-05-05 Thread Max Reitz
On 29.04.2017 21:14, Eric Blake wrote: > Use blkdebug's new geometry constraints to emulate setups that > have needed past regression fixes: write zeroes asserting > when running through a loopback block device with max-transfer > smaller than cluster size, and discard rounding away portions > of r

Re: [Qemu-devel] [PATCH v12 07/10] iotests: Add test 179 to cover write zeroes with unmap

2017-05-05 Thread Max Reitz
On 04.05.2017 05:07, Eric Blake wrote: > No tests were covering write zeroes with unmap. Additionally, > I needed to prove that my previous patches for correct status > reporting and write zeroes optimizations actually had an impact. > > The test works for cluster_size between 8k and 2M (for smal

Re: [Qemu-devel] [PATCH v10 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS

2017-05-05 Thread Michael S. Tsirkin
On Thu, May 04, 2017 at 04:50:12PM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_PAGE_CHUNKS, which enables > the transfer of the ballooned (i.e. inflated/deflated) pages in > chunks to the host. > > The implementation of the previous virtio-balloon is not very > efficient, because

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS

2017-05-05 Thread Michael S. Tsirkin
On Thu, Apr 27, 2017 at 02:31:49PM +0800, Wei Wang wrote: > On 04/27/2017 07:20 AM, Michael S. Tsirkin wrote: > > On Wed, Apr 26, 2017 at 11:03:34AM +, Wang, Wei W wrote: > > > Hi Michael, could you please give some feedback? > > I'm sorry, I'm not sure feedback on what you are requesting. > Oh

Re: [Qemu-devel] [PATCH v9 5/5] virtio-balloon: VIRTIO_BALLOON_F_MISC_VQ

2017-05-05 Thread Michael S. Tsirkin
On Thu, Apr 27, 2017 at 02:33:44PM +0800, Wei Wang wrote: > On 04/14/2017 01:08 AM, Michael S. Tsirkin wrote: > > On Thu, Apr 13, 2017 at 05:35:08PM +0800, Wei Wang wrote: > > > Add a new vq, miscq, to handle miscellaneous requests between the device > > > and the driver. > > > > > > This patch im

Re: [Qemu-devel] [PATCH v12 00/10] qcow2 zero-cluster tweaks [was add blkdebug tests]

2017-05-05 Thread Max Reitz
On 04.05.2017 05:07, Eric Blake wrote: > I've collected several improvements for qcow2 zero-cluster handling. > > Available as a tag at: > git fetch git://repo.or.cz/qemu/ericb.git nbd-blkdebug-v12 > > Marked as v12 for "hysterical raisins", since it it the half of > v10 [1] that was not resubmit

Re: [Qemu-devel] [PATCH v10 4/6] mm: function to offer a page block on the free list

2017-05-05 Thread Michael S. Tsirkin
e system] > > url: > https://github.com/0day-ci/linux/commits/Wei-Wang/Extend-virtio-balloon-for-fast-de-inflating-fast-live-migration/20170505-052958 > reproduce: make htmldocs > > All warnings (new ones prefixed by >>): > >WARNING: convert(1) not found, for SVG

Re: [Qemu-devel] [virtio-dev] Re: virtio-net: configurable TX queue size

2017-05-05 Thread Michael S. Tsirkin
On Fri, May 05, 2017 at 05:20:07PM +0800, Jason Wang wrote: > > > On 2017年05月05日 13:53, Wei Wang wrote: > > On 05/05/2017 10:27 AM, Jason Wang wrote: > > > > > > > > > On 2017年05月04日 18:58, Wang, Wei W wrote: > > > > Hi, > > > > > > > > I want to re-open the discussion left long time ago: > >

Re: [Qemu-devel] [PATCH v12 08/10] qcow2: Optimize write zero of unaligned tail cluster

2017-05-05 Thread Max Reitz
On 04.05.2017 05:07, Eric Blake wrote: > We've already improved discards to operate efficiently on the tail > of an unaligned qcow2 image; it's time to make a similar improvement > to write zeroes. The special case is only valid at the tail > cluster of a file, where we must recognize that any sec

Re: [Qemu-devel] [PATCH v12 07/10] iotests: Add test 179 to cover write zeroes with unmap

2017-05-05 Thread Max Reitz
On 04.05.2017 05:07, Eric Blake wrote: > No tests were covering write zeroes with unmap. Additionally, > I needed to prove that my previous patches for correct status > reporting and write zeroes optimizations actually had an impact. > > The test works for cluster_size between 8k and 2M (for smal

Re: [Qemu-devel] [PATCH v2 3/3] string-input-visitor: Support alternate types

2017-05-05 Thread Eduardo Habkost
On Fri, May 05, 2017 at 03:53:40PM -0500, Eric Blake wrote: > On 05/05/2017 03:11 PM, Eduardo Habkost wrote: > > When parsing alternates from a string, there are some limitations in > > what we can do, but it is a valid use case in some situations. We can > > support booleans, integer types, and en

Re: [Qemu-devel] [PATCH v12 06/10] iotests: Improve _filter_qemu_img_map

2017-05-05 Thread Max Reitz
On 05.05.2017 23:06, Eric Blake wrote: > On 05/05/2017 03:58 PM, Max Reitz wrote: >> On 04.05.2017 05:07, Eric Blake wrote: >>> Although _filter_qemu_img_map documents that it scrubs offsets, it >>> was only doing so for human mode. Of the existing tests using the >>> filter (97, 122, 150, 154, 17

Re: [Qemu-devel] [PATCH v12 06/10] iotests: Improve _filter_qemu_img_map

2017-05-05 Thread Eric Blake
On 05/05/2017 03:58 PM, Max Reitz wrote: > On 04.05.2017 05:07, Eric Blake wrote: >> Although _filter_qemu_img_map documents that it scrubs offsets, it >> was only doing so for human mode. Of the existing tests using the >> filter (97, 122, 150, 154, 176), two of them are affected, but it >> does

Re: [Qemu-devel] [PATCH v12 06/10] iotests: Improve _filter_qemu_img_map

2017-05-05 Thread Max Reitz
On 04.05.2017 05:07, Eric Blake wrote: > Although _filter_qemu_img_map documents that it scrubs offsets, it > was only doing so for human mode. Of the existing tests using the > filter (97, 122, 150, 154, 176), two of them are affected, but it > does not hurt the validity of the tests to not requi

Re: [Qemu-devel] [PATCH v12 05/10] qcow2: Optimize zero_single_l2() to minimize L2 churn

2017-05-05 Thread Max Reitz
On 04.05.2017 05:07, Eric Blake wrote: > Similar to discard_single_l2(), we should try to avoid dirtying > the L2 cache when the cluster we are changing already has the > right characteristics. > > Note that by the time we get to zero_single_l2(), BDRV_REQ_MAY_UNMAP > is a requirement to unallocat

Re: [Qemu-devel] [PATCH v12 04/10] qcow2: Make distinction between zero cluster types obvious

2017-05-05 Thread Max Reitz
On 04.05.2017 05:07, Eric Blake wrote: > Treat plain zero clusters differently from allocated ones, so that > we can simplify the logic of checking whether an offset is present. > Do this by splitting QCOW2_CLUSTER_ZERO into two new enums, > QCOW2_CLUSTER_ZERO_PLAIN and QCOW2_CLUSTER_ZERO_ALLOC. >

[Qemu-devel] [PATCH v9 6/6] migration: spapr: migrate pending_events of spapr state

2017-05-05 Thread Daniel Henrique Barboza
From: Jianjun Duan In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target so that the hotplug event ca

Re: [Qemu-devel] [PATCH v2 3/3] string-input-visitor: Support alternate types

2017-05-05 Thread Eric Blake
On 05/05/2017 03:11 PM, Eduardo Habkost wrote: > When parsing alternates from a string, there are some limitations in > what we can do, but it is a valid use case in some situations. We can > support booleans, integer types, and enums. Stale comment, given... > > This will be used to support 'fe

Re: [Qemu-devel] [PATCH v2 2/3] qapi: Add enum_table[] parameter to start_alternate

2017-05-05 Thread Eduardo Habkost
On Fri, May 05, 2017 at 03:45:01PM -0500, Eric Blake wrote: > On 05/05/2017 03:11 PM, Eduardo Habkost wrote: > > The new parameter will be used by the string input visitor to detect > > alternate types that can't be parsed unambiguously. > > > > Signed-off-by: Eduardo Habkost > > --- > > Changes

[Qemu-devel] [PATCH v9 4/6] hw/ppc/spapr.c: migrate pending_dimm_unplugs of spapr state

2017-05-05 Thread Daniel Henrique Barboza
To allow for a DIMM unplug event to resume its work if a migration occurs in the middle of it, this patch migrates the non-empty pending_dimm_unplugs QTAILQ that stores the DIMM information that the spapr_lmb_release() callback uses. It was considered an apprach where the DIMM states would be rest

[Qemu-devel] [PATCH v9 3/6] hw/ppc: migrating the DRC state of hotplugged devices

2017-05-05 Thread Daniel Henrique Barboza
In pseries, a firmware abstraction called Dynamic Reconfiguration Connector (DRC) is used to assign a particular dynamic resource to the guest and provide an interface to manage configuration/removal of the resource associated with it. In other words, DRC is the 'plugged state' of a device. Before

[Qemu-devel] [PATCH v9 5/6] migration: spapr: migrate ccs_list in spapr state

2017-05-05 Thread Daniel Henrique Barboza
From: Jianjun Duan ccs_list in spapr state maintains the device tree related information on the rtas side for hotplugged devices. In racing situations between hotplug events and migration operation, a rtas hotplug event could be migrated from the source guest to target guest, or the source guest

[Qemu-devel] [PATCH v9 2/6] hw/ppc: removing drc->detach_cb and drc->detach_cb_opaque

2017-05-05 Thread Daniel Henrique Barboza
The pointer drc->detach_cb is being used as a way of informing the detach() function inside spapr_drc.c which cb to execute. This information can also be retrieved simply by checking drc->type and choosing the right callback based on it. In this context, detach_cb is redundant information that must

[Qemu-devel] [PATCH v9 1/6] hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState

2017-05-05 Thread Daniel Henrique Barboza
The LMB DRC release callback, spapr_lmb_release(), uses an opaque parameter, a sPAPRDIMMState struct that stores the current LMBs that are allocated to a DIMM (nr_lmbs). After each call to this callback, the nr_lmbs is decremented by one and, when it reaches zero, the callback proceeds with the qde

[Qemu-devel] [PATCH v9 0/6] migration/ppc: migrating DRC, ccs_list and pending_events

2017-05-05 Thread Daniel Henrique Barboza
v9: - patch 1 (*new*): added a qtail in sPAPRMachineState called pending_dimm_unplugs that stores the DIMM LMB state during the unplug process. - patch 2 (*new*): merged v8-patch1 and v8-patch2: removing detach_cb and detach_cb_opaque. - patch 3: * removed dk->vmsd entry. We're using vmstate_r

Re: [Qemu-devel] [PATCH v2 2/3] qapi: Add enum_table[] parameter to start_alternate

2017-05-05 Thread Eric Blake
On 05/05/2017 03:11 PM, Eduardo Habkost wrote: > The new parameter will be used by the string input visitor to detect > alternate types that can't be parsed unambiguously. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * (new patch added to series) > --- > +++ b/include/qapi/visi

Re: [Qemu-devel] [PATCH v2 0/3] string-input-visitor: Support enum/bool alternate types

2017-05-05 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v2 0/3] string-input-visitor: Support enum/bool alternate types Message-id: 2017050

[Qemu-devel] [PATCH] fixup! sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-05-05 Thread Eduardo Habkost
On Fri, May 05, 2017 at 01:54:19PM -0300, Eduardo Habkost wrote: > On Fri, May 05, 2017 at 09:36:22AM +0200, Cornelia Huck wrote: > [...] > > > diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c > > > index c0f560b289..6a2eec8dd0 100644 > > > --- a/hw/core/sysbus.c > > > +++ b/hw/core/sysbus.c > > >

Re: [Qemu-devel] [PATCH v2] hw/virtio: fix vhost user fails to startup when MQ

2017-05-05 Thread Michael S. Tsirkin
On Fri, May 05, 2017 at 09:34:14AM +0200, Maxime Coquelin wrote: > Hi, > > On 05/04/2017 06:25 PM, Zhiyong Yang wrote: > > Qemu2.7~2.9 and vhost user for dpdk 17.02 release work together > > to cause failures of new connection when negotiating to set MQ. > > (one queue pair works well). > >

Re: [Qemu-devel] virtio-net: configurable TX queue size

2017-05-05 Thread Michael S. Tsirkin
On Fri, May 05, 2017 at 10:27:13AM +0800, Jason Wang wrote: > > > On 2017年05月04日 18:58, Wang, Wei W wrote: > > Hi, > > > > I want to re-open the discussion left long time ago: > > https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg06194.html > > , and discuss the possibility of changing th

Re: [Qemu-devel] [PATCH v2 07/24] pc: add node-id property to CPU

2017-05-05 Thread Eduardo Habkost
On Wed, May 03, 2017 at 02:57:01PM +0200, Igor Mammedov wrote: > it will allow switching from cpu_index to property based > numa mapping in follow up patches. > > Signed-off-by: Igor Mammedov > --- > hw/i386/pc.c | 17 + > target/i386/cpu.c | 1 + > 2 files changed, 18 inse

Re: [Qemu-devel] [PATCH v2 1/3] visitor: Add 'supported_qtypes' parameter to visit_start_alternate()

2017-05-05 Thread Eric Blake
On 05/05/2017 03:11 PM, Eduardo Habkost wrote: > This will allow visitors to make decisions based on the supported qtypes > of a given alternate type. The new parameter can replace the old > 'promote_int' argument, as qobject-input-visitor can simply check if > QTYPE_QINT is set in supported_qtypes

Re: [Qemu-devel] [PATCH v12 03/10] qcow2: Correctly report status of preallocated zero clusters

2017-05-05 Thread Max Reitz
On 04.05.2017 05:07, Eric Blake wrote: > We were throwing away the preallocation information associated with > zero clusters. But we should be matching the well-defined semantics > in bdrv_get_block_status(), where (BDRV_BLOCK_ZERO | > BDRV_BLOCK_OFFSET_VALID) informs the user which offset is rese

Re: [Qemu-devel] [PATCH v12 02/10] block: Update comments on BDRV_BLOCK_* meanings

2017-05-05 Thread Max Reitz
On 05.05.2017 22:13, Eric Blake wrote: > On 05/05/2017 03:06 PM, Max Reitz wrote: >> On 04.05.2017 05:07, Eric Blake wrote: >>> We had some conflicting documentation: a nice 8-way table that >>> described all possible combinations of DATA, ZERO, and >>> OFFSET_VALID, contrasted with text that impli

Re: [Qemu-devel] [PATCH v12 02/10] block: Update comments on BDRV_BLOCK_* meanings

2017-05-05 Thread Eric Blake
On 05/05/2017 03:06 PM, Max Reitz wrote: > On 04.05.2017 05:07, Eric Blake wrote: >> We had some conflicting documentation: a nice 8-way table that >> described all possible combinations of DATA, ZERO, and >> OFFSET_VALID, contrasted with text that implied that OFFSET_VALID >> always meant raw data

[Qemu-devel] [PATCH v2 1/3] visitor: Add 'supported_qtypes' parameter to visit_start_alternate()

2017-05-05 Thread Eduardo Habkost
This will allow visitors to make decisions based on the supported qtypes of a given alternate type. The new parameter can replace the old 'promote_int' argument, as qobject-input-visitor can simply check if QTYPE_QINT is set in supported_qtypes. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2

[Qemu-devel] [PATCH v2 2/3] qapi: Add enum_table[] parameter to start_alternate

2017-05-05 Thread Eduardo Habkost
The new parameter will be used by the string input visitor to detect alternate types that can't be parsed unambiguously. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * (new patch added to series) --- include/qapi/visitor.h | 10 +- include/qapi/visitor-impl.h | 4 +++- sc

[Qemu-devel] [PATCH v2 3/3] string-input-visitor: Support alternate types

2017-05-05 Thread Eduardo Habkost
When parsing alternates from a string, there are some limitations in what we can do, but it is a valid use case in some situations. We can support booleans, integer types, and enums. This will be used to support 'feature=force' in -cpu options, while keeping 'feature=on|off|true|false' represented

[Qemu-devel] [PATCH v2 0/3] string-input-visitor: Support enum/bool alternate types

2017-05-05 Thread Eduardo Habkost
v1 was originally part of the following series: [PATCH 0/4] x86: Support "-cpu feature=force" But as I am not sure yet "feature=force" is the right way to go, I decided to send only the string-input-visitor alternate support, in case the QAPI maintainers want to merge it anyway. Changes v1 ->

Re: [Qemu-devel] [PATCH] virtio-net: consolidate guest announcement with qemu_announce_self

2017-05-05 Thread Vlad Yasevich
On 05/02/2017 06:41 AM, Dr. David Alan Gilbert wrote: > * Vlad Yasevich (vyase...@redhat.com) wrote: >> On 03/30/2017 11:26 AM, Dr. David Alan Gilbert wrote: >>> * Vlad Yasevich (vyase...@redhat.com) wrote: On 03/30/2017 10:53 AM, Dr. David Alan Gilbert wrote: > * Vlad Yasevich (vyase...@r

Re: [Qemu-devel] [PATCH v12 02/10] block: Update comments on BDRV_BLOCK_* meanings

2017-05-05 Thread Max Reitz
On 04.05.2017 05:07, Eric Blake wrote: > We had some conflicting documentation: a nice 8-way table that > described all possible combinations of DATA, ZERO, and > OFFSET_VALID, contrasted with text that implied that OFFSET_VALID > always meant raw data could be read directly. Furthermore, the > te

Re: [Qemu-devel] [PATCH v2 12/24] numa: add numa_[has_]node_id() wrappers

2017-05-05 Thread Igor Mammedov
On Fri, 5 May 2017 14:12:26 -0300 Eduardo Habkost wrote: > On Fri, May 05, 2017 at 11:06:02AM +0200, Andrew Jones wrote: > > On Fri, May 05, 2017 at 10:09:18AM +0200, Igor Mammedov wrote: > > > On Fri, 5 May 2017 11:45:22 +1000 > > > David Gibson wrote: > > > > > > > On Wed, May 03, 2017 at 02:

Re: [Qemu-devel] [PATCH v2 10/24] numa: mirror cpu to node mapping in MachineState::possible_cpus

2017-05-05 Thread Igor Mammedov
On Fri, 5 May 2017 14:04:15 -0300 Eduardo Habkost wrote: > On Fri, May 05, 2017 at 02:16:48PM +0200, Igor Mammedov wrote: > > On Wed, 3 May 2017 12:20:22 -0300 > > Eduardo Habkost wrote: > > > > > On Wed, May 03, 2017 at 02:57:04PM +0200, Igor Mammedov wrote: > > > > Introduce machine_set_cpu_n

Re: [Qemu-devel] [PATCH v12 01/10] qcow2: Use consistent switch indentation

2017-05-05 Thread Max Reitz
On 04.05.2017 05:07, Eric Blake wrote: > Fix a couple of inconsistent indentations, before an upcoming > patch further tweaks the switch statements. While at it, make > some tweaks for shorter lines to keep checkpatch happy (best > viewed with 'git diff -b'). > > Signed-off-by: Eric Blake > > -

[Qemu-devel] [PATCH v6 4/5] shutdown: Preserve shutdown cause through replay

2017-05-05 Thread Eric Blake
With the recent addition of ShutdownCause, we want to be able to pass a cause through any shutdown request, and then faithfully replay that cause when later replaying the same sequence. The easiest way is to expand the reply event mechanism to track a series of values for EVENT_SHUTDOWN, one corre

[Qemu-devel] [PATCH v6 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events

2017-05-05 Thread Eric Blake
Libvirt would like to be able to distinguish between a SHUTDOWN event triggered solely by guest request and one triggered by a SIGTERM or other action on the host. While qemu_kill_report() was already able to give different output to stderr based on whether a shutdown was triggered by a host signa

[Qemu-devel] [PATCH v6 1/5] shutdown: Simplify shutdown_signal

2017-05-05 Thread Eric Blake
There is no signal 0 (kill(pid, 0) has special semantics to probe whether a process is alive), rather than actually sending a signal 0). So we can use the simpler 0, instead of -1, for our sentinel of whether a shutdown request due to a signal has happened. Suggested-by: Markus Armbruster Signed

[Qemu-devel] [PATCH v6 3/5] shutdown: Add source information to SHUTDOWN and RESET

2017-05-05 Thread Eric Blake
Time to wire up all the call sites that request a shutdown or reset to use the enum added in the previous patch. It would have been less churn to keep the common case with no arguments as meaning guest-triggered, and only modified the host-triggered code paths, via a wrapper function, but then we'

[Qemu-devel] [PATCH v6 0/5] event: Add source information to SHUTDOWN

2017-05-05 Thread Eric Blake
v2 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg03185.html v3 and v4 were dead on arrival v5 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg05564.html Since then: - rework the enum to be internal only - add a 'none' slot to the enum, so that we are back to

[Qemu-devel] [PATCH v6 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-05-05 Thread Eric Blake
We want to track why a guest was shutdown; in particular, being able to tell the difference between a guest request (such as ACPI request) and host request (such as SIGINT) will prove useful to libvirt. Since all requests eventually end up changing shutdown_requested in vl.c, the logical change is

Re: [Qemu-devel] [PATCH] Revert "Change net/socket.c to use socket_*() functions" again

2017-05-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] Revert "Change net/socket.c to use socket_*() functions" again Message-id: 20170505162305.15763-1-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH] block: Simplify BDRV_BLOCK_RAW recursion

2017-05-05 Thread Max Reitz
On 04.05.2017 19:37, Eric Blake wrote: > Since we are already in coroutine context during the body of > bdrv_co_get_block_status(), we can shave off a few layers of > wrappers when recursing to query the protocol when a format driver > returned BDRV_BLOCK_RAW. > > Note that we are already using th

Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-05 Thread Eduardo Habkost
On Thu, May 04, 2017 at 12:16:38PM +0200, Kashyap Chamarthy wrote: > On Tue, May 02, 2017 at 05:31:15PM -0300, Eduardo Habkost wrote: > > Hi, > > Yet to try this series, a small question in-line. > > > Introduce a new CPUFeatureSetting QAPI data type, and use it to support > > feature=force on -

[Qemu-devel] [PATCH 08/10] s390x/css: add ORB to SubchDev

2017-05-05 Thread Halil Pasic
Since we are going to need a migration compatibility breaking change to activate ChannelSubSys migration let us use the opportunity to introduce ORB to the SubchDev before that (otherwise we would need separate handling e.g. a compat property). The ORB will be useful for implementing IDA, or async

[Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

2017-05-05 Thread Halil Pasic
Let us use the freshly introduced vmstate migration helpers instead of saving/loading the config manually. To achieve this we need to hack the config_vector which is a common VirtIO state in the middle of the VirtioCcwDevice state representation. This somewhat ugly but we have no choice because th

Re: [Qemu-devel] [PATCH v2 1/2] i386: rewrite way CPUID index is validated

2017-05-05 Thread Eduardo Habkost
On Fri, May 05, 2017 at 03:27:42PM +0100, Daniel P. Berrange wrote: > Change the nested if statements into a flat switch, to make > it clearer what validation / capping is being performed on > different CPUID index values. > > Signed-off-by: Daniel P. Berrange > --- > target/i386/cpu.c | 43

[Qemu-devel] [PATCH 05/10] virtio-ccw: add vmstate entities for VirtioCcwDevice

2017-05-05 Thread Halil Pasic
As a preparation for a transition to a vmstate based migration let us introduce vmstate entities for VirtioCcwDevice and its members. This patch does not take care of config_vector which is common VirtIO state but not migrated by common VirtiIO code. No changes in behavior, we just added some dead

[Qemu-devel] [PATCH 09/10] s390x/css: turn on channel subsystem migration

2017-05-05 Thread Halil Pasic
Turn on migration for the channel subsystem and the new scheme for migrating virtio-ccw proxy devices (instead of letting the transport independent child device migrate it's proxy, use the usual DeviceClass.vmsd mechanism) for future machine versions. The vmstate based migration of the channel sub

[Qemu-devel] [PATCH 02/10] s390x: add css_migration_enabled to machine class

2017-05-05 Thread Halil Pasic
Currently the migration of the channel subsystem (css) is only partial and is done by the virtio ccw proxies -- the only css devices existing at the moment. With the current efforts towards emulated and passthrough devices we need to improve on the migration of the css. This however will necessaril

[Qemu-devel] [PATCH 01/10] s390x: add helper get_machine_class

2017-05-05 Thread Halil Pasic
We will need the machine class at machine initialization time, so the usual way via qdev won't do. Let's cache the machine class and also use the default values of the base machine for capability discovery. Signed-off-by: Halil Pasic --- hw/s390x/s390-virtio-ccw.c | 46 +++---

[Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-05 Thread Halil Pasic
As a preparation for switching to a vmstate based migration let us introduce vmstate entities (e.g. VMStateDescription) for the css entities to be migrated. Alongside some comments explaining or indicating the not migration of certain members are introduced too. No changes in behavior, we just add

[Qemu-devel] [PATCH 10/10] s390x/css: use SubchDev.orb

2017-05-05 Thread Halil Pasic
Instead of passing around a pointer to ORB let us simplify some functions signatures by using the previously introduced ORB saved at the subchannel (SubchDev). Signed-off-by: Halil Pasic Reviewed-by: Guenther Hutzl --- hw/s390x/css.c | 19 +-- 1 file changed, 9 insertions(+), 10

[Qemu-devel] [PATCH 00/10] migration: s390x css migration

2017-05-05 Thread Halil Pasic
This patch set has a dual purpose: introduce proper migration for the channel subsystem (css) and convert the migration of ccw devices to vmstate. The state of the css was only partially migrated by the virtio-ccw devices (was the only device type until recent), which was good enough for a while.

[Qemu-devel] [PATCH 07/10] s390x/css: remove unused subch_dev_(load|save)

2017-05-05 Thread Halil Pasic
Since the functions subch_dev_load and subch_dev save are not used any more let's remove them. Signed-off-by: Halil Pasic Reviewed-by: Guenther Hutzl --- hw/s390x/css.c | 143 - include/hw/s390x/css.h | 2 - 2 files changed, 145 deletion

[Qemu-devel] [PATCH 04/10] s390x/css: add vmstate macro for CcwDevice

2017-05-05 Thread Halil Pasic
As a preparation for switching to a vmstate based migration let us introduce a vmstate macro for CcwDevice. No changes in behavior, we just added some dead code -- which should rise to life soon. Signed-off-by: Halil Pasic Reviewed-by: Guenther Hutzl --- hw/s390x/ccw-device.c | 10 ++

Re: [Qemu-devel] [PATCH 1/5] 9pfs: check return value of v9fs_co_name_to_path()

2017-05-05 Thread Greg Kurz
On Fri, 5 May 2017 11:55:43 -0500 Eric Blake wrote: > On 05/05/2017 09:37 AM, Greg Kurz wrote: > > These v9fs_co_name_to_path() call sites have always been around. I guess > > no care was taken to check the return value because the name_to_path > > operation could never fail at the time. This is

Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

2017-05-05 Thread Eduardo Habkost
On Thu, May 04, 2017 at 11:49:38AM +0200, Igor Mammedov wrote: > On Tue, 2 May 2017 17:31:15 -0300 > Eduardo Habkost wrote: > > > Introduce a new CPUFeatureSetting QAPI data type, and use it to support > > feature=force on -cpu. > commit message lacks rationale why it's needed. > I suspect that

Re: [Qemu-devel] [PATCH 5/5] 9pfs: local: forbid client access to metadata

2017-05-05 Thread Eric Blake
On 05/05/2017 09:37 AM, Greg Kurz wrote: > When using the mapped-file security mode, we shouldn't let the client > mess with the metadata. The current code already hides it but the > client can still access the metadata through several operations. > > This patch fixes the issue by: > - preventing

Re: [Qemu-devel] [PATCH v2 12/24] numa: add numa_[has_]node_id() wrappers

2017-05-05 Thread Eduardo Habkost
On Fri, May 05, 2017 at 11:06:02AM +0200, Andrew Jones wrote: > On Fri, May 05, 2017 at 10:09:18AM +0200, Igor Mammedov wrote: > > On Fri, 5 May 2017 11:45:22 +1000 > > David Gibson wrote: > > > > > On Wed, May 03, 2017 at 02:57:06PM +0200, Igor Mammedov wrote: > > > > wrappers should make access

Re: [Qemu-devel] [PATCH 4/5] 9pfs: local: metadata file for the VirtFS root

2017-05-05 Thread Eric Blake
On 05/05/2017 09:37 AM, Greg Kurz wrote: > When using the mapped-file security, credentials are stored in a metadata > directory located in the parent directory. This is okay for all paths with > the notable exception of the root path, since we don't want and probably > can't create a metadata dire

Re: [Qemu-devel] [PATCH v2 10/24] numa: mirror cpu to node mapping in MachineState::possible_cpus

2017-05-05 Thread Eduardo Habkost
On Fri, May 05, 2017 at 02:16:48PM +0200, Igor Mammedov wrote: > On Wed, 3 May 2017 12:20:22 -0300 > Eduardo Habkost wrote: > > > On Wed, May 03, 2017 at 02:57:04PM +0200, Igor Mammedov wrote: > > > Introduce machine_set_cpu_numa_node() helper that stores > > > node mapping for CPU in MachineStat

Re: [Qemu-devel] [PATCH 3/5] 9pfs: local: simplify file opening

2017-05-05 Thread Eric Blake
On 05/05/2017 09:37 AM, Greg Kurz wrote: > All paths in the virtfs directory now start with "./" (except the virtfs > root itself which is exactly "."). > > We hence don't need to skip leading '/' characters anymore, nor to handle > the empty path case. Also, since virtfs will only ever be support

Re: [Qemu-devel] [PATCH qemu v6] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-05-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH qemu v6] memory/iommu: QOM'fy IOMMU MemoryRegion Message-id: 20170505101930.45837-1-...@ozlabs.ru === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=

Re: [Qemu-devel] [PATCH 2/5] 9pfs: local: resolve special directories in paths

2017-05-05 Thread Eric Blake
On 05/05/2017 09:37 AM, Greg Kurz wrote: > When using the mapped-file security mode, the creds of a path /foo/bar > are stored in the /foo/.virtfs_metadata/bar file. This is okay for all > paths unless they end with '.' or '..', because we cannot create the > corresponding file in the metadata dire

Re: [Qemu-devel] [PATCH 1/5] 9pfs: check return value of v9fs_co_name_to_path()

2017-05-05 Thread Eric Blake
On 05/05/2017 09:37 AM, Greg Kurz wrote: > These v9fs_co_name_to_path() call sites have always been around. I guess > no care was taken to check the return value because the name_to_path > operation could never fail at the time. This is no longer true: the > handle and synth backends can already fa

Re: [Qemu-devel] [PATCH RESEND v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-05-05 Thread Eduardo Habkost
On Fri, May 05, 2017 at 09:36:22AM +0200, Cornelia Huck wrote: [...] > > diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c > > index c0f560b289..6a2eec8dd0 100644 > > --- a/hw/core/sysbus.c > > +++ b/hw/core/sysbus.c > > @@ -326,6 +326,17 @@ static void sysbus_device_class_init(ObjectClass > > *kla

Re: [Qemu-devel] [PATCH RFC] i386: expose "TCGTCGTCGTCG" in the 0x40000000 CPUID leaf

2017-05-05 Thread Eduardo Habkost
On Fri, May 05, 2017 at 12:46:21PM +0100, Daniel P. Berrange wrote: > On Thu, May 04, 2017 at 03:42:41PM -0300, Eduardo Habkost wrote: > > On Thu, May 04, 2017 at 03:56:58PM +0100, Daniel P. Berrange wrote: > > > Currently when running KVM, we expose "KVMKVMKVM\0\0\0" in > > > the 0x4000 CPUID

Re: [Qemu-devel] [PATCH v2 0/4] Convert non-blocking connect and fix its error reporting

2017-05-05 Thread Daniel P. Berrange
On Wed, Apr 26, 2017 at 04:04:14PM +0800, Mao Zhongyi wrote: > v2: > * PATCH 02 reworking of patch 2 following Markus's suggestion that convert > error_report() > in the function called by net_socket_*_init() to Error. Also add many error > handling > information. > * PATCH 03 net_socket_mcas

Re: [Qemu-devel] [PATCH v3] ui: input-linux: Add absolute event support

2017-05-05 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v3] ui: input-linux: Add absolute event support Message-id: 20170505134231.30210-1-p

  1   2   3   >