Re: [Qemu-devel] [PATCH 2/6] spapr: fix error path of required kernel-irqchip

On Tue, 16 May 2017 14:35:55 +1000 David Gibson wrote: > On Mon, May 15, 2017 at 01:39:26PM +0200, Greg Kurz wrote: > > QEMU should exit if the user explicitely asked for kernel-irqchip support > > and "xics-kvm" initialization fails. > > > > The changelog of commit

Re: [Qemu-devel] [PATCH] fix mingw build failure

Am 16.05.2017 um 07:24 schrieb Gerd Hoffmann: Signed-off-by: Gerd Hoffmann --- crypto/random-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/random-platform.c b/crypto/random-platform.c index 0eddb915b7..92eed0ee78 100644 ---

[Qemu-devel] [PATCH] fix mingw build failure

Signed-off-by: Gerd Hoffmann --- crypto/random-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/random-platform.c b/crypto/random-platform.c index 0eddb915b7..92eed0ee78 100644 --- a/crypto/random-platform.c +++ b/crypto/random-platform.c

Re: [Qemu-devel] [PATCH 4/6] spapr: sanitize error handling in spapr_ics_create()

On Mon, May 15, 2017 at 01:39:45PM +0200, Greg Kurz wrote: > The spapr_ics_create() function handles errors in a rather convoluted > way, with two local Error * variables. Moreover, failing to parent the > ICS object to the machine should be considered as a bug but it is > currently ignored. > >

Re: [Qemu-devel] [PATCH 4/6] spapr: sanitize error handling in spapr_ics_create()

On Mon, May 15, 2017 at 02:06:18PM +0200, Greg Kurz wrote: > On Mon, 15 May 2017 13:59:33 +0200 > Cédric Le Goater wrote: > > > On 05/15/2017 01:39 PM, Greg Kurz wrote: > > > The spapr_ics_create() function handles errors in a rather convoluted > > > way, with two local Error *

Re: [Qemu-devel] [PATCH 5/6] spapr-cpu-core: release ICP object when realization fails

On Mon, May 15, 2017 at 01:39:55PM +0200, Greg Kurz wrote: > While here we introduce a single error path to avoid code duplication. > > Signed-off-by: Greg Kurz Applied to ppc=for-2.10. > --- > hw/ppc/spapr_cpu_core.c | 16 > 1 file changed, 8 insertions(+),

Re: [Qemu-devel] [PATCH 3/6] spapr: fix error reporting in xics_system_init()

On Mon, May 15, 2017 at 01:39:36PM +0200, Greg Kurz wrote: > The xics_system_init() function passes its errp argument to xics_kvm_init(). > If the call fails and the user requested in-kernel irqchip, it then ends up > passing a NULL Error * to error_reportf_err() and the error message is >

Re: [Qemu-devel] [PATCH 2/6] spapr: fix error path of required kernel-irqchip

On Mon, May 15, 2017 at 01:39:26PM +0200, Greg Kurz wrote: > QEMU should exit if the user explicitely asked for kernel-irqchip support > and "xics-kvm" initialization fails. > > The changelog of commit 34f2af3d3edf ("spapr: Clean up misuse of qdev_init() > in xics-kvm creation") reads: > >

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] virtio-net: keep the packet layout intact

On 05/16/2017 12:27 PM, Wei Wang wrote: On 05/15/2017 10:46 PM, Michael S. Tsirkin wrote: On Mon, May 15, 2017 at 05:29:15PM +0800, Wei Wang wrote: Ping for comments, thanks. On 05/11/2017 12:57 PM, Wei Wang wrote: The current implementation may change the packet layout when vnet_hdr needs

Re: [Qemu-devel] [PATCH 1/6] ppc/xics: simplify prototype of xics_spapr_init()

On Mon, May 15, 2017 at 01:39:16PM +0200, Greg Kurz wrote: > This function only does hypercall and RTAS-call registration, and thus > never returns an error. This patch adapt the prototype to reflect that. > > Signed-off-by: Greg Kurz Applied to ppc-for-2.10, thanks. > --- >

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] virtio-net: keep the packet layout intact

On 05/15/2017 10:46 PM, Michael S. Tsirkin wrote: On Mon, May 15, 2017 at 05:29:15PM +0800, Wei Wang wrote: Ping for comments, thanks. On 05/11/2017 12:57 PM, Wei Wang wrote: The current implementation may change the packet layout when vnet_hdr needs an endianness swap. The layout change

Re: [Qemu-devel] [PATCH 1/4] exec: simplify phys_page_find() params

On Mon, May 15, 2017 at 04:50:57PM +0800, Peter Xu wrote: > It really only plays with the dispatchers, so the parameter list does > not need that complexity. This helps for readability at least. > > Signed-off-by: Peter Xu Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH] target/ppc: reset reservation in do_rfi()

On Mon, May 15, 2017 at 02:05:09PM +0530, Nikunj A Dadhania wrote: > For transitioning back to userspace after the interrupt. > > Suggested-by: Richard Henderson > Signed-off-by: Nikunj A Dadhania Applied to ppc-for-2.10. thanks. > --- >

Re: [Qemu-devel] [PATCH v10] migration: spapr: migrate pending_events of spapr state

On Mon, May 15, 2017 at 10:10:52AM -0300, Daniel Henrique Barboza wrote: > From: Jianjun Duan > > In racing situations between hotplug events and migration operation, > a rtas hotplug event could have not yet be delivered to the source > guest when migration is started.

Re: [Qemu-devel] [PATCH v18 1/2] virtio-crypto: Add virtio crypto device specification

Hi Halil, Sorry for delay because I'm busy on inner production project recently. > > > START HERE > > > +The device can set the operation status as follows: VIRTIO_CRYPTO_OK: > success; > > +VIRTIO_CRYPTO_ERR: failure or device error; VIRTIO_CRYPTO_NOTSUPP: > not supported; > >

Re: [Qemu-devel] [PATCH v2] migration: Move check_migratable() into qdev.c

On Fri, May 12, 2017 at 05:54:36PM +0200, Juan Quintela wrote: > The function is only used once, and nothing else in migration knows > about objects. Create the function vmstate_device_is_migratable() in > savem.c that really do the bit that is related with migration. (may need to touch up the

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

> > On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: > > > >> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > >> Sent: Friday, May 12, 2017 7:02 PM > >> > >> > >> On 05/08/2017 01:38 PM, Gonglei wrote: > >>> According to the new spec, we should use different > >>> requst structure to store the

Re: [Qemu-devel] [PATCH] block: Use QDict helpers for --force-share

On Mon, 05/15 14:54, Eric Blake wrote: > Fam's addition of --force-share in commits 459571f7 and 335e9937 > were developed prior to the addition of QDict scalar insertion > macros, but merged after the general cleanup in commit 46f5ac20. > Patch created mechanically by rerunning: > > spatch

[Qemu-devel] [PATCH] SMM: disable smram region if smm is disabled

when smm is disabled, smram is not used, so disable it Signed-off-by: Anthony Xu --- hw/pci-host/piix.c | 45 +++-- hw/pci-host/q35.c | 83 +- kvm-all.c | 3 +- target/i386/kvm.c | 2

Re: [Qemu-devel] Installing Windows with virtio (was: QEMU, increase graphics memory)

Hello Fam. I managed to installed Windows with the *Virtio* drivers. Thanks for your tip. It has made a change in that I got 2X more graphics memory. But not nearly enough. I need 512 and now I have 16. How do I specify to Virtio how much memory to allocate? Thanks Jenia On Sun, May 14, 2017

[Qemu-devel] [PATCH] coccinelle: fix typo in comment

Signed-off-by: Philippe Mathieu-Daudé --- scripts/coccinelle/return_directly.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coccinelle/return_directly.cocci b/scripts/coccinelle/return_directly.cocci index 48680f2c2a..4cf50e75ea 100644 ---

[Qemu-devel] [PATCH] oslib: strip trailing '\n' from error_setg() string argument

spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci Signed-off-by: Philippe Mathieu-Daudé --- util/oslib-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 4d9189e9ef..7ca02f0103 100644 ---

Re: [Qemu-devel] [Qemu-arm] Changes to Broadcom(BCM) files and Raspberry Pi files. Addition of PanelEmu

Hi, The XML files in the base are not in the patch. They where net beans files. I can easily get it into 3 files, one large at 91KB but contains only new files and so is easy to read. Could be smaller but seems pointless. another which is about 19KB of quite simple changes to mostly make

Re: [Qemu-devel] [PATCH v4 5/6] target/ppc: optimize various functions using extract op

Hi David, On 05/15/2017 01:12 AM, David Gibson wrote: On Fri, May 12, 2017 at 08:38:42PM -0300, Philippe Mathieu-Daudé wrote: Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file

Re: [Qemu-devel] [PATCH] configure: Remove -lxencall for Xen detection

On Thu, 11 May 2017, Anthony PERARD wrote: > QEMU does not depends on libxencall, it was added because it was a > missing link dependency of libxendevicemodel, but now the later should > be built properly. > > Signed-off-by: Anthony PERARD Reviewed-by: Stefano

Re: [Qemu-devel] [PATCH v2 05/16] linux-user: fix argument type declaration of rt_sigqueinfo() syscall

On 05/15/2017 11:59 AM, Miloš Stojanović wrote: Change the type of the first argument of rt_sigqueinfo() from int to pid_t in the syscall declaration to match specifications of the system call. Proper spacing is added to satisfy checkpatch.pl. Signed-off-by: Miloš Stojanović

Re: [Qemu-devel] [PATCH v2 01/16] linux-user: add strace for getuid(), gettid(), getppid(), geteuid()

On 05/15/2017 11:59 AM, Miloš Stojanović wrote: Improve strace support for syscalls getuid(), gettid(), getppid() and geteuid(). Since these system calls don't have arguments, "%s()" is added in the corresponding strace.list entry so that no arguments are printed. getuid: Prior to this commit,

Re: [Qemu-devel] [Qemu-arm] Changes to Broadcom(BCM) files and Raspberry Pi files. Addition of PanelEmu

Hi John, That is going to be very difficult as a lot of the changes are interlinked the vast majority of the patch is new files. I rebased your branch on latest qemu/master here: https://github.com/philmd/qemu/tree/flypie-GDummyPanel-rebased It is much easier to follow now, the big XML

[Qemu-devel] Where did my previous post go?

Hello. I made a post in this group (QEMU). Then I received an email: Re: [Qemu-devel] Installing Windows with virtio (was: QEMU, increase graphics memory) There is no Qemu-devel group in gmane as far as I can see. How can I find my post and reply to it (to the replies it received

[Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET

Time to wire up all the call sites that request a shutdown or reset to use the enum added in the previous patch. It would have been less churn to keep the common case with no arguments as meaning guest-triggered, and only modified the host-triggered code paths, via a wrapper function, but then

[Qemu-devel] [PATCH v9 3/5] shutdown: Preserve shutdown cause through replay

With the recent addition of ShutdownCause, we want to be able to pass a cause through any shutdown request, and then faithfully replay that cause when later replaying the same sequence. The easiest way is to expand the reply event mechanism to track a series of values for EVENT_SHUTDOWN, one

[Qemu-devel] [PATCH v9 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events

Libvirt would like to be able to distinguish between a SHUTDOWN event triggered solely by guest request and one triggered by a SIGTERM or other action on the host. While qemu_kill_report() was already able to give different output to stderr based on whether a shutdown was triggered by a host

[Qemu-devel] [PATCH v9 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request

We want to track why a guest was shutdown; in particular, being able to tell the difference between a guest request (such as ACPI request) and host request (such as SIGINT) will prove useful to libvirt. Since all requests eventually end up changing shutdown_requested in vl.c, the logical change is

Re: [Qemu-devel] Changes to Broadcom(BCM) files and Raspberry Pi files. Addition of PanelEmu

Hi, That is going to be very difficult as a lot of the changes are interlinked the vast majority of the patch is new files. John BradleyTel: 07896 839635Skype: flypie125 125B Grove StreetEdge Hill Liverpool L7 7AF On Monday, 15 May 2017, 17:54, Alistair Francis

[Qemu-devel] [PATCH v9 1/5] shutdown: Simplify shutdown_signal

There is no signal 0 (kill(pid, 0) has special semantics to probe whether a process is alive), rather than actually sending a signal 0). So we can use the simpler 0, instead of -1, for our sentinel of whether a shutdown request due to a signal has happened. Suggested-by: Markus Armbruster

[Qemu-devel] [PATCH v9 0/5] event: Add source information to SHUTDOWN

v6 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg01380.html v7 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg01848.html v8 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg03599.html Since then: - one more comment fix in patch 2 [Markus]

Re: [Qemu-devel] [PATCH v8 0/5] event: Add source information to SHUTDOWN

On 05/15/2017 03:37 PM, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Checking PATCH 5/5: shutdown: Expose bool cause in SHUTDOWN and RESET > events... > ERROR: open brace '{' following function

Re: [Qemu-devel] [Qemu-block] [PATCH 01/13] vvfat: fix qemu-img map and qemu-img convert

On 05/15/2017 03:31 PM, Hervé Poussineau wrote: > - bs->total_sectors is the number of sectors of the whole disk > - s->sector_count is the number of sectors of the FAT partition > > This fixes the following assert in qemu-img map: > qemu-img.c:2641: get_block_status: Assertion `nb_sectors'

Re: [Qemu-devel] [PATCH v8 0/5] event: Add source information to SHUTDOWN

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v8 0/5] event: Add source information to SHUTDOWN Message-id: 20170515194149.16288-1-ebl...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH 10/13] vvfat: correctly generate numeric-tail of short file names

More specifically: - try without numeric-tail only if LFN didn't have invalid short chars - start at ~1 (instead of ~0) - handle case if numeric tail is more than one char (ie > 10) Windows 9x Scandisk doesn't see anymore mismatches between short file names and long file names for non-ASCII

[Qemu-devel] [PATCH 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir

- offset_to_bootsector is the number of sectors up to FAT bootsector - offset_to_fat is the number of sectors up to first File Allocation Table - offset_to_root_dir is the number of sectors up to root directory sector Replace first_sectors_number - 1 by offset_to_bootsector. Replace

[Qemu-devel] [PATCH 01/13] vvfat: fix qemu-img map and qemu-img convert

- bs->total_sectors is the number of sectors of the whole disk - s->sector_count is the number of sectors of the FAT partition This fixes the following assert in qemu-img map: qemu-img.c:2641: get_block_status: Assertion `nb_sectors' failed. This also fixes an infinite loop in qemu-img convert.

[Qemu-devel] [PATCH 13/13] vvfat: change OEM name to 'MSWIN4.1'

According to specification: "'MSWIN4.1' is the recommanded setting, because it is the setting least likely to cause compatibility problems. If you want to put something else in here, that is your option, but the result may be that some FAT drivers might not recognize the volume." Specification:

[Qemu-devel] [PATCH 02/13] vvfat: replace tabs by 8 spaces

This was a complete mess. On 2299 indented lines: - 1329 were with spaces only - 617 with tabulations only - 353 with spaces and tabulations Signed-off-by: Hervé Poussineau --- block/vvfat.c | 2054 - 1 file changed,

[Qemu-devel] [PATCH 07/13] vvfat: always create . and .. entries at first and in that order

readdir() doesn't always return . and .. entries at first and in that order. This leads to not creating them at first in the directory, which raises some errors on file system checking utilities like MS-DOS Scandisk. Specification: "FAT: General overview of on-disk format" v1.03, page 25 Fixes:

[Qemu-devel] [PATCH 08/13] vvfat: correctly create long names for non-ASCII filenames

Assume that input filename is encoded as UTF-8, so correctly create UTF-16 encoding. Reuse long_file_name structure to give back to caller the generated long name. It will be used in next commit to transform the long file name into short file name. Reference:

[Qemu-devel] [PATCH 11/13] vvfat: limit number of entries in root directory in FAT12/FAT16

FAT12/FAT16 root directory is two sectors in size, which allows only 512 directory entries. Prevent QEMU startup if too much files exist, instead of overflowing root directory. Also introduce variable root_entries, which will be required if we support loading a custom bootsector

[Qemu-devel] [PATCH 12/13] vvfat: handle KANJI lead byte 0xe5

Specification: "FAT: General overview of on-disk format" v1.03, page 23 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 7b21d6bb21..f96034cda1 100644 ---

[Qemu-devel] [PATCH 06/13] vvfat: fix field names in FAT12/FAT16 boot sector

Specification: "FAT: General overview of on-disk format" v1.03, page 11 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index f60d2a3889..348cffe1c4 100644 ---

[Qemu-devel] [PATCH 09/13] vvfat: correctly create base short names for non-ASCII filenames

More specifically, create short name from long name and change blacklist of invalid chars to whitelist of valid chars. Windows 9x also now correctly see long file names of filenames containing a space, but Scandisk still complains about mismatch between SFN and LFN. Specification: "FAT: General

[Qemu-devel] [PATCH 03/13] vvfat: fix typos

Signed-off-by: Hervé Poussineau --- block/vvfat.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 002bd86e42..57f2489689 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -404,9 +404,9 @@ static void

[Qemu-devel] [PATCH 00/13] vvfat: misc fixes for read-only mode

Hi, This patchset fixes some of issues I encountered when trying to use vvfat, and fixes bug #1599539: https://bugs.launchpad.net/qemu/+bug/1599539 Patch 1 fixes a crash when using 'qemu-img convert'. Patches 2 to 6 are code cleanup. No functionnal changes. Patches 6 to 12 fix problems detected

[Qemu-devel] [PATCH 04/13] vvfat: rename useless enumeration values

MODE_FAKED and MODE_RENAMED are not and were never used. Signed-off-by: Hervé Poussineau --- block/vvfat.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 57f2489689..4f4a63c03f 100644 ---

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll

On Mon, May 15, 2017 at 09:12:54PM +0200, Max Reitz wrote: > On 2017-05-10 17:57, Richard W.M. Jones wrote: > > On Wed, May 10, 2017 at 04:31:58PM +0200, Paolo Bonzini wrote: > >> Since the last patch in v1 didn't work, I bit the bullet and converted > >> the whole thing to coroutines (patches

[Qemu-devel] [PATCH] block: Use QDict helpers for --force-share

Fam's addition of --force-share in commits 459571f7 and 335e9937 were developed prior to the addition of QDict scalar insertion macros, but merged after the general cleanup in commit 46f5ac20. Patch created mechanically by rerunning: spatch --sp-file scripts/coccinelle/qobject.cocci \

[Qemu-devel] [PATCH v8 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events

Libvirt would like to be able to distinguish between a SHUTDOWN event triggered solely by guest request and one triggered by a SIGTERM or other action on the host. While qemu_kill_report() was already able to give different output to stderr based on whether a shutdown was triggered by a host

[Qemu-devel] [PATCH v8 4/5] shutdown: Add source information to SHUTDOWN and RESET

Time to wire up all the call sites that request a shutdown or reset to use the enum added in the previous patch. It would have been less churn to keep the common case with no arguments as meaning guest-triggered, and only modified the host-triggered code paths, via a wrapper function, but then

[Qemu-devel] [PATCH v8 1/5] shutdown: Simplify shutdown_signal

There is no signal 0 (kill(pid, 0) has special semantics to probe whether a process is alive), rather than actually sending a signal 0). So we can use the simpler 0, instead of -1, for our sentinel of whether a shutdown request due to a signal has happened. Suggested-by: Markus Armbruster

[Qemu-devel] [PATCH v8 3/5] shutdown: Preserve shutdown cause through replay

With the recent addition of ShutdownCause, we want to be able to pass a cause through any shutdown request, and then faithfully replay that cause when later replaying the same sequence. The easiest way is to expand the reply event mechanism to track a series of values for EVENT_SHUTDOWN, one

[Qemu-devel] [PATCH v8 0/5] event: Add source information to SHUTDOWN

v6 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg01380.html v7 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg01848.html Since then: - reorder the series [Markus] - tweak some comments [Markus] - add helper function in patch 5 [Markus] 001/5:[] [--]

[Qemu-devel] [PATCH v8 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request

We want to track why a guest was shutdown; in particular, being able to tell the difference between a guest request (such as ACPI request) and host request (such as SIGINT) will prove useful to libvirt. Since all requests eventually end up changing shutdown_requested in vl.c, the logical change is

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll

On 2017-05-15 12:00, Paolo Bonzini wrote: > Compared to v2, this silences checkpatch and correctly destroy the mutex on > exiting from curl_open with an error. > > Paolo > > Paolo Bonzini (7): > curl: strengthen assertion in curl_clean_state > curl: never invoke callbacks with s->mutex held

Re: [Qemu-devel] [PATCH v4] qemu-img: Check for backing image if specified during create

On 2017-05-15 20:41, Max Reitz wrote: > On 2017-05-12 21:47, John Snow wrote: >> >> >> On 05/12/2017 03:46 PM, Eric Blake wrote: >>> On 05/12/2017 01:07 PM, Max Reitz wrote: On 2017-05-11 20:27, John Snow wrote: > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1213786 > > Or,

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll

On 2017-05-10 17:57, Richard W.M. Jones wrote: > On Wed, May 10, 2017 at 04:31:58PM +0200, Paolo Bonzini wrote: >> Since the last patch in v1 didn't work, I bit the bullet and converted >> the whole thing to coroutines (patches 4-6). This in turns allows a more >> elegant solution to wait for

[Qemu-devel] [PATCH] gluster: add support for PREALLOC_MODE_FALLOC

Add missing support for "preallocation=falloc" to the Gluster block driver. This change bases its logic on that of block/file-posix.c and removed the gluster_supports_zerofill() function in favour of an #ifdef check in an easy to read switch-statement. Reported-by: Satheesaran Sundaramoorthi

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/08/2017 08:42 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 05/08/2017 07:59 PM, Dr. David Alan Gilbert wrote: > >> const VMStateDescription vmstate_virtio_ccw_dev = { >

Re: [Qemu-devel] [PATCH] 9pfs: local: forbid client access to metadata (CVE-2017-7493)

On Mon, 15 May 2017 12:37:08 -0500 Eric Blake wrote: > On 05/15/2017 11:07 AM, Greg Kurz wrote: > > When using the mapped-file security mode, we shouldn't let the client mess > > with the metadata. The current code already tries to hide the metadata dir > > from the client by

Re: [Qemu-devel] [PATCH v4] qemu-img: Check for backing image if specified during create

On 2017-05-12 21:47, John Snow wrote: > > > On 05/12/2017 03:46 PM, Eric Blake wrote: >> On 05/12/2017 01:07 PM, Max Reitz wrote: >>> On 2017-05-11 20:27, John Snow wrote: Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1213786 Or, rather, force the open of a backing image if

Re: [Qemu-devel] [PATCH v9 01/13] qcow2: Unallocate unmapped zero clusters if no backing file

On 2017-05-13 01:00, John Snow wrote: > > > On 05/12/2017 12:06 PM, Max Reitz wrote: >> On 2017-05-11 16:56, Eric Blake wrote: >>> [revisiting this older patch version, even though the final version in >>> today's pull request changed somewhat from this approach] >>> >>> On 04/12/2017 04:49 AM,

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > >> Forget -b/-i. > >> > >> migration_set_parameter compression_threads 8 > >> > >> migrate > >> > >> We don't use compression_threads at all > >> > >> migrate_set_capability compress > >>

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

The patch with CPUID_DE has apparently been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=b6c5a6f021f485fc36 So has this issue now been fixed in the current version of QEMU? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> As a preparation for switching to a vmstate based migration let us > >> introduce vmstate entities (e.g. VMStateDescription) for

Re: [Qemu-devel] [PATCH] qemu-img: Fix leakage of options on error

On 2017-05-15 16:10, Fam Zheng wrote: > Reported by Coverity. > > Signed-off-by: Fam Zheng > --- > qemu-img.c | 1 + > 1 file changed, 1 insertion(+) Thanks, applied to my block branch: https://github.com/XanClic/qemu/commits/block Max signature.asc Description: OpenPGP

Re: [Qemu-devel] [PATCH v10 0/4] Improve convert and dd commands

On 2017-05-15 18:47, Daniel P. Berrange wrote: > Update to > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05699.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg00728.html > v3: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg04391.html > v4:

Re: [Qemu-devel] [PATCH v10 3/4] qemu-img: introduce --target-image-opts for 'convert' command

On 05/15/2017 11:47 AM, Daniel P. Berrange wrote: > The '--image-opts' flag indicates whether the source filename > includes options. The target filename has to remain in the > plain filename format though, since it needs to be passed to > bdrv_create(). When using --skip-create though, it would

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

"Dr. David Alan Gilbert" wrote: >> Forget -b/-i. >> >> migration_set_parameter compression_threads 8 >> >> migrate >> >> We don't use compression_threads at all >> >> migrate_set_capability compress >> >> migrate >> >> Now, we use compression threads. >> >> So,

Re: [Qemu-devel] [PATCH v9 4/4] qemu-img: copy *key-secret opts when opening newly created files

On 2017-05-15 19:43, Max Reitz wrote: > On 2017-05-15 16:04, Daniel P. Berrange wrote: >> The qemu-img dd/convert commands will create an image file and >> then try to open it. Historically it has been possible to open >> new files without passing any options. With encrypted files >> though, the

Re: [Qemu-devel] [PATCH] sockets: Plug memory leak in socket_address_flatten()

On 05/15/2017 11:39 AM, Markus Armbruster wrote: > socket_address_flatten() leaks a SocketAddress when its argument is > null. Happens when opening a ChardevBackend of type 'udp' that is > configured without a local address. Screwed up in commit bd269ebc due > to last minute semantic conflict

Re: [Qemu-devel] [PATCH v9 4/4] qemu-img: copy *key-secret opts when opening newly created files

On 2017-05-15 16:04, Daniel P. Berrange wrote: > The qemu-img dd/convert commands will create an image file and > then try to open it. Historically it has been possible to open > new files without passing any options. With encrypted files > though, the *key-secret options are mandatory, so we need

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" wrote: > >> > * Juan Quintela (quint...@redhat.com) wrote: > >> >> Markus Armbruster

Re: [Qemu-devel] [PATCH] 9pfs: local: forbid client access to metadata (CVE-2017-7493)

On 05/15/2017 11:07 AM, Greg Kurz wrote: > When using the mapped-file security mode, we shouldn't let the client mess > with the metadata. The current code already tries to hide the metadata dir > from the client by skipping it in local_readdir(). But the client can still > access or modify it

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert" wrote: >> > * Juan Quintela (quint...@redhat.com) wrote: >> >> Markus Armbruster wrote: >> >> > Juan Quintela

Re: [Qemu-devel] [PATCH] qemu-img: Fix documentation of convert

On 2017-05-15 12:35, Fam Zheng wrote: > It got lost in commit a8d16f9ca "qemu-img: Update documentation for -U". > > Reported-by: Max Reitz > Signed-off-by: Fam Zheng > --- > qemu-img-cmds.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> Markus Armbruster wrote: > >> > Juan Quintela writes: > >> > > >> >> Eric Blake

Re: [Qemu-devel] 答复： Re: [RFC] virtio-fc: draft idea of virtual fibre channel HBA

Thread necromancy after doing my homework and studying a bunch of specs... >>> I'd propose to update >>> >>> struct virtio_scsi_config >>> with a field 'u8 initiator_id[8]' >>> >>> and >>> >>> struct virtio_scsi_req_cmd >>> with a field 'u8 target_id[8]' >>> >>> and do away with the weird LUN

Re: [Qemu-devel] [PULL 0/5] Migration pull request

Stefan Hajnoczi wrote: > On Fri, May 12, 2017 at 05:52:44PM +0200, Juan Quintela wrote: >> Hi >> >> > > Thanks, applied to my staging tree: > https://github.com/stefanha/qemu/commits/staging Hi As fast as I sent the PULL request, more comments appeared. What do you

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v18 1/2] virtio-crypto: Add virtio crypto device specification

On 05/10/2017 08:02 PM, Halil Pasic wrote: > > > On 04/22/2017 08:23 AM, Gonglei wrote: >> The virtio crypto device is a virtual crypto device (ie. hardware >> crypto accelerator card). Currently, the virtio crypto device provides >> the following crypto services: CIPHER, MAC, HASH, and AEAD.

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Markus Armbruster wrote: >> > Juan Quintela writes: >> > >> >> Eric Blake wrote: >> >> >> >>> Or is the proposal that we are also

Re: [Qemu-devel] [Qemu-devel PATCH 4/5] msf2: Add Smartfusion2 SoC.

On Thu, May 11, 2017 at 10:02 PM, Philippe Mathieu-Daudé wrote: > On 05/12/2017 12:17 AM, sundeep subbaraya wrote: >> >> Hi Philippe, >> >> On Wed, May 10, 2017 at 5:20 PM, Philippe Mathieu-Daudé >> wrote: >> >>> Hi Subbaraya, >>> >>> >>> On 05/09/2017 01:44

[Qemu-devel] [PATCH v10 4/4] qemu-img: copy *key-secret opts when opening newly created files

The qemu-img dd/convert commands will create an image file and then try to open it. Historically it has been possible to open new files without passing any options. With encrypted files though, the *key-secret options are mandatory, so we need to provide those options when opening the newly

[Qemu-devel] [PATCH v10 2/4] qemu-img: fix --image-opts usage with dd command

The --image-opts flag can only be used to affect the parsing of the source image. The target image has to be specified in the traditional style regardless, since it needs to be passed to the bdrv_create() API which does not support the new style opts. Reviewed-by: Fam Zheng

[Qemu-devel] [PATCH v10 3/4] qemu-img: introduce --target-image-opts for 'convert' command

The '--image-opts' flag indicates whether the source filename includes options. The target filename has to remain in the plain filename format though, since it needs to be passed to bdrv_create(). When using --skip-create though, it would be possible to use image-opts syntax. This adds

[Qemu-devel] [PATCH v10 1/4] qemu-img: add support for --object with 'dd' command

The qemu-img dd command added --image-opts support, but missed the corresponding --object support. This prevented passing secrets (eg auth passwords) needed by certain disk images. Reviewed-by: Fam Zheng Reviewed-by: Max Reitz Reviewed-by: Eric Blake

Re: [Qemu-devel] Changes to Broadcom(BCM) files and Raspberry Pi files. Addition of PanelEmu

On Sat, May 13, 2017 at 5:42 PM, John Bradley via Qemu-devel wrote: > From 7f74f048f135d9c9c230a9e90f72451c841c6d35 Mon Sep 17 00:00:00 2001 > From: John Bradley > Date: Sat, 13 May 2017 23:07:47 +0100 > Subject: [PATCH] Changes to Broadcom(BCM)

[Qemu-devel] [PATCH v10 0/4] Improve convert and dd commands

Update to v1: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05699.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg00728.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg04391.html v4:

[Qemu-devel] [PATCH] sockets: Plug memory leak in socket_address_flatten()

socket_address_flatten() leaks a SocketAddress when its argument is null. Happens when opening a ChardevBackend of type 'udp' that is configured without a local address. Screwed up in commit bd269ebc due to last minute semantic conflict resolution. Spotted by Coverity. Signed-off-by: Markus

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

* Juan Quintela (quint...@redhat.com) wrote: > Markus Armbruster wrote: > > Juan Quintela writes: > > > >> Eric Blake wrote: > > > >>> Or is the proposal that we are also going to simplify the QMP 'migrate' > >>> command to get rid of

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

Markus Armbruster wrote: > Juan Quintela writes: > >> Eric Blake wrote: >>> Or is the proposal that we are also going to simplify the QMP 'migrate' >>> command to get rid of crufty parameters? >> >> I didn't read it that way, but I

Re: [Qemu-devel] [PATCH 6/6] spapr: fix migration of ICP objects from/to older QEMU

On Mon, 15 May 2017 18:11:27 +0200 Cédric Le Goater wrote: > >>> +int smt = kvmppc_smt_threads(); > >>> +int nr_servers = DIV_ROUND_UP(max_cpus * smt, smp_threads); > >> > >> may be we should reintroduce nr_servers at the machine level ? > >> > > > > I had

Re: [Qemu-devel] [PATCH 6/6] spapr: fix migration of ICP objects from/to older QEMU

On Mon, 15 May 2017 18:09:04 +0200 Cédric Le Goater wrote: > On 05/15/2017 03:16 PM, Greg Kurz wrote: > > On Mon, 15 May 2017 14:22:32 +0200 > > Cédric Le Goater wrote: > > > >> On 05/15/2017 01:40 PM, Greg Kurz wrote: > >>> Commit 5bc8d26de20c ("spapr:

  1   2   3   >