Re: [Qemu-devel] [PATCH 3/3] numa: silence incomplete mapping warning under qtest

2017-05-19 Thread Stefan Hajnoczi
On Thu, May 18, 2017 at 7:20 PM, Eduardo Habkost wrote: > On Thu, May 18, 2017 at 10:09:31AM +0200, Igor Mammedov wrote: >> Suggested-by: Markus Armbruster >> Signed-off-by: Igor Mammedov > > Where exactly is the test code that triggers those messages and > requires this patch? I would like to d

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Peter Xu
On Fri, May 19, 2017 at 09:30:10AM +0100, Daniel P. Berrange wrote: > On Fri, May 19, 2017 at 09:25:38AM +0100, Daniel P. Berrange wrote: > > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > > We don't really have a return path for the other types yet. Let's check > > > this when .get_

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-19 Thread Jason Wang
On 2017年05月19日 17:00, Wei Wang wrote: On 05/19/2017 11:10 AM, Jason Wang wrote: On 2017年05月18日 11:03, Wei Wang wrote: On 05/17/2017 02:22 PM, Jason Wang wrote: On 2017年05月17日 14:16, Jason Wang wrote: On 2017年05月16日 15:12, Wei Wang wrote: Hi: Care to post the driver codes too? OK

Re: [Qemu-devel] [RFC PATCH 09/20] Memory: introduce iommu_ops->record_device

2017-05-19 Thread Liu, Yi L
On Fri, May 19, 2017 at 09:07:49AM +, Tian, Kevin wrote: > > From: Liu, Yi L [mailto:yi.l@linux.intel.com] > > Sent: Friday, May 19, 2017 1:24 PM > > > > Hi Alex, > > > > What's your opinion with Tianyu's question? Is it accepatable > > to use VFIO API in intel_iommu emulator? > > Did yo

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Peter Xu
On Fri, May 19, 2017 at 09:25:38AM +0100, Daniel P. Berrange wrote: > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > We don't really have a return path for the other types yet. Let's check > > this when .get_return_path() is called. > > > > For this, we introduce a new feature bit,

Re: [Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

2017-05-19 Thread Maxime Coquelin
On 05/18/2017 05:24 PM, Michael S. Tsirkin wrote: On Thu, May 18, 2017 at 04:45:23PM +0200, Maxime Coquelin wrote: Hi Michael, On 05/18/2017 09:35 AM, Maxime Coquelin wrote: On 05/17/2017 06:41 PM, Michael S. Tsirkin wrote: On Fri, May 12, 2017 at 01:21:18PM +0200, Maxime Coquelin wrote:

[Qemu-devel] [PATCH] i386: fix read/write cr with icount option

2017-05-19 Thread Mihail Abakumov
Running Windows with icount causes a crash in instruction of write cr. This patch fixes it. Reading and writing cr cause an icount read because there are called cpu_get_apic_tpr and cpu_set_apic_tpr functions. So, there is need gen_io_start()/gen_io_end() calls. --- target/i386/translate.c

[Qemu-devel] [PATCH v1 10/13] qcow2-cluster: slightly refactor handle_dependencies()

2017-05-19 Thread Anton Nefedov
- assert the alignment on return if the allocation has to stop (at the start of a running allocation) - make use of const specifiers for local variables Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev --- block/qcow2-cluster.c | 20 +++- 1 file changed, 11 ins

[Qemu-devel] [PATCH v1 08/13] qcow2: handle_prealloc(): find out if area zeroed by earlier preallocation

2017-05-19 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev --- block/qcow2-cluster.c | 2 ++ block/qcow2.c | 8 +++- block/qcow2.h | 4 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index b2879b9..25210cd 100

[Qemu-devel] [PATCH v1 06/13] qcow2: truncate preallocated space

2017-05-19 Thread Anton Nefedov
From: "Denis V. Lunev" This could be done after calculation of the end of data and metadata in the qcow2 image. Signed-off-by: Denis V. Lunev Signed-off-by: Anton Nefedov --- block/qcow2-cluster.c | 9 + block/qcow2-refcount.c | 7 +++ block/qcow2.c | 8 block/q

[Qemu-devel] [PATCH v1 12/13] qcow2: allow concurrent unaligned writes to the same clusters

2017-05-19 Thread Anton Nefedov
If COW area of a write request to unallocated cluster is empty, concurrent write requests can be allowed with a little bit of extra synchronization; so they don't have to wait until L2 is filled. Let qcow2_cluster.c::handle_dependencies() do the most of the job: if there is an in-flight request

[Qemu-devel] [PATCH v1 13/13] iotest 046: test simultaneous cluster write error case

2017-05-19 Thread Anton Nefedov
Signed-off-by: Anton Nefedov --- tests/qemu-iotests/046 | 38 +- tests/qemu-iotests/046.out | 23 +++ 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046 index f2ebecf..c210b55 1

[Qemu-devel] [PATCH v1 02/13] qcow2: is_zero_sectors(): return true if area is outside of backing file

2017-05-19 Thread Anton Nefedov
in such case, bdrv_get_block_status() shall return 0, *nr == 0 iotest 154 updated accordingly: write-zeroes tail alignment can be detected as zeroes now, so pwrite_zeroes succeeds Signed-off-by: Anton Nefedov --- block/qcow2.c | 6 -- tests/qemu-iotests/154.out | 4 ++-- 2 file

[Qemu-devel] [PATCH v1 11/13] qcow2-cluster: make handle_dependencies() logic easier to follow

2017-05-19 Thread Anton Nefedov
Avoid complicated nested conditions; return or continue asap instead. The logic is not changed. Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev --- block/qcow2-cluster.c | 45 ++--- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git

[Qemu-devel] [PATCH v1 05/13] qcow2: set inactive flag

2017-05-19 Thread Anton Nefedov
Qcow2State and BlockDriverState flags have to be in sync Signed-off-by: Anton Nefedov --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 6e7ce96..07c1706 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1939,6 +1939,7 @@ static int qcow2_i

[Qemu-devel] [PATCH v1 07/13] qcow2: check space leak at the end of the image

2017-05-19 Thread Anton Nefedov
From: Pavel Butsykin Preallocating memory in the image may remain unused after the fall, for the qcow2_check adds the ability to identify and fix it, so as not to store extra memory on the host. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev Signed-off-by: Anton Nefedov --- bloc

[Qemu-devel] [PATCH v1 01/13] qcow2: alloc space for COW in one chunk

2017-05-19 Thread Anton Nefedov
From: "Denis V. Lunev" Currently each single write operation can result in 3 write operations if guest offsets are not cluster aligned. One write is performed for the real payload and two for COW-ed areas. Thus the data possibly lays non-contiguously on the host filesystem. This will reduce furth

[Qemu-devel] [PATCH v1 09/13] qcow2: fix misleading comment about L2 linking

2017-05-19 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev --- block/qcow2-cluster.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 25210cd..4204db9 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c

[Qemu-devel] [PATCH v1 04/13] qcow2: preallocation at image expand

2017-05-19 Thread Anton Nefedov
From: "Denis V. Lunev" This patch adds image preallocation at expand to provide better locality of QCOW2 image file and optimize this procedure for some distributed storages where this procedure is slow. Image expand requests have to be suspended until the allocation is performed which is done v

[Qemu-devel] [PATCH v1 03/13] qcow2: do not COW the empty areas

2017-05-19 Thread Anton Nefedov
If COW area of the newly allocated cluster is zeroes, there is no reason to write zero sectors in perform_cow() again now as whole clusters are zeroed out in single chunks by handle_alloc_space(). Introduce QCowL2Meta field "reduced", since the existing fields (offset and nb_bytes) still has to ke

[Qemu-devel] [PATCH v1 00/13] qcow2: space preallocation and COW improvements

2017-05-19 Thread Anton Nefedov
This pull request is to address a few performance problems of qcow2 format: 1. non cluster-aligned write requests (to unallocated clusters) explicitly pad data with zeroes if there is no backing data. This can be avoided and the whole clusters are preallocated and zeroed in a single

Re: [Qemu-devel] [PATCH] Memory: use memory address space for cpu-memory

2017-05-19 Thread Paolo Bonzini
On 19/05/2017 01:28, Xu, Anthony wrote: >> On 18/05/2017 23:48, Xu, Anthony wrote: It should be called. Alternatively you could try adding a new function to mark address_space_memory as a never-destroyed AddressSpace: >>> This patch would do it, could you please submit this patch?

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-19 Thread Jay Zhou
Hi Xiao, On 2017/5/19 16:32, Xiao Guangrong wrote: I do not know why i was removed from the list. I was CCed to you... Your comments are very valuable to us, and thank for your quick response. On 05/19/2017 04:09 PM, Jay Zhou wrote: Hi Paolo and Wanpeng, On 2017/5/17 16:38, Wanpeng Li wr

Re: [Qemu-devel] specify memory in QEMU with Virtio

2017-05-19 Thread Gerd Hoffmann
On Do, 2017-05-18 at 22:43 -0400, jenia mtl wrote: > Hello. > > > How do I specify how much graphics memory the Windows client should have in > QEMU. I have successfully installed Virtio and can launch the VM (Windows) > with it. This doubles the memory form 8MB to 16MB. But I need 512. How can >

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

2017-05-19 Thread Markus Armbruster
Juan Quintela writes: > Create one capability for block migration and one parameter for > incremental block migration. > > Signed-off-by: Juan Quintela [...] > diff --git a/include/migration/block.h b/include/migration/block.h > index 41a1ac8..5225af9 100644 > --- a/include/migration/block.h > +

[Qemu-devel] [PATCH] target/i386: use multiple CPU AddressSpaces

2017-05-19 Thread Paolo Bonzini
This speeds up SMM switches. Later on it may remove the need to take the BQL, and it may also allow to reuse code between TCG and KVM. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c| 15 +- target/i386/cpu.h| 11 +- target/i386/helper.c | 54 +

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] migration: avoid recursive AioContext locking in save_vmstate()

2017-05-19 Thread Stefan Hajnoczi
On Thu, May 18, 2017 at 10:18:46AM +0200, Kevin Wolf wrote: > Am 17.05.2017 um 19:09 hat Stefan Hajnoczi geschrieben: > > diff --git a/migration/savevm.c b/migration/savevm.c > > index 7f66d58..a70ba20 100644 > > --- a/migration/savevm.c > > +++ b/migration/savevm.c > > @@ -2153,6 +2153,14 @@ int s

Re: [Qemu-devel] [RFC PATCH 09/20] Memory: introduce iommu_ops->record_device

2017-05-19 Thread Tian, Kevin
> From: Liu, Yi L [mailto:yi.l@linux.intel.com] > Sent: Friday, May 19, 2017 1:24 PM > > Hi Alex, > > What's your opinion with Tianyu's question? Is it accepatable > to use VFIO API in intel_iommu emulator? Did you actually need such translation at all? SID should be filled by kernel IOMMU d

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-19 Thread Wei Wang
On 05/19/2017 11:10 AM, Jason Wang wrote: On 2017年05月18日 11:03, Wei Wang wrote: On 05/17/2017 02:22 PM, Jason Wang wrote: On 2017年05月17日 14:16, Jason Wang wrote: On 2017年05月16日 15:12, Wei Wang wrote: Hi: Care to post the driver codes too? OK. It may take some time to clean up the d

[Qemu-devel] [PULL 1/1] ui: egl-headless requires dmabuf support

2017-05-19 Thread Gerd Hoffmann
Reported-by: Thomas Huth Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170517122744.3541-1-kra...@redhat.com --- vl.c | 4 ++-- ui/Makefile.objs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 1512df6e9e..ca4a

[Qemu-devel] [PULL 0/1] ui: egl-headless requires dmabuf support

2017-05-19 Thread Gerd Hoffmann
in the git repository at: git://git.kraxel.org/qemu tags/pull-ui-20170519-1 for you to fetch changes up to 371ec54e9f8415cd74af45acdcf67b413f50cce5: ui: egl-headless requires dmabuf support (2017-05-19 10:46:00 +0200) ui: eg

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

2017-05-19 Thread Maxime Coquelin
On 05/19/2017 08:48 AM, Jason Wang wrote: On 2017年05月17日 22:10, Maxime Coquelin wrote: On 05/17/2017 04:53 AM, Jason Wang wrote: On 2017年05月16日 23:16, Michael S. Tsirkin wrote: On Mon, May 15, 2017 at 01:45:28PM +0800, Jason Wang wrote: On 2017年05月13日 08:02, Michael S. Tsirkin wrote:

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-19 Thread Xiao Guangrong
I do not know why i was removed from the list. On 05/19/2017 04:09 PM, Jay Zhou wrote: Hi Paolo and Wanpeng, On 2017/5/17 16:38, Wanpeng Li wrote: 2017-05-17 15:43 GMT+08:00 Paolo Bonzini : Recently, I have tested the performance before migration and after migration failure using spec cpu2

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Daniel P. Berrange
On Fri, May 19, 2017 at 09:25:38AM +0100, Daniel P. Berrange wrote: > On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > > We don't really have a return path for the other types yet. Let's check > > this when .get_return_path() is called. > > > > For this, we introduce a new feature bit,

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-19 Thread Daniel P. Berrange
On Fri, May 19, 2017 at 02:43:27PM +0800, Peter Xu wrote: > We don't really have a return path for the other types yet. Let's check > this when .get_return_path() is called. > > For this, we introduce a new feature bit, and set it up only for socket > typed IO channels. > > This will help detect

Re: [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del

2017-05-19 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > The commands 'device_add' and 'device_del' should be used > nowadays instead. > > Signed-off-by: Thomas Huth Reviewed-by: Dr. David Alan Gilbert > --- > hmp-commands.hx | 6 -- > vl.c| 6 ++ > 2 files changed, 10 insertions(+), 2 d

Re: [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del

2017-05-19 Thread Paolo Bonzini
On 19/05/2017 08:36, Thomas Huth wrote: > The commands 'device_add' and 'device_del' should be used > nowadays instead. > > Signed-off-by: Thomas Huth > --- > hmp-commands.hx | 6 -- > vl.c| 6 ++ > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/hmp-com

Re: [Qemu-devel] [PATCH] usb: Simplify the parameter parsing of the legacy usb serial device

2017-05-19 Thread Paolo Bonzini
On 19/05/2017 09:00, Thomas Huth wrote: > Coverity complains about the current code, so let's get rid of > the now unneeded while loop and simply always emit "unrecognized > serial USB option" for all unsupported options. > > Signed-off-by: Thomas Huth > --- > hw/usb/dev-serial.c | 21 +---

Re: [Qemu-devel] [PATCH] usb: Deprecate the legacy -usbdevice option

2017-05-19 Thread Paolo Bonzini
On 19/05/2017 08:35, Thomas Huth wrote: > The '-usbdevice' option is considered as deprecated nowadays and > we might want to remove these options in a future version of QEMU. > So mark this options as deprecated in the documenation and print out > a warning if it is used to tell the user what to

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-19 Thread Jay Zhou
Hi Paolo and Wanpeng, On 2017/5/17 16:38, Wanpeng Li wrote: 2017-05-17 15:43 GMT+08:00 Paolo Bonzini : Recently, I have tested the performance before migration and after migration failure using spec cpu2006 https://www.spec.org/cpu2006/, which is a standard performance evaluation tool. These

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

2017-05-19 Thread Jason Wang
On 2017年05月18日 16:43, Maxime Coquelin wrote: +When the VHOST_USER_PROTOCOL_F_SLAVE_REQ is supported by the slave, and the +master initiated the slave to master communication channel using the +VHOST_USER_SET_SLAVE_REQ_FD request, the slave can send IOTLB miss and access +failure events by s

Re: [Qemu-devel] [RFC PATCH v2 1/4] migration: Introduce unregister_savevm_live()

2017-05-19 Thread David Gibson
On Fri, May 19, 2017 at 11:10:36AM +0530, Bharata B Rao wrote: > Introduce a new function unregister_savevm_live() to unregister the vmstate > handlers registered via register_savevm_live(). > > register_savevm() allocates SaveVMHandlers while register_savevm_live() > gets passed with SaveVMHandle

[Qemu-devel] [PATCH v0 6/6] change tcg relative file's compile definition

2017-05-19 Thread Yang Zhong
move tcg relative compile definitions form Makefile.target to tcg/Makefile.objs Signed-off-by: Yang Zhong --- Makefile.target | 7 +-- tcg/Makefile.objs | 2 ++ 2 files changed, 3 insertions(+), 6 deletions(-) create mode 100644 tcg/Makefile.objs diff --git a/Makefile.target b/Makefile.t

[Qemu-devel] [PATCH v0 5/6] move tcg relative files into tcg directory

2017-05-19 Thread Yang Zhong
move tci.c to ./tcg Signed-off-by: Yang Zhong --- Makefile.target| 2 +- tci.c => tcg/tci.c | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename tci.c => tcg/tci.c (100%) diff --git a/Makefile.target b/Makefile.target index 7ee6cb3..489a325 100644 --- a/Makefile.target +++ b/Makefile

[Qemu-devel] [PATCH v0 2/6] move tcg relative files into tcg directory

2017-05-19 Thread Yang Zhong
move translate-all.c file into tcg directory and update trace-events file Signed-off-by: Yang Zhong --- Makefile.objs | 1 + Makefile.target| 3 ++- tcg/trace-events | 6 ++ translate-all.c => tcg/translate-all.c | 2 +-

[Qemu-devel] [PATCH v0 3/6] move tcg header file

2017-05-19 Thread Yang Zhong
move translate-all.h to ./tcg Signed-off-by: Yang Zhong --- translate-all.h => tcg/translate-all.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename translate-all.h => tcg/translate-all.h (100%) diff --git a/translate-all.h b/tcg/translate-all.h similarity index 100% rename from tran

[Qemu-devel] [PATCH v0 1/6] move tcg relative files into tcg directory

2017-05-19 Thread Yang Zhong
move tcg-runtime.c to ./tcg directory Signed-off-by: Yang Zhong --- Makefile.target| 2 +- tcg-runtime.c => tcg/tcg-runtime.c | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename tcg-runtime.c => tcg/tcg-runtime.c (100%) diff --git a/Makefile.target b/Makefile.target

[Qemu-devel] [PATCH v0 4/6] move tcg relative files into tcg directory

2017-05-19 Thread Yang Zhong
move translate-common.c to ./tcg Signed-off-by: Yang Zhong --- Makefile.target | 2 +- translate-common.c => tcg/translate-common.c | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename translate-common.c => tcg/translate-common.c (100%) diff --git a/Makefile.

[Qemu-devel] [PATCH v0 0/6] move the tcg files into tcg directory.

2017-05-19 Thread Yang Zhong
Move the tcg relative files into tcg directory, which will make the code more clean in qemu. Yang Zhong (6): move tcg relative files into tcg directory move tcg relative files into tcg directory move tcg header file move tcg relative files into tcg directory move tcg relative files into

[Qemu-devel] [Bug 1180924] Re: fails to handle a usb serial port with a specific vendorid

2017-05-19 Thread Thomas Huth
The crash has now been fixed here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=aa612b364ecbe1dc Please also note that the "-usbdevice serial" syntax is considered as deprecated nowadays - use "-device usb-serial" instead. ** Changed in: qemu Status: New => Fix Committed -- You receive

Re: [Qemu-devel] [PATCH v4 3/3] net/rocker: Convert to realize()

2017-05-19 Thread Markus Armbruster
Mao Zhongyi writes: > The rocker device still implements the old PCIDeviceClass .init() > instead of the new .realize(). All devices need to be converted to > .realize(). > > .init() reports errors with fprintf() and return 0 on success, negative > number on failure. Meanwhile, when -device rocke

[Qemu-devel] [PATCH] usb: Simplify the parameter parsing of the legacy usb serial device

2017-05-19 Thread Thomas Huth
Coverity complains about the current code, so let's get rid of the now unneeded while loop and simply always emit "unrecognized serial USB option" for all unsupported options. Signed-off-by: Thomas Huth --- hw/usb/dev-serial.c | 21 + 1 file changed, 5 insertions(+), 16 delet

<    1   2   3