Re: [Qemu-devel] [Qemu devel v5 PATCH 0/5] Add support for Smartfusion2 SoC

2017-05-28 Thread sundeep subbaraya
Hi Philippe, Any update on this? I will wait for your comments too and send next iteration fixing Alistair comments. Thanks, Sundeep On Wed, May 17, 2017 at 3:09 PM, sundeep subbaraya wrote: > Hi Philippe, > > On Wed, May 17, 2017 at 9:57 AM, Philippe Mathieu-Daudé

Re: [Qemu-devel] [Qemu devel v5 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit.

2017-05-28 Thread sundeep subbaraya
Hi Alistair, On Sat, May 27, 2017 at 5:30 AM, Alistair Francis wrote: > On Tue, May 16, 2017 at 8:38 AM, Subbaraya Sundeep > wrote: > > Emulated Emcraft's Smartfusion2 System On Module starter > > kit. > > > > Signed-off-by: Subbaraya Sundeep

Re: [Qemu-devel] [Qemu devel v5 PATCH 4/5] msf2: Add Smartfusion2 SoC.

2017-05-28 Thread sundeep subbaraya
Hi Alistair, On Sat, May 27, 2017 at 5:18 AM, Alistair Francis wrote: > On Tue, May 16, 2017 at 8:38 AM, Subbaraya Sundeep > wrote: > > Smartfusion2 SoC has hardened Microcontroller subsystem > > and flash based FPGA fabric. This patch adds support

Re: [Qemu-devel] [PATCH v4 10/10] vhost: iommu: cache static mapping if there is

2017-05-28 Thread Peter Xu
On Thu, May 25, 2017 at 09:14:55PM +0300, Michael S. Tsirkin wrote: > On Mon, May 22, 2017 at 10:42:00AM +0800, Peter Xu wrote: > > On Fri, May 19, 2017 at 07:55:26PM +0300, Michael S. Tsirkin wrote: > > > On Fri, May 19, 2017 at 11:19:49AM +0800, Peter Xu wrote: > > > > This patch pre-heat vhost

[Qemu-devel] [PATCH v2] exec: fix address_space_get_iotlb_entry page mask

2017-05-28 Thread Peter Xu
The IOTLB that it returned didn't guarantee that page_mask is indeed a so-called page mask. That won't affect current usage since now only vhost is using it (vhost API allows arbitary IOTLB range). However we have IOTLB scemantic and we should best follow it. This patch fixes this issue to make

Re: [Qemu-devel] [PATCH] exec: fix address_space_get_iotlb_entry page mask

2017-05-28 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] exec: fix address_space_get_iotlb_entry page mask Message-id: 1496029936-6381-1-git-send-email-pet...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH] exec: fix address_space_get_iotlb_entry page mask

2017-05-28 Thread Peter Xu
The IOTLB that it returned didn't guarantee that page_mask is indeed a so-called page mask. That won't affect current usage since now only vhost is using it (vhost API allows arbitary IOTLB range). However we have IOTLB scemantic and we should best follow it. This patch fixes this issue to make

[Qemu-devel] [PULL 13/13] acpi-test: update expected files

2017-05-28 Thread Michael S. Tsirkin
commit 1a8d61ddbf ("pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry") changed generated SRAT tables, update expected files accordingly. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/SRAT.memhp | Bin 264 -> 264 bytes

[Qemu-devel] [PULL 10/13] virtio_net: Bypass backends for MTU feature negotiation

2017-05-28 Thread Michael S. Tsirkin
From: Maxime Coquelin This patch adds a new internal "x-mtu-bypass-backend" property to bypass backends for MTU feature negotiation. When this property is set, the MTU feature is negotiated as soon as supported by the guest and a MTU value is set via the host_mtu

[Qemu-devel] [PULL 11/13] vhost-user: pass message as a pointer to process_message_reply()

2017-05-28 Thread Michael S. Tsirkin
From: Maxime Coquelin process_message_reply() was recently updated to get full message content instead of only its request field. There is no need to copy all the struct content into the stack, so just pass its pointer as const. Reviewed-by: Jens Freimann

[Qemu-devel] [PULL 09/13] intel_iommu: turn off pt before 2.9

2017-05-28 Thread Michael S. Tsirkin
From: Peter Xu This is for compatibility. Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Jason Wang --- include/hw/compat.h | 4 1 file

[Qemu-devel] [PULL 07/13] intel_iommu: allow dev-iotlb context entry conditionally

2017-05-28 Thread Michael S. Tsirkin
From: Peter Xu When device-iotlb is not specified, we should fail this check. A new function vtd_ce_type_check() is introduced. While I'm at it, clean up the vtd_dev_to_context_entry() a bit - replace many "else if" usage into direct if check. That'll make the logic more

[Qemu-devel] [PULL 06/13] intel_iommu: use IOMMU_ACCESS_FLAG()

2017-05-28 Thread Michael S. Tsirkin
From: Peter Xu We have that now, so why not use it. Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Jason Wang --- hw/i386/intel_iommu.c | 2

[Qemu-devel] [PULL 08/13] intel_iommu: support passthrough (PT)

2017-05-28 Thread Michael S. Tsirkin
From: Peter Xu Hardware support for VT-d device passthrough. Although current Linux can live with iommu=pt even without this, but this is faster than when using software passthrough. Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 04/13] intel_iommu: renaming context entry helpers

2017-05-28 Thread Michael S. Tsirkin
From: Peter Xu The old names are too long and less ordered. Let's start to use vtd_ce_*() as a pattern. Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Jason Wang

[Qemu-devel] [PULL 12/13] pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry

2017-05-28 Thread Michael S. Tsirkin
From: Ladi Prosek For reasons unknown, Windows won't online all memory, both at command line and hot-plugged later, unless the hotplug mem hole SRAT entry specifies a node greater than or equal to the ones where memory is added. Using the highest node on the machine makes

[Qemu-devel] [PULL 03/13] x86-iommu: use DeviceClass properties

2017-05-28 Thread Michael S. Tsirkin
From: Peter Xu No reason to keep tens of lines if we can do it actually far shorter. Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Jason Wang

[Qemu-devel] [PULL 05/13] intel_iommu: provide vtd_ce_get_type()

2017-05-28 Thread Michael S. Tsirkin
From: Peter Xu Helper to fetch VT-d context entry type. Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Jason Wang --- hw/i386/intel_iommu.c |

[Qemu-devel] [PULL 00/13] pci, virtio, vhost: fixes

2017-05-28 Thread Michael S. Tsirkin
The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging (2017-05-23 15:01:31 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

[Qemu-devel] [PULL 02/13] memory: remove the last param in memory_region_iommu_replay()

2017-05-28 Thread Michael S. Tsirkin
From: Peter Xu We were always passing in that one as "false" to assume that's an read operation, and we also assume that IOMMU translation would always have that read permission. A better permission would be IOMMU_NONE since the replay is after all not a real read operation,

[Qemu-devel] [PULL 01/13] memory: tune last param of iommu_ops.translate()

2017-05-28 Thread Michael S. Tsirkin
From: Peter Xu This patch converts the old "is_write" bool into IOMMUAccessFlags. The difference is that "is_write" can only express either read/write, but sometimes what we really want is "none" here (neither read nor write). Replay is an good example - during replay, we

[Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature, again

2017-05-28 Thread Dan Aloni
The number of queues that should be return by the admin command should: 1) Only mention the number of non-admin queues. 2) It is zero-based, meaning that '0 == one non-admin queue', '1 == two non-admin queues', and so forth. Because our `num_queues` means the number of queues _plus_ the

Re: [Qemu-devel] [PATCH 08/13] be-hci: use backend functions

2017-05-28 Thread andrzej zaborowski
On 26 May 2017 at 14:20, Marc-André Lureau wrote: > On Tue, May 9, 2017 at 3:42 PM Marc-André Lureau < > marcandre.lur...@redhat.com> wrote: >> Avoid accessing CharBackend directly, use qemu_chr_be_* methods instead. >> >> be->chr_read should exists if

[Qemu-devel] [PATCH v3] gluster: add support for PREALLOC_MODE_FALLOC

2017-05-28 Thread Niels de Vos
Add missing support for "preallocation=falloc" to the Gluster block driver. This change bases its logic on that of block/file-posix.c and removed the gluster_supports_zerofill() and qemu_gluster_zerofill() functions in favour of #ifdef checks in an easy to read switch-statement. Both