Re: [Qemu-devel] [PATCH v2 0/6] vhost-user: Specify and implement device IOTLB support

2017-06-01 Thread Jason Wang
On 2017年06月01日 21:59, Michael S. Tsirkin wrote: On Wed, May 31, 2017 at 04:33:33PM +0800, Jason Wang wrote: On 2017年05月31日 02:20, Michael S. Tsirkin wrote: On Fri, May 26, 2017 at 04:28:52PM +0200, Maxime Coquelin wrote: This series aims at specifying ans implementing the protocol update

[Qemu-devel] [PULL] qemu-sparc updates

2017-06-01 Thread Mark Cave-Ayland
Hi Peter, This request contains the SPARC QOMify work which fell through the cracks during the last release. Please pull. ATB, Mark. The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31' into

Re: [Qemu-devel] [PATCH v3 0/8] QOM'ify work for sparc

2017-06-01 Thread Mark Cave-Ayland
On 25/05/17 14:34, xiaoqiang zhao wrote: > This patch set aims for QOM'ifying code relate with sparc. > It is part of my QOM'ify work of qemu code base. > > Changes: > > v2 -> v3: > * rebased on the latest master > * squash two patches about m48txx_sysbus into one > > v1 -> v2: > * rebased

Re: [Qemu-devel] [Qemu-arm] [PATCH 09/13] armv7m: Implement M profile default memory map

2017-06-01 Thread Philippe Mathieu-Daudé
Hi Peter, On 05/30/2017 12:11 PM, Peter Maydell wrote: On 30 May 2017 at 15:56, Philippe Mathieu-Daudé wrote: Hi Peter, On 04/25/2017 09:07 AM, Peter Maydell wrote: From: Michael Davidsaver Add support for the M profile default memory map which is

Re: [Qemu-devel] [PATCH v2 2/4] gdbstub: rename cpu_index -> cpu_gdb_index

2017-06-01 Thread Philippe Mathieu-Daudé
On 06/01/2017 11:49 AM, Alex Bennée wrote: This is to make it clear the index is purely a gdbstub function and should not be confused with the value of cpu->cpu_index. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- gdbstub.c

Re: [Qemu-devel] [PATCH 00/11] Misc migration cleanups

2017-06-01 Thread Philippe Mathieu-Daudé
for patches 1 to 10: Reviewed-by: Philippe Mathieu-Daudé On 06/01/2017 06:29 PM, Juan Quintela wrote: Hi This are a bit of everything: - Remove unneeded argumets for migration_channel_incomming - Lots of changes to make migration.h local to only migration * Move

Re: [Qemu-devel] [PATCH v2 13/14] char: make chr_fe_deinit() optionaly delete backend

2017-06-01 Thread Philippe Mathieu-Daudé
Hi Marc-André, The new boolean argument bothered me at first but I couldn't find nicer way (that's why I kept this patch review so long). On 05/29/2017 05:45 AM, Marc-André Lureau wrote: This simplifies removing a backend for a frontend user (no need to retrive the associated driver and

Re: [Qemu-devel] [PATCH v3 3/5] sockets: ensure we don't accept IPv4 clients when IPv4 is disabled

2017-06-01 Thread Philippe Mathieu-Daudé
On 06/01/2017 05:29 AM, Daniel P. Berrange wrote: Currently if you disable listening on IPv4 addresses, via the CLI flag ipv4=off, we still mistakenly accept IPv4 clients via the IPv6 listener socket due to IPV6_V6ONLY flag being unset. We must ensure IPV6_V6ONLY is always set if ipv4=off This

Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init()

2017-06-01 Thread Peter Xu
On Thu, Jun 01, 2017 at 03:06:29PM -0700, Paul Burton wrote: > Hi Aurelien/Paolo/Marcel, > > On Thursday, 1 June 2017 12:22:06 PDT Aurelien Jarno wrote: > > On 2017-06-01 16:23, Paolo Bonzini wrote: > > > On 01/06/2017 10:27, Marcel Apfelbaum wrote: > > > > On 31/05/2017 11:28, Paolo Bonzini

[Qemu-devel] [PATCH] gitignore: Ignore vim per-project config and clang complete

2017-06-01 Thread Qu Wenruo
Since we have already ignored ctags, ignoring .clangcomplete for vim-clang_completion is quite reasonable for me. (Not to mention vim-clang_completion provides better and more accurate completion and definition search) Also, qemu coding style is using 4 space as indent other than 8-space tab, it

Re: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling

2017-06-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170602031507.29881-1-da...@gibson.dropbear.id.au Subject: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCHv5 3/4] pseries: Reset CPU compatibility mode

2017-06-01 Thread David Gibson
Currently, the CPU compatibility mode is set when the cpu is initialized, then again when the guest negotiates features. This means if a guest negotiates a compatibility mode, then reboots, that compatibility mode will be retained across the reset. Usually that will get overridden when features

[Qemu-devel] [PATCHv5 4/4] ppc: Rework CPU compatibility testing across migration

2017-06-01 Thread David Gibson
Migrating between different CPU versions is a bit complicated for ppc. A long time ago, we ensured identical CPU versions at either end by checking the PVR had the same value. However, this breaks under KVM HV, because we always have to use the host's PVR - it's not virtualized. That would mean

[Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling

2017-06-01 Thread David Gibson
This is a rebased and revised version of my patches revising CPU compatiblity mode handling on ppc, last posted in November. Since then, many of the patches have already been merged (some for 2.9, some since). This is what's left. * There was conceptual confusion about what a compatibility

[Qemu-devel] [PATCHv5 1/4] qapi: add explicit null to string input and output visitors

2017-06-01 Thread David Gibson
From: Greg Kurz This may be used for deprecated object properties that are kept for backwards compatibility. Signed-off-by: Greg Kurz Reviewed-by: Markus Armbruster Signed-off-by: David Gibson ---

[Qemu-devel] [PATCHv5 2/4] pseries: Move CPU compatibility property to machine

2017-06-01 Thread David Gibson
Server class POWER CPUs have a "compat" property, which is used to set the backwards compatibility mode for the processor. However, this only makes sense for machine types which don't give the guest access to hypervisor privilege - otherwise the compatibility level is under the guest's control.

Re: [Qemu-devel] [PATCHv4 0/5] Clean up compatibility mode handling

2017-06-01 Thread David Gibson
On Thu, Jun 01, 2017 at 01:59:14PM +0200, Cédric Le Goater wrote: > On 06/01/2017 08:52 AM, David Gibson wrote: > > On Wed, May 31, 2017 at 10:58:57AM +0200, Greg Kurz wrote: > >> On Wed, 31 May 2017 12:57:48 +1000 > >> David Gibson wrote: > >>> [...] > All old

Re: [Qemu-devel] [PATCHv4 5/5] ppc: Rework CPU compatibility testing across migration

2017-06-01 Thread David Gibson
On Thu, Jun 01, 2017 at 10:23:18AM +0200, Greg Kurz wrote: > On Fri, 26 May 2017 15:23:19 +1000 > David Gibson wrote: > > > Migrating between different CPU versions is a bit complicated for ppc. > > A long time ago, we ensured identical CPU versions at either end by

Re: [Qemu-devel] [PATCHv4 0/5] Clean up compatibility mode handling

2017-06-01 Thread David Gibson
On Thu, Jun 01, 2017 at 03:09:15PM +0200, Greg Kurz wrote: > On Thu, 1 Jun 2017 13:59:14 +0200 > Cédric Le Goater wrote: > > > On 06/01/2017 08:52 AM, David Gibson wrote: > > > On Wed, May 31, 2017 at 10:58:57AM +0200, Greg Kurz wrote: > > >> On Wed, 31 May 2017 12:57:48 +1000 >

[Qemu-devel] NVME: is there any plan to support SGL data transfer?

2017-06-01 Thread Qu Wenruo
Hi, When going through NVMe specification and hw/block/nvme.c, I found that it seems that NVMe qemu implementation only support PRP for sq entry. And NvmeRwCmd doesn't even use union to define DPTR, but just prp1 and prp2. Although I am just a newbie, but I'm quite interested in NVMe and want

[Qemu-devel] Target AVR

2017-06-01 Thread Anichang via Qemu-devel
Hi all, I just resurrected the target-avr patchset from Michael Rolnik. Following the details: commit f2bca179dbfc3f378b131ed619d07db946bae598 Merge: 43771d5 ed250c0 Author: Ani Chang Date: Fri Jun 2 01:17:34 2017 +0200 target/avr: resurrected (see mailing list

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-01 Thread John Snow
On 06/01/2017 03:30 AM, Sementsov-Ogievskiy Vladimir wrote: > Hi John! > > Look at our discussion about this in v18 thread. > > Shortly: readonly is not the same as disabled. disabled= bitmap just > ignores all writes. readonly= writes are not allowed at all. > > And I think, I'll try to go

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-01 Thread John Snow
On 05/31/2017 11:53 AM, Max Reitz wrote: > On 2017-05-31 17:05, Vladimir Sementsov-Ogievskiy wrote: >> 31.05.2017 17:44, Max Reitz wrote: >>> On 2017-05-31 16:29, Vladimir Sementsov-Ogievskiy wrote: 31.05.2017 16:43, Max Reitz wrote: > On 2017-05-30 08:50, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH 14/19] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT

2017-06-01 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Separate case when client sent NBD_OPT_ABORT from other errors. > It will be needed for the following patch, where errors will be > reported. > Considered case is not actually the error - it honestly follows NBD > protocol. Therefore it

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-01 Thread John Snow
On 05/31/2017 09:43 AM, Max Reitz wrote: > On 2017-05-30 08:50, Vladimir Sementsov-Ogievskiy wrote: >> Thank you for this scenario. Hmm. >> >> So, as I need guarantee that image and bitmap are unchanged, >> bdrv_set_dirty should return error and fail the whole write. Ok? > > I don't know. That

Re: [Qemu-devel] [PATCH 13/19] nbd/server: return original error codes

2017-06-01 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > The code in many cases return -EINVAL or -EIO instead of original error > code from, for example, write_sync(). Following patch will need EPIPE > handling, so, let's refactor this where possible (the only exclusion > is

[Qemu-devel] [PATCH 5/5] migration: Make compression_threads use save/load_setup/cleanup()

2017-06-01 Thread Juan Quintela
Once there, be consistent and use compress_thread_{save,load}_{setup,cleanup}. Signed-off-by: Juan Quintela --- migration/migration.c | 5 - migration/ram.c | 12 migration/ram.h | 5 - 3 files changed, 8 insertions(+), 14 deletions(-)

[Qemu-devel] [PATCH 3/5] migration: Create load_setup()/cleanup() methods

2017-06-01 Thread Juan Quintela
We need to do things at load time. Signed-off-by: Juan Quintela --- include/migration/register.h | 2 ++ migration/savevm.c | 31 +++ 2 files changed, 33 insertions(+) diff --git a/include/migration/register.h

[Qemu-devel] [PATCH 4/5] migration: Convert ram to use new load_setup()/load_cleanup()

2017-06-01 Thread Juan Quintela
Once there, I rename ram_migration_cleanup() to ram_save_cleanup(). Notice that this is the first pass, and I only passed XBZRLE to the new scheme. Moved decoded_buf to inside XBZRLE struct. As a bonus, I don't have to export xbzrle functions from ram.c. Signed-off-by: Juan Quintela

[Qemu-devel] [PATCH 2/5] migration: Rename cleanup() to save_cleanup()

2017-06-01 Thread Juan Quintela
We need a cleanup for loads. Signed-off-by: Juan Quintela --- hw/ppc/spapr.c | 2 +- include/migration/register.h | 2 +- migration/block.c| 2 +- migration/ram.c | 2 +- migration/savevm.c | 4 ++-- 5 files changed, 6

[Qemu-devel] [PATCH 1/5] migration: Rename save_live_setup() to save_setup()

2017-06-01 Thread Juan Quintela
We are going to use it now for more than save live regions. Signed-off-by: Juan Quintela --- hw/ppc/spapr.c | 2 +- include/migration/register.h | 2 +- migration/block.c| 2 +- migration/ram.c | 2 +- migration/savevm.c | 6

[Qemu-devel] [PATCH 0/5] Create setup/cleanup methods for migration incoming side

2017-06-01 Thread Juan Quintela
Hi This series make: - use of cleanup/save methods generic, not only for save_live methods - create the equivalent methods for the load side (load_setup/cleanup) - Make ram use this methods to see how/when they are used. Stefan, Kevin, this were the methods that you asked for the block.c

Re: [Qemu-devel] [PATCH 12/19] nbd/common: nbd_wr_syncv handle QIO_CHANNEL_ERR_EPIPE

2017-06-01 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Return EPIPE in case of QIO_CHANNEL_ERR_EPIPE, we will need it to > improve error path in nbd server. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/common.c | 2 +- > 1 file changed, 1

[Qemu-devel] [PATCH 2/5] ram: Move ZERO_TARGET_PAGE inside XBZRLE

2017-06-01 Thread Juan Quintela
It was only used by XBZRLE anyways. Signed-off-by: Juan Quintela --- migration/ram.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index e503277..04b55a7 100644 --- a/migration/ram.c +++ b/migration/ram.c

[Qemu-devel] [PATCH 5/5] ram: Make RAMState dynamic

2017-06-01 Thread Juan Quintela
We create the variable while we are at migration and we remove it after migration. Signed-off-by: Juan Quintela --- migration/ram.c | 52 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PATCH 1/5] ram: Call migration_page_queue_free() at ram_migration_cleanup()

2017-06-01 Thread Juan Quintela
We shouldn't be using memory later than that. Signed-off-by: Juan Quintela --- migration/migration.c | 2 -- migration/ram.c | 5 +++-- migration/ram.h | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/migration/migration.c

[Qemu-devel] [PATCH 4/5] ram: Use MigrationStats for statistics

2017-06-01 Thread Juan Quintela
RAM Statistics need to survive migration to make info migrate work, so we need to store them outside of RAMState. As we already have an struct with those fields, just used them. (MigrationStats and XBZRLECacheStats). Signed-off-by: Juan Quintela --- migration/migration.c |

[Qemu-devel] [PATCH 0/5] Make RAMState dynamic

2017-06-01 Thread Juan Quintela
Hi This series make RAMState a dynamic variable. We create it at the beggining of migration and remove it when migration ends. - Move ZERO_TARGET_PAGE to XBZRLE - print the number of remaining pages not only the number of bytes this makes easier to use statistics. - How to export statistics

[Qemu-devel] [PATCH 3/5] migration: Print statistics about the number of remaining target pages

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 4 +++- migration/ram.c | 4 ++-- migration/ram.h | 2 +- qapi-schema.json | 6 +- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/migration/migration.c b/migration/migration.c

Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init()

2017-06-01 Thread Paul Burton
Hi Aurelien/Paolo/Marcel, On Thursday, 1 June 2017 12:22:06 PDT Aurelien Jarno wrote: > On 2017-06-01 16:23, Paolo Bonzini wrote: > > On 01/06/2017 10:27, Marcel Apfelbaum wrote: > > > On 31/05/2017 11:28, Paolo Bonzini wrote: > > >> No, for now I'd rather just go and remove msi_nonbroken. When

[Qemu-devel] [PATCH 4/4] ram: Now POSTCOPY_ACTIVE is the same that STATUS_ACTIVE

2017-06-01 Thread Juan Quintela
Merge them. Signed-off-by: Juan Quintela --- migration/migration.c | 12 1 file changed, 12 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 8289544..af4c2cc 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -538,19

[Qemu-devel] [PATCH 2/4] ram: We only print throttling information sometimes

2017-06-01 Thread Juan Quintela
Change it to be consistent with everything else. Signed-off-by: Juan Quintela --- migration/migration.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index fd8b406..7f79da0 100644 ---

[Qemu-devel] [PATCH 3/4] ram: Print block stats also in the complete case

2017-06-01 Thread Juan Quintela
To make things easier, I just moved it to populate_ram_info(). Signed-off-by: Juan Quintela --- migration/migration.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index

[Qemu-devel] [PATCH 1/4] ram: Unfold get_xbzrle_cache_stats() into populate_ram_info()

2017-06-01 Thread Juan Quintela
They were called consequtiveley always. Signed-off-by: Juan Quintela --- migration/migration.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 60da9d6..fd8b406 100644 ---

[Qemu-devel] [PATCH 0/4] Make info migrate output consistent

2017-06-01 Thread Juan Quintela
Hi This series make the output of info migrate be printed in a single place for the states ACTIVE, CANCELLING and POSTCOPY_ACTIVE. The code was duplicated, just use the same code. Once done that, fix the inconsistences that were not needed. Please, review. Thanks, Juan. Juan Quintela (4):

[Qemu-devel] [PATCH 09/11] migration: Move remaining exported functions to migration/misc.h

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/i386/pc_piix.c | 2 +- hw/ppc/spapr.c| 2 +- hw/xen/xen-common.c | 2 +- include/migration/migration.h | 13 - include/migration/misc.h | 12 migration/migration.c

[Qemu-devel] [PATCH 10/11] migration: Move migration.h to migration/

2017-06-01 Thread Juan Quintela
Nothing uses it outside of migration.h Signed-off-by: Juan Quintela --- migration/block.c| 2 +- migration/channel.c | 2 +- migration/colo-comm.c| 2 +- migration/colo.c

[Qemu-devel] [PATCH 07/11] migration: ram_control_* are implemented in qemu_file

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 18 -- migration/qemu-file.h | 17 + 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index

[Qemu-devel] [PATCH 03/11] migration: Split registration functions from vmstate.h

2017-06-01 Thread Juan Quintela
They are indpendent, and nowadays almost every device register things with qdev->vmsd. Signed-off-by: Juan Quintela --- hw/net/vmxnet3.c | 1 + hw/ppc/spapr.c | 1 + hw/s390x/s390-skeys.c| 1 + hw/s390x/s390-virtio-ccw.c | 1 +

[Qemu-devel] [PATCH 11/11] migration: Remove unneeded includes

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/colo.h | 3 --- include/migration/misc.h | 2 ++ migration/block.c | 6 -- migration/colo-failover.c | 2 ++ migration/colo.c | 2 -- migration/exec.c | 2 -- migration/fd.c| 2 --

[Qemu-devel] [PATCH 05/11] migration: Move constants to savevm.h

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 15 --- migration/savevm.h| 15 +++ migration/vmstate.c | 1 + tests/test-vmstate.c | 1 + 4 files changed, 17 insertions(+), 15 deletions(-) diff --git

[Qemu-devel] [PATCH 06/11] migration: Commands are only used inside migration.c

2017-06-01 Thread Juan Quintela
So, move them there. Notice that we export functions that send commands, not the command themselves. Signed-off-by: Juan Quintela --- include/migration/migration.h | 15 -- migration/migration.c | 46 +++ 2 files

[Qemu-devel] [PATCH 02/11] migration: Move self_announce_delay() to misc.h

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/net/virtio-net.c | 1 + include/migration/misc.h| 10 ++ include/migration/vmstate.h | 10 -- migration/savevm.c | 1 + 4 files changed, 12 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 08/11] migration: create global_state.c

2017-06-01 Thread Juan Quintela
It don't belong anywhere else, just the global state where everybody can stick other things. Signed-off-by: Juan Quintela --- hw/i386/pc_piix.c| 1 + hw/ppc/spapr.c | 1 + hw/xen/xen-common.c | 1 +

[Qemu-devel] [PATCH 04/11] migration: Move dump_vmsate_json_to_file() to misc.h

2017-06-01 Thread Juan Quintela
It was not from vmstate.c to start with. Signed-off-by: Juan Quintela --- include/migration/misc.h| 4 include/migration/vmstate.h | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/migration/misc.h b/include/migration/misc.h index

[Qemu-devel] [PATCH 00/11] Misc migration cleanups

2017-06-01 Thread Juan Quintela
Hi This are a bit of everything: - Remove unneeded argumets for migration_channel_incomming - Lots of changes to make migration.h local to only migration * Move self_annonce_delay() to misc.h I know this conflicts for announce changes from Vlad, but I want to remove migration.h from

[Qemu-devel] [PATCH 01/11] migration: Remove MigrationState from migration_channel_incomming()

2017-06-01 Thread Juan Quintela
All callers were calling migrate_get_current(), so do it inside the function. Signed-off-by: Juan Quintela --- migration/channel.c | 5 +++-- migration/channel.h | 3 +-- migration/exec.c| 2 +- migration/fd.c | 2 +- migration/socket.c | 3 +-- migration/tls.c

Re: [Qemu-devel] [RFC 3/6] vfio: Setup IGD stolen memory

2017-06-01 Thread Alex Williamson
On Tue, 30 May 2017 01:30:33 +0800 Zhi Wang wrote: > We still keep using VM dedicated memory for isolation to support IGD > stolen in the guest. Becuase of the PA of the stolen memory can not be > moved after the system is powered-up, we wish the PA of the guest stolen >

Re: [Qemu-devel] [RFC PATCH] OvmfPkg/AcpiPlatformDxe: lift 4 GB alloc limit for modern ACPI systems

2017-06-01 Thread Laszlo Ersek
On 06/01/17 14:25, Laszlo Ersek wrote: > In QEMU, we could tie both of these extensions to new machine types. > > The result would be: > > firmware QEMU QEMU machine type result > - --- > old new old

Re: [Qemu-devel] [RFC 2/6] vfio: Setup IGD quirks earlier

2017-06-01 Thread Alex Williamson
On Tue, 30 May 2017 01:30:32 +0800 Zhi Wang wrote: > Initialize IGD quirks a bit earlier since we're going to support IGD > stolen memory under both primary mode (legacy mode) and secondary mode > and we need one extra memory region from IGD quirks. > > Suggested-by: Xiong

Re: [Qemu-devel] [RFC 1/6] vfio: Add Intel platform definitions

2017-06-01 Thread Alex Williamson
On Tue, 30 May 2017 01:30:38 +0800 Zhi Wang wrote: > This patch introduces device descriptions for Intel platforms. Most of > the Intel device definitions come from i915. > > Suggested-by: Xiong Zhang > Signed-off-by: Zhi Wang

Re: [Qemu-devel] [PATCH v3 30/30] target/s390x: update maximum TCG model to z800

2017-06-01 Thread David Hildenbrand
On 01.06.2017 21:17, Aurelien Jarno wrote: > On 2017-06-01 10:38, David Hildenbrand wrote: >> On 01.06.2017 00:01, Aurelien Jarno wrote: >>> At the same time fix the TCG version of get_max_cpu_model to return the >>> maximum model like on KVM. Remove the ETF2 and long-displacement >> >> I don't

Re: [Qemu-devel] [PATCH v7 0/7] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches

2017-06-01 Thread Emilio G. Cota
On Fri, Jan 13, 2017 at 21:48:09 +0100, Lluís Vilanova wrote: (snip) > To handle both issues, this series integrates the dynamic tracing event state > into the TB hashing function, so that vCPUs tracing different events will use > separate TBs. Note that only events with the 'vcpu' property are

Re: [Qemu-devel] [PATCH v2 02/15] file-posix: support BDRV_REQ_ALLOCATE

2017-06-01 Thread Eric Blake
On 06/01/2017 02:49 PM, Eric Blake wrote: > On 06/01/2017 10:14 AM, Anton Nefedov wrote: >> Current write_zeroes implementation is good enough to satisfy this flag too >> >> Signed-off-by: Anton Nefedov >> --- >> block/file-posix.c | 9 - >> 1 file changed, 8

Re: [Qemu-devel] [PATCH v2 03/15] blkdebug: support BDRV_REQ_ALLOCATE

2017-06-01 Thread Eric Blake
On 06/01/2017 10:14 AM, Anton Nefedov wrote: > Support the flag if the underlying BDS supports it > > Signed-off-by: Anton Nefedov > --- > block/blkdebug.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Shouldn't other passthrough drivers (like

Re: [Qemu-devel] [PATCH v2 02/15] file-posix: support BDRV_REQ_ALLOCATE

2017-06-01 Thread Eric Blake
On 06/01/2017 10:14 AM, Anton Nefedov wrote: > Current write_zeroes implementation is good enough to satisfy this flag too > > Signed-off-by: Anton Nefedov > --- > block/file-posix.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Are we sure that

[Qemu-devel] [PULL 14/15] migration: Export ram.c functions in its own file

2017-06-01 Thread Juan Quintela
All functions are internal except for ram_mig_init(). Create migration/misc.h for this kind of functions. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 38 ---

[Qemu-devel] [PULL 12/15] migration: Export rdma.c functions in its own file

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 4 migration/migration.c | 1 + migration/rdma.c | 1 + migration/rdma.h | 25 + 4

Re: [Qemu-devel] [PATCH v7 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state

2017-06-01 Thread Emilio G. Cota
On Fri, Jan 13, 2017 at 21:48:35 +0100, Lluís Vilanova wrote: > 9 files changed, 54 insertions(+), 11 deletions(-) > > diff --git a/cpu-exec.c b/cpu-exec.c > index 4188fed3c6..36709cba1f 100644 > --- a/cpu-exec.c > +++ b/cpu-exec.c > @@ -261,6 +261,7 @@ struct tb_desc { > CPUArchState *env;

[Qemu-devel] [PULL 08/15] migration: Export exec.c functions in its own file

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 4 migration/exec.c | 1 + migration/exec.h | 26 ++ migration/migration.c | 1 + 4

[Qemu-devel] [PULL 15/15] migration: Move include/migration/block.h into migration/

2017-06-01 Thread Juan Quintela
All functions were internal, except blk_mig_init() that is exported in misc.h now. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/misc.h | 8 migration/block.c| 3

[Qemu-devel] [PULL 06/15] migration: Remove unneeded includes of migration/vmstate.h

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert --- hw/core/qdev.c | 1 - include/hw/acpi/memory_hotplug.h | 1 - include/hw/acpi/pcihp.h | 1 -

[Qemu-devel] [PULL 13/15] migration: Create include for migration snapshots

2017-06-01 Thread Juan Quintela
Start removing migration code from sysemu/sysemu.h. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- hmp.c| 5 +++-- include/block/block_int.h| 4 ++-- include/migration/snapshot.h | 21

[Qemu-devel] [PULL 04/15] migration: fix leak of src file on dst

2017-06-01 Thread Juan Quintela
From: Peter Xu The return path channel is possibly leaked. Fix it. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 5 + 1 file changed, 5

[Qemu-devel] [PULL 11/15] migration: Export tls.c functions in its own file

2017-06-01 Thread Juan Quintela
Just for the functions exported from tls.c. Notice that we can't remove the migration/migration.h include from tls.c because it access directly MigrationState for the tls params. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert ---

[Qemu-devel] [PULL 10/15] migration: Export socket.c functions in its own file

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 8 migration/migration.c | 1 + migration/socket.c| 1 + migration/socket.h| 28

[Qemu-devel] [PULL 03/15] migration: Remove section_id parameter from vmstate_load

2017-06-01 Thread Juan Quintela
Everything else assumes that we always load a device from its own savevm handler. Signed-off-by: Juan Quintela Reviewed-by: Laurent Vivier Reviewed-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert ---

[Qemu-devel] [PULL 09/15] migration: Export fd.c functions in its own file

2017-06-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 4 migration/fd.c| 1 + migration/fd.h| 23 +++ migration/migration.c | 1 + 4 files

[Qemu-devel] [PULL 05/15] migration: shut src return path unconditionally

2017-06-01 Thread Juan Quintela
From: Peter Xu We were do the shutting off only for postcopy. Now we do this as long as the source return path is there. Moving the cleanup of from_src_file there too. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by:

[Qemu-devel] [PULL 07/15] migration: Split qemu-file.h

2017-06-01 Thread Juan Quintela
Split the file into public and internal interfaces. I have to rename the external one because we can't have two include files with the same name in the same directory. Build system gets confused. The only exported functions are the ones that handle basic types. Signed-off-by: Juan Quintela

[Qemu-devel] [PULL 02/15] migration: loadvm handlers are not used

2017-06-01 Thread Juan Quintela
So we remove all traces of them. Signed-off-by: Juan Quintela Reviewed-by: Laurent Vivier Reviewed-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 5 -

[Qemu-devel] [PULL 01/15] migration: Use savevm_handlers instead of loadvm copy

2017-06-01 Thread Juan Quintela
There is no reason for having the loadvm_handlers at all. There is only one use, and we can use the savevm handlers. We will remove the loadvm handlers on a following patch. Signed-off-by: Juan Quintela Reviewed-by: Laurent Vivier Reviewed-by: Peter Xu

[Qemu-devel] [PULL 00/15] Migration PULL request

2017-06-01 Thread Juan Quintela
-tracking branch 'remotes/riku/tags/pull-linux-user-20170531' into staging (2017-06-01 15:50:40 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20170601 for you to fetch changes up to 2c9e6fec89ff032a3f75a5a1caccc31901fb4056: migration: Move

Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init()

2017-06-01 Thread Aurelien Jarno
On 2017-06-01 16:23, Paolo Bonzini wrote: > > > On 01/06/2017 10:27, Marcel Apfelbaum wrote: > > On 31/05/2017 11:28, Paolo Bonzini wrote: > >> No, for now I'd rather just go and remove msi_nonbroken. When someone > >> reports a bug, we can add back "msi_broken". > > > > Hi, > > I agree with

Re: [Qemu-devel] [PATCH v1] s390x/cpumodel: wire up cpu type + id for TCG

2017-06-01 Thread Aurelien Jarno
On 2017-06-01 12:14, David Hildenbrand wrote: > Let's properly expose the CPU type (machine-type number) via "STORE CPU > ID" and "STORE SUBSYSTEM INFORMATION". > > As TCG emulates basic mode, the CPU identification number has the format > "An", whereby A is the CPU address, and n are parts

Re: [Qemu-devel] [PATCH v3 30/30] target/s390x: update maximum TCG model to z800

2017-06-01 Thread Aurelien Jarno
On 2017-06-01 11:04, David Hildenbrand wrote: > On 01.06.2017 10:38, David Hildenbrand wrote: > > On 01.06.2017 00:01, Aurelien Jarno wrote: > >> At the same time fix the TCG version of get_max_cpu_model to return the > >> maximum model like on KVM. Remove the ETF2 and long-displacement > > > > I

Re: [Qemu-devel] [PATCH v3 30/30] target/s390x: update maximum TCG model to z800

2017-06-01 Thread Aurelien Jarno
On 2017-06-01 10:38, David Hildenbrand wrote: > On 01.06.2017 00:01, Aurelien Jarno wrote: > > At the same time fix the TCG version of get_max_cpu_model to return the > > maximum model like on KVM. Remove the ETF2 and long-displacement > > I don't understand the part > "fix the TCG version of

Re: [Qemu-devel] [PATCH v2 01/15] block: introduce BDRV_REQ_ALLOCATE flag

2017-06-01 Thread Eric Blake
On 06/01/2017 10:14 AM, Anton Nefedov wrote: > The flag is supposed to indicate that the region of the disk image has > to be sufficiently allocated so it reads as zeroes. The call with the flag > set has to return -ENOTSUP if allocation cannot be done efficiently > (i.e. without falling back to

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-01 Thread John Snow
On 06/01/2017 03:30 AM, Sementsov-Ogievskiy Vladimir wrote: > Hi John! > > Look at our discussion about this in v18 thread. > I'm batting zero today; I literally missed that entire subthread. Sigh, thanks, I'll go back and read.

Re: [Qemu-devel] [PATCH v2 00/15] qcow2: space preallocation and COW improvements

2017-06-01 Thread John Snow
Missing qemu-block@, CCing. On 06/01/2017 11:14 AM, Anton Nefedov wrote: > Changes in v2: > - introduce new BDRV flag for write_zeroes() > instead of using driver callback directly. > Skipped introducing new functions like bdrv_co_pallocate() for now: > 1. it seems ok to keep

Re: [Qemu-devel] [PATCH v2 2/4] dump: add vmcoreinfo ELF note

2017-06-01 Thread Laszlo Ersek
On 06/01/17 15:03, Marc-André Lureau wrote: > Read vmcoreinfo note from guest memory when dump_info provides the > address, and write it as an ELF note in the dump. > > NUMBER(phys_base) in vmcoreinfo has only been recently introduced in > Linux 4.10 ("kexec: export the value of phys_base instead

Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure

2017-06-01 Thread Eric Blake
On 06/01/2017 01:06 PM, Laszlo Ersek wrote: > On 06/01/17 15:03, Marc-André Lureau wrote: >> One way or another, the guest could communicate various dump info (via >> guest agent or vmcoreinfo device) and populate that structure. It can >> then be used to augment the dump with various details, as

Re: [Qemu-devel] [PATCH v8 19/20] qcow2: report encryption specific image information

2017-06-01 Thread Eric Blake
On 06/01/2017 12:27 PM, Daniel P. Berrange wrote: > Currently 'qemu-img info' reports a simple "encrypted: yes" > field. This is not very useful now that qcow2 can support > multiple encryption formats. Users want to know which format > is in use and some data related to it. > > >

Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure

2017-06-01 Thread Laszlo Ersek
On 06/01/17 15:03, Marc-André Lureau wrote: > One way or another, the guest could communicate various dump info (via > guest agent or vmcoreinfo device) and populate that structure. It can > then be used to augment the dump with various details, as done in the > following patch. > >

Re: [Qemu-devel] [PATCH v8 12/20] qcow2: extend specification to cover LUKS encryption

2017-06-01 Thread Eric Blake
On 06/01/2017 12:27 PM, Daniel P. Berrange wrote: > Update the qcow2 specification to describe how the LUKS header is > placed inside a qcow2 file, when using LUKS encryption for the > qcow2 payload instead of the legacy AES-CBC encryption > > Reviewed-by: Eric Blake >

Re: [Qemu-devel] [PULL v2 00/34] Misc patches for 2016-06-01

2017-06-01 Thread Peter Maydell
On 1 June 2017 at 18:53, Peter Maydell wrote: > Test failure on OSX: > > TEST: tests/device-introspect-test... (pid=66373) > /aarch64/device/introspect/list: OK > /aarch64/device/introspect/none:

Re: [Qemu-devel] [PULL v2 00/34] Misc patches for 2016-06-01

2017-06-01 Thread Peter Maydell
On 1 June 2017 at 18:07, Paolo Bonzini wrote: > The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: > > Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging > (2017-05-18 13:36:15 +0100) > > are available in the git

[Qemu-devel] [PATCH v8 17/20] block: remove all encryption handling APIs

2017-06-01 Thread Daniel P. Berrange
Now that all encryption keys must be provided upfront via the QCryptoSecret API and associated block driver properties there is no need for any explicit encryption handling APIs in the block layer. Encryption can be handled transparently within the block driver. We only retain an API for querying

[Qemu-devel] [PATCH v8 14/20] qcow2: add iotests to cover LUKS encryption support

2017-06-01 Thread Daniel P. Berrange
This extends the 087 iotest to cover LUKS encryption when doing blockdev-add. Two further tests are added to validate read/write of LUKS encrypted images with a single file and with a backing file. Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v8 11/20] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-06-01 Thread Daniel P. Berrange
This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content, using the legacy QCow2 AES scheme. With this change it is now required to use the QCryptoSecret object for providing passwords, instead of the current block password APIs / interactive prompting.

  1   2   3   4   5   >