[Qemu-devel] [PATCH] blockjob: cancel blockjobs before stopping all iothreads

2017-06-02 Thread sochin.jiang
From: "sochin.jiang" commit 88b062c and commit c9d1a56 introduce BDRV_POLL_WHILE, checking bs->in_flight in the main thread and exit till bs->in_flight reaches 0. This leaves a chance that BDRV_POLL_WHILE will hang until iothread complete the relative block job when

[Qemu-devel] [PATCH] tcg: allocate TB structs before the corresponding translated code

2017-06-02 Thread Emilio G. Cota
Allocating an arbitrarily-sized array of tbs results in either (a) a lot of memory wasted or (b) unnecessary flushes of the code cache when we run out of TB structs in the array. An obvious solution would be to just malloc a TB struct when needed, and keep the TB array as an array of pointers

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] commit: Fix use after free in completion

2017-06-02 Thread John Snow
On 06/02/2017 05:12 PM, Kevin Wolf wrote: > Kevin Wolf (2): > commit: Fix use after free in completion > qemu-iotests: Test automatic commit job cancel on hot unplug > > block/commit.c | 7 +++ > tests/qemu-iotests/040 | 35 +-- >

Re: [Qemu-devel] allocation zone extensions for the firmware linker/loader

2017-06-02 Thread Laszlo Ersek
On 06/02/17 18:30, Michael S. Tsirkin wrote: > On Fri, Jun 02, 2017 at 05:45:21PM +0200, Laszlo Ersek wrote: >> Hi, >> >> this message is cross-posted to three lists (qemu, seabios, edk2). I'll >> follow up with three patch series, one series for each project. I'll >> cross-post all of the patches

Re: [Qemu-devel] [PATCH v20 14/30] qcow2: support .bdrv_reopen_bitmaps_rw

2017-06-02 Thread John Snow
On 06/02/2017 07:21 AM, Vladimir Sementsov-Ogievskiy wrote: > Realize bdrv_reopen_bitmaps_rw interface. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow > --- > block/qcow2-bitmap.c | 61 >

Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure

2017-06-02 Thread Laszlo Ersek
On 06/02/17 11:55, Marc-André Lureau wrote: > Hi > > On Fri, Jun 2, 2017 at 1:46 PM Marc-André Lureau > wrote: > >> Hi >> >> On Thu, Jun 1, 2017 at 10:19 PM Eric Blake wrote: >> >>> On 06/01/2017 01:06 PM, Laszlo Ersek wrote: On 06/01/17

Re: [Qemu-devel] [RFC PATCH] OvmfPkg/AcpiPlatformDxe: lift 4 GB alloc limit for modern ACPI systems

2017-06-02 Thread Laszlo Ersek
On 06/02/17 16:56, Gerd Hoffmann wrote: > Hi, > >> The reason is that old firmware is allowed to fail on new QEMU >> (regardless of machine type). Example: the WRITE_POINTER command, >> originally introduced for VMGENID. If you run a SeaBIOS binary >> without >> WRITE_POINTER support, in a

Re: [Qemu-devel] [PATCH v20 13/30] block: new bdrv_reopen_bitmaps_rw interface

2017-06-02 Thread John Snow
On 06/02/2017 07:21 AM, Vladimir Sementsov-Ogievskiy wrote: > Add format driver handler, which should mark loaded read-only > bitmaps as 'IN_USE' in the image and unset read_only field in > corresponding BdrvDirtyBitmap's. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH] configure: Define NCURSES_WIDECHAR if we're using curses

2017-06-02 Thread Laszlo Ersek
On 06/02/17 16:35, Peter Maydell wrote: > We want the wide character functions from the ncurses header. > Unfortunately it doesn't provide them by default, but only > if either: > * NCURSES_WIDECHAR is defined (for ncurses 20111030 and up) > * _XOPEN_SOURCE/_XOPEN_SOURCE_EXTENDED are suitably

Re: [Qemu-devel] [PATCH v20 12/30] block: refactor bdrv_reopen_commit

2017-06-02 Thread John Snow
On 06/02/2017 07:21 AM, Vladimir Sementsov-Ogievskiy wrote: > Add bs local variable to simplify code. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/block.c

Re: [Qemu-devel] [PATCH v20 11/30] qcow2: autoloading dirty bitmaps

2017-06-02 Thread John Snow
On 06/02/2017 07:21 AM, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They > are loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Extra data in bitmaps is not supported for now. > >

Re: [Qemu-devel] [PULL v2 00/22] Docker and block patches

2017-06-02 Thread Fam Zheng
Cc'ing Paolo. On Fri, 06/02 16:50, Peter Maydell wrote: > On 2 June 2017 at 09:10, Fam Zheng wrote: > > The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01: > > > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31' > > into

[Qemu-devel] [PATCH 0/2] commit: Fix use after free in completion

2017-06-02 Thread Kevin Wolf
Kevin Wolf (2): commit: Fix use after free in completion qemu-iotests: Test automatic commit job cancel on hot unplug block/commit.c | 7 +++ tests/qemu-iotests/040 | 35 +-- tests/qemu-iotests/040.out | 4 ++-- 3 files changed, 42

[Qemu-devel] [PATCH 2/2] qemu-iotests: Test automatic commit job cancel on hot unplug

2017-06-02 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/040 | 35 +-- tests/qemu-iotests/040.out | 4 ++-- 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040 index 5bdaf3d..9d381d9 100755

[Qemu-devel] [PATCH 1/2] commit: Fix use after free in completion

2017-06-02 Thread Kevin Wolf
The final bdrv_set_backing_hd() could be working on already freed nodes because the commit job drops its references (through BlockBackends) to both overlay_bs and top already a bit earlier. One way to trigger the bug is hot unplugging a disk for which blockdev_mark_auto_del() cancels the block

Re: [Qemu-devel] [PATCH v20 09/30] block/dirty-bitmap: fix comment for BlockDirtyBitmap.disabled field

2017-06-02 Thread John Snow
On 06/02/2017 07:21 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirty-bitmap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c > index

Re: [Qemu-devel] [PATCH v20 10/30] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-02 Thread John Snow
On 06/02/2017 07:21 AM, Vladimir Sementsov-Ogievskiy wrote: > It will be needed in following commits for persistent bitmaps. > If bitmap is loaded from read-only storage (and we can't mark it > "in use" in this storage) corresponding BdrvDirtyBitmap should be > read-only. > > Signed-off-by:

Re: [Qemu-devel] [PULL 00/15] chardev patches

2017-06-02 Thread Marc-André Lureau
On Fri, Jun 2, 2017 at 7:37 PM Peter Maydell wrote: > On 2 June 2017 at 08:40, Marc-André Lureau > wrote: > > The following changes since commit > 43771d5d92312504305c19abe29ec5bfabd55f01: > > > > Merge remote-tracking branch >

[Qemu-devel] [PATCH v5 23/24] MAINTAINERS: add Shippable automation platform URL

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7df088259b..d578504294 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1865,6 +1865,7 @@ F:

[Qemu-devel] [PATCH v5 21/24] shippable: add powerpc target

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- .shippable.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index 2070c4d827..aad66ec5ec 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -11,6

[Qemu-devel] [PATCH v5 19/24] shippable: be verbose while building docker images

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml index 46adfa030f..fe360f85cb 100644 --- a/.shippable.yml +++

[Qemu-devel] [PATCH v5 24/24] MAINTAINERS: self-appoint me as reviewer in build/test automation

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d578504294..916c0e96cc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1859,6 +1859,7 @@

[Qemu-devel] [PATCH v5 17/24] shippable: build using all available cpus

2017-06-02 Thread Philippe Mathieu-Daudé
As of this commit: $ echo "container proc:" `getconf _NPROCESSORS_ONLN` `getconf _NPROCESSORS_CONF` container proc: 2 2 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH v5 16/24] shippable: use C locale to simplify console output

2017-06-02 Thread Philippe Mathieu-Daudé
remove this noise: perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = "en_US.UTF-8", LC_CTYPE = "en_US.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. Signed-off-by: Philippe

[Qemu-devel] [PATCH v5 13/24] docker: add extra libs to s390x target to extend codebase coverage

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/dockerfiles/debian-s390x-cross.docker | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/docker/dockerfiles/debian-s390x-cross.docker

[Qemu-devel] [PATCH v5 22/24] shippable: add mipsel target

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- .shippable.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index aad66ec5ec..75c2895a21 100644 --- a/.shippable.yml +++ b/.shippable.yml @@

[Qemu-devel] [PATCH v5 20/24] shippable: add armeb-linux-user target

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml index fe360f85cb..2070c4d827 100644 --- a/.shippable.yml +++

[Qemu-devel] [PATCH v5 12/24] docker: add extra libs to arm64 target to extend codebase coverage

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/dockerfiles/debian-arm64-cross.docker | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker

[Qemu-devel] [PATCH v5 11/24] docker: add extra libs to armhf target to extend codebase coverage

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/dockerfiles/debian-armhf-cross.docker | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker

[Qemu-devel] [PATCH v5 18/24] shippable: do not initialize submodules automatically

2017-06-02 Thread Philippe Mathieu-Daudé
instead do it in the 'ci' target when needed. for mips64el-softmmu target: use dtc submodule if distrib packages are too old. example with outdated libfdt on mips64el-softmmu target (required is >= 1.4.2): # dpkg-query --showformat='${Version}\n' --show libfdt-dev 1.4.0+dfsg-1 shippable

[Qemu-devel] [PATCH v5 15/24] docker: add powerpc build target

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/Makefile.include | 2 ++ .../docker/dockerfiles/debian-powerpc-cross.docker | 40 ++ 2 files changed, 42 insertions(+) create mode

[Qemu-devel] [PATCH v5 10/24] docker: use eatmydata in debian arm64 image

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/dockerfiles/debian-arm64-cross.docker | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker

[Qemu-devel] [PATCH v5 14/24] docker: add mipsel build target

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/Makefile.include | 3 ++ .../docker/dockerfiles/debian-mipsel-cross.docker | 41 ++ 2 files changed, 44 insertions(+) create mode

[Qemu-devel] [PATCH v5 07/24] docker: use better regex to generate deb-src entries

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/dockerfiles/debian.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/debian.docker b/tests/docker/dockerfiles/debian.docker

[Qemu-devel] [PATCH v5 06/24] docker: create deb-src entry and setup Emdebian in the same layer

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/dockerfiles/debian.docker | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tests/docker/dockerfiles/debian.docker

[Qemu-devel] [PATCH v5 09/24] docker: use eatmydata in debian armhf image

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/dockerfiles/debian-armhf-cross.docker | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker

[Qemu-devel] [PATCH v5 03/24] docker: rebuild image if 'extra files' checksum does not match

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/docker.py | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 10fa907905..e707e5bcca

[Qemu-devel] [PATCH v5 04/24] docker: add 'apt-fake' script which generate fake debian packages

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/dockerfiles/debian-apt-fake.sh | 46 + 1 file changed, 46 insertions(+) create mode 100755 tests/docker/dockerfiles/debian-apt-fake.sh diff

[Qemu-devel] [PATCH v5 08/24] docker: use eatmydata, install common build packages in base image

2017-06-02 Thread Philippe Mathieu-Daudé
The common build packages are: build-essential clang git bison flex Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/dockerfiles/debian.docker | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v5 05/24] docker: install ca-certificates package in base image

2017-06-02 Thread Philippe Mathieu-Daudé
Resolve SSL verification issue at shippable container's git_sync stage: shippable logs: -- git_sync - ssh-agent bash -c 'ssh-add /tmp/ssh/01_deploy; git clone https://github.com/philmd/qemu.git /root/src/github.com/philmd/qemu' Identity added: /tmp/ssh/01_deploy (rsa w/o comment)

[Qemu-devel] [PATCH v5 02/24] docker: add --include-files argument to 'build' command

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/Makefile.include | 3 +++ tests/docker/docker.py| 12 +--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/tests/docker/Makefile.include

[Qemu-devel] [PATCH v5 00/24] docker/shippable: cross-build mipsel and powerpc targets

2017-06-02 Thread Philippe Mathieu-Daudé
This patchset add 2 more architectures to the cross-build farm. There is still some issue trying to cross-build mips64el-softmmu, it seems the cross tools use the system outdated libfdt instead of the one checkouted in the dtc submodule. I disabled this target for now. The branch

[Qemu-devel] [PATCH v5 01/24] docker: let _copy_with_mkdir() sub_path argument be optional

2017-06-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- tests/docker/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 8747f6a440..6ddc6e4c2a 100755 ---

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-02 Thread John Snow
On 06/02/2017 05:45 AM, Vladimir Sementsov-Ogievskiy wrote: > 02.06.2017 12:01, Vladimir Sementsov-Ogievskiy wrote: >> 02.06.2017 11:56, Vladimir Sementsov-Ogievskiy wrote: >>> 02.06.2017 02:25, John Snow wrote: On 06/01/2017 03:30 AM, Sementsov-Ogievskiy Vladimir wrote: > Hi John!

Re: [Qemu-devel] [PULL 00/15] chardev patches

2017-06-02 Thread Philippe Mathieu-Daudé
On 06/02/2017 12:36 PM, Peter Maydell wrote: On 2 June 2017 at 08:40, Marc-André Lureau wrote: The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31' into staging

Re: [Qemu-devel] [PATCH v4 9/9] hw/misc/exynos4210_pmu: Add support for system poweroff

2017-06-02 Thread Philippe Mathieu-Daudé
On 06/02/2017 01:36 PM, Krzysztof Kozlowski wrote: On all Exynos-based boards, the system powers down itself by driving PS_HOLD signal low - eight bit in PS_HOLD_CONTROL register of PMU. Handle writing to respective PMU register to fix power off failure: reboot: Power down Unable to

Re: [Qemu-devel] [PATCH v4 2/9] hw/timer/exynos4210_mct: Fix checkpatch style errors

2017-06-02 Thread Philippe Mathieu-Daudé
On 06/02/2017 01:36 PM, Krzysztof Kozlowski wrote: Fix checkpatch errors: 1. ERROR: spaces required around that '+' (ctx:VxV) 2. ERROR: spaces required around that '&' (ctx:VxV) No functional changes. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v4 3/9] hw/timer/exynos4210_mct: Cleanup indentation and empty new lines

2017-06-02 Thread Philippe Mathieu-Daudé
On 06/02/2017 01:36 PM, Krzysztof Kozlowski wrote: Statements under 'case' were in some places wrongly indented bringing confusion and making the code less readable. Remove also few unneeded blank lines. No functional changes. Signed-off-by: Krzysztof Kozlowski Reviewed-by:

Re: [Qemu-devel] [PATCH v4 1/9] hw/intc/exynos4210_gic: Use more meaningful name for local variable

2017-06-02 Thread Philippe Mathieu-Daudé
On 06/02/2017 01:36 PM, Krzysztof Kozlowski wrote: There are to SysBusDevice variables in exynos4210_gic_realize() function: one for the device itself and second for arm_gic device. Add a prefix "gic" to the second one so it will be easier to understand the code. While at it, put local

Re: [Qemu-devel] [PATCH v3 3/9] exec: split qemu_ram_alloc_from_file()

2017-06-02 Thread Eduardo Habkost
On Fri, Jun 02, 2017 at 06:12:23PM +0400, Marc-André Lureau wrote: > Add qemu_ram_alloc_from_fd(), which can be use to allocate ramblock from > fd only. > > Signed-off-by: Marc-André Lureau > --- > include/exec/ram_addr.h | 3 +++ > exec.c | 45

Re: [Qemu-devel] [PATCH 3/4] ram: Print block stats also in the complete case

2017-06-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > To make things easier, I just moved it to populate_ram_info(). Blk is not RAM; better to create a separate function. Dave > Signed-off-by: Juan Quintela > --- > migration/migration.c | 26 -- > 1 file

Re: [Qemu-devel] [PATCH v2 5/6] pci: Make errp the last parameter of pci_add_capability()

2017-06-02 Thread Eduardo Habkost
On Fri, Jun 02, 2017 at 03:54:41PM +0800, Mao Zhongyi wrote: > Add Error argument for pci_add_capability() to leverage the errp > to pass info on errors. This way is helpful for its callers to > make a better error handling when moving to 'realize'. > > Cc: m...@redhat.com > Cc:

Re: [Qemu-devel] [PULL 0/8] virtio, vhost: fixes, features

2017-06-02 Thread Peter Maydell
On 2 June 2017 at 17:34, Michael S. Tsirkin wrote: > The following changes since commit d47a851caeda96d5979bf48d4bae6a87784ad91d: > > Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170601' > into staging (2017-06-02 14:07:53 +0100) > > are available in the

Re: [Qemu-devel] [PATCH v1 2/2] s390x/cpumodel: improve defintion search without an IBC

2017-06-02 Thread Halil Pasic
On 06/01/2017 07:42 PM, David Hildenbrand wrote: > On 01.06.2017 19:06, Jason J. Herne wrote: >> On 05/31/2017 03:34 PM, David Hildenbrand wrote: >>> Currently, under z/VM on a 0x2827, QEMU will detect a 0x2828 if no >>> IBC value is provided. QEMU will simply take the last model of that HW >>>

Re: [Qemu-devel] [PATCH v4 7/7] numa: cpu: calculate/set default node-ids after all -numa CLI options are parsed

2017-06-02 Thread Eduardo Habkost
On Thu, Jun 01, 2017 at 12:53:28PM +0200, Igor Mammedov wrote: > Calculating default node-ids for CPUs in possible_cpu_arch_ids() > is rather fragile since defaults calculation uses nb_numa_nodes but > callback might be potentially called early before all -numa CLI > options are parsed, which

Re: [Qemu-devel] [PATCH] RFC: vmcoreinfo device

2017-06-02 Thread Eduardo Habkost
On Thu, Jun 01, 2017 at 10:16:50AM +, Marc-André Lureau wrote: > Hi > > On Wed, Apr 26, 2017 at 2:58 AM Eduardo Habkost wrote: > > > On Tue, Apr 25, 2017 at 11:35:23PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Apr 25, 2017 at 05:29:20PM -0300, Eduardo Habkost

Re: [Qemu-devel] [PATCH 3/3] vhost: iommu: cache static mapping if there is

2017-06-02 Thread Michael S. Tsirkin
On Fri, Jun 02, 2017 at 07:50:54PM +0800, Peter Xu wrote: > This patch pre-heat vhost iotlb cache when passthrough mode enabled. > > Sometimes, even if user specified iommu_platform for vhost devices, > IOMMU might still be disabled. One case is passthrough mode in VT-d > implementation. We can

Re: [Qemu-devel] [PULL v2 00/34] Misc patches for 2016-06-01

2017-06-02 Thread Peter Maydell
On 2 June 2017 at 09:06, Paolo Bonzini wrote: > On 01/06/2017 19:56, Peter Maydell wrote: >> On 1 June 2017 at 18:53, Peter Maydell wrote: >>> Test failure on OSX: >>> >>> TEST: tests/device-introspect-test... (pid=66373) >>>

Re: [Qemu-devel] [PULL 0/1] Block patches

2017-06-02 Thread Peter Maydell
On 2 June 2017 at 16:33, Jeff Cody wrote: > The following changes since commit d47a851caeda96d5979bf48d4bae6a87784ad91d: > > Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170601' > into staging (2017-06-02 14:07:53 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH 2/3] exec: simplify address_space_get_iotlb_entry

2017-06-02 Thread Michael S. Tsirkin
On Fri, Jun 02, 2017 at 07:50:53PM +0800, Peter Xu wrote: > This patch let address_space_get_iotlb_entry() to use the newly > introduced page_mask parameter in address_space_do_translate(). Then we > will be sure the IOTLB can be aligned to page mask, also we should > nicely support huge pages now

Re: [Qemu-devel] [PATCH 1/3] exec: add page_mask for address_space_do_translate

2017-06-02 Thread Michael S. Tsirkin
On Fri, Jun 02, 2017 at 07:50:52PM +0800, Peter Xu wrote: > The function is originally used for address_space_translate() and what > we care about most is (xlat, plen) range. However for iotlb requests, we > don't really care about "plen", but the size of the page that "xlat" is > located on.

[Qemu-devel] [PATCH v4 9/9] hw/misc/exynos4210_pmu: Add support for system poweroff

2017-06-02 Thread Krzysztof Kozlowski
On all Exynos-based boards, the system powers down itself by driving PS_HOLD signal low - eight bit in PS_HOLD_CONTROL register of PMU. Handle writing to respective PMU register to fix power off failure: reboot: Power down Unable to poweroff system shutdown: 31 output lines suppressed

[Qemu-devel] [PATCH v4 5/9] hw/arm/exynos: Move DRAM initialization next boards

2017-06-02 Thread Krzysztof Kozlowski
Before QOM-ifying the Exynos4 SoC model, move the DRAM initialization from exynos4210.c to exynos4_boards.c because DRAM is board specific, not SoC. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 20

[Qemu-devel] [PATCH v4 6/9] hw/arm/exynos: Declare local variables in some order

2017-06-02 Thread Krzysztof Kozlowski
Bring some more readability by declaring local function variables: first initialized ones and then the rest (with reversed-christmas-tree order). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 4 ++-- 1 file

[Qemu-devel] [PATCH v4 8/9] hw/intc/exynos4210_gic: Constify array of combiner interrupts

2017-06-02 Thread Krzysztof Kozlowski
The static array of interrupt combiner mappings is not modified so it can be made const for code safeness. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Philippe Mathieu-Daudé --- hw/intc/exynos4210_gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PATCH v4 2/9] hw/timer/exynos4210_mct: Fix checkpatch style errors

2017-06-02 Thread Krzysztof Kozlowski
Fix checkpatch errors: 1. ERROR: spaces required around that '+' (ctx:VxV) 2. ERROR: spaces required around that '&' (ctx:VxV) No functional changes. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Peter Maydell --- hw/timer/exynos4210_mct.c | 4 ++--

[Qemu-devel] [PATCH v4 4/9] hw/timer/exynos4210_mct: Remove unused defines

2017-06-02 Thread Krzysztof Kozlowski
Remove defines not used anywhere. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Peter Maydell --- hw/timer/exynos4210_mct.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index

[Qemu-devel] [PATCH v4 3/9] hw/timer/exynos4210_mct: Cleanup indentation and empty new lines

2017-06-02 Thread Krzysztof Kozlowski
Statements under 'case' were in some places wrongly indented bringing confusion and making the code less readable. Remove also few unneeded blank lines. No functional changes. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Peter Maydell ---

[Qemu-devel] [PATCH v4 7/9] hw/arm/exynos: Use type define instead of hard-coded a9mpcore_priv string

2017-06-02 Thread Krzysztof Kozlowski
Use a define for a9mpcore_priv device type name instead of hard-coded string. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 3/5] migration: Print statistics about the number of remaining target pages

2017-06-02 Thread Juan Quintela
Eric Blake wrote: > On 06/01/2017 05:08 PM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 4 +++- >> migration/ram.c | 4 ++-- >> migration/ram.h | 2 +- >> qapi-schema.json | 6 +- >> 4 files

[Qemu-devel] [PULL 4/8] vhost: propagate errors in vhost_device_iotlb_miss()

2017-06-02 Thread Michael S. Tsirkin
From: Maxime Coquelin Some backends might want to know when things went wrong. Signed-off-by: Maxime Coquelin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL 8/8] spec/vhost-user spec: Add IOMMU support

2017-06-02 Thread Michael S. Tsirkin
From: Maxime Coquelin This patch specifies and implements the master/slave communication to support device IOTLB in slave. The vhost_iotlb_msg structure introduced for kernel backends is re-used, making the design close between the two backends. An exception is the

[Qemu-devel] [PATCH v4 1/9] hw/intc/exynos4210_gic: Use more meaningful name for local variable

2017-06-02 Thread Krzysztof Kozlowski
There are to SysBusDevice variables in exynos4210_gic_realize() function: one for the device itself and second for arm_gic device. Add a prefix "gic" to the second one so it will be easier to understand the code. While at it, put local uninitialized 'i' variable at the end, next to other

[Qemu-devel] [PULL 3/8] virtio-serial: fix segfault on disconnect

2017-06-02 Thread Michael S. Tsirkin
From: Stefan Hajnoczi Since commit d4c19cdeeb2f1e474bc426a6da261f1d7346eb5b ("virtio-serial: add missing virtio_detach_element() call") the following commands may cause QEMU to segfault: $ qemu -M accel=kvm -cpu host -m 1G \ -drive

[Qemu-devel] [PULL 7/8] vhost-user: add slave-req-fd support

2017-06-02 Thread Michael S. Tsirkin
From: Marc-André Lureau Learn to give a socket to the slave to let him make requests to the master. Signed-off-by: Marc-André Lureau Signed-off-by: Maxime Coquelin Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 6/8] vhost-user: add vhost_user to hold the chr

2017-06-02 Thread Michael S. Tsirkin
From: Marc-André Lureau Next patches will add more fields to the structure Signed-off-by: Marc-André Lureau Signed-off-by: Maxime Coquelin Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL 5/8] vhost: rework IOTLB messaging

2017-06-02 Thread Michael S. Tsirkin
From: Maxime Coquelin This patch reworks IOTLB messaging to prepare for vhost-user device IOTLB support. IOTLB messages handling is extracted from vhost-kernel backend, so that only the messages transport remains backend specifics. Signed-off-by: Maxime Coquelin

[Qemu-devel] [PULL 1/8] virtio-serial-bus: Unset hotplug handler when unrealize

2017-06-02 Thread Michael S. Tsirkin
From: Ladi Prosek Virtio serial device controls the lifetime of virtio-serial-bus and virtio-serial-bus links back to the device via its hotplug-handler property. This extra ref-count prevents the device from getting finalized, leaving the VirtIODevice memory listener

[Qemu-devel] [PULL 2/8] virtio: add virtqueue_alloc_element tracepoint

2017-06-02 Thread Michael S. Tsirkin
From: Paolo Bonzini This tracepoint can help diagnosing failures due to memory fragmentation in the guest. Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL 0/8] virtio, vhost: fixes, features

2017-06-02 Thread Michael S. Tsirkin
The following changes since commit d47a851caeda96d5979bf48d4bae6a87784ad91d: Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170601' into staging (2017-06-02 14:07:53 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

Re: [Qemu-devel] allocation zone extensions for the firmware linker/loader

2017-06-02 Thread Michael S. Tsirkin
On Fri, Jun 02, 2017 at 05:45:21PM +0200, Laszlo Ersek wrote: > Hi, > > this message is cross-posted to three lists (qemu, seabios, edk2). I'll > follow up with three patch series, one series for each project. I'll > cross-post all of the patches as well, but I'll add the project name in > the

[Qemu-devel] [PATCH v4 0/9] hw: arm: exynos: Improvements and cleanups

2017-06-02 Thread Krzysztof Kozlowski
Hi, I split non-intrusive changes from my previous attempts [1]. This patchset contains only cleanups, minor improvements and support for power off. Power off itself will not happen because kernel will hang before trying it, on syncing IRQ works (fix for this is [2], but this will be separate).

[Qemu-devel] [RISU PATCH v4 02/10] build-all-archs: support cross building via docker

2017-06-02 Thread Alex Bennée
If we want to link to any other libraries we might find using simple cross toolchains doesn't work so well. One way around this is to use a dockerised cross-toolchain which then won't clash with your host system. If the user specifies --use-docker the obvious will be done. By default we use the

Re: [Qemu-devel] [PATCH 0/2] Fix compilation dependency issues of CONFIG_ARM_V7M

2017-06-02 Thread Alex Bennée
Peter Maydell writes: > On 2 June 2017 at 16:49, Alex Bennée wrote: >> Peter Maydell writes: >>> We seem to run into "CONFIG_FOO is defined for make but not >>> for the C preprocessor" from time to time, so maybe we

[Qemu-devel] [RISU PATCH v4 01/10] .gitignore: ignore build directories

2017-06-02 Thread Alex Bennée
These are generated by the build-all-arches script. Signed-off-by: Alex Bennée --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index fc84419..fca9128 100644 --- a/.gitignore +++ b/.gitignore @@ -6,3 +6,4 @@ risu core config.h

[Qemu-devel] [RISU PATCH v4 08/10] risu: add support compressed tracefiles

2017-06-02 Thread Alex Bennée
This uses the magic of zlib's gzread/write interface to wrap the tracefile in compression. The code changes are tiny. I spent more time messing about with the configure/linker stuff to auto-detect bits. As you need decent multi-arch support or a correctly setup cross toolchain we fall back if we

[Qemu-devel] [RISU PATCH v4 10/10] new: run_risu.sh script

2017-06-02 Thread Alex Bennée
A simple script to work through running all of a bunch of files with record/playback traces. Dumps a summary and the number of failed tests at the end. Signed-off-by: Alex Bennée --- v3 - tweak to allow specifying RISU binary --- run_risu.sh | 53

[Qemu-devel] [edk2 PATCH 0/3] OvmfPkg/AcpiPlatformDxe: NOACPI hint and 64-bit zone in fw_cfg blob alloc

2017-06-02 Thread Laszlo Ersek
Please see the parent blurb http://mid.mail-archive.com/c76b36de-ebf9-c662-d454-0a95b43901e8@redhat.com> for a high level description. Repo: https://github.com/lersek/edk2.git Branch: zone_hints Cc: "Michael S. Tsirkin" Cc:

[Qemu-devel] [RISU PATCH v4 06/10] risu: add header to trace stream

2017-06-02 Thread Alex Bennée
I've also added a header packet with pc/risu op in it so we can keep better track of how things are going. Signed-off-by: Alex Bennée --- v4 - split from previous patch --- reginfo.c | 103 + risu.h

[Qemu-devel] [RISU PATCH v4 09/10] new: record_traces.sh helper script

2017-06-02 Thread Alex Bennée
A simple script to run through a bunch of binaries and generate their trace files. Signed-off-by: Alex Bennée --- v3 - allow overriding of RISU binary --- record_traces.sh | 20 1 file changed, 20 insertions(+) create mode 100755 record_traces.sh

Re: [Qemu-devel] [Qemu-block] [PATCH 10/29] qed: Remove callback from qed_write_header()

2017-06-02 Thread Stefan Hajnoczi
On Thu, Jun 01, 2017 at 06:04:25PM +0200, Paolo Bonzini wrote: > > > On 01/06/2017 17:59, Kevin Wolf wrote: > > Am 31.05.2017 um 14:32 hat Stefan Hajnoczi geschrieben: > >> On Fri, May 26, 2017 at 10:21:51PM +0200, Kevin Wolf wrote: > >>> static void qed_clear_need_check(void *opaque, int ret)

[Qemu-devel] [RISU PATCH v4 07/10] risu: add simple trace and replay support

2017-06-02 Thread Alex Bennée
This adds a very dumb and easily breakable trace and replay support. In --master mode the various risu ops trigger a write of register/memory state into a binary file which can be played back to an apprentice. Currently there is no validation of the image source so feeding the wrong image will

Re: [Qemu-devel] [Qemu-block] [PATCH 10/29] qed: Remove callback from qed_write_header()

2017-06-02 Thread Stefan Hajnoczi
On Thu, Jun 01, 2017 at 05:59:53PM +0200, Kevin Wolf wrote: > Am 31.05.2017 um 14:32 hat Stefan Hajnoczi geschrieben: > > On Fri, May 26, 2017 at 10:21:51PM +0200, Kevin Wolf wrote: > > > static void qed_clear_need_check(void *opaque, int ret) > > > { > > > BDRVQEDState *s = opaque; > > >

[Qemu-devel] [RISU PATCH v4 04/10] risu: a bit more verbosity when running

2017-06-02 Thread Alex Bennée
Before this is could seem a little quite when running as you had no indication stuff was happening (or how fast). I only dump on the master side as I want to minimise the amount of qemu logs to sift through. Signed-off-by: Alex Bennée -- v3 - use portable fmt string

[Qemu-devel] [seabios PATCH 1/2] romfile_loader: alloc: cope with the UEFI-oriented NOACPI content hint

2017-06-02 Thread Laszlo Ersek
OvmfPkg/AcpiPlatformDxe, which implements the client for QEMU's linker/loader in the OVMF and ArmVirtQemu virtual UEFI firmwares, currently relies on a 2nd pass processing of the ADD_POINTER commands, to identify potential ACPI tables in the pointed-to blobs. The reason for this is that ACPI

[Qemu-devel] [edk2 PATCH 2/3] OvmfPkg/AcpiPlatformDxe: support NOACPI content hint in ALLOCATE command

2017-06-02 Thread Laszlo Ersek
This driver currently relies on a 2nd pass processing of the ADD_POINTER commands to identify potential ACPI tables in the pointed-to blobs. In order to tell apart ACPI tables from other operation region-like areas within pointed-to blobs, we employ a heuristic called "ACPI SDT header probe" at

[Qemu-devel] [RISU PATCH v4 05/10] risu: paramterise send/receive functions

2017-06-02 Thread Alex Bennée
This is a precursor to record/playback support. Instead of passing the socket fd we now pass helper functions for reading/writing and responding. This will allow us to do the rest of the record/playback cleanly outside of the main worker function. Signed-off-by: Alex Bennée

[Qemu-devel] [RISU PATCH v4 00/10] record/replay patches

2017-06-02 Thread Alex Bennée
Hi, After much messing about I finally got this re-base working. The recent re-factoring work has made the code a lot simple. I also ran into problems getting a decent cross-compiler that could link against a zlib. This was manly down to multi-arch conflicts when I try and install

[Qemu-devel] [qemu PATCH 6/7] hw/i386/acpi-build: ask the fw to alloc ACPI_BUILD_TPMLOG_FILE with 64bit/NOACPI

2017-06-02 Thread Laszlo Ersek
The "etc/tpm/log" fw_cfg blob is guaranteed not to contain ACPI tables, so turning off the ACPI SDT header probe in OVMF is the right thing to do. In addition, the address of the blob is patched into the "TCPA.log_area_start_address" field, which has type "uint64_t". Therefore we can change the

[Qemu-devel] [edk2 PATCH 1/3] OvmfPkg/AcpiPlatformDxe: rename BLOB.HostsOnlyTableData to BLOB.Releasable

2017-06-02 Thread Laszlo Ersek
The "BLOB.HostsOnlyTableData" field tracks whether the allocated & downloaded fw_cfg blob should be released in the end. The current name "HostsOnlyTableData" reflects only the original determinant for this, namely whether the blob hosts ACPI table data only -- because in that case

  1   2   3   4   >