Re: [Qemu-devel] [RFC] q35/mch: implement extended TSEG sizes

2017-06-06 Thread Gerd Hoffmann
Hi, Patch looks sane overall. > Invent a new, QEMU-specific register in the config space of the DRAM > Controller, at offset 0x50, in order to allow guest firmware to query > the > TSEG (SMRAM) size. Hmm, 0x50 appears to be the only unused config space register in the specs. I suspect in

Re: [Qemu-devel] [PATCH 0/3] ppc: fix memory leaks

2017-06-06 Thread Greg Kurz
On Wed, 7 Jun 2017 09:45:06 +1000 David Gibson wrote: > On Tue, Jun 06, 2017 at 05:22:42PM +0200, Greg Kurz wrote: > > Coverity just reported a memory leak introduced by this commit (QEMU 2.9): > > > > commit df58713396f8b2deb923e39c00b10744c5c63909 > > Author:

Re: [Qemu-devel] [PATCH v3 5/7] pci: Make errp the last parameter of pci_add_capability()

2017-06-06 Thread Mao Zhongyi
Hi, Eduardo On 06/06/2017 10:52 PM, Eduardo Habkost wrote: On Tue, Jun 06, 2017 at 07:26:30PM +0800, Mao Zhongyi wrote: Add Error argument for pci_add_capability() to leverage the errp to pass info on errors. This way is helpful for its callers to make a better error handling when moving to

[Qemu-devel] [PATCH] Remove restriction that prevents bootimg elf64 images

2017-06-06 Thread Anatol Pomozov
It is possible to create a 64 bit elf image that has valid multiboot header. qemu should be able to boot such images. Tested with homemade 64bit OS - now it boots fine with 'qemu -kernel' and as a grub image. Signed-off-by: Anatol Pomozov --- hw/i386/multiboot.c | 5

[Qemu-devel] [Bug 1031955] Re: qemu-system-arm -M lm3s811evb fails

2017-06-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1031955 Title:

Re: [Qemu-devel] [PULL 0/2] Net patches

2017-06-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 0/2] Net patches Message-id: 1496806444-27910-1-git-send-email-jasow...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [Bug 1077708] Re: Video capture from webcam with USB passthrough freezes

2017-06-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1077708 Title: Video

[Qemu-devel] [Bug 1089005] Re: Qemu does not shutdown with vnc enabled on OS X

2017-06-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1089005 Title: Qemu does

[Qemu-devel] [Bug 1078892] Re: qemu doesn't general protection fault if there are reserved bits set in page-directory-pointer table entries

2017-06-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1078892 Title: qemu

[Qemu-devel] [Bug 1073952] Re: data sent to serial interface gets truncated after 64kb

2017-06-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1073952 Title: data sent

Re: [Qemu-devel] [PATCH 2/3] exec: simplify address_space_get_iotlb_entry

2017-06-06 Thread Peter Xu
On Wed, Jun 07, 2017 at 09:47:05AM +1000, David Gibson wrote: > On Tue, Jun 06, 2017 at 04:34:30PM +0200, Paolo Bonzini wrote: > > > > > > On 05/06/2017 05:07, Peter Xu wrote: > > > I don't sure whether it'll be a good interface for IOTLB. AFAIU at > > > least for VT-d, the IOMMU translation is

[Qemu-devel] [PULL 1/2] net/rocker: Cleanup the useless return value check

2017-06-06 Thread Jason Wang
From: Mao Zhongyi None of pci_dma_read()'s callers check the return value except rocker. There is no need to check it because it always return 0. So the check work is useless. Remove it entirely. Suggested-by: Markus Armbruster Signed-off-by: Mao

[Qemu-devel] [PULL 2/2] Revert "Change net/socket.c to use socket_*() functions" again

2017-06-06 Thread Jason Wang
From: "Daniel P. Berrange" This reverts commit 883e4f7624e10b98d16d9adaffb8b1795664d899. This code changed net/socket.c from using socket()+connect(), to using socket_connect(). In theory this is great, but in practice this has completely broken the ability to connect the

[Qemu-devel] [PULL 0/2] Net patches

2017-06-06 Thread Jason Wang
The following changes since commit 199e19ee538eb61fd08b1c1ee5aa838ebdcc968e: Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into staging (2017-06-05 15:28:12 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request

Re: [Qemu-devel] [PATCH v2 1/1] qemu/migration: fix the double free problem on from_src_file

2017-06-06 Thread Peter Xu
On Tue, Jun 06, 2017 at 06:42:18PM +0100, Dr. David Alan Gilbert wrote: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 06.06.2017 um 07:24 hat QingFeng Hao geschrieben: > > > In load_snapshot, mis->from_src_file is freed twice, the first free is by > > > qemu_fclose, the second is by

[Qemu-devel] [PATCHv2 7/7] spapr: Rework DRC name handling

2017-06-06 Thread David Gibson
DRC objects have a get_name method which returns the DRC name generated when the DRC is created. Replace that with a fixed spapr_drc_name() function which generates the name on the fly from other information. This means: * We get rid of a method with only one implementation, and only local

[Qemu-devel] [PATCHv2 5/7] spapr: Change DRC attach & detach methods to functions

2017-06-06 Thread David Gibson
DRC objects have attach & detach methods, but there's only one implementation. Although there are some differences in its behaviour for different DRC types, the overall structure is the same, so while we might want different method implementations for some parts, we're unlikely to want them for

[Qemu-devel] [PATCHv2 4/7] spapr: Clean up handling of DR-indicator

2017-06-06 Thread David Gibson
There are 3 types of "indicator" associated with hotplug in the PAPR spec the "allocation state", "isolation state" and "DR-indicator". The first two are intimately tied to the various state transitions associated with hotplug. The DR-indicator, however, is different and simpler. It's basically

[Qemu-devel] [PATCHv2 0/7] spapr: DRC cleanups (part III)

2017-06-06 Thread David Gibson
A third batch of cleanups to the DRC code. This continues to clear away relatively simple cruft, to get a clearer look at the fundamental state handling. Changes since v1: * Some comment updates suggested by Mike Roth * Changed approach to the get_name cleanup, using generated on the fly

[Qemu-devel] [PATCHv2 6/7] spapr: Fold spapr_phb_{add, remove}_pci_device() into their only callers

2017-06-06 Thread David Gibson
Both functions are fairly short, and so are their callers. There's no particular logical distinction between them, so fold them together. Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 63 -- 1 file changed,

Re: [Qemu-devel] [PATCH 0/3] ppc: fix memory leaks

2017-06-06 Thread David Gibson
On Tue, Jun 06, 2017 at 05:22:42PM +0200, Greg Kurz wrote: > Coverity just reported a memory leak introduced by this commit (QEMU 2.9): > > commit df58713396f8b2deb923e39c00b10744c5c63909 > Author: Thomas Huth > Date: Wed Feb 15 10:21:44 2017 +0100 > > hw/ppc/spapr:

[Qemu-devel] [PATCHv2 2/7] spapr: Don't misuse DR-indicator in spapr_recover_pending_dimm_state()

2017-06-06 Thread David Gibson
With some combinations of migration and hotplug we can lost temporary state indicating how many DRCs (guest side hotplug handles) are still connected to a DIMM object in the process of removal. When we hit that situation spapr_recover_pending_dimm_state() is used to scan more extensively and work

Re: [Qemu-devel] [RFC 1/3] spapr: Fold spapr_phb_add_pci_device() into its only caller

2017-06-06 Thread David Gibson
On Tue, Jun 06, 2017 at 04:37:27PM -0500, Michael Roth wrote: > Quoting David Gibson (2017-06-06 08:05:32) > > This function is fairly short, and so is its only caller. There's no > > particular logical distinction between them, so fold them together. > > > > Signed-off-by: David Gibson

Re: [Qemu-devel] [PATCH 2/3] exec: simplify address_space_get_iotlb_entry

2017-06-06 Thread David Gibson
On Tue, Jun 06, 2017 at 04:34:30PM +0200, Paolo Bonzini wrote: > > > On 05/06/2017 05:07, Peter Xu wrote: > > I don't sure whether it'll be a good interface for IOTLB. AFAIU at > > least for VT-d, the IOMMU translation is page aligned which is defined > > by spec, so it makes sense that (again

Re: [Qemu-devel] [PATCH 6/7] spapr: Clean up handling of DR-indicator

2017-06-06 Thread David Gibson
On Tue, Jun 06, 2017 at 04:04:33PM -0500, Michael Roth wrote: > Quoting David Gibson (2017-06-06 03:32:20) > > There are 3 types of "indicator" associated with hotplug in the PAPR spec > > the "allocation state", "isolation state" and "DR-indicator". The first > > two are intimately tied to the

[Qemu-devel] [PATCHv2 3/7] spapr: Clean up RTAS set-indicator

2017-06-06 Thread David Gibson
In theory the RTAS set-indicator call can be used for a number of "indicators" defined by PAPR. In practice the only ones we're ever likely to implement are those used for Dynamic Reconfiguration (i.e. hotplug). Because of this, the current implementation determines the associated DRC object,

[Qemu-devel] [PATCHv2 1/7] spapr: Clean up DR entity sense handling

2017-06-06 Thread David Gibson
DRC classes have an entity_sense method to determine (in a specific PAPR sense) the presence or absence of a device plugged into a DRC. However, we only have one implementation of the method, which explicitly tests for different DRC types. This changes it to instead have different method

Re: [Qemu-devel] [PATCH v2 1/1] qemu/migration: fix the double free problem on from_src_file

2017-06-06 Thread QingFeng Hao
在 2017/6/6 20:49, Kevin Wolf 写道: Am 06.06.2017 um 07:24 hat QingFeng Hao geschrieben: In load_snapshot, mis->from_src_file is freed twice, the first free is by qemu_fclose, the second is by migration_incoming_state_destroy and it causes Illegal instruction exception. The fix is just to remove

Re: [Qemu-devel] [PATCH 4/5] ram: Use MigrationStats for statistics

2017-06-06 Thread Peter Xu
On Tue, Jun 06, 2017 at 07:33:45PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jun 05, 2017 at 01:34:45PM +0100, Dr. David Alan Gilbert wrote: > >> * Juan Quintela (quint...@redhat.com) wrote: > >> > RAM Statistics need to survive migration to make info migrate

Re: [Qemu-devel] [PATCH v2 0/6] Convert to realize and cleanup

2017-06-06 Thread Mao Zhongyi
Hi, Michael On 06/06/2017 11:23 PM, Michael S. Tsirkin wrote: Notes: - Please write a cover letter explaining what this patchset is about - Please add notes about how did you test it - Pls copy everyone on the cover letter too. - Please run a spell checker on comments and commit log Thanks!

Re: [Qemu-devel] [PATCH v3 4/7] net/eepro100: Fix code style

2017-06-06 Thread Mao Zhongyi
Hi, Michael On 06/06/2017 11:31 PM, Michael S. Tsirkin wrote: On Tue, Jun 06, 2017 at 07:26:29PM +0800, Mao Zhongyi wrote: It reports a code style problem(ERROR: "foo * bar" should be "foo *bar") when running checkpatch.pl. So fix it to conform to the coding standards. Cc: jasow...@redhat.com

Re: [Qemu-devel] [PATCH] target/xtensa: handle unknown registers in gdbstub

2017-06-06 Thread Richard Henderson
On 06/03/2017 02:19 AM, Max Filippov wrote: +memset(mem_buf, 0, reg->size); +return reg->size; return 0; Leaving a dead return. r~

[Qemu-devel] [PULL v2 70/70] target/s390x: addressing exceptions are suppressing

2017-06-06 Thread Richard Henderson
From: David Hildenbrand We have to make the address in the old PSW point at the next instruction, as addressing exceptions are suppressing and not nullifying. I assume that there are a lot of other broken cases (as most instructions we care about are suppressing) - all

[Qemu-devel] [PULL v2 69/70] target/s390x: mark ETF2 and ETF2-ENH facilities as available

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-30-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/cpu_models.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Qemu-devel] [PULL v2 67/70] target/s390x: implement STORE PAIR TO QUADWORD

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170604202034.16615-3-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++

[Qemu-devel] [PULL v2 64/70] target/s390x: implement TEST DECIMAL

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-28-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 +

[Qemu-devel] [PULL v2 65/70] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-29-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 9 +

[Qemu-devel] [PULL v2 60/70] target/s390x: implement PACK ASCII

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-24-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 +

[Qemu-devel] [PULL v2 55/70] target/s390x: implement COMPARE LOGICAL LONG

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno As CLCL and CLCLE mostly differ by their operands, use a common do_clcl helper. Another difference is that CLCL is not interruptible. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id:

[Qemu-devel] [PULL v2 59/70] target/s390x: implement MOVE LONG UNICODE

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-23-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 +

[Qemu-devel] [PULL v2 54/70] target/s390x: fix COMPARE LOGICAL LONG EXTENDED

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno There are multiple issues with the COMPARE LOGICAL LONG EXTENDED instruction: - The test between the two operands is inverted, leading to an inversion of the cc values 1 and 2. - The address and length of an operand continue to be decreased after

Re: [Qemu-devel] [PATCH] target/m68k: implement rtd

2017-06-06 Thread Richard Henderson
On 06/05/2017 03:00 AM, Laurent Vivier wrote: Add "Return and Deallocate" (rtd) instruction. RTD #d (SP) -> PC SP + 4 + d -> SP Signed-off-by: Laurent Vivier --- target/m68k/cpu.c | 2 ++ target/m68k/cpu.h | 1 + target/m68k/translate.c | 11

[Qemu-devel] [PULL v2 58/70] target/s390x: implement COMPARE LOGICAL LONG UNICODE

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno For that we need to make program_interrupt available to qemu-user. Fortunately there is almost nothing to change as both kvm_enabled and CONFIG_KVM evaluate to false in that case. Reviewed-by: Richard Henderson Signed-off-by:

[Qemu-devel] [PULL v2 53/70] target/s390x: improve 24-bit and 31-bit lengths read/write

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-17-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 47

Re: [Qemu-devel] [PATCH v4 0/3] target/s390x: implement loads/store quadword

2017-06-06 Thread Richard Henderson
On 06/04/2017 01:20 PM, Aurelien Jarno wrote: This patchset implements the LOAD PAIR FROM QUADWORD and STORE PAIR TO QUADWORD instructions. The corresponding patches have been in my previous patchset and the pull request from Richard, but they failed to build on a host without atomic128 support.

[Qemu-devel] [PULL v2 57/70] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno As MVCL and MVCLE only differ by their operands, use a common do_mvcl helper. Optimize it calling fast_memmove and fast_memset. Correctly write back addresses. Check that r1 and r2/r3 registers are even. Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-06 Thread Wei Wang
On 06/05/2017 11:38 PM, Michael S. Tsirkin wrote: On Mon, Jun 05, 2017 at 04:57:29PM +0800, Wei Wang wrote: This patch enables the virtio-net tx queue size to be configurable between 256 and 1024 by the user. The queue size specified by the user should be power of 2. If "tx_queue_size" is not

[Qemu-devel] [PULL v2 45/70] target/s390x: implement PACK

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-7-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 +

[Qemu-devel] [PULL v2 68/70] target/s390x: check alignment in CDSG in the !CONFIG_ATOMIC128 case

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno The CDSG instruction requires a 16-byte alignement, as expressed in the MO_ALIGN_16 passed to helper_atomic_cmpxchgo_be_mmu. In the non parallel case, use check_alignment to enforce this. Signed-off-by: Aurelien Jarno Message-Id:

[Qemu-devel] [PULL v2 52/70] target/s390x: improve 24-bit and 31-bit addresses write

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-16-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 37

[Qemu-devel] [PULL v2 42/70] target/s390x: implement local-TLB-clearing in IPTE

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno And at the same time make IPTE SMP aware. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-4-aurel...@aurel32.net>

[Qemu-devel] [PULL v2 51/70] target/s390x: improve 24-bit and 31-bit addresses read

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Improve fix_address to also handle the 24-bit mode. Rename fix_address to wrap_address to better explain what is changed. Replace the calls to get_address with x2 = 0 and b2 = 0 by call to wrap_address, leading to the removal of this function. Rename

[Qemu-devel] [PULL v2 49/70] target/s390x: implement MOVE WITH OFFSET

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-13-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 +

[Qemu-devel] [PULL v2 66/70] target/s390x: implement LOAD PAIR FROM QUADWORD

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170604202034.16615-2-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++

[Qemu-devel] [PULL v2 43/70] target/s390x: implement TEST AND SET

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-5-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 3 +++

[Qemu-devel] [PULL v2 50/70] target/s390x: implement MOVE ZONES

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-14-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 +

[Qemu-devel] [PULL v2 63/70] target/s390x: implement UNPACK UNICODE

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-27-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 +

[Qemu-devel] [PULL v2 46/70] target/s390x: implement COMPARE AND SIGNAL

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno These functions differ from COMPARE by generating an exception for a QNaN input. Use the non quiet version of floatXX_compare. Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-10-aurel...@aurel32.net>

[Qemu-devel] [PULL v2 48/70] target/s390x: implement MOVE NUMERICS

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-12-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 +

[Qemu-devel] [PULL v2 41/70] target/s390x: remove some Linux assumptions from IPTE

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-3-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/cpu.h| 2 ++ target/s390x/mem_helper.c | 17 ++---

[Qemu-devel] [PULL v2 62/70] target/s390x: implement UNPACK ASCII

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-26-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 +

[Qemu-devel] [PULL v2 39/70] target/s390x/cpu_models: Allow some additional feature bits for the "qemu" CPU

2017-06-06 Thread Richard Henderson
From: Thomas Huth Currently we only present the plain z900 feature bits to the guest, but QEMU already emulates some additional features (but not all of the next CPU generation, so we can not use the next CPU level as default yet). Since newer Linux kernels are checking the

[Qemu-devel] [PULL v2 44/70] target/s390x: implement TEST ADDRESSING MODE

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-6-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 3 +++

[Qemu-devel] [PULL v2 36/70] target/s390x: End the TB after EXECUTE

2017-06-06 Thread Richard Henderson
This split will be required for implementing EXECUTE properly. Do this now as a separate step to aid comparison of before and after TB listings. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 54

[Qemu-devel] [PULL v2 38/70] target/s390x: Re-implement a few EXECUTE target insns directly

2017-06-06 Thread Richard Henderson
While the previous patch is required for proper conformance, the vast majority of target insns are MVC and XC for implementing memmove and memset respectively. The next most common are CLC, TR, and SVC. Implementing these (and a few others for which we already have an implementation) directly is

[Qemu-devel] [PULL v2 61/70] target/s390x: implement PACK UNICODE

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Use a common helper with PACK ASCII as the differences are limited to the stride of the source operand. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id:

[Qemu-devel] [PULL v2 33/70] target/s390x: Use atomic operations for COMPARE SWAP PURGE

2017-06-06 Thread Richard Henderson
Also provide the cross-cpu tlb flushing required by the PoO. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x/insn-data.def | 2 +- target/s390x/mem_helper.c | 32

[Qemu-devel] [PULL v2 56/70] target/s390x: fix adj_len_to_page

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno adj_len_to_page doesn't return the correct result when the address is already page aligned and the length is bigger than a page. Fix that. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno

[Qemu-devel] [PULL v2 37/70] target/s390x: Implement EXECUTE via new TranslationBlock

2017-06-06 Thread Richard Henderson
Previously, helper_ex would construct the insn and then implement the insn via direct calls other helpers. This was sufficient to boot Linux but that is all. It is easy enough to go the whole nine yards by stashing state for EXECUTE within the cpu, and then rely on a new TB to be created that

[Qemu-devel] [PULL v2 35/70] target/s390x: Save current ilen during translation

2017-06-06 Thread Richard Henderson
Use this saved value instead of recomputing from next_pc difference. Reviewed-by: David Hildenbrand Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/translate.c | 8 +--- 1 file changed, 5

[Qemu-devel] [PULL v2 31/70] target/s390x: Fix some helper_ex problems

2017-06-06 Thread Richard Henderson
(1) The OR of the low bits or R1 into INSN were not being done consistently; it was forgotten along all but the SVC path. (2) The setting of ILEN was wrong on SVC path for EXRL. (3) The data load for ICM read too much. Fix these by consolidating data load at the beginning, using get_ilen to

[Qemu-devel] [PULL v2 32/70] target/s390x: Fix EXECUTE with R1==0

2017-06-06 Thread Richard Henderson
The PoO specifies that when R1==0, no ORing into the insn loaded from storage takes place. Load a zero for this case. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 4 ++-- target/s390x/translate.c | 14

[Qemu-devel] [PULL v2 47/70] target/s390x: implement MOVE INVERSE

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-11-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 +

[Qemu-devel] [PULL v2 29/70] target/s390x: Use unwind data for helper_lra

2017-06-06 Thread Richard Henderson
Fix saving exception_index around mmu_translate; eliminate a dead store. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 6 +++--- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 4

[Qemu-devel] [PULL v2 30/70] target/s390x: Use unwind data for helper_mvcs/mvcp

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 8 ++-- target/s390x/translate.c | 2 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL v2 28/70] target/s390x: Use unwind data for helper_tprot

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 1 - target/s390x/translate.c | 1 - 2 files changed, 2 deletions(-) diff --git a/target/s390x/mem_helper.c

[Qemu-devel] [PULL v2 40/70] target/s390x: remove dead code in translate.c

2017-06-06 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-2-aurel...@aurel32.net> Signed-off-by: Richard Henderson

[Qemu-devel] [PULL v2 27/70] target/s390x: Use unwind data for helper_testblock

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 +++ target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL v2 18/70] target/s390x: Use unwind data for helper_clcle

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 6 +++--- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL v2 23/70] target/s390x: Use unwind data for helper_trt

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 28 target/s390x/translate.c | 1 - 2 files changed, 16 insertions(+), 13 deletions(-)

[Qemu-devel] [PULL v2 34/70] target/s390x: Implement CSPG

2017-06-06 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 1 + target/s390x/translate.c | 1 + 2 files changed, 2 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index

[Qemu-devel] [PULL v2 26/70] target/s390x: Use unwind data for helper_stctl

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 ++ target/s390x/translate.c | 2 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PULL v2 17/70] target/s390x: Use unwind data for helper_mvcle

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 7 --- target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL v2 25/70] target/s390x: Use unwind data for helper_lctl

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PULL v2 22/70] target/s390x: Use unwind data for helper_tre

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 15 --- target/s390x/translate.c | 1 - 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PULL v2 21/70] target/s390x: Use unwind data for helper_tr

2017-06-06 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 25 +++-- target/s390x/translate.c | 1 - 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/target/s390x/mem_helper.c

[Qemu-devel] [PULL v2 07/70] target/s390x: Use unwind data for helper_mvc

2017-06-06 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 30 ++ target/s390x/translate.c | 1 - 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/target/s390x/mem_helper.c

[Qemu-devel] [PULL v2 24/70] target/s390x: Use unwind data for helper_lctlg

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 8 target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PULL v2 19/70] target/s390x: Use unwind data for helper_cksm

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 11 ++- target/s390x/translate.c | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PULL v2 20/70] target/s390x: Use unwind data for helper_unpk

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PULL v2 13/70] target/s390x: Use unwind data for helper_mvst

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 5 +++-- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL v2 15/70] target/s390x: Use unwind data for helper_stam

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL v2 08/70] target/s390x: Use unwind data for helper_clc

2017-06-06 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 29 + target/s390x/translate.c | 1 - 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/target/s390x/mem_helper.c

[Qemu-devel] [PULL v2 16/70] target/s390x: Use unwind data for helper_mvcl

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 7 --- target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL v2 14/70] target/s390x: Use unwind data for helper_lam

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL v2 10/70] target/s390x: Use unwind data for helper_srst

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL v2 06/70] target/s390x: Use unwind data for helper_xc

2017-06-06 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 44 target/s390x/translate.c | 1 - 2 files changed, 24 insertions(+), 21 deletions(-) diff --git

[Qemu-devel] [PULL v2 11/70] target/s390x: Use unwind data for helper_clst

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 5 +++-- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL v2 09/70] target/s390x: Use unwind data for helper_clm

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 11 ++- target/s390x/translate.c | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PULL v2 12/70] target/s390x: Use unwind data for helper_mvpg

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 3 +-- 3 files changed, 7 insertions(+), 7

  1   2   3   4   5   >