On Sat, Jun 10, 2017 at 09:59:19 -0700, Richard Henderson wrote:
> On 06/10/2017 01:51 AM, Alex Bennée wrote:
> >I would agree with Emilio that we revert but I can't quite shake the
> >feeling we are missing an underlying problem. Would just skipping the
> >htable lookup (but keeping the tb_jmp_cac
On 06/10/2017 02:04 AM, Zhengui Li wrote:
> Avoid empty pointer access if the bs is NULL.
>
> Signed-off-by: Zhengui Li
> ---
> block/io.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
NACK; this is fixing a symptom, not the problem. If you have a coredump
due to a bad call
On Sat, Jun 10, 2017 at 06:28:42PM -0700, no-re...@patchew.org wrote:
Hi,
/tmp/qemu-test/src/tests/test-throttle.c:144: error: static declaration of
‘read_timer_cb’ follows non-static declaration
/tmp/qemu-test/src/include/block/throttle-groups.h:50: note: previous
declaration of ‘read_timer
On Sat, Jun 10, 2017 at 03:04:10PM +0800, Zhengui Li wrote:
Avoid empty pointer access if the bs is NULL.
Looks like most (if not all) of the places these are called dereference
bs anyway. Can it ever be NULL? Perhaps a check for each of those case
(if any) would be a better idea.
Signed-o
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20170611011427.6713-1-el13...@mail.ntua.gr
Subject: [Qemu-devel] [PATCH RFC v2 0/2] IO throttling blo
block/throttle.c uses existing I/O throttle infrastructure inside a
block filter driver. I/O operations are intercepted in the filter's
read/write coroutines, and referred to block/throttle-groups.c
The driver can be used with the command
-drive driver=throttle,file.filename=foo.qcow2,iops-total=.
block: move ThrottleGroup membership to ThrottleGroupMember
block: add throttle block filter driver
block/Makefile.objs | 1 +
block/block-backend.c | 75 +
block/qapi.c| 8 +-
block/throttle-groups.c | 315 +++
This commit gathers ThrottleGroup membership details from BlockBackendPublic
into ThrottleGroupMember and refactors existing code to use the structure.
Signed-off-by: Manos Pitsidianakis
---
block/block-backend.c | 75 ++
block/qapi.c| 8 +-
block/throttl
remove some copy/paste leftover, code seems sane.
while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img:
Trace 0x7fa1904b0890 [0: ffc00036cd04]
IN:
0xffc00036cd24: 5ac00694 rev16 w20, w20
OP:
ffc00036cd24
Hi Mark,
Is it possible to reorder the 3rd patch (FW_CFG_ID) first or 2nd in the
series? Mostly for cosmetic :)
On 06/10/2017 09:30 AM, Mark Cave-Ayland wrote:
As part of some ongoing sun4u work, I need to be able to wire the fw_cfg
IO interface to a separate IO space by instantiating the qde
On 06/10/2017 09:30 AM, Mark Cave-Ayland wrote:
The dma_enabled property enables us to set the FW_CFG_ID version
accordingly.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
---
hw/nvram/fw_cfg.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
On 06/10/2017 09:30 AM, Mark Cave-Ayland wrote:
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
---
hw/nvram/fw_cfg.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 316fca9..144e0c6 10064
Hi Mark,
I'm not sure having this patch split from the previous (2/3) really
helps bisecting, I'd rather squash them altogether.
Either way:
Reviewed-by: Philippe Mathieu-Daudé
On 06/10/2017 10:00 AM, Mark Cave-Ayland wrote:
To allow future changes to the sun4u PCI topology.
Signed-off-by
On 06/10/2017 10:00 AM, Mark Cave-Ayland wrote:
To allow future changes to the sun4u PCI topology.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
---
hw/sparc64/sun4u.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/sparc64/sun4u.c
Hi Mark,
On 06/10/2017 10:00 AM, Mark Cave-Ayland wrote:
Signed-off-by: Mark Cave-Ayland
---
hw/sparc64/sun4u.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index 69f565d..98ee6f5 100644
--- a/hw/sparc64/sun4u.c
+++ b/h
On 06/10/2017 09:30 AM, Mark Cave-Ayland wrote:
This allows the device to be instantiated externally.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
---
hw/nvram/fw_cfg.c |8
include/hw/nvram/fw_cfg.h |8
2 files changed, 8 insertions
On 06/10/2017 01:51 AM, Alex Bennée wrote:
Richard Henderson writes:
On 06/09/2017 10:01 AM, Alex Bennée wrote:
THIS IS A DEBUG PATCH DO NOT MERGE
I include all the comments to show my working. I was trying to
isolate which instructions cause the problem. It turns out it is the
RET instruct
On 06/01/2017 04:29 AM, Daniel P. Berrange wrote:
> This is a followup to:
>
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg05659.html
> v2: https://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg04706.html
>
> This series aims to fix a lot of bugs related to handling
On Fri, 2017-06-02 at 13:15 +1000, David Gibson wrote:
> This is a rebased and revised version of my patches revising CPU
> compatiblity mode handling on ppc, last posted in November. Since
> then, many of the patches have already been merged (some for 2.9, some
> since). This is what's left.
I'
On 10.06.2017 17:15, Markus Armbruster wrote:
> Kamil Rytarowski writes:
>
>> On 06.06.2017 16:56, Kamil Rytarowski wrote:
>>> On 06.06.2017 16:34, Peter Maydell wrote:
On 6 June 2017 at 14:38, Kamil Rytarowski wrote:
> I've linked qemu with the original patch and:
> ./configure --d
Kamil Rytarowski writes:
> On 06.06.2017 16:56, Kamil Rytarowski wrote:
>> On 06.06.2017 16:34, Peter Maydell wrote:
>>> On 6 June 2017 at 14:38, Kamil Rytarowski wrote:
I've linked qemu with the original patch and:
./configure --disable-linux-user --disable-system --static
I
Hello Qemu-devel,
Recently I'm trying to study vm memory allocation on qemu-kvm environment.
I found some interesting here:
I have create a 8GB(8388608 k) memory guest using Centos 7. but when I using
dmesg to show the init memory,
it was 9437184 k,around 9216MB. I would like to know the gap?
I
On 06.06.2017 16:56, Kamil Rytarowski wrote:
> On 06.06.2017 16:34, Peter Maydell wrote:
>> On 6 June 2017 at 14:38, Kamil Rytarowski wrote:
>>> I've linked qemu with the original patch and:
>>> ./configure --disable-linux-user --disable-system --static
>>>
>>> I got some warnings, I think they ar
On 10/06/17 14:27, no-re...@patchew.org wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
Well given that it's dependent upon the fw_cfg patchset I posted
earlier, it's probably going to fail on all hosts :)
Is there a way to express patch dependencies
To allow future changes to the sun4u PCI topology.
Signed-off-by: Mark Cave-Ayland
---
hw/sparc64/sun4u.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index 19e64be..bf738f8 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
The sun4u ebus is currently attached directly to the PCI host bridge meaning
some access is split between the ebus (ISA) IO space and system IO space. This
patchset moves the remaining fw_cfg/NVRAM devices into the ebus IO space in
preparation for moving the ebus device behind a PCI-PCI bridge.
No
To allow future changes to the sun4u PCI topology.
Signed-off-by: Mark Cave-Ayland
---
hw/sparc64/sun4u.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index 98ee6f5..19e64be 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc
Signed-off-by: Mark Cave-Ayland
---
hw/sparc64/sun4u.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index 69f565d..98ee6f5 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
@@ -512,7 +512,15 @@ static void sun4uv_in
And rename to fw_cfg_common_realize() which better describes its role.
Signed-off-by: Mark Cave-Ayland
---
hw/nvram/fw_cfg.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index f7b78a9..87b4392 100644
--- a/hw/nvram/fw_cfg.c
The dma_enabled property enables us to set the FW_CFG_ID version
accordingly.
Signed-off-by: Mark Cave-Ayland
---
hw/nvram/fw_cfg.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 1313bfd..f7b78a9 100644
--- a/hw/
Signed-off-by: Mark Cave-Ayland
---
hw/nvram/fw_cfg.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 144e0c6..1313bfd 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -919,8 +919,6 @@ static void fw_cfg_init1(Device
Signed-off-by: Mark Cave-Ayland
---
hw/nvram/fw_cfg.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 316fca9..144e0c6 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -1017,6 +1017,15 @@ FWCfgState *fw_cfg
This allows the device to be instantiated externally.
Signed-off-by: Mark Cave-Ayland
---
hw/nvram/fw_cfg.c |8
include/hw/nvram/fw_cfg.h |8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 4159316..b77d
This brings the function in line with fw_cfg_mem_realize(), deferring the
actual mapping until outside of the realize function.
Signed-off-by: Mark Cave-Ayland
---
hw/nvram/fw_cfg.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cf
As part of some ongoing sun4u work, I need to be able to wire the fw_cfg
IO interface to a separate IO space by instantiating the qdev device instead
of calling fw_cfg_init_io(). This patchset brings FW_CFG_IO in line with
FW_CFG_MEM and tidies up the realize methods accordingly.
Signed-off-by: Ma
Avoid empty pointer access if the bs is NULL.
Signed-off-by: Zhengui Li
---
block/io.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/block/io.c b/block/io.c
index ed31810..b12d7cf 100644
--- a/block/io.c
+++ b/block/io.c
@@ -492,7 +492,9 @@ static bool tracked_re
Hello
thanks for your answer
Do i code in kernel space for writing this API?
Please give me more guide about what should i do to write this API.
thanks a lot
On Thu, May 25, 2017 at 5:50 PM, Xiao Guangrong
wrote:
>
> No API directly supports your case, but you can do it in KVM by using
> page-tr
Richard Henderson writes:
> On 06/09/2017 10:01 AM, Alex Bennée wrote:
>> THIS IS A DEBUG PATCH DO NOT MERGE
>>
>> I include all the comments to show my working. I was trying to
>> isolate which instructions cause the problem. It turns out it is the
>> RET instruction. I don't understand why bec
38 matches
Mail list logo
