Re: [Qemu-devel] [PATCH] util: remove the obsolete non-blocking connect

2017-06-15 Thread Mao Zhongyi
On 06/16/2017 08:21 AM, Fam Zheng wrote: On Thu, 06/15 11:08, Mao Zhongyi wrote: From: Cao jin The non-blocking connect mechanism is obsolete, and it doesn't work well in inet connection, because it will call getaddrinfo first and getaddrinfo will blocks on DNS

[Qemu-devel] [PATCH v2] target/s390x: Enforce instruction features

2017-06-15 Thread Richard Henderson
Introduce a synthetic feature (type MISC) to handle disabling of the enforcing of features at translation time. Signed-off-by: Richard Henderson --- target/s390x/cpu_features.c | 4 +++- target/s390x/cpu_features_def.h | 1 + target/s390x/cpu_models.c | 5 +

Re: [Qemu-devel] [PATCH 0/6] spapr: DRC cleanups (part IV)

2017-06-15 Thread David Gibson
On Thu, Jun 15, 2017 at 07:10:55PM +0200, Laurent Vivier wrote: > On 08/06/2017 07:09, David Gibson wrote: > > This fourth isntallment of cleanups to the DRC code introduces the > > first changes to the fundamental state handling. We change the > > initial states in the reset code and attach code

Re: [Qemu-devel] [PATCH 1/5] virtio-pci: use ioeventfd even when KVM is disabled

2017-06-15 Thread Michael S. Tsirkin
On Thu, Jun 15, 2017 at 05:38:09PM +0100, Stefan Hajnoczi wrote: > Old kvm.ko versions only supported a tiny number of ioeventfds so > virtio-pci avoids ioeventfds when kvm_has_many_ioeventfds() returns 0. > > Do not check kvm_has_many_ioeventfds() when KVM is disabled since it > always returns

Re: [Qemu-devel] [PATCH] q35/mch: implement extended TSEG sizes

2017-06-15 Thread Michael S. Tsirkin
On Thu, Jun 15, 2017 at 09:07:45AM +0200, Gerd Hoffmann wrote: > Hi, > > > To be specific, what I meant is a bit that tells guest that a > > config space register is available, and lets host find out > > that guest is going to use it. > > > > This to ensure full forward and backward

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-15 Thread Michael S. Tsirkin
On Thu, Jun 15, 2017 at 02:52:01PM +0800, Wei Wang wrote: > On 06/15/2017 12:16 PM, Jason Wang wrote: > > > > > > On 2017年06月14日 23:22, Michael S. Tsirkin wrote: > > > On Wed, Jun 14, 2017 at 07:26:54PM +0800, Jason Wang wrote: > > > > > > > > On 2017年06月13日 18:46, Jason Wang wrote: > > > > >

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS

2017-06-15 Thread Michael S. Tsirkin
On Thu, Jun 15, 2017 at 04:10:17PM +0800, Wei Wang wrote: > On 06/14/2017 01:56 AM, Michael S. Tsirkin wrote: > > On Fri, Jun 09, 2017 at 06:41:38PM +0800, Wei Wang wrote: > > > Add a new feature, VIRTIO_BALLOON_F_PAGE_CHUNKS, which enables > > > the transfer of the ballooned (i.e.

Re: [Qemu-devel] [PATCH v2 2/5] target/alpha: Use tcg_gen_lookup_and_goto_ptr

2017-06-15 Thread Richard Henderson
On 06/15/2017 02:57 PM, Philippe Mathieu-Daudé wrote: Peter cleaned that and improved the doc on ARM: https://patchwork.kernel.org/patch/9690993/ (commit b636649f5a2e108413dd171edaf320f781f57942) $ git grep -- singlestep_enabled target|wc -l 113 still confusing... This is two of the three

Re: [Qemu-devel] [PATCH 1/2] gen-icount: add missing inline to gen_tb_end

2017-06-15 Thread Richard Henderson
On 06/15/2017 04:04 PM, Emilio G. Cota wrote: Signed-off-by: Emilio G. Cota --- include/exec/gen-icount.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 2/2] gen-icount: pass cpu_env as a parameter to gen_* inlines

2017-06-15 Thread Richard Henderson
On 06/15/2017 04:04 PM, Emilio G. Cota wrote: We are relying on cpu_env being defined as a global, yet most targets (i.e. all but arm/a64) have it defined as a local variable. Luckily all of them use the same "cpu_env" name, but really compilation shouldn't break if the name of that local

Re: [Qemu-devel] [PATCH V6 02/10] net/filter-mirror.c: Make filter mirror support vnet support.

2017-06-15 Thread Jason Wang
On 2017年06月15日 16:10, Zhang Chen wrote: On 06/15/2017 12:31 PM, Jason Wang wrote: On 2017年06月14日 16:04, Zhang Chen wrote: On 06/13/2017 05:14 PM, Jason Wang wrote: On 2017年06月12日 17:27, Zhang Chen wrote: +if (nf->direction == NET_FILTER_DIRECTION_RX || +

Re: [Qemu-devel] [FIX PATCH] spapr: prevent QEMU crash when CPU realization fails

2017-06-15 Thread Bharata B Rao
On Thu, Jun 15, 2017 at 09:32:38AM +0200, Greg Kurz wrote: > On Thu, 15 Jun 2017 08:22:44 +0530 > Bharata B Rao wrote: > > > ICPState objects were being allocated before CPU thread realization. > > However commit 9ed656631d73 (xics: setup cpu at realize time) reversed

[Qemu-devel] [PULL v4 00/23] Docker and block patches

2017-06-15 Thread Fam Zheng
The following changes since commit edf8bc98424d62035d5e4c0f39542722d72d7979: Merge remote-tracking branch 'remotes/rth/tags/pull-s390-20170613' into staging (2017-06-15 13:45:15 +0100) are available in the git repository at: git://github.com/famz/qemu.git tags/docker-and-block-pull-request

[Qemu-devel] [PULL v4 18/23] block: introduce dirty_bitmap_mutex

2017-06-15 Thread Fam Zheng
From: Paolo Bonzini It protects only the list of dirty bitmaps; in the next patch we will also protect their content. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id:

Re: [Qemu-devel] [PATCH] virtio-blk: trace vdev so devices can be distinguished

2017-06-15 Thread Fam Zheng
On Wed, 06/14 10:29, Stefan Hajnoczi wrote: > It is hard to analyze trace logs with multiple virtio-blk devices > because none of the trace events include the VirtIODevice *vdev. > > This patch adds vdev so it's clear which device a request is associated > with. > > I considered using

Re: [Qemu-devel] [PATCH] util: remove the obsolete non-blocking connect

2017-06-15 Thread Fam Zheng
On Thu, 06/15 11:08, Mao Zhongyi wrote: > From: Cao jin > > The non-blocking connect mechanism is obsolete, and it doesn't > work well in inet connection, because it will call getaddrinfo > first and getaddrinfo will blocks on DNS lookups. Since commit > e65c67e4 &

Re: [Qemu-devel] [PATCH v6 6/6] target: [tcg, arm] Port to generic translation framework

2017-06-15 Thread Emilio G. Cota
On Mon, Jun 12, 2017 at 17:54:30 +0300, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > target/arm/translate-a64.c | 346 ++--- > target/arm/translate.c | 720 > ++-- > target/arm/translate.h |

Re: [Qemu-devel] [PULL v3 18/23] block: introduce dirty_bitmap_mutex

2017-06-15 Thread Fam Zheng
On Thu, 06/08 19:56, Fam Zheng wrote: > From: Paolo Bonzini > > It protects only the list of dirty bitmaps; in the next patch we will > also protect their content. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini >

Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework

2017-06-15 Thread Emilio G. Cota
On Thu, Jun 15, 2017 at 18:19:11 -0400, Emilio G. Cota wrote: > (snip) > > +/** > > + * DisasContextBase: > > + * @tb: Translation block for this disassembly. > > + * @pc_first: Address of first guest instruction in this TB. > > + * @pc_next: Address of next guest instruction in this TB (current

[Qemu-devel] [PATCH 1/2] gen-icount: add missing inline to gen_tb_end

2017-06-15 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- include/exec/gen-icount.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h index 62d462e..547c979 100644 --- a/include/exec/gen-icount.h +++ b/include/exec/gen-icount.h @@

[Qemu-devel] [PATCH 2/2] gen-icount: pass cpu_env as a parameter to gen_* inlines

2017-06-15 Thread Emilio G. Cota
We are relying on cpu_env being defined as a global, yet most targets (i.e. all but arm/a64) have it defined as a local variable. Luckily all of them use the same "cpu_env" name, but really compilation shouldn't break if the name of that local variable changed. This patch fixes it by explicitly

Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework

2017-06-15 Thread Emilio G. Cota
Some minor nits below. On Mon, Jun 12, 2017 at 17:54:09 +0300, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > +/** > + * BreakpointHitType: > + * @BH_MISS: No hit > + * @BH_HIT_INSN: Hit, but continue translating instruction > + * @BH_HIT_TB: Hit, stop

[Qemu-devel] [PATCH] translator mega-patch

2017-06-15 Thread Emilio G. Cota
On Mon, Jun 12, 2017 at 17:54:09 +0300, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > include/exec/gen-icount.h |2 > include/exec/translate-all_template.h | 73 > include/qom/cpu.h | 22 >

Re: [Qemu-devel] [PATCH v2 2/5] target/alpha: Use tcg_gen_lookup_and_goto_ptr

2017-06-15 Thread Philippe Mathieu-Daudé
Peter cleaned that and improved the doc on ARM: https://patchwork.kernel.org/patch/9690993/ (commit b636649f5a2e108413dd171edaf320f781f57942) $ git grep -- singlestep_enabled target|wc -l 113 still confusing... On Thu, Jun 15, 2017 at 5:55 PM, Richard Henderson wrote: > On

Re: [Qemu-devel] [PATCH v2 3/5] target/mips: Exit after enabling interrupts

2017-06-15 Thread Richard Henderson
On 06/15/2017 02:19 PM, Aurelien Jarno wrote: While the above looks correct, it's not complete. It only fixes the microMIPS EI instruction. The MIPS one also has to be fixed. For what I understood, anything that can change the result of cpu_mips_hw_interrupts_enabled has to stop the

Re: [Qemu-devel] [PATCH 5/5] target/s390x: mark CSST, CSST2, FPSEH facilities as available

2017-06-15 Thread Aurelien Jarno
On 2017-06-15 14:10, Richard Henderson wrote: > On 06/15/2017 01:49 PM, Aurelien Jarno wrote: > > > +S390_FEAT_FLOATING_POINT_SUPPPORT_ENH, > > > > Theoretically the floating-point-support-enhancement facilities include > > the DFP rounding facility. Given We don't implement the DFP

Re: [Qemu-devel] [PATCH v2 3/5] target/mips: Exit after enabling interrupts

2017-06-15 Thread Aurelien Jarno
On 2017-06-14 12:48, Richard Henderson wrote: > From: Paolo Bonzini > > Exit to cpu loop so we reevaluate cpu_mips_hw_interrupts. > > Cc: Aurelien Jarno > Cc: Yongbok Kim > Signed-off-by: Richard Henderson >

Re: [Qemu-devel] [PATCH 5/5] target/s390x: mark CSST, CSST2, FPSEH facilities as available

2017-06-15 Thread Richard Henderson
On 06/15/2017 01:49 PM, Aurelien Jarno wrote: +S390_FEAT_FLOATING_POINT_SUPPPORT_ENH, Theoretically the floating-point-support-enhancement facilities include the DFP rounding facility. Given We don't implement the DFP facility I guess this can be ignored. We *do* implement the one

Re: [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features

2017-06-15 Thread Aurelien Jarno
On 2017-06-15 15:10, David Hildenbrand wrote: > > >> A "sane" guest (e.g. Linux) will only use an instruction if the > >> corresponding stfl(e) bit is set. So in my opinion, this should be just > >> fine. If the bit is not set currently, the guest will not use it == dead > >> code. > > > > Not

Re: [Qemu-devel] [PATCH v2 2/5] target/alpha: Use tcg_gen_lookup_and_goto_ptr

2017-06-15 Thread Richard Henderson
On 06/15/2017 01:48 AM, Alex Bennée wrote: Richard Henderson writes: Signed-off-by: Richard Henderson --- target/alpha/translate.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/target/alpha/translate.c

Re: [Qemu-devel] [PATCH 5/5] target/s390x: mark CSST, CSST2, FPSEH facilities as available

2017-06-15 Thread Aurelien Jarno
On 2017-06-14 22:53, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/cpu_models.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index c3a4ce6..703feca 100644 > ---

[Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-15 Thread Richard Henderson
There are no uses in a Linux system with which to test, but it Looks Right by my reading of the PoO. Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 + target/s390x/mem_helper.c | 189

[Qemu-devel] [PATCH] nbd: fix NBD over TLS

2017-06-15 Thread Paolo Bonzini
When attaching the NBD QIOChannel to an AioContext, the TLS channel should be used, not the underlying socket channel. This is because, trivially, the TLS channel will be the one that we read/write to and thus the one that will get the qio_channel_yield() call. Fixes:

[Qemu-devel] [PATCH] nbd: fix NBD over TLS

2017-06-15 Thread Paolo Bonzini
When attaching the NBD QIOChannel to an AioContext, the TLS channel should be used, not the underlying socket channel. This is because, trivially, the TLS channel will be the one that we read/write to and thus the one that will get the qio_channel_yield() call. Fixes:

Re: [Qemu-devel] QEMU issues on SPARC hosts due to more-than-page-alignment requirement for MAP_SHARED|MAP_FIXED...

2017-06-15 Thread Laszlo Ersek
On 06/15/17 20:17, Peter Maydell wrote: > It turns out that SPARC hosts impose a requirement that > if you mmap MAP_SHARED|MAP_FIXED then the address must be > aligned to SHMLBA alignment, which for SPARC is 16K and > larger than the 8K page size: >

Re: [Qemu-devel] DragonFly BSD support

2017-06-15 Thread Peter Maydell
On 15 June 2017 at 19:09, John Snow wrote: > Peter, do we have a wiki page detailing what it takes to get an > operating system considered "supported" with hints and tips for > prospective maintainers? We don't, but as you say there aren't that many cases where it will come up

[Qemu-devel] QEMU issues on SPARC hosts due to more-than-page-alignment requirement for MAP_SHARED|MAP_FIXED...

2017-06-15 Thread Peter Maydell
It turns out that SPARC hosts impose a requirement that if you mmap MAP_SHARED|MAP_FIXED then the address must be aligned to SHMLBA alignment, which for SPARC is 16K and larger than the 8K page size: http://lxr.linux.no/#linux+v4.10.1/arch/sparc/kernel/sys_sparc_64.c#L158 QEMU doesn't really

Re: [Qemu-devel] DragonFly BSD support

2017-06-15 Thread John Snow
On 06/15/2017 06:15 AM, Peter Maydell wrote: > On 14 June 2017 at 11:55, Antonio Huete Jiménez > wrote: >> According to 2.9 changelog page, DragonFly BSD will be listed as unsupported >> with the possibility of dropping support completely in the future: >> >>

Re: [Qemu-devel] [RFC PATCH v6 0/6] translate: [tcg] Generic translation framework

2017-06-15 Thread Emilio G. Cota
On Mon, Jun 12, 2017 at 17:53:47 +0300, Lluís Vilanova wrote: > This series proposes a generic (target-agnostic) instruction translation > framework. > > It basically provides a generic main loop for instruction disassembly, which > calls target-specific functions when necessary. This

[Qemu-devel] [Bug 1694998] Re: PPC: msgsnd instruction leads to assertion

2017-06-15 Thread Kurban Mallachiev
Yes, Thomas, this patch fixes the issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1694998 Title: PPC: msgsnd instruction leads to assertion Status in QEMU: New Bug description: I tried

Re: [Qemu-devel] [PATCH 0/6] spapr: DRC cleanups (part IV)

2017-06-15 Thread Laurent Vivier
On 08/06/2017 07:09, David Gibson wrote: > This fourth isntallment of cleanups to the DRC code introduces the > first changes to the fundamental state handling. We change the > initial states in the reset code and attach code for PCI devices, and > are able to remove the 'signalled' state

Re: [Qemu-devel] [PATCH] migration: fix incorrect enable return path

2017-06-15 Thread Laurent Vivier
On 14/06/2017 09:55, Peter Xu wrote: > 0425dc9 is actually v1 of that patch, but it was accidentally > merged (while there was a v2). That will cause problem when we try to > migrate to some old QEMUs when return path is not really there. Let's > fix it, then squashing this patch with 0425dc9 will

Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!)

2017-06-15 Thread Stefan Hajnoczi
On Thu, Jun 15, 2017 at 5:38 PM, Stefan Hajnoczi wrote: > This series extends qemu-iotests 068 to also run with iothread enabled. I forgot to mention: this series is based on Kevin's 'block' branch: git://repo.or.cz/qemu/kevin.git block This is necessary in order to get

[Qemu-devel] [PATCH 5/5] qemu-iotests: 068: test iothread mode

2017-06-15 Thread Stefan Hajnoczi
Perform the savevm/loadvm test with both iothread on and off. This covers the recently found savevm/loadvm hang when iothread is enabled. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/068 | 23 ++- tests/qemu-iotests/068.out | 11 ++-

[Qemu-devel] [PATCH 4/5] qemu-iotests: 068: use -drive/-device instead of -hda

2017-06-15 Thread Stefan Hajnoczi
The legacy -hda option does not support -drive/-device parameters. They will be required by the next patch that extends this test case. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/068 | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 1/5] virtio-pci: use ioeventfd even when KVM is disabled

2017-06-15 Thread Stefan Hajnoczi
Old kvm.ko versions only supported a tiny number of ioeventfds so virtio-pci avoids ioeventfds when kvm_has_many_ioeventfds() returns 0. Do not check kvm_has_many_ioeventfds() when KVM is disabled since it always returns 0. Since commit 8c56c1a592b5092d91da8d8943c1d6462a6f ("memory: emulate

[Qemu-devel] [PATCH 2/5] migration: hold AioContext lock for loadvm qemu_fclose()

2017-06-15 Thread Stefan Hajnoczi
migration_incoming_state_destroy() uses qemu_fclose() on the vmstate file. Make sure to call it inside an AioContext acquire/release region. This fixes an 'qemu: qemu_mutex_unlock: Operation not permitted' abort in loadvm. This patch closes the vmstate file before ending the drained region.

[Qemu-devel] [PATCH v2 3/3] migration: add bitmap for received page

2017-06-15 Thread Alexey Perevalov
This patch adds ability to track down already received pages, it's necessary for calculation vCPU block time in postcopy migration feature, maybe for restore after postcopy migration failure. Also it's necessary to solve shared memory issue in postcopy livemigration. Information about received

[Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function

2017-06-15 Thread Stefan Hajnoczi
Avoid duplicating the QEMU command-line. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/068 | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/068 b/tests/qemu-iotests/068 index 9c1687d..653e23c 100755 ---

[Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!)

2017-06-15 Thread Stefan Hajnoczi
This series extends qemu-iotests 068 to also run with iothread enabled. Doing so was harder than expected because: 1. ioeventfd is disabled without -M accel=kvm even though it should work 2. loadvm still has an iothread bug Instead of adding a ./check -iothread option I decided to always run

[Qemu-devel] [PATCH v2 0/3] Add bitmap for received pages in postcopy migration

2017-06-15 Thread Alexey Perevalov
This is second version of [PATCH v1 0/2] Add bitmap for copied pages in postcopy migration cover message from there This is a separate patch set, it derived from https://www.mail-archive.com/qemu-devel@nongnu.org/msg456004.html There are several possible use cases: 1. solve issue with postcopy

[Qemu-devel] [PATCH v2 1/3] migration: postcopy_place_page factoring out

2017-06-15 Thread Alexey Perevalov
Need to mark copied pages as closer as possible to the place where it tracks down. That will be necessary in futher patch. Reviewed-by: Juan Quintela Signed-off-by: Alexey Perevalov --- migration/postcopy-ram.c | 13 -

[Qemu-devel] [PATCH v2 2/3] migration: introduce qemu_ufd_copy_ioctl helper

2017-06-15 Thread Alexey Perevalov
Just for placing auxilary operations inside helper, auxilary operations like: track received pages, notify about copying operation in futher patches. Signed-off-by: Alexey Perevalov --- migration/postcopy-ram.c | 35 ++- 1 file changed,

Re: [Qemu-devel] ahci-test failures with 'Failed to get "write" lock'

2017-06-15 Thread John Snow
On 06/15/2017 11:28 AM, Dr. David Alan Gilbert wrote: > Hi, > Peter noticed that there were some hangs in the ahci-test; > I can reproduce them on my laptop as long as the laptop has > some other load on it (a few md5sum /dev/zero's help). > > /x86_64/ahci/flush/migrate: qemu-system-x86_64:

Re: [Qemu-devel] [PATCH 05/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-15 Thread Roman Kagan
On Thu, Jun 15, 2017 at 03:27:28PM +0200, Igor Mammedov wrote: > On Thu, 15 Jun 2017 15:41:08 +0300 > Roman Kagan wrote: > > On Wed, Jun 14, 2017 at 03:00:27PM +0200, Igor Mammedov wrote: > > > On Wed, 14 Jun 2017 13:26:44 +0200 > > > Paolo Bonzini

Re: [Qemu-devel] [PATCH 5/5] target/s390x: mark CSST, CSST2, FPSEH facilities as available

2017-06-15 Thread Richard Henderson
On 06/15/2017 02:02 AM, Thomas Huth wrote: On 15.06.2017 07:53, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/s390x/cpu_models.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index

Re: [Qemu-devel] [PATCH v3 06/10] docs: add qemu-clock documentation

2017-06-15 Thread Edgar E. Iglesias
On Tue, Feb 28, 2017 at 11:03:01AM +0100, fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This adds the qemu-clock documentation. Hi Fred > > Signed-off-by: KONRAD Frederic > > V1 -> V2: > * Fixed in accordance with the

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-15 Thread KONRAD Frederic
Le 15/06/2017 à 17:15, Edgar E. Iglesias a écrit : On Thu, Jun 15, 2017 at 04:04:56PM +0100, Peter Maydell wrote: On 15 June 2017 at 15:57, Edgar E. Iglesias wrote: On Thu, Jun 15, 2017 at 03:40:40PM +0100, Peter Maydell wrote: Unfortunately we make no guarantees

Re: [Qemu-devel] [PULL 0/3] Queued s390x tcg patches

2017-06-15 Thread Peter Maydell
On 13 June 2017 at 21:26, Richard Henderson wrote: > Cleanups and fixes from David Hildenbrand. > > > r~ > > > > The following changes since commit 3f0602927b120a480b35dcf58cf6f95435b3ae91: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20170613'

[Qemu-devel] ahci-test failures with 'Failed to get "write" lock'

2017-06-15 Thread Dr. David Alan Gilbert
Hi, Peter noticed that there were some hangs in the ahci-test; I can reproduce them on my laptop as long as the laptop has some other load on it (a few md5sum /dev/zero's help). /x86_64/ahci/flush/migrate: qemu-system-x86_64: Failed to get "write" lock Is another process using the image? OK

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-15 Thread Edgar E. Iglesias
On Thu, Jun 15, 2017 at 04:04:56PM +0100, Peter Maydell wrote: > On 15 June 2017 at 15:57, Edgar E. Iglesias wrote: > > On Thu, Jun 15, 2017 at 03:40:40PM +0100, Peter Maydell wrote: > >> Unfortunately we make no guarantees at all about migration order > >> for devices

[Qemu-devel] [PATCH] target/mips: fix msa copy_[s|u]_df rd = 0 corner case

2017-06-15 Thread Miodrag Dinic
From: Miodrag Dinic This patch fixes the msa copy_[s|u]_df instruction emulation when the destination register rd is zero. Without this patch the zero register would get clobbered, which should never happen because it is supposed to be hardwired to 0. Fix this corner

[Qemu-devel] Guest unresponsive after Virtqueue size exceeded error

2017-06-15 Thread Fernando Casas Schössow
Hi there, I recently migrated a Hyper-V host to qemu/kvm runing on Alpine Linux 3.6.1 (kernel 4.9.30 -with grsec patches- and qemu 2.8.1). Almost on daily basis at least one of the guests is showing the following error in the log and the it needs to be terminated and restarted to recover it:

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-15 Thread Peter Maydell
On 15 June 2017 at 15:57, Edgar E. Iglesias wrote: > On Thu, Jun 15, 2017 at 03:40:40PM +0100, Peter Maydell wrote: >> Unfortunately we make no guarantees at all about migration order >> for devices as far as I'm aware, so devices have to cope regardless. > > > How does

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-15 Thread Edgar E. Iglesias
On Thu, Jun 15, 2017 at 03:40:40PM +0100, Peter Maydell wrote: > On 14 June 2017 at 12:54, Paolo Bonzini wrote: > > I think the various bindings and rates could be refreshed as devices are > > migrated. This assumes that the device migration order is okay > > according to

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-15 Thread Paolo Bonzini
On 15/06/2017 16:40, Peter Maydell wrote: > On 14 June 2017 at 12:54, Paolo Bonzini wrote: >> I think the various bindings and rates could be refreshed as devices are >> migrated. This assumes that the device migration order is okay >> according to the clock tree > >

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-15 Thread Peter Maydell
On 14 June 2017 at 12:54, Paolo Bonzini wrote: > I think the various bindings and rates could be refreshed as devices are > migrated. This assumes that the device migration order is okay > according to the clock tree, that is if you have three devices X/Y/Z and > five clocks

Re: [Qemu-devel] [PATCH v2 3/5] target/mips: Exit after enabling interrupts

2017-06-15 Thread Paolo Bonzini
On 15/06/2017 10:57, Alex Bennée wrote: >> +/* BS_STOP isn't good enough here; >> + reevaluate cpu_mips_hw_interrupts_enabled. */ > nit: technically we want to ensure mips_cpu_exec_interrupt is run (which > calls cpu_mips_hw_interrupts_enabled) Right, that's why

Re: [Qemu-devel] [PATCH v3 03/13] char: chardevice hotswap

2017-06-15 Thread Anton Nefedov
On 06/13/2017 03:32 PM, Marc-André Lureau wrote: Hi On Tue, Jun 13, 2017 at 3:53 PM Anton Nefedov > wrote: > The existing chr_write_lock belongs to Chardev. > For the hotswap case, we need to ensure that

Re: [Qemu-devel] [PATCH v3 3/4] migration: avoid recursive AioContext locking in save_vmstate()

2017-06-15 Thread Pavel Butsykin
On 14.06.2017 17:43, Kevin Wolf wrote: Am 14.06.2017 um 15:15 hat Pavel Butsykin geschrieben: On 14.06.2017 13:10, Pavel Butsykin wrote: On 22.05.2017 16:57, Stefan Hajnoczi wrote: AioContext was designed to allow nested acquire/release calls. It uses a recursive mutex so callers don't need

[Qemu-devel] spapr guests warn "System page size 0x2000 is not enabled in page_size_mask (0x11000). Performance may be slow" on SPARC hosts

2017-06-15 Thread Peter Maydell
I've just noticed that on a SPARC host, some of the PPC guests warn during make check: /ppc64/prom-env/pseries: qemu-system-ppc64: System page size 0x2000 is not enabled in page_size_mask (0x11000). Performance may be slow Is this really a performance problem on a TCG guest? It makes the 'make

Re: [Qemu-devel] [PATCH 05/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-15 Thread Igor Mammedov
On Thu, 15 Jun 2017 15:41:08 +0300 Roman Kagan wrote: > On Wed, Jun 14, 2017 at 03:00:27PM +0200, Igor Mammedov wrote: > > On Wed, 14 Jun 2017 13:26:44 +0200 > > Paolo Bonzini wrote: > > > > > On 14/06/2017 13:25, Roman Kagan wrote: > > > >> The

Re: [Qemu-devel] [PATCH 05/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-15 Thread Paolo Bonzini
On 15/06/2017 14:41, Roman Kagan wrote: > On Wed, Jun 14, 2017 at 03:00:27PM +0200, Igor Mammedov wrote: >> On Wed, 14 Jun 2017 13:26:44 +0200 >> Paolo Bonzini wrote: >> >>> On 14/06/2017 13:25, Roman Kagan wrote: > The problem with that is that it will break as soon as

Re: [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features

2017-06-15 Thread David Hildenbrand
>> A "sane" guest (e.g. Linux) will only use an instruction if the >> corresponding stfl(e) bit is set. So in my opinion, this should be just >> fine. If the bit is not set currently, the guest will not use it == dead >> code. > > Not necessarily. Depending on the distribution, gcc and hence

Re: [Qemu-devel] [PATCH qemu v8 1/2] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-06-15 Thread David Gibson
On Wed, Jun 14, 2017 at 04:36:06PM +1000, Alexey Kardashevskiy wrote: > This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion > as a parent. > > This moves IOMMU-related fields from MR to IOMMU MR. However to avoid > dymanic QOM casting in fast path (address_space_translate, etc), >

Re: [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features

2017-06-15 Thread Aurelien Jarno
On 2017-06-15 13:28, David Hildenbrand wrote: > On 15.06.2017 09:01, Aurelien Jarno wrote: > > On 2017-06-14 22:53, Richard Henderson wrote: > >> Signed-off-by: Richard Henderson > >> --- > >> target/s390x/translate.c | 8 > >> 1 file changed, 8 insertions(+) > >> > >>

Re: [Qemu-devel] [PATCH 05/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-15 Thread Roman Kagan
On Wed, Jun 14, 2017 at 03:00:27PM +0200, Igor Mammedov wrote: > On Wed, 14 Jun 2017 13:26:44 +0200 > Paolo Bonzini wrote: > > > On 14/06/2017 13:25, Roman Kagan wrote: > > >> The problem with that is that it will break as soon as we create > > >> VCPUs in a different order.

Re: [Qemu-devel] [PULL 0/7] ui patch queue

2017-06-15 Thread Peter Maydell
On 13 June 2017 at 11:41, Gerd Hoffmann wrote: > Which systems are failing? Any chance this is just gtk3-devel missing? > gtk 3.0 was released more than five years ago, pretty much every distro > should have packages meanwhile ... I've gone through and checked, and yes, it

Re: [Qemu-devel] [PATCH 05/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-15 Thread Roman Kagan
On Thu, Jun 15, 2017 at 01:42:56PM +0200, Paolo Bonzini wrote: > > > On 15/06/2017 13:40, Roman Kagan wrote: > > On Thu, Jun 15, 2017 at 10:26:58AM +0200, Paolo Bonzini wrote: > >> On 14/06/2017 20:59, Eduardo Habkost wrote: > >>> On Wed, Jun 14, 2017 at 09:40:37PM +0300, Roman Kagan wrote: >

Re: [Qemu-devel] [PULL 0/5] Migration PULL request

2017-06-15 Thread Peter Maydell
On 14 June 2017 at 12:51, Juan Quintela wrote: > Hi > > In this pull requset: > - I included the v1 of peter return path, fix it > - fix the compliation with older compilers (new compliers don't >complain about a repeated typedef, so I didn't noticed) > - Add test for

Re: [Qemu-devel] [PATCH 05/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-15 Thread Paolo Bonzini
On 15/06/2017 13:40, Roman Kagan wrote: > On Thu, Jun 15, 2017 at 10:26:58AM +0200, Paolo Bonzini wrote: >> On 14/06/2017 20:59, Eduardo Habkost wrote: >>> On Wed, Jun 14, 2017 at 09:40:37PM +0300, Roman Kagan wrote: One more data point is that until now there was no use for vp_index in

Re: [Qemu-devel] [PATCH 05/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-15 Thread Roman Kagan
On Thu, Jun 15, 2017 at 10:26:58AM +0200, Paolo Bonzini wrote: > On 14/06/2017 20:59, Eduardo Habkost wrote: > > On Wed, Jun 14, 2017 at 09:40:37PM +0300, Roman Kagan wrote: > >> One more data point is that until now there was no use for vp_index in > >> QEMU, so it didn't care how KVM managed it.

Re: [Qemu-devel] [PATCH v2 2/2] target/s390x: implement mvcos instruction

2017-06-15 Thread David Hildenbrand
>> >> +#ifndef CONFIG_USER_ONLY >> +static void fast_memmove_idx(CPUS390XState *env, uint64_t dest, uint64_t >> src, >> + uint32_t len, int dest_idx, int src_idx, >> + uintptr_t ra) >> +{ >> +TCGMemOpIdx oi_dest =

Re: [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features

2017-06-15 Thread David Hildenbrand
On 15.06.2017 09:01, Aurelien Jarno wrote: > On 2017-06-14 22:53, Richard Henderson wrote: >> Signed-off-by: Richard Henderson >> --- >> target/s390x/translate.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/target/s390x/translate.c

[Qemu-devel] [PULL 39/41] qemu-doc: include version number

2017-06-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile | 17 + qemu-doc.texi | 5 +++-- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/Makefile b/Makefile index c27389a..b017e3a 100644 --- a/Makefile +++ b/Makefile @@ -669,33 +669,26 @@

[Qemu-devel] [PULL 40/41] vhost-user-scsi: Introduce vhost-user-scsi host device

2017-06-15 Thread Paolo Bonzini
From: Felipe Franciosi This commit introduces a vhost-user device for SCSI. This is based on the existing vhost-scsi implementation, but done over vhost-user instead. It also uses a chardev to connect to the backend. Unlike vhost-scsi (today), VMs using vhost-user-scsi can be

[Qemu-devel] [PULL 41/41] vhost-user-scsi: Introduce a vhost-user-scsi sample application

2017-06-15 Thread Paolo Bonzini
From: Felipe Franciosi This commit introduces a vhost-user-scsi backend sample application. It must be linked with libiscsi and libvhost-user. To use it, compile with: $ make vhost-user-scsi And run as follows: $ ./vhost-user-scsi -u vus.sock -i iscsi://uri_to_target/

[Qemu-devel] [PULL 37/41] include/exec/poison: Mark some CONFIG defines as poisoned, too

2017-06-15 Thread Paolo Bonzini
From: Thomas Huth These are defined in config-target.h and thus should never be used in common code. Signed-off-by: Thomas Huth Message-Id: <1497468113-2874-3-git-send-email-th...@redhat.com> Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 30/41] nbd/server: refactor nbd_co_receive_request

2017-06-15 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy Move function tail, about receiving next request out of the function. Error path is simplified and nbd_co_receive_request becomes more corresponding to its name. Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PULL 38/41] docs: create interop/ subdirectory

2017-06-15 Thread Paolo Bonzini
This is for the future interoperability & management guide. It includes the QAPI docs, including the automatically generated ones, other socket protocols (vhost-user, VNC), and the qcow2 file format. Signed-off-by: Paolo Bonzini --- .gitignore

[Qemu-devel] [PULL 36/41] include/exec/poison: Add missing TARGET defines

2017-06-15 Thread Paolo Bonzini
From: Thomas Huth Since we've got some new CPU targets in QEMU during the last months and years, we've got some new TARGET_xxx defines now which should be marked as poisoned for common code. Signed-off-by: Thomas Huth Message-Id:

[Qemu-devel] [PULL 27/41] nbd/server: get rid of ssize_t

2017-06-15 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy Now nbd_read and friends return int, so get rid of ssize_t. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 33/41] nbd/server: get rid of fail: return rc

2017-06-15 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy "goto fail" error handling scheme is not needed for just returning error code. Better is return it immediately. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake

[Qemu-devel] [PULL 32/41] nbd/server: nbd_negotiate: fix error path

2017-06-15 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy Current code will return 0 on this nbd_write fail, as rc is 0 after successful nbd_negotiate_options. Fix this. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake

[Qemu-devel] [PULL 23/41] accel: move kvm related accelerator files into accel/

2017-06-15 Thread Paolo Bonzini
From: Yang Zhong move kvm related accelerator files into accel/ subdirectory, also create one stub subdirectory, which will include accelerator's stub files. Signed-off-by: Yang Zhong Message-Id:

[Qemu-devel] [PULL 34/41] nbd/server: rename rc to ret

2017-06-15 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy For consistency use 'ret' name for saving return code everywhere in the file. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 35/41] nbd/server: refactor nbd_trip

2017-06-15 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy - do not use 'goto error_reply' outside a switch to jump into the middle of the switch's default case label - reduce code duplication Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake

[Qemu-devel] [PULL 29/41] nbd/server: get rid of EAGAIN dead code

2017-06-15 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy For now nbd_read never returns EAGAIN. So, don't handle it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 07/41] megasas: add qtest

2017-06-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +++ tests/megasas-test.c | 51 ++ 2 files changed, 54 insertions(+) create mode 100644 tests/megasas-test.c diff --git a/tests/Makefile.include

[Qemu-devel] [PULL 21/41] tcg: move tcg related files into accel/tcg/ subdirectory

2017-06-15 Thread Paolo Bonzini
From: Yang Zhong move cputlb.c, cpu-exec-common.c and cpu-exec.c related tcg exec file into accel/tcg/ subdirectory. Signed-off-by: Yang Zhong Message-Id: <1496383606-18060-3-git-send-email-yang.zh...@intel.com> Signed-off-by: Paolo Bonzini

  1   2   >