Re: [Qemu-devel] [Qemu devel v6 PATCH 1/5] msf2: Add Smartfusion2 System timer

2017-07-06 Thread sundeep subbaraya
Hi Alistair, On Wed, Jul 5, 2017 at 11:26 PM, Alistair Francis wrote: > On Sun, Jul 2, 2017 at 9:45 PM, Subbaraya Sundeep > wrote: > > Modelled System Timer in Microsemi's Smartfusion2 Soc. > > Timer has two 32bit down counters and two interrupts. > > > > Signed-off-by: Subbaraya Sundeep > > -

Re: [Qemu-devel] [PATCH v2.2 3/4] doc: add item for "-M enforce-config-section"

2017-07-06 Thread Greg Kurz
On Fri, 7 Jul 2017 10:54:08 +0800 Peter Xu wrote: > It's never documented, and now we have one more parameter for it (which > obsoletes this one). Document it properly. > > Although now when enforce-config-section is set, it'll override the > other "-global" parameter, that is not necessarily a

Re: [Qemu-devel] [RFC 1/1] qemu-ga: add missing libpcre to MSI build

2017-07-06 Thread Thomas Lamprecht
Hi, On 06/02/2017 01:42 PM, Marc-André Lureau wrote: Hi On Thu, Jun 1, 2017 at 5:08 PM Thomas Lamprecht wrote: glib depends on libpcre which was not shipped with the MSI, thus starting of the qemu-ga.exe failed with the respective error message. Tell WIXL to ship this library with the MSI to

Re: [Qemu-devel] [PATCH v14] migration: spapr: migrate pending_events of spapr state

2017-07-06 Thread David Gibson
On Tue, Jun 20, 2017 at 03:40:17PM -0300, Daniel Henrique Barboza wrote: > In racing situations between hotplug events and migration operation, > a rtas hotplug event could have not yet be delivered to the source > guest when migration is started. In this case the pending_events of > spapr state ne

Re: [Qemu-devel] [RFC 5/5] vifo: introduce new VFIO ioctl VFIO_DEVICE_PCI_GET_DIRTY_BITMAP

2017-07-06 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Saturday, July 1, 2017 1:00 AM > > On Fri, 30 Jun 2017 05:14:40 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Friday, June 30, 2017 4:57 AM > > > > > > On Thu, 29 Jun

Re: [Qemu-devel] [PATCH 2/4] net/colo-compare.c: compare tcp packet base on sequence number

2017-07-06 Thread Zhang Chen
On 07/07/2017 02:20 PM, Li Zhijian wrote: this title confused me i think you want to express "only compare the packets that has the same sequence number" OK, I will fix it in next version. and i think this optimization can not reduce this checkpoint optimization. In my test it can r

Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

2017-07-06 Thread Greg Kurz
On Thu, 6 Jul 2017 16:49:44 -0700 Alistair Francis wrote: > Convert all uses of error_report("[Ww]arning:"... to use warn_report() > instead. This helps standardise on a single method of printing warnings > to the user. > > All of the warnings were found using this regex expression: > error_

Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

2017-07-06 Thread Thomas Huth
On 07.07.2017 01:49, Alistair Francis wrote: > Convert all uses of error_report("[Ww]arning:"... to use warn_report() > instead. This helps standardise on a single method of printing warnings > to the user. > > All of the warnings were found using this regex expression: > error_report.*[Ww]arn

Re: [Qemu-devel] [PATCH 1/4] net/colo-compare.c: Add checkpoint min period to optimize performance

2017-07-06 Thread Zhang Chen
On 07/07/2017 02:06 PM, Li Zhijian wrote: On 07/07/2017 01:43 PM, Zhang Chen wrote: If colo-compare find out the first different packet at this situation, why not trigger the checkpoint, and then flush all primary packets and drop secondary packets? In this time we already do this job, b

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Bharat Bhushan
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Friday, July 07, 2017 2:47 AM > To: Bharat Bhushan ; Jean-Philippe Brucker > ; eric.auger@gmail.com; > peter.mayd...@linaro.org; alex.william...@redhat.com; m...@redhat.com; > qemu-...@nongnu.org; q

Re: [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling

2017-07-06 Thread Markus Armbruster
PS: Sorry for the late review, got a bit overwhelmed...

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Tian, Kevin
> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] > Sent: Wednesday, July 5, 2017 8:45 PM > > On 05/07/17 08:14, Tian, Kevin wrote: > >> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] > >> Sent: Monday, June 19, 2017 6:15 PM > >> > >> On 19/06/17 08:54, Bhara

Re: [Qemu-devel] [PATCH 2/4] net/colo-compare.c: compare tcp packet base on sequence number

2017-07-06 Thread Li Zhijian
this title confused me i think you want to express "only compare the packets that has the same sequence number" and i think this optimization can not reduce this checkpoint optimization. Thanks On 07/07/2017 01:43 PM, Zhang Chen wrote: If primary packet's sequence number not same with secon

Re: [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling

2017-07-06 Thread Markus Armbruster
Pradeep Jagadeesh writes: > These patches provide the qmp interface, to query the io throttle > status of the all fsdev devices that are present in a vm. > also, it provides an interface to set the io throttle parameters of a > fsdev to a required value. some of the patches also remove the dupli

Re: [Qemu-devel] [PATCH 1/4] net/colo-compare.c: Add checkpoint min period to optimize performance

2017-07-06 Thread Li Zhijian
On 07/07/2017 01:43 PM, Zhang Chen wrote: If colo-compare find out the first different packet at this situation, why not trigger the checkpoint, and then flush all primary packets and drop secondary packets? that means the following packet almost is different. we needn't do a lot of chec

[Qemu-devel] [PATCH 1/4] net/colo-compare.c: Add checkpoint min period to optimize performance

2017-07-06 Thread Zhang Chen
If colo-compare find out the first different packet that means the following packet almost is different. we needn't do a lot of checkpoint in this time, so we set the no-need-checkpoint peroid, default just set 3 second. Signed-off-by: Zhang Chen --- net/colo-compare.c | 13 - 1 file

[Qemu-devel] [PATCH 2/4] net/colo-compare.c: compare tcp packet base on sequence number

2017-07-06 Thread Zhang Chen
If primary packet's sequence number not same with secondary packet's sequence number, no need to compare the packet other field. Signed-off-by: Zhang Chen --- net/colo-compare.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index 0f8e198..2caeb

[Qemu-devel] [PATCH 4/4] net/colo-compare.c: Adjust net queue pop order for performance

2017-07-06 Thread Zhang Chen
The packet_enqueue() use g_queue_push_tail() to enqueue net packet, so it is more efficent way use g_queue_pop_head() to get packet for compare. That will improve the success rate of comparison. In my test the performance of ftp put 1000M file will increase 10% Signed-off-by: Zhang Chen --- net/

[Qemu-devel] [PATCH 0/4] Optimize COLO-compare performance

2017-07-06 Thread Zhang Chen
In this serise, we do a lot of job to optimize COLO net performance. Mainly focus on TCP protocol. Zhang Chen (4): net/colo-compare.c: Add checkpoint min period to optimize performance net/colo-compare.c: compare tcp packet base on sequence number net/colo-compare.c: Optimize unpredictable

[Qemu-devel] [PATCH 3/4] net/colo-compare.c: Optimize unpredictable tcp options comparison

2017-07-06 Thread Zhang Chen
When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just care about packet payload, so we skip the option field. Signed-off-by: Zhang Chen --- net/colo-com

[Qemu-devel] 答复: Re: [PATCH] tcg/mips: Bugfix for crash when runningprogram with qemu-i386.

2017-07-06 Thread jiang.biao2
> > This is wrong, because you're not allowed to modify the input operands. > > Try this, just a few lines lower in the function: > > -tcg_out_movi(s, TCG_TYPE_PTR, base, guest_base) > -tcg_out_opc_reg(s, ALIAS_PADD, base, base, addr_regl) > +tcg_out_movi(s, TCG_TYPE_PT

Re: [Qemu-devel] [PATCH] tcg/mips: Bugfix for crash when running program with qemu-i386.

2017-07-06 Thread Richard Henderson
On 07/06/2017 05:15 PM, Jiang Biao wrote: When running a helloworld program with qemu-i386 in linux-user mode on Loongson 3A3000, it will crash. This patch fix the bug. Signed-off-by: Jiang Biao --- tcg/mips/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PATCH] tcg/mips: Bugfix for crash when running program with qemu-i386.

2017-07-06 Thread Jiang Biao
When running a helloworld program with qemu-i386 in linux-user mode on Loongson 3A3000, it will crash. This patch fix the bug. Signed-off-by: Jiang Biao --- tcg/mips/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-targ

Re: [Qemu-devel] [PATCH v4 19/21] block: Make bdrv_is_allocated() byte-based

2017-07-06 Thread Eric Blake
On 07/06/2017 11:02 AM, Kevin Wolf wrote: >> +++ b/qemu-img.c >> @@ -3229,6 +3229,7 @@ static int img_rebase(int argc, char **argv) >> int64_t new_backing_num_sectors = 0; >> uint64_t sector; >> int n; >> +int64_t count; >> float local_progress = 0; >> >

[Qemu-devel] [PATCH v2.2 3/4] doc: add item for "-M enforce-config-section"

2017-07-06 Thread Peter Xu
It's never documented, and now we have one more parameter for it (which obsoletes this one). Document it properly. Although now when enforce-config-section is set, it'll override the other "-global" parameter, that is not necessarily a rule. Forbid that usage in the document. Suggested-by: Eduard

[Qemu-devel] [PATCH v2 26/27] target/sh4: Implement fsrra

2017-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sh4/helper.h| 1 + target/sh4/op_helper.c | 16 target/sh4/translate.c | 2 ++ 3 files changed, 19 insertions(+) diff --git a/target/sh4/helper.h b/target/sh4/helper.h index 6c6fa04..ea92dc0 100644 --- a/target/sh4/helper.h +++ b

[Qemu-devel] [PATCH v2 25/27] target/sh4: Add missing FPSCR.PR == 0 checks

2017-07-06 Thread Richard Henderson
Both frchg and fschg require PR == 0, otherwise undefined_operation. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 35a5c91..2b62e39 100644 --- a/target/sh4/translate.c +++ b/

[Qemu-devel] [PATCH v2 21/27] target/sh4: Tidy misc illegal insn checks

2017-07-06 Thread Richard Henderson
Now that we have a do_illegal label, use goto in order to self-document the forcing of the exception. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/transl

[Qemu-devel] [PATCH v2 24/27] target/sh4: Implement fpchg

2017-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sh4/translate.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index d164e62..35a5c91 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -492,6 +492,11 @@ static void _decode_opc

[Qemu-devel] [PATCH v2 18/27] target/sh4: Unify code for CHECK_NOT_DELAY_SLOT

2017-07-06 Thread Richard Henderson
We do not need to emit N copies of raising an exception. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 3453f19..41157a0 100644 --- a/target/sh4/tran

[Qemu-devel] [PATCH v2 19/27] target/sh4: Unify code for CHECK_PRIVILEGED

2017-07-06 Thread Richard Henderson
We do not need to emit N copies of raising an exception. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 41157a0..dd14b43 100644 --- a/target/sh4/

[Qemu-devel] [PATCH v2 23/27] target/sh4: Introduce CHECK_SH4A

2017-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sh4/translate.c | 64 +++--- 1 file changed, 29 insertions(+), 35 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 3d8ac59..d164e62 100644 --- a/target/sh4/translate.c +++ b/tar

[Qemu-devel] [PATCH v2 12/27] target/sh4: Pass DisasContext to fpr64 routines

2017-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sh4/translate.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index b521cff..878c0bd 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -

[Qemu-devel] [PATCH v2 27/27] target/sh4: Use tcg_gen_lookup_and_goto_ptr

2017-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sh4/translate.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 5fae872..7e80e10 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c

[Qemu-devel] [PATCH v2 17/27] target/sh4: Simplify 64-bit fp reg-reg move

2017-07-06 Thread Richard Henderson
We do not need to form full 64-bit quantities in order to perform the move. This reduces code expansion on 64-bit hosts. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/tr

[Qemu-devel] [PATCH v2 22/27] target/sh4: Introduce CHECK_FPSCR_PR_*

2017-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sh4/translate.c | 57 +++--- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 06cf649..3d8ac59 100644 --- a/target/sh4/translate.c +++ b/tar

[Qemu-devel] [PATCH v2 11/27] target/sh4: Unify cpu_fregs into FREG

2017-07-06 Thread Richard Henderson
We were treating FREG as an index and REG as a TCGv. Making FREG return a TCGv is both less confusing and a step toward cleaner banking of cpu_fregs. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 125 - 1 file changed, 52 insertions

[Qemu-devel] [PATCH v2 20/27] target/sh4: Unify code for CHECK_FPU_ENABLED

2017-07-06 Thread Richard Henderson
We do not need to emit N copies of raising an exception. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index dd14b43..a4370c6 100644 --- a/

[Qemu-devel] [PATCH v2 15/27] target/sh4: Merge DREG into fpr64 routines

2017-07-06 Thread Richard Henderson
Also add a debugging assert that we did signal illegal opc for odd double-precision registers. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translat

[Qemu-devel] [PATCH v2 13/27] target/sh4: Hoist fp register bank selection

2017-07-06 Thread Richard Henderson
Compute which register bank to use once at the start of translation. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 878c0bd..fc743da 100644 --- a/target/

[Qemu-devel] [PATCH v2 06/27] target/sh4: Handle user-space atomics

2017-07-06 Thread Richard Henderson
For uniprocessors, SH4 uses optimistic restartable atomic sequences. Upon an interrupt, a real kernel would simply notice magic values in the registers and reset the PC to the start of the sequence. For QEMU, we cannot do this in quite the same way. Instead, we notice the normal start of such a s

[Qemu-devel] [PATCH v2 16/27] target/sh4: Load/store Dr as 64-bit quantities

2017-07-06 Thread Richard Henderson
This enforces proper alignment and makes the register update more natural. Note that there is a more serious bug fix for fmov {DX}Rn,@(R0,Rn) to use a store instead of a load. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 74 -- 1

[Qemu-devel] [PATCH v2 08/27] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread Richard Henderson
We translate gUSA regions atomically in a parallel context. But in a serial context a gUSA region may be interrupted. In that case, restart the region as the kernel would. Signed-off-by: Richard Henderson --- linux-user/signal.c | 23 +++ 1 file changed, 23 insertions(+) dif

[Qemu-devel] [PATCH v2 14/27] target/sh4: Eliminate unused XREG macro

2017-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sh4/translate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index fc743da..b6c3ff9 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -369,7 +369,6 @@ static inline void gen_store_f

[Qemu-devel] [PATCH v2 04/27] target/sh4: Keep env->flags clean

2017-07-06 Thread Richard Henderson
If we mask off any out-of-band bits before we assign to the variable, then we don't need to clean it up when reading. Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 2 +- target/sh4/cpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/sh4/cpu.h b/target/sh

[Qemu-devel] [PATCH v2 10/27] target/sh4: Hoist register bank selection

2017-07-06 Thread Richard Henderson
Compute which register bank to use once at the start of translation. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 73b3e02..0ac101e 1006

[Qemu-devel] [PATCH v2 05/27] target/sh4: Adjust TB_FLAG_PENDING_MOVCA

2017-07-06 Thread Richard Henderson
Don't leave an unused bit after DELAY_SLOT_MASK. Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h index 6d179a7..da31805 100644 --- a/target/sh4/cpu.h +++ b/target/sh4/cpu.h @@ -96,

[Qemu-devel] [PATCH v2 03/27] target/sh4: Introduce TB_FLAG_ENVFLAGS_MASK

2017-07-06 Thread Richard Henderson
We'll be putting more things into this bitmask soon. Let's have a name that covers all possible uses. Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 4 +++- target/sh4/translate.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/sh4/cpu.h b/target/sh

[Qemu-devel] [PATCH v2 09/27] linux-user/sh4: Clean env->flags on signal boundaries

2017-07-06 Thread Richard Henderson
If a signal is delivered during the execution of a delay slot, or a gUSA region, clear those bits from the environment so that the signal handler does not start in that same state. Cleaning the bits on signal return is paranoid good sense. Signed-off-by: Richard Henderson --- linux-user/signal.

[Qemu-devel] [PATCH v2 07/27] target/sh4: Recognize common gUSA sequences

2017-07-06 Thread Richard Henderson
For many of the sequences produced by gcc or glibc, we can translate these as host atomic operations. Which saves the need to acquire the exclusive lock. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 316 + 1 file changed, 316 inser

[Qemu-devel] [PATCH v2 02/27] target/sh4: Consolidate end-of-TB tests

2017-07-06 Thread Richard Henderson
We can fold 3 different tests within the decode loop into a more accurate computation of max_insns to start. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/target/sh4/translate.c b/ta

[Qemu-devel] [PATCH v2 01/27] target/sh4: Use cmpxchg for movco

2017-07-06 Thread Richard Henderson
As for other targets, cmpxchg isn't quite right for ll/sc, suffering from an ABA race, but is sufficient to implement portable atomic operations. Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 3 ++- target/sh4/translate.c | 56 +-

[Qemu-devel] [PATCH v2 00/27] target/sh4 improvements

2017-07-06 Thread Richard Henderson
This fixes two problems with atomic operations on sh4, including an attempt at supporting the user-space atomics technique used by most sh-linux-user binaries. Changes since v1: * Rebase on Aurelien's recent sh4 patchset. * Patch 3,5 split out of patch 6. * Patch 4 fixes the sh4-softmmu prob

[Qemu-devel] [Bug 1702798] Re: colo: secondary vm can't receive any packet

2017-07-06 Thread pork-prince
The qemu version is 2.9.0 release. The secondary vm state make me confused. I tried to add vm_stop and vm_start in colo_process_incoming_thread function, but it crashed. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

2017-07-06 Thread Peter.Chubb
> "Alistair" == Alistair Francis writes: Alistair> Convert all uses of error_report("[Ww]arning:"... to use Alistair> warn_report() instead. This helps standardise on a single Alistair> method of printing warnings to the user. In a number of cases the initial double quote has been removed as

Re: [Qemu-devel] [Qemu-arm] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Kalra, Ashish
I have a generic question on vIOMMU support, is there any proposal/plan to add ATS/PRI extension support to vIOMMUs and allow handling for end to end (v)IOMMU Page faults (w/t the device side implementation on Vhost) ? Again, the motivation will be to do DMA on paged guest memory and potentially

Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

2017-07-06 Thread David Gibson
On Thu, Jul 06, 2017 at 04:49:44PM -0700, Alistair Francis wrote: > Convert all uses of error_report("[Ww]arning:"... to use warn_report() > instead. This helps standardise on a single method of printing warnings > to the user. > > All of the warnings were found using this regex expression: >

[Qemu-devel] [Bug 1702798] [NEW] colo: secondary vm can't receive any packet

2017-07-06 Thread pork-prince
Public bug reported: Following document 'COLO-FT.txt', I test colo feature on my hosts. It seems goes well,but I found the secondary vm can't receive any packets. I attached the process and find out the reason as follow, the filter-redirector(red0) didn't flush it's queue because the secondary

Re: [Qemu-devel] [RFC PATCH 00/11] Block layer thread-safety, next part

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:48, no-re...@patchew.org wrote: > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170706163828.24082-1-pbonz...@redhat.com' which can not be > resolved as commit? > Traceback (most recent call last): > Fi

Re: [Qemu-devel] [PATCH v2 00/11] Block layer thread-safety, part 2

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:50, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170629132749.997-1-pbonz...@redhat.com' which can not be > resolved as c

Re: [Qemu-devel] [PATCH] block: fix bs->file leak in bdrv_new_open_driver()

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170629060300.29869-1-el13...@mail.ntua.gr' which can not be > resolved a

Re: [Qemu-devel] [PATCH v1 0/3] Some armv7m fixes

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/1498728533-23160-1-git-send-email-frederic.kon...@adacore.com' > which can

Re: [Qemu-devel] [RFC v1 0/4] Windows runtime improvements

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:48, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/cover.1498607452.git.alistair.fran...@xilinx.com' which can > not be resol

Re: [Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:50, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping > function support > Message-id: 1498715394-16402-1-git-send-em

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170629010300.2848-1-f4...@amsat.org' which can not be > resolved as comm

Re: [Qemu-devel] [PATCH] target/ppc: Only set PCR in kvm if actually in a compat mode

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170629045940.11242-1-sjitindarsi...@gmail.com' which can > not be resolv

Re: [Qemu-devel] [PATCH v3 0/2] main_loop: Make main_loop_wait() return void

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:48, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/1498584769-12439-1-git-send-email-peter.mayd...@linaro.org' > which can no

Re: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension > Message-id: 1498733831-15254-1-git-send-email...@kamp.de > Type:

[Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

2017-07-06 Thread Alistair Francis
Convert all uses of error_report("[Ww]arning:"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were found using this regex expression: error_report.*[Ww]arning: and replaced with: warn_report(" Signed-off-by:

Re: [Qemu-devel] [PATCH 0/2] Pending MTTCG patches

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170629071129.29362-1-bobby.pr...@gmail.com' which can not > be resolved

Re: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Subject: [Qemu-devel] [PATCH] replace struct ucontext with u

[Qemu-devel] [PATCH v1 2/6] error: Functions to report warnings and informational messages

2017-07-06 Thread Alistair Francis
Add warn_report(), warn_vreport() for reporting warnings, and info_report(), info_vreport() for informational messages. These are implemented them with a helper function factored out of error_vreport(), suitably generalized. As we don't regard error messages as a stable API the original error mess

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:50, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/1498734863-164338-1-git-send-email-imamm...@redhat.com' which > can not be

[Qemu-devel] [PATCH v1 0/6] Implement a warning_report function

2017-07-06 Thread Alistair Francis
QEMU currently has a standard method to report errors with error_repot(). This ensure a sane and standard format when printing errors. This series is attempting to extend this functionality for warnings and information as well. This patch renames error_print_loc() function to be more clear, but I

Re: [Qemu-devel] [PATCH v2] docs: add qemu-block-drivers(7) man page

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:48, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: unable to access 'https://github.com/patchew-project/qemu/': Could not > resolve host: github.com > error: Could not fetch 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Traceback (most recent

[Qemu-devel] [PATCH v1 6/6] Convert error_report*_err() to warn_report*_err()

2017-07-06 Thread Alistair Francis
Convert all uses of error_report*_err("[Ww]arning:"... to use warn_report*_err() instead. This helps standardise on a single method of printing warnings to the user. Signed-off-by: Alistair Francis Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" --- hw/c

Re: [Qemu-devel] [PATCH] block: fix bs->file leak in bdrv_new_open_driver()

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] block: fix bs->file leak in bdrv_new_open_driver() Message-id: 20170629060300.29869-1-el13...@mail.ntua.gr Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCH v1 5/6] error: Implement the warn and free Error functions

2017-07-06 Thread Alistair Francis
Implement warn_report_err() and warn_reportf_err() functions which are the same as the error_report_err() and error_reportf_err() functions except report a warning instead of an error. Signed-off-by: Alistair Francis --- include/qapi/error.h | 11 +++ scripts/checkpatch.pl | 1 + util

Re: [Qemu-devel] [PATCH v2 00/11] Block layer thread-safety, part 2

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/11] Block layer thread-safety, part 2 Message-id: 20170629132749.997-1-pbonz...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$

Re: [Qemu-devel] [PATCH v2] docs: add qemu-block-drivers(7) man page

2017-07-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2] docs: add qemu-block-drivers(7) man page Message-id: 20170627154120.20346-1-stefa...@redhat.c

[Qemu-devel] [PATCH v1 4/6] char-socket: Report TCP socket waiting as information

2017-07-06 Thread Alistair Francis
When QEMU is waiting for a TCP socket connection it reports that message as an error. This isn't an error it is just information so let's change the report to use info_report() instead. Signed-off-by: Alistair Francis Reviewed-by: Thomas Huth --- chardev/char-socket.c | 4 ++-- 1 file changed,

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback Message-id: 1498734863-164338-1-git-send-email-imamm...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/b

[Qemu-devel] [PATCH v1 1/6] util/qemu-error: Rename error_print_loc() to be more generic

2017-07-06 Thread Alistair Francis
Rename the error_print_loc() function in preparation for using it to print warnings as well. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- util/qemu-error.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/qemu-err

Re: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type

2017-07-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type Message-id: 20170628204452.41230-1-raj.k...@gmail.c

Re: [Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support Message-id: 1498715394-16402-1-git-send-email-tianyu@intel.com Type: series === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH] target/ppc: Only set PCR in kvm if actually in a compat mode

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] target/ppc: Only set PCR in kvm if actually in a compat mode Message-id: 20170629045940.11242-1-sjitindarsi...@gmail.com Type: series === TEST SCRIPT BEGIN === #!/bin/b

Re: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension Message-id: 1498733831-15254-1-git-send-email...@kamp.de Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tot

Re: [Qemu-devel] [PATCH 0/2] Pending MTTCG patches

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/2] Pending MTTCG patches Message-id: 20170629071129.29362-1-bobby.pr...@gmail.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --on

Re: [Qemu-devel] [PATCH v1 0/3] Some armv7m fixes

2017-07-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v1 0/3] Some armv7m fixes Message-id: 1498728533-23160-1-git-send-email-frederic.kon...@adacore.c

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter) Message-id: 20170629010300.2848-1-f4...@amsat.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [RFC v1 0/4] Windows runtime improvements

2017-07-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [RFC v1 0/4] Windows runtime improvements Message-id: cover.1498607452.git.alistair.fran...@xilinx.com

Re: [Qemu-devel] [PATCH v3 0/2] main_loop: Make main_loop_wait() return void

2017-07-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v3 0/2] main_loop: Make main_loop_wait() return void Message-id: 1498584769-12439-1-git-send-ema

[Qemu-devel] [PATCH v3] xenfb: remove xen_init_display "temporary" hack

2017-07-06 Thread Stefano Stabellini
Initialize xenfb properly, as all other backends, from its own "initialise" function. Remove the dependency of vkbd on vfb: use qemu_console_lookup_by_index to find the principal console (to get the size of the screen) instead of relying on a vfb backend to be available (which adds a dependency be

Re: [Qemu-devel] [PATCH v4 04/17] dirty-bitmap: Drop unused functions

2017-07-06 Thread John Snow
On 07/03/2017 11:10 AM, Eric Blake wrote: > We had several functions that no one is currently using, and which > use sector-based interfaces. I'm trying to convert towards byte-based > interfaces, so it's easier to just drop the unused functions: > > bdrv_dirty_bitmap_get_meta > bdrv_dirty_bitm

Re: [Qemu-devel] [PATCH v2] xenfb: remove xen_init_display "temporary" hack

2017-07-06 Thread Stefano Stabellini
On Thu, 29 Jun 2017, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 28 June 2017 19:37 > > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > > Cc: sstabell...@kernel.org; peter.mayd...@linaro.org; Anthony Perard >

Re: [Qemu-devel] [Qemu-arm] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Tian, Kevin
> From: Kalra, Ashish [mailto:ashish.ka...@cavium.com] > Sent: Friday, July 7, 2017 7:24 AM > > I have a generic question on vIOMMU support, is there any proposal/plan to > add ATS/PRI extension support to vIOMMUs and allow > handling for end to end (v)IOMMU Page faults (w/t the device side > impl

Re: [Qemu-devel] [Qemu-arm] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2017 at 11:23:41PM +, Kalra, Ashish wrote: > I have a generic question on vIOMMU support, is there any proposal/plan to > add ATS/PRI extension support to vIOMMUs and allow > handling for end to end (v)IOMMU Page faults (w/t the device side > implementation on Vhost) ? > > Ag

Re: [Qemu-devel] [PATCH v3 2/6] block: Add VFIO based NVMe driver

2017-07-06 Thread Fam Zheng
On Thu, 07/06 13:38, Keith Busch wrote: > On Wed, Jul 05, 2017 at 09:36:31PM +0800, Fam Zheng wrote: > > This is a new protocol driver that exclusively opens a host NVMe > > controller through VFIO. It achieves better latency than linux-aio by > > completely bypassing host kernel vfs/block layer. >

Re: [Qemu-devel] [PATCH 8/9] target-mips: Implement segmentation control

2017-07-06 Thread James Hogan
On Thu, Oct 13, 2016 at 02:06:25PM +0100, Yongbok Kim wrote: > > > On 06/09/2016 12:03, James Hogan wrote: > > Implement the optional segmentation control feature in the virtual to > > physical address translation code. > > > > The fixed legacy segment and XKPhys handling is replaced with a dyna

Re: [Qemu-devel] [PATCH v4 03/17] qcow2: Ensure bitmap serialization is aligned

2017-07-06 Thread John Snow
On 07/03/2017 11:10 AM, Eric Blake wrote: > When subdividing a bitmap serialization, the code in hbitmap.c > enforces that start/count parameters are aligned (except that > count can end early at end-of-bitmap). We exposed this required > alignment through bdrv_dirty_bitmap_serialization_align()

  1   2   3   4   >